On Wed, Dec 09, 2009 at 08:14:24PM +0900, jassi brar wrote:
On Wed, Dec 9, 2009 at 8:09 PM, Mark Brown
- if (!request_mem_region(res->start, resource_size(res),
- "s3c64xx-i2s")) {
- dev_err(&pdev->dev, "Unable to request SFR region\n");
- return -EBUSY;
- }
This feels like it should be in the patch that requested the resource rather than here. Probably ought to have a version that does the request in 2.6.33 too if we can...
that patch is only for setting DMA channel and dst addresses, so we request MEM resource there.
I'm not sure I follow? In any case the real issue here is that looking at this change and it's hard to see how it's immediately related to the subject of the patch; it's not about how the data is passed and somewhat distant from the code which does do the passing.
A comment explaining why we're doing the subtraction wouldn't hurt; the code is OK.
its just that i didn't want to reorder the code and MEM resource was requested into a temporary variable 'res' not immediately before this call. At this point res->start should do too though.
Yes, I saw - all I'm saying is that putting a note in the code