On 7/22/20 11:47 PM, Vinod Koul wrote:
On 22-07-20, 10:36, Pierre-Louis Bossart wrote:
* and the stream properties
- @set_codec_params: Sets the compressed stream codec
parameters, Optional
- This can be called in during gapless next track codec change
only to set
- codec params
Would it be clearer if this was called set_next_codec_params()? or set_next_track_codec_params()?
Having set_params() and set_codec_params() is a bit confusing since the semantic difference is not captured in the callback name.
set_next_track_codec_params seems more sensible as its next track params. Will change this in next version!
maybe set_params() and set_next_track_params() are enough, not sure if the codec reference helps?
params typically refers to whole set of compress parameters which includes buffer information and codec parameters, so codec reference would help.
then add the codec reference to both...