On 8. 8. 2022, at 16:12, Martin Povišer povik+lin@cutebit.org wrote:
Because the PWR_CTRL field is modeled as the power state of the DAC widget, and at the same time it is used to implement mute/unmute, we need some additional book-keeping to have the right end result no matter the sequence of calls. Without this fix, one can mute an ongoing stream by toggling a speaker pin control.
Fixes: 1a476abc723e ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Martin Povišer povik+lin@cutebit.org
Ah, should have written the end of the commit message clearer... What I meant is, if you toggle the speaker pin, you mute the stream permanently until it's restarted, since toggling the speaker pin back won't recover the PWR_CTRL_ACTIVE value set in mute_stream at unmute.
Martin