Re: [alsa-devel] [PATCH 2/9] ASoC: sun4i-i2s: Add compatibility with A64 codec I2S

On Tue, Dec 05, 2017 at 03:04:19PM -0800, Vasily Khoruzhick wrote:

On Tue, Dec 5, 2017 at 12:01 AM, Maxime Ripard maxime.ripard@free-electrons.com wrote:

...

Hi,

On Sun, Dec 03, 2017 at 11:34:06PM -0800, Vasily Khoruzhick wrote:

...

I'd keep it sun50i_a64_acodec_i2s, since other 3 I2S modules aren't compatible with this one, but similar to H3.

Please don't top-post.

What are those differences?

Different registers and their locations. Compare quirks for sun50i_a64_acodec_i2s and sun8i_h3_i2s fro details.

Whatever differences should also be mentionned in your commit log.

Maxime