On Wed, Nov 16, 2011 at 01:56:47PM +0100, Daniel Mack wrote:
On 11/15/2011 03:13 PM, Mark Brown wrote:
Is this really a single driver? Looking at the code it looks like there's little if any code sharing between the different machines, it'd help with maintainability to have multiple simple drivers.
Hmm. This new version of Raumfeld's hardware features a new ADC and DAC, and the configuration to use is determined by looking at the system revision. If this would be split into multiple smaller drivers, there would be need for a 'master' to dispatch the possible options. I think
No, not really.
I'll do that once the next generation is about to land, and leave it as it is for now. Ok for you?
What I'd expect here is that the arch/arm code would register a different platform device depending on which board it's running on (though actually controlling I2C device registration is enough as ASoC won't probe the sound driver until the components appear).
- fmt = SND_SOC_DAIFMT_I2S |
SND_SOC_DAIFMT_NB_NF |SND_SOC_DAIFMT_CBS_CFS;
Set this using dai_fmt in hte machine driver.
Can you elaborate on this one? I couldn't find an example for this, sorry.
Look at the snd_soc_dai_link definition, and things like speyside.