On Wed, Jan 09, 2019 at 10:33:38AM +0100, Hans de Goede wrote:
Hi,
On 09-01-19 10:29, Dan Carpenter wrote:
I think the correct fix is actually this (untested):
Right, I'm pretty sure the soc framework depends on dev_get_drvdata returning the snd_soc_card and I forgot about this when adding the remove function.
Wei Yongjun, thank you for catching this.
Dan, thank you for the correct version of the patch :)
Dan, can you do an official submission of the correct version of the patch, with a Reported-by: Wei Yongjun weiyongjun1@huawei.com or shall I submit your version upstream ?
Wei can resend and get authorship credit. I only wrote the patch by accident because it was easier than explaining. (Or if you really don't want to, Wei, then message me and I will do it).
regards, dan carpenter