On Fri, Nov 20, 2020 at 04:56:34PM +0000, Mark Brown wrote:
On Fri, Nov 20, 2020 at 05:16:15PM +0100, Krzysztof Kozlowski wrote:
The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). This fixes compile warning (!CONFIG_OF on x86_64):
It would be better to fix these by annotating the table as potentially unused, if nothing else it means if someone wants to add ACPI support (or it just works on their ACPI system with the plain old I2C ID) then they don't need to revert this change.
The point is after this patch - removal of of_match_ptr() - they will already support the ACPI matching through the PRP0001.
Keeping of_match_ptr() and maybe_unused will prevent any ACPI re-usage unless explicit ACPI table is added
Best regards, Krzysztof