June 2025 - Alsa-devel - mailman.alsa-project.org

Re: [PATCH v1 1/4] ASoc: tac5x1x: add codec driver tac5x1x family
by Holalu Yogendra, Niranjan 10 Jun '25

10 Jun '25

> From: Mark Brown <broonie(a)kernel.org> > Sent: Friday, June 6, 2025 6:17 PM > Subject: Re: [PATCH v1 1/4] ASoc: tac5x1x: add codec driver > tac5x1x family > > On Fri, Jun 06, 2025 at 12:21:33PM +0530, Niranjan H Y wrote: ... > There's a few issues below but nothing that's *hugely* structural, the > bulk of the code here looks good. Thank you for your time and review comments. I will add fixes for most the comments in the next patch. Request you to take a look at some comments below. > > > +config SND_SOC_TAC5X1X > > + tristate "Texas Instruments TAC5X1X family codecs" > > + depends on I2C && REGMAP_I2C > > + > > +config SND_SOC_TAC5X1X_I2C > > + tristate "Texas Instruments TAC5X1X family driver based on I2C" > > + depends on I2C && REGMAP_I2C > > + select SND_SOC_TAC5X1X > > You need to select REGMAP_I2C if you use it, it can't be turned on > independently. If the device is I2C only then there's no need to have > the second option for I2C, that's used for devices that support both I2C > and SPI to avoid problems with dependencies on the I2C and SPI core > code. Many of these devices support SPI interface as well. So I thought I will make library and I2C interface file. But currently SPI support is not added in the driver. Is this okay to still keep this ? please suggest. ... > > > +static const char * const out_ch2_ltch[] = { > > + "OUT_CH2 OUT2P Short circuit Fault", > > + "OUT_CH2 OUT2M Short circuit Fault", > > + "OUT_CH2 DRVRP Virtual Ground Fault", > > + "OUT_CH2 DRVRM Virtual ground Fault", > > + "Reserved", > > + "Reserved", > > + "AREG SC Fault Mask", > > + "AREG SC Fault", > > +}; > > For ones where the reserved values are in the middle of the set of > values you can use _VAL_ENUM() which lets you skip over the values that > are invalid. Is there some example which I can refer? I could not find anything in the kernel source with _VAL_ENUM. I will try to refactor to avoid this. > > > +static s32 tac5x1x_regmap_write(struct tac5x1x_priv *tac5x1x, > > + u32 reg, u32 value) > > +{ > > + s32 ret; > > + s32 retry_count = 5; > > + > > + while (retry_count--) { > > + ret = regmap_write(tac5x1x->regmap, reg, > > + value); > > + if (ret >= 0) > > + break; > > + usleep_range(5000, 5050); > > + } > > + if (retry_count == -1) > > + return 3; > > + else > > + return ret; > > +} > > Is the hardware genuinely so unstable that we need to retry all the I/O? > This seems really concerning. I think this can be dropped as this is used for some legacy devices for some customer platforms. I will remove this in next patch and redo the tests. > > +static s32 tac5x1x_set_GPO1_gpio(struct snd_kcontrol *kcontrol, > > + struct snd_ctl_elem_value *ucontrol) > > +{ > > + struct snd_soc_component *component = > snd_kcontrol_chip(kcontrol); > > + s32 gpio_check, val; > > + > > + val = snd_soc_component_read(component, TAC5X1X_GPO1); > > + gpio_check = ((val & TAC5X1X_GPIOX_CFG_MASK) >> 0); > > + if (gpio_check != TAC5X1X_GPIO_GPO) { > > + dev_err(component->dev, > > + "%s: GPO1 is not configure as a GPO output\n", > > + __func__); > > + return -EINVAL; > > + } > > + > > + if (ucontrol->value.integer.value[0]) > > + val = 0; > > + else > > + val = TAC5X1X_GPO1_VAL; > > This seems to be exposing a GPIO directly to userspace, which will > prevent using that GPIO with other kernel subsystems. It would be > better to expose this via gpiolib, then if userspace control is needed > that can be done through gpiolib. Thanks for the suggestion. But, in our case, codec chip has some GPIO pins which are specific to the codec. We do not intend to expose to the other kernel subsystem. It is more of codec chip configuration to use these GPIO pins as - for e.g. daisy-chain input, audio data output, PLL input clock source, interrupt, digital audio input(PDM) etc. Depending on the hardware connection, we need to configure some registers so that the pin can function as any one of the features which mentioned in the data sheet. More info in section "5 Pin Configuration and Functions" & "Table 7-70. Multifunction Pin Assignments" in the data sheet. https://www.ti.com/lit/ds/symlink/tac5212.pdf If it feels right, I can make this also as part of the dts configuration. Please suggest if I still need to expose this as gpiolib. > > > +static const char *const tac5x1x_slot_select_text[] = { > > + "Slot 0", "Slot 1", "Slot 2", "Slot 3", > > + "Slot 4", "Slot 5", "Slot 6", "Slot 7", > > + "Slot 8", "Slot 9", "Slot 10", "Slot 11", > > + "Slot 12", "Slot 13", "Slot 14", "Slot 15", > > + "Slot 16", "Slot 17", "Slot 18", "Slot 19", > > + "Slot 20", "Slot 21", "Slot 22", "Slot 23", > > + "Slot 24", "Slot 25", "Slot 26", "Slot 27", > > + "Slot 28", "Slot 29", "Slot 30", "Slot 31", > > +}; > > TDM slot control would usually be done via set_tdm_slot(). We need the slots to be configurable in case we need to swap capture channels. Is it okay to keep this ? > > > +static const char *const out2x_vcom_text[] = { > > + "0.6 * Vref", > > + "AVDD by 2", > > +}; > > + This can be device tree setting. I will move it. > > +static const char *const diag_cfg_text[] = { > > + "0mv", "30mv", "60mv", "90mv", > > + "120mv", "150mv", "180mv", "210mv", > > + "240mv", "270mv", "300mv", "330mv", > > + "360mv", "390mv", "420mv", "450mv", > > +}; > > + > > +static const char *const diag_cfg_gnd_text[] = { > > + "0mv", "60mv", "120mv", "180mv", > > + "240mv", "300mv", "360mv", "420mv", > > + "480mv", "540mv", "600mv", "660mv", > > + "720mv", "780mv", "840mv", "900mv", > > +}; > > Are these controls that should be device tree data? We need these values to be configurable via mixer controls. Thanks, Niranjan H Y

2 1

ucm2: Qualcomm: Update the QCM6490 and QCS6490 HiFi conf files
by GitHub pull_request - opened 10 Jun '25

10 Jun '25

alsa-project/alsa-ucm-conf pull request #577 was opened from mohsRafi: Rename the HiFi conf files for QCM6490-IDP and QCS6490-RB3Gen2 boards to match with soundcard name. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/577 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/577.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[tiwai-sound:for-next 12/13] sound/pci/hda/patch_ca0132.c:4388:22: sparse: sparse: Using plain integer as NULL pointer
by kernel test robot 10 Jun '25

10 Jun '25

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 92f59aeb13252265c20e7aef1379a8080c57e0a2 commit: ed57a3d5a3118b9681de607692608fe573c5959d [12/13] ALSA: hda/ca0132: Enable hardware band EQ for Sound Blaster Core3D config: i386-randconfig-061-20250610 (https://download.01.org/0day-ci/archive/20250610/202506100842.d8lwwdwU-lkp@…) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250610/202506100842.d8lwwdwU-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202506100842.d8lwwdwU-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> sound/pci/hda/patch_ca0132.c:4388:22: sparse: sparse: Using plain integer as NULL pointer sound/pci/hda/patch_ca0132.c:4389:22: sparse: sparse: Using plain integer as NULL pointer vim +4388 sound/pci/hda/patch_ca0132.c 44f0c9782cc6ab Ian Minett 2012-12-20 4376 44f0c9782cc6ab Ian Minett 2012-12-20 4377 static int add_tuning_control(struct hda_codec *codec, 44f0c9782cc6ab Ian Minett 2012-12-20 4378 hda_nid_t pnid, hda_nid_t nid, 44f0c9782cc6ab Ian Minett 2012-12-20 4379 const char *name, int dir) 44f0c9782cc6ab Ian Minett 2012-12-20 4380 { 975cc02a904ae3 Takashi Iwai 2013-06-28 4381 char namestr[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; 44f0c9782cc6ab Ian Minett 2012-12-20 4382 int type = dir ? HDA_INPUT : HDA_OUTPUT; 44f0c9782cc6ab Ian Minett 2012-12-20 4383 struct snd_kcontrol_new knew = 44f0c9782cc6ab Ian Minett 2012-12-20 4384 HDA_CODEC_VOLUME_MONO(namestr, nid, 1, 0, type); 44f0c9782cc6ab Ian Minett 2012-12-20 4385 44f0c9782cc6ab Ian Minett 2012-12-20 4386 knew.access = SNDRV_CTL_ELEM_ACCESS_READWRITE | 44f0c9782cc6ab Ian Minett 2012-12-20 4387 SNDRV_CTL_ELEM_ACCESS_TLV_READ; 44f0c9782cc6ab Ian Minett 2012-12-20 @4388 knew.tlv.c = 0; 44f0c9782cc6ab Ian Minett 2012-12-20 4389 knew.tlv.p = 0; 44f0c9782cc6ab Ian Minett 2012-12-20 4390 switch (pnid) { 44f0c9782cc6ab Ian Minett 2012-12-20 4391 case VOICE_FOCUS: 44f0c9782cc6ab Ian Minett 2012-12-20 4392 knew.info = voice_focus_ctl_info; 44f0c9782cc6ab Ian Minett 2012-12-20 4393 knew.get = tuning_ctl_get; 44f0c9782cc6ab Ian Minett 2012-12-20 4394 knew.put = voice_focus_ctl_put; 44f0c9782cc6ab Ian Minett 2012-12-20 4395 knew.tlv.p = voice_focus_db_scale; 44f0c9782cc6ab Ian Minett 2012-12-20 4396 break; 44f0c9782cc6ab Ian Minett 2012-12-20 4397 case MIC_SVM: 44f0c9782cc6ab Ian Minett 2012-12-20 4398 knew.info = mic_svm_ctl_info; 44f0c9782cc6ab Ian Minett 2012-12-20 4399 knew.get = tuning_ctl_get; 44f0c9782cc6ab Ian Minett 2012-12-20 4400 knew.put = mic_svm_ctl_put; 44f0c9782cc6ab Ian Minett 2012-12-20 4401 break; 44f0c9782cc6ab Ian Minett 2012-12-20 4402 case EQUALIZER: 44f0c9782cc6ab Ian Minett 2012-12-20 4403 knew.info = equalizer_ctl_info; 44f0c9782cc6ab Ian Minett 2012-12-20 4404 knew.get = tuning_ctl_get; 44f0c9782cc6ab Ian Minett 2012-12-20 4405 knew.put = equalizer_ctl_put; 44f0c9782cc6ab Ian Minett 2012-12-20 4406 knew.tlv.p = eq_db_scale; 44f0c9782cc6ab Ian Minett 2012-12-20 4407 break; 44f0c9782cc6ab Ian Minett 2012-12-20 4408 default: 44f0c9782cc6ab Ian Minett 2012-12-20 4409 return 0; 44f0c9782cc6ab Ian Minett 2012-12-20 4410 } 44f0c9782cc6ab Ian Minett 2012-12-20 4411 knew.private_value = 44f0c9782cc6ab Ian Minett 2012-12-20 4412 HDA_COMPOSE_AMP_VAL(nid, 1, 0, type); 44f0c9782cc6ab Ian Minett 2012-12-20 4413 sprintf(namestr, "%s %s Volume", name, dirstr[dir]); 44f0c9782cc6ab Ian Minett 2012-12-20 4414 return snd_hda_ctl_add(codec, nid, snd_ctl_new1(&knew, codec)); 44f0c9782cc6ab Ian Minett 2012-12-20 4415 } 44f0c9782cc6ab Ian Minett 2012-12-20 4416 :::::: The code at line 4388 was first introduced by commit :::::: 44f0c9782cc6ab71ea947f8f710a46f2078a151c ALSA: hda/ca0132: Add tuning controls :::::: TO: Ian Minett <ian_minett(a)creativelabs.com> :::::: CC: Takashi Iwai <tiwai(a)suse.de> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:for-next 12/13] sound/pci/hda/patch_ca0132.c:4413:27: warning: '%s' directive writing up to 767 bytes into a region of size 44
by kernel test robot 10 Jun '25

10 Jun '25

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 92f59aeb13252265c20e7aef1379a8080c57e0a2 commit: ed57a3d5a3118b9681de607692608fe573c5959d [12/13] ALSA: hda/ca0132: Enable hardware band EQ for Sound Blaster Core3D config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20250610/202506100642.95jpuMY1-lkp@…) compiler: hppa-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250610/202506100642.95jpuMY1-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202506100642.95jpuMY1-lkp@intel.com/ All warnings (new ones prefixed by >>): sound/pci/hda/patch_ca0132.c: In function 'ca0132_build_controls': >> sound/pci/hda/patch_ca0132.c:4413:27: warning: '%s' directive writing up to 767 bytes into a region of size 44 [-Wformat-overflow=] 4413 | sprintf(namestr, "%s %s Volume", name, dirstr[dir]); | ^~ In function 'add_tuning_control', inlined from 'add_tuning_ctls' at sound/pci/hda/patch_ca0132.c:4423:9, inlined from 'ca0132_build_controls' at sound/pci/hda/patch_ca0132.c:7195:2: sound/pci/hda/patch_ca0132.c:4413:9: note: 'sprintf' output 9 or more bytes (assuming 776) into a destination of size 44 4413 | sprintf(namestr, "%s %s Volume", name, dirstr[dir]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +4413 sound/pci/hda/patch_ca0132.c 44f0c9782cc6ab Ian Minett 2012-12-20 4376 44f0c9782cc6ab Ian Minett 2012-12-20 4377 static int add_tuning_control(struct hda_codec *codec, 44f0c9782cc6ab Ian Minett 2012-12-20 4378 hda_nid_t pnid, hda_nid_t nid, 44f0c9782cc6ab Ian Minett 2012-12-20 4379 const char *name, int dir) 44f0c9782cc6ab Ian Minett 2012-12-20 4380 { 975cc02a904ae3 Takashi Iwai 2013-06-28 4381 char namestr[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; 44f0c9782cc6ab Ian Minett 2012-12-20 4382 int type = dir ? HDA_INPUT : HDA_OUTPUT; 44f0c9782cc6ab Ian Minett 2012-12-20 4383 struct snd_kcontrol_new knew = 44f0c9782cc6ab Ian Minett 2012-12-20 4384 HDA_CODEC_VOLUME_MONO(namestr, nid, 1, 0, type); 44f0c9782cc6ab Ian Minett 2012-12-20 4385 44f0c9782cc6ab Ian Minett 2012-12-20 4386 knew.access = SNDRV_CTL_ELEM_ACCESS_READWRITE | 44f0c9782cc6ab Ian Minett 2012-12-20 4387 SNDRV_CTL_ELEM_ACCESS_TLV_READ; 44f0c9782cc6ab Ian Minett 2012-12-20 4388 knew.tlv.c = 0; 44f0c9782cc6ab Ian Minett 2012-12-20 4389 knew.tlv.p = 0; 44f0c9782cc6ab Ian Minett 2012-12-20 4390 switch (pnid) { 44f0c9782cc6ab Ian Minett 2012-12-20 4391 case VOICE_FOCUS: 44f0c9782cc6ab Ian Minett 2012-12-20 4392 knew.info = voice_focus_ctl_info; 44f0c9782cc6ab Ian Minett 2012-12-20 4393 knew.get = tuning_ctl_get; 44f0c9782cc6ab Ian Minett 2012-12-20 4394 knew.put = voice_focus_ctl_put; 44f0c9782cc6ab Ian Minett 2012-12-20 4395 knew.tlv.p = voice_focus_db_scale; 44f0c9782cc6ab Ian Minett 2012-12-20 4396 break; 44f0c9782cc6ab Ian Minett 2012-12-20 4397 case MIC_SVM: 44f0c9782cc6ab Ian Minett 2012-12-20 4398 knew.info = mic_svm_ctl_info; 44f0c9782cc6ab Ian Minett 2012-12-20 4399 knew.get = tuning_ctl_get; 44f0c9782cc6ab Ian Minett 2012-12-20 4400 knew.put = mic_svm_ctl_put; 44f0c9782cc6ab Ian Minett 2012-12-20 4401 break; 44f0c9782cc6ab Ian Minett 2012-12-20 4402 case EQUALIZER: 44f0c9782cc6ab Ian Minett 2012-12-20 4403 knew.info = equalizer_ctl_info; 44f0c9782cc6ab Ian Minett 2012-12-20 4404 knew.get = tuning_ctl_get; 44f0c9782cc6ab Ian Minett 2012-12-20 4405 knew.put = equalizer_ctl_put; 44f0c9782cc6ab Ian Minett 2012-12-20 4406 knew.tlv.p = eq_db_scale; 44f0c9782cc6ab Ian Minett 2012-12-20 4407 break; 44f0c9782cc6ab Ian Minett 2012-12-20 4408 default: 44f0c9782cc6ab Ian Minett 2012-12-20 4409 return 0; 44f0c9782cc6ab Ian Minett 2012-12-20 4410 } 44f0c9782cc6ab Ian Minett 2012-12-20 4411 knew.private_value = 44f0c9782cc6ab Ian Minett 2012-12-20 4412 HDA_COMPOSE_AMP_VAL(nid, 1, 0, type); 44f0c9782cc6ab Ian Minett 2012-12-20 @4413 sprintf(namestr, "%s %s Volume", name, dirstr[dir]); 44f0c9782cc6ab Ian Minett 2012-12-20 4414 return snd_hda_ctl_add(codec, nid, snd_ctl_new1(&knew, codec)); 44f0c9782cc6ab Ian Minett 2012-12-20 4415 } 44f0c9782cc6ab Ian Minett 2012-12-20 4416 :::::: The code at line 4413 was first introduced by commit :::::: 44f0c9782cc6ab71ea947f8f710a46f2078a151c ALSA: hda/ca0132: Add tuning controls :::::: TO: Ian Minett <ian_minett(a)creativelabs.com> :::::: CC: Takashi Iwai <tiwai(a)suse.de> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH v4 0/5] Add DisplayPort sound support for Fairphone 5 smartphone
by Luca Weiss 10 Jun '25

10 Jun '25

Add the necessary sound card bits and some dts additions to enable sound over DisplayPort-over-USB-C, e.g. to a connected TV or monitor. The UCM files can be found here: https://gitlab.postmarketos.org/postmarketOS/pmaports/-/tree/master/device/… This series - in spirit - depends on the series enabling DisplayPort in the first place, but can land pretty independently, especially the ASoC bits: https://lore.kernel.org/linux-arm-msm/20250312-fp5-pmic-glink-dp-v2-0-a5592… The ASoC bits depend on the patches for USB audio offloading merged through Greg's tree so this cannot easily be applied for v6.16 through the sound tree. Either it waits for v6.17 or also goes through Greg's tree. Signed-off-by: Luca Weiss <luca.weiss(a)fairphone.com> --- Changes in v4: - Use "sm4250" for qcom,qrb4210-rb2-sndcard (Srinivas) - Expand cover letter to mention dependencies for ASoC patches - Pick up tags - Link to v3: https://lore.kernel.org/r/20250425-fp5-dp-sound-v3-0-7cb45180091b@fairphone… Changes in v3: - Simplify return qcom_snd_wcd_jack_setup in machine driver - Pick up tags - Link to v2: https://lore.kernel.org/r/20250418-fp5-dp-sound-v2-0-05d65f084b05@fairphone… Changes in v2: - Revamp series based on comments on v1, doesn't have much too much in common anymore - Use sm8250 instead of sc8280xp sndcard file, so port other required changes from sc8280xp.c to sm8250.c - This also changes the sound card compatible to from qcom,qcm6490-sndcard to fairphone,fp5-sndcard - Link to v1: https://lore.kernel.org/r/20240809-fp5-dp-sound-v1-0-d7ba2c24f6b9@fairphone… --- Luca Weiss (5): ASoC: dt-bindings: qcom,sm8250: Add Fairphone 5 sound card ASoC: qcom: sm8250: set card driver name from match data ASoC: qcom: sm8250: add DisplayPort Jack support ASoC: qcom: sm8250: Add Fairphone 5 soundcard compatible arm64: dts: qcom: qcm6490-fairphone-fp5: Add DisplayPort sound support .../devicetree/bindings/sound/qcom,sm8250.yaml | 1 + arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 31 ++++++++++++++++++++++ sound/soc/qcom/sm8250.c | 27 ++++++++++--------- 3 files changed, 47 insertions(+), 12 deletions(-) --- base-commit: f819a667fa466d3b96b542b147053b6873f18ea1 change-id: 20240809-fp5-dp-sound-b3768f3019bd Best regards, -- Luca Weiss <luca.weiss(a)fairphone.com>

5 10

[PATCH v3 0/5] Add DisplayPort sound support for Fairphone 5 smartphone
by Luca Weiss 10 Jun '25

10 Jun '25

Add the necessary sound card bits and some dts additions to enable sound over DisplayPort-over-USB-C, e.g. to a connected TV or monitor. The UCM files can be found here: https://gitlab.postmarketos.org/postmarketOS/pmaports/-/tree/master/device/… This series - in spirit - depends on the series enabling DisplayPort in the first place, but can land pretty independently, especially the ASoC bits: https://lore.kernel.org/linux-arm-msm/20250312-fp5-pmic-glink-dp-v2-0-a5592… Signed-off-by: Luca Weiss <luca.weiss(a)fairphone.com> --- Changes in v3: - Simplify return qcom_snd_wcd_jack_setup in machine driver - Pick up tags - Link to v2: https://lore.kernel.org/r/20250418-fp5-dp-sound-v2-0-05d65f084b05@fairphone… Changes in v2: - Revamp series based on comments on v1, doesn't have much too much in common anymore - Use sm8250 instead of sc8280xp sndcard file, so port other required changes from sc8280xp.c to sm8250.c - This also changes the sound card compatible to from qcom,qcm6490-sndcard to fairphone,fp5-sndcard - Link to v1: https://lore.kernel.org/r/20240809-fp5-dp-sound-v1-0-d7ba2c24f6b9@fairphone… --- Luca Weiss (5): ASoC: dt-bindings: qcom,sm8250: Add Fairphone 5 sound card ASoC: qcom: sm8250: set card driver name from match data ASoC: qcom: sm8250: add DisplayPort Jack support ASoC: qcom: sm8250: Add Fairphone 5 soundcard compatible arm64: dts: qcom: qcm6490-fairphone-fp5: Add DisplayPort sound support .../devicetree/bindings/sound/qcom,sm8250.yaml | 1 + arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 31 ++++++++++++++++++++++ sound/soc/qcom/sm8250.c | 27 ++++++++++--------- 3 files changed, 47 insertions(+), 12 deletions(-) --- base-commit: 7f1dd4e6634d085f3c9652d4e0f1903659fb96f9 change-id: 20240809-fp5-dp-sound-b3768f3019bd Best regards, -- Luca Weiss <luca.weiss(a)fairphone.com>

6 16

[PATCH] ASoC: amd: acp: Fix pointer assignments for snd_soc_acpi_mach structures
by Venkata Prasad Potturu 09 Jun '25

09 Jun '25

This patch modifies the assignment of machine structure pointers in the acp_pci_probe function. Previously, the machine pointers were assigned using the address-of operator (&), which caused incompatibility issues in type assignments. Additionally, the declarations of the machine arrays in amd.h have been updated to reflect that they are indeed arrays (`[]`). The code is further cleaned up by declaring the codec structures in amd-acpi-mach.c as static, reflecting their intended usage. error: symbol 'amp_rt1019' was not declared. Should it be static? error: symbol 'amp_max' was not declared. Should it be static? error: symbol 'snd_soc_acpi_amd_acp_machines' was not declared. Should it be static? error: symbol 'snd_soc_acpi_amd_rmb_acp_machines' was not declared. Should it be static? error: symbol 'snd_soc_acpi_amd_acp63_acp_machines' was not declared. Should it be static? error: symbol 'snd_soc_acpi_amd_acp70_acp_machines' was not declared. Should it be static? Fixes: 9c2c0ef64009 ("ASoC: amd: acp: Fix snd_soc_acpi_mach id's duplicate symbol error") Link: https://github.com/thesofproject/linux/issues/5438 Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu(a)amd.com> --- sound/soc/amd/acp/acp-pci.c | 8 ++++---- sound/soc/amd/acp/amd-acpi-mach.c | 4 ++-- sound/soc/amd/acp/amd.h | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c index 0b2aa33cc426..2591b1a1c5e0 100644 --- a/sound/soc/amd/acp/acp-pci.c +++ b/sound/soc/amd/acp/acp-pci.c @@ -137,26 +137,26 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id chip->name = "acp_asoc_renoir"; chip->rsrc = &rn_rsrc; chip->acp_hw_ops_init = acp31_hw_ops_init; - chip->machines = &snd_soc_acpi_amd_acp_machines; + chip->machines = snd_soc_acpi_amd_acp_machines; break; case 0x6f: chip->name = "acp_asoc_rembrandt"; chip->rsrc = &rmb_rsrc; chip->acp_hw_ops_init = acp6x_hw_ops_init; - chip->machines = &snd_soc_acpi_amd_rmb_acp_machines; + chip->machines = snd_soc_acpi_amd_rmb_acp_machines; break; case 0x63: chip->name = "acp_asoc_acp63"; chip->rsrc = &acp63_rsrc; chip->acp_hw_ops_init = acp63_hw_ops_init; - chip->machines = &snd_soc_acpi_amd_acp63_acp_machines; + chip->machines = snd_soc_acpi_amd_acp63_acp_machines; break; case 0x70: case 0x71: chip->name = "acp_asoc_acp70"; chip->rsrc = &acp70_rsrc; chip->acp_hw_ops_init = acp70_hw_ops_init; - chip->machines = &snd_soc_acpi_amd_acp70_acp_machines; + chip->machines = snd_soc_acpi_amd_acp70_acp_machines; break; default: dev_err(dev, "Unsupported device revision:0x%x\n", pci->revision); diff --git a/sound/soc/amd/acp/amd-acpi-mach.c b/sound/soc/amd/acp/amd-acpi-mach.c index d95047d2ee94..27da2a862f1c 100644 --- a/sound/soc/amd/acp/amd-acpi-mach.c +++ b/sound/soc/amd/acp/amd-acpi-mach.c @@ -8,12 +8,12 @@ #include <sound/soc-acpi.h> -struct snd_soc_acpi_codecs amp_rt1019 = { +static struct snd_soc_acpi_codecs amp_rt1019 = { .num_codecs = 1, .codecs = {"10EC1019"} }; -struct snd_soc_acpi_codecs amp_max = { +static struct snd_soc_acpi_codecs amp_max = { .num_codecs = 1, .codecs = {"MX98360A"} }; diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h index 863e74fcee43..cb8d97122f95 100644 --- a/sound/soc/amd/acp/amd.h +++ b/sound/soc/amd/acp/amd.h @@ -243,10 +243,10 @@ extern struct acp_resource rmb_rsrc; extern struct acp_resource acp63_rsrc; extern struct acp_resource acp70_rsrc; -extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines; -extern struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines; -extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp63_acp_machines; -extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_acp_machines; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp63_acp_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_acp_machines[]; extern const struct snd_soc_dai_ops asoc_acp_cpu_dai_ops; extern const struct snd_soc_dai_ops acp_dmic_dai_ops; -- 2.43.0

2 3

Qualcomm: Add QCS9075-IQ-EVK HiFi config
by GitHub pull_request - opened 09 Jun '25

09 Jun '25

alsa-project/alsa-ucm-conf pull request #576 was opened from mohsRafi: Add UCM2 configs for the Qualcomm QCS9075-IQ-EVK Board to handle: - I2S Speaker Amplifier - I2S Mic Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/576 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/576.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: codecs: ES8326: Modify initialization configuration
by Zhang Yi 09 Jun '25

09 Jun '25

Modify the value of ES8326_SDINOUT1_IO in the initialization Signed-off-by: Zhang Yi <zhangyi(a)everest-semi.com> --- sound/soc/codecs/es8326.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/es8326.c b/sound/soc/codecs/es8326.c index 066d92b54312..78c4e68f6002 100755 --- a/sound/soc/codecs/es8326.c +++ b/sound/soc/codecs/es8326.c @@ -1079,8 +1079,7 @@ static void es8326_init(struct snd_soc_component *component) regmap_update_bits(es8326->regmap, ES8326_HPDET_TYPE, 0x03, 0x00); regmap_write(es8326->regmap, ES8326_INTOUT_IO, es8326->interrupt_clk); - regmap_write(es8326->regmap, ES8326_SDINOUT1_IO, - (ES8326_IO_DMIC_CLK << ES8326_SDINOUT1_SHIFT)); + regmap_write(es8326->regmap, ES8326_SDINOUT1_IO, ES8326_IO_INPUT); regmap_write(es8326->regmap, ES8326_SDINOUT23_IO, ES8326_IO_INPUT); regmap_write(es8326->regmap, ES8326_ANA_PDN, 0x00); -- 2.17.1

2 2

[PATCH v1] ASoC: tas2781: Drop the unnecessary symbol imply
by Shenghao Ding 09 Jun '25

09 Jun '25

The unnecessary symbols for imply are SND_SOC_TAS2781_COMLIB, SND_SOC_TAS2781_COMLIB_I2C, and SND_SOC_TAS2781_FMWLIB. They all used for library compiling. All the symbols in the imply are used for codec driver compiling. Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- sound/soc/codecs/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 8fe795504dbb..0e70064bc90c 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -262,9 +262,6 @@ config SND_SOC_ALL_CODECS imply SND_SOC_TAS2764 imply SND_SOC_TAS2770 imply SND_SOC_TAS2780 - imply SND_SOC_TAS2781_COMLIB - imply SND_SOC_TAS2781_COMLIB_I2C - imply SND_SOC_TAS2781_FMWLIB imply SND_SOC_TAS2781_I2C imply SND_SOC_TAS5086 imply SND_SOC_TAS571X -- 2.43.0

2 1