March 2025 - Alsa-devel - mailman.alsa-project.org

regresion: snd_hdsp
by GitHub issues - edited 06 Mar '25

06 Mar '25

alsa-project/alsa-firmware issue #11 was edited from juanpc2018: ![Image](https://github.com/user-attachments/assets/e57192a7-ad1c-44f9-b51d-7806efed9a32) ``` $ pulseaudio W: [pulseaudio] module.c: module-combine is deprecated: Please use module-combine-sink instead of module-combine! W: [pulseaudio] module-combine.c: We will now load module-combine-sink. Please make sure to remove module-combine from your configuration. E: [alsa-sink-RME Hammerfall HDSP 9632] alsa-sink.c: ALSA woke us up to write new data to the device, but there was actually nothing to write. E: [alsa-sink-RME Hammerfall HDSP 9632] alsa-sink.c: Most likely this is a bug in the ALSA driver 'snd_hdsp'. Please report this issue to the ALSA developers. E: [alsa-sink-RME Hammerfall HDSP 9632] alsa-sink.c: We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail. ``` when i play any video or sound file, most of the time PulseAudio takes between 7 to 15 seconds to fill the buffer in proper order, audio is played in wrong order, chopped, like stutter. i have tested /etc/pulse/deamon.conf s24le to s24be problem persists. forced sample rate to 48Khz, i remember hdsp9632 worked ok on U/Kubuntu 10.04 & 10.10 Now 20.04.4 LTS has problems. im using Liquorix 6.3 Kernel. ``` $ sudo apt show alsa-firmware* Package: alsa-firmware-loaders Version: 1.1.7-1ubuntu1 Priority: extra Section: multiverse/sound Source: alsa-tools Origin: Ubuntu Maintainer: Ubuntu Developers <ubuntu-devel-discuss(a)lists.ubuntu.com> Original-Maintainer: Debian ALSA Maintainers <pkg-alsa-devel(a)lists.alioth.debian.org> Bugs: https://bugs.launchpad.net/ubuntu/+filebug Installed-Size: 211 kB Depends: fxload, udev, libasound2 (>= 1.0.24.1), libc6 (>= 2.4) Homepage: https://www.alsa-project.org/ Download-Size: 25,0 kB APT-Manual-Installed: yes APT-Sources: http://archive.ubuntu.com/ubuntu focal/multiverse amd64 Packages Description: ALSA software loaders for specific hardware $ sudo apt show alsa-tools-gui Package: alsa-tools-gui Version: 1.1.7-1ubuntu1 Priority: extra Section: universe/sound Source: alsa-tools Origin: Ubuntu Maintainer: Ubuntu Developers <ubuntu-devel-discuss(a)lists.ubuntu.com> Original-Maintainer: Debian ALSA Maintainers <pkg-alsa-devel(a)lists.alioth.debian.org> Bugs: https://bugs.launchpad.net/ubuntu/+filebug Installed-Size: 1.002 kB Depends: libasound2 (>= 1.0.24.1), libc6 (>= 2.29), libfltk1.1 (>= 1.1.6), libglib2.0-0 (>= 2.35.9), libgtk-3-0 (>= 3.0.0), libgtk2.0-0 (>= 2.8.0), libstdc++6 (>= 5.2) Homepage: https://www.alsa-project.org/ Task: ubuntustudio-audio Download-Size: 220 kB APT-Manual-Installed: yes APT-Sources: http://archive.ubuntu.com/ubuntu focal/universe amd64 Packages Description: GUI based ALSA utilities for specific hardware ``` Issue URL : https://github.com/alsa-project/alsa-firmware/issues/11 Repository URL: https://github.com/alsa-project/alsa-firmware

1 0

regresion: snd_hdsp
by GitHub issues - opened 06 Mar '25

06 Mar '25

alsa-project/alsa-firmware issue #11 was opened from juanpc2018: ![Image](https://github.com/user-attachments/assets/e57192a7-ad1c-44f9-b51d-7806efed9a32) ``` $ pulseaudio W: [pulseaudio] module.c: module-combine is deprecated: Please use module-combine-sink instead of module-combine! W: [pulseaudio] module-combine.c: We will now load module-combine-sink. Please make sure to remove module-combine from your configuration. E: [alsa-sink-RME Hammerfall HDSP 9632] alsa-sink.c: ALSA woke us up to write new data to the device, but there was actually nothing to write. E: [alsa-sink-RME Hammerfall HDSP 9632] alsa-sink.c: Most likely this is a bug in the ALSA driver 'snd_hdsp'. Please report this issue to the ALSA developers. E: [alsa-sink-RME Hammerfall HDSP 9632] alsa-sink.c: We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail. ``` when i play any video or sound file, most of the time PulseAudio takes between 7 to 15 seconds to fill the buffer in proper order, audio is played in wrong order, chopped, like stutter. i have tested /etc/pulse/deamon.conf s24le to s24be problem persists. forced sample rate to 48Khz, i remember hdsp9632 worked ok on U/Kubuntu 10.04 & 10.10 Now 20.04.4 LTS has problems. im using Liquorix 6.3 Kernel. Issue URL : https://github.com/alsa-project/alsa-firmware/issues/11 Repository URL: https://github.com/alsa-project/alsa-firmware

1 0

XRUN handling in pcm driver
by noman pouigt 05 Mar '25

05 Mar '25

Hello Maintainers, I have a question regarding XRUN handling. After an XRUN is triggered, userspace generally calls TRIGGER_STOP followed by PREPARE and TRIGGER_START. In the PREPARE stage, we are currently not sending the ALSA ring buffer (physical address, rate, format, etc.) IPC to the DSP but instead doing that in HW_PARAMS which is causing bad audio after XRUN is triggered. I was able to resolve the issue by moving the IPC to PREPARE, which fixes the XRUN problem and results in good audio even after an XRUN. I have also observed a similar approach in Qualcomm drivers, which I assume is for the same reason. Is moving the IPC to PREPARE the correct approach for handling this issue? I would appreciate any insights or guidance on whether this is the recommended way to handle XRUN recovery. Thanks,

2 1

RE: [PATCH v4 1/2] ASoC: codecs: add support for ES8389
by Zhang Yi 05 Mar '25

05 Mar '25

> > + ret = device_property_read_u8(codec->dev, "everest,adc-slot", &es8389->adc_slot); > > + if (ret != 0) { > > + dev_dbg(codec->dev, "adc-slot return %d", ret); > > + es8389->adc_slot = 0x00; > > + } > > + > > + ret = device_property_read_u8(codec->dev, "everest,dac-slot", &es8389->dac_slot); > > + if (ret != 0) { > > + dev_dbg(codec->dev, "dac-slot return %d", ret); > > + es8389->dac_slot = 0x00; > > + } > > set_tdm_slot() > > Please don't ignore review comments, people are generally making them > for a reason and are likely to have the same concerns if issues remain > unaddressed. Having to repeat the same comments can get repetitive and > make people question the value of time spent reviewing. If you disagree > with the review comments that's fine but you need to reply and discuss > your concerns so that the reviewer can understand your decisions. We will register multiple codecs inside a single dai_link and differentiate these codecs by of_node. And the adc_slot and the dac_slot may be different, they can be decided by the user.If we use set_tdm_slot,the adc_slot and the dac_slot will be same. > > + if (!es8389->adc_slot) { > > + es8389->mclk = devm_clk_get(codec->dev, "mclk"); > > + if (IS_ERR(es8389->mclk)) > > + return dev_err_probe(codec->dev, PTR_ERR(es8389->mclk), > > + "ES8389 is unable to get mclk\n"); > > + > > + if (!es8389->mclk) > > + dev_err(codec->dev, "%s, assuming static mclk\n", __func__); > > + > > + ret = clk_prepare_enable(es8389->mclk); > > + if (ret) { > > + dev_err(codec->dev, "%s, unable to enable mclk\n", __func__); > > + return ret; > > + } > > + } > > Making the use of a MCLK depend on the configuration of a TDM slot for > the ADC seems *very* unusual, what's going on there? Because we are associating multiple codecs under a single dai_link, we will be executing probe and init many times during initialization.But MCLK only needs to be used once.So we decided making the use of a MCLK depend on the configuration of a TDM slot for the ADC

2 1

update ALC222 depop optimize
by Kailang 05 Mar '25

05 Mar '25

Hi Takashi, Update ALC222 depop optimize as attach. BR, Kailang

2 8

[PATCH] ALSA: hda: intel: Add Dell ALC3271 to power_save denylist
by Hoku Ishibe 05 Mar '25

05 Mar '25

Dell XPS 13 7390 with the Realtek ALC3271 codec experiences persistent humming noise when the power_save mode is enabled. This issue occurs when the codec enters power saving mode, leading to unwanted noise from the speakers. This patch adds the affected model (PCI ID 0x1028:0x0962) to the power_save denylist to ensure power_save is disabled by default, preventing power-off related noise issues. Steps to Reproduce 1. Boot the system with `snd_hda_intel` loaded. 2. Verify that `power_save` mode is enabled: ```sh cat /sys/module/snd_hda_intel/parameters/power_save ```` output: 10 (default power save timeout) 3. Wait for the power save timeout 4. Observe a persistent humming noise from the speakers 5. Disable `power_save` manually: ```sh echo 0 | sudo tee /sys/module/snd_hda_intel/parameters/power_save ```` 6. Confirm that the noise disappears immediately. This issue has been observed on my system, and this patch successfully eliminates the unwanted noise. If other users experience similar issues, additional reports would be helpful. Signed-off-by: Hoku Ishibe <me(a)hokuishi.be> --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 7d7f9aac50a9..ff536a0e480c 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2232,6 +2232,8 @@ static const struct snd_pci_quirk power_save_denylist[] = { SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0), /* KONTRON SinglePC may cause a stall at runtime resume */ SND_PCI_QUIRK(0x1734, 0x1232, "KONTRON SinglePC", 0), + /* Dell ALC3271 */ + SND_PCI_QUIRK(0x1028, 0x0962, "Dell ALC3271", 0), {} }; -- 2.48.1

2 1

RE: [PATCH v4 1/2] ASoC: codecs: add support for ES8389
by Zhang Yi 05 Mar '25

05 Mar '25

> > @@ -0,0 +1,961 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * es8389.c -- ES8389/ES8390 ALSA SoC Audio Codec > > + * > > + * Copyright (C) 2025 Everest Semiconductor Co., Ltd > > Please make the entire comment block a C++ one so things look more > consistent. I will fix it > > + if (es8389->dmic == true) { > > + regmap_update_bits(es8389->regmap, ES8389_DMIC_EN, 0xC0, 0xC0); > > + regmap_update_bits(es8389->regmap, ES8389_ADC_MODE, 0x03, 0x03); > > + } else { > > + regmap_update_bits(es8389->regmap, ES8389_DMIC_EN, 0xC0, 0x00); > > + regmap_update_bits(es8389->regmap, ES8389_ADC_MODE, 0x03, 0x00); > > + } > > We also had the DMIC mux, is that useful as a runtime control when we > have firmware data telling us if there's a DMIC? Can both a DMIC and > analog input be present in the same system? > > It does still look like a lot of these settings might be things that > should be user controllable... I'm going to remove es8389->dmic and everest,dmic-enabled and use only DMIC_MUX

1 0

RE: [PATCH v3 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC
by Zhang Yi 05 Mar '25

05 Mar '25

> > > >>> + > >>> + prefix_name: > >> > >> No underscores in node names, missing vendor prefix... but more > >> important: I don't understand the need for this property. Description copies property name so it is not useful. > > And these comments as well. The prefix_name is used to distinguish the dapm and kcontrol of each individual codec. And I will update name of the property > > > >>> + everest,dmic-enabled: > >>> + $ref: /schemas/types.yaml#/definitions/flag > >>> + description: > >>> + The property is a choice between PDM and AMIC > >>> + > >> > >> No supplies? > > > > I will drop the property > > I did not comment about dmic, but meant missing power supplies, which > usually are placed here. I apologize for misunderstanding your comment. But we don't have properties about the power supplies

1 0

RE: [PATCH v3 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC
by Zhang Yi 05 Mar '25

05 Mar '25

> > + > > +properties: > > + compatible: > > + const: everest,es8389 > > Device is really different than es8388? yes, it's different from es8388 > > + "#sound-dai-cells": > > + const: 0 > > + > > + everest,adc-slot: > > + $ref: /schemas/types.yaml#/definitions/uint8 > > + description: | > > + This property is used to set the slots of recording data when multiple > > + codecs are connected in PTDM mode. > > + please set this property to default if you are setting STDM mode. > > + minimum: 0x00 > > Drop, unsigned does not allow -1. > > > + maximum: 0x07 > > + default: 0x00 > > All of these should be rather decimal. I will try to fix the error > > + > > + prefix_name: > > No underscores in node names, missing vendor prefix... but more > important: I don't understand the need for this property. Description copies property name so it is not useful. > > Drop. You maybe wanted dai prefix, but this is already in dai-common. I will update description at v4 PATCH > > + everest,dmic-enabled: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The property is a choice between PDM and AMIC > > + > > No supplies? I will drop the property > > +required: > > + - compatible > > + - reg > > + - "#sound-dai-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c{ > > Missing space. > > > + #address-cells = <1>; > > + #size-cells = <0>; > > + es8389: es8389@10 { > > Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetr… > > > + compatible = "everest,es8389"; > > + reg = <0x10>; > > + everest,adc-slot = [00]; > > Please open other bindings or DTS and take a look how single number is encoded. In general, please rather base your work on latest bindings and DTS accepted by reviewers and use them as learning/template to avoid common mistakes. At least two comments in this review could be avoided if you did this. > > > + everest,dac-slot = [00]; > > + prefix_name = "es8389_0"; > > Drop I will try to fix it

1 0

[PATCH v4 0/2] ASoC: codecs: add support for ES8389
by Zhang Yi 04 Mar '25

04 Mar '25

The driver is for codec ES8389 of everest-semi. Zhang Yi (2): ASoC: codecs: add support for ES8389 ASoC: dt-bindings: Add Everest ES8389 audio CODEC .../bindings/sound/everest,es8389.yaml | 83 ++ sound/soc/codecs/Kconfig | 6 +- sound/soc/codecs/Makefile | 2 + sound/soc/codecs/es8389.c | 961 ++++++++++++++++++ sound/soc/codecs/es8389.h | 139 +++ 5 files changed, 1190 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/sound/everest,es8389.yaml create mode 100644 sound/soc/codecs/es8389.c create mode 100644 sound/soc/codecs/es8389.h -- 2.17.1

2 3