August 2024 - Alsa-devel - mailman.alsa-project.org

[PATCH 0/2] ASoC: codecs: warn on unknown codec version
by Dmitry Baryshkov 09 Aug '24

09 Aug '24

While debugging broken audio issues on some of Qualcomm platforms I stumbled upon the kernel not providing the actual error information. It prints an error from the wsa_macro driver, but the actual issue is in the VA macro driver. Add error message to point to the actual error location. va_macro 3370000.codec: Unknown VA Codec version, ID: 00 / 0f / 00 wsa_macro 3240000.codec: Unsupported Codec version (0) Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> --- Dmitry Baryshkov (2): ASoC: codecs: lpass-macro: fix version strings returned for 1.x codecs ASoC: codecs: lpass-va-macro: warn on unknown version sound/soc/codecs/lpass-macro-common.h | 6 ++++++ sound/soc/codecs/lpass-va-macro.c | 4 ++++ 2 files changed, 10 insertions(+) --- base-commit: 668d33c9ff922c4590c58754ab064aaf53c387dd change-id: 20240803-codec-version-db6f65ab51ce Best regards, -- Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org>

2 3

[tiwai-sound:for-next 69/83] sound/pcmcia/vx/vxpocket.c:273:12: error: use of undeclared identifier 'pdev'; did you mean 'p_dev'?
by kernel test robot 09 Aug '24

09 Aug '24

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: c46fc83e3f3c89f18962e43890de90b1c304747a commit: 2acbb5e57230830016e0fb2d61886e7a8c7f59ce [69/83] ALSA: vxpocket: Use standard print API config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240809/202408090809.TAYiyrqJ-lkp@…) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240809/202408090809.TAYiyrqJ-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202408090809.TAYiyrqJ-lkp@intel.com/ Note: the tiwai-sound/for-next HEAD c46fc83e3f3c89f18962e43890de90b1c304747a builds fine. It only hurts bisectability. All errors (new ones prefixed by >>): sound/pcmcia/vx/vxpocket.c:207:8: error: no member named 'dev' in 'struct vx_core' 207 | chip->dev = &link->dev; | ~~~~ ^ >> sound/pcmcia/vx/vxpocket.c:273:12: error: use of undeclared identifier 'pdev'; did you mean 'p_dev'? 273 | dev_err(&pdev->dev, "vxpocket: cannot create a card instance\n"); | ^~~~ | p_dev include/linux/dev_printk.h:154:44: note: expanded from macro 'dev_err' 154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__) | ^ include/linux/dev_printk.h:110:11: note: expanded from macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^ sound/pcmcia/vx/vxpocket.c:251:49: note: 'p_dev' declared here 251 | static int vxpocket_probe(struct pcmcia_device *p_dev) | ^ 2 errors generated. vim +273 sound/pcmcia/vx/vxpocket.c 247 248 249 /* 250 */ 251 static int vxpocket_probe(struct pcmcia_device *p_dev) 252 { 253 struct snd_card *card; 254 struct snd_vxpocket *vxp; 255 int i, err; 256 257 /* find an empty slot from the card list */ 258 for (i = 0; i < SNDRV_CARDS; i++) { 259 if (!(card_alloc & (1 << i))) 260 break; 261 } 262 if (i >= SNDRV_CARDS) { 263 dev_err(&p_dev->dev, "vxpocket: too many cards found\n"); 264 return -EINVAL; 265 } 266 if (! enable[i]) 267 return -ENODEV; /* disabled explicitly */ 268 269 /* ok, create a card instance */ 270 err = snd_card_new(&p_dev->dev, index[i], id[i], THIS_MODULE, 271 0, &card); 272 if (err < 0) { > 273 dev_err(&pdev->dev, "vxpocket: cannot create a card instance\n"); 274 return err; 275 } 276 277 err = snd_vxpocket_new(card, ibl[i], p_dev, &vxp); 278 if (err < 0) { 279 snd_card_free(card); 280 return err; 281 } 282 card->private_data = vxp; 283 284 vxp->index = i; 285 card_alloc |= 1 << i; 286 287 vxp->p_dev = p_dev; 288 289 return vxpocket_config(p_dev); 290 } 291 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:for-next 73/83] sound/sparc/cs4231.c:2018:25: error: 'chpi' undeclared; did you mean 'chip'?
by kernel test robot 09 Aug '24

09 Aug '24

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: c46fc83e3f3c89f18962e43890de90b1c304747a commit: d41abde894830bfb77252653f606473728e930eb [73/83] ALSA: sparc: Use standard print API config: sparc64-defconfig (https://download.01.org/0day-ci/archive/20240809/202408090648.J2EAijjH-lkp@…) compiler: sparc64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240809/202408090648.J2EAijjH-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202408090648.J2EAijjH-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/platform_device.h:13, from sound/sparc/cs4231.c:21: sound/sparc/cs4231.c: In function 'snd_cs4231_ebus_create': >> sound/sparc/cs4231.c:2018:25: error: 'chpi' undeclared (first use in this function); did you mean 'chip'? 2018 | dev_dbg(chpi->card->dev, | ^~~~ include/linux/dev_printk.h:139:44: note: in definition of macro 'dev_no_printk' 139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~ sound/sparc/cs4231.c:2018:17: note: in expansion of macro 'dev_dbg' 2018 | dev_dbg(chpi->card->dev, | ^~~~~~~ sound/sparc/cs4231.c:2018:25: note: each undeclared identifier is reported only once for each function it appears in 2018 | dev_dbg(chpi->card->dev, | ^~~~ include/linux/dev_printk.h:139:44: note: in definition of macro 'dev_no_printk' 139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~ sound/sparc/cs4231.c:2018:17: note: in expansion of macro 'dev_dbg' 2018 | dev_dbg(chpi->card->dev, | ^~~~~~~ vim +2018 sound/sparc/cs4231.c 1950 1951 static int snd_cs4231_ebus_create(struct snd_card *card, 1952 struct platform_device *op, 1953 int dev) 1954 { 1955 struct snd_cs4231 *chip = card->private_data; 1956 int err; 1957 1958 spin_lock_init(&chip->lock); 1959 spin_lock_init(&chip->c_dma.ebus_info.lock); 1960 spin_lock_init(&chip->p_dma.ebus_info.lock); 1961 mutex_init(&chip->mce_mutex); 1962 mutex_init(&chip->open_mutex); 1963 chip->flags |= CS4231_FLAG_EBUS; 1964 chip->op = op; 1965 memcpy(&chip->image, &snd_cs4231_original_image, 1966 sizeof(snd_cs4231_original_image)); 1967 strcpy(chip->c_dma.ebus_info.name, "cs4231(capture)"); 1968 chip->c_dma.ebus_info.flags = EBUS_DMA_FLAG_USE_EBDMA_HANDLER; 1969 chip->c_dma.ebus_info.callback = snd_cs4231_ebus_capture_callback; 1970 chip->c_dma.ebus_info.client_cookie = chip; 1971 chip->c_dma.ebus_info.irq = op->archdata.irqs[0]; 1972 strcpy(chip->p_dma.ebus_info.name, "cs4231(play)"); 1973 chip->p_dma.ebus_info.flags = EBUS_DMA_FLAG_USE_EBDMA_HANDLER; 1974 chip->p_dma.ebus_info.callback = snd_cs4231_ebus_play_callback; 1975 chip->p_dma.ebus_info.client_cookie = chip; 1976 chip->p_dma.ebus_info.irq = op->archdata.irqs[1]; 1977 1978 chip->p_dma.prepare = _ebus_dma_prepare; 1979 chip->p_dma.enable = _ebus_dma_enable; 1980 chip->p_dma.request = _ebus_dma_request; 1981 chip->p_dma.address = _ebus_dma_addr; 1982 1983 chip->c_dma.prepare = _ebus_dma_prepare; 1984 chip->c_dma.enable = _ebus_dma_enable; 1985 chip->c_dma.request = _ebus_dma_request; 1986 chip->c_dma.address = _ebus_dma_addr; 1987 1988 chip->port = of_ioremap(&op->resource[0], 0, 0x10, "cs4231"); 1989 chip->p_dma.ebus_info.regs = 1990 of_ioremap(&op->resource[1], 0, 0x10, "cs4231_pdma"); 1991 chip->c_dma.ebus_info.regs = 1992 of_ioremap(&op->resource[2], 0, 0x10, "cs4231_cdma"); 1993 if (!chip->port || !chip->p_dma.ebus_info.regs || 1994 !chip->c_dma.ebus_info.regs) { 1995 snd_cs4231_ebus_free(chip); 1996 dev_dbg(chip->card->dev, 1997 "cs4231-%d: Unable to map chip registers.\n", dev); 1998 return -EIO; 1999 } 2000 2001 if (ebus_dma_register(&chip->c_dma.ebus_info)) { 2002 snd_cs4231_ebus_free(chip); 2003 dev_dbg(chip->card->dev, 2004 "cs4231-%d: Unable to register EBUS capture DMA\n", 2005 dev); 2006 return -EBUSY; 2007 } 2008 if (ebus_dma_irq_enable(&chip->c_dma.ebus_info, 1)) { 2009 snd_cs4231_ebus_free(chip); 2010 dev_dbg(chip->card->dev, 2011 "cs4231-%d: Unable to enable EBUS capture IRQ\n", 2012 dev); 2013 return -EBUSY; 2014 } 2015 2016 if (ebus_dma_register(&chip->p_dma.ebus_info)) { 2017 snd_cs4231_ebus_free(chip); > 2018 dev_dbg(chpi->card->dev, 2019 "cs4231-%d: Unable to register EBUS play DMA\n", 2020 dev); 2021 return -EBUSY; 2022 } 2023 if (ebus_dma_irq_enable(&chip->p_dma.ebus_info, 1)) { 2024 snd_cs4231_ebus_free(chip); 2025 dev_dbg(chip->card->dev, 2026 "cs4231-%d: Unable to enable EBUS play IRQ\n", dev); 2027 return -EBUSY; 2028 } 2029 2030 if (snd_cs4231_probe(chip) < 0) { 2031 snd_cs4231_ebus_free(chip); 2032 return -ENODEV; 2033 } 2034 snd_cs4231_init(chip); 2035 2036 err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, 2037 chip, &snd_cs4231_ebus_dev_ops); 2038 if (err < 0) { 2039 snd_cs4231_ebus_free(chip); 2040 return err; 2041 } 2042 2043 return 0; 2044 } 2045 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:for-next 32/83] sound/pcmcia/vx/vxpocket.c:208:8: error: no member named 'dev' in 'struct vx_core'
by kernel test robot 09 Aug '24

09 Aug '24

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: c46fc83e3f3c89f18962e43890de90b1c304747a commit: b426b3ba9f6fe17990893c5324727dd217d420b6 [32/83] ALSA: vx_core: Drop unused dev field config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240809/202408090607.58bm8VK5-lkp@…) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240809/202408090607.58bm8VK5-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202408090607.58bm8VK5-lkp@intel.com/ Note: the tiwai-sound/for-next HEAD c46fc83e3f3c89f18962e43890de90b1c304747a builds fine. It only hurts bisectability. All errors (new ones prefixed by >>): >> sound/pcmcia/vx/vxpocket.c:208:8: error: no member named 'dev' in 'struct vx_core' 208 | chip->dev = &link->dev; | ~~~~ ^ 1 error generated. vim +208 sound/pcmcia/vx/vxpocket.c 6d00a3127972e7 Takashi Iwai 2005-06-30 170 6d00a3127972e7 Takashi Iwai 2005-06-30 171 6d00a3127972e7 Takashi Iwai 2005-06-30 172 /* 6d00a3127972e7 Takashi Iwai 2005-06-30 173 * configuration callback 6d00a3127972e7 Takashi Iwai 2005-06-30 174 */ 6d00a3127972e7 Takashi Iwai 2005-06-30 175 15b99ac1729503 Dominik Brodowski 2006-03-31 176 static int vxpocket_config(struct pcmcia_device *link) 6d00a3127972e7 Takashi Iwai 2005-06-30 177 { af26367f69a474 Takashi Iwai 2005-11-17 178 struct vx_core *chip = link->priv; 7c5af6ffd69bb2 Dominik Brodowski 2009-10-24 179 int ret; 6d00a3127972e7 Takashi Iwai 2005-06-30 180 6d00a3127972e7 Takashi Iwai 2005-06-30 181 snd_printdd(KERN_DEBUG "vxpocket_config called\n"); 6d00a3127972e7 Takashi Iwai 2005-06-30 182 6d00a3127972e7 Takashi Iwai 2005-06-30 183 /* redefine hardware record according to the VERSION1 string */ af2b3b503ad1b0 Dominik Brodowski 2006-10-25 184 if (!strcmp(link->prod_id[1], "VX-POCKET")) { 6d00a3127972e7 Takashi Iwai 2005-06-30 185 snd_printdd("VX-pocket is detected\n"); 6d00a3127972e7 Takashi Iwai 2005-06-30 186 } else { 6d00a3127972e7 Takashi Iwai 2005-06-30 187 snd_printdd("VX-pocket 440 is detected\n"); 6d00a3127972e7 Takashi Iwai 2005-06-30 188 /* overwrite the hardware information */ 6d00a3127972e7 Takashi Iwai 2005-06-30 189 chip->hw = &vxp440_hw; 6d00a3127972e7 Takashi Iwai 2005-06-30 190 chip->type = vxp440_hw.type; 6d00a3127972e7 Takashi Iwai 2005-06-30 191 strcpy(chip->card->driver, vxp440_hw.name); 6d00a3127972e7 Takashi Iwai 2005-06-30 192 } 6d00a3127972e7 Takashi Iwai 2005-06-30 193 90abdc3b973229 Dominik Brodowski 2010-07-24 194 ret = pcmcia_request_io(link); 7c5af6ffd69bb2 Dominik Brodowski 2009-10-24 195 if (ret) db0a5214b8d6cc Takashi Iwai 2014-09-09 196 goto failed_preirq; 7c5af6ffd69bb2 Dominik Brodowski 2009-10-24 197 db0a5214b8d6cc Takashi Iwai 2014-09-09 198 ret = request_threaded_irq(link->irq, snd_vx_irq_handler, db0a5214b8d6cc Takashi Iwai 2014-09-09 199 snd_vx_threaded_irq_handler, db0a5214b8d6cc Takashi Iwai 2014-09-09 200 IRQF_SHARED, link->devname, link->priv); 7c5af6ffd69bb2 Dominik Brodowski 2009-10-24 201 if (ret) db0a5214b8d6cc Takashi Iwai 2014-09-09 202 goto failed_preirq; 7c5af6ffd69bb2 Dominik Brodowski 2009-10-24 203 1ac71e5a35eebe Dominik Brodowski 2010-07-29 204 ret = pcmcia_enable_device(link); 7c5af6ffd69bb2 Dominik Brodowski 2009-10-24 205 if (ret) 7c5af6ffd69bb2 Dominik Brodowski 2009-10-24 206 goto failed; 6d00a3127972e7 Takashi Iwai 2005-06-30 207 dd2e5a156525f1 Dominik Brodowski 2009-11-03 @208 chip->dev = &link->dev; 6d00a3127972e7 Takashi Iwai 2005-06-30 209 9a017a910346af Dominik Brodowski 2010-07-24 210 if (snd_vxpocket_assign_resources(chip, link->resource[0]->start, 9a017a910346af Dominik Brodowski 2010-07-24 211 link->irq) < 0) 6d00a3127972e7 Takashi Iwai 2005-06-30 212 goto failed; 6d00a3127972e7 Takashi Iwai 2005-06-30 213 79ca4f3f625e14 Takashi Iwai 2006-04-12 214 return 0; 6d00a3127972e7 Takashi Iwai 2005-06-30 215 6d00a3127972e7 Takashi Iwai 2005-06-30 216 failed: db0a5214b8d6cc Takashi Iwai 2014-09-09 217 free_irq(link->irq, link->priv); db0a5214b8d6cc Takashi Iwai 2014-09-09 218 failed_preirq: fba395eee7d3f3 Dominik Brodowski 2006-03-31 219 pcmcia_disable_device(link); 15b99ac1729503 Dominik Brodowski 2006-03-31 220 return -ENODEV; 6d00a3127972e7 Takashi Iwai 2005-06-30 221 } 6d00a3127972e7 Takashi Iwai 2005-06-30 222 :::::: The code at line 208 was first introduced by commit :::::: dd2e5a156525f11754d9b1e0583f6bb49c253d62 pcmcia: remove deprecated handle_to_dev() macro :::::: TO: Dominik Brodowski <linux(a)dominikbrodowski.net> :::::: CC: Dominik Brodowski <linux(a)dominikbrodowski.net> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH v2] ASoC: meson: axg-fifo: fix irq scheduling issue with PREEMPT_RT
by Jerome Brunet 09 Aug '24

09 Aug '24

With PREEMPT_RT enabled a spinlock_t becomes a sleeping lock. This is usually not a problem with spinlocks used in IRQ context since IRQ handlers get threaded. However, if IRQF_ONESHOT is set, the primary handler won't be force-threaded and runs always in hardirq context. This is a problem because spinlock_t requires a preemptible context on PREEMPT_RT. In this particular instance, regmap mmio uses spinlock_t to protect the register access and IRQF_ONESHOT is set on the IRQ. In this case, it is actually better to do everything in threaded handler and it solves the problem with PREEMPT_RT. Reported-by: Arseniy Krasnov <avkrasnov(a)salutedevices.com> Closes: https://lore.kernel.org/linux-amlogic/20240729131652.3012327-1-avkrasnov@sa… Suggested-by: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Fixes: b11d26660dff ("ASoC: meson: axg-fifo: use threaded irq to check periods") Signed-off-by: Jerome Brunet <jbrunet(a)baylibre.com> --- sound/soc/meson/axg-fifo.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c index 7e6090af720b..75909196b769 100644 --- a/sound/soc/meson/axg-fifo.c +++ b/sound/soc/meson/axg-fifo.c @@ -207,25 +207,18 @@ static irqreturn_t axg_fifo_pcm_irq_block(int irq, void *dev_id) status = FIELD_GET(STATUS1_INT_STS, status); axg_fifo_ack_irq(fifo, status); - /* Use the thread to call period elapsed on nonatomic links */ - if (status & FIFO_INT_COUNT_REPEAT) - return IRQ_WAKE_THREAD; + if (status & ~FIFO_INT_COUNT_REPEAT) + dev_dbg(axg_fifo_dev(ss), "unexpected irq - STS 0x%02x\n", + status); - dev_dbg(axg_fifo_dev(ss), "unexpected irq - STS 0x%02x\n", - status); + if (status & FIFO_INT_COUNT_REPEAT) { + snd_pcm_period_elapsed(ss); + return IRQ_HANDLED; + } return IRQ_NONE; } -static irqreturn_t axg_fifo_pcm_irq_block_thread(int irq, void *dev_id) -{ - struct snd_pcm_substream *ss = dev_id; - - snd_pcm_period_elapsed(ss); - - return IRQ_HANDLED; -} - int axg_fifo_pcm_open(struct snd_soc_component *component, struct snd_pcm_substream *ss) { @@ -251,8 +244,9 @@ int axg_fifo_pcm_open(struct snd_soc_component *component, if (ret) return ret; - ret = request_threaded_irq(fifo->irq, axg_fifo_pcm_irq_block, - axg_fifo_pcm_irq_block_thread, + /* Use the threaded irq handler only with non-atomic links */ + ret = request_threaded_irq(fifo->irq, NULL, + axg_fifo_pcm_irq_block, IRQF_ONESHOT, dev_name(dev), ss); if (ret) return ret; -- 2.43.0

3 2

[PATCH 1/4] ASoC: dt-bindings: qcom,wcd937x: Correct reset GPIO polarity in example
by Krzysztof Kozlowski 09 Aug '24

09 Aug '24

The reset GPIO of WCD9370/WCD9375 is active low and that's how it is routed on typical boards, so correct the example DTS to use expected polarity. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- Cc: Alexey Klimov <alexey.klimov(a)linaro.org> --- Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml index de397d879acc..f94203798f24 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml @@ -42,7 +42,7 @@ examples: pinctrl-names = "default", "sleep"; pinctrl-0 = <&wcd_reset_n>; pinctrl-1 = <&wcd_reset_n_sleep>; - reset-gpios = <&tlmm 83 GPIO_ACTIVE_HIGH>; + reset-gpios = <&tlmm 83 GPIO_ACTIVE_LOW>; vdd-buck-supply = <&vreg_l17b_1p8>; vdd-rxtx-supply = <&vreg_l18b_1p8>; vdd-px-supply = <&vreg_l18b_1p8>; -- 2.43.0

2 4

[PATCH v2 0/3] ASoC: tas*: Fix up GPIO usage
by Linus Walleij 09 Aug '24

09 Aug '24

The TI TAS drivers use some legacy GPIO code and headers, this series fixes it up. The TAS2781 is a special case since it adds a handful of lines of deviating code to reconfigure a GPIO line for IRQ mode and then never actually use the IRQ obtained in the code. Is the line used by autonomous hardware? I'm puzzled by this. Anyways the patch suggest how to solve this properly by fixing the parent irqchip and I'm happy to help. Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> --- Changes in v2: - Rebased onto v6.11-rc1 - Link to v1: https://lore.kernel.org/r/20240701-asoc-tas-gpios-v1-0-d69ec5d79939@linaro.… --- Linus Walleij (3): ASoC: tas2781-i2c: Drop weird GPIO code ASoC: tas2781-i2c: Get the right GPIO line ASoC: tas*: Drop unused GPIO includes include/sound/tas2781.h | 7 +------ sound/pci/hda/tas2781_hda_i2c.c | 2 +- sound/soc/codecs/tas2552.c | 1 - sound/soc/codecs/tas2764.c | 1 - sound/soc/codecs/tas2770.c | 1 - sound/soc/codecs/tas2780.c | 1 - sound/soc/codecs/tas2781-comlib.c | 3 --- sound/soc/codecs/tas2781-fmwlib.c | 1 - sound/soc/codecs/tas2781-i2c.c | 26 ++++---------------------- 9 files changed, 6 insertions(+), 37 deletions(-) --- base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b change-id: 20240701-asoc-tas-gpios-5c051d80d768 Best regards, -- Linus Walleij <linus.walleij(a)linaro.org>

2 4

[PATCH] ASoC: cs35l56: Patch CS35L56_IRQ1_MASK_18 to the default value
by Simon Trimmer 09 Aug '24

09 Aug '24

Device tuning files made with early revision tooling may contain configuration that can unmask IRQ signals that are owned by the host. Adding a safe default to the regmap patch ensures that the hardware matches the driver expectations. Signed-off-by: Simon Trimmer <simont(a)opensource.cirrus.com> --- sound/soc/codecs/cs35l56-shared.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/cs35l56-shared.c b/sound/soc/codecs/cs35l56-shared.c index e7e8d617da94..bd74fef33d49 100644 --- a/sound/soc/codecs/cs35l56-shared.c +++ b/sound/soc/codecs/cs35l56-shared.c @@ -36,6 +36,7 @@ static const struct reg_sequence cs35l56_patch[] = { { CS35L56_SWIRE_DP3_CH2_INPUT, 0x00000019 }, { CS35L56_SWIRE_DP3_CH3_INPUT, 0x00000029 }, { CS35L56_SWIRE_DP3_CH4_INPUT, 0x00000028 }, + { CS35L56_IRQ1_MASK_18, 0x1f7df0ff }, /* These are not reset by a soft-reset, so patch to defaults. */ { CS35L56_MAIN_RENDER_USER_MUTE, 0x00000000 }, -- 2.43.0

2 1

[PATCH 0/2] ASoC: codecs: ES8326: button and input issue
by Zhang Yi 08 Aug '24

08 Aug '24

TO solve button and input issue, We have modified parts of the driver related to button and input. Zhang Yi (2): ASoC: codecs: ES8326: button detect issue ASoC: codecs: ES8326: input issue after init sound/soc/codecs/es8326.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.17.1

2 3

[PATCH] ASoC: amd: acp: add ZSC control register programming sequence
by Vijendar Mukunda 08 Aug '24

08 Aug '24

Add ZSC Control register programming sequence for ACP D0 and D3 state transitions for ACP7.0 onwards. This will allow ACP to enter low power state when ACP enters D3 state. When ACP enters D0 State, ZSC control should be disabled. Tested-by: Leo Li <sunpeng.li(a)amd.com> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/soc/amd/acp/acp-legacy-common.c | 5 +++++ sound/soc/amd/acp/amd.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/sound/soc/amd/acp/acp-legacy-common.c b/sound/soc/amd/acp/acp-legacy-common.c index 4422cec81e3c..04bd605fdce3 100644 --- a/sound/soc/amd/acp/acp-legacy-common.c +++ b/sound/soc/amd/acp/acp-legacy-common.c @@ -321,6 +321,8 @@ int acp_init(struct acp_chip_info *chip) pr_err("ACP reset failed\n"); return ret; } + if (chip->acp_rev >= ACP70_DEV) + writel(0, chip->base + ACP_ZSC_DSP_CTRL); return 0; } EXPORT_SYMBOL_NS_GPL(acp_init, SND_SOC_ACP_COMMON); @@ -336,6 +338,9 @@ int acp_deinit(struct acp_chip_info *chip) if (chip->acp_rev != ACP70_DEV) writel(0, chip->base + ACP_CONTROL); + + if (chip->acp_rev >= ACP70_DEV) + writel(0x01, chip->base + ACP_ZSC_DSP_CTRL); return 0; } EXPORT_SYMBOL_NS_GPL(acp_deinit, SND_SOC_ACP_COMMON); diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h index 87a4813783f9..c095a34a7229 100644 --- a/sound/soc/amd/acp/amd.h +++ b/sound/soc/amd/acp/amd.h @@ -103,6 +103,8 @@ #define ACP70_PGFSM_CONTROL ACP6X_PGFSM_CONTROL #define ACP70_PGFSM_STATUS ACP6X_PGFSM_STATUS +#define ACP_ZSC_DSP_CTRL 0x0001014 +#define ACP_ZSC_STS 0x0001018 #define ACP_SOFT_RST_DONE_MASK 0x00010001 #define ACP_PGFSM_CNTL_POWER_ON_MASK 0xffffffff -- 2.34.1

2 1