August 2024 - Alsa-devel - mailman.alsa-project.org

Port API coverage reporting to Python 3 and adapt to current doxygen output
by GitHub pull_request - opened 18 Aug '24

18 Aug '24

alsa-project/alsa-python pull request #15 was opened from tormodvolden: Tested by comparing the new output from alsa-python-coverage.py with the old COVERAGE file. For transparency and easier review there are multiple commits for the Python 3 fixups, but this can be squashed if desired. Request URL : https://github.com/alsa-project/alsa-python/pull/15 Patch URL : https://github.com/alsa-project/alsa-python/pull/15.patch Repository URL: https://github.com/alsa-project/alsa-python

1 0

Add persistent ID's for soundcards and midi devices (like coreaudio)
by GitHub issues - opened 18 Aug '24

18 Aug '24

alsa-project/alsa-lib issue #407 was opened from sjomae: "This is something where macOS' Coreaudio/MIDI shines. Unlike macOS Linux/ALSA has no persistent unique IDs for soundcards or MIDI devices. ALSA supports hotplug, and first come first server sequential numeric IDs. The best you^Wpipewire can do is keep track of cards by name. So this is not something pipewire can reliably address, until ALSA get support to identify cards by vendor and serial-number, and provide a UUID." https://lists.linuxaudio.org/hyperkitty/list/linux-audio-dev@lists.linuxaud… Issue URL : https://github.com/alsa-project/alsa-lib/issues/407 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 1/1] ASoC: dt-bindings: Convert tpa6130a2.txt to yaml
by Frank Li 16 Aug '24

16 Aug '24

Convert binding doc tpa6130a2.txt to yaml format. Additional change: - add ref to dai-common.yaml - add i2c node in example Fix below warning: arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb: /soc@0/bus@30800000/i2c@30a20000/amp@60: failed to match any schema with compatible: ['ti,tpa6130a2'] Signed-off-by: Frank Li <Frank.Li(a)nxp.com> --- .../bindings/sound/ti,tpa6130a2.yaml | 55 +++++++++++++++++++ .../devicetree/bindings/sound/tpa6130a2.txt | 27 --------- 2 files changed, 55 insertions(+), 27 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/ti,tpa6130a2.yaml delete mode 100644 Documentation/devicetree/bindings/sound/tpa6130a2.txt diff --git a/Documentation/devicetree/bindings/sound/ti,tpa6130a2.yaml b/Documentation/devicetree/bindings/sound/ti,tpa6130a2.yaml new file mode 100644 index 0000000000000..a42bf9bde6940 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,tpa6130a2.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,tpa6130a2.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments - tpa6130a2 Codec module + +maintainers: + - Sebastian Reichel <sre(a)kernel.org> + +description: + Stereo, analog input headphone amplifier + +properties: + compatible: + enum: + - ti,tpa6130a2 + - ti,tpa6140a2 + + reg: + maxItems: 1 + + Vdd-supply: + description: power supply regulator + + power-gpio: + description: gpio pin to power the device + +required: + - compatible + - reg + - Vdd-supply + +allOf: + - $ref: dai-common.yaml# + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + amplifier@60 { + compatible = "ti,tpa6130a2"; + reg = <0x60>; + Vdd-supply = <&vmmc2>; + power-gpio = <&gpio4 2 GPIO_ACTIVE_HIGH>; + }; + }; + diff --git a/Documentation/devicetree/bindings/sound/tpa6130a2.txt b/Documentation/devicetree/bindings/sound/tpa6130a2.txt deleted file mode 100644 index 6dfa740e4b2d8..0000000000000 --- a/Documentation/devicetree/bindings/sound/tpa6130a2.txt +++ /dev/null @@ -1,27 +0,0 @@ -Texas Instruments - tpa6130a2 Codec module - -The tpa6130a2 serial control bus communicates through I2C protocols - -Required properties: - -- compatible - "string" - One of: - "ti,tpa6130a2" - TPA6130A2 - "ti,tpa6140a2" - TPA6140A2 - - -- reg - <int> - I2C slave address - -- Vdd-supply - <phandle> - power supply regulator - -Optional properties: - -- power-gpio - gpio pin to power the device - -Example: - -tpa6130a2: tpa6130a2@60 { - compatible = "ti,tpa6130a2"; - reg = <0x60>; - Vdd-supply = <&vmmc2>; - power-gpio = <&gpio4 2 GPIO_ACTIVE_HIGH>; -}; -- 2.34.1

3 2

ASUS Maximus Z790 Hero (ALC4082) - USB Audio 5.1 speakers assigned incorrectly and subwoofer not working
by GitHub issues - opened 16 Aug '24

16 Aug '24

alsa-project/alsa-ucm-conf issue #437 was opened from Gess79: I hope I'm correct to post this here. Still new to things Linux. **Situation** OS: Kubuntu 24.04 Mainboard = ASUS ROG Maximus Z790 Hero USB Audio = 0b05:1a53 ASUSTek Computer, Inc. USB Audio Speakers = Logitech Z906 Surround Kernel = 6.8.0-40-generic Alsa version = 1.2.9 **Issue** The speakers seem to be assigned incorrectly and the subwoofer isn't working. I'm testing the speakers through pulseaudio as follows: ![image](https://github.com/user-attachments/assets/8bf65600-63ad-46cc-af68-d51ab6d4a7e6) I'm listing the results below in three categories: - The icon clicked within pulseaudio - The soundfile played - The speaker the sound is actually output to _Icon clicked - Soundfile played - Physical speaker output_ Front Left - Front Left - Front Left Front Center - Front Center - Rear Left Front Right - Front Right - Front Right Rear Left - Rear Left - Front Center Subwoofer - Rear Center - Rear Right Rear Right - (nothing) - (nothing) I've had a lengthy discussion on Reddit but I couldn't find a fix for it so far: https://www.reddit.com/r/linux4noobs/comments/1980uv1/comment/kieqsor/ I'm happy to provide all information necessary to pinpoint the issue and fix it. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/437 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Use PyBytes and not Unicode strings for IEC958 values
by GitHub pull_request - edited 16 Aug '24

16 Aug '24

alsa-project/alsa-python pull request #14 was edited from tormodvolden: Suggested fix for #13. - the first commit is not strictly related but also needed to avoid hctltest1.py crashing with my audio devices, where some have info.count = 0. Let me know if more information is needed. I don't know if this is expected or if a warning should be issued. - I went for PyBytes instead of PyByteArray - for setting values, if the provided PyBytes value is shorter than the value, it will be zero-padded. - if it is too long, it will be silently truncated - following the existing code style, no empty lines were inserted, but this could help readability - the third commit is not for fixing the crash, but for fixing set_tuple() to actually do anything for IEC958 - I haven't changed the reference counting, which seems wrong to me in the original code as well. This would be a different issue. Request URL : https://github.com/alsa-project/alsa-python/pull/14 Patch URL : https://github.com/alsa-project/alsa-python/pull/14.patch Repository URL: https://github.com/alsa-project/alsa-python

1 0

Use PyBytes and not Unicode strings for IEC958 values
by GitHub pull_request - edited 16 Aug '24

16 Aug '24

alsa-project/alsa-python pull request #14 was edited from tormodvolden: Suggested fix for #13. - the first commit is not strictly related but also needed to avoid hctltest1.py crashing with my audio devices, where some have info.count = 0. Let me know if more information is needed. I don't know if this is expected or if a warning should be issued. - I went for PyBytes instead of PyByteArray - for setting values, if the provided PyBytes value is shorter than the value, it will be zero-padded. - if it is too long, it will be silently truncated - following the existing code style, no empty lines were inserted, but this could help readability - the third commit is not for fixing the crash, but for fixing set_tuple() to actually do anything for IEC958 Request URL : https://github.com/alsa-project/alsa-python/pull/14 Patch URL : https://github.com/alsa-project/alsa-python/pull/14.patch Repository URL: https://github.com/alsa-project/alsa-python

1 0

[PATCH] ASoC: dt-bindings: qcom,lpass-wsa-macro: correct clocks on SM8250
by srinivas.kandagatla＠linaro.org 16 Aug '24

16 Aug '24

From: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> we seems to have ended up with duplicate clocks for frame-sync on sm8250, it has both va and fsgen which are exactly same things. Remove the redundant va clock and make it align with other SoCs. Codec driver does not even handle va clock, so remove this from the bindings and examples to avoid any confusion. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- .../bindings/sound/qcom,lpass-wsa-macro.yaml | 22 ++----------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml index 06b5f7be3608..6f5644a89feb 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml @@ -64,6 +64,7 @@ allOf: compatible: enum: - qcom,sc7280-lpass-wsa-macro + - qcom,sm8250-lpass-wsa-macro - qcom,sm8450-lpass-wsa-macro - qcom,sc8280xp-lpass-wsa-macro then: @@ -79,24 +80,6 @@ allOf: - const: dcodec - const: fsgen - - if: - properties: - compatible: - enum: - - qcom,sm8250-lpass-wsa-macro - then: - properties: - clocks: - minItems: 6 - clock-names: - items: - - const: mclk - - const: npl - - const: macro - - const: dcodec - - const: va - - const: fsgen - - if: properties: compatible: @@ -130,8 +113,7 @@ examples: <&audiocc 0>, <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, - <&aoncc LPASS_CDC_VA_MCLK>, <&vamacro>; - clock-names = "mclk", "npl", "macro", "dcodec", "va", "fsgen"; + clock-names = "mclk", "npl", "macro", "dcodec", "fsgen"; clock-output-names = "mclk"; }; -- 2.25.1

3 2

[PATCH v1] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781
by Shenghao Ding 16 Aug '24

16 Aug '24

Rename dai_driver name to unify the name between TAS2563 and TAS2781, remove unnecessary line feed, strscpy replace scnprintf. Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- v1: - Use strscpy to replace scnprintf. - rename dai_driver name from "tas2781_codec" to "tasdev_codec", in case of misunderstanding whether tas2781 or tas2563. - Remove unnecessary line feed for tasdevice_dsp_create_ctrls --- sound/soc/codecs/tas2781-i2c.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index 8a57c045afdd..6631254d4985 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -353,7 +353,7 @@ static int tasdevice_create_control(struct tasdevice_priv *tas_priv) ret = -ENOMEM; goto out; } - scnprintf(name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, "Speaker Profile Id"); + strscpy(name, "Speaker Profile Id", SNDRV_CTL_ELEM_ID_NAME_MAXLEN); prof_ctrls[mix_index].name = name; prof_ctrls[mix_index].iface = SNDRV_CTL_ELEM_IFACE_MIXER; prof_ctrls[mix_index].info = tasdevice_info_profile; @@ -424,8 +424,7 @@ static int tasdevice_configuration_put( return ret; } -static int tasdevice_dsp_create_ctrls( - struct tasdevice_priv *tas_priv) +static int tasdevice_dsp_create_ctrls(struct tasdevice_priv *tas_priv) { struct snd_kcontrol_new *dsp_ctrls; char *prog_name, *conf_name; @@ -453,8 +452,8 @@ static int tasdevice_dsp_create_ctrls( goto out; } - scnprintf(prog_name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, - "Speaker Program Id"); + strscpy(prog_name, "Speaker Program Id", + SNDRV_CTL_ELEM_ID_NAME_MAXLEN); dsp_ctrls[mix_index].name = prog_name; dsp_ctrls[mix_index].iface = SNDRV_CTL_ELEM_IFACE_MIXER; dsp_ctrls[mix_index].info = tasdevice_info_programs; @@ -462,8 +461,7 @@ static int tasdevice_dsp_create_ctrls( dsp_ctrls[mix_index].put = tasdevice_program_put; mix_index++; - scnprintf(conf_name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, - "Speaker Config Id"); + strscpy(conf_name, "Speaker Config Id", SNDRV_CTL_ELEM_ID_NAME_MAXLEN); dsp_ctrls[mix_index].name = conf_name; dsp_ctrls[mix_index].iface = SNDRV_CTL_ELEM_IFACE_MIXER; dsp_ctrls[mix_index].info = tasdevice_info_configurations; @@ -673,7 +671,7 @@ static const struct snd_soc_dai_ops tasdevice_dai_ops = { static struct snd_soc_dai_driver tasdevice_dai_driver[] = { { - .name = "tas2781_codec", + .name = "tasdev_codec", .id = 0, .playback = { .stream_name = "Playback", -- 2.34.1

4 6

[PATCH] ASoC: SOF: amd: Fix for acp init sequence
by Vijendar Mukunda 16 Aug '24

16 Aug '24

When ACP is not powered on by default, acp power on sequence explicitly invoked by programming pgfsm control mask. The existing implementation checks the same PGFSM status mask and programs the same PGFSM control mask in all ACP variants which breaks acp power on sequence for ACP6.0 and ACP6.3 variants. So to fix this issue, update ACP pgfsm control mask and status mask based on acp descriptor rev field, which will vary based on acp variant. Fixes: 846aef1d7cc0 ("ASoC: SOF: amd: Add Renoir ACP HW support") Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/soc/sof/amd/acp.c | 19 +++++++++++++++++-- sound/soc/sof/amd/acp.h | 7 +++++-- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c index 35e56d22930f..0f6115c8b005 100644 --- a/sound/soc/sof/amd/acp.c +++ b/sound/soc/sof/amd/acp.c @@ -433,6 +433,7 @@ static int acp_power_on(struct snd_sof_dev *sdev) const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata); unsigned int base = desc->pgfsm_base; unsigned int val; + unsigned int acp_pgfsm_status_mask, acp_pgfsm_cntl_mask; int ret; val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, base + PGFSM_STATUS_OFFSET); @@ -440,9 +441,23 @@ static int acp_power_on(struct snd_sof_dev *sdev) if (val == ACP_POWERED_ON) return 0; - if (val & ACP_PGFSM_STATUS_MASK) + switch (desc->rev) { + case 3: + case 5: + acp_pgfsm_status_mask = ACP3X_PGFSM_STATUS_MASK; + acp_pgfsm_cntl_mask = ACP3X_PGFSM_CNTL_POWER_ON_MASK; + break; + case 6: + acp_pgfsm_status_mask = ACP6X_PGFSM_STATUS_MASK; + acp_pgfsm_cntl_mask = ACP6X_PGFSM_CNTL_POWER_ON_MASK; + break; + default: + return -EINVAL; + } + + if (val & acp_pgfsm_status_mask) snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + PGFSM_CONTROL_OFFSET, - ACP_PGFSM_CNTL_POWER_ON_MASK); + acp_pgfsm_cntl_mask); ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, base + PGFSM_STATUS_OFFSET, val, !val, ACP_REG_POLL_INTERVAL, ACP_REG_POLL_TIMEOUT_US); diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h index f6f0fcfeb691..321c40cc6d50 100644 --- a/sound/soc/sof/amd/acp.h +++ b/sound/soc/sof/amd/acp.h @@ -25,8 +25,11 @@ #define ACP_REG_POLL_TIMEOUT_US 2000 #define ACP_DMA_COMPLETE_TIMEOUT_US 5000 -#define ACP_PGFSM_CNTL_POWER_ON_MASK 0x01 -#define ACP_PGFSM_STATUS_MASK 0x03 +#define ACP3X_PGFSM_CNTL_POWER_ON_MASK 0x01 +#define ACP3X_PGFSM_STATUS_MASK 0x03 +#define ACP6X_PGFSM_CNTL_POWER_ON_MASK 0x07 +#define ACP6X_PGFSM_STATUS_MASK 0x0F + #define ACP_POWERED_ON 0x00 #define ACP_ASSERT_RESET 0x01 #define ACP_RELEASE_RESET 0x00 -- 2.34.1

2 1

Use PyBytes and not Unicode strings for IEC958 values
by GitHub pull_request - edited 16 Aug '24

16 Aug '24

alsa-project/alsa-python pull request #14 was edited from tormodvolden: Suggested fix for #13. - the first commit is not strictly related but also needed to avoid hctltest1.py crashing with my audio devices, where some have info.count = 0. Let me know if more information is needed. I don't know if this is expected or if a warning should be issued. - I went for PyBytes instead of PyByteArray - for setting values, if the provided PyBytes value is shorter than the value, it will be zero-padded. - if it is too long, it will be silently truncated - following the existing code style, no empty lines were inserted, but this could help readability Request URL : https://github.com/alsa-project/alsa-python/pull/14 Patch URL : https://github.com/alsa-project/alsa-python/pull/14.patch Repository URL: https://github.com/alsa-project/alsa-python

1 0