November 2024 - Alsa-devel - mailman.alsa-project.org

src/Versions.in.in: Update *_tempo_base name
by GitHub pull_request - opened 14 Nov '24

14 Nov '24

alsa-project/alsa-lib pull request #421 was opened from nvinson: Change @SYMBOL_PREFIX@snd_has_tempo_base to @SYMBOL_PREFIX@snd_has_queue_tempo_base. Starting with version 1.2.13, alsa-lib fails to link with ld.lld-19 due to "version script assignment of 'ALSA_1.2.13' to symbol 'snd_seq_has_tempo_base' failed: symbol not defined". Per commit 769d1db1b0a213a39c7e59c0d1d724e7f45b1ac3 the correct name for the symbol is @SYMBOL_PREFIX@snd_has_queue_tempo_base; therefore, update src/Vesions.in.in to match. Fixes bug 420 Fixes Gentoo bug 943399 (https://bugs.gentoo.org/943399) Request URL : https://github.com/alsa-project/alsa-lib/pull/421 Patch URL : https://github.com/alsa-project/alsa-lib/pull/421.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

alsa-lib-1.2.13: ld.lld: error: version script assignment of 'ALSA_1.2.13' to symbol 'snd_seq_has_tempo_base' failed: symbol not defined
by GitHub issues - opened 14 Nov '24

14 Nov '24

alsa-project/alsa-lib issue #420 was opened from nvinson: libasound.so fails to link with ld.lld with error ```ld.lld: error: version script assignment of 'ALSA_1.2.13' to symbol 'snd_seq_has_tempo_base' failed: symbol not defined``` Bug: [Gentoo bug 943399](https://bugs.gentoo.org/9433399) Issue URL : https://github.com/alsa-project/alsa-lib/issues/420 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

udevd[142]: GOTO 'alsa_restore_std' has no matching label in: '/usr/lib/udev/rules.d/90-alsa-restore.rules'
by GitHub issues - opened 14 Nov '24

14 Nov '24

alsa-project/alsa-utils issue #280 was opened from sxzzsf: There is no 'alsa_restore_std' label in the udev rule file, is it misspelled alsa_restore_go? Issue URL : https://github.com/alsa-project/alsa-utils/issues/280 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

UCM2: Intel: sof-hda-dsp: Fix handling of empty sys_vendor string
by GitHub pull_request - opened 13 Nov '24

13 Nov '24

alsa-project/alsa-ucm-conf pull request #463 was opened from singalsu: The mistake in UCM syntax caused in alsaucm start error: ALSA lib ucm_cond.c:367:(if_eval) unknown If.Condition.Type Fixes: 13022a97711d ("sof-hda-dsp: Fix the case where sysfs dmi sys_vendor attribute is not set") Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/463 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/463.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

memory leakage detected in alsa-lib-1.2.9 in Linux-5.10.24
by GitHub issues - edited 13 Nov '24

13 Nov '24

alsa-project/alsa-lib issue #419 was edited from wangtao13: I wrote an ALSA application using alsa-lib-1.2.9, the main logic of the application is ``` static int init_pcm_play(snd_pcm_t **playback_handle...) { snd_pcm_hw_params_t *hw_params; snd_pcm_format_t format; snd_pcm_uframes_t frames, periodsize; int ret; //1. openPCM， if (0 > snd_pcm_open(playback_handle, "default", SND_PCM_STREAM_PLAYBACK, 0)) { return -1; } //2. snd_pcm_hw_params_t if (0 > snd_pcm_hw_params_malloc (&hw_params)) { return -1; } //3. hw_params if (0 > snd_pcm_hw_params_any (*playback_handle, hw_params)) { return -1; } //4. if (0 > snd_pcm_hw_params_set_access (*playback_handle, hw_params, SND_PCM_ACCESS_RW_INTERLEAVED)) { return -1; } //5. SND_PCM_FORMAT_U8,8 if (8 == bits_per_sample) { format = SND_PCM_FORMAT_U8; } if (16 == bits_per_sample) { format = SND_PCM_FORMAT_S16_LE; } if (0 > snd_pcm_hw_params_set_format (*playback_handle, hw_params, format)) { return -1; } //6. if (0 > snd_pcm_hw_params_set_rate_near (*playback_handle, hw_params, &rate, 0)) { return -1; } //7. if (0 > snd_pcm_hw_params_set_channels(*playback_handle, hw_params, channels)) { return -1; } frames = 64; periodsize = frames; ret = snd_pcm_hw_params_set_buffer_size_near(*playback_handle, hw_params, &periodsize); if (ret < 0) { printf("Unable to set buffer size %li : %s\n", frames * 2, snd_strerror(ret)); } periodsize /= channels; ret = snd_pcm_hw_params_set_period_size_near(*playback_handle, hw_params, &periodsize, 0); if (ret < 0) { printf("Unable to set period size %li : %s\n", periodsize, snd_strerror(ret)); } //8. set hw_params if (0 > snd_pcm_hw_params (*playback_handle, hw_params)) { return -1; } snd_pcm_uframes_t temp; snd_pcm_hw_params_get_buffer_size(hw_params, &temp); printf("Got buffer size: %ld\n", temp); snd_pcm_hw_params_get_period_size(hw_params, &temp, 0); printf("Got period size: %ld\n", temp); snd_pcm_hw_params_free(hw_params); ret = snd_pcm_prepare(playback_handle); if (ret < 0) { printf("snd_pcm_prepare err\n"); } return ret; } int sound_play(playback_handle, ...) { rc = snd_pcm_writei(playback_handle, buf, buflen); if (rc < 0) { if (rc == -EAGAIN) { usleep(1000); return -1; } snd_pcm_prepare(playback_handle); return -1; } else if (rc == 0) { usleep(10 * 1000); } return 0; } int app_exit(....) { snd_pcm_close(*playback_handle); snd_config_update_free_global(); } #define TEST_LOOPS 2 /* > 1, can trigger memory leakage */ int main_test() { init_pcm_play(&playback_handle, ...., ..); for (int i=0; i<2; i++) { pcm_exit(); init_pcm_play(&playback_handle); sound_play(playback_handle) } return 0; } ``` ``` ==5176==ERROR: LeakSanitizer: detected memory leaks Direct leak of 12792 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x7626c458 (/usr/lib/libasound.so.2+0x4c458) Direct leak of 12 byte(s) in 1 object(s) allocated from: #0 0x77901ad8 in __interceptor_posix_memalign /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:155 #1 0x7758b3f4 in av_malloc (/usr/lib/libavutil.so.56+0x3b3f4) Indirect leak of 151552 byte(s) in 37 object(s) allocated from: #0 0x77900acc in __interceptor_malloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:86 #1 0x76281230 in snd_pcm_mmap (/usr/lib/libasound.so.2+0x61230) Indirect leak of 37392 byte(s) in 114 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x7626c458 (/usr/lib/libasound.so.2+0x4c458) Indirect leak of 31200 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762b91b8 in snd_pcm_softvol_open (/usr/lib/libasound.so.2+0x991b8) Indirect leak of 15808 byte(s) in 76 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x76280d1c in snd_pcm_mmap (/usr/lib/libasound.so.2+0x60d1c) Indirect leak of 10032 byte(s) in 38 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762b4e28 (/usr/lib/libasound.so.2+0x94e28) Indirect leak of 5168 byte(s) in 38 object(s) allocated from: #0 0x77900acc in __interceptor_malloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:86 #1 0x7627e644 (/usr/lib/libasound.so.2+0x5e644) Indirect leak of 3344 byte(s) in 38 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x7627e4e0 (/usr/lib/libasound.so.2+0x5e4e0) Indirect leak of 1976 byte(s) in 38 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762939ac in snd_pcm_plug_open (/usr/lib/libasound.so.2+0x739ac) Indirect leak of 1824 byte(s) in 76 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x76280d3c in snd_pcm_mmap (/usr/lib/libasound.so.2+0x60d3c) Indirect leak of 1596 byte(s) in 38 object(s) allocated from: #0 0x7786d584 in __interceptor_strdup /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_interceptors.cc:405 #1 0x762c09b8 in snd_timer_hw_open (/usr/lib/libasound.so.2+0xa09b8) Indirect leak of 1560 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762b7c58 (/usr/lib/libasound.so.2+0x97c58) Indirect leak of 1560 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762512d4 (/usr/lib/libasound.so.2+0x312d4) Indirect leak of 1520 byte(s) in 38 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762c0978 in snd_timer_hw_open (/usr/lib/libasound.so.2+0xa0978) Indirect leak of 1419 byte(s) in 153 object(s) allocated from: #0 0x7786d584 in __interceptor_strdup /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_interceptors.cc:405 #1 0x7626c47c (/usr/lib/libasound.so.2+0x4c47c) Indirect leak of 468 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762572e8 in snd_ctl_hw_open (/usr/lib/libasound.so.2+0x372e8) Indirect leak of 304 byte(s) in 76 object(s) allocated from: #0 0x779011a4 in __interceptor_realloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:105 #1 0x762690c4 (/usr/lib/libasound.so.2+0x490c4) Indirect leak of 273 byte(s) in 1 object(s) allocated from: #0 0x779011a4 in __interceptor_realloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:105 #1 0x77569f3c in av_buffer_realloc (/usr/lib/libavutil.so.56+0x19f3c) Indirect leak of 195 byte(s) in 39 object(s) allocated from: #0 0x7786d584 in __interceptor_strdup /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_interceptors.cc:405 #1 0x762512fc (/usr/lib/libasound.so.2+0x312fc) Indirect leak of 28 byte(s) in 1 object(s) allocated from: #0 0x77901ad8 in __interceptor_posix_memalign /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:155 #1 0x7758b3f4 in av_malloc (/usr/lib/libavutil.so.56+0x3b3f4) SUMMARY: AddressSanitizer: 280023 byte(s) leaked in 997 allocation(s). ``` If the `TEST_LOOPS` is defined as 1, there is NO memory leakage reported by ASAN. Issue URL : https://github.com/alsa-project/alsa-lib/issues/419 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

memory leakage detected in alsa-lib-1.2.9 in Linux-5.10.24
by GitHub issues - opened 13 Nov '24

13 Nov '24

alsa-project/alsa-lib issue #419 was opened from wangtao13: I wrote an ALSA application using alsa-lib-1.2.9, the main logic of the application is ``` static int init_pcm_play(snd_pcm_t **playback_handle...) { snd_pcm_hw_params_t *hw_params; snd_pcm_format_t format; snd_pcm_uframes_t frames, periodsize; int ret; //1. openPCM， if (0 > snd_pcm_open(playback_handle, "default", SND_PCM_STREAM_PLAYBACK, 0)) { return -1; } //2. snd_pcm_hw_params_t if (0 > snd_pcm_hw_params_malloc (&hw_params)) { return -1; } //3. hw_params if (0 > snd_pcm_hw_params_any (*playback_handle, hw_params)) { return -1; } //4. if (0 > snd_pcm_hw_params_set_access (*playback_handle, hw_params, SND_PCM_ACCESS_RW_INTERLEAVED)) { return -1; } //5. SND_PCM_FORMAT_U8,8 if (8 == bits_per_sample) { format = SND_PCM_FORMAT_U8; } if (16 == bits_per_sample) { format = SND_PCM_FORMAT_S16_LE; } if (0 > snd_pcm_hw_params_set_format (*playback_handle, hw_params, format)) { return -1; } //6. if (0 > snd_pcm_hw_params_set_rate_near (*playback_handle, hw_params, &rate, 0)) { return -1; } //7. if (0 > snd_pcm_hw_params_set_channels(*playback_handle, hw_params, channels)) { return -1; } frames = 64; periodsize = frames; ret = snd_pcm_hw_params_set_buffer_size_near(*playback_handle, hw_params, &periodsize); if (ret < 0) { printf("Unable to set buffer size %li : %s\n", frames * 2, snd_strerror(ret)); } periodsize /= channels; ret = snd_pcm_hw_params_set_period_size_near(*playback_handle, hw_params, &periodsize, 0); if (ret < 0) { printf("Unable to set period size %li : %s\n", periodsize, snd_strerror(ret)); } //8. set hw_params if (0 > snd_pcm_hw_params (*playback_handle, hw_params)) { return -1; } snd_pcm_uframes_t temp; snd_pcm_hw_params_get_buffer_size(hw_params, &temp); printf("Got buffer size: %ld\n", temp); snd_pcm_hw_params_get_period_size(hw_params, &temp, 0); printf("Got period size: %ld\n", temp); snd_pcm_hw_params_free(hw_params); ret = snd_pcm_prepare(playback_handle); if (ret < 0) { printf("snd_pcm_prepare err\n"); } return ret; } int sound_play(playback_handle, ...) { rc = snd_pcm_writei(playback_handle, buf, buflen); if (rc < 0) { if (rc == -EAGAIN) { usleep(1000); return -1; } snd_pcm_prepare(playback_handle); return -1; } else if (rc == 0) { usleep(10 * 1000); } return 0; } int app_exit(....) { snd_pcm_close(*playback_handle); snd_config_update_free_global(); } int main_test() { init_pcm_play(&playback_handle, ...., ..); for (int i=0; i<2; i++) { pcm_exit(); init_pcm_play(&playback_handle); sound_play(playback_handle) } return 0; } ``` ``` ==5176==ERROR: LeakSanitizer: detected memory leaks Direct leak of 12792 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x7626c458 (/usr/lib/libasound.so.2+0x4c458) Direct leak of 12 byte(s) in 1 object(s) allocated from: #0 0x77901ad8 in __interceptor_posix_memalign /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:155 #1 0x7758b3f4 in av_malloc (/usr/lib/libavutil.so.56+0x3b3f4) Indirect leak of 151552 byte(s) in 37 object(s) allocated from: #0 0x77900acc in __interceptor_malloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:86 #1 0x76281230 in snd_pcm_mmap (/usr/lib/libasound.so.2+0x61230) Indirect leak of 37392 byte(s) in 114 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x7626c458 (/usr/lib/libasound.so.2+0x4c458) Indirect leak of 31200 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762b91b8 in snd_pcm_softvol_open (/usr/lib/libasound.so.2+0x991b8) Indirect leak of 15808 byte(s) in 76 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x76280d1c in snd_pcm_mmap (/usr/lib/libasound.so.2+0x60d1c) Indirect leak of 10032 byte(s) in 38 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762b4e28 (/usr/lib/libasound.so.2+0x94e28) Indirect leak of 5168 byte(s) in 38 object(s) allocated from: #0 0x77900acc in __interceptor_malloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:86 #1 0x7627e644 (/usr/lib/libasound.so.2+0x5e644) Indirect leak of 3344 byte(s) in 38 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x7627e4e0 (/usr/lib/libasound.so.2+0x5e4e0) Indirect leak of 1976 byte(s) in 38 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762939ac in snd_pcm_plug_open (/usr/lib/libasound.so.2+0x739ac) Indirect leak of 1824 byte(s) in 76 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x76280d3c in snd_pcm_mmap (/usr/lib/libasound.so.2+0x60d3c) Indirect leak of 1596 byte(s) in 38 object(s) allocated from: #0 0x7786d584 in __interceptor_strdup /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_interceptors.cc:405 #1 0x762c09b8 in snd_timer_hw_open (/usr/lib/libasound.so.2+0xa09b8) Indirect leak of 1560 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762b7c58 (/usr/lib/libasound.so.2+0x97c58) Indirect leak of 1560 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762512d4 (/usr/lib/libasound.so.2+0x312d4) Indirect leak of 1520 byte(s) in 38 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762c0978 in snd_timer_hw_open (/usr/lib/libasound.so.2+0xa0978) Indirect leak of 1419 byte(s) in 153 object(s) allocated from: #0 0x7786d584 in __interceptor_strdup /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_interceptors.cc:405 #1 0x7626c47c (/usr/lib/libasound.so.2+0x4c47c) Indirect leak of 468 byte(s) in 39 object(s) allocated from: #0 0x77900d24 in __interceptor_calloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:95 #1 0x762572e8 in snd_ctl_hw_open (/usr/lib/libasound.so.2+0x372e8) Indirect leak of 304 byte(s) in 76 object(s) allocated from: #0 0x779011a4 in __interceptor_realloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:105 #1 0x762690c4 (/usr/lib/libasound.so.2+0x490c4) Indirect leak of 273 byte(s) in 1 object(s) allocated from: #0 0x779011a4 in __interceptor_realloc /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:105 #1 0x77569f3c in av_buffer_realloc (/usr/lib/libavutil.so.56+0x19f3c) Indirect leak of 195 byte(s) in 39 object(s) allocated from: #0 0x7786d584 in __interceptor_strdup /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_interceptors.cc:405 #1 0x762512fc (/usr/lib/libasound.so.2+0x312fc) Indirect leak of 28 byte(s) in 1 object(s) allocated from: #0 0x77901ad8 in __interceptor_posix_memalign /home/users/at/work/arm-gnu-toolchain/arm-gcc/libsanitizer/asan/asan_malloc_linux.cc:155 #1 0x7758b3f4 in av_malloc (/usr/lib/libavutil.so.56+0x3b3f4) SUMMARY: AddressSanitizer: 280023 byte(s) leaked in 997 allocation(s). ``` Issue URL : https://github.com/alsa-project/alsa-lib/issues/419 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH] Revert "aplay: fix S24_LE wav header"
by Shengjiu Wang 13 Nov '24

13 Nov '24

S24_LE means the lower 24bit in 32bit space has valid data. So previous code is correct. The commit causes regression, then revert it. This reverts commit 9cdcbe0e932b97fac88a6195f87647159a6c7194. Fixes: 9cdcbe0e932b ("aplay: fix S24_LE wav header") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- aplay/aplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index c58c2e9..d11e63a 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -2719,11 +2719,11 @@ static void begin_wave(int fd, size_t cnt) case SND_PCM_FORMAT_S16_LE: bits = 16; break; - case SND_PCM_FORMAT_S24_LE: /* S24_LE is 24 bits stored in 32 bit width with 8 bit padding */ case SND_PCM_FORMAT_S32_LE: - case SND_PCM_FORMAT_FLOAT_LE: + case SND_PCM_FORMAT_FLOAT_LE: bits = 32; break; + case SND_PCM_FORMAT_S24_LE: case SND_PCM_FORMAT_S24_3LE: bits = 24; break; -- 2.34.1

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up on | Relevant PRs | Related issues | | ------------------| ---------------- | ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | #434 | ### Problem statement The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ### Relevant files & the such * [alsa-info info dump](https://github.com/user-attachments/files/17721762/alsa-info.txt) * Screenshot of the other USB device * ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up on | Relevant PRs | Related issues | | ------------------| ---------------- | ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | #434 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) ### Relevant files & the such [alsa-info.txt](https://github.com/user-attachments/files/17721762/alsa-info… Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up on | Relevant PRs | Related issues | | ------------------| ---------------- | ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | #434 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up | Relevant PR | Related issues | | ------------------| ---------------- | ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | #434 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up | Relevant PR | | ------------------| ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs (edit: *for the ALC408x*) are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Clevo Platfrom with ALC255
by Kailang 12 Nov '24

12 Nov '24

Hi Takashi, Attach was let Clevo platform with ALC255 enable headset Mic. BR, Kailang

2 1

ALSA 1.2.8 release
by Jaroslav Kysela 12 Nov '24

12 Nov '24

Hello all, new ALSA userspace packages were released. You may download them from the ALSA website http://www.alsa-project.org or directly: HTTP: https://www.alsa-project.org/files/pub FTP: ftp://ftp.alsa-project.org/pub Released packages: alsa-lib alsa-utils alsa-ucm-conf tinycompress Full list of changes: https://www.alsa-project.org/wiki/Changes_v1.2.7.2_v1.2.8 The fingerprint of the public signing key is: F04D F507 37AC 1A88 4C4B 3D71 8380 596D A6E5 9C91 Have fun, Jaroslav -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

1 5

[PATCH AUTOSEL 5.4 4/5] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index b7dc9d3192597..e8cd58c0838ee 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -318,7 +318,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0

[PATCH AUTOSEL 5.4 3/5] ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 63c1c87993e0e5bb11bced3d8224446a2bc62338 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation (*prate / div) is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 7e965848796c3..b7dc9d3192597 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -379,8 +379,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, int div; div = stm32_sai_get_clk_div(sai, *prate, rate); - if (div < 0) - return div; + if (div <= 0) + return -EINVAL; mclk->freq = *prate / div; -- 2.43.0

1 0

[PATCH AUTOSEL 5.10 5/6] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 3a7f0102b4c5c..90e4757f76b0f 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -319,7 +319,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0

[PATCH AUTOSEL 5.15 7/8] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index aa9cdd93b5778..d71b4aecd269f 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -319,7 +319,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0

[PATCH AUTOSEL 5.15 6/8] ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 63c1c87993e0e5bb11bced3d8224446a2bc62338 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation (*prate / div) is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 9c3b8e2096565..aa9cdd93b5778 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -380,8 +380,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, int div; div = stm32_sai_get_clk_div(sai, *prate, rate); - if (div < 0) - return div; + if (div <= 0) + return -EINVAL; mclk->freq = *prate / div; -- 2.43.0

1 0

[PATCH AUTOSEL 6.1 10/12] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 3d237f75e81f5..0629aa5f2fe4b 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -317,7 +317,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0

[PATCH AUTOSEL 6.1 09/12] ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 63c1c87993e0e5bb11bced3d8224446a2bc62338 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation (*prate / div) is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index eb31b49e65978..3d237f75e81f5 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -378,8 +378,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, int div; div = stm32_sai_get_clk_div(sai, *prate, rate); - if (div < 0) - return div; + if (div <= 0) + return -EINVAL; mclk->freq = *prate / div; -- 2.43.0

1 0

[PATCH AUTOSEL 6.6 13/15] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 1b61110cb9174..dcbcd1a59a3aa 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -317,7 +317,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0

[PATCH AUTOSEL 6.6 12/15] ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 63c1c87993e0e5bb11bced3d8224446a2bc62338 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation (*prate / div) is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 0acc848c1f004..1b61110cb9174 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -378,8 +378,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, int div; div = stm32_sai_get_clk_div(sai, *prate, rate); - if (div < 0) - return div; + if (div <= 0) + return -EINVAL; mclk->freq = *prate / div; -- 2.43.0

1 0

[PATCH AUTOSEL 6.6 06/15] ASoC: tas2781: Add new driver version for tas2563 & tas2781 qfn chip
by Sasha Levin 12 Nov '24

12 Nov '24

From: Shenghao Ding <shenghao-ding(a)ti.com> [ Upstream commit fe09de2db2365eed8b44b572cff7d421eaf1754a ] Add new driver version to support tas2563 & tas2781 qfn chip Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> Link: https://patch.msgid.link/20241104100055.48-1-shenghao-ding@ti.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/tas2781-fmwlib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c index 629e2195a890b..1cc64ed8de6da 100644 --- a/sound/soc/codecs/tas2781-fmwlib.c +++ b/sound/soc/codecs/tas2781-fmwlib.c @@ -2022,6 +2022,7 @@ static int tasdevice_dspfw_ready(const struct firmware *fmw, break; case 0x202: case 0x400: + case 0x401: tas_priv->fw_parse_variable_header = fw_parse_variable_header_git; tas_priv->fw_parse_program_data = -- 2.43.0

1 0

[PATCH AUTOSEL 6.11 14/16] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 19307812ec765..64f52c75e2aa8 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -317,7 +317,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0