October 2024 - Alsa-devel - mailman.alsa-project.org

Re: [PATCH v2 1/7] ASoC: dt-bindings: qcom,sm8250: add qrb4210-rb2-sndcard
by Krzysztof Kozlowski 02 Oct '24

02 Oct '24

On Wed, Oct 02, 2024 at 03:20:09AM +0100, Alexey Klimov wrote: > Add adsp-backed soundcard compatible for QRB4210 RB2 platform, > which as of now looks fully compatible with SM8250. > > Signed-off-by: Alexey Klimov <alexey.klimov(a)linaro.org> > --- > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> Best regards, Krzysztof

1 0

Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Krzysztof Kozlowski 02 Oct '24

02 Oct '24

On 01/10/2024 23:02, Gax-c wrote: > A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could > possibly return NULL pointer. NULL Pointer Dereference may be > triggerred without addtional check. > Add a NULL check for the returned pointer. > > Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") > Signed-off-by: Zichen Xie <zichenxie0106(a)gmail.com> > Cc: stable(a)vger.kernel.org > Reported-by: Zichen Xie <zichenxie0106(a)gmail.com> Drop, you cannot report own work. To whom do you report it? Was this compiled? Based on the previous work I have doubts. Best regards, Krzysztof

1 0

Re: [PATCH v2 6/7] arm64: dts: qcom: qrb4210-rb2: add description of lpi_i2s2 pins
by Krzysztof Kozlowski 02 Oct '24

02 Oct '24

On 02/10/2024 04:20, Alexey Klimov wrote: > This is required to enable to HDMI audio playback on > QRB4210 RB2 board. > > Signed-off-by: Alexey Klimov <alexey.klimov(a)linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 36 ++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index 1888d99d398b..7731681688d5 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -634,6 +634,42 @@ sdc2_card_det_n: sd-card-det-n-state { > }; > }; > > +&lpass_tlmm { > + lpi_i2s2_active: lpi-i2s2-active-state { > + sck-pin { It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sourc… for instructions). Best regards, Krzysztof

1 0

Re: [PATCH v2 0/7] qrb4210-rb2: add HDMI audio playback support
by Rob Herring (Arm) 02 Oct '24

02 Oct '24

On Wed, 02 Oct 2024 03:20:08 +0100, Alexey Klimov wrote: > Rebased on top of -master, tested. > > Changes since v1: > -- removed handling of MI2S clock in sm2450_snd_shutdown(): setting clock rate > and disabling it causes audio delay on playback start; > -- removed empty sound { } node from sm6115.dtsi as suggested by Krzysztof; > -- moved lpi_i2s2_active pins description to qrb423310 board-specific file > as suggested by Dmitry Baryshkov; > -- moved q6asmdai DAIs to apr soc node as suggested by Konrad Dybcio; > -- lpass_tlmm is not disabled; > -- lpass_tlmm node moved to sm4250.dtsi; > -- kept MultiMedia DAIs as is, without them the sound card driver doesn't initialise; > -- added some reviewed-by tags. > > This series still keeps "qcom,qrb4210-rb2-sndcard" for sm8250 soundcard. As per > off the list discussion with Srini it was suggested to have it since in future it > may be required to add clocks, workarounds, quirks, model-specific things based on > this compatible. The same as for RB5 compatible in sm8250 snd driver. > > This focuses on HDMI audio playback only hence there are no soundwire and dmic pins, > for instance. The work to enable playback via wcd+wsa8815 amplifier is in progress (it works) > and one of the routes is to merge such two patchsets together. > > Link to prev series: > https://lore.kernel.org/linux-sound/20240628010715.438471-1-alexey.klimov@l… > > Alexey Klimov (7): > ASoC: dt-bindings: qcom,sm8250: add qrb4210-rb2-sndcard > ASoC: qcom: sm8250: add qrb4210-rb2-sndcard compatible string > ASoC: qcom: sm8250: add handling of secondary MI2S clock > arm64: dts: qcom: sm6115: add apr and its services > arm64: dts: qcom: sm4250: add LPASS LPI pin controller > arm64: dts: qcom: qrb4210-rb2: add description of lpi_i2s2 pins > arm64: dts: qcom: qrb4210-rb2: add HDMI audio playback support > > .../bindings/sound/qcom,sm8250.yaml | 1 + > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 91 +++++++++++++++++++ > arch/arm64/boot/dts/qcom/sm4250.dtsi | 16 ++++ > arch/arm64/boot/dts/qcom/sm6115.dtsi | 72 +++++++++++++++ > sound/soc/qcom/sm8250.c | 9 ++ > 5 files changed, 189 insertions(+) > > -- > 2.45.2 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/qrb4210-rb2.dtb' for 20241002022015.867031-1-alexey.klimov(a)linaro.org: arch/arm64/boot/dts/qcom/qrb4210-rb2.dtb: pinctrl@a7c0000: lpi-i2s2-active-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'function' is a required property Unevaluated properties are not allowed ('data-pins', 'ext-mclk1', 'sck-pin', 'ws-pins' were unexpected) 'ext-mclk1', 'sck-pin' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sm4250-lpass-lpi-pinctrl.yaml#

1 0

[PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Gax-c 01 Oct '24

01 Oct '24

A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could possibly return NULL pointer. NULL Pointer Dereference may be triggerred without addtional check. Add a NULL check for the returned pointer. Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") Signed-off-by: Zichen Xie <zichenxie0106(a)gmail.com> Reported-by: Zichen Xie <zichenxie0106(a)gmail.com> Reported-by: Zijie Zhao <zzjas98(a)gmail.com> Reported-by: Chenyuan Yang <chenyuan0y(a)gmail.com> --- sound/soc/qcom/lpass-cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 5a47f661e0c6..a8e56f47f237 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -1243,6 +1243,9 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) drvdata->i2sctl = devm_kzalloc(&pdev->dev, sizeof(struct lpaif_i2sctl), GFP_KERNEL); + if (!drvdata->i2sctl) + return -ENOMEM; + /* Initialize bitfields for dai I2SCTL register */ ret = lpass_cpu_init_i2sctl_bitfields(dev, drvdata->i2sctl, drvdata->lpaif_map); -- 2.25.1

2 1

[PATCH] Fix possible NULL Pointer Dereference in 'asoc_qcom_lpass_cpu_platform_probe'
by Gax-c 01 Oct '24

01 Oct '24

A 'devm_kzalloc' in 'asoc_qcom_lpass_cpu_platform_probe' could possibly return NULL pointer. NULL Pointer Dereference may be triggerred in 'asoc_qcom_lpass_cpu_platform_probe' without addtional check. Add a null check for the returned pointer. Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") Signed-off-by: Zichen Xie <zichenxie0106(a)gmail.com> Reported-by: Zichen Xie <zichenxie0106(a)gmail.com> Reported-by: Zijie Zhao <zzjas98(a)gmail.com> Reported-by: Chenyuan Yang <chenyuan0y(a)gmail.com> --- sound/soc/qcom/lpass-cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 5a47f661e0c6..a8e56f47f237 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -1243,6 +1243,9 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) drvdata->i2sctl = devm_kzalloc(&pdev->dev, sizeof(struct lpaif_i2sctl), GFP_KERNEL); + if (!drvdata->i2sctl) + return -ENOMEM; + /* Initialize bitfields for dai I2SCTL register */ ret = lpass_cpu_init_i2sctl_bitfields(dev, drvdata->i2sctl, drvdata->lpaif_map); -- 2.25.1

5 7

[PATCH 0/3] ASoC: fsl_micfil: fix and improvement
by Shengjiu Wang 01 Oct '24

01 Oct '24

Fix the usage of regmap_write_bits(). Move mclk clock enablement to late stage. Enable the micfil error interrupt. Shengjiu Wang (3): ASoC: fsl_micfil: fix regmap_write_bits usage ASoC: fsl_micfil: Add mclk enable flag ASoC: fsl_micfil: Enable micfil error interrupt sound/soc/fsl/fsl_micfil.c | 49 ++++++++++++++++++++++++++++++-------- 1 file changed, 39 insertions(+), 10 deletions(-) -- 2.34.1

3 5

[PATCH -next 0/5] sound/soc: fix some macro definitions and usages
by Hongbo Li 01 Oct '24

01 Oct '24

Many variable in macro are not used as we used macro_check script to detect and mamually check, let us address these issues. Hongbo Li (5): sound/soc: fix macro definition on TWL4030_OUTPUT_PGA sound/soc remove unused substream in macro soc_component_mark_pop sound/soc remove unused substream in macro soc_dai_mark_pop sound/soc remove unused substream in macro soc_link_mark_pop sound/soc: fix macro definition on STM_SAI_HAS_EXT_SYNC sound/soc/codecs/twl4030.c | 12 ++++++------ sound/soc/soc-component.c | 14 +++++++------- sound/soc/soc-dai.c | 10 +++++----- sound/soc/soc-link.c | 10 +++++----- sound/soc/stm/stm32_sai_sub.c | 2 +- 5 files changed, 24 insertions(+), 24 deletions(-) -- 2.34.1

2 7

[PATCH v2 0/2] {ASoC,media}: constify snd_soc_component_driver when used as read-only
by Javier Carrasco 01 Oct '24

01 Oct '24

Declare `snd_soc_component_driver` as const to move their declarations to read-only sections for the drivers that do not modify the struct after its declaration. Apart from a single case under media/, the affected drivers are members of the ASoC subsystem. To: Tim Harvey <tharvey(a)gateworks.com> To: Mauro Carvalho Chehab <mchehab(a)kernel.org> To: Liam Girdwood <lgirdwood(a)gmail.com> To: Mark Brown <broonie(a)kernel.org> To: Jaroslav Kysela <perex(a)perex.cz> To: Takashi Iwai <tiwai(a)suse.com> To: Ray Jui <rjui(a)broadcom.com> To: Scott Branden <sbranden(a)broadcom.com> To: Broadcom internal kernel review list <bcm-kernel-feedback-list(a)broadcom.com> To: Shenghao Ding <shenghao-ding(a)ti.com> To: Kevin Lu <kevin-lu(a)ti.com> To: Baojun Xu <baojun.xu(a)ti.com> To: Olivier Moysan <olivier.moysan(a)foss.st.com> To: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> To: Maxime Coquelin <mcoquelin.stm32(a)gmail.com> To: Alexandre Torgue <alexandre.torgue(a)foss.st.com> To: Kunihiko Hayashi <hayashi.kunihiko(a)socionext.com> To: Masami Hiramatsu <mhiramat(a)kernel.org> Cc: linux-media(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: linux-sound(a)vger.kernel.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: alsa-devel(a)alsa-project.org Cc: linux-stm32(a)st-md-mailman.stormreply.com Signed-off-by: Javier Carrasco <javier.carrasco.cruz(a)gmail.com> Changes in v2: - drop cs43130 and sti-sas, as they modifiy the struct in the probe function. - Link to v1: https://lore.kernel.org/r/20240725-const_snd_soc_component_driver-v1-0-3d7e… --- Javier Carrasco (2): media: i2c: tda1997x: constify snd_soc_component_driver struct ASoC: constify snd_soc_component_driver struct drivers/media/i2c/tda1997x.c | 2 +- sound/soc/au1x/dbdma2.c | 2 +- sound/soc/au1x/dma.c | 2 +- sound/soc/bcm/cygnus-pcm.c | 2 +- sound/soc/codecs/cpcap.c | 2 +- sound/soc/codecs/pcm186x.c | 4 ++-- sound/soc/codecs/pcm5102a.c | 2 +- sound/soc/codecs/spdif_receiver.c | 2 +- sound/soc/codecs/spdif_transmitter.c | 2 +- sound/soc/codecs/tas6424.c | 2 +- sound/soc/stm/stm32_adfsdm.c | 2 +- sound/soc/uniphier/evea.c | 2 +- 12 files changed, 13 insertions(+), 13 deletions(-) --- base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b change-id: 20240725-const_snd_soc_component_driver-b9629a95b948 Best regards, -- Javier Carrasco <javier.carrasco.cruz(a)gmail.com>

2 3

[PATCH V2 0/9] ASoC: amd: acp: refactor acp version differentiation logic
by Vijendar Mukunda 01 Oct '24

01 Oct '24

Currently different logics being used in the code for acp version differentiation. This patch series refactors the code to use acp pci revision id for handling acp version specific code. Changes since v1: - Add patch to update mach_params subsystem_rev field in machine select logic. Vijendar Mukunda (9): ASoC: amd: acp: simplify platform conditional checks code ASoC: amd: acp: use acp_rev for platform specific conditional checks ASoC: amd: acp: use acp pci revision id for platform differntiation ASoC: amd: acp: store acp pci rev id in platform driver private structure ASoC: amd: acp: pass acp pci revision id as platform data ASoC: amd: acp: update mach_params subsystem_rev field ASoC: amd: acp: remove unused variable from acp_card_drvdata structure ASoC: amd: acp: replace adata->platform conditional check ASoC: amd: acp: remove unused variable from acp platform driver sound/soc/amd/acp/acp-i2s.c | 38 +++++++++++++-------------- sound/soc/amd/acp/acp-legacy-common.c | 24 ++++++++--------- sound/soc/amd/acp/acp-legacy-mach.c | 8 +++--- sound/soc/amd/acp/acp-mach-common.c | 38 +++++++++++++++++++-------- sound/soc/amd/acp/acp-mach.h | 12 +++------ sound/soc/amd/acp/acp-pci.c | 7 +---- sound/soc/amd/acp/acp-pdm.c | 2 +- sound/soc/amd/acp/acp-platform.c | 15 ++++++----- sound/soc/amd/acp/acp-rembrandt.c | 4 +-- sound/soc/amd/acp/acp-renoir.c | 4 +-- sound/soc/amd/acp/acp-sof-mach.c | 6 ++--- sound/soc/amd/acp/acp63.c | 4 +-- sound/soc/amd/acp/acp70.c | 14 ++++------ sound/soc/amd/acp/acp_common.h | 19 ++++++++++++++ sound/soc/amd/acp/amd.h | 9 ++----- 15 files changed, 109 insertions(+), 95 deletions(-) create mode 100644 sound/soc/amd/acp/acp_common.h -- 2.34.1

2 10