October 2024 - Alsa-devel - mailman.alsa-project.org

[PATCH 0/3] Fixes and improvements related to amd soundwire machine
by Vijendar Mukunda 08 Oct '24

08 Oct '24

This patch series consists of smatch error fixes and code improvements related to amd soundwire generic machine driver. Vijendar Mukunda (3): ASoC: amd: acp: fix for inconsistent indenting ASoC: amd: acp: fix for cpu dai index logic ASoC: amd: acp: refactor sof_card_dai_links_create() function sound/soc/amd/acp/acp-sdw-sof-mach.c | 47 +++++++++++----------------- 1 file changed, 18 insertions(+), 29 deletions(-) -- 2.34.1

2 4

Fix build with FFmpeg 7
by GitHub pull_request - opened 07 Oct '24

07 Oct '24

alsa-project/tinycompress pull request #25 was opened from fossdd: Patch provided by the Arch Linux team: https://gitlab.archlinux.org/archlinux/packaging/packages/tinycompress/-/bl… Request URL : https://github.com/alsa-project/tinycompress/pull/25 Patch URL : https://github.com/alsa-project/tinycompress/pull/25.patch Repository URL: https://github.com/alsa-project/tinycompress

1 0

[PATCH] ASoC: dt-bindings: davinci-mcasp: Fix interrupt properties
by Miquel Raynal 07 Oct '24

07 Oct '24

Combinations of "tx" alone, "rx" alone and "tx", "rx" together are supposedly valid (see link below), which is not the case today as "rx" alone is not accepted by the current binding. Let's rework the two interrupt properties to expose all correct possibilities. Cc: Péter Ujfalusi <peter.ujfalusi(a)gmail.com> Link: https://lore.kernel.org/linux-sound/20241003102552.2c11840e@xps-13/T/#m277f… Fixes: 8be90641a0bb ("ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema") Signed-off-by: Miquel Raynal <miquel.raynal(a)bootlin.com> --- Hello Mark, This patch applies on top of the one you already took, but if you prefer you can squash them together, I don't mind. Cheers, Miquèl --- .../bindings/sound/davinci-mcasp-audio.yaml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml index ab3206ffa4af..beef193aaaeb 100644 --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml @@ -102,21 +102,21 @@ properties: default: 2 interrupts: - oneOf: - - minItems: 1 - items: - - description: TX interrupt - - description: RX interrupt - - items: - - description: common/combined interrupt + minItems: 1 + maxItems: 2 interrupt-names: oneOf: - - minItems: 1 + - description: TX interrupt + const: tx + - description: RX interrupt + const: rx + - description: TX and RX interrupts items: - const: tx - const: rx - - const: common + - description: Common/combined interrupt + const: common fck_parent: $ref: /schemas/types.yaml#/definitions/string -- 2.43.0

3 2

Re: [v3?] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Markus Elfring 07 Oct '24

07 Oct '24

… > --- > v2: Fix "From" tag. > v3: Format tags to Fixes/Cc/Signed-off-by. > --- … * How do you think about to reconsider the version numbers a bit more? * Would you like to mention the repeated adjustment of the patch subject? * Can a duplicate marker line be replaced by a blank line? See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Doc… Is the email address “linux-kernel(a)vger.kernel.xn--org-9o0a still relevant here? Regards, Markus

2 1

Re: [PATCH v3] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Markus Elfring 07 Oct '24

07 Oct '24

> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could call? > possibly return NULL pointer. NULL Pointer Dereference may be Can the term “null pointer dereference” be applied for the final commit message (including the summary phrase)? > triggerred without addtional check. triggered? additional? Regards, Markus

2 1

[PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Gax-c 07 Oct '24

07 Oct '24

A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could possibly return NULL pointer. NULL Pointer Dereference may be triggerred without addtional check. Add a NULL check for the returned pointer. Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") Signed-off-by: Zichen Xie <zichenxie0106(a)gmail.com> Cc: stable(a)vger.kernel.org --- sound/soc/qcom/lpass-cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 5a47f661e0c6..242bc16da36d 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -1242,6 +1242,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) /* Allocation for i2sctl regmap fields */ drvdata->i2sctl = devm_kzalloc(&pdev->dev, sizeof(struct lpaif_i2sctl), GFP_KERNEL); + if (!drvdata->i2sctl) + return -ENOMEM; /* Initialize bitfields for dai I2SCTL register */ ret = lpass_cpu_init_i2sctl_bitfields(dev, drvdata->i2sctl, -- 2.25.1

5 9

[PATCH v2 0/7] qrb4210-rb2: add HDMI audio playback support
by Alexey Klimov 06 Oct '24

06 Oct '24

Rebased on top of -master, tested. Changes since v1: -- removed handling of MI2S clock in sm2450_snd_shutdown(): setting clock rate and disabling it causes audio delay on playback start; -- removed empty sound { } node from sm6115.dtsi as suggested by Krzysztof; -- moved lpi_i2s2_active pins description to qrb423310 board-specific file as suggested by Dmitry Baryshkov; -- moved q6asmdai DAIs to apr soc node as suggested by Konrad Dybcio; -- lpass_tlmm is not disabled; -- lpass_tlmm node moved to sm4250.dtsi; -- kept MultiMedia DAIs as is, without them the sound card driver doesn't initialise; -- added some reviewed-by tags. This series still keeps "qcom,qrb4210-rb2-sndcard" for sm8250 soundcard. As per off the list discussion with Srini it was suggested to have it since in future it may be required to add clocks, workarounds, quirks, model-specific things based on this compatible. The same as for RB5 compatible in sm8250 snd driver. This focuses on HDMI audio playback only hence there are no soundwire and dmic pins, for instance. The work to enable playback via wcd+wsa8815 amplifier is in progress (it works) and one of the routes is to merge such two patchsets together. Link to prev series: https://lore.kernel.org/linux-sound/20240628010715.438471-1-alexey.klimov@l… Alexey Klimov (7): ASoC: dt-bindings: qcom,sm8250: add qrb4210-rb2-sndcard ASoC: qcom: sm8250: add qrb4210-rb2-sndcard compatible string ASoC: qcom: sm8250: add handling of secondary MI2S clock arm64: dts: qcom: sm6115: add apr and its services arm64: dts: qcom: sm4250: add LPASS LPI pin controller arm64: dts: qcom: qrb4210-rb2: add description of lpi_i2s2 pins arm64: dts: qcom: qrb4210-rb2: add HDMI audio playback support .../bindings/sound/qcom,sm8250.yaml | 1 + arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 91 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sm4250.dtsi | 16 ++++ arch/arm64/boot/dts/qcom/sm6115.dtsi | 72 +++++++++++++++ sound/soc/qcom/sm8250.c | 9 ++ 5 files changed, 189 insertions(+) -- 2.45.2

5 15

Ubuntu 24.04 microphone is not working USB-Audio: ALC4080 Z-590E
by GitHub issues - edited 05 Oct '24

05 Oct '24

alsa-project/alsa-ucm-conf issue #447 was edited from jiutian12: My rear microphone is not working on Ubuntu 24.04 (nor on Ubuntu 22), but it can be used normally on Windows 10. Can hear sound After updating the master branch, the microphone still doesn't work, but the response is the same as the sound system Initial feedback on the issue, the following is my hardware information, I am not sure if it is complete http://alsa-project.org/db/?f=2558f03ffd8c55e18f8208a806f3e2336d9fa49c Kernel: k6.8.0-45-generic USB-Audio: ALC4080 ROG STRIX Z590-E This command can be recorded, but the sound is very low： arecord -D plughw:1,0 -c 1 -r 16000 -f S16_LE output.wav Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/447 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Ubuntu 24.04 microphone is not working USB-Audio: ALC4080 Z-590E
by GitHub issues - edited 05 Oct '24

05 Oct '24

alsa-project/alsa-ucm-conf issue #447 was edited from jiutian12: My rear microphone is not working on Ubuntu 24.04 (nor on Ubuntu 22), but it can be used normally on Windows 10. Can hear sound After updating the master branch, the microphone still doesn't work, but the response is the same as the sound system Initial feedback on the issue, the following is my hardware information, I am not sure if it is complete http://alsa-project.org/db/?f=2558f03ffd8c55e18f8208a806f3e2336d9fa49c Kernel: k6.8.0-45-generic USB-Audio: ALC4080 ROG STRIX Z590-E Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/447 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Ubuntu 24.04 microphone is not working USB-Audio: ALC4080 Z-590p
by GitHub issues - edited 05 Oct '24

05 Oct '24

alsa-project/alsa-ucm-conf issue #447 was edited from jiutian12: My rear microphone is not working on Ubuntu 24.04 (nor on Ubuntu 22), but it can be used normally on Windows 10. Can hear sound After updating the master branch, the microphone still doesn't work, but the response is the same as the sound system Initial feedback on the issue, the following is my hardware information, I am not sure if it is complete http://alsa-project.org/db/?f=2558f03ffd8c55e18f8208a806f3e2336d9fa49c Kernel: k6.8.0-45-generic USB-Audio: ALC4080 ROG STRIX Z590-E Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/447 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0