October 2024 - Alsa-devel - mailman.alsa-project.org

[PATCH 00/35] Reorganize kerneldoc parameter names
by Julia Lawall 06 Oct '24

06 Oct '24

Reorganize kerneldoc parameter names to match the parameter order in the function header. The misordered cases were identified using the following Coccinelle semantic patch: // <smpl> @initialize:ocaml@ @@ let parse_doc l = let pieces = List.map String.trim (String.split_on_char '*' l) in let l = String.concat " " pieces in match String.split_on_char ':' l with x::xs -> x | _ -> "" let params ps = List.rev (List.fold_left (fun prev (pm,_) -> let ty = String.trim(Pretty_print_c.string_of_fullType pm.Ast_c.p_type) in if ty = "void" && pm.Ast_c.p_namei = None then prev else let name = match pm.Ast_c.p_namei with Some name -> name | None -> failwith "function parameter has no name" in (String.trim (Pretty_print_c.string_of_name name),ty)::prev) [] ps) @r@ comments c; identifier fn; position p; parameter list ps; type T; @@ T@c fn@p(ps) { ... } @script:ocaml@ p << r.p; c << r.c; (_,ps) << r.ps; @@ let isdoc c ps = List.length ps > 1 && (let c = String.trim c in String.length c > 3 && String.sub c 0 3 = "/**" && String.get c 3 != '*') in let subset l1 l2 = List.for_all (fun x -> List.mem x l2) l1 in let (cb,cm,ca) = List.hd c in match List.rev cb with c::_ when isdoc c ps -> let pieces = String.split_on_char '@' c in (match pieces with _::tl -> let d_names = List.map parse_doc tl in (* check parameters *) let p_names = List.map fst (params ps) in if d_names <> [] && not(d_names = p_names) then begin if List.sort compare d_names = List.sort compare p_names then Coccilib.print_main "out of order" p else if subset d_names p_names then Coccilib.print_main "doc is missing a parameter" p else if subset d_names p_names then Coccilib.print_main "doc has an extra parameter" p end | _ -> ()) | _ -> () // </smpl> --- arch/arm/mach-omap2/prm2xxx_3xxx.c | 1 - arch/powerpc/platforms/ps3/interrupt.c | 2 +- arch/powerpc/platforms/ps3/repository.c | 2 +- drivers/base/firmware_loader/main.c | 2 +- drivers/comedi/drivers/comedi_8254.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 3 +-- drivers/gpu/drm/drm_gpuvm.c | 2 +- drivers/gpu/drm/radeon/radeon_ib.c | 2 +- drivers/iommu/iommu.c | 2 +- drivers/leds/leds-gpio-register.c | 2 +- drivers/mfd/atmel-smc.c | 4 ++-- drivers/misc/mei/bus.c | 2 +- drivers/mtd/ubi/eba.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c | 2 +- drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_common.c | 7 +++---- drivers/net/ethernet/intel/ice/ice_common.c | 2 +- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +- drivers/nvdimm/dimm_devs.c | 2 +- drivers/pci/hotplug/pci_hotplug_core.c | 2 +- drivers/pinctrl/pinmux.c | 2 +- drivers/slimbus/messaging.c | 2 +- drivers/soc/qcom/qmi_interface.c | 2 +- drivers/soundwire/stream.c | 2 +- drivers/usb/gadget/config.c | 4 ++-- fs/char_dev.c | 2 +- fs/dcache.c | 4 ++-- fs/seq_file.c | 2 +- kernel/audit.c | 2 +- kernel/resource.c | 2 +- kernel/sysctl.c | 1 - kernel/trace/ring_buffer.c | 2 +- lib/lru_cache.c | 2 +- lib/maple_tree.c | 2 +- mm/mmu_notifier.c | 2 +- net/dccp/feat.c | 2 +- net/mac80211/mesh_hwmp.c | 6 +++--- net/mac80211/mesh_pathtbl.c | 10 +++++----- net/socket.c | 2 +- net/sunrpc/xprt.c | 2 +- net/tipc/link.c | 14 +++++++------- net/tipc/msg.c | 2 +- sound/pci/hda/hda_codec.c | 2 +- 45 files changed, 60 insertions(+), 64 deletions(-)

2 3

Ubuntu 24.04 microphone is not working USB-Audio: ALC4080 Z-590E
by GitHub issues - edited 05 Oct '24

05 Oct '24

alsa-project/alsa-ucm-conf issue #447 was edited from jiutian12: My rear microphone is not working on Ubuntu 24.04 (nor on Ubuntu 22), but it can be used normally on Windows 10. Can hear sound After updating the master branch, the microphone still doesn't work, but the response is the same as the sound system Initial feedback on the issue, the following is my hardware information, I am not sure if it is complete http://alsa-project.org/db/?f=2558f03ffd8c55e18f8208a806f3e2336d9fa49c Kernel: k6.8.0-45-generic USB-Audio: ALC4080 ROG STRIX Z590-E This command can be recorded, but the sound is very low： arecord -D plughw:1,0 -c 1 -r 16000 -f S16_LE output.wav Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/447 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Ubuntu 24.04 microphone is not working USB-Audio: ALC4080 Z-590E
by GitHub issues - edited 05 Oct '24

05 Oct '24

alsa-project/alsa-ucm-conf issue #447 was edited from jiutian12: My rear microphone is not working on Ubuntu 24.04 (nor on Ubuntu 22), but it can be used normally on Windows 10. Can hear sound After updating the master branch, the microphone still doesn't work, but the response is the same as the sound system Initial feedback on the issue, the following is my hardware information, I am not sure if it is complete http://alsa-project.org/db/?f=2558f03ffd8c55e18f8208a806f3e2336d9fa49c Kernel: k6.8.0-45-generic USB-Audio: ALC4080 ROG STRIX Z590-E Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/447 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Ubuntu 24.04 microphone is not working USB-Audio: ALC4080 Z-590p
by GitHub issues - edited 05 Oct '24

05 Oct '24

alsa-project/alsa-ucm-conf issue #447 was edited from jiutian12: My rear microphone is not working on Ubuntu 24.04 (nor on Ubuntu 22), but it can be used normally on Windows 10. Can hear sound After updating the master branch, the microphone still doesn't work, but the response is the same as the sound system Initial feedback on the issue, the following is my hardware information, I am not sure if it is complete http://alsa-project.org/db/?f=2558f03ffd8c55e18f8208a806f3e2336d9fa49c Kernel: k6.8.0-45-generic USB-Audio: ALC4080 ROG STRIX Z590-E Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/447 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Ubuntu 24.04 microphone is not working USB-Audio: ALC4080 Z-590p
by GitHub issues - opened 05 Oct '24

05 Oct '24

alsa-project/alsa-ucm-conf issue #447 was opened from jiutian12: My rear microphone is not working on Ubuntu 24.04 (nor on Ubuntu 22), but it can be used normally on Windows 10. Can hear sound After updating the master branch, the microphone still doesn't work, but the response is the same as the sound system Initial feedback on the issue, the following is my hardware information, I am not sure if it is complete http://alsa-project.org/db/?f=2558f03ffd8c55e18f8208a806f3e2336d9fa49c Kernel: k6.8.0-45-generic USB-Audio: ALC4080 asus Z-590p Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/447 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Markus Elfring 05 Oct '24

05 Oct '24

> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could call? > possibly return NULL pointer. NULL Pointer Dereference may be > triggerred without addtional check. … * How do you think about to use the term “null pointer dereference” for the final commit message (including the summary phrase)? * Would you like to avoid any typos here? … > --- > sound/soc/qcom/lpass-cpu.c | 2 ++ Did you overlook to add a version description behind the marker line? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Doc… Regards, Markus

1 0

[PATCH treewide 00/11] ASoC: Clean up {hp,mic}-det-gpio handling
by Geert Uytterhoeven 05 Oct '24

05 Oct '24

Hi all, The "gpio" suffix for GPIO consumers was deprecated a while ago, in favor of the "gpios" suffix. However, there are still several users of the "hp-det-gpio" and "mic-det-gpio" properties, in DT bindings, drivers, and DT source files. Drivers that use gpiolib handle both the deprecated and new properties transparently, but that is not the case when using of_property_*() calls directly. - The first patch fixes a bug, as the Freescale Generic ASoC Sound driver handles only the deprecated properties, while there is already a user of the new variants, - The second patch updates the Audio Graph and Simple Audio Card DT bindings, - Patches 3-9 converts various DTS files to use the new properties, - The last 2 patches convert Freescale sound device nodes to use the new properties. All patches can be applied independently, except for the last two, which depend on the first patch to avoid regressions. This series was compile-tested only. Thanks for your comments! Geert Uytterhoeven (11): ASoC: fsl-asoc-card: Add missing handling of {hp,mic}-dt-gpios ASoC: dt-bindings: Deprecate {hp,mic}-det-gpio ARM: dts: marvell: mmp2-olpc-xo-1-75: Switch to {hp,mic}-det-gpios arm64: dts: freescale: imx: Switch to simple-audio-card,hp-det-gpios arm64: dts: renesas: beacon-renesom: Switch to mic-det-gpios arm64: dts: rockchip: Switch to simple-audio-card,hp-det-gpios arm64: dts: rockchip: Switch to hp-det-gpios arm64: dts: uniphier: Switch to hp-det-gpios mips: dts: ingenic: Switch to simple-audio-card,hp-det-gpios ARM: dts: nxp: imx: Switch to {hp,mic}-det-gpios arm64: dts: freescale: imx: Switch to hp-det-gpios .../devicetree/bindings/sound/audio-graph.yaml | 6 ++++++ .../devicetree/bindings/sound/simple-card.yaml | 12 ++++++++++++ arch/arm/boot/dts/marvell/mmp2-olpc-xo-1-75.dts | 4 ++-- arch/arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi | 4 ++-- arch/arm/boot/dts/nxp/imx/imx6sl-evk.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx6sll-evk.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx6ul-14x14-evk.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 2 +- .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 2 +- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 2 +- arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 2 +- .../boot/dts/renesas/beacon-renesom-baseboard.dtsi | 2 +- .../boot/dts/rockchip/rk3326-anbernic-rg351m.dtsi | 2 +- .../arm64/boot/dts/rockchip/rk3326-gameforce-chi.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts | 2 +- .../boot/dts/rockchip/rk3399-rock-pi-4a-plus.dts | 2 +- .../boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts | 2 +- .../boot/dts/rockchip/rk3399-sapphire-excavator.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg-arc.dtsi | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg353ps.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg353vs.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg503.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3566-powkiddy-x55.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 2 +- .../dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3588-ok3588-c.dts | 2 +- .../boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- .../boot/dts/rockchip/rk3588s-gameforce-ace.dts | 2 +- .../boot/dts/socionext/uniphier-ld11-global.dts | 2 +- .../boot/dts/socionext/uniphier-ld20-global.dts | 2 +- arch/mips/boot/dts/ingenic/gcw0.dts | 2 +- arch/mips/boot/dts/ingenic/rs90.dts | 2 +- sound/soc/fsl/fsl-asoc-card.c | 8 +++++--- 50 files changed, 72 insertions(+), 52 deletions(-) -- 2.34.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

6 26

[PATCH] sound: soc: uniphier: Handle regmap_write errors in aio_src_set_param()
by (학생) 장인규 (컴퓨터공학과) 05 Oct '24

05 Oct '24

From 791716bf359b8540c519810848fd1f8006d7c3c5 Mon Sep 17 00:00:00 2001 From: Ingyu Jang <ingyujang25(a)unist.ac.kr> Date: Thu, 26 Sep 2024 19:40:04 +0900 Subject: [PATCH] sound: soc: uniphier: Handle regmap_write errors in aio_src_set_param() The aio_src_set_param() function did not previously check the return values of regmap_write() and regmap_update_bits(). If these functions fail, it could lead to silent failures when configuring the sample rate converter (SRC), causing improper behavior in audio processing without any indication of an error. This patch modifies aio_src_set_param to check the return values of regmap_write() and regmap_update_bits(). If either function returns an error, the error code is propagated back to the caller to ensure proper error handling. This change aligns with the existing error-handling behavior in functions like uniphier_aio_prepare(), where a failure in a sub-function should result in an immediate return of the error. Signed-off-by: Ingyu Jang <ingyujang25(a)unist.ac.kr> --- sound/soc/uniphier/aio-core.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c index 0eba60758134..2c4e8b873253 100644 --- a/sound/soc/uniphier/aio-core.c +++ b/sound/soc/uniphier/aio-core.c @@ -921,16 +921,19 @@ int aio_src_set_param(struct uniphier_aio_sub *sub, { struct regmap *r = sub->aio->chip->regmap; u32 v; + int ret; if (sub->swm->dir != PORT_DIR_OUTPUT) return 0; - regmap_write(r, OPORTMXSRC1CTR(sub->swm->oport.map), + ret = regmap_write(r, OPORTMXSRC1CTR(sub->swm->oport.map), OPORTMXSRC1CTR_THMODE_SRC | OPORTMXSRC1CTR_SRCPATH_CALC | OPORTMXSRC1CTR_SYNC_ASYNC | OPORTMXSRC1CTR_FSIIPSEL_INNER | OPORTMXSRC1CTR_FSISEL_ACLK); + if (ret) + return ret; switch (params_rate(params)) { default: @@ -951,12 +954,18 @@ int aio_src_set_param(struct uniphier_aio_sub *sub, break; } - regmap_write(r, OPORTMXRATE_I(sub->swm->oport.map), + + ret = regmap_write(r, OPORTMXRATE_I(sub->swm->oport.map), v | OPORTMXRATE_I_ACLKSRC_APLL | OPORTMXRATE_I_LRCKSTP_STOP); - regmap_update_bits(r, OPORTMXRATE_I(sub->swm->oport.map), + if (ret) + return ret; + + ret = regmap_update_bits(r, OPORTMXRATE_I(sub->swm->oport.map), OPORTMXRATE_I_LRCKSTP_MASK, OPORTMXRATE_I_LRCKSTP_START); + if (ret) + return ret; return 0; } -- 2.34.1

2 2

Re: [PATCH] Fix unsigned int compared against 0
by Mark Brown 05 Oct '24

05 Oct '24

On Fri, 04 Oct 2024 19:40:46 +0530, Advait Dhamorikar wrote: > An unsigned value held by offset can never be > negative, so this test will always evaluate > the same way and is therefore redundant. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] Fix unsigned int compared against 0 commit: 40ba40fa4e054c62507026454529e3d530e10456 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0

[PATCH] ASoC: fsl: fsl_qmc_audio: Remove the logging when parsing channels
by Herve Codina 05 Oct '24

05 Oct '24

On each channel parsing, a log message is issued. This log message is not needed and become annoying when many channels are used (up to 64 channel supported). Simply remove this unneeded log message. Signed-off-by: Herve Codina <herve.codina(a)bootlin.com> --- sound/soc/fsl/fsl_qmc_audio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/fsl/fsl_qmc_audio.c b/sound/soc/fsl/fsl_qmc_audio.c index 8668abd35208..e257b8adafe0 100644 --- a/sound/soc/fsl/fsl_qmc_audio.c +++ b/sound/soc/fsl/fsl_qmc_audio.c @@ -838,8 +838,6 @@ static int qmc_audio_dai_parse(struct qmc_audio *qmc_audio, struct device_node * qmc_dai->id, i, ret); return ret; } - dev_info(qmc_audio->dev, "dai %d QMC channel %d mode %d, nb_tx_ts %u, nb_rx_ts %u\n", - qmc_dai->id, i, info.mode, info.nb_tx_ts, info.nb_rx_ts); if (info.mode != QMC_TRANSPARENT) { dev_err(qmc_audio->dev, "dai %d QMC chan %d mode %d is not QMC_TRANSPARENT\n", -- 2.46.1

2 1