September 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH v2 00/17] ALSA/ASoC: hda: Address format selection limitations and ambiguity
by Cezary Rojewski 14 Nov '23

14 Nov '23

Patchset aims to address format selection restrictions present currently in the HDAudio library. Formats which we are concerned about are 20 and 24 valid bits per sample within 32 bit depth container. One may identify them as S20_LE and S24_LE except that those, according to comments found in include/uapi/sound/asound.h, are for LSB-aligned scenarios. HDAudio streams expect MSB-aligned data, no matter if we are speaking of HOST (SDxFMT) or LINK (PPLCxFMT) side - chapter 4.5.1 of the public HDAudio specification. In short, S20_LE and S24_LE are invalid options. Right now, given the implementation of snd_hdac_query_supported_pcm() within sound/hda/hdac_device.c, even if a codec responds with: "I support all possible formats specified within HDAudio specification", there will be no option to open a 20/32 or 24/32 stream. The kernel will force the stream to be opened using the highest available bit depth. After discussing subject initially with Jaroslav and Takashi, suggestion was made to utilize 'subformat' option to address the problem. The eye-opening discussion begun much earlier though, in 2019 [1]. Paired with PRs for alsa-utils [2] and alsa-lib [3]. Flow of changes: The very first patch adds MSBITS subformat options to allow for granular 20/32, 24/32 and 32/32 format selection. The next three make sure subformat is actually honored during runtime. Most of that code is based on format-related API. Follow up is upgrade to the hda stream-format interface - several functions are added to make the granular format selection simple in the HDAudio world. Core of the implementation is based on the existing snd_hdac_calc_stream_format(). The next ten patches are straightforward switch from one interface to another with cleanup of now-unsed function as a finishing touch. Last but not least - the avs-driver, on which the problem analyzed and debugged, is updated to no longer acknowledge S24_LE as a valid format option. Results with skylake-driver and snd_hda_intel show status quo on our RVPs. PR filed on SOF github shows promising results too [4]. Changes in v2: - patch 01/17, introduced struct snd_pcm_subformat which task is to represent subformat-mask on per format basis. Expectation is that manipulated arrays of subformats always end with a sentinel entry - patch 01/17, added snd_pcm_hw_copy() as the copying snd_pcm_hardware becomes non-trivial - patch 02/17, added hw_rule that produces final subformat mask based on provided formats as suggested by Jaroslav - patch 04/17, soc_pcm_hw_update_subformat() refactored as the subformat intersection becomes non-trivial - relevant functions releasing resources occupied by hda_pcm and snd_pcm_runtime updated to also kfree() subformats - except for 16/17, no changes to patches past 04/17, retaining acks for these Changes in v1: - fixed UBSAN due to missing snd_pcm_subformat_names[] entries for new subformats - as HDMI stream capabilities are assigned on PCM open, patch 16/17 has been updated to ignore such codecs for now. A separate patchset will take care of this case - params_bps() reworded to snd_pcm_hw_params_bps() - fixed compilation issues in sof-driver, patch 13/17 [1]: https://lore.kernel.org/alsa-devel/20190905053302.9262-1-pawel.harlozinski@… [2]: https://github.com/alsa-project/alsa-utils/pull/228 [3]: https://github.com/alsa-project/alsa-lib/pull/342 [4]: https://github.com/thesofproject/linux/pull/4539 Cezary Rojewski (17): ALSA: pcm: Introduce MSBITS subformat interface ALSA: pcm: Honor subformat when configuring substream ALSA: hda: Honor subformat when querying PCMs ASoC: pcm: Honor subformat when configuring runtime ALSA: hda: Upgrade stream-format infrastructure ALSA: hda: Switch to new stream-format interface ALSA: hda/hdmi: Switch to new stream-format interface ALSA: hda/ca0132: Switch to new stream-format interface ASoC: codecs: hda: Switch to new stream-format interface ASoC: codecs: hdac_hda: Switch to new stream-format interface ASoC: codecs: hdac_hdmi: Switch to new stream-format interface ASoC: Intel Skylake: Switch to new stream-format interface ASoC: SOF: Intel: Switch to new stream-format interface ASoC: Intel: avs: Switch to new stream-format interface ALSA: hda: Drop snd_hdac_calc_stream_format() ASoC: Intel: avs: Kill S24_LE in HDAudio streaming ASoC: Intel: avs: Unhardcode HDAudio BE DAI drivers description include/sound/hda_codec.h | 5 +- include/sound/hdaudio.h | 14 +-- include/sound/pcm.h | 14 +++ include/sound/pcm_params.h | 2 + include/sound/soc.h | 1 + include/uapi/sound/asound.h | 7 +- sound/core/pcm.c | 4 + sound/core/pcm_lib.c | 28 +++++ sound/core/pcm_misc.c | 51 ++++++++++ sound/core/pcm_native.c | 67 +++++++++++- sound/hda/hdac_device.c | 163 ++++++++++++++++++++++-------- sound/pci/hda/hda_codec.c | 5 + sound/pci/hda/hda_controller.c | 10 +- sound/pci/hda/patch_ca0132.c | 3 +- sound/pci/hda/patch_hdmi.c | 6 +- sound/soc/codecs/hda-dai.c | 6 +- sound/soc/codecs/hda.c | 2 + sound/soc/codecs/hdac_hda.c | 8 +- sound/soc/codecs/hdac_hdmi.c | 10 +- sound/soc/intel/avs/loader.c | 4 +- sound/soc/intel/avs/path.c | 2 +- sound/soc/intel/avs/pcm.c | 54 ++++++++-- sound/soc/intel/avs/probes.c | 3 +- sound/soc/intel/avs/topology.c | 19 +++- sound/soc/intel/skylake/skl-pcm.c | 11 +- sound/soc/soc-pcm.c | 35 ++++++- sound/soc/sof/intel/hda-dai-ops.c | 5 +- tools/include/uapi/sound/asound.h | 7 +- 28 files changed, 443 insertions(+), 103 deletions(-) base-commit: 564ee9ac788b680e4ec4a6cb3a4a953dc61d5da8 -- 2.25.1

4 25

[PATCH v3 00/42] ep93xx device tree conversion
by Nikita Shubin via B4 Relay 13 Nov '23

13 Nov '23

This series aims to convert ep93xx from platform to full device tree support. The main goal is to receive ACK's to take it via Arnd's arm-soc branch. I've moved to b4, tricking it to consider v0 as v1, so it consider's this version to be v3, this exactly the third version. Link to previous versions: https://lore.kernel.org/all/20230424123522.18302-1-nikita.shubin@maquefel.m… Major changes with clocks: - split all ep93xx clk into two groups: - those who are special to ep93xx (i.e. can't be implemented via standard clk's) and use special swlocked registers - those who can be implemented via devm_clk_hw_register_gate, etc... - moved all clk's that are not used via device tree to SoC driver - dropped init and globals - devm_* everywhere Other notable changes: - added a global spinlock for SoC driver to protect swlocked register's. - moved dts file into cirrus - dropped "dt-bindings: gpio: Add Cirrus EP93xx" as it was taken by Bartosz via gpio subsystem on master v6.5-rc2-89-g3acbd4602b05: make dtbs_check ``` make -j34 -C build-linux ARCH=arm CROSS_COMPILE=armv4t-softfloat-linux-gnueabi- dtbs_check -s arch/arm/boot/dts/cirrus/ep93xx-edb9302.dtb:0:0: /soc/spi@808a0000/codec@0: failed to match any schema with compatible: ['cirrus,cs4271'] /home/maquefel/workshop/ts7250-boot-build/build-linux/arch/arm/boot/dts/cirrus/ep93xx-edb9302.dtb: sound: 'simple-audio-card,convert-sample-format' does not match any of the regexes: '^simple-audio-card,codec(@[0-9a-f]+)?$', '^simple-audio-card,cpu(@[0-9a-f]+)?$', '^simple-audio-card,dai-link(@[0-9a-f]+)?$', '^simple-audio-card,plat(@[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/maquefel/workshop/ts7250-boot-build/linux/Documentation/devicetree/bindings/sound/simple-card.yaml ``` cirrus,cs4271 is defined in linux/Documentation/devicetree/bindings/sound/cs4271.txt `make dt_binding_check` shows no issues. [PATCH v1 01/43] gpio: ep93xx: split device in multiple - core.c: - fixed tab used instead of space - unsigned i in ep93xx_init_devices - gpio-ep93xx.c: - single line for EP93XX_INT_DEBOUNCE_OFFSET - drop assignment from definition - s/devm_kcalloc/devm_kzalloc/ - value check for platform_get_irq - used dev_err_probe - s/if (irq <= 0)/if (irq < 0)/ [PATCH v1 02/43] dt-bindings: soc: Add Cirrus EP93xx - fixed title - dropped "+|" - dropped example, syscon, timer, required - dropped clock header from this patch and moved to clk patch - don't shadow irq_of_parse_and_map error NOTES: There is no possiblity to use fwnode_irq_get for TIMER_OF_DECLARE. [PATCH v1 03/43] soc: Add SoC driver for Cirrus ep93xx - s/Soc/SoC/ - sorted Kconfig, Makefile - s/linux/Linux/ - headers sorted - drop parentness - drop comment entirely (it's obvious) - drop global map - add SoC Bus stuff to get rid of exporting ep93xx_chip_revision Only PATA and CLK currently rely on revision, they can take it from soc_device_match. [PATCH v1 04/43] dt-bindings: clock: Add Cirrus EP93xx - filename now matches compatible - dropped description - dropped clock description - dropped fixed-clock from example - compatible first in example [PATCH v1 06/43] dt-bindings: pinctrl: Add Cirrus EP93xx - blank line after function - dropped minItems, maxItems for groups - fixed weird wrapping [PATCH v1 07/43] pinctrl: add a Cirrus ep93xx SoC pin controller Nikita Shubin - dropped 0 assigment in enum ep93xx_pinctrl_model - convert to pingroup - convert to pinfunction - str_enabled_disabled - s/of_match_node/of_device_get_match_data/ - numerous defaults for cases - convert to dev_err_probe - dropped dev_info noise - add "gpio2agrp" to ep9301/ep9302 as they have 0 pin of Port C exposed [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx - headers sorted - fixed comment - use lo_hi_readq and UINT_MAX [PATCH 12/43] clk: ep93xx: add DT support for Cirrus EP93xx - move out all clocks that aren't used in device tree to SoC driver (pll1, pll2, usb) - drop all static variables (regmap, clock data) - DMA and USB clocks as standart gates to avoid additional checks (all other require swlocked_write) - rearranged ep93xx_clk members to avoid holes - numerous fixes from Andy - don't get revision, use soc_device_match instead - added own clk_get function to distinguish fixed and own clocks [PATCH v1 14/43] power: reset: Add a driver for the ep93xx reset - added private data with regmap, as we dropped global regmap in SoC dirver - use dev_err_probe - + bits.h header [PATCH v1 17/43] dt-bindings: spi: Add Cirrus EP93xx - fixed filename to cirrus,ep9301-spi.yaml - dropped address and size cells - dropped cs-gpio - dropped cirrus,ep9301-use-dma - we are looking into "dmas" property now - added proper gpio defines [PATCH v1 18/43] spi: ep93xx: add DT support for Cirrus EP93xx - use device_set_node + dev_fwnode - s/of_property_present/device_property_present/ [PATCH v1 20/43] net: cirrus: add DT support for Cirrus EP93xx - +dev_err_probe [PATCH v1 22/43] dma: cirrus: add DT support for Cirrus EP93xx - dropped subsys_initcall probe - use of_device_get_match_data - use struct_size for allocating memory with channel array - rearranged data to take it out of CONFIG_OF - + dev_err_probe [PATCH v1 23/43] dt-bindings: mtd: Add ts7250 nand-controller - unevaluatedProperties: false - dropped address and size cells - added nand node [PATCH v1 24/43] mtd: nand: add support for ts72xx - return -EINVAL on engine_type == ON_HOST - added err_nand_cleanup goto - s/derived/Derived from/ - BIT and GENMASK - s/sizeof(struct ts72xx_nand_data)/sizeof(*data)/ and one line - fixed wierd mtd_device_parse_register error handling - added child node parsing to conform device tree bindings (i.e. partitions contained in 'nand@0' child node) [PATCH v1 26/43] pata: cirrus: add DT support for Cirrus EP93xx - headers reordering - s/-ENXIO/-ENOMEM/ - drop ep93xx_chip_revision, get data from soc_device_match - changed title to "ata: pata_ep93xx: add device tree support" [PATCH v1 27/43] dt-bindings: input: Add Cirrus EP93xx keypad - s/cirrus,debounce-delay-ms/debounce-delay-ms/ - cirrus,prescale -> uint16 and constraints - added "autorepeat" - fixed compatible in example [PATCH v1 28/43] input: keypad: ep93xx: add DT support for Cirrus EP93xx - added autorepeat - dropped module param flags entirely - s/of_property_read/device_property_read/ [PATCH v1 29/43] dt-bindings: rtc: Add ST M48T86 - renamed file to st,m48t86.yaml - fixed typo - reordered props [PATCH v1 33/43] dt-bindings: gpio: Add Cirrus EP93xx - renamed file to cirrus,ep9301-gpio.yaml - dropped explicit examples (but left port F with uses 8 interrupts) [PATCH v1 34/43] gpio: ep93xx: add DT support for gpio-ep93xx - s/Add match table./Add OF ID match table./ [PATCH v1 35/43] ARM: dts: add device tree for ep93xx Soc - splitted dtsi and dts - made nand-controller, leds, etc... part of the board and not SoC - dropped empty spi bus - labels sorted - dropped "delete-property" everywhere - compatible first, reg is second, ranges, if present, third - fixed wrapping - status last - moved cs gpios to board files - led0 -> led-0, led1 -> led-1 [PATCH v1 38/43] pata: cirrus: drop legacy pinctrl - changed title to "ata: pata_ep93xx: remove legacy pinctrl use" - removed ep93xx_ide_acquire_gpio and ep93xx_ide_release_gpio along with this patch -- 2.39.2 --- Alexander Sverdlin (2): ARM: dts: ep93xx: Add EDB9302 DT ASoC: cirrus: edb93xx: Delete driver Nikita Shubin (40): gpio: ep93xx: split device in multiple dt-bindings: clock: Add Cirrus EP93xx clk: ep93xx: add DT support for Cirrus EP93xx dt-bindings: pinctrl: Add Cirrus EP93xx pinctrl: add a Cirrus ep93xx SoC pin controller dt-bindings: soc: Add Cirrus EP93xx soc: Add SoC driver for Cirrus ep93xx dt-bindings: timers: Add Cirrus EP93xx clocksource: ep93xx: Add driver for Cirrus Logic EP93xx dt-bindings: rtc: Add Cirrus EP93xx rtc: ep93xx: add DT support for Cirrus EP93xx dt-bindings: watchdog: Add Cirrus EP93x watchdog: ep93xx: add DT support for Cirrus EP93xx power: reset: Add a driver for the ep93xx reset dt-bindings: pwm: Add Cirrus EP93xx pwm: ep93xx: add DT support for Cirrus EP93xx dt-bindings: spi: Add Cirrus EP93xx spi: ep93xx: add DT support for Cirrus EP93xx dt-bindings: net: Add Cirrus EP93xx net: cirrus: add DT support for Cirrus EP93xx dt-bindings: dma: Add Cirrus EP93xx dma: cirrus: add DT support for Cirrus EP93xx dt-bindings: mtd: Add ts7200 nand-controller mtd: nand: add support for ts72xx dt-bindings: ata: Add Cirrus EP93xx ata: pata_ep93xx: add device tree support dt-bindings: input: Add Cirrus EP93xx keypad input: keypad: ep93xx: add DT support for Cirrus EP93xx dt-bindings: rtc: Add ST M48T86 rtc: m48t86: add DT support for m48t86 dt-bindings: wdt: Add ts72xx wdt: ts72xx: add DT support for ts72xx gpio: ep93xx: add DT support for gpio-ep93xx ARM: dts: add Cirrus EP93XX SoC .dtsi ARM: dts: ep93xx: add ts7250 board ARM: ep93xx: DT for the Cirrus ep93xx SoC platforms pwm: ep93xx: drop legacy pinctrl ata: pata_ep93xx: remove legacy pinctrl use ARM: ep93xx: delete all boardfiles ARM: ep93xx: soc: drop defines .../bindings/arm/cirrus/ep9301-syscon.yaml | 59 + .../devicetree/bindings/arm/cirrus/ep9301.yaml | 39 + .../bindings/ata/cirrus,ep9312-pata.yaml | 44 + .../bindings/clock/cirrus,ep9301-clk.yaml | 46 + .../bindings/dma/cirrus,ep9301-dma-m2m.yaml | 72 + .../bindings/dma/cirrus,ep9301-dma-m2p.yaml | 124 ++ .../bindings/input/cirrus,ep9307-keypad.yaml | 87 ++ .../devicetree/bindings/mtd/technologic,nand.yaml | 47 + .../devicetree/bindings/net/cirrus,ep9301-eth.yaml | 61 + .../bindings/pinctrl/cirrus,ep9301-pinctrl.yaml | 58 + .../devicetree/bindings/pwm/cirrus,ep9301-pwm.yaml | 48 + .../devicetree/bindings/rtc/cirrus,ep9301-rtc.yaml | 40 + .../devicetree/bindings/rtc/st,m48t86.yaml | 38 + .../devicetree/bindings/spi/cirrus,ep9301-spi.yaml | 63 + .../bindings/timer/cirrus,ep9301-timer.yaml | 49 + .../bindings/watchdog/cirrus,ep9301-wdt.yaml | 46 + .../bindings/watchdog/technologic,ts7200-wdt.yaml | 46 + arch/arm/Makefile | 1 - arch/arm/boot/dts/cirrus/Makefile | 4 + arch/arm/boot/dts/cirrus/ep93xx-bk3.dts | 126 ++ arch/arm/boot/dts/cirrus/ep93xx-edb9302.dts | 178 +++ arch/arm/boot/dts/cirrus/ep93xx-ts7250.dts | 145 ++ arch/arm/boot/dts/cirrus/ep93xx.dtsi | 449 ++++++ arch/arm/mach-ep93xx/Kconfig | 20 +- arch/arm/mach-ep93xx/Makefile | 11 - arch/arm/mach-ep93xx/clock.c | 733 ---------- arch/arm/mach-ep93xx/core.c | 1017 -------------- arch/arm/mach-ep93xx/dma.c | 114 -- arch/arm/mach-ep93xx/edb93xx.c | 344 ----- arch/arm/mach-ep93xx/ep93xx-regs.h | 38 - arch/arm/mach-ep93xx/gpio-ep93xx.h | 111 -- arch/arm/mach-ep93xx/hardware.h | 25 - arch/arm/mach-ep93xx/irqs.h | 76 - arch/arm/mach-ep93xx/platform.h | 42 - arch/arm/mach-ep93xx/soc.h | 212 --- arch/arm/mach-ep93xx/ts72xx.c | 422 ------ arch/arm/mach-ep93xx/ts72xx.h | 94 -- arch/arm/mach-ep93xx/vision_ep9307.c | 311 ----- drivers/ata/pata_ep93xx.c | 49 +- drivers/clk/Kconfig | 8 + drivers/clk/Makefile | 1 + drivers/clk/clk-ep93xx.c | 764 +++++++++++ drivers/clocksource/Kconfig | 11 + drivers/clocksource/Makefile | 1 + .../clocksource}/timer-ep93xx.c | 155 ++- drivers/dma/ep93xx_dma.c | 131 +- drivers/gpio/gpio-ep93xx.c | 332 ++--- drivers/input/keyboard/ep93xx_keypad.c | 74 +- drivers/mtd/nand/raw/Kconfig | 7 + drivers/mtd/nand/raw/Makefile | 1 + drivers/mtd/nand/raw/technologic-nand-controller.c | 162 +++ drivers/net/ethernet/cirrus/ep93xx_eth.c | 61 +- drivers/pinctrl/Kconfig | 7 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-ep93xx.c | 1447 ++++++++++++++++++++ drivers/power/reset/Kconfig | 10 + drivers/power/reset/Makefile | 1 + drivers/power/reset/ep93xx-restart.c | 86 ++ drivers/pwm/pwm-ep93xx.c | 26 +- drivers/rtc/rtc-ep93xx.c | 8 + drivers/rtc/rtc-m48t86.c | 8 + drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/cirrus/Kconfig | 12 + drivers/soc/cirrus/Makefile | 2 + drivers/soc/cirrus/soc-ep93xx.c | 231 ++++ drivers/spi/spi-ep93xx.c | 28 +- drivers/watchdog/ep93xx_wdt.c | 8 + drivers/watchdog/ts72xx_wdt.c | 8 + include/dt-bindings/clock/cirrus,ep93xx-clock.h | 41 + include/dt-bindings/dma/cirrus,ep93xx-dma.h | 26 + include/linux/platform_data/dma-ep93xx.h | 25 +- include/linux/platform_data/eth-ep93xx.h | 10 - include/linux/platform_data/keypad-ep93xx.h | 32 - include/linux/soc/cirrus/ep93xx.h | 33 +- sound/soc/cirrus/Kconfig | 9 - sound/soc/cirrus/Makefile | 4 - sound/soc/cirrus/edb93xx.c | 117 -- 78 files changed, 5205 insertions(+), 4174 deletions(-) --- base-commit: ccff6d117d8dc8d8d86e8695a75e5f8b01e573bf change-id: 20230605-ep93xx-01c76317e2d2 Best regards, -- Nikita Shubin <nikita.shubin(a)maquefel.me>

15 90

[PATCH v2 1/2] ALSA: docs: Add Marian M2 driver documentation
by Ivan Orlov 05 Nov '23

05 Nov '23

Add documentation for the new MARIAN Seraph M2 sound card. It covers current development status, available controls of the card and information about the integrated loopback. Signed-off-by: Ivan Orlov <ivan.orlov0322(a)gmail.com> --- V1 -> V2: - Remove redundant documentation fix from the next patch in the series Documentation/sound/cards/index.rst | 1 + Documentation/sound/cards/marian-m2.rst | 104 ++++++++++++++++++++++++ 2 files changed, 105 insertions(+) create mode 100644 Documentation/sound/cards/marian-m2.rst diff --git a/Documentation/sound/cards/index.rst b/Documentation/sound/cards/index.rst index e68bbb13c384..e873592d8d00 100644 --- a/Documentation/sound/cards/index.rst +++ b/Documentation/sound/cards/index.rst @@ -19,3 +19,4 @@ Card-Specific Information serial-u16550 img-spdif-in pcmtest + marian-m2 diff --git a/Documentation/sound/cards/marian-m2.rst b/Documentation/sound/cards/marian-m2.rst new file mode 100644 index 000000000000..bf12445e20d7 --- /dev/null +++ b/Documentation/sound/cards/marian-m2.rst @@ -0,0 +1,104 @@ +.. SPDX-License-Identifier: GPL-2.0 + +======================= +MARIAN Seraph M2 Driver +======================= + +Sep 18, 2023 + +Ivan Orlov <ivan.orlov0322(a)gmail.com> + +STATE OF DEVELOPMENT +==================== + +This driver is based on the driver written by Florian Faber in 2012, which seemed to work fine. +However, the initial code contained multiple issues, which had to be solved before sending the +driver upstream. + +The vendor lost the full documentation, so what we have here was recovered from drafts and found +after experiments with the card. + +What seems to be working fine: +- Playback and capture for all supported rates +- Integrated loopback (with some exceptions, see below) + +MEMORY MODEL +============ + +The hardware requires one huge contiguous DMA space to be allocated. After allocation, the bus address of +this buffer should be written to the hardware register. + +We can split this space into two parts: the first one contains samples for capture, another one contains +play samples: + +CAPTURE_CH_0, CAPTURE_CH_1, ..., CAPTURE_CH_127 | PLAY_CH_0, PLAY_CH_1, ..., PLAY_CH_127 + +The card supports the non-interleaved access mode only, so samples for each channel lay together: + +C0, C0, ..., C0, C1, C1, ..., C1, ..., C127 | C0, C0, ..., C0, C1, C1, ..., C1, ..., C127 + +The count of samples per each channel buffer needs to be set explicitly, so the address of the first +byte of the playback data depends on this value. The playback buffer starts where the capture buffer ends. +It makes the arbitrary period count/buffer size feature impossible to implement, and the driver supports only +2 periods per buffer. + +Controls +======== + +Input 1 Sync + 0 - No signal, 1 - valid MADI signal found, 2 - Synced with MADI signal +Input 2 Sync + 0 - No signal, 1 - valid MADI signal found, 2 - Synced with MADI signal + +Input 1 Channel Mode + 0 - 56 channels, 1 - 64 channels +Input 2 Channel Mode + 0 - 56 channels, 1 - 64 channels + +Input 1 Frame Mode + 0 - 48 kHz, 1 - 96 kHz +Input 2 Frame Mode + 0 - 48 kHz, 1 - 96 kHz + +Input 1 Frequency + Measured frequency on Input 1 +Input 2 Frequency + Measured frequency on Input 2 + +Output 1 Channel Mode + 0 - 56 channels, 1 - 64 channels +Output 2 Channel Mode + 0 - 56 channels, 1 - 64 channels + +Output 1 Frame Mode + 0 - 48 kHz, 1 - 96 kHz +Output 2 Frame Mode + 0 - 48 kHz, 1 - 96 kHz + +Clock Source + Internal/Sync Bus, Input Port 1, Input Port 2 + +Speed mode + VCO clock range (slow/fast) + +DCO Frequency (Hz) + +DCO Frequency (ms) + +DCO Detune + Range: -200...200 + +Loopback + Enable/Disable integrated loopback + + +Loopback +======== + +The card contains integrated loopback. When it is enabled, it sets the hardware’s DAW-in memory pointer +to the hardware’s DAW-out memory. So, what you play is what you record. + +You can enable the integrated loopback using the corresponding control. + +The loopback seems to work well on lower rates (like 28000). However, when the rate goes higher, I observe +multiple mistakes in recorded byte ordering. -- 2.34.1

5 12

Re: RFC: usb: gadget: u_audio: Notifying gadget that host started playback/capture?
by Pavel Hofman 30 Oct '23

30 Oct '23

Hi, Dne 08. 09. 21 v 10:21 Pavel Hofman napsal(a): > Hi, > > The current audio gadget has no way to inform the gadget side that the > host side has started playback/capture and that gadget-side alsa > processes should be started. > > Playback/capture processes on the host side do not get stuck without the > gadget side consuming/producing data (OUT requests are ignored in > u_audio_iso_complete, IN ones send initial zeros in their req->buf). > > However, playback/capture processes on the gadget side get stuck without > the host side sending playback OUT packets or capture IN requests and > time out with error. If there was a way to inform the gadget side that > playback/capture has started on the host side, the gadget clients could > react accordingly. > I drafted a simple patch for u_audio.c which defines read-only boolean ctl elems "Capture Requested" and "Playback Requested". Their values are set/reset in methods u_audio_start_capture/playback and u_audio_stop_capture/playback, i.e. at changes of respective altsettings from 0 to 1 and back. Every ctl elem value change sends notification via snd_ctl_notify. The principle works OK for capture/playback start/stop on the host, as monitored by alsactl: pi@raspberrypi:~ $ alsactl monitor hw:UAC2Gadget node hw:UAC2Gadget, #4 (3,0,0,Capture Requested,0) VALUE node hw:UAC2Gadget, #4 (3,0,0,Capture Requested,0) VALUE node hw:UAC2Gadget, #3 (3,0,0,Playback Requested,0) VALUE node hw:UAC2Gadget, #3 (3,0,0,Playback Requested,0) VALUE However at enumeration the USB host switches both playback and capture altsettings repeatedly, generating "fake" events from the gadget side POW. The host even sends regular-sized EP-OUT packets filled with zeros during enumeration (tested on linux only for now). Please is there any way to "detect" the enumeration stage to mask out the "fake" playback/capture start/stop events? The attached patch does not apply cleanly to mainline u_audio.c because it's rebased on other patches not submitted yet but it's only a discussion inducer for now. Thanks a lot, Pavel.

2 6

[PATCH] patch_realtek: Splitting the UX3402 into two separate models.
by poseaydone＠ya.ru 28 Oct '23

28 Oct '23

From: Knyazev Arseniy <poseaydone(a)ya.ru> UX3402VA and UX3402ZA models require different hex values, so comibining them into one model is incorrect. Signed-off-by: Knyazev Arseniy <poseaydone(a)ya.ru> --- sound/pci/hda/patch_realtek.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index b7e78bfcffd8..b002f947b0d2 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9812,7 +9812,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x1d1f, "ASUS ROG Strix G17 2023 (G713PV)", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE), - SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402", ALC245_FIXUP_CS35L41_SPI_2), + SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402ZA", ALC245_FIXUP_CS35L41_SPI_2), + SND_PCI_QUIRK(0x1043, 0x16a3, "ASUS UX3402VA", ALC245_FIXUP_CS35L41_SPI_2), SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA502), SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS), -- 2.42.0

3 2

[PATCH 0/4] ASoC: qcom: fixes for Click/Pop Noise
by Srinivas Kandagatla 27 Oct '23

27 Oct '23

Click/Pop Noise was a long pending issue with WSA Codecs which are prone to accumlate DC when ports are active but without any data streams. There are multiple places in the current setup, where this could happen in both startup as well as shutdown path. This patches help fix those issues by making sure the PA is Muted/Unmuted inline with the stream start/stop events. Other than this there is a patch to fix DSP graph saturation issue as we never unload playback graph before loading same graph. Srinivas Kandagatla (4): ASoC: qcom: q6apm-lpass-dai: close graphs before opening a new one ASoC: qcom: sdw: do not restart soundwire ports for every prepare ASoC: codecs: wsa883x: mute/unmute PA in correct sequence ASoC: codecs: wsa881x: mute/unmute PA in correct sequence sound/soc/codecs/wsa881x.c | 30 ++++++++++++++++++++- sound/soc/codecs/wsa883x.c | 36 ++++++++++++++++++++----- sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 3 +++ sound/soc/qcom/sdw.c | 7 ++--- 4 files changed, 63 insertions(+), 13 deletions(-) -- 2.21.0

4 16

[alsa-devel] echo-cancellation plugin advice?
by Max Klein 27 Oct '23

27 Oct '23

> Well, asym wouldn't be the answer. Basically you'll need to open two > slave PCMs in one plugin. So, it's no simple filter-type plugin. > It's doable, but not easy as it sounds, I guess. Takashi, can you please further explain why asym is not the solution and what you see as a problem? I am also trying to figure out if it would be possible to create such a plugin for ALSA? I am still searching for some good starting points on how to write an ALSA plugin... Jean-Marc Valin (http://lists.linuxaudio.org/pipermail/linux-audio-dev/2005-June/012454.html) already released his work as part of speex but as far I know there is no plugin that has been made out of it? Thanks for any hint! -- NEU: FreePhone 3-fach-Flat mit kostenlosem Smartphone! Jetzt informieren: http://mobile.1und1.de/?ac=OM.PW.PW003K20328T7073a

3 2

[PATCH 0/3] ARM: omap4: embt2ws: Add audio support
by Andreas Kemnade 25 Oct '23

25 Oct '23

Add audio support for Epson Moverio BT-200. In the vendor kernel, the MCBSP side is used as master, so do it here also that way. Andreas Kemnade (3): ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src ASoC: tlv320aic3x: use BCLK instead of MCLK if not in master mode ARM: dts: omap4: embt2ws: Add audio support arch/arm/boot/dts/omap4-epson-embt2ws.dts | 21 +++++++++++++++++++++ sound/soc/codecs/tlv320aic3x.c | 4 ++++ sound/soc/ti/omap-mcbsp.c | 4 ++-- 3 files changed, 27 insertions(+), 2 deletions(-) -- 2.39.2

4 28

[PATCH v4 00/42] ep93xx device tree conversion
by Nikita Shubin via B4 Relay 16 Oct '23

16 Oct '23

This series aims to convert ep93xx from platform to full device tree support. The main goal is to receive ACK's to take it via Arnd's arm-soc branch. Major changes: - drop newline at the end from each YAML files - rename dma and clk bindings headers to match first compatible - shrink SoC exported functions number to only 2 - dropped some ep93xx_pata fixes from these series - dropped m48t86 stuff from these series Bit thanks to Andy Shevchenko for thorough review. Some parts are were sent in advance, so these series depends on the following: Link: https://lore.kernel.org/all/20230823-m48t86_device_tree-v2-0-21ff275f949d@m… Link: https://lore.kernel.org/all/20230823-ep93xx_pata_fixes-v1-0-d7e7229be148@ma… --- Changes in v4: - gpio: ep93xx: split device in multiple - s/generic_handle_irq/generic_handle_domain_irq/ - s/int offset/irq_hw_number_t offset/ though now it looks a bit odd to me - drop i = 0 - drop 'error' - use dev_err_probe withour printing devname once again dt-bindings: clock: Add Cirrus EP93xx - renamed cirrus,ep93xx-clock.h -> cirrus,ep9301-clk.h clk: ep93xx: add DT support for Cirrus EP93xx - drop unused includes - use .name only for xtali, pll1, pll2 parents - convert // to /* - pass clk_parent_data instead of char* clock name dt-bindings: pinctrl: Add Cirrus EP93xx - s/additionalProperties/unevaluatedProperties/ dt-bindings: soc: Add Cirrus EP93xx - move syscon to soc directory - add vendor prefix - make reboot same style as pinctrl, clk - use absolute path for ref - expand example soc: Add SoC driver for Cirrus ep93xx - s/0xf0000000/GENMASK(31, 28)/ - s/ret/ep93xx_chip_revision(map)/ - drop symbol exports - convert to platform driver dt-bindings: rtc: Add Cirrus EP93xx - allOf: with $ref to rtc.yaml - s/additionalProperties/unevaluatedProperties/ dt-bindings: watchdog: Add Cirrus EP93x - drop description - reword power: reset: Add a driver for the ep93xx reset - lets use 'GPL-2.0+' instead of '(GPL-2.0)' - s/of_device/of/ - drop mdelay with warning - return 0 at the end net: cirrus: add DT support for Cirrus EP93xx - fix leaking np mtd: nand: add support for ts72xx - +bits.h - drop comment - ok to fwnode_get_next_child_node - use goto to put handle and nand and report error ARM: dts: add Cirrus EP93XX SoC .dtsi - add simple-bus for ebi, as we don't require to setup anything - add arm,pl011 compatible to uart nodes - drop i2c-gpio, as it's isn't used anywhere ARM: dts: ep93xx: add ts7250 board - generic node name for temperature-sensor - drop i2c - move nand, rtc, watchdog to ebi node - Link to v3: https://lore.kernel.org/r/20230605-ep93xx-v3-0-3d63a5f1103e@maquefel.me --- Alexander Sverdlin (2): ARM: dts: ep93xx: Add EDB9302 DT ASoC: cirrus: edb93xx: Delete driver Nikita Shubin (40): gpio: ep93xx: split device in multiple ARM: ep93xx: add swlocked prototypes dt-bindings: clock: Add Cirrus EP93xx clk: ep93xx: add DT support for Cirrus EP93xx dt-bindings: pinctrl: Add Cirrus EP93xx pinctrl: add a Cirrus ep93xx SoC pin controller dt-bindings: power: reset: Add ep93xx reset power: reset: Add a driver for the ep93xx reset dt-bindings: soc: Add Cirrus EP93xx soc: Add SoC driver for Cirrus ep93xx dt-bindings: timers: Add Cirrus EP93xx clocksource: ep93xx: Add driver for Cirrus Logic EP93xx dt-bindings: rtc: Add Cirrus EP93xx rtc: ep93xx: add DT support for Cirrus EP93xx dt-bindings: watchdog: Add Cirrus EP93x watchdog: ep93xx: add DT support for Cirrus EP93xx dt-bindings: pwm: Add Cirrus EP93xx pwm: ep93xx: add DT support for Cirrus EP93xx dt-bindings: spi: Add Cirrus EP93xx spi: ep93xx: add DT support for Cirrus EP93xx dt-bindings: net: Add Cirrus EP93xx net: cirrus: add DT support for Cirrus EP93xx dt-bindings: dma: Add Cirrus EP93xx dma: cirrus: add DT support for Cirrus EP93xx dt-bindings: mtd: Add ts7200 nand-controller mtd: nand: add support for ts72xx dt-bindings: ata: Add Cirrus EP93xx ata: pata_ep93xx: add device tree support dt-bindings: input: Add Cirrus EP93xx keypad input: keypad: ep93xx: add DT support for Cirrus EP93xx dt-bindings: wdt: Add ts72xx wdt: ts72xx: add DT support for ts72xx gpio: ep93xx: add DT support for gpio-ep93xx ARM: dts: add Cirrus EP93XX SoC .dtsi ARM: dts: ep93xx: add ts7250 board ARM: ep93xx: DT for the Cirrus ep93xx SoC platforms pwm: ep93xx: drop legacy pinctrl ata: pata_ep93xx: remove legacy pinctrl use ARM: ep93xx: delete all boardfiles ARM: ep93xx: soc: drop defines .../bindings/arm/cirrus/cirrus,ep9301.yaml | 38 + .../bindings/ata/cirrus,ep9312-pata.yaml | 42 + .../bindings/clock/cirrus,ep9301-clk.yaml | 46 + .../bindings/dma/cirrus,ep9301-dma-m2m.yaml | 69 + .../bindings/dma/cirrus,ep9301-dma-m2p.yaml | 121 ++ .../bindings/input/cirrus,ep9307-keypad.yaml | 87 ++ .../devicetree/bindings/mtd/technologic,nand.yaml | 45 + .../devicetree/bindings/net/cirrus,ep9301-eth.yaml | 59 + .../bindings/pinctrl/cirrus,ep9301-pinctrl.yaml | 57 + .../bindings/power/reset/cirrus,ep9301-reboot.yaml | 34 + .../devicetree/bindings/pwm/cirrus,ep9301-pwm.yaml | 46 + .../devicetree/bindings/rtc/cirrus,ep9301-rtc.yaml | 42 + .../bindings/soc/cirrus/cirrus,ep9301-syscon.yaml | 71 + .../devicetree/bindings/spi/cirrus,ep9301-spi.yaml | 61 + .../bindings/timer/cirrus,ep9301-timer.yaml | 49 + .../bindings/watchdog/cirrus,ep9301-wdt.yaml | 42 + .../bindings/watchdog/technologic,ts7200-wdt.yaml | 45 + arch/arm/Makefile | 1 - arch/arm/boot/dts/cirrus/Makefile | 4 + arch/arm/boot/dts/cirrus/ep93xx-bk3.dts | 124 ++ arch/arm/boot/dts/cirrus/ep93xx-edb9302.dts | 180 +++ arch/arm/boot/dts/cirrus/ep93xx-ts7250.dts | 143 ++ arch/arm/boot/dts/cirrus/ep93xx.dtsi | 454 +++++++ arch/arm/mach-ep93xx/Kconfig | 20 +- arch/arm/mach-ep93xx/Makefile | 11 - arch/arm/mach-ep93xx/clock.c | 733 ---------- arch/arm/mach-ep93xx/core.c | 1017 -------------- arch/arm/mach-ep93xx/dma.c | 114 -- arch/arm/mach-ep93xx/edb93xx.c | 344 ----- arch/arm/mach-ep93xx/ep93xx-regs.h | 38 - arch/arm/mach-ep93xx/gpio-ep93xx.h | 111 -- arch/arm/mach-ep93xx/hardware.h | 25 - arch/arm/mach-ep93xx/irqs.h | 76 -- arch/arm/mach-ep93xx/platform.h | 42 - arch/arm/mach-ep93xx/soc.h | 212 --- arch/arm/mach-ep93xx/ts72xx.c | 422 ------ arch/arm/mach-ep93xx/ts72xx.h | 94 -- arch/arm/mach-ep93xx/vision_ep9307.c | 311 ----- drivers/ata/pata_ep93xx.c | 33 +- drivers/clk/Kconfig | 8 + drivers/clk/Makefile | 1 + drivers/clk/clk-ep93xx.c | 753 +++++++++++ drivers/clocksource/Kconfig | 11 + drivers/clocksource/Makefile | 1 + .../clocksource}/timer-ep93xx.c | 155 ++- drivers/dma/ep93xx_dma.c | 125 +- drivers/gpio/gpio-ep93xx.c | 331 ++--- drivers/input/keyboard/ep93xx_keypad.c | 74 +- drivers/mtd/nand/raw/Kconfig | 7 + drivers/mtd/nand/raw/Makefile | 1 + drivers/mtd/nand/raw/technologic-nand-controller.c | 166 +++ drivers/net/ethernet/cirrus/ep93xx_eth.c | 63 +- drivers/pinctrl/Kconfig | 7 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-ep93xx.c | 1429 ++++++++++++++++++++ drivers/power/reset/Kconfig | 10 + drivers/power/reset/Makefile | 1 + drivers/power/reset/ep93xx-restart.c | 85 ++ drivers/pwm/pwm-ep93xx.c | 26 +- drivers/rtc/rtc-ep93xx.c | 8 + drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/cirrus/Kconfig | 12 + drivers/soc/cirrus/Makefile | 2 + drivers/soc/cirrus/soc-ep93xx.c | 215 +++ drivers/spi/spi-ep93xx.c | 28 +- drivers/watchdog/ep93xx_wdt.c | 8 + drivers/watchdog/ts72xx_wdt.c | 8 + include/dt-bindings/clock/cirrus,ep9301-clk.h | 41 + include/dt-bindings/dma/cirrus,ep93xx-dma.h | 26 + include/linux/platform_data/dma-ep93xx.h | 25 +- include/linux/platform_data/eth-ep93xx.h | 10 - include/linux/platform_data/keypad-ep93xx.h | 32 - include/linux/soc/cirrus/ep93xx.h | 29 +- sound/soc/cirrus/Kconfig | 9 - sound/soc/cirrus/Makefile | 4 - sound/soc/cirrus/edb93xx.c | 117 -- 77 files changed, 5126 insertions(+), 4168 deletions(-) --- base-commit: bdc09c8e8b16d494ccd1c56e903e78dd76455a35 change-id: 20230605-ep93xx-01c76317e2d2 Best regards, -- Nikita Shubin <nikita.shubin(a)maquefel.me>

4 4

[PATCH] ASoC: apple: mca: Annotate struct mca_data with __counted_by
by Kees Cook 11 Oct '23

11 Oct '23

Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct mca_data. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted… Cc: "Martin Povišer" <povik+lin(a)cutebit.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: asahi(a)lists.linux.dev Cc: alsa-devel(a)alsa-project.org Signed-off-by: Kees Cook <keescook(a)chromium.org> --- sound/soc/apple/mca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c index ce77934f3eef..99e547ef95e6 100644 --- a/sound/soc/apple/mca.c +++ b/sound/soc/apple/mca.c @@ -161,7 +161,7 @@ struct mca_data { struct mutex port_mutex; int nclusters; - struct mca_cluster clusters[]; + struct mca_cluster clusters[] __counted_by(nclusters); }; static void mca_modify(struct mca_cluster *cl, int regoffset, u32 mask, u32 val) -- 2.34.1

3 7