July 2023 - Alsa-devel - mailman.alsa-project.org

Problem with Rog Delta S Wireless
by GitHub issues - opened 30 Jul '23

30 Jul '23

alsa-project/alsa-utils issue #227 was opened from bagou4502: Greetings, I am posting this issue here since I haven't found a solution in forums yet. I am facing an problem with my Rog Delta S Wireless headset when using Linux with Gnome. The volume control doesn't function correctly. Setting the volume to < 95% keeps the sound at 0 in alsamixer. When I set it to 95%, alsamixer shows 50%, and 100% corresponds to 100% in alsamixer. This issue occurs specifically with this headset in both 2.4GHz and Bluetooth modes. I have already tried using another Rog Delta S Wireless headset, but the same problem persists. Additionally, I tested it on multiple computers running Fedora, Ubuntu 22.04 and 23.04, Debian 11 and 12, as well as ZorinOs 16.2 and 16.3, and encountered the same problem on all of them. Here is a video demonstrating the issue: https://www.youtube.com/watch?v=-OuKtLt5U1k Unfortunately, I am uncertain whether this problem originates from the Gnome volume system or AlsaMixer. I am hopeful that someone can assist me with this matter. Thank you for your help. Issue URL : https://github.com/alsa-project/alsa-utils/issues/227 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Documentation cleanup
by GitHub pull_request - opened 30 Jul '23

30 Jul '23

alsa-project/alsa-lib pull request #340 was opened from borine: Fixes missing doxygen tags and macros so that now doxygen picks up all of the documentation comments and completes cleanly without any errors or warnings. Request URL : https://github.com/alsa-project/alsa-lib/pull/340 Patch URL : https://github.com/alsa-project/alsa-lib/pull/340.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Fwd: Lenovo Thinkpad T490 Microphone Noise
by Bagas Sanjaya 30 Jul '23

30 Jul '23

Hi, I notice a bug report on Bugzilla [1]. Quoting from it: > I have reported this issue to the Arch but they redirected me to here. > https://bugs.archlinux.org/task/79245 > > > Description: > When I use microphone for online meetings, my sound reaches them with a high noise that prevent it from being understood. I tested the microphone on my own and yes the noise is there. I tried pulseaudio and pipewire, but neither has solved the problem. This problem is not stemming from hardware since I do not have this issue with Windows 10. > > Additional info: > * pulseaudio: 16.1-6, piprewire: 1:0.3.75-2, kernel: 6.4.6-arch1-1 > > Steps to reproduce: > 1 - Open a chat app/website or online meeting tool like, Whatsapp, Signal, Zoom, etc. > 2 - Speak to the microphone. You can use Whatsapp and Signal to listen your microphone sound. See Bugzilla for the full thread. The reporter chose the incorrect component when this bug was being filed on Bugzilla (only generic `Kernel`), hence missing sound maintainers and I had to forward it to the mailing list instead. Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217730 -- An old man doll... just what I always wanted! - Clara

1 0

ALC3306 beeing registered as ALC287 on Lenovo Yoga
by GitHub issues - opened 29 Jul '23

29 Jul '23

alsa-project/alsa-lib issue #339 was opened from InfinityRed-Code: I have a Lenovo Yoga 7 16IAP7 with Fedora Workstation 38 installed. Kernel Verion: Linux 6.4.6-200.fc38.x86_64 alsa-lib version: alsa-lib-1.2.9-1.fc38.x86_64 I installed alsa-tools and went into hdajackretask to see what is going on. Then I noticed that my System is telling me that I have an ALC287 installed but actually it is a ALC3306. Sound is horrible and several fixes with ALC 287 for Legion Models did nit work. In the Settings I can see as well, that only 2 of the 4 integrated speakers are getting noticed. Is there any known fix? Issue URL : https://github.com/alsa-project/alsa-lib/issues/339 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH] ALSA: bcd2000: refactor deprecated strncpy
by Justin Stitt 29 Jul '23

29 Jul '23

`strncpy` is deprecated for use on NUL-terminated destination strings [1]. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on its destination buffer argument which is _not_ always the case for `strncpy`! It should be noted that, in this case, the destination buffer has a length strictly greater than the source string. Moreover, the source string is NUL-terminated (and so is the destination) which means there was no real bug happening here. Nonetheless, this patch would get us one step closer to eliminating the `strncpy` API in the kernel, as its use is too ambiguous. We need to favor less ambiguous replacements such as: strscpy, strscpy_pad, strtomem and strtomem_pad (amongst others). Technically, my patch yields subtly different behavior. The original implementation with `strncpy` would fill the entire destination buffer with null bytes [3] while `strscpy` will leave the junk, uninitialized bytes trailing after the _mandatory_ NUL-termination. So, if somehow `card->driver` or `card->shortname` require this NUL-padding behavior then `strscpy_pad` should be used. My interpretation, though, is that the aforementioned fields are just fine as NUL-terminated strings. Please correct my assumptions if needed and I'll send in a v2. [1]: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-termi… [2]: manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [3]: https://linux.die.net/man/3/strncpy Link: https://github.com/KSPP/linux/issues/90 Link: https://lore.kernel.org/r/20230727-sound-xen-v1-1-89dd161351f1@google.com (related ALSA patch) Signed-off-by: Justin Stitt <justinstitt(a)google.com> --- sound/usb/bcd2000/bcd2000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/bcd2000/bcd2000.c b/sound/usb/bcd2000/bcd2000.c index 7aec0a95c609..392b4d8e9e76 100644 --- a/sound/usb/bcd2000/bcd2000.c +++ b/sound/usb/bcd2000/bcd2000.c @@ -395,8 +395,8 @@ static int bcd2000_probe(struct usb_interface *interface, snd_card_set_dev(card, &interface->dev); - strncpy(card->driver, "snd-bcd2000", sizeof(card->driver)); - strncpy(card->shortname, "BCD2000", sizeof(card->shortname)); + strscpy(card->driver, "snd-bcd2000", sizeof(card->driver)); + strscpy(card->shortname, "BCD2000", sizeof(card->shortname)); usb_make_path(bcd2k->dev, usb_path, sizeof(usb_path)); snprintf(bcd2k->card->longname, sizeof(bcd2k->card->longname), "Behringer BCD2000 at %s", --- base-commit: 57012c57536f8814dec92e74197ee96c3498d24e change-id: 20230727-sound-usb-bcd2000-400b3060a9f9 Best regards, -- Justin Stitt <justinstitt(a)google.com>

2 1

[PATCH v3 31/50] ASoC: dt-bindings: microchip: add sam9x7
by Varshini Rajendran 29 Jul '23

29 Jul '23

Add sam9x7 compatible in the DT documentation. Signed-off-by: Varshini Rajendran <varshini.rajendran(a)microchip.com> --- .../bindings/sound/microchip,sama7g5-i2smcc.yaml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml index 651f61c7c25a..fb630a184350 100644 --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml @@ -24,9 +24,14 @@ properties: const: 0 compatible: - enum: - - microchip,sam9x60-i2smcc - - microchip,sama7g5-i2smcc + oneOf: + - enum: + - microchip,sam9x60-i2smcc + - microchip,sama7g5-i2smcc + - items: + - enum: + - microchip,sam9x7-i2smcc + - const: microchip,sam9x60-i2smcc reg: maxItems: 1 -- 2.25.1

1 0

[tiwai-sound:test/pcm-sockptr 18/26] drivers/media/pci/solo6x10/solo6x10-g723.c:242:11: error: use of undeclared identifier 'snd_solo_pcm_copy_user'; did you mean 'snd_solo_pcm_copy'?
by kernel test robot 29 Jul '23

29 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/pcm-sockptr head: 3fffa74b00add561981357c76375e1829059d4e5 commit: 79cf0bf97368998dd44c1863d6f54057846b68c9 [18/26] media: solo6x10: Convert to generic PCM copy ops config: x86_64-randconfig-x004-20230728 (https://download.01.org/0day-ci/archive/20230729/202307291526.AOnKZKB1-lkp@…) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291526.AOnKZKB1-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307291526.AOnKZKB1-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/media/pci/solo6x10/solo6x10-g723.c:242:11: error: use of undeclared identifier 'snd_solo_pcm_copy_user'; did you mean 'snd_solo_pcm_copy'? .copye = snd_solo_pcm_copy_user, ^~~~~~~~~~~~~~~~~~~~~~ snd_solo_pcm_copy drivers/media/pci/solo6x10/solo6x10-g723.c:207:12: note: 'snd_solo_pcm_copy' declared here static int snd_solo_pcm_copy(struct snd_pcm_substream *ss, int channel, ^ >> drivers/media/pci/solo6x10/solo6x10-g723.c:242:3: error: field designator 'copye' does not refer to any field in type 'const struct snd_pcm_ops'; did you mean 'copy'? .copye = snd_solo_pcm_copy_user, ^~~~~ copy include/sound/pcm.h:72:8: note: 'copy' declared here int (*copy)(struct snd_pcm_substream *substream, int channel, ^ 2 errors generated. vim +242 drivers/media/pci/solo6x10/solo6x10-g723.c 235 236 static const struct snd_pcm_ops snd_solo_pcm_ops = { 237 .open = snd_solo_pcm_open, 238 .close = snd_solo_pcm_close, 239 .prepare = snd_solo_pcm_prepare, 240 .trigger = snd_solo_pcm_trigger, 241 .pointer = snd_solo_pcm_pointer, > 242 .copye = snd_solo_pcm_copy_user, 243 }; 244 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:test/pcm-sockptr 18/26] drivers/media/pci/solo6x10/solo6x10-g723.c:207:12: warning: 'snd_solo_pcm_copy' defined but not used
by kernel test robot 29 Jul '23

29 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/pcm-sockptr head: 3fffa74b00add561981357c76375e1829059d4e5 commit: 79cf0bf97368998dd44c1863d6f54057846b68c9 [18/26] media: solo6x10: Convert to generic PCM copy ops config: i386-buildonly-randconfig-r004-20230728 (https://download.01.org/0day-ci/archive/20230729/202307291119.03yget13-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291119.03yget13-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307291119.03yget13-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/media/pci/solo6x10/solo6x10-g723.c:242:10: error: 'const struct snd_pcm_ops' has no member named 'copye'; did you mean 'copy'? 242 | .copye = snd_solo_pcm_copy_user, | ^~~~~ | copy drivers/media/pci/solo6x10/solo6x10-g723.c:242:18: error: 'snd_solo_pcm_copy_user' undeclared here (not in a function); did you mean 'snd_solo_pcm_copy'? 242 | .copye = snd_solo_pcm_copy_user, | ^~~~~~~~~~~~~~~~~~~~~~ | snd_solo_pcm_copy drivers/media/pci/solo6x10/solo6x10-g723.c:242:18: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init] drivers/media/pci/solo6x10/solo6x10-g723.c:242:18: note: (near initialization for 'snd_solo_pcm_ops') >> drivers/media/pci/solo6x10/solo6x10-g723.c:207:12: warning: 'snd_solo_pcm_copy' defined but not used [-Wunused-function] 207 | static int snd_solo_pcm_copy(struct snd_pcm_substream *ss, int channel, | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/snd_solo_pcm_copy +207 drivers/media/pci/solo6x10/solo6x10-g723.c 206 > 207 static int snd_solo_pcm_copy(struct snd_pcm_substream *ss, int channel, 208 unsigned long pos, sockptr_t dst, 209 unsigned long count) 210 { 211 struct solo_snd_pcm *solo_pcm = snd_pcm_substream_chip(ss); 212 struct solo_dev *solo_dev = solo_pcm->solo_dev; 213 unsigned int off = 0; 214 int err, i; 215 216 for (i = 0; i < (count / G723_FRAMES_PER_PAGE); i++) { 217 int page = (pos / G723_FRAMES_PER_PAGE) + i; 218 219 err = solo_p2m_dma_t(solo_dev, 0, solo_pcm->g723_dma, 220 SOLO_G723_EXT_ADDR(solo_dev) + 221 (page * G723_PERIOD_BLOCK) + 222 (ss->number * G723_PERIOD_BYTES), 223 G723_PERIOD_BYTES, 0, 0); 224 if (err) 225 return err; 226 227 if (copy_to_sockptr_offset(dst, off, 228 solo_pcm->g723_buf, G723_PERIOD_BYTES)) 229 return -EFAULT; 230 off += G723_PERIOD_BYTES; 231 } 232 233 return 0; 234 } 235 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH] ASoC: 88pm860x: refactor deprecated strncpy
by Justin Stitt 28 Jul '23

28 Jul '23

`strncpy` is deprecated for use on NUL-terminated destination strings [1]. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on its destination buffer argument which is _not_ always the case for `strncpy`! In this case, though, there was care taken to ensure that the destination buffer would be NUL-terminated. The destination buffer is zero-initialized and each `pm860x->name[i]` has a size of `MAX_NAME_LENGTH + 1`. This means that there is unlikely to be a bug here. However, in an attempt to eliminate the usage of the `strncpy` API as well as disambiguate implementations, replacements such as: `strscpy`, `strscpy_pad`, `strtomem` and `strtomem_pad` should be preferred. We are able to eliminate the need for `len + 1` since `strscpy` guarantees NUL-termination for its destination buffer as per its implementation [3]: | /* Hit buffer length without finding a NUL; force NUL-termination. */ | if (res) | dest[res-1] = '\0'; [1]: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-termi… [2]: manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [3]: https://elixir.bootlin.com/linux/v6.3/source/lib/string.c#L183 Link: https://github.com/KSPP/linux/issues/90 Signed-off-by: Justin Stitt <justinstitt(a)google.com> --- sound/soc/codecs/88pm860x-codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/88pm860x-codec.c b/sound/soc/codecs/88pm860x-codec.c index 3574c68e0dda..d99b674d574b 100644 --- a/sound/soc/codecs/88pm860x-codec.c +++ b/sound/soc/codecs/88pm860x-codec.c @@ -143,7 +143,7 @@ struct pm860x_priv { struct pm860x_det det; int irq[4]; - unsigned char name[4][MAX_NAME_LEN+1]; + unsigned char name[4][MAX_NAME_LEN]; }; /* -9450dB to 0dB in 150dB steps ( mute instead of -9450dB) */ @@ -1373,7 +1373,7 @@ static int pm860x_codec_probe(struct platform_device *pdev) return -EINVAL; } pm860x->irq[i] = res->start + chip->irq_base; - strncpy(pm860x->name[i], res->name, MAX_NAME_LEN); + strscpy(pm860x->name[i], res->name, MAX_NAME_LEN); } ret = devm_snd_soc_register_component(&pdev->dev, --- base-commit: 57012c57536f8814dec92e74197ee96c3498d24e change-id: 20230727-sound-soc-codecs-947fcb9536a7 Best regards, -- Justin Stitt <justinstitt(a)google.com>

3 2

[PATCH] ASoC: Intel: Skylake: replace deprecated strncpy with strscpy
by justinstitt＠google.com 28 Jul '23

28 Jul '23

`strncpy` is deprecated for use on NUL-terminated destination strings [1]. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on its destination buffer argument which is _not_ the case for `strncpy`! It was pretty difficult, in this case, to try and figure out whether or not the destination buffer was zero-initialized. If it is and this behavior is relied on then perhaps `strscpy_pad` is the preferred option here. Kees was able to help me out and identify the following code snippet which seems to show that the destination buffer is zero-initialized. | skl = devm_kzalloc(&pci->dev, sizeof(*skl), GFP_KERNEL); With this information, I opted for `strscpy` since padding is seemingly not required. Also within this patch is a change to an instance of `x > y - 1` to `x >= y` which tends to be more robust and readable. Consider, for instance, if `y` was somehow `INT_MIN`. [1]: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-termi… [2]: manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html Link: https://github.com/KSPP/linux/issues/90 Suggested-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Justin Stitt <justinstitt(a)google.com> --- sound/soc/intel/skylake/skl-topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 96cfebded072..67f08ec3a2ea 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3154,12 +3154,12 @@ static int skl_tplg_fill_str_mfest_tkn(struct device *dev, switch (str_elem->token) { case SKL_TKN_STR_LIB_NAME: - if (ref_count > skl->lib_count - 1) { + if (ref_count >= skl->lib_count) { ref_count = 0; return -EINVAL; } - strncpy(skl->lib_info[ref_count].name, + strscpy(skl->lib_info[ref_count].name, str_elem->string, ARRAY_SIZE(skl->lib_info[ref_count].name)); ref_count++; --- base-commit: 0b4a9fdc9317440a71d4d4c264a5650bf4a90f3c change-id: 20230726-asoc-intel-skylake-remove-deprecated-strncpy-9dbcfc26040c Best regards, -- Justin Stitt <justinstitt(a)google.com>

5 9