May 2023 - Alsa-devel - mailman.alsa-project.org

Bug: premature stringification in SND_DLSYM_BUILD_VERSION produces wrong results for alsa-plugins.
by GitHub issues - edited 07 May '23

07 May '23

alsa-project/alsa-lib issue #316 was edited from MIvanchev: [The macro](https://github.com/alsa-project/alsa-lib/blob/master/include/global.…: ``` #define SND_DLSYM_BUILD_VERSION(name, version) \ static struct snd_dlsym_link __SND_DLSYM_VERSION(snd_dlsym_, name, version); \ void __SND_DLSYM_VERSION(snd_dlsym_constructor_, name, version) (void) __attribute__ ((constructor)); \ void __SND_DLSYM_VERSION(snd_dlsym_constructor_, name, version) (void) { \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).next = snd_dlsym_start; \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_name = # name; \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_ptr = (void *)&name; \ snd_dlsym_start = &__SND_DLSYM_VERSION(snd_dlsym_, name, version); \ } ``` should actually be ``` #define SND_DLSYM_NAME(name) #name #define SND_DLSYM_BUILD_VERSION(name, version) \ static struct snd_dlsym_link __SND_DLSYM_VERSION(snd_dlsym_, name, version); \ void __SND_DLSYM_VERSION(snd_dlsym_constructor_, name, version) (void) __attribute__ ((constructor)); \ void __SND_DLSYM_VERSION(snd_dlsym_constructor_, name, version) (void) { \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).next = snd_dlsym_start; \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_name = SND_DLSYM_NAME(name) \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_ptr = (void *)&name; \ snd_dlsym_start = &__SND_DLSYM_VERSION(snd_dlsym_, name, version); \ } ``` This is because for instance [this code](https://github.com/alsa-project/alsa-plugins/blob/master/pulse/ctl_pu… `SND_CTL_PLUGIN_SYMBOL(pulse);` expands to ``` SND_DLSYM_BUILD_VERSION(SND_CTL_PLUGIN_ENTRY(pulse), SND_CONTROL_DLSYM_VERSION); ``` and this expands to ``` ... __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_name = # SND_CTL_PLUGIN_ENTRY(pulse) ... ``` but the C preprocessor doesn't expand stringified tokens so the value of `dlsym_name` is actually `"SND_CTL_PLUGIN_ENTRY(pulse)"`. Issue URL : https://github.com/alsa-project/alsa-lib/issues/316 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Bug: premature stringification in SND_DLSYM_BUILD_VERSION produces wrong results for alsa-plugins.
by GitHub issues - opened 07 May '23

07 May '23

alsa-project/alsa-lib issue #316 was opened from MIvanchev: The macro: ``` #define SND_DLSYM_BUILD_VERSION(name, version) \ static struct snd_dlsym_link __SND_DLSYM_VERSION(snd_dlsym_, name, version); \ void __SND_DLSYM_VERSION(snd_dlsym_constructor_, name, version) (void) __attribute__ ((constructor)); \ void __SND_DLSYM_VERSION(snd_dlsym_constructor_, name, version) (void) { \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).next = snd_dlsym_start; \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_name = # name; \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_ptr = (void *)&name; \ snd_dlsym_start = &__SND_DLSYM_VERSION(snd_dlsym_, name, version); \ } ``` should actually be ``` #define SND_DLSYM_NAME(name) #name #define SND_DLSYM_BUILD_VERSION(name, version) \ static struct snd_dlsym_link __SND_DLSYM_VERSION(snd_dlsym_, name, version); \ void __SND_DLSYM_VERSION(snd_dlsym_constructor_, name, version) (void) __attribute__ ((constructor)); \ void __SND_DLSYM_VERSION(snd_dlsym_constructor_, name, version) (void) { \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).next = snd_dlsym_start; \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_name = SND_DLSYM_NAME(name) \ __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_ptr = (void *)&name; \ snd_dlsym_start = &__SND_DLSYM_VERSION(snd_dlsym_, name, version); \ } ``` This is because for instance [this code](https://github.com/alsa-project/alsa-plugins/blob/master/pulse/ctl_pu… `SND_CTL_PLUGIN_SYMBOL(pulse);` expands to ``` SND_DLSYM_BUILD_VERSION(SND_CTL_PLUGIN_ENTRY(pulse), SND_CONTROL_DLSYM_VERSION); ``` and this expands to ``` ... __SND_DLSYM_VERSION(snd_dlsym_, name, version).dlsym_name = # SND_CTL_PLUGIN_ENTRY(pulse) ... ``` but the C preprocessor doesn't expand stringified tokens so the value of `dlsym_name` is actually `"SND_CTL_PLUGIN_ENTRY(pulse)"`. Issue URL : https://github.com/alsa-project/alsa-lib/issues/316 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH AUTOSEL 4.14 1/8] ASoC: jack: allow multiple interrupt per gpio
by Sasha Levin 07 May '23

07 May '23

From: Svyatoslav Ryhel <clamor95(a)gmail.com> [ Upstream commit a2d4051b0bd6dffcd736888ae89a550d6f60b060 ] This feature is required for coupled hp-mic quirk used by some Nvidia Tegra 3 based devices work properly. Signed-off-by: Svyatoslav Ryhel <clamor95(a)gmail.com> Link: https://lore.kernel.org/r/20230221183211.21964-3-clamor95@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/soc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index b04ecc633da36..f04a6eb8eecc8 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -451,6 +451,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, ret = request_any_context_irq(gpiod_to_irq(gpios[i].desc), gpio_handler, + IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, gpios[i].name, -- 2.39.2

1 0

[PATCH AUTOSEL 4.19 1/9] ASoC: jack: allow multiple interrupt per gpio
by Sasha Levin 07 May '23

07 May '23

From: Svyatoslav Ryhel <clamor95(a)gmail.com> [ Upstream commit a2d4051b0bd6dffcd736888ae89a550d6f60b060 ] This feature is required for coupled hp-mic quirk used by some Nvidia Tegra 3 based devices work properly. Signed-off-by: Svyatoslav Ryhel <clamor95(a)gmail.com> Link: https://lore.kernel.org/r/20230221183211.21964-3-clamor95@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/soc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index 2a528e73bad25..bba84df0982f7 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -424,6 +424,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, ret = request_any_context_irq(gpiod_to_irq(gpios[i].desc), gpio_handler, + IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, gpios[i].name, -- 2.39.2

1 0

[PATCH AUTOSEL 5.4 1/9] ASoC: jack: allow multiple interrupt per gpio
by Sasha Levin 07 May '23

07 May '23

From: Svyatoslav Ryhel <clamor95(a)gmail.com> [ Upstream commit a2d4051b0bd6dffcd736888ae89a550d6f60b060 ] This feature is required for coupled hp-mic quirk used by some Nvidia Tegra 3 based devices work properly. Signed-off-by: Svyatoslav Ryhel <clamor95(a)gmail.com> Link: https://lore.kernel.org/r/20230221183211.21964-3-clamor95@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/soc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index b5748dcd490f2..e83f9a2541cab 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -406,6 +406,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, ret = request_any_context_irq(gpiod_to_irq(gpios[i].desc), gpio_handler, + IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, gpios[i].name, -- 2.39.2

1 0

[PATCH AUTOSEL 5.10 1/9] ASoC: jack: allow multiple interrupt per gpio
by Sasha Levin 07 May '23

07 May '23

From: Svyatoslav Ryhel <clamor95(a)gmail.com> [ Upstream commit a2d4051b0bd6dffcd736888ae89a550d6f60b060 ] This feature is required for coupled hp-mic quirk used by some Nvidia Tegra 3 based devices work properly. Signed-off-by: Svyatoslav Ryhel <clamor95(a)gmail.com> Link: https://lore.kernel.org/r/20230221183211.21964-3-clamor95@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/soc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index 0f1820f36b4d7..80ea4408e6ad6 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -368,6 +368,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, ret = request_any_context_irq(gpiod_to_irq(gpios[i].desc), gpio_handler, + IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, gpios[i].name, -- 2.39.2

1 0

[PATCH AUTOSEL 5.15 01/10] ASoC: jack: allow multiple interrupt per gpio
by Sasha Levin 07 May '23

07 May '23

From: Svyatoslav Ryhel <clamor95(a)gmail.com> [ Upstream commit a2d4051b0bd6dffcd736888ae89a550d6f60b060 ] This feature is required for coupled hp-mic quirk used by some Nvidia Tegra 3 based devices work properly. Signed-off-by: Svyatoslav Ryhel <clamor95(a)gmail.com> Link: https://lore.kernel.org/r/20230221183211.21964-3-clamor95@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/soc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index d798765d168c4..a7256ad49b243 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -367,6 +367,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, ret = request_any_context_irq(gpiod_to_irq(gpios[i].desc), gpio_handler, + IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, gpios[i].name, -- 2.39.2

1 1

[PATCH AUTOSEL 6.1 01/19] ASoC: jack: allow multiple interrupt per gpio
by Sasha Levin 07 May '23

07 May '23

From: Svyatoslav Ryhel <clamor95(a)gmail.com> [ Upstream commit a2d4051b0bd6dffcd736888ae89a550d6f60b060 ] This feature is required for coupled hp-mic quirk used by some Nvidia Tegra 3 based devices work properly. Signed-off-by: Svyatoslav Ryhel <clamor95(a)gmail.com> Link: https://lore.kernel.org/r/20230221183211.21964-3-clamor95@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/soc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index fcece5ca38c69..f951acb2ce362 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -367,6 +367,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, ret = request_any_context_irq(gpiod_to_irq(gpios[i].desc), gpio_handler, + IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, gpios[i].name, -- 2.39.2

1 5

[PATCH AUTOSEL 6.2 01/20] ASoC: jack: allow multiple interrupt per gpio
by Sasha Levin 07 May '23

07 May '23

From: Svyatoslav Ryhel <clamor95(a)gmail.com> [ Upstream commit a2d4051b0bd6dffcd736888ae89a550d6f60b060 ] This feature is required for coupled hp-mic quirk used by some Nvidia Tegra 3 based devices work properly. Signed-off-by: Svyatoslav Ryhel <clamor95(a)gmail.com> Link: https://lore.kernel.org/r/20230221183211.21964-3-clamor95@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/soc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index fcece5ca38c69..f951acb2ce362 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -367,6 +367,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, ret = request_any_context_irq(gpiod_to_irq(gpios[i].desc), gpio_handler, + IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, gpios[i].name, -- 2.39.2

1 5

MSI MAG B650M Mortar Wifi Spdif input & output are reversed
by GitHub issues - opened 06 May '23

06 May '23

alsa-project/alsa-ucm-conf issue #311 was opened from RenEH01: Hi, I have a MSI MAG B650M Mortar Wifi. I have installed this UCM conf files which provided no sound. I further installed pauvcontrol and I found changing the USB Audio device under Configuration to Pro Audio and changing the output device under Output Devices to USB Audio Pro 2 allowed for sound. When I select Digital Stereo (IEC958) Output under configuration I get no sound. When I select Digital Stereo Duplex Duplex under configuration I get no sound, but there is sound under Input Devices. I believe this is reversed. I do not think this board has spdif input functionality at all. A side effect of using Pro Audio 2 for output is that none of my multi channel tracks are downsampled for 2.0. I'm guessing this will be resolved if the above isssue is resolved. Would that be correct? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/311 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0