October 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH 00/16] Harden SSP boards and add TDM support
by Amadeusz Sławiński 12 Oct '23

12 Oct '23

In quite a few places in code there are checks for number of SSPs present on system, to reduce maintenance burden introduce helper functions allowing to get SSP and TDM from machine board configuration. Current mechanism replaces "%d" present in some routes and widget names with SSP number. However there are also configurations which make use of of TDM number, in which case expected behavior would be to have string in form of SSP:TDM - see implementation of avs_i2s_platform_register() in sound/soc/intel/avs/pcm.c. Implement custom function, which parses string and make use of it when parsing topology. While at it make sure that we generate dynamic names only if there is no multiple SSPs or TDMs defined. Migrate all boards to handle TDM if requested. Amadeusz Sławiński (16): ASoC: Intel: avs: Only create SSP%d snd_soc_dai_driver when requested ASoC: Intel: avs: Introduce helper functions for SSP and TDM handling ASoC: Intel: avs: Improve topology parsing of dynamic strings ASoC: Intel: avs: i2s_test: Validate machine board configuration ASoC: Intel: avs: rt274: Validate machine board configuration ASoC: Intel: avs: rt5682: Validate machine board configuration ASoC: Intel: avs: max98357a: Validate machine board configuration ASoC: Intel: avs: rt298: Validate machine board configuration ASoC: Intel: avs: da7219: Validate machine board configuration ASoC: Intel: avs: es8336: Validate machine board configuration ASoC: Intel: avs: max98373: Validate machine board configuration ASoC: Intel: avs: max98927: Validate machine board configuration ASoC: Intel: avs: nau8825: Validate machine board configuration ASoC: Intel: avs: rt286: Validate machine board configuration ASoC: Intel: avs: rt5663: Validate machine board configuration ASoC: Intel: avs: ssm4567: Validate machine board configuration sound/soc/intel/avs/board_selection.c | 2 +- sound/soc/intel/avs/boards/da7219.c | 17 +++-- sound/soc/intel/avs/boards/es8336.c | 18 +++-- sound/soc/intel/avs/boards/i2s_test.c | 55 ++++++++----- sound/soc/intel/avs/boards/max98357a.c | 18 +++-- sound/soc/intel/avs/boards/max98373.c | 18 +++-- sound/soc/intel/avs/boards/max98927.c | 18 +++-- sound/soc/intel/avs/boards/nau8825.c | 18 +++-- sound/soc/intel/avs/boards/rt274.c | 18 +++-- sound/soc/intel/avs/boards/rt286.c | 19 +++-- sound/soc/intel/avs/boards/rt298.c | 18 +++-- sound/soc/intel/avs/boards/rt5663.c | 18 +++-- sound/soc/intel/avs/boards/rt5682.c | 18 +++-- sound/soc/intel/avs/boards/ssm4567.c | 18 +++-- sound/soc/intel/avs/pcm.c | 28 ++++--- sound/soc/intel/avs/topology.c | 102 +++++++++++++++++++------ sound/soc/intel/avs/utils.h | 65 ++++++++++++++++ 17 files changed, 346 insertions(+), 122 deletions(-) create mode 100644 sound/soc/intel/avs/utils.h -- 2.34.1

2 19

[PATCH] ASoC: cs42l42: Fix missing include of gpio/consumer.h
by Richard Fitzgerald 11 Oct '23

11 Oct '23

The call to gpiod_set_value_cansleep() in cs42l42_sdw_update_status() needs the header file gpio/consumer.h to be included. This was introduced by commit 2d066c6a7865 ("ASoC: cs42l42: Avoid stale SoundWire ATTACH after hard reset") and caused error: sound/soc/codecs/cs42l42-sdw.c:374:4: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean gpio_set_value_cansleep’? Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> Fixes: 2d066c6a7865 ("ASoC: cs42l42: Avoid stale SoundWire ATTACH after hard reset") --- sound/soc/codecs/cs42l42-sdw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/cs42l42-sdw.c b/sound/soc/codecs/cs42l42-sdw.c index 974bae4abfad..94a66a325303 100644 --- a/sound/soc/codecs/cs42l42-sdw.c +++ b/sound/soc/codecs/cs42l42-sdw.c @@ -6,6 +6,7 @@ #include <linux/acpi.h> #include <linux/device.h> +#include <linux/gpio/consumer.h> #include <linux/iopoll.h> #include <linux/module.h> #include <linux/mod_devicetable.h> -- 2.30.2

2 1

[PATCH] ALSA: hda: cs35l56: Enable low-power hibernation mode on i2c
by Richard Fitzgerald 11 Oct '23

11 Oct '23

From: Simon Trimmer <simont(a)opensource.cirrus.com> This can now be re-enabled as the sequence to reliably wake the device has been implemented in the shared ASoC code. This has a functional dependency on commit 3df761bdbc8b ("ASoC: cs35l56: Wake transactions need to be issued twice") To protect against this, enabling hibernation is conditional on CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new hibernation sequences are available. Signed-off-by: Simon Trimmer <simont(a)opensource.cirrus.com> Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- sound/pci/hda/cs35l56_hda_i2c.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/cs35l56_hda_i2c.c b/sound/pci/hda/cs35l56_hda_i2c.c index 757a4d193e0f..a9ef6d86de83 100644 --- a/sound/pci/hda/cs35l56_hda_i2c.c +++ b/sound/pci/hda/cs35l56_hda_i2c.c @@ -21,6 +21,10 @@ static int cs35l56_hda_i2c_probe(struct i2c_client *clt) return -ENOMEM; cs35l56->base.dev = &clt->dev; + +#ifdef CS35L56_WAKE_HOLD_TIME_US + cs35l56->base.can_hibernate = true; +#endif cs35l56->base.regmap = devm_regmap_init_i2c(clt, &cs35l56_regmap_i2c); if (IS_ERR(cs35l56->base.regmap)) { ret = PTR_ERR(cs35l56->base.regmap); -- 2.30.2

1 0

[PATCH 0/4] ASoC: makes CPU/Codec channel connection map more generic
by Kuninori Morimoto 11 Oct '23

11 Oct '23

Hi Mark Cc Bard, Pierre-Louis Current ASoC is supporting CPU/Codec = N:M (N < M) connection by using ch_map idea. This patch expand that all connection uses this idea, and no limit of N < M [1]. This patch is tested on Audio-Graph-Card2 with sample dtsi, but needs Tested-by, at least from Intel. Link: https://lore.kernel.org/r/87fs6wuszr.wl-kuninori.morimoto.gx@renesas.com [1] Kuninori Morimoto (4): ASoC: makes CPU/Codec channel connection map more generic ASoC: audio-graph-card2: add CPU:Codec = N:M support ASoC: audio-graph-card2-custom-sample: add CPU/Codec = N:M sample dt-bindings: audio-graph-port: ch_maps property .../bindings/sound/audio-graph-port.yaml | 2 + include/sound/soc.h | 48 +++++- .../audio-graph-card2-custom-sample.dtsi | 138 +++++++++++++++--- sound/soc/generic/audio-graph-card2.c | 29 ++++ sound/soc/intel/boards/sof_sdw.c | 14 +- sound/soc/soc-core.c | 83 +++++++++++ sound/soc/soc-dapm.c | 47 +++--- sound/soc/soc-pcm.c | 73 ++++----- 8 files changed, 343 insertions(+), 91 deletions(-) -- 2.25.1

3 8

[PATCH v2 0/4] ASoC: makes CPU/Codec channel connection map more generic
by Kuninori Morimoto 11 Oct '23

11 Oct '23

Hi Mark Cc Bard, Pierre-Louis This is v2 patch-set. Current ASoC is supporting CPU/Codec = N:M (N < M) connection by using ch_map idea. This patch-set expands it that all connection uses this idea, and no longer N < M limit [1]. Link: https://lore.kernel.org/r/87fs6wuszr.wl-kuninori.morimoto.gx@renesas.com [1] This patch is tested on Audio-Graph-Card2 with sample dtsi, but needs Tested-by, at least from Intel. v1 -> v2 - makes CPU/Codec connection relation clear on comment/sample - fixup type "connction" -> "connection" - makes error message clear Kuninori Morimoto (4): ASoC: makes CPU/Codec channel connection map more generic ASoC: audio-graph-card2: add CPU:Codec = N:M support ASoC: audio-graph-card2-custom-sample: add CPU/Codec = N:M sample dt-bindings: audio-graph-port: ch_maps property .../bindings/sound/audio-graph-port.yaml | 2 + include/sound/soc.h | 66 ++++++++- .../audio-graph-card2-custom-sample.dtsi | 138 +++++++++++++++--- sound/soc/generic/audio-graph-card2.c | 29 ++++ sound/soc/intel/boards/sof_sdw.c | 14 +- sound/soc/soc-core.c | 85 +++++++++++ sound/soc/soc-dapm.c | 47 +++--- sound/soc/soc-pcm.c | 73 ++++----- 8 files changed, 363 insertions(+), 91 deletions(-) -- 2.25.1

2 5

[PATCH] ASoC: apple: mca: Annotate struct mca_data with __counted_by
by Kees Cook 11 Oct '23

11 Oct '23

Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct mca_data. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted… Cc: "Martin Povišer" <povik+lin(a)cutebit.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: asahi(a)lists.linux.dev Cc: alsa-devel(a)alsa-project.org Signed-off-by: Kees Cook <keescook(a)chromium.org> --- sound/soc/apple/mca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c index ce77934f3eef..99e547ef95e6 100644 --- a/sound/soc/apple/mca.c +++ b/sound/soc/apple/mca.c @@ -161,7 +161,7 @@ struct mca_data { struct mutex port_mutex; int nclusters; - struct mca_cluster clusters[]; + struct mca_cluster clusters[] __counted_by(nclusters); }; static void mca_modify(struct mca_cluster *cl, int regoffset, u32 mask, u32 val) -- 2.34.1

3 7

Realtek ALC 4080 on MSI MPG B650 Carbon WiFi
by GitHub issues - edited 11 Oct '23

11 Oct '23

alsa-project/alsa-ucm-conf issue #359 was edited from TeamFahQ: I have Realtek ALC 4080 on an MSI MPG B650 Carbon WiFi and the chip is not getting recognized. I havve seen similar post with this exact issue on similar motherboards and the fix is to change the usb id. Unfortunately, I'm not sure which is the usb id I need `Bus 001 Device 003: ID 0db0:70d3 Micro Star International USB Audio Bus 002 Device 003: ID 0bda:0411 Realtek Semiconductor Corp. Hub Bus 001 Device 004: ID 0bda:5411 Realtek Semiconductor Corp. RTS5411 Hub` Assumably, it would be the first one I listed, but being this is a Realtek device, could it be either of the other 2? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/359 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Realtek ALC 4080 on MSI MPG B650 Carbon WiFi
by GitHub issues - edited 11 Oct '23

11 Oct '23

alsa-project/alsa-ucm-conf issue #359 was edited from TeamFahQ: I have Realtek ALC 4080 on an MSI MPG B650 Carbon WiFi and the chip is not getting recognized. I havve seen similar post with this exact issue on similar motherboards and the fix is to change the usb id. Unfortunately, I'm not sure which is the usb id I need `Bus 001 Device 003: ID 0db0:70d3 Micro Star International USB Audio` `Bus 002 Device 003: ID 0bda:0411 Realtek Semiconductor Corp. Hub` `Bus 001 Device 004: ID 0bda:5411 Realtek Semiconductor Corp. RTS5411 Hub` Assumably, it would be the first one I listed, but being this is a Realtek device, could it be either of the other 2? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/359 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Realtek ALC 4080 on MSI MPG B650 Carbon WiFi
by GitHub issues - opened 11 Oct '23

11 Oct '23

alsa-project/alsa-ucm-conf issue #359 was opened from TeamFahQ: I have Realtek ALC 4080 on an MSI MPG B650 Carbon WiFi and the chip is not getting recognized. I havve seen similar post with this exact issue on similar motherboards and the fix is to change the usb id. Unfortunately, I'm not sure which is the usb id I need `Bus 001 Device 003: ID 0db0:70d3 Micro Star International USB Audio Bus 002 Device 003: ID 0bda:0411 Realtek Semiconductor Corp. Hub Bus 001 Device 004: ID 0bda:5411 Realtek Semiconductor Corp. RTS5411 Hub` Assumably, it would be the first one I listed, but being this is a Realtek device, could it be either of the other 2? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/359 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] hda/realtek: Add SND_PCI_QUIRK entry for the Dell XPS 9530 laptop for dual speakers
by Brett Worth 11 Oct '23

11 Oct '23

The Dell XPS 9530, like previous XPS laptops like the 9520 and 9510 have dual speakers in each channel. If the ALC289_FIXUP_DUAL_SPK flag is not set in sound/pci/hda/patch_realtek.c only the tweeter will work and therefore make the sound quality terrible. This patch has not been tested but is derived from a previous patch attempt from a different user called Pentracillin which was rejected. $ diff -r -up a b diff -r -up a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c --- a/sound/pci/hda/patch_realtek.c 2023-10-07 22:16:36.129618972 +1100 +++ b/sound/pci/hda/patch_realtek.c 2023-10-07 22:16:52.645258218 +1100 @@ -9412,6 +9412,7 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x0b37, "Dell Inspiron 16 Plus 7620 2-in-1", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), + SND_PCI_QUIRK(0x1028, 0x0beb, "Dell XPS 15 9530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x0c03, "Dell Precision 5340", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0c19, "Dell Precision 3340", ALC236_FIXUP_DELL_DUAL_CODECS), SND_PCI_QUIRK(0x1028, 0x0c1a, "Dell Precision 3340", ALC236_FIXUP_DELL_DUAL_CODECS), I don't have much confidence that this patch request will meet the requirements. Brett

2 3