January 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH] pcm_rate: fix hw_ptr boundary wrapping issue
by Alan Young 16 Feb '23

16 Feb '23

Wrap the hw_ptr using the total position of the slave hw_ptr, including boundary wraps. Otherwise, small errors can creep in due to residuals (when boundary is not a multiple of period size) and which can accumulate. Signed-off-by: Alan Young <consult.awy(a)gmail.com> Fixes: 7570e5d7 ("pcm: rate: fix the hw_ptr update until the boundary available") --- src/pcm/pcm_rate.c | 54 ++++++++++++++++++++++++++++++---------------- 1 file changed, 36 insertions(+), 18 deletions(-) diff --git a/src/pcm/pcm_rate.c b/src/pcm/pcm_rate.c index c8076859..a29fc5a9 100644 --- a/src/pcm/pcm_rate.c +++ b/src/pcm/pcm_rate.c @@ -52,6 +52,7 @@ struct _snd_pcm_rate { snd_pcm_generic_t gen; snd_pcm_uframes_t appl_ptr, hw_ptr, last_slave_hw_ptr; snd_pcm_uframes_t last_commit_ptr; + u_int64_t slave_hw_ptr_wrap; snd_pcm_uframes_t orig_avail_min; snd_pcm_sw_params_t sw_params; snd_pcm_format_t sformat; @@ -562,6 +563,8 @@ static int snd_pcm_rate_init(snd_pcm_t *pcm) if (rate->ops.reset) rate->ops.reset(rate->obj); rate->last_commit_ptr = 0; + rate->last_slave_hw_ptr = 0; + rate->slave_hw_ptr_wrap = 0; rate->start_pending = 0; return 0; } @@ -638,33 +641,48 @@ snd_pcm_rate_read_areas1(snd_pcm_t *pcm, static inline void snd_pcm_rate_sync_hwptr0(snd_pcm_t *pcm, snd_pcm_uframes_t slave_hw_ptr) { snd_pcm_rate_t *rate; - snd_pcm_sframes_t slave_hw_ptr_diff; - snd_pcm_sframes_t last_slave_hw_ptr_frac; + snd_pcm_uframes_t new_hw_ptr; + snd_pcm_uframes_t slave_residual; if (pcm->stream != SND_PCM_STREAM_PLAYBACK) return; rate = pcm->private_data; - slave_hw_ptr_diff = pcm_frame_diff(slave_hw_ptr, rate->last_slave_hw_ptr, rate->gen.slave->boundary); - if (slave_hw_ptr_diff == 0) + if (slave_hw_ptr == rate->last_slave_hw_ptr) return; - last_slave_hw_ptr_frac = rate->last_slave_hw_ptr % rate->gen.slave->period_size; - /* While handling fraction part fo slave period, rounded value will be - * introduced by input_frames(). - * To eliminate rounding issue on rate->hw_ptr, subtract last rounded - * value from rate->hw_ptr and add new rounded value of present - * slave_hw_ptr fraction part to rate->hw_ptr. Hence, - * rate->hw_ptr += [ (no. of updated slave periods * pcm rate period size) - - * fractional part of last_slave_hw_ptr rounded value + - * fractional part of updated slave hw ptr's rounded value ] + + /* + * Our hw_ptr may wrap at a different time to that of the slave as the + * number of period / boundary may differ. It is essential that our hw_ptr + * wraps at the correct point, along with our appl_ptr. Otherwise the + * avail calculation will be incorrect. + * + * Track the number of slave hw_ptr boundary wraps and use that to calculate + * our new_hw_ptr from the total number of samples converted. */ - rate->hw_ptr += ( - (((last_slave_hw_ptr_frac + slave_hw_ptr_diff) / rate->gen.slave->period_size) * pcm->period_size) - - rate->ops.input_frames(rate->obj, last_slave_hw_ptr_frac) + - rate->ops.input_frames(rate->obj, (last_slave_hw_ptr_frac + slave_hw_ptr_diff) % rate->gen.slave->period_size)); + if (slave_hw_ptr < rate->last_slave_hw_ptr) { + rate->slave_hw_ptr_wrap += rate->gen.slave->boundary; + } rate->last_slave_hw_ptr = slave_hw_ptr; - rate->hw_ptr %= pcm->boundary; + /* + * Calculate rate->hw_ptr using total number of frames consumed by slave hw_ptr, + * including any boundary wraps. + */ + if (rate->slave_hw_ptr_wrap) { + /* + * Restrict explicit 64-bit calculations to case where rate->slave_hw_ptr_wrap + * is non-zero, which will only happen in 32-bit environments. + */ + u_int64_t wrapped_slave_hw_ptr = slave_hw_ptr + rate->slave_hw_ptr_wrap; + new_hw_ptr = ((wrapped_slave_hw_ptr / rate->gen.slave->period_size) * pcm->period_size) % pcm->boundary; + slave_residual = wrapped_slave_hw_ptr % rate->gen.slave->period_size; + } else { + new_hw_ptr = (slave_hw_ptr / rate->gen.slave->period_size) * pcm->period_size; + slave_residual = slave_hw_ptr % rate->gen.slave->period_size; + } + new_hw_ptr += rate->ops.input_frames(rate->obj, slave_residual); + rate->hw_ptr = new_hw_ptr % pcm->boundary; } static inline void snd_pcm_rate_sync_hwptr(snd_pcm_t *pcm) -- 2.25.1

2 3

[PATCH v4 00/10] Add the PowerQUICC audio support using the QMC
by Herve Codina 16 Feb '23

16 Feb '23

Hi, This series adds support for audio using the QMC controller available in some Freescale PowerQUICC SoCs. This series contains three parts in order to show the different blocks hierarchy and their usage in this support. The first one is related to TSA (Time Slot Assigner). The TSA handles the data present at the pin level (TDM with up to 64 time slots) and dispatchs them to one or more serial controller (SCC). The second is related to QMC (QUICC Multichannel Controller). The QMC handles the data at the serial controller (SCC) level and splits again the data to creates some virtual channels. The last one is related to the audio component (QMC audio). It is the glue between the QMC controller and the ASoC component. It handles one or more QMC virtual channels and creates one DAI per QMC virtual channels handled. Compared to the previous iteration https://lore.kernel.org/linux-kernel/20230113103759.327698-1-herve.codina@b… this v4 series mainly: - updates code comment format (feedback received on v2 series and forgot to update in v3), - fixes bindings, - Replaces the fsl,tsa phandle and the fsl,tsa-cell-id property by a fsl,tsa-serial phandle and update the TSA related API, - Adds some missing lock in tsa_serial_connect() and tsa_serial_disconnect(). Best regards, Herve Codina Changes v3 -> v4 - patches 2, 6 and 9 Update code comment format. - patch 1 Fix some description formats. Add 'additionalProperties: false' in subnode. Move fsl,mode to fsl,diagnostic-mode. Change clocks and clock-names properties. Add '#serial-cells' property related to the newly introduced fsl,tsa-serial phandle. - patch 2 Move fsl,mode to fsl,diagnostic-mode. Replace the fsl,tsa phandle and the fsl,tsa-cell-id property by a fsl,tsa-serial phandle and update the related API. Add missing locks. - patch 5 Fix some description format. Replace the fsl,tsa phandle and the fsl,tsa-cell-id property by a fsl,tsa-serial phandle. Rename fsl,mode to fsl,operational-mode and update its description. - patch 6 Replace the fsl,tsa phandle and the fsl,tsa-cell-id property by a fsl,tsa-serial phandle and use the TSA updated API. Rename fsl,mode to fsl,operational-mode. - patch 8 Add 'Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org>' Changes v2 -> v3 - All bindings Rename fsl-tsa.h to fsl,tsa.h Add missing vendor prefix Various fixes (quotes, node names, upper/lower case) - patches 1 and 2 (TSA binding specific) Remove 'reserved' values in the routing tables Remove fsl,grant-mode Add a better description for 'fsl,common-rxtx-pins' Fix clocks/clocks-name handling against fsl,common-rxtx-pins Add information related to the delays unit Removed FSL_CPM_TSA_NBCELL Fix license in binding header file fsl,tsa.h - patches 5 and 6 (QMC binding specific) Remove fsl,cpm-command property Add interrupt property constraint - patches 8 and 9 (QMC audio binding specific) Remove 'items' in compatible property definition Add missing 'dai-common.yaml' reference Fix the qmc_chan phandle definition - patch 2 and 6 Use io{read,write}be{32,16} Change commit subjects and logs - patch 4 Add 'Acked-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' Changes v1 -> v2: - patch 2 and 6 Fix kernel test robot errors - other patches No changes Herve Codina (10): dt-bindings: soc: fsl: cpm_qe: Add TSA controller soc: fsl: cpm1: Add support for TSA MAINTAINERS: add the Freescale TSA controller entry powerpc/8xx: Use a larger CPM1 command check mask dt-bindings: soc: fsl: cpm_qe: Add QMC controller soc: fsl: cmp1: Add support for QMC MAINTAINERS: add the Freescale QMC controller entry dt-bindings: sound: Add support for QMC audio ASoC: fsl: Add support for QMC audio MAINTAINERS: add the Freescale QMC audio entry .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 167 ++ .../bindings/soc/fsl/cpm_qe/fsl,tsa.yaml | 261 +++ .../bindings/sound/fsl,qmc-audio.yaml | 117 ++ MAINTAINERS | 25 + arch/powerpc/platforms/8xx/cpm1.c | 2 +- drivers/soc/fsl/qe/Kconfig | 23 + drivers/soc/fsl/qe/Makefile | 2 + drivers/soc/fsl/qe/qmc.c | 1533 +++++++++++++++++ drivers/soc/fsl/qe/tsa.c | 864 ++++++++++ drivers/soc/fsl/qe/tsa.h | 42 + include/dt-bindings/soc/fsl,tsa.h | 13 + include/soc/fsl/qe/qmc.h | 71 + sound/soc/fsl/Kconfig | 9 + sound/soc/fsl/Makefile | 2 + sound/soc/fsl/fsl_qmc_audio.c | 735 ++++++++ 15 files changed, 3865 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.yaml create mode 100644 Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml create mode 100644 drivers/soc/fsl/qe/qmc.c create mode 100644 drivers/soc/fsl/qe/tsa.c create mode 100644 drivers/soc/fsl/qe/tsa.h create mode 100644 include/dt-bindings/soc/fsl,tsa.h create mode 100644 include/soc/fsl/qe/qmc.h create mode 100644 sound/soc/fsl/fsl_qmc_audio.c -- 2.39.0

6 22

[PATCH 00/35] Documentation: correct lots of spelling errors (series 1)
by Randy Dunlap 14 Feb '23

14 Feb '23

Correct many spelling errors in Documentation/ as reported by codespell. Maintainers of specific kernel subsystems are only Cc-ed on their respective patches, not the entire series. [if all goes well] These patches are based on linux-next-20230125. [PATCH 01/35] Documentation: arm64: correct spelling [PATCH 02/35] Documentation: arm: correct spelling [PATCH 03/35] Documentation: block: correct spelling [PATCH 04/35] Documentation: bpf: correct spelling [PATCH 05/35] Documentation: core-api: correct spelling [PATCH 06/35] Documentation: fault-injection: correct spelling [PATCH 07/35] Documentation: fb: correct spelling [PATCH 08/35] Documentation: features: correct spelling [PATCH 09/35] Documentation: firmware-guide/acpi: correct spelling [PATCH 10/35] Documentation: hid: correct spelling [PATCH 11/35] Documentation: i2c: correct spelling [PATCH 12/35] Documentation: input: correct spelling [PATCH 13/35] Documentation: isdn: correct spelling [PATCH 14/35] Documentation: leds: correct spelling [PATCH 15/35] Documentation: litmus-tests: correct spelling [PATCH 16/35] Documentation: livepatch: correct spelling [PATCH 17/35] Documentation: locking: correct spelling [PATCH 18/35] Documentation: mm: correct spelling [PATCH 19/35] Documentation: openrisc: correct spelling [PATCH 20/35] Documentation: PCI: correct spelling [PATCH 21/35] Documentation: powerpc: correct spelling [PATCH 22/35] Documentation: power: correct spelling [PATCH 23/35] Documentation: s390: correct spelling [PATCH 24/35] Documentation: scheduler: correct spelling [PATCH 25/35] Documentation: security: correct spelling [PATCH 26/35] Documentation: sound: correct spelling [PATCH 27/35] Documentation: spi: correct spelling [PATCH 28/35] Documentation: target: correct spelling [PATCH 29/35] Documentation: timers: correct spelling [PATCH 30/35] Documentation: tools/rtla: correct spelling [PATCH 31/35] Documentation: trace: correct spelling [PATCH 32/35] Documentation: usb: correct spelling [PATCH 33/35] Documentation: w1: correct spelling [PATCH 34/35] Documentation: x86: correct spelling [PATCH 35/35] Documentation: xtensa: correct spelling Documentation/PCI/endpoint/pci-vntb-howto.rst | 2 - Documentation/PCI/msi-howto.rst | 2 - Documentation/arm/arm.rst | 2 - Documentation/arm/ixp4xx.rst | 4 +- Documentation/arm/keystone/knav-qmss.rst | 2 - Documentation/arm/stm32/stm32-dma-mdma-chaining.rst | 6 +-- Documentation/arm/sunxi/clocks.rst | 2 - Documentation/arm/swp_emulation.rst | 2 - Documentation/arm/tcm.rst | 2 - Documentation/arm/vlocks.rst | 2 - Documentation/arm64/booting.rst | 2 - Documentation/arm64/elf_hwcaps.rst | 2 - Documentation/arm64/sve.rst | 4 +- Documentation/block/data-integrity.rst | 2 - Documentation/bpf/libbpf/libbpf_naming_convention.rst | 6 +-- Documentation/bpf/map_xskmap.rst | 2 - Documentation/bpf/ringbuf.rst | 4 +- Documentation/bpf/verifier.rst | 2 - Documentation/core-api/packing.rst | 2 - Documentation/core-api/padata.rst | 2 - Documentation/fault-injection/fault-injection.rst | 2 - Documentation/fb/sm712fb.rst | 2 - Documentation/fb/sstfb.rst | 2 - Documentation/features/core/thread-info-in-task/arch-support.txt | 2 - Documentation/firmware-guide/acpi/acpi-lid.rst | 2 - Documentation/firmware-guide/acpi/namespace.rst | 2 - Documentation/hid/hid-alps.rst | 2 - Documentation/hid/hid-bpf.rst | 2 - Documentation/hid/hiddev.rst | 2 - Documentation/hid/hidraw.rst | 2 - Documentation/hid/intel-ish-hid.rst | 2 - Documentation/i2c/gpio-fault-injection.rst | 2 - Documentation/i2c/smbus-protocol.rst | 2 - Documentation/input/devices/iforce-protocol.rst | 2 - Documentation/input/multi-touch-protocol.rst | 2 - Documentation/isdn/interface_capi.rst | 2 - Documentation/isdn/m_isdn.rst | 2 - Documentation/leds/leds-qcom-lpg.rst | 4 +- Documentation/litmus-tests/README | 2 - Documentation/livepatch/reliable-stacktrace.rst | 2 - Documentation/locking/lockdep-design.rst | 4 +- Documentation/locking/locktorture.rst | 2 - Documentation/locking/locktypes.rst | 2 - Documentation/locking/preempt-locking.rst | 2 - Documentation/mm/hmm.rst | 4 +- Documentation/mm/hwpoison.rst | 2 - Documentation/openrisc/openrisc_port.rst | 4 +- Documentation/power/suspend-and-interrupts.rst | 2 - Documentation/powerpc/kasan.txt | 2 - Documentation/powerpc/papr_hcalls.rst | 2 - Documentation/powerpc/qe_firmware.rst | 4 +- Documentation/powerpc/vas-api.rst | 4 +- Documentation/s390/pci.rst | 4 +- Documentation/s390/vfio-ccw.rst | 2 - Documentation/scheduler/sched-bwc.rst | 2 - Documentation/scheduler/sched-energy.rst | 4 +- Documentation/security/digsig.rst | 4 +- Documentation/security/keys/core.rst | 2 - Documentation/security/secrets/coco.rst | 2 - Documentation/sound/alsa-configuration.rst | 8 ++-- Documentation/sound/cards/audigy-mixer.rst | 2 - Documentation/sound/cards/maya44.rst | 2 - Documentation/sound/cards/sb-live-mixer.rst | 2 - Documentation/sound/designs/jack-controls.rst | 2 - Documentation/sound/designs/seq-oss.rst | 2 - Documentation/sound/hd-audio/notes.rst | 2 - Documentation/spi/pxa2xx.rst | 12 +++--- Documentation/spi/spi-lm70llp.rst | 2 - Documentation/spi/spi-summary.rst | 2 - Documentation/target/tcmu-design.rst | 2 - Documentation/timers/hrtimers.rst | 2 - Documentation/tools/rtla/rtla-timerlat-top.rst | 2 - Documentation/trace/coresight/coresight-etm4x-reference.rst | 2 - Documentation/trace/events.rst | 6 +-- Documentation/trace/fprobe.rst | 2 - Documentation/trace/ftrace-uses.rst | 2 - Documentation/trace/hwlat_detector.rst | 2 - Documentation/trace/rv/runtime-verification.rst | 2 - Documentation/trace/uprobetracer.rst | 2 - Documentation/usb/chipidea.rst | 19 +++++----- Documentation/usb/gadget-testing.rst | 2 - Documentation/usb/mass-storage.rst | 2 - Documentation/w1/w1-netlink.rst | 2 - Documentation/x86/boot.rst | 2 - Documentation/x86/buslock.rst | 2 - Documentation/x86/mds.rst | 2 - Documentation/x86/resctrl.rst | 2 - Documentation/x86/sgx.rst | 2 - Documentation/xtensa/atomctl.rst | 2 - 89 files changed, 124 insertions(+), 123 deletions(-) Cc: Jonathan Corbet <corbet(a)lwn.net> Cc: Catalin Marinas <catalin.marinas(a)arm.com> Cc: Will Deacon <will(a)kernel.org> Cc: Russell King <linux(a)armlinux.org.uk> Cc: Jens Axboe <axboe(a)kernel.dk> Cc: Andrii Nakryiko <andrii(a)kernel.org> Cc: Alexei Starovoitov <ast(a)kernel.org> Cc: Daniel Borkmann <daniel(a)iogearbox.net> Cc: Vladimir Oltean <olteanv(a)gmail.com> Cc: Steffen Klassert <steffen.klassert(a)secunet.com> Cc: Daniel Jordan <daniel.m.jordan(a)oracle.com> Cc: Akinobu Mita <akinobu.mita(a)gmail.com> Cc: Helge Deller <deller(a)gmx.de> Cc: "Rafael J. Wysocki" <rafael(a)kernel.org> Cc: Jiri Kosina <jikos(a)kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires(a)redhat.com> Cc: Srinivas Pandruvada <srinivas.pandruvada(a)linux.intel.com> Cc: Wolfram Sang <wsa(a)kernel.org> Cc: Dmitry Torokhov <dmitry.torokhov(a)gmail.com> Cc: Henrik Rydberg <rydberg(a)bitmath.org> Cc: Karsten Keil <isdn(a)linux-pingi.de> Cc: Pavel Machek <pavel(a)ucw.cz> Cc: Lee Jones <lee(a)kernel.org> Cc: Josh Poimboeuf <jpoimboe(a)kernel.org> Cc: Miroslav Benes <mbenes(a)suse.cz> Cc: Petr Mladek <pmladek(a)suse.com> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Jérôme Glisse <jglisse(a)redhat.com> Cc: Naoya Horiguchi <naoya.horiguchi(a)nec.com> Cc: Miaohe Lin <linmiaohe(a)huawei.com> Cc: Jonas Bonn <jonas(a)southpole.se> Cc: Stefan Kristiansson <stefan.kristiansson(a)saunalahti.fi> Cc: Stafford Horne <shorne(a)gmail.com> Cc: Bjorn Helgaas <bhelgaas(a)google.com> Cc: Lorenzo Pieralisi <lpieralisi(a)kernel.org> Cc: Marc Zyngier <maz(a)kernel.org> Cc: Michael Ellerman <mpe(a)ellerman.id.au> Cc: Len Brown <len.brown(a)intel.com> Cc: Heiko Carstens <hca(a)linux.ibm.com> Cc: Vasily Gorbik <gor(a)linux.ibm.com> Cc: Alexander Gordeev <agordeev(a)linux.ibm.com> Cc: Juri Lelli <juri.lelli(a)redhat.com> Cc: Vincent Guittot <vincent.guittot(a)linaro.org> Cc: David Howells <dhowells(a)redhat.com> Cc: Jarkko Sakkinen <jarkko(a)kernel.org> Cc: Paul Moore <paul(a)paul-moore.com> Cc: James Morris <jmorris(a)namei.org> Cc: "Serge E. Hallyn" <serge(a)hallyn.com> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: "Martin K. Petersen" <martin.petersen(a)oracle.com> Cc: Daniel Bristot de Oliveira <bristot(a)kernel.org> Cc: Steven Rostedt <rostedt(a)goodmis.org> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Masami Hiramatsu <mhiramat(a)kernel.org> Cc: Mathieu Poirier <mathieu.poirier(a)linaro.org> Cc: Suzuki K Poulose <suzuki.poulose(a)arm.com> Cc: Evgeniy Polyakov <zbr(a)ioremap.net> Cc: Fenghua Yu <fenghua.yu(a)intel.com> Cc: Reinette Chatre <reinette.chatre(a)intel.com> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Borislav Petkov <bp(a)alien8.de> Cc: Chris Zankel <chris(a)zankel.net> Cc: Max Filippov <jcmvbkbc(a)gmail.com> Cc: alsa-devel(a)alsa-project.org Cc: coresight(a)lists.linaro.org Cc: bpf(a)vger.kernel.org Cc: dri-devel(a)lists.freedesktop.org Cc: isdn4linux(a)listserv.isdn4linux.de Cc: keyrings(a)vger.kernel.org Cc: linux-acpi(a)vger.kernel.org Cc: linux-block(a)vger.kernel.org Cc: linux-crypto(a)vger.kernel.org Cc: linux-doc(a)vger.kernel.org Cc: linux-fbdev(a)vger.kernel.org Cc: linux-i2c(a)vger.kernel.org Cc: linux-input(a)vger.kernel.org Cc: linux-leds(a)vger.kernel.org Cc: linux-pci(a)vger.kernel.org Cc: linux-s390(a)vger.kernel.org Cc: linux-scsi(a)vger.kernel.org Cc: linux-sgx(a)vger.kernel.org Cc: linux-spi(a)vger.kernel.org Cc: linux-trace-devel(a)vger.kernel.org Cc: linux-trace-kernel(a)vger.kernel.org Cc: live-patching(a)vger.kernel.org Cc: linux-pm(a)vger.kernel.org Cc: linux-security-module(a)vger.kernel.org Cc: linux-usb(a)vger.kernel.org Cc: netdev(a)vger.kernel.org Cc: target-devel(a)vger.kernel.org Cc: linux-mm(a)kvack.org Cc: openrisc(a)lists.librecores.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-xtensa(a)linux-xtensa.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: x86(a)kernel.org

6 6

remove arch/sh
by Christoph Hellwig 13 Feb '23

13 Feb '23

18 96

No sound on HDMI by default on Lenovo T14s using Fedora 37
by Mike FABIAN 11 Feb '23

11 Feb '23

With a Lenovo Thinkpad T14s (Gen1, Intel version), I tried to get sound on the monitor speakers via the HDMI cable. It didn’t work out of the box and after a bit of googling I found: https://forums.lenovo.com/t5/ThinkPad-T400-T500-and-newer-T-series-Laptops/… which suggested to put snd_rn_pci_acp3x.dmic_acpi_check=0 on the kernel command line. So I tried this: $ cat /etc/modprobe.d/lenovot14s.conf options snd-rn-pci-acp3x dmic_acpi_check=0 And that did make it work indeed. I have no idea what this means and why this makes it work. -- Mike FABIAN <mfabian(a)redhat.com> 睡眠不足はいい仕事の敵だ。

2 10

[PATCH] ASoC: da7219: Fix pole orientation detection on OMTP headsets when playing music
by David Rau 09 Feb '23

09 Feb '23

The OMTP pin define headsets can be mis-detected as line out instead of OMTP, causing obvious issues with audio quality. This patch is to put increased resistances within the device at a suitable point. To solve this issue better, the new mechanism setup ground switches with conditional delay control and these allow for more stabile detection process to operate as intended. This conditional delay control will not impact the hardware process but use extra system resource. This commit improves control of ground switches in the AAD logic. Signed-off-by: David Rau <david.rau.zg(a)renesas.com> --- sound/soc/codecs/da7219-aad.c | 42 ++++++++++++++++++++++++++++++----- sound/soc/codecs/da7219-aad.h | 1 + 2 files changed, 37 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c index bba73c44c219..08200ec259f9 100644 --- a/sound/soc/codecs/da7219-aad.c +++ b/sound/soc/codecs/da7219-aad.c @@ -352,9 +352,14 @@ static irqreturn_t da7219_aad_irq_thread(int irq, void *data) struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component); struct da7219_priv *da7219 = snd_soc_component_get_drvdata(component); u8 events[DA7219_AAD_IRQ_REG_MAX]; - u8 statusa; + u8 statusa, srm_st; int i, report = 0, mask = 0; + srm_st = snd_soc_component_read(component, DA7219_PLL_SRM_STS) & DA7219_PLL_SRM_STS_MCLK; + msleep(da7219_aad->gnd_switch_delay * ((srm_st == 0x0) ? 2 : 1) - 4); + /* Enable ground switch */ + snd_soc_component_update_bits(component, 0xFB, 0x01, 0x01); + /* Read current IRQ events */ regmap_bulk_read(da7219->regmap, DA7219_ACCDET_IRQ_EVENT_A, events, DA7219_AAD_IRQ_REG_MAX); @@ -454,8 +459,8 @@ static irqreturn_t da7219_aad_irq_thread(int irq, void *data) snd_soc_dapm_disable_pin(dapm, "Mic Bias"); snd_soc_dapm_sync(dapm); - /* Enable ground switch */ - snd_soc_component_update_bits(component, 0xFB, 0x01, 0x01); + /* Disable ground switch */ + snd_soc_component_update_bits(component, 0xFB, 0x01, 0x00); } } @@ -831,6 +836,32 @@ static void da7219_aad_handle_pdata(struct snd_soc_component *component) } } +static void da7219_aad_handle_gnd_switch_time(struct snd_soc_component *component) +{ + struct da7219_priv *da7219 = snd_soc_component_get_drvdata(component); + struct da7219_aad_priv *da7219_aad = da7219->aad; + u8 jack_det; + + jack_det = snd_soc_component_read(component, DA7219_ACCDET_CONFIG_2) + & DA7219_JACK_DETECT_RATE_MASK; + switch (jack_det) { + case 0x00: + da7219_aad->gnd_switch_delay = 32; + break; + case 0x10: + da7219_aad->gnd_switch_delay = 64; + break; + case 0x20: + da7219_aad->gnd_switch_delay = 128; + break; + case 0x30: + da7219_aad->gnd_switch_delay = 256; + break; + default: + da7219_aad->gnd_switch_delay = 32; + break; + } +} /* * Suspend/Resume @@ -908,9 +939,6 @@ int da7219_aad_init(struct snd_soc_component *component) snd_soc_component_update_bits(component, DA7219_ACCDET_CONFIG_1, DA7219_BUTTON_CONFIG_MASK, 0); - /* Enable ground switch */ - snd_soc_component_update_bits(component, 0xFB, 0x01, 0x01); - INIT_WORK(&da7219_aad->btn_det_work, da7219_aad_btn_det_work); INIT_WORK(&da7219_aad->hptest_work, da7219_aad_hptest_work); @@ -928,6 +956,8 @@ int da7219_aad_init(struct snd_soc_component *component) regmap_bulk_write(da7219->regmap, DA7219_ACCDET_IRQ_MASK_A, &mask, DA7219_AAD_IRQ_REG_MAX); + da7219_aad_handle_gnd_switch_time(component); + return 0; } EXPORT_SYMBOL_GPL(da7219_aad_init); diff --git a/sound/soc/codecs/da7219-aad.h b/sound/soc/codecs/da7219-aad.h index f48a12012ef3..21fdf53095cc 100644 --- a/sound/soc/codecs/da7219-aad.h +++ b/sound/soc/codecs/da7219-aad.h @@ -187,6 +187,7 @@ enum da7219_aad_event_regs { struct da7219_aad_priv { struct snd_soc_component *component; int irq; + int gnd_switch_delay; u8 micbias_pulse_lvl; u32 micbias_pulse_time; -- 2.17.1

4 21

Re: Firewire Phase24 Motu help
by Takashi Sakamoto 07 Feb '23

07 Feb '23

Hi, (C.C.ed to administrator of alsa-devel mailing list) On Mon, Jan 30, 2023 at 12:40:06PM +0100, M. Armsby wrote: > Hi Takashi, > I'm writing direct because I cannot seem to get a post on AlsaDevel > list. I've realized your two posts, but no reaction since they have no message body: * Firewire ALSA Motu and Phase24 * https://lore.kernel.org/alsa-devel/sokos1-r6xj933yn42y-hmy3gsrfgsma-mnwe9a-… * Firewire Motu ALSA (Re-post) * https://lore.kernel.org/alsa-devel/v6inx6-fwmr0r-kvajcd-kfs8u9l6m2qn2cnogd-… Jaroslav, would I ask your opinion for the problem which perhaps dropped the message body from his messages? > I need to repair my two Phase X24 (defekt caps?) and I'm having > problems with Traveler and other Motu interfaces on Linux. > Thanks for any hints or where I should post. > Here's a copy of my post: > Hello everyone! > Thank you for all the hard work on this. > Especially Mr. Takashi Sakamoto. > I'm an experienced studio engineer and was a Beta tester for Samplitude > for years. > Not a programmer and have very little experience with Linux. > So please excuse me blundering in on this professional programmer forum > but I'm hoping my experience will help somehow to find bugs. I'll > provide any information I can or test following instructions. > I really would love to completely change over to Linux but I need > reliable drivers. > How can I help? > Here's my experience so far. > Around November I started testing Linux for audio as I have > occasionally over the last years. I was pleased to find Manjaro and > Sparky would detect Traveler Mk1 and Mk3 and to run so efficiently > compared to Win10. > But things would freeze. > Reaper has a long standing Midi bug so it was difficult at first to see > why my laptop would freeze on occasion. I dissabled hardware midi in > the software. > Then I updated Sparky beginning of December and to my surprise Firewire > didn't work anymore. The Firewire stack must have been removed. > I use: > Dell Laptops 4310, 6510, M4800 > Tested platforms Ardour and Reaper using Pianoteq 8 > No JACK > Manjaro Kernel from 6.0 rc4? and 6.1.1 work for a limited time. > Sparky only works with special kernels Xanmod1 6.1.7-x64v2 but the > audio is completely distorted. > CachyOS Kernel 6.2 rc4 sounds good. > Common problem is freezing or loosing audio. Ardour is less sensitive > than Reaper but Reaper is far more efficient on CPU > (20% compared to 90%and more with one instance of Pianoteq 7 or 8) > Motu Traveler MK3 and MK1 wrong channel assignment from 1+2 (3+4 are > actually 1+2) and freezing or just loosing audio. > Motu 896Mk3 Hybrid not recognised in firewire or USB mode. > Shame cause its the best. > Motu 8pre working similarly. > Phase 24 working much better but still freezes or looses audio after > long period. > Tested in Ardour and Reaper. > I hope that's not too much at once. > Martin Armsby > M. Armsby Thanks for the report including many issues. I apologize to trouble you. In my opinion, the issues are not so easy since each application uses ALSA PCM device by slightly different ways. So we need to investigate the issue step by step to take relevant longer time than easy issues. Before discussing about the issue, I need to ask a help about MOTU devices. As you realized, 896 mk3 is neither supported yet, FireWire only nor Hybrid, in IEEE 1394 bus nor Universal Serial Bus. For example, you can see no entry for the device in module device table[1] in the file which consists of snd-firewire-motu driver. The reason is apparent; no one provides information enough to support it. Then I would like you to help me to integrate for it in the case in IEEE 1394 bus. I maintain a remote repository for my collection of configuration ROM image which includes identity information of each node in IEEE 1394 bus[2]. The information is useful both to make the entry of module device table and to make hardware database[3] in systemd project. When 896 mk3 Hybrid is connected to IEEE 1394 bus and only connected to the bus, Linux FireWire subsystem detects it as '/dev/fw1'. Then the rom image is exported to an node on sysfs. You can retrieve the content by the command line below: $ cat /sys/bus/firewire/devices/fw1/config_rom > motu-896mk3hybrid.img If retrieved successfully, please send it to me. I don't mind to receive it to private message, mailing list, any upload services. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sou… [2] https://github.com/takaswie/am-config-roms [3] https://github.com/systemd/systemd/blob/main/hwdb.d/80-ieee1394-unit-functi… Thanks Takashi Sakamoto

3 4

[PATCH 00/19] Add soundwire support for Pink Sardine platform
by Vijendar Mukunda 06 Feb '23

06 Feb '23

Pink Sardine(ps) platform is based on ACP6.3 Architecture. ACP6.3 IP has two soundwire controller instance support. This patchset add support for Soundwire controller on Pink Sardine platform. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> Vijendar Mukunda (19): ASoC: amd: ps: create platform devices based on acp config soundwire: amd: Add support for AMD Master driver soundwire: amd: register sdw controller dai ops soundwire: amd: enable build for AMD soundwire master driver soundwire: amd: add soundwire interrupt handling ASoC: amd: ps: add support for soundwire interrupts in acp pci driver ASoC: amd: ps: add soundwire dma driver for pink sardine platform ASoC: amd: ps: add soundwire dma driver dma ops ASoC: amd: ps: add support for Soundwire DMA interrupts ASoC: amd: ps: enable Soundwire DMA driver build ASoC: amd: update comments in Kconfig file ASoC: amd: ps: Add soundwire specific checks in pci driver in pm ops. ASoC: amd: ps: add support for runtime pm ops for soundwire dma driver soundwire: amd: add runtime pm ops for AMD master driver soundwire: amd: add startup and shutdown dai ops soundwire: amd: handle wake enable interrupt soundwire: amd: add pm_prepare callback and pm ops support ASoC: amd: ps: implement system level pm ops for soundwire dma driver ASoC: amd: ps: increase runtime suspend delay drivers/soundwire/Kconfig | 9 + drivers/soundwire/Makefile | 4 + drivers/soundwire/amd_master.c | 1734 +++++++++++++++++++++++++++++ drivers/soundwire/amd_master.h | 284 +++++ include/linux/soundwire/sdw_amd.h | 65 ++ sound/soc/amd/Kconfig | 3 +- sound/soc/amd/ps/Makefile | 2 + sound/soc/amd/ps/acp63.h | 98 +- sound/soc/amd/ps/pci-ps.c | 383 ++++++- sound/soc/amd/ps/ps-sdw-dma.c | 728 ++++++++++++ 10 files changed, 3287 insertions(+), 23 deletions(-) create mode 100644 drivers/soundwire/amd_master.c create mode 100644 drivers/soundwire/amd_master.h create mode 100644 include/linux/soundwire/sdw_amd.h create mode 100644 sound/soc/amd/ps/ps-sdw-dma.c -- 2.34.1

8 90

[PATCH][next] ASoC: uapi: Replace zero-length arrays with __DECLARE_FLEX_ARRAY() helper
by Gustavo A. R. Silva 03 Feb '23

03 Feb '23

Zero-length arrays are deprecated and we are moving towards adopting C99 flexible-array members, instead. So, replace zero-length arrays declarations in anonymous union with the new __DECLARE_FLEX_ARRAY() helper macro. This helper allows for flexible-array members in unions. Link: https://github.com/KSPP/linux/issues/193 Link: https://github.com/KSPP/linux/issues/227 Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html Signed-off-by: Gustavo A. R. Silva <gustavoars(a)kernel.org> --- include/uapi/sound/asoc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h index 053949287ce8..dd8ad790fc15 100644 --- a/include/uapi/sound/asoc.h +++ b/include/uapi/sound/asoc.h @@ -226,9 +226,9 @@ struct snd_soc_tplg_vendor_array { __le32 type; /* SND_SOC_TPLG_TUPLE_TYPE_ */ __le32 num_elems; /* number of elements in array */ union { - struct snd_soc_tplg_vendor_uuid_elem uuid[0]; - struct snd_soc_tplg_vendor_value_elem value[0]; - struct snd_soc_tplg_vendor_string_elem string[0]; + __DECLARE_FLEX_ARRAY(struct snd_soc_tplg_vendor_uuid_elem, uuid); + __DECLARE_FLEX_ARRAY(struct snd_soc_tplg_vendor_value_elem, value); + __DECLARE_FLEX_ARRAY(struct snd_soc_tplg_vendor_string_elem, string); }; } __attribute__((packed)); -- 2.34.1

5 11

Is there any way to install alsa-lib with the suid bit set?
by Stefan Alexe 03 Feb '23

03 Feb '23

I am trying to only use a static /dev. I have opened an issue about this on GitHub and got it to work only as the root user. This resembles my experience with xorg. In that case I had to use the suid use flag. Is there an equivalent in this situation?

2 1