June 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH v2 0/2] Read _SUB from ACPI to be able to identify firmware
by Stefan Binding 27 Jun '22

27 Jun '22

CS35L41 has a DSP which is able to run firmware, as well as a tuning file. Different systems may want to use different firmwares and tuning files, and some firmwares/tunings may not be compatible with other systems. To allow a system to select the correct fimware/tuning, we can read an _SUB from the ACPI. This _SUB can then be used to uniquely identify the system in the firmware/tuning file name. Add a helper function which reads the _SUB, so this can be used by other parts in the future. Add support inside the CS35L41 ASoC driver to read this _SUB, and save it appropriately. Changes since v1: - Add length validation for SSID String - Rename API - Allocate memory inside API - Use ACPI_HANDLE macro instead of ACPI_COMPANION - Improve error handling Stefan Binding (2): ACPI: utils: Add api to read _SUB from ACPI ASoC: cs35l41: Read System Name from ACPI _SUB to identify firmware drivers/acpi/utils.c | 38 ++++++++++++++++++++++++++++++++++++++ include/linux/acpi.h | 6 ++++++ sound/soc/codecs/cs35l41.c | 24 ++++++++++++++++++++++++ 3 files changed, 68 insertions(+) -- 2.25.1

2 3

Pandora audio using machine_is_omap3_pandora() check
by Tony Lindgren 27 Jun '22

27 Jun '22

Hi Grazvydas, Arnd noticed that pandora audio is using machine_is_omap3_pandora() check that never succeeds for devicetree booting machines. Looks like this has been broken at some point many years ago with the devicetree conversion. Does anybody have an interest in fixing this driver? Regards, Tony

2 2

[PATCH 0/5] seq: code change for cell helper functionalities
by GitHub pull_request - opened 27 Jun '22

27 Jun '22

alsa-project/alsa-gobject pull request #80 was opened from takaswie: In design of ALSA Sequencer, cell is a unit to deliver events. This patchset adds code change for helper functionalities. ``` Takashi Sakamoto (5): event: add public API to compute pool consumption when scheduling event client-pool: change signedness for size properties user-client/client-pool: update function comments about event scheduling all: replace 'represent' with 'express' in comments ci: separate libudev-dev installation from the other .github/workflows/build.yml | 3 +- doc/ctl/overview.md | 2 +- doc/rawmidi/overview.md | 2 +- doc/seq/overview.md | 6 +-- doc/timer/overview.md | 2 +- src/ctl/card-info.c | 2 +- src/ctl/card.c | 6 +-- src/ctl/elem-id.c | 4 +- src/hwdep/device-info.c | 4 +- src/rawmidi/stream-pair.c | 6 +-- src/rawmidi/substream-info.c | 4 +- src/rawmidi/substream-params.c | 4 +- src/rawmidi/substream-status.c | 4 +- src/seq/addr.c | 4 +- src/seq/alsaseq.map | 1 + src/seq/client-info.c | 4 +- src/seq/client-pool.c | 91 ++++++++++++++++++---------------- src/seq/event-data-connect.c | 4 +- src/seq/event-data-ctl.c | 4 +- src/seq/event-data-note.c | 4 +- src/seq/event-data-queue.c | 4 +- src/seq/event-data-result.c | 4 +- src/seq/event.c | 16 ++++++ src/seq/event.h | 2 + src/seq/port-info.c | 4 +- src/seq/queue-info.c | 4 +- src/seq/queue-status.c | 4 +- src/seq/queue-tempo.c | 4 +- src/seq/remove-filter.c | 4 +- src/seq/subscribe-data.c | 4 +- src/seq/system-info.c | 4 +- src/seq/user-client.c | 16 ++++-- src/timer/device-id.c | 4 +- src/timer/device-info.c | 4 +- src/timer/device-params.c | 4 +- src/timer/device-status.c | 4 +- src/timer/instance-info.c | 4 +- src/timer/instance-params.c | 4 +- src/timer/instance-status.c | 2 +- src/timer/user-instance.c | 6 +-- tests/alsaseq-event | 1 + 41 files changed, 148 insertions(+), 116 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/80 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/80.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH v5 0/2] Add pinctrl support adsp bypass platforms
by Srinivasa Rao Mandadapu 27 Jun '22

27 Jun '22

This patch set is to make clock voting optinal for adsp bypass sc7280 platforms. Changes Since V4: -- Fix the improper device node variable usage. -- Optimize the code by removing redundant private variant data structure variable "is_clk_optional". Changes Since V3: -- Revert compatible type change in dt bindings. -- Update boolean flag description in dt bindings. -- Drop redundant clock optional flag initialization. -- Remove redundant if check. Changes Since V2: -- Remove redundant lpi pincontrol variant data structure and compatible entry. -- Add adsp bypass mode boolean param check. -- Remove compatible name in dt bindings. -- Update dt binding bypass mode boolean param. Changes Since V1: -- Update commit message. Srinivasa Rao Mandadapu (2): dt-bindings: pinctrl: qcom: sc7280: Add boolean param for ADSP bypass platforms pinctrl: qcom: sc7280: Add clock optional check for ADSP bypass targets .../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 5 +++++ drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 +- drivers/pinctrl/qcom/pinctrl-lpass-lpi.h | 1 - drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 1 - 4 files changed, 6 insertions(+), 3 deletions(-) -- 2.7.4

1 2

[PATCH 0/2] Update machine driver for audioreach solution
by Srinivasa Rao Mandadapu 27 Jun '22

27 Jun '22

This patch set is to update sc7280 machine driver for audioreach support. Srinivasa Rao Mandadapu (2): ASoC: google: dt-bindings: Update sc7280-audioreach-herobrine compatible name ASoC: qcom: Add driver support for audioreach solution .../bindings/sound/google,sc7280-herobrine.yaml | 1 + sound/soc/qcom/sc7280.c | 34 ++++++++++++++++++++++ 2 files changed, 35 insertions(+) -- 2.7.4

2 4

[PATCH v8 0/8] ASoC: mediatek: Add support for MT8186 SoC
by Jiaxin Yu 27 Jun '22

27 Jun '22

This series of patches adds support for Mediatek AFE of MT8186 Soc. Patches are based on broonie tree "for-next" branch. Changes since v7: - Optimize the code logic, such as the return value and position of a function. - Use devm_pm_runtime_enable() instead of pm_runtime_enable(). - Use pm_runtime_resume_and_get() instead of pm_runtime_get_sync(). Changes since v6: - The Makefile and Kconfig updates are moved into the driver patches so that can keep independence of each patch. Changes since v5: - fix build error about function snd_soc_card_jack_new that modified by: Link: https://lore.kernel.org/r/20220408041114.6024-1-akihiko.odaki@gmail.com - some have been accepted, details are in the link below: Link: https://lore.kernel.org/all/165459931885.399031.2621579592368573898.b4-ty@k… Changes since v4: - [v5 07/20] - remove unsusd controls - [v5 09/20] - correct indent error - [v5 10/20] - [v5 13/20] - [v5 14/20] - fix the return value if the value is different from the previous value in mixer controls - [v5 17/20] - [v5 19/20] - correct the compatible name with '_' instead of '-' - [v5 18/20] - [v5 20/20] - correct the yaml after 'pip3 install dtschema --upgrade' Changes since v3: - [v4 09/18] - remove DEBUG_COEFF debugging code - [v4 10/18] - simplify the logic of the code - [v4 13/18] - split out the MT6366 bits into mt8186-mt6366-commom.c - fix build error of "error: 'struct dev_pm_info' has no member named 'runtime_error'" - fix bug of adda dai driver - add route for pcm interface channel 2. - [v4 15/18] - [v4 17/18] - commonize the configuration of the codec - move MT6366 common bits into mt8186-mt6366-common.c Changes since v2: - add a new compatible string "mediatek,mt6366-sound" - modify the log level for simplicity - use dev_err_probe(...) instead of dev_err(...) in dev probe() - optimized the logic of some code - use BIT() and GENMASK() macros to descript the registers Thanks for AngeloGioacchino's careful reviews. Changes since v1: [v2 01/17] - add a new ID to the existing mt6358 codec driver [v2 03/17] - modify log level in DAPM events - use standard numeric control with name ending in Switch - return 1 when the value changed in mixer control's .get callback [v2 05/17] - ending in Switch to the standard on/off controls - change to "HW Gain 1 Volume" and "HW Gain 2 Volume" [v2 09/17] - return an error in the default case rather than just picking one of the behaviours when do .set_fmt - use the new defines that are _PROVIDER_MASK, _DAIFMT_CBP_CFP and _DAIFMT_CBC_CFC [v2 10/17] [v2 11/17] - the clock and gpio are aplit out into separate patches The source file's GPL comment use c++ style, and the header fils's GPL comment use c style. We have added "Switch" after the names of all the controls that just are simple on/off. Jiaxin Yu (8): dt-bindings: mediatek: mt6358: add new compatible for using mt6366 ASoC: mediatek: mt8186: add platform driver ASoC: mediatek: mt8186: add mt8186-mt6366 common driver dt-bindings: mediatek: mt8186: add audio afe document ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357 dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682s dt-bindings: mediatek: mt8186: add mt8186-mt6366-rt1019-rt5682s document .../devicetree/bindings/sound/mt6358.txt | 4 +- .../bindings/sound/mt8186-afe-pcm.yaml | 175 + .../sound/mt8186-mt6366-da7219-max98357.yaml | 75 + .../sound/mt8186-mt6366-rt1019-rt5682s.yaml | 75 + sound/soc/mediatek/Kconfig | 44 + sound/soc/mediatek/Makefile | 1 + sound/soc/mediatek/mt8186/Makefile | 22 + sound/soc/mediatek/mt8186/mt8186-afe-common.h | 235 ++ .../soc/mediatek/mt8186/mt8186-afe-control.c | 255 ++ sound/soc/mediatek/mt8186/mt8186-afe-pcm.c | 3011 +++++++++++++++++ .../mediatek/mt8186/mt8186-mt6366-common.c | 57 + .../mediatek/mt8186/mt8186-mt6366-common.h | 17 + .../mt8186/mt8186-mt6366-da7219-max98357.c | 1002 ++++++ .../mt8186/mt8186-mt6366-rt1019-rt5682s.c | 978 ++++++ 14 files changed, 5950 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/sound/mt8186-afe-pcm.yaml create mode 100644 Documentation/devicetree/bindings/sound/mt8186-mt6366-da7219-max98357.yaml create mode 100644 Documentation/devicetree/bindings/sound/mt8186-mt6366-rt1019-rt5682s.yaml create mode 100644 sound/soc/mediatek/mt8186/Makefile create mode 100644 sound/soc/mediatek/mt8186/mt8186-afe-common.h create mode 100644 sound/soc/mediatek/mt8186/mt8186-afe-control.c create mode 100644 sound/soc/mediatek/mt8186/mt8186-afe-pcm.c create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-common.c create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-common.h create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c -- 2.18.0

2 10

attach/detach by mixer class implementation of alsa-lib mixer API
by Takashi Sakamoto 27 Jun '22

27 Jun '22

Hi Jaroslav, Recent years I'm bothered about unexpected abort of pulseaudio and pipewire processes when testing user-defined control element set. They aborts at element removal event. ``` pulseaudio: mixer.c:149: hctl_elem_event_handler: Assertion `bag_empty(bag)' failed. wireplumber: mixer.c:149: hctl_elem_event_handler: Assertion `bag_empty(bag)' failed. ``` Would I ask your opinion about the design of alsa-lib mixer API? As long as I investigate, these programs seem to have careless coding as alsa-lib mixer API application. Both of them attaches an instance of snd_mixer_elem_t to an instance of snd_hctl_elem_t by calling snd_mixer_elem_attach() when detecting element addition, but never detach it even if detecting element removal. In the case, the link list (=bag) of mixer API internal never becomes empty. It has link entries as much as the number of registered mixer classes which attaches snd_mixer_elem_t. Then it hits the assertion. I think the design of alsa-lib mixer API demands mixer class implementation to detach at element removal which attached at element addition. But I have less conviction about it since enough unfamiliar. I'm glad if receiving your opinion about it. I wrote test program for the issued behaviour: - https://gist.github.com/takaswie/8378fe3bc04652d83428694cd7573bc0 For test, please use sample script in alsa-gobject project: - https://github.com/alsa-project/alsa-gobject/blob/master/samples/ctl The patches for pulseaudio/pipewire are prepared: - https://gitlab.freedesktop.org/takaswie/pulseaudio/-/commit/topic/fix-wrong… - https://gitlab.freedesktop.org/takaswie/pipewire/-/commits/topic/fix-wrong-… Regards Takashi Sakamoto

2 2

mixer: add documentation about postcondition of removal event processing
by GitHub pull_request - opened 27 Jun '22

27 Jun '22

alsa-project/alsa-lib pull request #244 was opened from takaswie: PulseAudio and PipeWire seems to appear including careless code to process events of mixer element in implementation of mixer class. * https://lore.kernel.org/alsa-devel/YrbxZ2b+3rIdi7Ut@workstation/ They register own implementation of mixer class. At addition event, they attach own mixer element into hcontrol element. However at removal event, they never detach the mixer element from hcontrol element. They hit assertion in mixer API internal due to unsatisfied postcondition. This commit adds documentation about postcondition of removal event processing so that developer for implementation of mixer class easily realize the way to satisfy the postcondition. Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> Request URL : https://github.com/alsa-project/alsa-lib/pull/244 Patch URL : https://github.com/alsa-project/alsa-lib/pull/244.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v3 0/2] [PATCH v4 0/2] Add pinctrl support adsp bypass platforms
by Srinivasa Rao Mandadapu 26 Jun '22

26 Jun '22

This patch set is to make clock voting optinal for adsp bypass sc7280 platforms. Changes Since V3: -- Revert compatible type change in dt bindings. -- Update boolean flag description in dt bindings. -- Drop redundant clock optional flag initialization. -- Remove redundant if check. Changes Since V2: -- Remove redundant lpi pincontrol variant data structure and compatible entry. -- Add adsp bypass mode boolean param check. -- Remove compatible name in dt bindings. -- Update dt binding bypass mode boolean param. Changes Since V1: -- Update commit message. Srinivasa Rao Mandadapu (2): dt-bindings: pinctrl: qcom: sc7280: Add boolean param for ADSP bypass platforms pinctrl: qcom: sc7280: Add clock optional check for ADSP bypass targets .../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 5 +++++ drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 ++ drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 1 - 3 files changed, 7 insertions(+), 1 deletion(-) -- 2.7.4

4 6

Questions about driver implementation (1 I2S controller to 2 codecs)
by Paul Cercueil 25 Jun '22

25 Jun '22

Hi, I'm trying to add support for a new board that uses the Ingenic JZ4770 SoC. This SoC has a I2S/AC97 controller, and has an internal codec. The controller has a register switch to select either the internal codec, or an external codec; both cannot be enabled at the same time. On this board, the external speakers / audio line are wired to the internal codec, while a HDMI chip (ITE66121) is wired as the external codec. I'm having a hard time trying to figure out how the codec selection switch should be exported. Should it be a regular widget, and the user is responsible for selecting the right codec? Should it be a DAPM, and plugging the HDMI cable auto-enables the switch? Is this configuration (one controller to two codecs) already somehow supported by ALSA? Right now we're using a "simple-audio-card" in the device tree, and trying to add HDMI sound support. I am not even sure if we should be using one sound card with the two codecs, or one sound card per codec, sharing the same I2S controller? Any thoughts? Thanks, -Paul

2 1