December 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH V8 0/5] ASoC: codecs: Add Awinic AW883XX audio amplifier driver
by wangweidong.a＠awinic.com 06 Jan '23

06 Jan '23

From: Weidong Wang <wangweidong.a(a)awinic.com> The Awinic AW883XX is an I2S/TDM input, high efficiency digital Smart K audio amplifier with an integrated 10.25V smart boost convert Add a DT schema for describing Awinic AW883xx audio amplifiers. They are controlled using I2C v7 -> v8: Delete retry for double loops Enable PA Delete useless initialization and use reverse x-mas tree style Add Spaces in comments Modify aw883xx_switch_set function Delete our own workqueue, use a default one Change variable name Modifying function name Use dev_ replace pr_ function Use define replace number Modify the compatible of the awinic,aw883xx.yaml file Weidong Wang (5): ASoC: codecs: Add i2c and codec registration for aw883xx and their associated operation functions ASoC: codecs: Aw883xx function for ACF file parse and check ASoC: codecs: Aw883xx common function for ALSA Audio Driver ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile ASoC: dt-bindings: Add schema for "awinic,aw883xx" .../bindings/sound/awinic,aw883xx.yaml | 49 + sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 6 + sound/soc/codecs/aw883xx/aw883xx.c | 667 ++++++ sound/soc/codecs/aw883xx/aw883xx.h | 59 + sound/soc/codecs/aw883xx/aw883xx_bin_parse.c | 1067 ++++++++++ sound/soc/codecs/aw883xx/aw883xx_bin_parse.h | 92 + sound/soc/codecs/aw883xx/aw883xx_data_type.h | 143 ++ sound/soc/codecs/aw883xx/aw883xx_device.c | 1790 +++++++++++++++++ sound/soc/codecs/aw883xx/aw883xx_device.h | 198 ++ .../soc/codecs/aw883xx/aw883xx_pid_2049_reg.h | 384 ++++ 11 files changed, 4465 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml create mode 100644 sound/soc/codecs/aw883xx/aw883xx.c create mode 100644 sound/soc/codecs/aw883xx/aw883xx.h create mode 100644 sound/soc/codecs/aw883xx/aw883xx_bin_parse.c create mode 100644 sound/soc/codecs/aw883xx/aw883xx_bin_parse.h create mode 100644 sound/soc/codecs/aw883xx/aw883xx_data_type.h create mode 100644 sound/soc/codecs/aw883xx/aw883xx_device.c create mode 100644 sound/soc/codecs/aw883xx/aw883xx_device.h create mode 100644 sound/soc/codecs/aw883xx/aw883xx_pid_2049_reg.h base-commit: bff687b3dad6e0e56b27f4d3ed8a9695f35c7b1a -- 2.38.1

8 14

[regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
by Thorsten Leemhuis 04 Jan '23

04 Jan '23

Hi, this is your Linux kernel regression tracker speaking. I noticed a regression report in bugzilla.kernel.org. As many (most?) kernel developer don't keep an eye on it, I decided to forward it by mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 : > Sergey 2022-12-29 10:07:51 UTC > > Created attachment 303497 [details] > pulseaudio.log > > Sudden sound disappearance was reported for some laptops, e.g. > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz > > # lspci > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20) > Subsystem: Acer Incorporated [ALI] Device 148c > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12 > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K] > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M] > Capabilities: [50] Power Management version 3 > Capabilities: [80] Vendor Specific Information: Len=14 <?> > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ > Kernel driver in use: sof-audio-pci > > I am attaching the pulseaudio and dmesg logs > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157 > > Bisection revealed the commit being reverted: > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee > Author: Richard Fitzgerald <rf(a)opensource.cirrus.com> > Date: Fri Nov 4 13:22:13 2022 +0000 > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open() > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ] > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot() > and used by later code that depends on the TDM settings. So > __soc_pcm_open() should not be obliterating those mask values. > > [...] > Original bug report: https://bugzilla.altlinux.org/44690 See the ticket for more details. BTW, let me use this mail to also add the report to the list of tracked regressions to ensure it's doesn't fall through the cracks: #regzbot introduced: c34db0d6b88b1d https://bugzilla.kernel.org/show_bug.cgi?id=216861 #regzbot title: sound: asoc: sudden sound disappearance #regzbot ignore-activity Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.

6 9

[PATCH v2 0/3] drm: Add component_match_add_of and convert users of drm_of_component_match_add
by Sean Anderson 03 Jan '23

03 Jan '23

This series adds a new function component_match_add_of to simplify the common case of calling component_match_add_release with component_release_of and component_compare_of. There is already drm_of_component_match_add, which allows for a custom compare function. However, all existing users just use component_compare_of (or an equivalent). Changes in v2: - Split off conversion from helper addition - Rebased onto drm/drm-next Sean Anderson (3): component: Add helper for device nodes iommu/sound: Use component_match_add_of helper drm: Convert users of drm_of_component_match_add to component_match_add_of .../gpu/drm/arm/display/komeda/komeda_drv.c | 6 ++-- drivers/gpu/drm/arm/hdlcd_drv.c | 9 +----- drivers/gpu/drm/arm/malidp_drv.c | 11 +------ drivers/gpu/drm/armada/armada_drv.c | 10 ++++--- drivers/gpu/drm/drm_of.c | 29 +++---------------- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +-- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 3 +- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 3 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +-- drivers/gpu/drm/msm/msm_drv.c | 14 ++++----- drivers/gpu/drm/sti/sti_drv.c | 3 +- drivers/gpu/drm/sun4i/sun4i_drv.c | 3 +- drivers/gpu/drm/tilcdc/tilcdc_external.c | 10 ++----- drivers/iommu/mtk_iommu.c | 3 +- drivers/iommu/mtk_iommu_v1.c | 3 +- include/drm/drm_of.h | 12 -------- include/linux/component.h | 9 ++++++ sound/soc/codecs/wcd938x.c | 6 ++-- 18 files changed, 46 insertions(+), 96 deletions(-) -- 2.35.1.1320.gc452695387.dirty

3 5

Turn on power early to avoid something
by Kailang 03 Jan '23

03 Jan '23

Hi Takashi, It maybe can avoid something for early power up. Many Thanks. Kailang.

2 6

[PATCH v4 00/13] ASoC: mediatek: Add support for MT8188 SoC
by Trevor Wu 03 Jan '23

03 Jan '23

This series of patches adds support for Mediatek AFE of MT8188 SoC. Patches are based on broonie tree "for-next" branch. Changes since v3: - replace apll_ck with apll to sync with the relationship in CCF - add mtk-soundcard-driver.c to support codec parsing - drop mclk-always-on-rates support in mt8188-dai-etdm.c - refine dt-binding files based on reviewer's suggestions Changes since v2: - drop CLK_IGNORE_UNUSED flag - include bitfield.h to reslove the issue reported by kernel test robot - rename mt8188-afe-pcm.yaml to mt8188-afe.yaml - refine dt-binding files based on reviewer's suggestions Changes since v1: - remove bus protection functions in case of unmerged dependency problem - replace some bit operation macro with FIELD_PREP - simplify register control by regmap_set_bits and regmap_clear_bits - fix dt-binding errors - rename compatible string for recognition Trevor Wu (13): ASoC: mediatek: common: add SMC ops and SMC CMD ASoC: mediatek: mt8188: add common header ASoC: mediatek: mt8188: support audsys clock ASoC: mediatek: mt8188: support adda in platform driver ASoC: mediatek: mt8188: support etdm in platform driver ASoC: mediatek: mt8188: support pcmif in platform driver ASoC: mediatek: mt8188: support audio clock control ASoC: mediatek: mt8188: add platform driver ASoC: mediatek: mt8188: add control for timing select dt-bindings: mediatek: mt8188: add audio afe document ASoC: mediatek: common: add soundcard driver common code ASoC: mediatek: mt8188: add machine driver with mt6359 dt-bindings: mediatek: mt8188: add mt8188-mt6359 document .../bindings/sound/mediatek,mt8188-afe.yaml | 208 + .../sound/mediatek,mt8188-mt6359.yaml | 93 + sound/soc/mediatek/Kconfig | 23 + sound/soc/mediatek/Makefile | 1 + sound/soc/mediatek/common/Makefile | 2 +- sound/soc/mediatek/common/mtk-base-afe.h | 19 + .../mediatek/common/mtk-soundcard-driver.c | 79 + .../mediatek/common/mtk-soundcard-driver.h | 14 + sound/soc/mediatek/mt8188/Makefile | 15 + sound/soc/mediatek/mt8188/mt8188-afe-clk.c | 658 ++++ sound/soc/mediatek/mt8188/mt8188-afe-clk.h | 115 + sound/soc/mediatek/mt8188/mt8188-afe-common.h | 151 + sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 3359 +++++++++++++++++ sound/soc/mediatek/mt8188/mt8188-audsys-clk.c | 205 + sound/soc/mediatek/mt8188/mt8188-audsys-clk.h | 15 + .../soc/mediatek/mt8188/mt8188-audsys-clkid.h | 83 + sound/soc/mediatek/mt8188/mt8188-dai-adda.c | 632 ++++ sound/soc/mediatek/mt8188/mt8188-dai-etdm.c | 2591 +++++++++++++ sound/soc/mediatek/mt8188/mt8188-dai-pcm.c | 367 ++ sound/soc/mediatek/mt8188/mt8188-mt6359.c | 785 ++++ sound/soc/mediatek/mt8188/mt8188-reg.h | 3180 ++++++++++++++++ 21 files changed, 12594 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8188-afe.yaml create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml create mode 100644 sound/soc/mediatek/common/mtk-soundcard-driver.c create mode 100644 sound/soc/mediatek/common/mtk-soundcard-driver.h create mode 100644 sound/soc/mediatek/mt8188/Makefile create mode 100644 sound/soc/mediatek/mt8188/mt8188-afe-clk.c create mode 100644 sound/soc/mediatek/mt8188/mt8188-afe-clk.h create mode 100644 sound/soc/mediatek/mt8188/mt8188-afe-common.h create mode 100644 sound/soc/mediatek/mt8188/mt8188-afe-pcm.c create mode 100644 sound/soc/mediatek/mt8188/mt8188-audsys-clk.c create mode 100644 sound/soc/mediatek/mt8188/mt8188-audsys-clk.h create mode 100644 sound/soc/mediatek/mt8188/mt8188-audsys-clkid.h create mode 100644 sound/soc/mediatek/mt8188/mt8188-dai-adda.c create mode 100644 sound/soc/mediatek/mt8188/mt8188-dai-etdm.c create mode 100644 sound/soc/mediatek/mt8188/mt8188-dai-pcm.c create mode 100644 sound/soc/mediatek/mt8188/mt8188-mt6359.c create mode 100644 sound/soc/mediatek/mt8188/mt8188-reg.h -- 2.18.0

4 19

[PATCH 0/6] ASoC: samsung: fsd: audio support for FSD SoC
by Padmanabhan Rajanbabu 02 Jan '23

02 Jan '23

The intention of this patch series is to enable audio support on FSD SoC. The following features are added in samsung I2S interface: 1. Add TDM support on samsung I2S interface 2. Allow sound card to directly configure prescaler divider instead of calculating it from frame clock Also the sound card support for FSD SoC is added, which utilizes samsung I2S interface as CPU DAI. This patch is dependent on fsd-pinctrl fixes patch series [1] [1]: https://lkml.org/lkml/2022/10/13/257 Padmanabhan Rajanbabu (6): ASoC: samsung: i2s: TDM Support for CPU DAI driver ASoC: samsung: i2s: configure PSR from sound card dt-bindings: sound: Add sound card bindings for Tesla FSD ASoC: samsung: fsd: Add FSD soundcard driver arm64: dts: fsd: Add I2S DAI node for Tesla FSD arm64: dts: fsd: Add sound card node for Tesla FSD .../bindings/sound/tesla,fsd-card.yaml | 158 ++++++++ arch/arm64/boot/dts/tesla/fsd-evb.dts | 57 +++ arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 14 + arch/arm64/boot/dts/tesla/fsd.dtsi | 41 ++ sound/soc/samsung/Kconfig | 12 + sound/soc/samsung/Makefile | 2 + sound/soc/samsung/fsd-card.c | 349 ++++++++++++++++++ sound/soc/samsung/i2s-regs.h | 17 + sound/soc/samsung/i2s.c | 120 +++++- sound/soc/samsung/i2s.h | 1 + 10 files changed, 766 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/tesla,fsd-card.yaml create mode 100644 sound/soc/samsung/fsd-card.c -- 2.17.1

5 32

[PATCH v4 0/7] kselftest/alsa: pcm-test improvements
by Mark Brown 02 Jan '23

02 Jan '23

This series provides a bunch of quick updates which should make the coverage from pcm-test a bit more useful, it adds some support for skipping tests when the hardware/driver is unable to support the requested configuration, support for providing user visible descriptions and then expands the set of cases we cover to include more sample rates and channel counts. This should exercise switching between 8kHz and 44.1kHz based rates and ensure that clocking doesn't get confused by non-stereo channel counts, both of which are I expect common real world errors, at least for embedded cards. v4: - Rebase onto v6.2-rc1. v3: - "Rebase" onto Takashi's current tree (with a revert). - Include Jaroslav's changes to specify all tests in the configuration file parsing. - Add a new "description" field to the configuration instead of trying to name the tests. - Always run both default and per-system tests, logging our success at setting the per-system configurations as a separate test since they shouldn't fail. v2: - Rebase onto Takashi's current tree. - Tweak the buffer sizes for the newly added cases, don't be quite so ambitious in how big a buffer we request for 96kHz and don't go quite so small for 8kHz since some devices start hitting lower limits on period size and struggle to deliver accurate timing. To: Takashi Iwai <tiwai(a)suse.com> To: Jaroslav Kysela <perex(a)perex.cz> To: Shuah Khan <shuah(a)kernel.org> Cc: alsa-devel(a)alsa-project.org Cc: linux-kselftest(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Mark Brown <broonie(a)kernel.org> --- Jaroslav Kysela (1): kselftest/alsa: pcm - move more configuration to configuration files Mark Brown (6): kselftest/alsa: pcm - Drop recent coverage improvement changes kselftest/alsa: pcm - Always run the default set of tests kselftest/alsa: pcm - skip tests when we fail to set params kselftest/alsa: pcm - Support optional description for tests kselftest/alsa: pcm - Provide descriptions for the default tests kselftest/alsa: pcm - Add more coverage by default tools/testing/selftests/alsa/Makefile | 2 +- tools/testing/selftests/alsa/alsa-local.h | 3 + tools/testing/selftests/alsa/conf.c | 26 ++- .../alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf | 43 +++-- tools/testing/selftests/alsa/pcm-test.c | 205 ++++++++++++++------- tools/testing/selftests/alsa/pcm-test.conf | 63 +++++++ 6 files changed, 250 insertions(+), 92 deletions(-) --- base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 change-id: 20221208-alsa-pcm-test-hacks-f6c1aa76bd2c Best regards, -- Mark Brown <broonie(a)kernel.org>

2 8

Regression playing 24bit/96kHz audio on USB audio interface between 5.10.94 and 5.15.21
by Ruud van Asseldonk 02 Jan '23

02 Jan '23

Hi, I have a program that configures a Behringer UMC404HD 192k USB audio interface for playback as follows (pseudocode): snd_pcm_hw_params_set_channels(pcm, hwp, 2); snd_pcm_hw_params_set_format(pcm, hwp, SND_PCM_FORMAT_S24_3LE); snd_pcm_hw_params_set_access(pcm, hwp, SND_PCM_ACCESS_MMAP_INTERLEAVED); snd_pcm_hw_params_set_rate(pcm, hwp, val=96000, dir=0); snd_pcm_hw_params_set_period_size_near(pcm, hwp, val=513, dir=0); // If I confirm at this point with snd_pcm_hw_params_get_period_size, // I get back 513. snd_pcm_hw_params_set_buffer_size_near(pcm, hwp, val=2052); snd_pcm_hw_params(pcm, hwp); // If I confirm with snd_pcm_hw_params_get_buffer_size, // I get back 2052. On Linux 5.10.94 (specifically Arch Linux ARM package linux-rpi-5.10.94-1), this succeeds, and I can play back audio just fine. On 5.15.21 (specifically linux-rpi-5.15.21-3), all the calls succeed apart from the last one, which returns EINVAL. (My actual program is written in Rust and uses a Rust wrapper library for libasound, https://docs.rs/alsa/0.6.0/alsa/, but the calls should be the ones listed.) I confirmed with snd_pcm_hw_params_test_format that the S24_3LE format is supported. On both kernels it is successful. I confirmed with snd_pcm_hw_params_test_rate that 96 kHz is supported. On both kernels it is successful. There are differences though. When I query these: snd_pcm_hw_params_get_period_size_min snd_pcm_hw_params_get_period_size_max snd_pcm_hw_params_get_buffer_size_min snd_pcm_hw_params_get_buffer_size_max Then on 5.10.94 (the good version), I get: period size min/max: 12/32768, buffer size min/max: 24/65536 But on 5.15.21 (the bad version), I get: period size min/max: 13/71332, buffer size min/max: 26/142663 Also, after I set the period size to 513, if I then query the buffer size min/max, on 5.10.94 I get: buffer size min/max: 1026/65536 But on 5.15.21 I get: buffer size min/max: 1027/142663 In lsmod, snd_usb_audio shows up, and from lsusb -v, the UMC404HD appears to be a standard USB audio interface. The lsusb output is identical on both kernels. Please let me know if there is anything I can do to help further diagnose the issue, or if I should report this elsewhere. Kind regards, Ruud van Asseldonk

5 10

[PATCH] ASoC: qcom: lpass-cpu: Fix fallback SD line index handling
by Brian Norris 01 Jan '23

01 Jan '23

These indices should reference the ID placed within the dai_driver array, not the indices of the array itself. This fixes commit 4ff028f6c108 ("ASoC: qcom: lpass-cpu: Make I2S SD lines configurable"), which among others, broke IPQ8064 audio (sound/soc/qcom/lpass-ipq806x.c) because it uses ID 4 but we'd stop initializing the mi2s_playback_sd_mode and mi2s_capture_sd_mode arrays at ID 0. Fixes: 4ff028f6c108 ("ASoC: qcom: lpass-cpu: Make I2S SD lines configurable") Cc: <stable(a)vger.kernel.org> Signed-off-by: Brian Norris <computersforpeace(a)gmail.com> --- sound/soc/qcom/lpass-cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 54353842dc07..dbdaaa85ce48 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -1037,10 +1037,11 @@ static void of_lpass_cpu_parse_dai_data(struct device *dev, struct lpass_data *data) { struct device_node *node; - int ret, id; + int ret, i, id; /* Allow all channels by default for backwards compatibility */ - for (id = 0; id < data->variant->num_dai; id++) { + for (i = 0; i < data->variant->num_dai; i++) { + id = data->variant->dai_driver[i].id; data->mi2s_playback_sd_mode[id] = LPAIF_I2SCTL_MODE_8CH; data->mi2s_capture_sd_mode[id] = LPAIF_I2SCTL_MODE_8CH; } -- 2.39.0

3 2

Front Audio (Headphone) and Optical Not Working in Rocky Linux 9
by yakajirri - a001 31 Dec '22

31 Dec '22

With Rocky Linux 9 (clone of RHEL 9), I do not get audio of the front headphone jack or the optical output on the back. I do get audio out of the line out on the back. The front port does not work with Rocky Linux 8, Ubuntu and Fedora, and I did not test the optical. With Windows, the front jack works as expected with the realtek driver installed, and I did not test the optical on Windows. The output of /usr/sbin/alsa-info.sh is here: http://alsa-project.org/db/?f=0d71a1351cd49f220c36fe69cc9af93f1d71ee3c I built the computer with a Gigabyte Z690 AERO G motherboard that has a realtek alc4080 codec and Intel Z690 chipset. With Rocky Linux 9, without the headphones plugged in the sounds settings show: digital output (s/sdif) - usb hdmi/displayport-built-in audio when plug in headphones in the front jack “headphones - usb audio” appears and disappears when I unplug the headphones. If I use the following command, I can hear the audio clip through the headphones: aplay -D plughw:Audio,1 /usr/share/sounds/alsa/Front_Left.wav If I use the following command, I can hear the audio clip through the optical: aplay -D plughw:Audio,2 /usr/share/sounds/alsa/Front_Left.wav I’m using alsa-lib 1.2.7 from the Rocky Linux repo. I tried to compile 1.2.8 from source but when I run “./configure” I got the error: ./configure: line 2998: syntax error near unexpected token `external' ./configure: line 2998: `AM_GNU_GETTEXT(external)' I noticed https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/USB-Audio/US… has more If.realtek-alc4080 entries. When I copied the If.realtek-alc4080 section into /usr/share/alsa/ucm2/USB-Audio/USB-Audio.conf and /usr/share/alsa/ucm2/conf.d/USB-Audio/USB-Audio.conf, and after I rebooted, I get the same performance. One thing I noticed in https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/USB-Audio/US… is the only Gigabyte entry under If.realtek-alc4080 is “Gigabyte Z590 Aorus Pro AX”. I see other manufactures have Intel Z690 chipset support but not Gigabyte. I’m not sure if I’m hitting a bug or if my motherboard is not supported. Please point me in the correct direction if this isn’t an AlSA issue. I posted the Rocky Linux forum but was not able to resolve the issue. Brian

2 2