October 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH v2 0/4] hda: Minor cleanups
by Amadeusz Sławiński 07 Oct '22

07 Oct '22

First two patches are small refactoring of code to use poll macros instead of open coding register checks. Following two patches remove unused defines from code. v2: * Fix includes Amadeusz Sławiński (4): ALSA: hda: Move stream-register polling macros ALSA: hda: Rework snd_hdac_stream_reset() to use macros ALSA: hda: Remove unused MAX_PIN_CONFIGS constant ALSA: hda: Remove unused defines include/sound/hdaudio.h | 7 +++++++ include/sound/hdaudio_ext.h | 6 ------ sound/hda/hdac_stream.c | 26 ++++++-------------------- sound/pci/hda/hda_intel.c | 7 ------- sound/pci/hda/hda_sysfs.c | 2 -- 5 files changed, 13 insertions(+), 35 deletions(-) -- 2.25.1

3 14

master tree: Realtek ALC4080: "Failed to get the verb"
by GitHub issues - opened 07 Oct '22

07 Oct '22

alsa-project/alsa-ucm-conf issue #227 was opened from mavoga: Hi, wanted to test the UCM2 code in master for the onboard Realtek ALC4080 USB sound card (included in the list, 0db0:a073 MSI MAG X570S Torpedo Max); starting pulseaudio with new code causes this: ``` Oct 07 09:33:55 mybox systemd[2654]: Starting Sound Service... -- Subject: A start job for unit UNIT has begun execution -- Defined-By: systemd -- Support: https://www.debian.org/support -- -- A start job for unit UNIT has begun execution. -- -- The job identifier is 540. Oct 07 09:33:55 mybox pulseaudio[12140]: Failed to get the verb HiFi Oct 07 09:33:55 mybox pulseaudio[12140]: Failed to get the verb HiFi 5+1 Oct 07 09:33:55 mybox pulseaudio[12140]: Failed to get the verb HiFi 7+1 Oct 07 09:33:55 mybox pulseaudio[12140]: No UCM verb is valid for hw:0 Oct 07 09:33:58 mybox pulseaudio[12140]: Failed to find a working profile. [...] ``` v1.2.7.2 (without profile variants) works well. Is this expected in this development phase? Debian up-to-date testing here, libasound2 v1.2.7.2 Thank you for your precious work! Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/227 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: codecs: wsa883x: add GPIOLIB dependency
by Randy Dunlap 07 Oct '22

07 Oct '22

Fix a build error when GPIOLIB is not set/enabled: ../sound/soc/codecs/wsa883x.c: In function 'wsa883x_probe': ../sound/soc/codecs/wsa883x.c:1394:25: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration] 1394 | wsa883x->sd_n = devm_gpiod_get_optional(&pdev->dev, "powerdown", ../sound/soc/codecs/wsa883x.c:1395:49: error: 'GPIOD_FLAGS_BIT_NONEXCLUSIVE' undeclared (first use in this function) 1395 | GPIOD_FLAGS_BIT_NONEXCLUSIVE); ../sound/soc/codecs/wsa883x.c:1414:9: error: implicit declaration of function 'gpiod_direction_output'; did you mean 'gpio_direction_output'? [-Werror=implicit-function-declaration] 1414 | gpiod_direction_output(wsa883x->sd_n, 1); Fixes: 43b8c7dc85a14 ("ASoC: codecs: add wsa883x amplifier support") Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Reported-by: kernel test robot <lkp(a)intel.com> Cc: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> Cc: Banajit Goswami <bgoswami(a)quicinc.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: alsa-devel(a)alsa-project.org Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -2029,6 +2029,7 @@ config SND_SOC_WSA881X config SND_SOC_WSA883X tristate "WSA883X Codec" depends on SOUNDWIRE + depends on GPIOLIB select REGMAP_SOUNDWIRE tristate help

1 0

Add Arturia Minifuse 1 Support
by GitHub pull_request - opened 06 Oct '22

06 Oct '22

alsa-project/alsa-ucm-conf pull request #226 was opened from nodens: Arturia Minifuse 1 is a stripped-down version of Minifuse 2: - 1 Input - 2 Outputs - Loopback interface to ease recording of the computer output (attempt at fixing #220) Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/226 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/226.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Re: [PATCH 08/12] ASoC: mediatek: mt8188: add platform driver
by Trevor Wu (吳文良) 06 Oct '22

06 Oct '22

Hi maintainers, As I mentioned in the comment, this patch depends on a reviewing series. Should I remove the related code from this patch in case of the build error? Thanks, Trevor On Sat, 2022-10-01 at 17:17 +0800, kernel test robot wrote: > Hi Trevor, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on broonie-sound/for-next] > [also build test ERROR on broonie-spi/for-next tiwai-sound/for-next > linus/master v6.0-rc7 next-20220930] > [If your patch is applied to the wrong git tree, kindly drop us a > note. > And when submitting patch, we suggest to use '--base' as documented > in > https://urldefense.com/v3/__https://git-scm.com/docs/git-format-patch*_base… > ] > > url: > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commits/… > > base: > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git… > for-next > config: s390-allyesconfig > compiler: s390-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget > https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tes… > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commit/6… > > git remote add linux-review > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux__;!!CTRN… > > git fetch --no-tags linux-review Trevor-Wu/ASoC-mediatek-Add- > support-for-MT8188-SoC/20220930-230009 > git checkout 65c941d291852582ccbe6a8196ff3b60fb4d1243 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 > make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot <lkp(a)intel.com> > > All errors (new ones prefixed by >>): > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c: In function > 'bus_protect_enable': > > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2649:16: error: > > > 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1' undeclared (first use in > > > this function); did you mean > > > 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'? > > 2649 | mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1 > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2649:16: note: each > undeclared identifier is reported only once for each function it > appears in > > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2650:30: error: > > > 'MT8188_TOP_AXI_PROT_EN_2_SET' undeclared (first use in this > > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_SET'? > > 2650 | regmap_write(regmap, MT8188_TOP_AXI_PROT_EN_2_SET, > mask); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | MT8186_TOP_AXI_PROT_EN_2_SET > In file included from include/linux/regmap.h:20, > from sound/soc/mediatek/mt8188/mt8188-afe- > common.h:15, > from sound/soc/mediatek/mt8188/mt8188-afe- > pcm.c:24: > > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2652:48: error: > > > 'MT8188_TOP_AXI_PROT_EN_2_STA' undeclared (first use in this > > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_STA'? > > 2652 | ret = regmap_read_poll_timeout(regmap, > MT8188_TOP_AXI_PROT_EN_2_STA, > | ^~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~ > include/linux/iopoll.h:46:28: note: in definition of macro > 'read_poll_timeout' > 46 | (val) = op(args); \ > | ^~~~ > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2652:15: note: in > expansion of macro 'regmap_read_poll_timeout' > 2652 | ret = regmap_read_poll_timeout(regmap, > MT8188_TOP_AXI_PROT_EN_2_STA, > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2659:16: error: > > > 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2' undeclared (first use in > > > this function); did you mean > > > 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'? > > 2659 | mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1 > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c: In function > 'bus_protect_disable': > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2678:16: error: > 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2' undeclared (first use in this > function); did you mean 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'? > 2678 | mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1 > > > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2679:30: error: > > > 'MT8188_TOP_AXI_PROT_EN_2_CLR' undeclared (first use in this > > > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_CLR'? > > 2679 | regmap_write(regmap, MT8188_TOP_AXI_PROT_EN_2_CLR, > mask); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | MT8186_TOP_AXI_PROT_EN_2_CLR > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2681:48: error: > 'MT8188_TOP_AXI_PROT_EN_2_STA' undeclared (first use in this > function); did you mean 'MT8186_TOP_AXI_PROT_EN_2_STA'? > 2681 | ret = regmap_read_poll_timeout(regmap, > MT8188_TOP_AXI_PROT_EN_2_STA, > | ^~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~ > include/linux/iopoll.h:46:28: note: in definition of macro > 'read_poll_timeout' > 46 | (val) = op(args); \ > | ^~~~ > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2681:15: note: in > expansion of macro 'regmap_read_poll_timeout' > 2681 | ret = regmap_read_poll_timeout(regmap, > MT8188_TOP_AXI_PROT_EN_2_STA, > | ^~~~~~~~~~~~~~~~~~~~~~~~ > sound/soc/mediatek/mt8188/mt8188-afe-pcm.c:2688:16: error: > 'MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1' undeclared (first use in this > function); did you mean 'MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1'? > 2688 | mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | MT8186_TOP_AXI_PROT_EN_1_DIS_STEP1 > > > vim +2649 sound/soc/mediatek/mt8188/mt8188-afe-pcm.c > > 2641 > 2642 static int bus_protect_enable(struct regmap *regmap) > 2643 { > 2644 int ret; > 2645 u32 val; > 2646 u32 mask; > 2647 > 2648 val = 0; > > 2649 mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1; > > 2650 regmap_write(regmap, > > MT8188_TOP_AXI_PROT_EN_2_SET, mask); > > 2651 > > 2652 ret = regmap_read_poll_timeout(regmap, > > MT8188_TOP_AXI_PROT_EN_2_STA, > > 2653 val, (val & > mask) == mask, > 2654 MT8188_DELAY_US, > MT8188_TIMEOUT_US); > 2655 if (ret) > 2656 return ret; > 2657 > 2658 val = 0; > > 2659 mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2; > > 2660 regmap_write(regmap, > MT8188_TOP_AXI_PROT_EN_2_SET, mask); > 2661 > 2662 ret = regmap_read_poll_timeout(regmap, > MT8188_TOP_AXI_PROT_EN_2_STA, > 2663 val, (val & > mask) == mask, > 2664 MT8188_DELAY_US, > MT8188_TIMEOUT_US); > 2665 if (ret) > 2666 return ret; > 2667 > 2668 return 0; > 2669 } > 2670 > 2671 static int bus_protect_disable(struct regmap *regmap) > 2672 { > 2673 int ret; > 2674 u32 val; > 2675 u32 mask; > 2676 > 2677 val = 0; > 2678 mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2; > > 2679 regmap_write(regmap, > > MT8188_TOP_AXI_PROT_EN_2_CLR, mask); > > 2680 > 2681 ret = regmap_read_poll_timeout(regmap, > MT8188_TOP_AXI_PROT_EN_2_STA, > 2682 val, !(val & > mask), > 2683 MT8188_DELAY_US, > MT8188_TIMEOUT_US); > 2684 if (ret) > 2685 return ret; > 2686 > 2687 val = 0; > 2688 mask = MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1; > 2689 regmap_write(regmap, > MT8188_TOP_AXI_PROT_EN_2_CLR, mask); > 2690 > 2691 ret = regmap_read_poll_timeout(regmap, > MT8188_TOP_AXI_PROT_EN_2_STA, > 2692 val, !(val & > mask), > 2693 MT8188_DELAY_US, > MT8188_TIMEOUT_US); > 2694 if (ret) > 2695 return ret; > 2696 > 2697 return 0; > 2698 } > 2699 >

2 2

[PATCH 1/2] ASoC: dt-bindings: add pin-switches to audio-graph-card2.yaml
by Claudio Cabral 05 Oct '22

05 Oct '22

Document support for pin-switches in audio-graph-card2 this devicetree property behaves the same way as its homonym in simple-card Reviewed-by: Alvin Šipraga <alsi(a)bang-olufsen.dk> Signed-off-by: Alvin Šipraga <alsi(a)bang-olufsen.dk> Signed-off-by: Claudio Cabral <clca(a)bang-olufsen.dk> --- Documentation/devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml index 7416067c945e..ab2cc83d6b4b 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml @@ -32,6 +32,9 @@ properties: codec2codec: type: object description: Codec to Codec node + pin-switches: + description: the widget names for which pin switches must be created. + $ref: /schemas/types.yaml#/definitions/string-array required: - compatible -- 2.37.3

2 2

wm8962 0-001a: ASoC: error at soc_component_read_no_lock on wm8962.0-001a: -16
by Wang, Xiaolei 05 Oct '22

05 Oct '22

Hi Jaroslav When I tested the audio, I found that some registers in the codec of wm8962.c will fail to read in the mainline kernel. I found that wm8962_i2c_probe will enter runtime suspend after startup, but in the following program: snd_soc_bind_card snd_soc_dapm_new_widgets soc_dapm_read snd_soc_component_read(dapm->component, reg); There is no runtime resume, which cannot perform normal reading and writing for volatile reg, because it has been switched to regcache only in the process of runtime suspend. I can't find the right place to resume, can you give me any advice? thanks xiaolei

3 4

ALSA multi plugin error when combining two soundcards
by GitHub issues - opened 05 Oct '22

05 Oct '22

alsa-project/alsa-lib issue #273 was opened from anthonio9: My goal is to mix the output of two sound cards (RAVENNA from [bondagit](https://github.com/bondagit/aes67-linux-daemon.git) and hifiberry), then pass it to a DSP pcm plugin. As it's not possible with `dmix` (dmix only supports output to hw devices) the reasonable next step was `multi` plugin, but my tries always end up in a failure. Below is a quite standard `multi` configuration inspired by alsa docs that I'm using: ```sh pcm.quad { type multi slaves.a.pcm "hw:RAVENNA" slaves.a.channels 2 slaves.b.pcm "hw:sndrpihifiberry" slaves.b.channels 2 bindings.0.slave a bindings.0.channel 0 bindings.1.slave a bindings.1.channel 1 bindings.2.slave b bindings.2.channel 0 bindings.3.slave b bindings.3.channel 1 master 1 } pcm.quad2 { type plug slave.pcm "quad" } ``` This is run with `alsaloop` to be input into an extplug plugin that easily accepts 4 channels of audio - `alsadsp`: ```sh $ alsaloop -C quad -P alsadsp -c 4 Rate 48000Hz not available for capture quad: Invalid argument Unable to set parameters for capture quad stream: Invalid argument Loopback start failure. ``` This results in a failure, moreover running `quad2` also results in the same type of error. Next step was to try plug pcm: ```sh pcm.quad_plug { type multi slaves.a.pcm "plughw:RAVENNA" slaves.a.channels 2 slaves.b.pcm "plughw:sndrpihifiberry" slaves.b.channels 2 bindings.0.slave a bindings.0.channel 0 bindings.1.slave a bindings.1.channel 1 bindings.2.slave a bindings.2.channel 0 bindings.3.slave a bindings.3.channel 1 } pcm.quad_plug2 { type plug slave.pcm "quad_plug" } ``` With `quad_plug` the same error occurs, with `quad_plug2` the error is as below: ```sh $ alsaloop -C quad_plug2 -P alsadsp -c 4 Broken configuration for capture quad_plug2 PCM: no configurations available: Invalid argument Unable to set parameters for capture quad_plug2 stream: Invalid argument Loopback start failure. ``` Then the last thing I tried was to force the 48kHz sampling rate directly on the hardware devices with the help of the following config: ```sh pcm.quad_48k { type multi slaves.a { pcm { type plug slave.pcm "hw:RAVENNA" slave.rate 48000 } channels 2 } slaves.b { pcm { type plug slave.pcm "hw:sndrpihifiberry" slave.rate 48000 } channels 2 } bindings.0.slave a bindings.0.channel 0 bindings.1.slave a bindings.1.channel 1 bindings.2.slave b bindings.2.channel 0 bindings.3.slave b bindings.3.channel 1 } ``` and again it ends up with a failure: ```sh $ alsaloop -C quad_48k -P alsadsp -c 4 Sample format not available for capture quad_48k: Invalid argument Unable to set parameters for capture quad_48k stream: Invalid argument Loopback start failure. ``` I know that both these cards are capable of running 48kHz, I'm doing that all the time. So what could be the cause of this error? `alsadsp` wants them to be 48kHz and if run separately it all works well, both cards set themselves according to `alsadsp` requirements. It works even if there's only one card in the multi plugin that occupies all 4 output ports - my conclusion is that it's not a problem of `alsadsp`. Are there any other steps that could help solving the issue? Issue URL : https://github.com/alsa-project/alsa-lib/issues/273 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Add support for getting list of supported codecs
by GitHub pull_request - edited 05 Oct '22

05 Oct '22

alsa-project/tinycompress pull request #16 was edited from SanchayanMaity: Right now, there is no way to expose a list of codecs from `tinycompress`. While one could theoretically call `is_codec_supported` multiple times in an application to check against a list of codecs, an API would make it easy to enumerate supported codecs. The IOCTL `SNDRV_COMPRESS_GET_CAPS` after all already exists. Our use case is Pipewire where we would like the compressed sink node to advertise only codecs supported by the underlying hardware. So far we were just advertising the complete list of codecs and let node linking fail at runtime based on result from `is_codec_supported`. Request URL : https://github.com/alsa-project/tinycompress/pull/16 Patch URL : https://github.com/alsa-project/tinycompress/pull/16.patch Repository URL: https://github.com/alsa-project/tinycompress

1 0

[PATCH 1/1] ALSA: remove ALC289_FIXUP_DUAL_SPK for Dell 5530
by Callum Osmotherly 05 Oct '22

05 Oct '22

From: Callum Osmotherly <callum.osmotherly(a)gmail.com> After some feedback from users with Dell Precision 5530 machines, this patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK. While it improved the speaker output quality, it caused the headphone jack to have an audible "pop" sound when power saving was toggled. Signed-off-by: Callum Osmotherly <callum.osmotherly(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d35934f..ab6d736 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8836,7 +8836,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB), - SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB), -- 2.37.3

2 1