January 2022 - Alsa-devel - mailman.alsa-project.org

slow snd_rawmidi_drain() for VirMidi devcies
by Stefan Sauer 02 Jan '22

02 Jan '22

hi, happy new year every one. During the free days I've tried to link BitwigStudio to the webapp [1]cables.gl over virmidi. Unfortunately Bitwig Studio only supports rawmidi. What I discovered is that there is a strange slowness when sending data to virmidi caused by snd_rawmidi_drain(). I've posted two tiny, self-contained c apps to: [2]https://gist.github.com/ensonic/c7588b87fa6c1fa94a8f753b1e0aa394 See some examples below. 2 observations: * snd_rawmidi_type() is *not* reporting virmidi as VIRTUAL * snd_rawmidi_drain() takes about 60ms! on virtual vs. less that 0.1 ms on usb midi (I checked all my hw midi and the worst was avg=1ms on physical midi image unitor8) When comparing the implementations: [3]https://github.com/alsa-project/alsa-lib/blob/master/ src/rawmidi/rawmidi_virt.c#L173 [4]https://github.com/alsa-project/alsa-lib/blob/master/ src/rawmidi/rawmidi_hw.c#L164 I see that the hw one results in an IOCTL (SNDRV_RAWMIDI_IOCTL_DRAIN) which I can see when strac'ing app and I wonder if this is the root cause? Why is rawmidi_virt.c not used for virmidi? From poking at snd_rawmidi_open_conf() I have not yet figured where this is decided .... If the IOCTl is the right code path, any idea why it is slow? Is the virmidi driver not reporting buffer fill status or something like that? Stefan > amidi -l Dir Device Name IO hw:0,0,0 Scarlett 18i20 USB MIDI 1 IO hw:3,0,0 nanoKEY2 nanoKEY2 _ KEYBOARD IO hw:5,0,0 nanoKONTROL nanoKONTROL _ SLIDE IO hw:10,0 Virtual Raw MIDI (16 subdevices) IO hw:11,0 Virtual Raw MIDI (16 subdevices) # using direct i/o to virmidi - all good > ./rawmidi_oss /dev/midi11 0 Using device '/dev/midi11' without draining write took min= 0.0015 ms, avg= 0.0016 ms, max= 0.0110 ms > ./rawmidi_oss /dev/midi11 1 Using device '/dev/midi11' with draining write took min= 0.0015 ms, avg= 0.0017 ms, max= 0.0101 ms drain took min= 0.0001 ms, avg= 0.0001 ms, max= 0.0008 ms # using snd_rawmidi to virmidi - slow drain operations > ./rawmidi_alsa hw:11,0 0 Using device 'hw:11,0' without draining SND_RAWMIDI_TYPE_HW write took min= 0.0010 ms, avg= 0.0011 ms, max= 0.0056 ms > ./rawmidi_alsa hw:11,0 1 Using device 'hw:11,0' with draining SND_RAWMIDI_TYPE_HW write took min= 0.0016 ms, avg= 0.0040 ms, max= 0.0077 ms drain took min= 55.9951 ms, avg= 60.4330 ms, max= 64.0653 ms # using snd_rawmidi to usb hw - all good > ./rawmidi_alsa hw:3,0 0 Using device 'hw:3,0' without draining SND_RAWMIDI_TYPE_HW write took min= 0.0012 ms, avg= 0.0015 ms, max= 0.0121 ms > ./rawmidi_alsa hw:3,0 1 Using device 'hw:3,0' with draining SND_RAWMIDI_TYPE_HW write took min= 0.0024 ms, avg= 0.0032 ms, max= 0.0110 ms drain took min= 0.0293 ms, avg= 0.0636 ms, max= 0.2277 ms References 1. http://cables.gl/ 2. https://gist.github.com/ensonic/c7588b87fa6c1fa94a8f753b1e0aa394 3. https://github.com/alsa-project/alsa-lib/blob/master/src/rawmidi/rawmidi_vi… 4. https://github.com/alsa-project/alsa-lib/blob/master/src/rawmidi/rawmidi_hw…

1 0

src/topology/parser.c: drop duplicate safe_strtol_base
by GitHub pull_request - opened 01 Jan '22

01 Jan '22

alsa-project/alsa-lib pull request #208 was opened from ffontaine: `safe_strtol_base` is defined twice since https://github.com/alsa-project/alsa-lib/commit/f547b2e35f71e89397e8b29cd0b… and https://github.com/alsa-project/alsa-lib/commit/5fab157a593180525607b7d2626… resulting in the following build failure when alsa-utils is built statically: ``` checking for snd_tplg_new in -latopology... no configure: error: No linkable libatopology was found. ``` because `safe_strtol_base` is defined twice: ``` configure:7776: checking for snd_tplg_new in -latopology configure:7801: /home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g0 -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static conftest.c -latopology -lasound -lasound -lm -lpthread >&5 /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/9.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/buildroot/autobuild/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libasound.a(conf.o): in function `safe_strtol_base': conf.c:(.text+0x1600): multiple definition of `safe_strtol_base'; /home/buildroot/autobuild/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libatopology.a(parser.o):parser.c:(.text+0x130): first defined here ``` Fixes: - http://autobuild.buildroot.org/results/08d028004090b2a8292f03910cb9bf80a73a… Request URL : https://github.com/alsa-project/alsa-lib/pull/208 Patch URL : https://github.com/alsa-project/alsa-lib/pull/208.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

src/topology/parser.c: drop duplicate safe_strtol_base
by GitHub pull_request - opened 01 Jan '22

01 Jan '22

alsa-project/alsa-lib pull request #207 was opened from ffontaine: `safe_strtol_base` is defined twice since https://github.com/alsa-project/alsa-lib/commit/f547b2e35f71e89397e8b29cd0b… and https://github.com/alsa-project/alsa-lib/commit/5fab157a593180525607b7d2626… resulting in the following build failure when alsa-utils is built statically: ``` checking for snd_tplg_new in -latopology... no configure: error: No linkable libatopology was found. ``` because `safe_strtol_base` is defined twice: ``` configure:7776: checking for snd_tplg_new in -latopology configure:7801: /home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g0 -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static conftest.c -latopology -lasound -lasound -lm -lpthread >&5 /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/9.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/buildroot/autobuild/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libasound.a(conf.o): in function `safe_strtol_base': conf.c:(.text+0x1600): multiple definition of `safe_strtol_base'; /home/buildroot/autobuild/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libatopology.a(parser.o):parser.c:(.text+0x130): first defined here ``` Fixes: - http://autobuild.buildroot.org/results/08d028004090b2a8292f03910cb9bf80a73a… Signed-off-by: Fabrice Fontaine <fontaine.fabrice(a)gmail.com> Request URL : https://github.com/alsa-project/alsa-lib/pull/207 Patch URL : https://github.com/alsa-project/alsa-lib/pull/207.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v4 0/3] Fix Tegra194 HDA regression
by Sameer Pujar 01 Jan '22

01 Jan '22

HDA probe failure is observed on Tegra194 based platforms and this happens due to reset failure. This series fixes the problem by skipping the failing reset and DT bindings are updated accordingly. Changelog ========= v3 -> v4: --------- * Rename SoC data variable in HDA driver patch. * Remove NULL check for compatible match data in HDA driver patch. * Drop "Depends-on" tag from commit message and add "Reviewed-by" tag from Dmitry. * Update binding doc patch as per comment from Rob. v2 -> v3: --------- * Use reset bulk APIs in HDA driver as suggested by Dmitry. v1 -> v2: --------- * Updated HDA driver patch to skip the failing reset instead of skipping resets in general for BPMP devices as per comment from Dmitry. * Used a better strucure name for SoC data as per comment from Thierry. * Dropped 'Fixes' tag in binding doc patch as per comment from Dmitry. Sameer Pujar (3): ALSA: hda/tegra: Fix Tegra194 HDA reset failure dt-bindings: sound: tegra: Add minItems for resets arm64: tegra: Remove non existent Tegra194 reset .../bindings/sound/nvidia,tegra30-hda.yaml | 2 + arch/arm64/boot/dts/nvidia/tegra194.dtsi | 5 +-- sound/pci/hda/hda_tegra.c | 43 +++++++++++++++++----- 3 files changed, 38 insertions(+), 12 deletions(-) -- 2.7.4

2 4