August 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH 1/2] dt-bindings: panel: ili9341: correct indentation
by Krzysztof Kozlowski 30 Aug '21

30 Aug '21

Correct indentation warning: ilitek,ili9341.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)canonical.com> --- .../devicetree/bindings/display/panel/ilitek,ili9341.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml index 2ed010f91e2d..20ce88ab4b3a 100644 --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml @@ -22,7 +22,7 @@ properties: items: - enum: # ili9341 240*320 Color on stm32f429-disco board - - st,sf-tc240t-9370-t + - st,sf-tc240t-9370-t - const: ilitek,ili9341 reg: true -- 2.30.2

5 9

[RFC PATCH 0/2] ASoC: soc-pcm: fix trigger race conditions with shared BE
by Pierre-Louis Bossart 30 Aug '21

30 Aug '21

We've been adding a 'deep buffer' PCM device to several SOF topologies in order to reduce power consumption. The typical use-case would be music playback over a headset: this additional PCM device provides more buffering and longer latencies, leaving the rest of the system sleep for longer periods. Notifications and 'regular' low-latency audio playback would still use the 'normal' PCM device and be mixed with the 'deep buffer' before rendering on the headphone endpoint. The tentative direction would be to expose this alternate device to PulseAudio/PipeWire/CRAS via the UCM SectionModifier definitions. That seemed a straightforward topology change until our automated validation stress tests started reporting issues on SoundWire platforms, when e.g. two START triggers might be send and conversely the STOP trigger is never sent. The SoundWire stream state management flagged inconsistent states when the two 'normal' and 'deep buffer' devices are used concurrently with rapid play/stop/pause monkey testing. Looking at the soc-pcm.c code, it seems that the BE state management needs a lot of love. a) there is no consistent protection for the BE state. In some parts of the code, the state updates are protected by a spinlock but in the trigger they are not. When we open/play/close the two PCM devices in stress tests, we end-up testing a state that is being modified. That can't be good. b) there is a conceptual deadlock: on stop we check the FE states to see if a shared BE can be stopped, but since we trigger the BE first the FE states have not been modified yet, so the TRIGGER_STOP is never sent. This patchset suggests using the same spinlock used in other parts of soc-dpcm.c, and the use of a refcount to decide when to trigger the BE. With the two patches I am able to run our entire validation suite without any issues with this new 'deep buffer' topology. One might ask 'how come we didn't see this earlier'? The answer is probably that the .trigger callbacks in most implementations seems to perform DAPM operations, and sending the triggers multiple times is not an issue. In the case of SoundWire, we do use the .trigger callback to reconfigure the bus using the 'bank switch' mechanism. It could be acceptable to tolerate a trigger multiple times, but the deadlock on stop cannot be fixed at the SoundWire layer alone. Opens: 1) is this the right solution? The DPCM code is far from simple, has notions such as SND_SOC_DPCM_UPDATE_NO and 'trigger_pending' that I have no background on. 2) it's not clear if we need the full-blown spin_lock_irq_save() version or just the regular spin_lock()? 3) is this universal? this might break platforms with other types of 'POST' or 'BESPOKE' trigger. 4) is this ok to proceed with such an incremental fix, or do we have to revisit (possibly rewrite) the entire FE-BE interaction? I chose to send this patchset as an RFC to gather feedback and make use others know about DPCM issues. We're going to spend more time on this but if others can provide feedback/test results it would be greatly appreciated. Note that these DPCM issues will add more complexity to our SOF distribution. We've never hit a case where even recent kernels do not support a minor topology change that isn't related to an ABI change. We might have to introduce the deep buffer PCM device in a new topology file, add a kernel patch to make use of this new file and keep the old (w/o deep buffer) and new file (w/ deep buffer) for a very long time (not sure when we can assume that all users of SOF would transition to 5.15+...) Pierre-Louis Bossart (2): ASoC: soc-pcm: protect BE dailink state changes in trigger ASoC: soc-pcm: test refcount before triggering include/sound/soc-dpcm.h | 2 + sound/soc/soc-pcm.c | 151 +++++++++++++++++++++++++++++++++------ 2 files changed, 130 insertions(+), 23 deletions(-) -- 2.25.1

2 5

[bug report] ASoC: mediatek: implement mediatek common structure
by Dan Carpenter 30 Aug '21

30 Aug '21

Hello Garlic Tseng, The patch 283b612429a2: "ASoC: mediatek: implement mediatek common structure" from Jun 17, 2016, leads to the following Smatch static checker warning: sound/soc/mediatek/common/mtk-afe-fe-dai.c:364 mtk_afe_resume() error: we previously assumed 'afe->reg_back_up' could be null (see line 359) sound/soc/mediatek/common/mtk-afe-fe-dai.c 354 if (pm_runtime_status_suspended(dev) || !afe->suspended) 355 return 0; 356 357 afe->runtime_resume(dev); 358 359 if (!afe->reg_back_up) 360 dev_dbg(dev, "%s no reg_backup\n", __func__); Should this return? Also when ->reg_back_up is allocated there is no check for NULL so it seems like a very possible condition. 361 362 for (i = 0; i < afe->reg_back_up_list_num; i++) 363 mtk_regmap_write(regmap, afe->reg_back_up_list[i], --> 364 afe->reg_back_up[i]); 365 366 afe->suspended = false; 367 return 0; 368 } regards, dan carpenter

2 1

[PATCH] ASoC: rockchip: i2s: Fix concurrency between tx/rx
by Sugar Zhang 30 Aug '21

30 Aug '21

This patch adds lock to fix comcurrency between tx/rx to fix 'rockchip-i2s ff070000.i2s; fail to clear' Considering the situation; tx stream rx stream | | | disable enable | | reset After this patch: lock | tx stream | enable | unlock -------- --------- lock | rx stream | disable | reset | unlock Signed-off-by: Sugar Zhang <sugar.zhang(a)rock-chips.com> --- --- sound/soc/rockchip/rockchip_i2s.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index c7dc350..e4782ba 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -15,6 +15,7 @@ #include <linux/clk.h> #include <linux/pm_runtime.h> #include <linux/regmap.h> +#include <linux/spinlock.h> #include <sound/pcm_params.h> #include <sound/dmaengine_pcm.h> @@ -49,6 +50,7 @@ struct rk_i2s_dev { bool rx_start; bool is_master_mode; const struct rk_i2s_pins *pins; + spinlock_t lock; /* tx/rx lock */ }; static int i2s_runtime_suspend(struct device *dev) @@ -92,6 +94,7 @@ static void rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on) unsigned int val = 0; int retry = 10; + spin_lock(&lock); if (on) { regmap_update_bits(i2s->regmap, I2S_DMACR, I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_ENABLE); @@ -132,6 +135,7 @@ static void rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on) } } } + spin_unlock(&lock); } static void rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) @@ -139,6 +143,7 @@ static void rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) unsigned int val = 0; int retry = 10; + spin_lock(&lock); if (on) { regmap_update_bits(i2s->regmap, I2S_DMACR, I2S_DMACR_RDE_ENABLE, I2S_DMACR_RDE_ENABLE); @@ -179,6 +184,7 @@ static void rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) } } } + spin_unlock(&lock); } static int rockchip_i2s_set_fmt(struct snd_soc_dai *cpu_dai, @@ -589,6 +595,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) if (!i2s) return -ENOMEM; + spin_lock_init(&i2s->lock); i2s->dev = &pdev->dev; i2s->grf = syscon_regmap_lookup_by_phandle(node, "rockchip,grf"); -- 2.7.4

2 2

Re: linux-next: Tree for Aug 27 (sound/soc/mediatek: Kconfig)
by Randy Dunlap 30 Aug '21

30 Aug '21

On 8/27/21 4:24 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20210826: > > The kbuild tree still had its build failure for which I reverted a commit. > > The uml tree gained a conflict against the asm-generic tree. > > The net-next tree still had its build failure for which I applied a > patch and it also gained a semantic conflict against Linus' tree. > > The bpf-next tree lost its build failure. > > The tip tree gained conflicts against the arm64 tree. > > The ftrace tree gained a conflict against the uml tree. > > The vfio tree gained conflicts against the drm tree. > > The kspp tree still had its build failure so I used the version from > next-20210825. > > Non-merge commits (relative to Linus' tree): 9867 > 9528 files changed, 552507 insertions(+), 227054 deletions(-) > > ---------------------------------------------------------------------------- > > I have created today's linux-next tree at > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > (patches at http://www.kernel.org/pub/linux/kernel/next/ ). If you > are tracking the linux-next tree using git, you should not use "git pull" > to do so as that will try to merge the new linux-next release with the > old one. You should use "git fetch" and checkout or reset to the new > master. > > You can see which trees have been included by looking in the Next/Trees > file in the source. There are also quilt-import.log and merge.log > files in the Next directory. Between each merge, the tree was built > with a ppc64_defconfig for powerpc, an allmodconfig for x86_64, a > multi_v7_defconfig for arm and a native build of tools/perf. After > the final fixups (if any), I do an x86_64 modules_install followed by > builds for x86_64 allnoconfig, powerpc allnoconfig (32 and 64 bit), > ppc44x_defconfig, allyesconfig and pseries_le_defconfig and i386, sparc > and sparc64 defconfig and htmldocs. And finally, a simple boot test > of the powerpc pseries_le_defconfig kernel in qemu (with and without > kvm enabled). > > Below is a summary of the state of the merge. > > I am currently merging 334 trees (counting Linus' and 90 trees of bug > fix patches pending for the current merge release). > > Stats about the size of the tree over time can be seen at > http://neuling.org/linux-next-size.html . > > Status of my local build tests will be at > http://kisskb.ellerman.id.au/linux-next . If maintainers want to give > advice about cross compilers/configs that work, we are always open to add > more builds. > > Thanks to Randy Dunlap for doing many randconfig builds. And to Paul > Gortmaker for triage and bug fixes. > on i386: WARNING: unmet direct dependencies detected for SND_SOC_MT6359 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MTK_PMIC_WRAP [=n] Selected by [y]: - SND_SOC_MT8195_MT6359_RT1019_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] caused by 40d605df0a7b: ASoC: mediatek: mt8195: add machine driver with mt6359, rt1019 and rt5682 Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap <rdunlap(a)infradead.org>

2 1

[PATCH 0/2] Add reset-gpios handling for max98927
by Alejandro Tafalla 29 Aug '21

29 Aug '21

The max98927 codec on some devices (i.e. Xiaomi Mi A2 Lite phone) require hardware-resetting the codec by driving a reset-gpio. This series add support for it through an optional reset-gpios property. Alejandro Tafalla (2): ASoC: max98927: Handle reset gpio when probing i2c dt-bindings: sound: max98927: Add reset-gpios optional property .../devicetree/bindings/sound/max9892x.txt | 3 +++ sound/soc/codecs/max98927.c | 16 ++++++++++++++++ sound/soc/codecs/max98927.h | 1 + 3 files changed, 20 insertions(+) -- 2.32.0

1 2

Question: different install prefixes for libalsa and alsa-plugins?
by GitHub issues - opened 29 Aug '21

29 Aug '21

alsa-project/alsa-lib issue #175 was opened from daravi: Hello, I use Conan to manage my dependencies and wanted to add a recipe for `alsa-plugins`. However it seems that `ALSA_CONFIG_DIR` can only be set to a single path: https://github.com/conan-io/conan-center-index/pull/7098#discussion_r697920… So I was wondering if there is any other way I could have alsa and plugins installed in separate directories? (so that they can each have their own config directory) Issue URL : https://github.com/alsa-project/alsa-lib/issues/175 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH] ALSA: usb-audio: Add lowlatency module option
by Takashi Iwai 29 Aug '21

29 Aug '21

For making user to switch back to the old playback mode, this patch adds a new module option 'lowlatency' to snd-usb-audio driver. When user face a regression due to the recent low-latency playback support, they can test easily by passing lowlatency=0 option without rebuilding the kernel. Fixes: 307cc9baac5c ("ALSA: usb-audio: Reduce latency at playback start, take#2") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/card.c | 4 ++++ sound/usb/pcm.c | 3 ++- sound/usb/usbaudio.h | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/usb/card.c b/sound/usb/card.c index cf8f3953f78f..fd570a42f043 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -68,6 +68,7 @@ static int pid[SNDRV_CARDS] = { [0 ... (SNDRV_CARDS-1)] = -1 }; static int device_setup[SNDRV_CARDS]; /* device parameter for this card */ static bool ignore_ctl_error; static bool autoclock = true; +static bool lowlatency = true; static char *quirk_alias[SNDRV_CARDS]; static char *delayed_register[SNDRV_CARDS]; static bool implicit_fb[SNDRV_CARDS]; @@ -93,6 +94,8 @@ MODULE_PARM_DESC(ignore_ctl_error, "Ignore errors from USB controller for mixer interfaces."); module_param(autoclock, bool, 0444); MODULE_PARM_DESC(autoclock, "Enable auto-clock selection for UAC2 devices (default: yes)."); +module_param(lowlatency, bool, 0444); +MODULE_PARM_DESC(lowlatency, "Enable low latency playback (default: yes)."); module_param_array(quirk_alias, charp, NULL, 0444); MODULE_PARM_DESC(quirk_alias, "Quirk aliases, e.g. 0123abcd:5678beef."); module_param_array(delayed_register, charp, NULL, 0444); @@ -623,6 +626,7 @@ static int snd_usb_audio_create(struct usb_interface *intf, chip->setup = device_setup[idx]; chip->generic_implicit_fb = implicit_fb[idx]; chip->autoclock = autoclock; + chip->lowlatency = lowlatency; atomic_set(&chip->active, 1); /* avoid autopm during probing */ atomic_set(&chip->usage_count, 0); atomic_set(&chip->shutdown, 0); diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index f5cbf61ac366..5dc9266180e3 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -617,7 +617,8 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream) /* check whether early start is needed for playback stream */ subs->early_playback_start = subs->direction == SNDRV_PCM_STREAM_PLAYBACK && - subs->data_endpoint->nominal_queue_size >= subs->buffer_bytes; + (!chip->lowlatency || + (subs->data_endpoint->nominal_queue_size >= subs->buffer_bytes)); if (subs->early_playback_start) ret = start_endpoints(subs); diff --git a/sound/usb/usbaudio.h b/sound/usb/usbaudio.h index 94261d19cceb..167834133b9b 100644 --- a/sound/usb/usbaudio.h +++ b/sound/usb/usbaudio.h @@ -55,6 +55,7 @@ struct snd_usb_audio { bool generic_implicit_fb; /* from the 'implicit_fb' module param */ bool autoclock; /* from the 'autoclock' module param */ + bool lowlatency; /* from the 'lowlatency' module param */ struct usb_host_interface *ctrl_intf; /* the audio control interface */ struct media_device *media_dev; struct media_intf_devnode *ctl_intf_media_devnode; -- 2.26.2

1 0

Static build generates broken symlinks
by GitHub issues - opened 28 Aug '21

28 Aug '21

alsa-project/alsa-plugins issue #34 was opened from daravi: Hello, This snippet seems to generate some symlinks: ``` install-exec-hook: rm -f $(DESTDIR)@ALSA_PLUGIN_DIR@/libasound_module_rate_speexrate_*.so $(LN_S) libasound_module_rate_speexrate.so $(DESTDIR)@ALSA_PLUGIN_DIR@/libasound_module_rate_speexrate_best.so $(LN_S) libasound_module_rate_speexrate.so $(DESTDIR)@ALSA_PLUGIN_DIR@/libasound_module_rate_speexrate_medium.so ``` But it assumes we are doing a shared build. Which results in broken symlinks in a static build. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/34 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[PATCH 0/2] ctl/rawmidi/hwdep: fix trivial bugs
by GitHub pull_request - opened 28 Aug '21

28 Aug '21

alsa-project/alsa-gobject pull request #62 was opened from takaswie: Current implementation of libalsactl0, libalsarawmidi0, and libalsahwdep0 includes trivial bugs such as usage of uninitialized local variable. This patchset fixes the bugs. ``` Takashi Sakamoto (2): ctl/rawmidi/hwdep: fix compiler warning due to uninitialized variables seq: use safer way to copy strings src/ctl/query.c | 4 ++-- src/hwdep/query.c | 4 ++-- src/rawmidi/query.c | 4 ++-- src/seq/client-info.c | 2 +- src/seq/port-info.c | 2 +- src/seq/query.c | 2 +- src/seq/queue-info.c | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/62 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/62.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0