May 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH v2] ASoC: rt5659: Fix the lost powers for the HDA header
by Jack Yu 28 May '21

28 May '21

The power of "LDO2", "MICBIAS1" and "Mic Det Power" were powered off after the DAPM widgets were added, and these powers were set by the JD settings "RT5659_JD_HDA_HEADER" in the probe function. In the codec probe function, these powers were ignored to prevent them controlled by DAPM. Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> Signed-off-by: Jack Yu <jack.yu(a)realtek.com> --- sound/soc/codecs/rt5659.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index 87f5709..4a50b16 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -2433,13 +2433,18 @@ static int set_dmic_power(struct snd_soc_dapm_widget *w, return 0; } -static const struct snd_soc_dapm_widget rt5659_dapm_widgets[] = { +static const struct snd_soc_dapm_widget rt5659_particular_dapm_widgets[] = { SND_SOC_DAPM_SUPPLY("LDO2", RT5659_PWR_ANLG_3, RT5659_PWR_LDO2_BIT, 0, NULL, 0), - SND_SOC_DAPM_SUPPLY("PLL", RT5659_PWR_ANLG_3, RT5659_PWR_PLL_BIT, 0, - NULL, 0), + SND_SOC_DAPM_SUPPLY("MICBIAS1", RT5659_PWR_ANLG_2, RT5659_PWR_MB1_BIT, + 0, NULL, 0), SND_SOC_DAPM_SUPPLY("Mic Det Power", RT5659_PWR_VOL, RT5659_PWR_MIC_DET_BIT, 0, NULL, 0), +}; + +static const struct snd_soc_dapm_widget rt5659_dapm_widgets[] = { + SND_SOC_DAPM_SUPPLY("PLL", RT5659_PWR_ANLG_3, RT5659_PWR_PLL_BIT, 0, + NULL, 0), SND_SOC_DAPM_SUPPLY("Mono Vref", RT5659_PWR_ANLG_1, RT5659_PWR_VREF3_BIT, 0, NULL, 0), @@ -2464,8 +2469,6 @@ static int set_dmic_power(struct snd_soc_dapm_widget *w, RT5659_ADC_MONO_R_ASRC_SFT, 0, NULL, 0), /* Input Side */ - SND_SOC_DAPM_SUPPLY("MICBIAS1", RT5659_PWR_ANLG_2, RT5659_PWR_MB1_BIT, - 0, NULL, 0), SND_SOC_DAPM_SUPPLY("MICBIAS2", RT5659_PWR_ANLG_2, RT5659_PWR_MB2_BIT, 0, NULL, 0), SND_SOC_DAPM_SUPPLY("MICBIAS3", RT5659_PWR_ANLG_2, RT5659_PWR_MB3_BIT, @@ -3660,10 +3663,23 @@ static int rt5659_set_bias_level(struct snd_soc_component *component, static int rt5659_probe(struct snd_soc_component *component) { + struct snd_soc_dapm_context *dapm = + snd_soc_component_get_dapm(component); struct rt5659_priv *rt5659 = snd_soc_component_get_drvdata(component); rt5659->component = component; + switch (rt5659->pdata.jd_src) { + case RT5659_JD_HDA_HEADER: + break; + + default: + snd_soc_dapm_new_controls(dapm, + rt5659_particular_dapm_widgets, + ARRAY_SIZE(rt5659_particular_dapm_widgets)); + break; + } + return 0; } -- 1.9.1

2 1

[PATCH v2 00/11] ASoC: rsnd: tidyup and fixup rare MIXer issue
by Kuninori Morimoto 28 May '21

28 May '21

Hi Mark These are v2 of tidyup patch, and rare MIXer issue fixup patch for Renesas Sound driver. 1 - 6 : tidyup for rsnd driver 7 : add debugfs support 8 : fixup rare MIXer issue 9 - 11: tidyup for rsnd driver v1 -> v2 - add adg.c fixup patch (= [01/11]) - tidyup compile error when CONFIG_DEBUG_FS was not selected (= [07/11]) Link: https://lore.kernel.org/r/87mtsjof3w.wl-kuninori.morimoto.gx@renesas.com Kuninori Morimoto (11): 1 ASoC: rsnd: call unregister for null_hw when removed 2 ASoC: rsnd: ignore runtime NULL case at rsnd_runtime_channel_original_with_params() 3 ASoC: rsnd: attach SSIU when SSI was DMA mode 4 ASoC: rsnd: check BUIF error everytime 5 ASoC: rsnd: indicate unknown error at rsnd_dai_call() 6 ASoC: rsnd: incidate irq error message 7 ASoC: rsnd: add debugfs support 8 ASoC: rsnd: protect mod->status 9 ASoC: rsnd: implement BUSIF related code in ssiu.c 10 ASoC: rsnd: tidyup rsnd_ssiu_busif_err_status_clear() 11 ASoC: rsnd: tidyup rsnd_ssiu_busif_err_irq_ctrl() sound/soc/sh/rcar/Makefile | 2 +- sound/soc/sh/rcar/adg.c | 44 +++++++---- sound/soc/sh/rcar/cmd.c | 14 ++++ sound/soc/sh/rcar/core.c | 65 +++++++++------- sound/soc/sh/rcar/ctu.c | 14 ++++ sound/soc/sh/rcar/debugfs.c | 96 +++++++++++++++++++++++ sound/soc/sh/rcar/dma.c | 31 ++++++-- sound/soc/sh/rcar/dvc.c | 14 ++++ sound/soc/sh/rcar/gen.c | 9 +++ sound/soc/sh/rcar/mix.c | 14 ++++ sound/soc/sh/rcar/rsnd.h | 40 ++++++++-- sound/soc/sh/rcar/src.c | 26 ++++++- sound/soc/sh/rcar/ssi.c | 148 +++++++++--------------------------- sound/soc/sh/rcar/ssiu.c | 134 ++++++++++++++++++++++++++++---- 14 files changed, 465 insertions(+), 186 deletions(-) create mode 100644 sound/soc/sh/rcar/debugfs.c -- 2.25.1

2 12

[PATCH -next] ALSA: core: use DEVICE_ATTR_*() macro
by YueHaibing 28 May '21

28 May '21

Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- sound/core/init.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/sound/core/init.c b/sound/core/init.c index 70114fd26956..228faf9369dc 100644 --- a/sound/core/init.c +++ b/sound/core/init.c @@ -665,17 +665,15 @@ void snd_card_set_id(struct snd_card *card, const char *nid) } EXPORT_SYMBOL(snd_card_set_id); -static ssize_t -card_id_show_attr(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t id_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct snd_card *card = container_of(dev, struct snd_card, card_dev); return scnprintf(buf, PAGE_SIZE, "%s\n", card->id); } -static ssize_t -card_id_store_attr(struct device *dev, struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t id_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) { struct snd_card *card = container_of(dev, struct snd_card, card_dev); char buf1[sizeof(card->id)]; @@ -703,17 +701,16 @@ card_id_store_attr(struct device *dev, struct device_attribute *attr, return count; } -static DEVICE_ATTR(id, 0644, card_id_show_attr, card_id_store_attr); +static DEVICE_ATTR_RW(id); -static ssize_t -card_number_show_attr(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t number_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct snd_card *card = container_of(dev, struct snd_card, card_dev); return scnprintf(buf, PAGE_SIZE, "%i\n", card->number); } -static DEVICE_ATTR(number, 0444, card_number_show_attr, NULL); +static DEVICE_ATTR_RO(number); static struct attribute *card_dev_attrs[] = { &dev_attr_id.attr, -- 2.17.1

2 1

[PATCH 0/3] alsa-gobject: misc fixes
by GitHub pull_request - edited 28 May '21

28 May '21

alsa-project/alsa-gobject pull request #59 was edited from takaswie: This patchset fixes some bugs below: * Ubuntu 19.10/i386 is EOL and no release is available for i386 architecture in Ubuntu project * Update Fedora version for CI environment * Wrong command is in install section of README ``` Takashi Sakamoto (3): correct install section in README fix workflow according to EOF of i386 ubuntu distribution update Fedora release for CI environment .github/workflows/build.yml | 83 +++++++++++++++++++------------------ README.rst | 2 +- 2 files changed, 43 insertions(+), 42 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/59 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/59.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 0/3] alsa-gobject: misc fixes
by GitHub pull_request - edited 28 May '21

28 May '21

alsa-project/alsa-gobject pull request #59 was edited from takaswie: This patchset fixes some bugs below: * Ubuntu 19.10/i386 is EOL and no release is available for i386 architecture in Ubuntu project * Wrong command is in install section of README ``` Takashi Sakamoto (2): correct install section in README fix workflow according to EOF of i386 ubuntu distribution .github/workflows/build.yml | 81 +++++++++++++++++++------------------ README.rst | 2 +- 2 files changed, 42 insertions(+), 41 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/59 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/59.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 0/2] alsa-gobject: misc fixes
by GitHub pull_request - opened 28 May '21

28 May '21

alsa-project/alsa-gobject pull request #59 was opened from takaswie: This patchset fixes some bugs below: * Ubuntu 19.10/i386 is EOL and no release is available for i386 architecture in Ubuntu project * Wrong command is in install section of README ``` Takashi Sakamoto (2): correct install section in README fix workflow according to EOF of i386 ubuntu distribution .github/workflows/build.yml | 81 +++++++++++++++++++------------------ README.rst | 2 +- 2 files changed, 42 insertions(+), 41 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/59 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/59.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 0/3] ALSA: firewire-lib: preparation for media clock recovery
by Takashi Sakamoto 28 May '21

28 May '21

Hi, ALSA IEC 61883-1/6 packet streaming engine have been using pre-computed parameters ideal for nominal sampling transfer frequency (STF), to transfer packets to device since it was added 2011. As a result of user experience for a decade, it is clear that the sequence is not suitable to some actual devices. In design of audio and music unit in IEEE 1394 bus, feedback of effective sampling transfer frequency is delivered by packets transferred from device. Reuse of the sequence of parameter in the packets results in pseudo media clock recovery to transfer packet. In this patchset, an option is added to AMDTP domain so that each of AMDTP stream for outgoing packet has association to AMDTP stream for incoming packet, to replay the sequence of parameter. Some devices require receiving packet on-the-fly to transfer packets, so another option is added. These options are just added, not used yet in this time. In future work, they are going to be used by drivers in ALSA firewire stack. Takashi Sakamoto (3): ALSA: firewire-lib: add replay target to cache sequence of packet ALSA: firewire-lib: replay sequence of incoming packets for outgoing packets ALSA: firewire-lib: transfer rx packets on-the-fly when replaying sound/firewire/amdtp-stream.c | 252 ++++++++++++++++++-- sound/firewire/amdtp-stream.h | 17 +- sound/firewire/bebob/bebob_stream.c | 2 +- sound/firewire/dice/dice-stream.c | 2 +- sound/firewire/digi00x/digi00x-stream.c | 2 +- sound/firewire/fireface/ff-stream.c | 2 +- sound/firewire/fireworks/fireworks_stream.c | 2 +- sound/firewire/motu/motu-stream.c | 2 +- sound/firewire/oxfw/oxfw-stream.c | 2 +- sound/firewire/tascam/tascam-stream.c | 2 +- 10 files changed, 259 insertions(+), 26 deletions(-) -- 2.27.0

2 4

[PATCH] ALSA: firewire-lib: support NO_PERIOD_WAKEUP in ALSA PCM runtime
by Takashi Sakamoto 28 May '21

28 May '21

Drivers of ALSA firewire stack can process packets for IT/IR context in process context when the process operates ALSA PCM character device by calling ioctl(2) with some requests. The ioctl requests are: * SNDRV_PCM_IOCTL_HWSYNC * SNDRV_PCM_IOCTL_SYNC_PTR * SNDRV_PCM_IOCTL_REWIND * SNDRV_PCM_IOCTL_FORWARD * SNDRV_PCM_IOCTL_WRITEI_FRAMES * SNDRV_PCM_IOCTL_READI_FRAMES * SNDRV_PCM_IOCTL_WRITEN_FRAMES * SNDRV_PCM_IOCTL_READN_FRAMES This means that general application can process PCM frames apart from hardware IRQ invocation, even if they are programmed by either IRQ-based scheduling model or Timer-based scheduling model. This commit add support for Timer-based scheduling model by allowing PCM runtime to suppress both process wakeup per period and scheduling hardware IRQ. SNDRV_PCM_INFO_BATCH is obsoleted since ALSA IEC 61883-1/6 packet streaming engine can report the number of transferred PCM frames within PCM period boundary. The granularity equals to SYT_INTERVAL in blocking transmission. In non-blocking transmission, it doesn't equal to SYT_INTERVAL but doesn't exceed. This patch is tested with PulseAudio, and --sched-model option of axfer with fix against the issue reported at: * https://lore.kernel.org/alsa-devel/687f9871-7484-1370-04d1-9c968e86f72b@lin… Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/amdtp-stream.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index 68ffbc33f692..8e72e7f4c082 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -191,14 +191,13 @@ int amdtp_stream_add_pcm_hw_constraints(struct amdtp_stream *s, unsigned int maximum_usec_per_period; int err; - hw->info = SNDRV_PCM_INFO_BATCH | - SNDRV_PCM_INFO_BLOCK_TRANSFER | + hw->info = SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_JOINT_DUPLEX | SNDRV_PCM_INFO_MMAP | - SNDRV_PCM_INFO_MMAP_VALID; + SNDRV_PCM_INFO_MMAP_VALID | + SNDRV_PCM_INFO_NO_PERIOD_WAKEUP; - /* SNDRV_PCM_INFO_BATCH */ hw->periods_min = 2; hw->periods_max = UINT_MAX; @@ -503,7 +502,12 @@ static void update_pcm_pointers(struct amdtp_stream *s, s->pcm_period_pointer += frames; if (s->pcm_period_pointer >= pcm->runtime->period_size) { s->pcm_period_pointer -= pcm->runtime->period_size; - queue_work(system_highpri_wq, &s->period_work); + + // The program in user process should periodically check the status of intermediate + // buffer associated to PCM substream to process PCM frames in the buffer, instead + // of receiving notification of period elapsed by poll wait. + if (!pcm->runtime->no_period_wakeup) + queue_work(system_highpri_wq, &s->period_work); } } @@ -949,6 +953,7 @@ static void process_rx_packets(struct fw_iso_context *context, u32 tstamp, size_ unsigned int event_count = s->ctx_data.rx.event_count; unsigned int pkt_header_length; unsigned int packets; + bool need_hw_irq; int i; if (s->packet_index < 0) @@ -968,6 +973,16 @@ static void process_rx_packets(struct fw_iso_context *context, u32 tstamp, size_ else pkt_header_length = 0; + if (s == d->irq_target) { + // At NO_PERIOD_WAKEUP mode, the packets for all IT/IR contexts are processed by + // the tasks of user process operating ALSA PCM character device by calling ioctl(2) + // with some requests, instead of scheduled hardware IRQ of an IT context. + struct snd_pcm_substream *pcm = READ_ONCE(s->pcm); + need_hw_irq = !pcm || !pcm->runtime->no_period_wakeup; + } else { + need_hw_irq = false; + } + for (i = 0; i < packets; ++i) { const struct pkt_desc *desc = s->pkt_descs + i; struct { @@ -984,7 +999,7 @@ static void process_rx_packets(struct fw_iso_context *context, u32 tstamp, size_ event_count += desc->data_blocks; if (event_count >= events_per_period) { event_count -= events_per_period; - sched_irq = true; + sched_irq = need_hw_irq; } } -- 2.27.0

2 1

No sound with Realtek ALC3306
by GitHub issues - edited 27 May '21

27 May '21

alsa-project/alsa-lib issue #139 was edited from dantahoua: Realtek ALC3306 (Lenovo 13s Gen2 ITL i7), but seems common problem with any computer using this codec. -Headphone, HDMI, BT working great. -Speaker not working (but computer seeing audio output and sending audio, meter even showing audio in GUI). Seems like something (amp?) is not turned, like missing something between speaker and codec... Works perfect in Windows 10. Tested lots different distro and kernel... Computer report ALC287 but it is not! It's ALC3306... Here is the alsa infos: [Infos](http://alsa-project.org/db/?f=1f3e847b60bd38085e39e26d992ea8680dd908… Issue URL : https://github.com/alsa-project/alsa-lib/issues/139 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

No sound with Realtek ALC3306
by GitHub issues - edited 27 May '21

27 May '21

alsa-project/alsa-lib issue #139 was edited from dantahoua: Realtek ALC3306 (Lenovo 13s Gen2 ITL i7), but seems common problem with any computer using this codec. -Headphone, HDMI, BT working great. -Speaker not working (but computer seeing audio output and sending audio, meter even showing audio in GUI). Seems like something (amp?) is not turned, like missing something between speaker and codec... Works perfect in Windows 10. Tested lots different distro and kernel... Here is the alsa infos: [Infos](http://alsa-project.org/db/?f=1f3e847b60bd38085e39e26d992ea8680dd908… Issue URL : https://github.com/alsa-project/alsa-lib/issues/139 Repository URL: https://github.com/alsa-project/alsa-lib

1 0