April 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] Pioneer devices: engage implicit feedback sync for playback
by Geraldo 04 Apr '21

04 Apr '21

Hello everybody, This is a highly experimental patch on top of 5.12-rc4 that's supposed to engage implicit feedback sync on the playback for Pioneer devices. Without implicit feedback sync the inputs started glitching due to clock drift in about an hour in my Pioneer DJ DDJ-SR2. If you own a Pioneer device please test this patch and verify in the dyndbg logs if your capture(input) EP is being opened twice and if implicit_fb = 1 for the playback EP. I can't ask of you all to test this for hours and hours but if you wanted to have an excuse to digitize vinyl or spin up DVS this is your perfect one. Help open source! I'd like to thank Takashi Iwai for his tireless support in the Pioneer regression and beyond. Hopefully this highly experimental feature's code can be polished and mainlined eventually. --- implicit.c.git 2021-03-21 22:40:48.363417245 -0300 +++ implicit.c 2021-03-22 01:03:05.726729481 -0300 @@ -177,30 +177,31 @@ ifnum, alts); } -/* Playback and capture EPs on Pioneer devices share the same iface/altset, - * but they don't seem working with the implicit fb mode well, hence we - * just return as if the sync were already set up. +/* Pioneer devices: playback and capture streams sharing the same iface/altset */ -static int skip_pioneer_sync_ep(struct snd_usb_audio *chip, - struct audioformat *fmt, - struct usb_host_interface *alts) -{ - struct usb_endpoint_descriptor *epd; - - if (alts->desc.bNumEndpoints != 2) - return 0; - - epd = get_endpoint(alts, 1); - if (!usb_endpoint_is_isoc_in(epd) || - (epd->bmAttributes & USB_ENDPOINT_SYNCTYPE) != USB_ENDPOINT_SYNC_ASYNC || - ((epd->bmAttributes & USB_ENDPOINT_USAGE_MASK) != - USB_ENDPOINT_USAGE_DATA && - (epd->bmAttributes & USB_ENDPOINT_USAGE_MASK) != - USB_ENDPOINT_USAGE_IMPLICIT_FB)) - return 0; - return 1; /* don't handle with the implicit fb, just skip sync EP */ +static int add_pioneer_implicit_fb(struct snd_usb_audio *chip, + struct audioformat *fmt, + struct usb_host_interface *alts) +{ + struct usb_endpoint_descriptor *epd; + + if (alts->desc.bNumEndpoints != 2) + return 0; + + epd = get_endpoint(alts, 1); + + if (!usb_endpoint_is_isoc_in(epd) || + (epd->bmAttributes & USB_ENDPOINT_SYNCTYPE) != USB_ENDPOINT_SYNC_ASYNC || + ((epd->bmAttributes & USB_ENDPOINT_USAGE_MASK) != + USB_ENDPOINT_USAGE_DATA && + (epd->bmAttributes & USB_ENDPOINT_USAGE_MASK) != + USB_ENDPOINT_USAGE_IMPLICIT_FB)) + return 0; + return add_implicit_fb_sync_ep(chip, fmt, epd->bEndpointAddress, 1, + alts->desc.bInterfaceNumber, alts); } + static int __add_generic_implicit_fb(struct snd_usb_audio *chip, struct audioformat *fmt, int iface, int altset) @@ -306,7 +307,7 @@ alts->desc.bInterfaceClass == USB_CLASS_VENDOR_SPEC && (USB_ID_VENDOR(chip->usb_id) == 0x2b73 || /* Pioneer */ USB_ID_VENDOR(chip->usb_id) == 0x08e4 /* Pioneer */)) { - if (skip_pioneer_sync_ep(chip, fmt, alts)) + if (add_pioneer_implicit_fb(chip, fmt, alts)) return 1; } @@ -339,8 +340,20 @@ struct audioformat *fmt, struct usb_host_interface *alts) { - if (fmt->endpoint & USB_DIR_IN) - return audioformat_capture_quirk(chip, fmt, alts); + bool isPioneer; + + if (alts->desc.bInterfaceClass == USB_CLASS_VENDOR_SPEC && + (USB_ID_VENDOR(chip->usb_id) == 0x2b73 || /* Pioneer */ + USB_ID_VENDOR(chip->usb_id) == 0x08e4 /* Pioneer */)) + isPioneer = true; + + if (fmt->endpoint & USB_DIR_IN) { + if (isPioneer == true) + return 1; + else + return audioformat_capture_quirk(chip, fmt, alts); + } + else return audioformat_implicit_fb_quirk(chip, fmt, alts); } --- endpoint.c.git 2021-03-21 22:40:54.800084101 -0300 +++ endpoint.c 2021-03-21 22:45:41.543425855 -0300 @@ -688,7 +688,7 @@ goto unlock; } - if (!ep->opened) { + if (ep->opened < 2) { if (is_sync_ep) { ep->iface = fp->sync_iface; ep->altsetting = fp->sync_altsetting;

1 3

ALC1220 and presence of ucm2/ucm.conf breaks audio
by GitHub issues - opened 04 Apr '21

04 Apr '21

alsa-project/alsa-ucm-conf issue #86 was opened from devnull0000: I'd want to make a better report but I am not an ALSA expert, so the issue is that after update I lose any sound and I use ALC1220 codec on MSI MEG X570 GODLIKE motherboard. Deep googling gave me the report: https://bugs.archlinux.org/task/67058 So indeed deletion of the file helped immediately. The bug is super confusing because it looks like the device is present at alsa level but absent on Pulse Audio and it is not shown in GUI at all. I am at alsa-ucm-conf-1.2.4, linux-5.11.11, pulseaudio 13.0, gentoo. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/86 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v6 0/2] hardware-privacy-implementation-for-dell-laptop
by Perry Yuan 04 Apr '21

04 Apr '21

From: Perry Yuan <perry_yuan(a)dell.com> Hi All, This patch set is a new driver for Dell mobile platform that has the hardware privacy feature including micmute,camera mute. For micmute led control, the hotkey is Fn + F4, it is a hardware based mute state, and new privacy will prevent micphone void input from hardware layer, any application cannot get voice data when micmute activated. Camera mute use a new hardware design to control the camrea shutter. When video is muted, no OS application should be functionally able to capture images of the person/environment in front of the system Older history: [1]https://patchwork.kernel.org/project/platform-driver-x86/patch/2020122813… [2]https://patchwork.kernel.org/project/alsa-devel/patch/20201103125859.8759… [3]https://www.spinics.net/lists/alsa-devel/msg120537.html [4]https://github.com/thesofproject/linux/pull/2660 [5]https://github.com/thesofproject/linux/issues/2496 Perry Yuan (2): platform/x86: dell-privacy: Add support for Dell hardware privacy ASoC: rt715:add micmute led state control supports .../testing/sysfs-platform-dell-privacy-wmi | 55 +++ drivers/platform/x86/dell/Kconfig | 14 + drivers/platform/x86/dell/Makefile | 1 + drivers/platform/x86/dell/dell-laptop.c | 23 +- drivers/platform/x86/dell/dell-privacy-wmi.c | 441 ++++++++++++++++++ drivers/platform/x86/dell/dell-privacy-wmi.h | 32 ++ drivers/platform/x86/dell/dell-wmi.c | 13 +- sound/soc/codecs/rt715-sdca.c | 41 +- sound/soc/codecs/rt715.c | 41 ++ 9 files changed, 653 insertions(+), 8 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-platform-dell-privacy-wmi create mode 100644 drivers/platform/x86/dell/dell-privacy-wmi.c create mode 100644 drivers/platform/x86/dell/dell-privacy-wmi.h -- 2.25.1

1 0

[PATCH] ALSA: control_led: use helper macro to declare device attributes with specific permission
by Takashi Sakamoto 04 Apr '21

04 Apr '21

It's preferable to use DEVICE_ATTR_XXX() for device attributes with specific permission instead of DEVICE_ATTR() basis macro. Fixes: 22d8de62f11b ("ALSA: control - add generic LED trigger module as the new control layer") Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/core/control_led.c | 37 +++++++++++++++++-------------------- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/sound/core/control_led.c b/sound/core/control_led.c index 788fd9e275e0..99c5d503638f 100644 --- a/sound/core/control_led.c +++ b/sound/core/control_led.c @@ -371,8 +371,7 @@ static void snd_ctl_led_disconnect(struct snd_card *card) * sysfs */ -static ssize_t show_mode(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t mode_show(struct device *dev, struct device_attribute *attr, char *buf) { struct snd_ctl_led *led = container_of(dev, struct snd_ctl_led, dev); const char *str; @@ -386,8 +385,8 @@ static ssize_t show_mode(struct device *dev, return sprintf(buf, "%s\n", str); } -static ssize_t store_mode(struct device *dev, struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t mode_store(struct device *dev, struct device_attribute *attr, const char *buf, + size_t count) { struct snd_ctl_led *led = container_of(dev, struct snd_ctl_led, dev); char _buf[16]; @@ -415,16 +414,15 @@ static ssize_t store_mode(struct device *dev, struct device_attribute *attr, return count; } -static ssize_t show_brightness(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t brightness_show(struct device *dev, struct device_attribute *attr, char *buf) { struct snd_ctl_led *led = container_of(dev, struct snd_ctl_led, dev); return sprintf(buf, "%u\n", ledtrig_audio_get(led->trigger_type)); } -static DEVICE_ATTR(mode, 0644, show_mode, store_mode); -static DEVICE_ATTR(brightness, 0444, show_brightness, NULL); +static DEVICE_ATTR_RW(mode); +static DEVICE_ATTR_RO(brightness); static struct attribute *snd_ctl_led_dev_attrs[] = { &dev_attr_mode.attr, @@ -558,22 +556,22 @@ static ssize_t set_led_id(struct snd_ctl_led_card *led_card, const char *buf, si return count; } -static ssize_t parse_attach(struct device *dev, struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t attach_store(struct device *dev, struct device_attribute *attr, const char *buf, + size_t count) { struct snd_ctl_led_card *led_card = container_of(dev, struct snd_ctl_led_card, dev); return set_led_id(led_card, buf, count, true); } -static ssize_t parse_detach(struct device *dev, struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t detach_store(struct device *dev, struct device_attribute *attr, const char *buf, + size_t count) { struct snd_ctl_led_card *led_card = container_of(dev, struct snd_ctl_led_card, dev); return set_led_id(led_card, buf, count, false); } -static ssize_t ctl_reset(struct device *dev, struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t reset_store(struct device *dev, struct device_attribute *attr, const char *buf, + size_t count) { struct snd_ctl_led_card *led_card = container_of(dev, struct snd_ctl_led_card, dev); int err; @@ -586,8 +584,7 @@ static ssize_t ctl_reset(struct device *dev, struct device_attribute *attr, return count; } -static ssize_t ctl_list(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t list_show(struct device *dev, struct device_attribute *attr, char *buf) { struct snd_ctl_led_card *led_card = container_of(dev, struct snd_ctl_led_card, dev); struct snd_card *card; @@ -620,10 +617,10 @@ static ssize_t ctl_list(struct device *dev, return buf2 - buf; } -static DEVICE_ATTR(attach, 0200, NULL, parse_attach); -static DEVICE_ATTR(detach, 0200, NULL, parse_detach); -static DEVICE_ATTR(reset, 0200, NULL, ctl_reset); -static DEVICE_ATTR(list, 0444, ctl_list, NULL); +static DEVICE_ATTR_WO(attach); +static DEVICE_ATTR_WO(detach); +static DEVICE_ATTR_WO(reset); +static DEVICE_ATTR_RO(list); static struct attribute *snd_ctl_led_card_attrs[] = { &dev_attr_attach.attr, -- 2.27.0

1 0

[PATCH alsa-ucm-conf 0/1] cht-bsw-rt5672: Add support for the components string
by Hans de Goede 04 Apr '21

04 Apr '21

Hi All, Add support for using the card's components string to figure out the DMIC and speaker configuration so that we can stop duplicating the kernel's DMI quirks inside the UCM profile. The kernel side of this was just merged: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h… Regards, Hans Hans de Goede (1): cht-bsw-rt5672: Add support for the components string ucm2/cht-bsw-rt5672/HiFi.conf | 37 +++++++++++++++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) -- 2.30.2

1 1

[PATCH] ASoC: max98390: Add controls for tx path
by Steve Lee 03 Apr '21

03 Apr '21

Add controls for tx source. Signed-off-by: Steve Lee <steves.lee(a)maximintegrated.com> --- sound/soc/codecs/max98390.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index bb736c44e68a..163093959da8 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -656,6 +656,12 @@ static const struct snd_kcontrol_new max98390_snd_controls[] = { MAX98390_AMP_DSP_CFG_RMP_DN_SHIFT, 1, 0), SOC_SINGLE("Boost Clock Phase", MAX98390_BOOST_CTRL3, MAX98390_BOOST_CLK_PHASE_CFG_SHIFT, 3, 0), + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A, + 0, 255, 0), + SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A, + 0, 255, 0), + SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2, + 0, 255, 0), SOC_ENUM("Boost Output Voltage", max98390_boost_voltage), SOC_ENUM("Current Limit", max98390_current_limit), SOC_SINGLE_EXT("DSM Rdc", SND_SOC_NOPM, 0, 0xffffff, 0, -- 2.17.1

2 2

[PATCH 0/6] ASoC: rt5670/Intel: Add support for Bay Trail CR / Dell Venue 10 Pro 5055 tablet
by Hans de Goede 02 Apr '21

02 Apr '21

Hi All, Here is a patch series to enable sound on the Dell Venue 10 Pro 5055 tablet this series also includes 2 generic improvements to rt5672 support: 1. Add support for boards using Bay Trail CR (SSP0) in combination with a rt5672 codec 2. Set the card's components string based on the DMI info, so that we don't need to duplicate the DMI quirks in userspace (in the UCM profile) I've a patch to add support for the components string to the UCM profile for these boards available here: https://github.com/jwrdegoede/alsa-ucm-conf/commit/fedacc2bdc530b6febac665d… I will submit this upstream once the kernel side has landed. Regards, Hans Hans de Goede (6): ASoC: Intel: Unify the thinkpad10 and aegex10 byt-match quirks ASoC: Intel: Baytrail: Add quirk for the Dell Venue 10 Pro 5055 tablet ASoC: Intel: cht_bsw_rt5672: Add support for Bay Trail CR / SSP0 ASoC: rt5670: Add a quirk for the Dell Venue 10 Pro 5055 ASoC: rt5670: Add a rt5670_components() helper ASoC: Intel: cht_bsw_rt5672: Set card.components string sound/soc/codecs/rt5670.c | 51 ++++++++++++ sound/soc/codecs/rt5670.h | 2 + sound/soc/intel/boards/cht_bsw_rt5672.c | 77 +++++++++++++++---- .../intel/common/soc-acpi-intel-byt-match.c | 40 +++++----- 4 files changed, 136 insertions(+), 34 deletions(-) -- 2.30.2

3 8

[PATCH] ASoC: fsl_esai: Fix TDM slot setup for I2S mode
by Alexander Shiyan 02 Apr '21

02 Apr '21

When using the driver in I2S TDM mode, the fsl_esai_startup() function rewrites the number of slots previously set by the fsl_esai_set_dai_tdm_slot() function to 2. To fix this, let's use the saved slot count value or, if TDM is not used and the number of slots is not set, the driver will use the default value (2), which is set by fsl_esai_probe(). Signed-off-by: Alexander Shiyan <shc_work(a)mail.ru> --- sound/soc/fsl/fsl_esai.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 08056fa0a0fa..a857a624864f 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -519,11 +519,13 @@ static int fsl_esai_startup(struct snd_pcm_substream *substream, ESAI_SAICR_SYNC, esai_priv->synchronous ? ESAI_SAICR_SYNC : 0); - /* Set a default slot number -- 2 */ + /* Set slots count */ regmap_update_bits(esai_priv->regmap, REG_ESAI_TCCR, - ESAI_xCCR_xDC_MASK, ESAI_xCCR_xDC(2)); + ESAI_xCCR_xDC_MASK, + ESAI_xCCR_xDC(esai_priv->slots)); regmap_update_bits(esai_priv->regmap, REG_ESAI_RCCR, - ESAI_xCCR_xDC_MASK, ESAI_xCCR_xDC(2)); + ESAI_xCCR_xDC_MASK, + ESAI_xCCR_xDC(esai_priv->slots)); } return 0; -- 2.26.2

3 2

[PATCH 0/2] soundwire: bus: handle errors in clock stop/start sequences
by Bard Liao 02 Apr '21

02 Apr '21

If a device lost sync and can no longer ACK a command, it may not be able to enter a lower-power state but it will still be able to resync when the clock restarts. In those cases, we want to continue with the clock stop sequence. This patch modifies the behavior when -ENODATA is received, with the error level demoted to a dev_dbg() since it's a recoverable issue. For consistency the log messages are also modified to be unique and self-explanatory, and missing logs are also added on clock stop exit. Pierre-Louis Bossart (2): soundwire: add macro to selectively change error levels soundwire: bus: handle errors in clock stop/start sequences drivers/soundwire/bus.c | 70 +++++++++++++++++++---------------------- drivers/soundwire/bus.h | 8 +++++ 2 files changed, 40 insertions(+), 38 deletions(-) -- 2.17.1

4 10

[PATCH] ASoC: Intel: Boards: cml_da7219_max98390: add capture stream for echo reference
by mac.chiang＠intel.com 01 Apr '21

01 Apr '21

From: Mac Chiang <mac.chiang(a)intel.com> enable speaker capture dai link for feedback path Signed-off-by: Mac Chiang <mac.chiang(a)intel.com> --- sound/soc/intel/boards/bxt_da7219_max98357a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c index 0c0a7178..9ffef39 100644 --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c @@ -813,6 +813,7 @@ static int broxton_audio_probe(struct platform_device *pdev) if (ctx->spkamp == SPKAMP_MAX98390) { broxton_dais[i].codecs = max98390_codec; broxton_dais[i].num_codecs = ARRAY_SIZE(max98390_codec); + broxton_dais[i].dpcm_capture = 1; } } /* DIALOG_CODEC is connected to SSP0 */ -- 2.7.4

3 2