March 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: soc-core: Prevent warning if no DMI table is present
by Jon Hunter 03 Mar '21

03 Mar '21

Many systems do not provide a DMI table and on these systems a warning, such as the following, is printed on boot ... WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name! If DMI support is enabled in the kernel, there is no simple way to detect if a DMI table is table or not. Note that the variable 'dmi_available' is not exported and so cannot be used by kernel modules. It could be possible to have every ASoC sound card driver set the long name to avoid the above message, but it might be intentional for the long name, that we fall back to using the sound card name. Therefore, make this a debug print by default to avoid the warning. Signed-off-by: Jon Hunter <jonathanh(a)nvidia.com> --- sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index f6d4e99b590c..f1189e7c1fcc 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1576,7 +1576,7 @@ int snd_soc_set_dmi_name(struct snd_soc_card *card, const char *flavour) /* make up dmi long name as: vendor-product-version-board */ vendor = dmi_get_system_info(DMI_BOARD_VENDOR); if (!vendor || !is_dmi_valid(vendor)) { - dev_warn(card->dev, "ASoC: no DMI vendor name!\n"); + dev_dbg(card->dev, "ASoC: no DMI vendor name!\n"); return 0; } -- 2.25.1

3 3

[PATCH v5 1/1] ASoC: dpcm: acquire dpcm_lock in dpcm_do_trigger()
by Gyeongtaek Lee 03 Mar '21

03 Mar '21

If stop by underrun and DPCM BE disconnection is run simultaneously, data abort can be occurred by the sequence below. CPU0 CPU1 dpcm_be_dai_trigger(): dpcm_be_disconnect(): for_each_dpcm_be(fe, stream, dpcm) { spin_lock_irqsave(&fe->card->dpcm_lock, flags); list_del(&dpcm->list_be); list_del(&dpcm->list_fe); spin_unlock_irqrestore(&fe->card->dpcm_lock, flags); kfree(dpcm); struct snd_soc_pcm_runtime *be = dpcm->be; <-- Accessing freed memory To prevent this situation, dpcm_lock should be acquired during iteration of dpcm list in dpcm_be_dai_trigger(). Signed-off-by: Gyeongtaek Lee <gt82.lee(a)samsung.com> Cc: stable(a)vger.kernel.org --- include/sound/soc-dpcm.h | 5 ++++ sound/soc/soc-pcm.c | 59 +++++++++++++++++++++++++++++++++------- 2 files changed, 54 insertions(+), 10 deletions(-) diff --git a/include/sound/soc-dpcm.h b/include/sound/soc-dpcm.h index 0f6c50b17bba..599cd6054bc3 100644 --- a/include/sound/soc-dpcm.h +++ b/include/sound/soc-dpcm.h @@ -103,6 +103,11 @@ struct snd_soc_dpcm_runtime { int trigger_pending; /* trigger cmd + 1 if pending, 0 if not */ }; +struct snd_soc_dpcm_rtd_list { + int num_rtds; + struct snd_soc_pcm_runtime *rtds[0]; +}; + #define for_each_dpcm_fe(be, stream, _dpcm) \ list_for_each_entry(_dpcm, &(be)->dpcm[stream].fe_clients, list_fe) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 14d85ca1e435..ccda0f77e827 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2028,15 +2028,51 @@ static int dpcm_fe_dai_hw_params(struct snd_pcm_substream *substream, return ret; } +static int dpcm_be_list_create(struct snd_soc_pcm_runtime *fe, int stream, + struct snd_soc_dpcm_rtd_list **be_list) +{ + struct snd_soc_dpcm *dpcm; + unsigned long flags; + int size, i, ret = 0; + + spin_lock_irqsave(&fe->card->dpcm_lock, flags); + + size = 0; + for_each_dpcm_be(fe, stream, dpcm) + size++; + + *be_list = kzalloc(struct_size(*be_list, rtds, size), GFP_ATOMIC); + if (*be_list) { + i = 0; + for_each_dpcm_be(fe, stream, dpcm) + (*be_list)->rtds[i++] = dpcm->be; + + if (i != size) + dev_err(fe->dev, "ASoC: abnormal change in be clients: %d -> %d\n", + size, i); + + (*be_list)->num_rtds = i; + } else { + ret = -ENOMEM; + } + + spin_unlock_irqrestore(&fe->card->dpcm_lock, flags); + + return ret; +} + int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, int cmd) { - struct snd_soc_dpcm *dpcm; - int ret = 0; + struct snd_soc_dpcm_rtd_list *be_list; + int i, ret = 0; - for_each_dpcm_be(fe, stream, dpcm) { + ret = dpcm_be_list_create(fe, stream, &be_list); + if (ret < 0) + return ret; - struct snd_soc_pcm_runtime *be = dpcm->be; + for (i = 0; i < be_list->num_rtds; i++) { + struct snd_soc_pcm_runtime *be = be_list->rtds[i]; struct snd_pcm_substream *be_substream = snd_soc_dpcm_get_substream(be, stream); @@ -2056,7 +2092,7 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, ret = soc_pcm_trigger(be_substream, cmd); if (ret) - return ret; + break; be->dpcm[stream].state = SND_SOC_DPCM_STATE_START; break; @@ -2066,7 +2102,7 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, ret = soc_pcm_trigger(be_substream, cmd); if (ret) - return ret; + break; be->dpcm[stream].state = SND_SOC_DPCM_STATE_START; break; @@ -2076,7 +2112,7 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, ret = soc_pcm_trigger(be_substream, cmd); if (ret) - return ret; + break; be->dpcm[stream].state = SND_SOC_DPCM_STATE_START; break; @@ -2090,7 +2126,7 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, ret = soc_pcm_trigger(be_substream, cmd); if (ret) - return ret; + break; be->dpcm[stream].state = SND_SOC_DPCM_STATE_STOP; break; @@ -2103,7 +2139,7 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, ret = soc_pcm_trigger(be_substream, cmd); if (ret) - return ret; + break; be->dpcm[stream].state = SND_SOC_DPCM_STATE_SUSPEND; break; @@ -2116,13 +2152,16 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, ret = soc_pcm_trigger(be_substream, cmd); if (ret) - return ret; + break; be->dpcm[stream].state = SND_SOC_DPCM_STATE_PAUSED; break; } + if (ret < 0) + break; } + kfree(be_list); return ret; } EXPORT_SYMBOL_GPL(dpcm_be_dai_trigger); -- 2.21.0

2 1

[PATCH 0/3] ALSA: digigram: fix kernel-doc warnings
by Pierre-Louis Bossart 03 Mar '21

03 Mar '21

make W=1 reports these warnings with v5.12-rc1. Pierre-Louis Bossart (3): ALSA: vx: fix kernel-doc warning ALSA: pci: mixart: fix kernel-doc warning ALSA: pci: vx222: fix kernel-doc warning sound/drivers/vx/vx_core.c | 2 +- sound/pci/mixart/mixart_hwdep.c | 3 ++- sound/pci/vx222/vx222_ops.c | 10 +++++----- 3 files changed, 8 insertions(+), 7 deletions(-) -- 2.25.1

2 4

[PATCH] ALSA: hda/realtek: Add quirk for Intel NUC 10
by Werner Sembach 03 Mar '21

03 Mar '21

ALSA: hda/realtek: Add quirk for Intel NUC 10 This adds a new SND_PCI_QUIRK(...) and applies it to the Intel NUC 10 devices. This fixes the issue of the devices not having audio input and output on the headset jack because the kernel does not recognize when something is plugged in. The new quirk was inspired by the quirk for the Intel NUC 8 devices, but it turned out that the NUC 10 uses another pin. This information was acquired by black box testing likely pins. Co-developed-by: Eckhart Mohr <e.mohr(a)tuxedocomputers.com> Signed-off-by: Eckhart Mohr <e.mohr(a)tuxedocomputers.com> Signed-off-by: Werner Sembach <wse(a)tuxedocomputers.com> Cc: <stable(a)vger.kernel.org> --- Resend of this patch with git send-email, because last patch got tabs replaced with spaces. >From d281364b8ca6c054a0e5ce20caa599bf7d08160d Mon Sep 17 00:00:00 2001 From: Werner Sembach <wse(a)tuxedocomputers.com> Date: Fri, 26 Feb 2021 13:54:30 +0100 Subject: [PATCH] Fix Intel NUC10 no output and input on headset jack --- sound/pci/hda/patch_realtek.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 290645516313..c14d624dbaf1 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6362,6 +6362,7 @@ enum { ALC269_FIXUP_LEMOTE_A1802, ALC269_FIXUP_LEMOTE_A190X, ALC256_FIXUP_INTEL_NUC8_RUGGED, + ALC256_FIXUP_INTEL_NUC10, ALC255_FIXUP_XIAOMI_HEADSET_MIC, ALC274_FIXUP_HP_MIC, ALC274_FIXUP_HP_HEADSET_MIC, @@ -7744,6 +7745,15 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MODE }, + [ALC256_FIXUP_INTEL_NUC10] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE + }, [ALC255_FIXUP_XIAOMI_HEADSET_MIC] = { .type = HDA_FIXUP_VERBS, .v.verbs = (const struct hda_verb[]) { @@ -8183,6 +8193,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1c06, 0x2013, "Lemote A1802", ALC269_FIXUP_LEMOTE_A1802), SND_PCI_QUIRK(0x1c06, 0x2015, "Lemote A190X", ALC269_FIXUP_LEMOTE_A190X), SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED), + SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10), #if 0 /* Below is a quirk table taken from the old code. -- 2.25.1

2 1

[PATCH v5 0/1] ASoC: dpcm: acquire dpcm_lock in dpcm_do_trigger()
by Gyeongtaek Lee 03 Mar '21

03 Mar '21

On Wed, 2021-02-17 16:29, Takashi Iwai wrote: >On Wed, 17 Feb 2021 05:31:49 +0100, >Gyeongtaek Lee wrote: >> >> If stop by underrun and DPCM BE disconnection is run simultaneously, >> data abort can be occurred by the sequence below. >> >> CPU0 CPU1 >> dpcm_be_dai_trigger(): dpcm_be_disconnect(): >> >> for_each_dpcm_be(fe, stream, dpcm) { >> >> spin_lock_irqsave(&fe->card->dpcm_lock, flags); >> list_del(&dpcm->list_be); >> list_del(&dpcm->list_fe); >> spin_unlock_irqrestore(&fe->card->dpcm_lock, flags); >> kfree(dpcm); >> >> struct snd_soc_pcm_runtime *be = dpcm->be; <-- Accessing freed memory >> >> To prevent this situation, dpcm_lock should be acquired during >> iteration of dpcm list in dpcm_be_dai_trigger(). > >I don't think we can apply spin lock there blindly. There is >non-atomic PCM that must not take a spin lock there, too. Hi, Takashi I fixed the patch to hold dpcm_lock during accessing dpcm related data only, not on the trigger callback of driver. Thank you. Gyeongtaek Lee > > >thanks, > >Takashi > Gyeongtaek Lee (1): ASoC: dpcm: acquire dpcm_lock in dpcm_do_trigger() include/sound/soc-dpcm.h | 5 ++++ sound/soc/soc-pcm.c | 59 +++++++++++++++++++++++++++++++++------- 2 files changed, 54 insertions(+), 10 deletions(-) base-commit: fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8 -- 2.21.0

1 0

Re: [PATCH] ASoC: wm8960: Remove bitclk relax condition
by S.j. Wang 03 Mar '21

03 Mar '21

> > > > Using a higher bitclk then expected doesn't always work. > > Here is an example: > > > > aplay -Dhw:0,0 -d 5 -r 48000 -f S24_LE -c 2 audio48k24b2c.wav > > > > In this case, the required bitclk is 48000 * 24 * 2 = 2304000 but the > > closest bitclk that can be derived is 3072000. Since the clock is > > faster than expected, it will start to send bytes from the next > > channel so the sound will be corrupted. > > > > Fixes: 82bab88910ee ("ASoC: codec: wm8960: Relax bit clock computation > > when using PLL") > > Fixes: 3c01b9ee2ab9 ("ASoC: codec: wm8960: Relax bit clock > > computation") > > Signed-off-by: Daniel Baluta <daniel.baluta(a)nxp.com> > > Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> > > --- > > I think this is probably going to need a much more involved fix. > The problem is that there are systems that depend on this behaviour, so you > can't just flat out revert it. And to be fair the I2S specification says that bit > clock can run at a higher rate than required for the data, so the behaviour is > correct as well. > > Probably the best solution here is to add additional contraints from the > machine driver on which rates/bit depths/channels are supported. > Just double check the issue, the real reason is in below: The call sequence in wm8960_configure_clocking is ret = wm8960_configure_sysclk(); if (ret >= 0) goto configure_clock; .... ret = wm8960_configure_pll(); configure_clock: ... wm8960_configure_sysclk is called before wm8960_configure_pll, as there is bitclk relax on both functions, so wm8960_configure_sysclk always return success, then wm8960_configure_pll() never be called. So bitclk relax condition should be removed in wm8960_configure_sysclk, That wm8960_configure_pll can be called, and there is also bitclk relax function in wm8960_configure_pll. I will update and resend this patch. Best regards Wang shengjiu

1 0

Fiio M3K: Failed to find a working profile
by GitHub issues - edited 03 Mar '21

03 Mar '21

alsa-project/alsa-lib issue #123 was edited from x1unix: Hello, I have a [Fiio M3K](https://fiio.com/m3k) player which I often use as an external USB DAC. It worked well with Pipewire, but I had some other issues with Pipewire so I had to rollback to PulseAudio. Unfortunately, PulseAudio and module-alsa-card cannot setup this device, so it doesn't work. Here is a small portion of PulseAudio log (full log is available at link below): ``` E: [pulseaudio] module-alsa-card.c: Failed to find a working profile. E: [pulseaudio] module.c: Failed to load module "module-alsa-card" (argument: "device_id="2" name="usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00" card_name="alsa_card.usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00" namereg_fail=false tsched=yes fixed_latency_range=no ignore_dB=no deferred_volume=yes use_ucm=yes avoid_resampling=no card_properties="module-udev-detect.discovered=1""): initialization failed. I: [pulseaudio] module-udev-detect.c: Card /devices/pci0000:00/0000:00:08.1/0000:0b:00.3/usb5/5-1/5-1:1.0/sound/card2 (alsa_card.usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00) failed to load module. D: [pulseaudio] module-udev-detect.c: /dev/snd/controlC2 is accessible: yes D: [pulseaudio] module-udev-detect.c: /devices/pci0000:00/0000:00:08.1/0000:0b:00.3/usb5/5-1/5-1:1.0/sound/card2 is busy: no ``` I'm using ArchLinux with Linux 5.11.2 and PulseAudio 14.2. **Logs and debug info** USB device in `lsusb` output: ``` Bus 005 Device 022: ID 2972:0044 FiiO Electronics Technology FiiO M3K ``` aplay, pulseaudio debug log and other info I've posted as gist: https://gist.github.com/x1unix/dae3fb810ac499cc63362a805220968f Issue URL : https://github.com/alsa-project/alsa-lib/issues/123 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Fiio M3K: Failed to find a working profile
by GitHub issues - edited 03 Mar '21

03 Mar '21

alsa-project/alsa-lib issue #123 was edited from x1unix: Hello, I have a [Fiio M3K](https://fiio.com/m3k) player which I often use as an external USB DAC. It worked well with Pipewire, but I had some other issues with Pipewire so I had to rollback to PulseAudio. Unfortunately, PulseAudio and module-alsa-card cannot setup this device, so it doesn't work. Here is a small portion of PulseAudio log (full log is available at link below): ``` E: [pulseaudio] module-alsa-card.c: Failed to find a working profile. E: [pulseaudio] module.c: Failed to load module "module-alsa-card" (argument: "device_id="2" name="usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00" card_name="alsa_card.usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00" namereg_fail=false tsched=yes fixed_latency_range=no ignore_dB=no deferred_volume=yes use_ucm=yes avoid_resampling=no card_properties="module-udev-detect.discovered=1""): initialization failed. I: [pulseaudio] module-udev-detect.c: Card /devices/pci0000:00/0000:00:08.1/0000:0b:00.3/usb5/5-1/5-1:1.0/sound/card2 (alsa_card.usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00) failed to load module. D: [pulseaudio] module-udev-detect.c: /dev/snd/controlC2 is accessible: yes D: [pulseaudio] module-udev-detect.c: /devices/pci0000:00/0000:00:08.1/0000:0b:00.3/usb5/5-1/5-1:1.0/sound/card2 is busy: no ``` I'm using ArchLinux with Linux 5.11.2 and PulseAudio 14.2. **Logs and debug info** aplay, pulseaudio debug log and other info I've posted as gist: https://gist.github.com/x1unix/dae3fb810ac499cc63362a805220968f Issue URL : https://github.com/alsa-project/alsa-lib/issues/123 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Fiio M3K: Failed to find a working profile
by GitHub issues - edited 03 Mar '21

03 Mar '21

alsa-project/alsa-lib issue #123 was edited from x1unix: Hello, I have a [Fiio M3K](https://fiio.com/m3k) player which I often use as an external USB DAC. It worked well with Pipewire, but I had some other issues with Pipewire so I had to rollback to PulseAudio. Unfortunately, PulseAudio and module-alsa-card cannot setup this device, so it doesn't work. Here is a small portion of PulseAudio log (full log is available at link below): ``` E: [pulseaudio] module-alsa-card.c: Failed to find a working profile. E: [pulseaudio] module.c: Failed to load module "module-alsa-card" (argument: "device_id="2" name="usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00" card_name="alsa_card.usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00" namereg_fail=false tsched=yes fixed_latency_range=no ignore_dB=no deferred_volume=yes use_ucm=yes avoid_resampling=no card_properties="module-udev-detect.discovered=1""): initialization failed. I: [pulseaudio] module-udev-detect.c: Card /devices/pci0000:00/0000:00:08.1/0000:0b:00.3/usb5/5-1/5-1:1.0/sound/card2 (alsa_card.usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00) failed to load module. D: [pulseaudio] module-udev-detect.c: /dev/snd/controlC2 is accessible: yes D: [pulseaudio] module-udev-detect.c: /devices/pci0000:00/0000:00:08.1/0000:0b:00.3/usb5/5-1/5-1:1.0/sound/card2 is busy: no ``` I'm using ArchLinux and Linux 5.11.2 and PulseAudio 14.2. **Logs and debug info** aplay, pulseaudio debug log and other info I've posted as gist: https://gist.github.com/x1unix/dae3fb810ac499cc63362a805220968f Issue URL : https://github.com/alsa-project/alsa-lib/issues/123 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Fiio M3K: Failed to find a working profile
by GitHub issues - opened 03 Mar '21

03 Mar '21

alsa-project/alsa-lib issue #123 was opened from x1unix: Hello, I have a [Fiio M3K](https://fiio.com/m3k) player which I often use as an external USB DAC. It worked well with Pipewire, but I had some other issues with Pipewire so I had to rollback to PulseAudio. Unfortunately, PulseAudio and module-alsa-card cannot setup this device, so it doesn't work. Here is a small portion of PulseAudio log (full log is available at link below): ``` E: [pulseaudio] module-alsa-card.c: Failed to find a working profile. E: [pulseaudio] module.c: Failed to load module "module-alsa-card" (argument: "device_id="2" name="usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00" card_name="alsa_card.usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00" namereg_fail=false tsched=yes fixed_latency_range=no ignore_dB=no deferred_volume=yes use_ucm=yes avoid_resampling=no card_properties="module-udev-detect.discovered=1""): initialization failed. I: [pulseaudio] module-udev-detect.c: Card /devices/pci0000:00/0000:00:08.1/0000:0b:00.3/usb5/5-1/5-1:1.0/sound/card2 (alsa_card.usb-GuangZhou_FiiO_Electronics_Technology_Co.__Ltd._FiiO_M3K_FiiO_M3K-00) failed to load module. D: [pulseaudio] module-udev-detect.c: /dev/snd/controlC2 is accessible: yes D: [pulseaudio] module-udev-detect.c: /devices/pci0000:00/0000:00:08.1/0000:0b:00.3/usb5/5-1/5-1:1.0/sound/card2 is busy: no ``` I'm using ArchLinux and Linux 5.11.2. **Logs and debug info** aplay, pulseaudio debug log and other info I've posted as gist: https://gist.github.com/x1unix/dae3fb810ac499cc63362a805220968f Issue URL : https://github.com/alsa-project/alsa-lib/issues/123 Repository URL: https://github.com/alsa-project/alsa-lib

1 0