December 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH RESEND 1/2] ASoC: cs4265: Fix part number ID error message
by Fabio Estevam 29 Dec '21

29 Dec '21

From: Fabio Estevam <festevam(a)denx.de> The Chip ID - Register 01h contains the following description as per the CS4265 datasheet: "Bits 7 through 4 are the part number ID, which is 1101b (0Dh)" The current error message is incorrect as it prints CS4265_CHIP_ID, which is the register number, instead of printing the expected part number ID value. To make it clearer, also do a shift by 4, so that the error message would become: [ 4.218083] cs4265 1-004f: CS4265 Part Number ID: 0x0 Expected: 0xd Signed-off-by: Fabio Estevam <festevam(a)denx.de> --- Sorry, I am resending because I was not subscribed in the alsa-list from the other e-mail account. sound/soc/codecs/cs4265.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c index cffd6111afac..b89002189a2b 100644 --- a/sound/soc/codecs/cs4265.c +++ b/sound/soc/codecs/cs4265.c @@ -611,8 +611,8 @@ static int cs4265_i2c_probe(struct i2c_client *i2c_client, if (devid != CS4265_CHIP_ID_VAL) { ret = -ENODEV; dev_err(&i2c_client->dev, - "CS4265 Device ID (%X). Expected %X\n", - devid, CS4265_CHIP_ID); + "CS4265 Part Number ID: 0x%x Expected: 0x%x\n", + devid >> 4, CS4265_CHIP_ID_VAL >> 4); return ret; } dev_info(&i2c_client->dev, -- 2.25.1

3 4

[patch] speaker-test/samples/sample_map.csv is not accurate, which does not affect operation of speaker-test
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #133 was edited from ZjYwMj: With alsa-utils 1.2.6: The [commit](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1… in question. ``` --- a/usr/share/alsa/speaker-test/sample_map.csv 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/speaker-test/sample_map.csv 2021-12-28 19:48:02.390305957 +0000 @@ -1,2 +1,2 @@ -0, "Front Left", "/usr/share/alsa/samples/Front_Left.wav" -1, "Front Right", "/usr/share/alsa/samples/Front_Right.wav" +0, "Front Left", "/usr/share/sounds/alsa/Front_Left.wav" +1, "Front Right", "/usr/share/sounds/alsa/Front_Right.wav" ``` The directory ``/usr/share/alsa/samples/`` does not exist. It sounds as if ``speaker-test -t wav`` plays the files mentioned in the diff. This inaccuracy does not affect the operation of ``speaker-test``. Do the paths to the wav files hard coded within ``speaker-test``? Does only their ``basename`` counts? Still, I find it a minor bug. Why is ``/usr/share/alsa/speaker-test/sample_map.csv`` distributed anyway? Am I misunderstanding [Install sound samples to correct places](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1… Is it for informational purposes? Was it used in the past, and no longer serves its purpose? Is it planed to be used in the future? Is it something else? [speaker-test.c:745](https://github.com/alsa-project/alsa-utils/blob/00be486… and [746](https://github.com/alsa-project/alsa-utils/blob/00be486131129a6d209de6… has the ``basename``s hardcoded. And there is also the default value for ``speaker-test --wavdir`` of ``/usr/share/sounds/alsa``. Issue URL : https://github.com/alsa-project/alsa-utils/issues/133 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[patch] speaker-test/samples/sample_map.csv is not accurate, which does not affect operation of speaker-test
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #133 was edited from ZjYwMj: With alsa-utils 1.2.6: ``` --- a/usr/share/alsa/speaker-test/sample_map.csv 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/speaker-test/sample_map.csv 2021-12-28 19:48:02.390305957 +0000 @@ -1,2 +1,2 @@ -0, "Front Left", "/usr/share/alsa/samples/Front_Left.wav" -1, "Front Right", "/usr/share/alsa/samples/Front_Right.wav" +0, "Front Left", "/usr/share/sounds/alsa/Front_Left.wav" +1, "Front Right", "/usr/share/sounds/alsa/Front_Right.wav" ``` The directory ``/usr/share/alsa/samples/`` does not exist. It sounds as if ``speaker-test -t wav`` plays the files mentioned in the diff. This inaccuracy does not affect the operation of ``speaker-test``. Do the paths to the wav files hard coded within ``speaker-test``? Does only their ``basename`` counts? Still, I find it a minor bug. Why is ``/usr/share/alsa/speaker-test/sample_map.csv`` distributed anyway? Am I misunderstanding [Install sound samples to correct places](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1… Is it for informational purposes? Was it used in the past, and no longer serves its purpose? Is it planed to be used in the future? Is it something else? [speaker-test.c:745](https://github.com/alsa-project/alsa-utils/blob/00be486… and [746](https://github.com/alsa-project/alsa-utils/blob/00be486131129a6d209de6… has the ``basename``s hardcoded. And there is also the default value for ``speaker-test --wavdir`` of ``/usr/share/sounds/alsa``. Issue URL : https://github.com/alsa-project/alsa-utils/issues/133 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[patch] alsa-utils/alsactl/init/00main:1, which is a comment and contains a typo
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #132 was edited from ZjYwMj: With alsa-utils 1.2.6: This should probably get applied to [00main:1](https://github.com/alsa-project/alsa-utils/blob/90f59671784a7e47b…. ``` --- a/usr/share/alsa/init/00main 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/init/00main 2021-12-28 17:04:36.835174838 +0000 @@ -1,4 +1,4 @@ -# This is toplevel configuration for for 'alsactl init'. +# This is the toplevel configuration file for 'alsactl init'. # See 'man alsactl_init' for syntax. # set root device directory in sysfs for soundcard for ATTR{} command ``` Issue URL : https://github.com/alsa-project/alsa-utils/issues/132 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[patch] [00main:1](https://github.com/alsa-project/alsa-utils/blob/90f59671784a7e47b40485095cd66892d4840ed7/alsactl/init/00main#L1), which is a comment and contains a typo
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #132 was edited from ZjYwMj: With alsa-utils 1.2.6: This should probably get applied to [00main:1](https://github.com/alsa-project/alsa-utils/blob/90f59671784a7e47b…. ``` --- a/usr/share/alsa/init/00main 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/init/00main 2021-12-28 17:04:36.835174838 +0000 @@ -1,4 +1,4 @@ -# This is toplevel configuration for for 'alsactl init'. +# This is the toplevel configuration file for 'alsactl init'. # See 'man alsactl_init' for syntax. # set root device directory in sysfs for soundcard for ATTR{} command ``` Issue URL : https://github.com/alsa-project/alsa-utils/issues/132 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[patch] [00main:1](ainhttps://github.com/alsa-project/alsa-utils/blob/90f59671784a7e47b40485095cd66892d4840ed7/alsactl/init/00main#L1), which is a comment and contains a typo
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #132 was edited from ZjYwMj: With alsa-utils 1.2.6: This should probably get applied to [00main:1](https://github.com/alsa-project/alsa-utils/blob/90f59671784a7e47b…. ``` --- a/usr/share/alsa/init/00main 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/init/00main 2021-12-28 17:04:36.835174838 +0000 @@ -1,4 +1,4 @@ -# This is toplevel configuration for for 'alsactl init'. +# This is the toplevel configuration file for 'alsactl init'. # See 'man alsactl_init' for syntax. # set root device directory in sysfs for soundcard for ATTR{} command ``` Issue URL : https://github.com/alsa-project/alsa-utils/issues/132 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[patch] 1st line of /usr/share/alsa/init/00main, which is a comment and contains a typo
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #132 was edited from ZjYwMj: With alsa-utils 1.2.6: This should probably get applied to [00main:1](https://github.com/alsa-project/alsa-utils/blob/90f59671784a7e47b…. ``` --- a/usr/share/alsa/init/00main 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/init/00main 2021-12-28 17:04:36.835174838 +0000 @@ -1,4 +1,4 @@ -# This is toplevel configuration for for 'alsactl init'. +# This is the toplevel configuration file for 'alsactl init'. # See 'man alsactl_init' for syntax. # set root device directory in sysfs for soundcard for ATTR{} command ``` Issue URL : https://github.com/alsa-project/alsa-utils/issues/132 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[patch] /usr/share/alsa/speaker-test/sample_map.csv is not accurate, which does not affect operation of speaker-test
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #133 was edited from ZjYwMj: With alsa-utils 1.2.6: ``` --- a/usr/share/alsa/speaker-test/sample_map.csv 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/speaker-test/sample_map.csv 2021-12-28 19:48:02.390305957 +0000 @@ -1,2 +1,2 @@ -0, "Front Left", "/usr/share/alsa/samples/Front_Left.wav" -1, "Front Right", "/usr/share/alsa/samples/Front_Right.wav" +0, "Front Left", "/usr/share/sounds/alsa/Front_Left.wav" +1, "Front Right", "/usr/share/sounds/alsa/Front_Right.wav" ``` The directory ``/usr/share/alsa/samples/`` does not exist. It sounds as if ``speaker-test -t wav`` plays the files mentioned in the diff. This inaccuracy does not affect the operation of ``speaker-test``. Do the paths to the wav files hard coded within ``speaker-test``? Does only their ``basename`` counts? Still, I find it a minor bug. Why is ``/usr/share/alsa/speaker-test/sample_map.csv`` distributed anyway? Am I misunderstanding [Install sound samples to correct places](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1… Is it for informational purposes? Was it used in the past, and no longer serves its purpose? Is it planed to be used in the future? Is it something else? [speaker-test.c:745](https://github.com/alsa-project/alsa-utils/blob/00be486… and [746](https://github.com/alsa-project/alsa-utils/blob/00be486131129a6d209de6… has the ``basename``s hardcoded. And there is also the default value for ``speaker-test --wavdir`` of ``/usr/share/sounds/alsa``. Issue URL : https://github.com/alsa-project/alsa-utils/issues/133 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[patch] /usr/share/alsa/speaker-test/sample_map.csv is not accurate, which does not affect operation of speaker-test
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #133 was edited from ZjYwMj: With alsa-utils 1.2.6: ``` --- a/usr/share/alsa/speaker-test/sample_map.csv 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/speaker-test/sample_map.csv 2021-12-28 19:48:02.390305957 +0000 @@ -1,2 +1,2 @@ -0, "Front Left", "/usr/share/alsa/samples/Front_Left.wav" -1, "Front Right", "/usr/share/alsa/samples/Front_Right.wav" +0, "Front Left", "/usr/share/sounds/alsa/Front_Left.wav" +1, "Front Right", "/usr/share/sounds/alsa/Front_Right.wav" ``` The directory ``/usr/share/alsa/samples/`` does not exist. It sounds as if ``speaker-test -t wav`` plays the files mentioned in the diff. This inaccuracy does not affect the operation of ``speaker-test``. Do the paths to the wav files hard coded within ``speaker-test``? Does only their ``basename`` counts? Still, I find it a minor bug. Why is ``/usr/share/alsa/speaker-test/sample_map.csv`` distributed anyway? Am I misunderstanding [Install sound samples to correct places](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1… Is it for informational purposes? Was it used in the past, and no longer serves its purpose? Is it planed to be used in the future? Is it something else? [speaker-test.c](https://github.com/alsa-project/alsa-utils/blob/00be4861311… and 746 has the ``basename``s hardcoded. And there is also the default value for ``speaker-test --wavdir`` of ``/usr/share/sounds/alsa``. Issue URL : https://github.com/alsa-project/alsa-utils/issues/133 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[patch] /usr/share/alsa/speaker-test/sample_map.csv is not accurate, which does not affect operation of speaker-test
by GitHub issues - edited 29 Dec '21

29 Dec '21

alsa-project/alsa-utils issue #133 was edited from ZjYwMj: With alsa-utils 1.2.6: ``` --- a/usr/share/alsa/speaker-test/sample_map.csv 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/speaker-test/sample_map.csv 2021-12-28 19:48:02.390305957 +0000 @@ -1,2 +1,2 @@ -0, "Front Left", "/usr/share/alsa/samples/Front_Left.wav" -1, "Front Right", "/usr/share/alsa/samples/Front_Right.wav" +0, "Front Left", "/usr/share/sounds/alsa/Front_Left.wav" +1, "Front Right", "/usr/share/sounds/alsa/Front_Right.wav" ``` The directory ``/usr/share/alsa/samples/`` does not exist. It sounds as if ``speaker-test -t wav`` plays the files mentioned in the diff. This inaccuracy does not affect the operation of ``speaker-test``. Do the paths to the wav files hard coded within ``speaker-test``? Does only their ``basename`` counts? Still, I find it a minor bug. Why is ``/usr/share/alsa/speaker-test/sample_map.csv`` distributed anyway? Am I misunderstanding [Install sound samples to correct places](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1… Is it for informational purposes? Was it used in the past, and no longer serves its purpose? Is it planed to be used in the future? Is it something else? [speaker-test.c](https://github.com/alsa-project/alsa-utils/blob/00be4861311… has the ``basename``s hardcoded. And there is also the default value for ``speaker-test --wavdir`` of ``/usr/share/sounds/alsa``. Issue URL : https://github.com/alsa-project/alsa-utils/issues/133 Repository URL: https://github.com/alsa-project/alsa-utils

1 0