November 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH v3 0/2] Codec driver for TLV320ADC3001 and 3101
by Ricard Wanderlof 04 Nov '21

04 Nov '21

This is a codec driver for the TLV320ADC3001 and TLV320ADC3101 2 channel audio ADC chips from Texas Instruments. Based on an old driver for these chips that I was referred to by Texas Instruments, but which apparently was never upstreamed, I've taken patches from various incarnations, ported them and augmented them with various new features in order to make a working driver. There is currently no support for the on-chip "miniDSP". Although the TLV320ADC3001 and TLV320ADC3101 have similarities with other TI codec chips for which there are existing drivers, upon closer inspection I decided the differences were too great to warrant attempting to modify an existing driver, especially without access to all supported chips and resources for testing them all. There are certainly things that could be improved, among others in the area of PLL register value calculations, but it has been tested on the Axis ARTPEC-8 platform and has been found to work satisfactorily at least with a TLV320ADC3101 operating as an I2S slave at 48 kHz with 32 bit bit depth, 1 or 2 channels, both with the on-chip PLL enabled and disabled. I have not tested this on a TLV320ADC3001 chip; in the original driver the only differences were related to the now-removed initialization code, so I've just retained the compatible strings for both chips. Limitations: - GPIO pins on chip can only be set up as outputs. - Using BCLK as an input to clock chain is supported by the hw but not by driver. Changes v2->v3: Fix a couple of issues reported by the kernel test robot (lkp(a)intel.com). Changes v1->v2: Large portions of the driver have been reworked from v1 based on remarks from Mark. More specifically: - Remove an unneeded #ifdef and EXPORT_SYMBOL_GPL. - Add ADC3XXX_ prefix to all macro names to avoid namespace contention. - Clean up certain macro names with mixed lower case - upper case names. - Do away with the D0..D7 macros representing bit values. - Fix general formatting: spaces before and after {, }, replace multi spaces with tabs, maximum 2 blank lines anywhere, and other minor issues. - Page register does not need to be volatile. - Rather than use 0 / -6dB enum for input attenuator, use standard TLV. - The dither offset control contains reserved values so use VALUE_ENUM instead of straight ENUM. - Replace vector of SOC_ENUMs with individual variables. - Fix ALSA control names: - Use Volume at the end of all gain controls, and remove "Gain" where applicable. - Use "Switch" at the end of all switch controls, either adding it or changing "switch" into "Switch" as applicable. - Switches and Volumes related to capture should be set up as such, so add "Capture" to widget names where appropriate. This is mostly important for the PGA Capture and Switch widgets, not just for consistency, but also because amixer simple Switch controls expect different names (cap/nocap instead of on/off) for control values for capture. - Make widget names have capital first letters for all consitutent words. - When resuming, the registers will not have changed, so no need to call snd_soc_component_cache_sync(). - Move reset gpio init to I2C probe - Remove needless _priv at end of private struct name. - Make hex constants lower case - _CBM_CFM/_CBS_CFS -> _CBP_CFP/_CBC_CFC - Instead of using device specific ALSA controls to control the two GPIO pins, use GPIOLIB. GPIO pin functions still can be set up in the devicetree as the pins can be used for other functions which are not GPIO related. - Limitation: The GPIO pins can only be used as outputs, even though the hardware alternatively supports using them as inputs. - Handle GPIO configs in a vector rather than separately. - Use more appropriate module_i2c_driver instead of generic module_init/module_exit. - Remove useless initialization data. - As the ADC mute function had no control, add it. - Clean up GPIO initialization which was done both in the I2C probe and in the component probe. - Remove probe, remove, suspend and resume callbacks, which either do not do anything at all anymore, or uselessly just do set_bias_level. - The PLL should not be configured in the devicetree, so move the corresponding definitions to tlv320adc3xxx.h where they can be picked up by a machine driver if needed. - Default to PLL AUTO mode. - Use "reset-gpios" instead of too-generic "gpios" for dt property for configuring codec reset pin. - Use function for printing PLL mode rather than macro. - dev_info is too verbose for most of the printouts, change them to dev_dbg. - Add support for configuring micbias voltage in DT. - Remove ALSA control for mic bias. - Move PLL and NADC, MADC divisor enable to DAPM, including 10 ms post PLL start up delay via POST_PMU event. - ADC is powered on using DAPM, so needless to do it in set_bias_level, thus remove it. - Let DAPM handle BCLK divisor enable. With this, we can remove set_bias_level as it doesn't do anything anymore. - Fix incorrect argument order to a snd_soc_component_update_bits call. - Although the chip itself can operate using BCLK as the clock source, either directly to the divider chain or via the PLL, this is not yet supported in the driver, so require the clocks property for the MCLK for now. - Move PLL rate structure out of .h file where it does not belong. /Ricard Ricard Wanderlöf (2): dt-bindings: sound: tlv320adc3xxx: New codec driver ASoC: codec: tlv320adc3xxx: New codec driver .../bindings/sound/ti,tlv320adc3xxx.yaml | 137 +++ include/dt-bindings/sound/tlv320adc3xxx.h | 28 + sound/soc/codecs/Kconfig | 7 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tlv320adc3xxx.c | 1071 +++++++++++++++++ sound/soc/codecs/tlv320adc3xxx.h | 379 ++++++ 6 files changed, 1624 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml create mode 100644 include/dt-bindings/sound/tlv320adc3xxx.h create mode 100644 sound/soc/codecs/tlv320adc3xxx.c create mode 100644 sound/soc/codecs/tlv320adc3xxx.h -- 2.20.1 -- Ricard Wolf Wanderlof ricardw(at)axis.com Axis Communications AB, Lund, Sweden www.axis.com Phone +46 46 272 2016 Fax +46 46 13 61 30

1 0

Creative Soundblaster AE-7 Headphones Issue
by Emre Fidan 04 Nov '21

04 Nov '21

Hi There, Headphones connected to Creative Soundblaster AE-7 are normally auto-detected on alsamixer, but sink shows the headphone port as not available. alsamixer can change speakers to headphones and vice-versa, however, the audio silences on the headphones after a couple of seconds unless you keep system sound settings/easyeffects/pavucontol opened or minimized. acpi_listen reports Line-In plugged/unplugged instead of headphones, trying to reassign the with hdajackretask does the sensing (acpi_listen shows headphones plugged/unplugged), however, no sound from headphones this time at all. Any suggestions? Thanks. -- Emre Fidan

1 0

HDA-Intel: fixes for Headphone+LO variant (Realtek ALC233)
by GitHub pull_request - opened 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf pull request #116 was opened from perexg: Issue: https://github.com/alsa-project/alsa-ucm-conf/issues/114 Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/116 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/116.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Intel SOF HDA: Lenovo m920sff support (Realtek ALC 233)
by GitHub issues - edited 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf issue #114 was edited from perexg: Description: An issue with the headphone detection (Speaker/Headphone auto-mute). More info: https://github.com/thesofproject/linux/issues/3088 and https://bugzilla.suse.com/show_bug.cgi?id=1188685 Mixer: ``` Simple mixer control 'Master',0 Simple mixer control 'Headphone',0 # Switch only Simple mixer control 'Headphone+LO',0 # Volume only Simple mixer control 'Speaker',0 Simple mixer control 'Front Mic',0 Simple mixer control 'Front Mic Boost',0 Simple mixer control 'Line Out',0 # Switch only Simple mixer control 'Mic',0 Simple mixer control 'Mic Boost',0 Simple mixer control 'IEC958',0 Simple mixer control 'IEC958',1 Simple mixer control 'IEC958',2 Simple mixer control 'Capture',0 Simple mixer control 'Auto-Mute Mode',0 Simple mixer control 'Dmic0',0 Simple mixer control 'Dmic1 2nd',0 Simple mixer control 'Loopback Mixing',0 Simple mixer control 'PGA1.0 1 Master',0 Simple mixer control 'PGA2.0 2 Master',0 Simple mixer control 'PGA3.0 3 Master',0 Simple mixer control 'PGA4.0 4 Master',0 Simple mixer control 'PGA7.0 7 Master',0 Simple mixer control 'PGA8.0 8 Master',0 Simple mixer control 'PGA9.0 9 Master',0 ``` Jacks: ``` name 'Mic Jack' name 'Front Mic Jack' name 'Line Out Jack' name 'Front Headphone Jack' name 'Speaker Phantom Jack' name 'HDMI/DP,pcm=3 Jack' name 'HDMI/DP,pcm=4 Jack' name 'HDMI/DP,pcm=5 Jack' ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/114 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Intel SOF HDA: Lenovo m920sff support (Realtek ALC 233)
by GitHub issues - edited 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf issue #114 was edited from perexg: Description: An issue with the headphone detection (Speaker/Headphone auto-mute). More info: https://github.com/thesofproject/linux/issues/3088 and https://bugzilla.suse.com/show_bug.cgi?id=1188685 ``` Simple mixer control 'Master',0 Simple mixer control 'Headphone',0 # Switch only Simple mixer control 'Headphone+LO',0 # Volume only Simple mixer control 'Speaker',0 Simple mixer control 'Front Mic',0 Simple mixer control 'Front Mic Boost',0 Simple mixer control 'Line Out',0 # Switch only Simple mixer control 'Mic',0 Simple mixer control 'Mic Boost',0 Simple mixer control 'IEC958',0 Simple mixer control 'IEC958',1 Simple mixer control 'IEC958',2 Simple mixer control 'Capture',0 Simple mixer control 'Auto-Mute Mode',0 Simple mixer control 'Dmic0',0 Simple mixer control 'Dmic1 2nd',0 Simple mixer control 'Loopback Mixing',0 Simple mixer control 'PGA1.0 1 Master',0 Simple mixer control 'PGA2.0 2 Master',0 Simple mixer control 'PGA3.0 3 Master',0 Simple mixer control 'PGA4.0 4 Master',0 Simple mixer control 'PGA7.0 7 Master',0 Simple mixer control 'PGA8.0 8 Master',0 Simple mixer control 'PGA9.0 9 Master',0 ``` ``` name 'Mic Jack' name 'Front Mic Jack' name 'Line Out Jack' name 'Front Headphone Jack' name 'Speaker Phantom Jack' name 'HDMI/DP,pcm=3 Jack' name 'HDMI/DP,pcm=4 Jack' name 'HDMI/DP,pcm=5 Jack' ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/114 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ALSA: hda/realtek: fix flexible_array.cocci warning
by Guo Zhengkui 04 Nov '21

04 Nov '21

Fix following coccicheck warnings: ./sound/pci/hda/patch_realtek.c:128:4-24: WARNING use flexible-array member instead. There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members” for these cases. The older style of one-element or zero-length arrays should no longer be used. Signed-off-by: Guo Zhengkui <guozhengkui(a)vivo.com> --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6322fac9e694..7935c363092e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -125,7 +125,7 @@ struct alc_spec { unsigned int pll_coef_idx, pll_coef_bit; unsigned int coef0; struct input_dev *kb_dev; - u8 alc_mute_keycode_map[1]; + u8 alc_mute_keycode_map[]; }; /* -- 2.20.1

2 1

Intel SOF HDA: Lenovo m920sff support (Realtek ALC 233)
by GitHub issues - edited 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf issue #114 was edited from perexg: More info: https://github.com/thesofproject/linux/issues/3088 ``` Simple mixer control 'Master',0 Simple mixer control 'Headphone',0 Simple mixer control 'Headphone+LO',0 Simple mixer control 'Speaker',0 Simple mixer control 'Front Mic',0 Simple mixer control 'Front Mic Boost',0 Simple mixer control 'Line Out',0 Simple mixer control 'Mic',0 Simple mixer control 'Mic Boost',0 Simple mixer control 'IEC958',0 Simple mixer control 'IEC958',1 Simple mixer control 'IEC958',2 Simple mixer control 'Capture',0 Simple mixer control 'Auto-Mute Mode',0 Simple mixer control 'Dmic0',0 Simple mixer control 'Dmic1 2nd',0 Simple mixer control 'Loopback Mixing',0 Simple mixer control 'PGA1.0 1 Master',0 Simple mixer control 'PGA2.0 2 Master',0 Simple mixer control 'PGA3.0 3 Master',0 Simple mixer control 'PGA4.0 4 Master',0 Simple mixer control 'PGA7.0 7 Master',0 Simple mixer control 'PGA8.0 8 Master',0 Simple mixer control 'PGA9.0 9 Master',0 ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/114 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Lenovo m920sff support (Realtek ALC 233)
by GitHub issues - opened 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf issue #114 was opened from perexg: More info: https://github.com/thesofproject/linux/issues/3088 ``` Simple mixer control 'Master',0 Simple mixer control 'Headphone',0 Simple mixer control 'Headphone+LO',0 Simple mixer control 'Speaker',0 Simple mixer control 'Front Mic',0 Simple mixer control 'Front Mic Boost',0 Simple mixer control 'Line Out',0 Simple mixer control 'Mic',0 Simple mixer control 'Mic Boost',0 Simple mixer control 'IEC958',0 Simple mixer control 'IEC958',1 Simple mixer control 'IEC958',2 Simple mixer control 'Capture',0 Simple mixer control 'Auto-Mute Mode',0 Simple mixer control 'Dmic0',0 Simple mixer control 'Dmic1 2nd',0 Simple mixer control 'Loopback Mixing',0 Simple mixer control 'PGA1.0 1 Master',0 Simple mixer control 'PGA2.0 2 Master',0 Simple mixer control 'PGA3.0 3 Master',0 Simple mixer control 'PGA4.0 4 Master',0 Simple mixer control 'PGA7.0 7 Master',0 Simple mixer control 'PGA8.0 8 Master',0 Simple mixer control 'PGA9.0 9 Master',0 ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/114 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

USB audio on riscv64
by Kip Warner 04 Nov '21

04 Nov '21

Hey list, Apologies for double posting on alsa-user(a)lists.sourceforge.net as well. Someone suggested this might be more appropriate for the developer mailing list. I am doing some development on riscv64 using a SiFive Unmatched development board. It has only one PCI express slot which I intend to use for a VGA, but it has a number of USB ports. Is anyone aware of any USB audio devices that are known to work, or likely to work, with ALSA on riscv64? I would have thought any device using the generic USB audio module would have worked. But when I went to plug in a small USB speaker, I see it show up on the bus and yet `aplay -l` shows no devices. Yours truly, -- Kip Warner -- Senior Software Engineer OpenPGP signed/encrypted mail preferred https://www.thevertigo.com

1 0

[PATCH] ASoC: amd: vangogh: add SPI dependency
by Arnd Bergmann 03 Nov '21

03 Nov '21

From: Arnd Bergmann <arnd(a)arndb.de> Without CONFIG_SPI, this fails to build: WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SPI_MASTER [=n] Selected by [m]: - SND_SOC_AMD_VANGOGH_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_AMD_ACP5x [=m] && I2C [=y] ERROR: modpost: "spi_setup" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined! ERROR: modpost: "__devm_regmap_init_spi" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined! Fixes: 96792fdd77cd ("ASoC: amd: enable vangogh platform machine driver build") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index d91a9399777c..edee2098c82e 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH tristate "AMD Vangogh support for NAU8821 CS35L41" select SND_SOC_NAU8821 select SND_SOC_CS35L41_SPI - depends on SND_SOC_AMD_ACP5x && I2C + depends on SND_SOC_AMD_ACP5x && I2C && SPI help This option enables machine driver for Vangogh platform using NAU8821 and CS35L41 codecs. -- 2.29.2

2 1