November 2021 - Alsa-devel - mailman.alsa-project.org

Intel SOF HDA: Lenovo m920sff support (Realtek ALC 233)
by GitHub issues - edited 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf issue #114 was edited from perexg: Description: An issue with the headphone detection (Speaker/Headphone auto-mute). More info: https://github.com/thesofproject/linux/issues/3088 and https://bugzilla.suse.com/show_bug.cgi?id=1188685 Mixer: ``` Simple mixer control 'Master',0 Simple mixer control 'Headphone',0 # Switch only Simple mixer control 'Headphone+LO',0 # Volume only Simple mixer control 'Speaker',0 Simple mixer control 'Front Mic',0 Simple mixer control 'Front Mic Boost',0 Simple mixer control 'Line Out',0 # Switch only Simple mixer control 'Mic',0 Simple mixer control 'Mic Boost',0 Simple mixer control 'IEC958',0 Simple mixer control 'IEC958',1 Simple mixer control 'IEC958',2 Simple mixer control 'Capture',0 Simple mixer control 'Auto-Mute Mode',0 Simple mixer control 'Dmic0',0 Simple mixer control 'Dmic1 2nd',0 Simple mixer control 'Loopback Mixing',0 Simple mixer control 'PGA1.0 1 Master',0 Simple mixer control 'PGA2.0 2 Master',0 Simple mixer control 'PGA3.0 3 Master',0 Simple mixer control 'PGA4.0 4 Master',0 Simple mixer control 'PGA7.0 7 Master',0 Simple mixer control 'PGA8.0 8 Master',0 Simple mixer control 'PGA9.0 9 Master',0 ``` Jacks: ``` name 'Mic Jack' name 'Front Mic Jack' name 'Line Out Jack' name 'Front Headphone Jack' name 'Speaker Phantom Jack' name 'HDMI/DP,pcm=3 Jack' name 'HDMI/DP,pcm=4 Jack' name 'HDMI/DP,pcm=5 Jack' ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/114 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Intel SOF HDA: Lenovo m920sff support (Realtek ALC 233)
by GitHub issues - edited 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf issue #114 was edited from perexg: Description: An issue with the headphone detection (Speaker/Headphone auto-mute). More info: https://github.com/thesofproject/linux/issues/3088 and https://bugzilla.suse.com/show_bug.cgi?id=1188685 ``` Simple mixer control 'Master',0 Simple mixer control 'Headphone',0 # Switch only Simple mixer control 'Headphone+LO',0 # Volume only Simple mixer control 'Speaker',0 Simple mixer control 'Front Mic',0 Simple mixer control 'Front Mic Boost',0 Simple mixer control 'Line Out',0 # Switch only Simple mixer control 'Mic',0 Simple mixer control 'Mic Boost',0 Simple mixer control 'IEC958',0 Simple mixer control 'IEC958',1 Simple mixer control 'IEC958',2 Simple mixer control 'Capture',0 Simple mixer control 'Auto-Mute Mode',0 Simple mixer control 'Dmic0',0 Simple mixer control 'Dmic1 2nd',0 Simple mixer control 'Loopback Mixing',0 Simple mixer control 'PGA1.0 1 Master',0 Simple mixer control 'PGA2.0 2 Master',0 Simple mixer control 'PGA3.0 3 Master',0 Simple mixer control 'PGA4.0 4 Master',0 Simple mixer control 'PGA7.0 7 Master',0 Simple mixer control 'PGA8.0 8 Master',0 Simple mixer control 'PGA9.0 9 Master',0 ``` ``` name 'Mic Jack' name 'Front Mic Jack' name 'Line Out Jack' name 'Front Headphone Jack' name 'Speaker Phantom Jack' name 'HDMI/DP,pcm=3 Jack' name 'HDMI/DP,pcm=4 Jack' name 'HDMI/DP,pcm=5 Jack' ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/114 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ALSA: hda/realtek: fix flexible_array.cocci warning
by Guo Zhengkui 04 Nov '21

04 Nov '21

Fix following coccicheck warnings: ./sound/pci/hda/patch_realtek.c:128:4-24: WARNING use flexible-array member instead. There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members” for these cases. The older style of one-element or zero-length arrays should no longer be used. Signed-off-by: Guo Zhengkui <guozhengkui(a)vivo.com> --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6322fac9e694..7935c363092e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -125,7 +125,7 @@ struct alc_spec { unsigned int pll_coef_idx, pll_coef_bit; unsigned int coef0; struct input_dev *kb_dev; - u8 alc_mute_keycode_map[1]; + u8 alc_mute_keycode_map[]; }; /* -- 2.20.1

2 1

Intel SOF HDA: Lenovo m920sff support (Realtek ALC 233)
by GitHub issues - edited 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf issue #114 was edited from perexg: More info: https://github.com/thesofproject/linux/issues/3088 ``` Simple mixer control 'Master',0 Simple mixer control 'Headphone',0 Simple mixer control 'Headphone+LO',0 Simple mixer control 'Speaker',0 Simple mixer control 'Front Mic',0 Simple mixer control 'Front Mic Boost',0 Simple mixer control 'Line Out',0 Simple mixer control 'Mic',0 Simple mixer control 'Mic Boost',0 Simple mixer control 'IEC958',0 Simple mixer control 'IEC958',1 Simple mixer control 'IEC958',2 Simple mixer control 'Capture',0 Simple mixer control 'Auto-Mute Mode',0 Simple mixer control 'Dmic0',0 Simple mixer control 'Dmic1 2nd',0 Simple mixer control 'Loopback Mixing',0 Simple mixer control 'PGA1.0 1 Master',0 Simple mixer control 'PGA2.0 2 Master',0 Simple mixer control 'PGA3.0 3 Master',0 Simple mixer control 'PGA4.0 4 Master',0 Simple mixer control 'PGA7.0 7 Master',0 Simple mixer control 'PGA8.0 8 Master',0 Simple mixer control 'PGA9.0 9 Master',0 ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/114 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Lenovo m920sff support (Realtek ALC 233)
by GitHub issues - opened 04 Nov '21

04 Nov '21

alsa-project/alsa-ucm-conf issue #114 was opened from perexg: More info: https://github.com/thesofproject/linux/issues/3088 ``` Simple mixer control 'Master',0 Simple mixer control 'Headphone',0 Simple mixer control 'Headphone+LO',0 Simple mixer control 'Speaker',0 Simple mixer control 'Front Mic',0 Simple mixer control 'Front Mic Boost',0 Simple mixer control 'Line Out',0 Simple mixer control 'Mic',0 Simple mixer control 'Mic Boost',0 Simple mixer control 'IEC958',0 Simple mixer control 'IEC958',1 Simple mixer control 'IEC958',2 Simple mixer control 'Capture',0 Simple mixer control 'Auto-Mute Mode',0 Simple mixer control 'Dmic0',0 Simple mixer control 'Dmic1 2nd',0 Simple mixer control 'Loopback Mixing',0 Simple mixer control 'PGA1.0 1 Master',0 Simple mixer control 'PGA2.0 2 Master',0 Simple mixer control 'PGA3.0 3 Master',0 Simple mixer control 'PGA4.0 4 Master',0 Simple mixer control 'PGA7.0 7 Master',0 Simple mixer control 'PGA8.0 8 Master',0 Simple mixer control 'PGA9.0 9 Master',0 ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/114 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

USB audio on riscv64
by Kip Warner 04 Nov '21

04 Nov '21

Hey list, Apologies for double posting on alsa-user(a)lists.sourceforge.net as well. Someone suggested this might be more appropriate for the developer mailing list. I am doing some development on riscv64 using a SiFive Unmatched development board. It has only one PCI express slot which I intend to use for a VGA, but it has a number of USB ports. Is anyone aware of any USB audio devices that are known to work, or likely to work, with ALSA on riscv64? I would have thought any device using the generic USB audio module would have worked. But when I went to plug in a small USB speaker, I see it show up on the bus and yet `aplay -l` shows no devices. Yours truly, -- Kip Warner -- Senior Software Engineer OpenPGP signed/encrypted mail preferred https://www.thevertigo.com

1 0

[PATCH] ASoC: amd: vangogh: add SPI dependency
by Arnd Bergmann 03 Nov '21

03 Nov '21

From: Arnd Bergmann <arnd(a)arndb.de> Without CONFIG_SPI, this fails to build: WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SPI_MASTER [=n] Selected by [m]: - SND_SOC_AMD_VANGOGH_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_AMD_ACP5x [=m] && I2C [=y] ERROR: modpost: "spi_setup" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined! ERROR: modpost: "__devm_regmap_init_spi" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined! Fixes: 96792fdd77cd ("ASoC: amd: enable vangogh platform machine driver build") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index d91a9399777c..edee2098c82e 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH tristate "AMD Vangogh support for NAU8821 CS35L41" select SND_SOC_NAU8821 select SND_SOC_CS35L41_SPI - depends on SND_SOC_AMD_ACP5x && I2C + depends on SND_SOC_AMD_ACP5x && I2C && SPI help This option enables machine driver for Vangogh platform using NAU8821 and CS35L41 codecs. -- 2.29.2

2 1

[PATCH -next v2] ALSA: timer: Fix use-after-free problem
by Wang Wensheng 03 Nov '21

03 Nov '21

When the timer instance was add into ack_list but was not currently in process, the user could stop it via snd_timer_stop1() without delete it from the ack_list. Then the user could free the timer instance and when it was actually processed UAF occurred. This issue could be reproduced via testcase snd_timer01 in ltp - running several instances of that testcase at the same time. What I actually met was that the ack_list of the timer broken and the kernel went into deadloop with irqoff. That could be detected by hardlockup detector on board or when we run it on qemu, we could use gdb to dump the ack_list when the console has no response. To fix this issue, we delete the timer instance from ack_list and active_list unconditionally in snd_timer_stop1(). Signed-off-by: Wang Wensheng <wangwensheng4(a)huawei.com> Suggested-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/timer.c b/sound/core/timer.c index 92b7008fcdb8..4f9bab931951 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -624,13 +624,13 @@ static int snd_timer_stop1(struct snd_timer_instance *timeri, bool stop) if (!timer) return -EINVAL; spin_lock_irqsave(&timer->lock, flags); + list_del_init(&timeri->ack_list); + list_del_init(&timeri->active_list); if (!(timeri->flags & (SNDRV_TIMER_IFLG_RUNNING | SNDRV_TIMER_IFLG_START))) { result = -EBUSY; goto unlock; } - list_del_init(&timeri->ack_list); - list_del_init(&timeri->active_list); if (timer->card && timer->card->shutdown) goto unlock; if (stop) { -- 2.17.1

2 2

[PATCH] ALSA: hda/realtek: Headset fixup for Clevo NH77HJQ
by Tim Crawford 03 Nov '21

03 Nov '21

From: Jeremy Soller <jeremy(a)system76.com> On Clevo NH77HJ, NH77HP, and their 15" variants, there is a headset microphone input attached to 0x19 that does not have a jack detect. In order to get it working, the pin configuration needs to be set correctly, and a new ALC256_FIXUP_HEADSET_MODE_NO_HP_MIC fixup is applied. This is similar to the existing System76 quirk for ALC293, but for ALC256. Signed-off-by: Jeremy Soller <jeremy(a)system76.com> Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- sound/pci/hda/patch_realtek.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 8a3e2fe42106..e6b266416393 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6739,6 +6739,7 @@ enum { ALC287_FIXUP_YOGA7_14ITL_SPEAKERS, ALC287_FIXUP_13S_GEN2_SPEAKERS, ALC256_FIXUP_TONGFANG_RESET_PERSISTENT_SETTINGS, + ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE, }; static const struct hda_fixup alc269_fixups[] = { @@ -8450,6 +8451,15 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc245_fixup_hp_gpio_led, }, + [ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x03a11120 }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -8750,11 +8760,15 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1558, 0x40a1, "Clevo NL40GU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x40c1, "Clevo NL40[CZ]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x40d1, "Clevo NL41DU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x5015, "Clevo NH5[58]H[HJK]Q", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x5017, "Clevo NH7[79]H[HJK]Q", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x50a3, "Clevo NJ51GU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x50b3, "Clevo NK50S[BEZ]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x50b6, "Clevo NK50S5", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x50b8, "Clevo NK50SZ", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x50d5, "Clevo NP50D5", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x50e1, "Clevo NH5[58]HPQ", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x50e2, "Clevo NH7[79]HPQ", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x50f0, "Clevo NH50A[CDF]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x50f2, "Clevo NH50E[PR]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x50f3, "Clevo NH58DPQ", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), -- 2.31.1

2 3

[PATCH 0/4] Fix kcontrol put callback in Tegra drivers
by Sameer Pujar 03 Nov '21

03 Nov '21

This series fixes kcontrol put callback in some of the Tegra drivers which are used on platforms based on Tegra210 and later. The callback is expected to return 1 whenever the HW update is done. ADMAIF, I2S, DMIC and DSPK drivers are updated as part of it. This idea is suggested by Jaroslav. Similar suggestion came from Mark during review of series [0] and drivers under those series were taken care. This series takes care of remaining drivers. I have added 'Suggested-by" tags accordingly. [0] https://lore.kernel.org/linux-arm-kernel/20210913142307.GF4283@sirena.org.u… Sameer Pujar (4): ASoC: tegra: Fix kcontrol put callback in ADMAIF ASoC: tegra: Fix kcontrol put callback in I2S ASoC: tegra: Fix kcontrol put callback in DMIC ASoC: tegra: Fix kcontrol put callback in DSPK sound/soc/tegra/tegra186_dspk.c | 4 +++- sound/soc/tegra/tegra210_admaif.c | 4 +++- sound/soc/tegra/tegra210_dmic.c | 4 +++- sound/soc/tegra/tegra210_i2s.c | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-) -- 2.7.4

2 6