June 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: meson: fix memory leak of links if allocation of ldata fails
by Colin King 08 Jun '20

08 Jun '20

From: Colin Ian King <colin.king(a)canonical.com> Currently if the allocation of ldata fails the error return path does not kfree the allocated links object. Fix this by adding an error exit return path that performs the necessary kfree'ing. Addresses-Coverity: ("Resource leak") Fixes: 7864a79f37b5 ("ASoC: meson: add axg sound card support") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/meson/meson-card-utils.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/sound/soc/meson/meson-card-utils.c b/sound/soc/meson/meson-card-utils.c index 2ca8c98e204f..5a4a91c88734 100644 --- a/sound/soc/meson/meson-card-utils.c +++ b/sound/soc/meson/meson-card-utils.c @@ -49,19 +49,26 @@ int meson_card_reallocate_links(struct snd_soc_card *card, links = krealloc(priv->card.dai_link, num_links * sizeof(*priv->card.dai_link), GFP_KERNEL | __GFP_ZERO); + if (!links) + goto err_links; + ldata = krealloc(priv->link_data, num_links * sizeof(*priv->link_data), GFP_KERNEL | __GFP_ZERO); - - if (!links || !ldata) { - dev_err(priv->card.dev, "failed to allocate links\n"); - return -ENOMEM; - } + if (!ldata) + goto err_ldata; priv->card.dai_link = links; priv->link_data = ldata; priv->card.num_links = num_links; return 0; + +err_ldata: + kfree(links); +err_links: + dev_err(priv->card.dev, "failed to allocate links\n"); + return -ENOMEM; + } EXPORT_SYMBOL_GPL(meson_card_reallocate_links); -- 2.25.1

3 2

[PATCH] ALSA: usb-audio: Use the new macro for HP Dock rename quirks
by Takashi Iwai 08 Jun '20

08 Jun '20

Replace the open-code with the new QUIRK_DEVICE_PROFILE() macro for simplicity. Fixes: 0c5086f56999 ("ALSA: usb-audio: Add vendor, product and profile name for HP Thunderbolt Dock") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/quirks-table.h | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 90d65bfa733d..4ec491011b19 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -43,22 +43,14 @@ /* HP Thunderbolt Dock Audio Headset */ { USB_DEVICE(0x03f0, 0x0269), - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { - .vendor_name = "HP", - .product_name = "Thunderbolt Dock Audio Headset", - .profile_name = "HP-Thunderbolt-Dock-Audio-Headset", - .ifnum = QUIRK_NO_INTERFACE - } + QUIRK_DEVICE_PROFILE("HP", "Thunderbolt Dock Audio Headset", + "HP-Thunderbolt-Dock-Audio-Headset"), }, /* HP Thunderbolt Dock Audio Module */ { USB_DEVICE(0x03f0, 0x0567), - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { - .vendor_name = "HP", - .product_name = "Thunderbolt Dock Audio Module", - .profile_name = "HP-Thunderbolt-Dock-Audio-Module", - .ifnum = QUIRK_NO_INTERFACE - } + QUIRK_DEVICE_PROFILE("HP", "Thunderbolt Dock Audio Module", + "HP-Thunderbolt-Dock-Audio-Module"), }, /* FTDI devices */ { -- 2.16.4

2 5

[PATCH] ALSA: usb-audio: Add vendor, product and profile name for HP Thunderbolt Dock
by Kai-Heng Feng 08 Jun '20

08 Jun '20

The HP Thunderbolt Dock has two separate USB devices, one is for speaker and one is for headset. Add names for them so userspace can apply UCM settings. Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- sound/usb/quirks-table.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 6d6492195bdc..90d65bfa733d 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -40,6 +40,26 @@ .ifnum = QUIRK_NO_INTERFACE \ } +/* HP Thunderbolt Dock Audio Headset */ +{ + USB_DEVICE(0x03f0, 0x0269), + .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { + .vendor_name = "HP", + .product_name = "Thunderbolt Dock Audio Headset", + .profile_name = "HP-Thunderbolt-Dock-Audio-Headset", + .ifnum = QUIRK_NO_INTERFACE + } +}, +/* HP Thunderbolt Dock Audio Module */ +{ + USB_DEVICE(0x03f0, 0x0567), + .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { + .vendor_name = "HP", + .product_name = "Thunderbolt Dock Audio Module", + .profile_name = "HP-Thunderbolt-Dock-Audio-Module", + .ifnum = QUIRK_NO_INTERFACE + } +}, /* FTDI devices */ { USB_DEVICE(0x0403, 0xb8d8), -- 2.17.1

2 1

config for Renoir APU
by GitHub pull_request - edited 07 Jun '20

07 Jun '20

alsa-project/alsa-ucm-conf pull request #31 was edited from perexg: This is just a test config (not for merge). BEWARE: This configuration is not intended for the broad use at the moment. It will broke other HDA Intel hardware. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/31 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/31.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

config for Renoir APU
by GitHub pull_request - opened 07 Jun '20

07 Jun '20

alsa-project/alsa-ucm-conf pull request #31 was opened from perexg: This is just a test config (not for merge). Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/31 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/31.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALSA control service in user space
by Takashi Sakamoto 07 Jun '20

07 Jun '20

Hi, Today I released hinawa-rs[1], Rust bindings to libhinawa v2.0[2]. Aug 2018 I sent a message[3] about new releases of libhinawa/hinawa-utils. In the releases, I used Python 3 to write tools for audio and music units on IEEE 1394 bus, supported by ALSA firewire stack. The attempt is successful to make my understandings further about vendor-dependent protocols. Earlier the message, Nov 2016 I had a presentation about ALSA device control service in user space[4]. The idea requires server program to perform some tasks below in user space: * register control element set into ALSA control core for existent card instance * dispatch control event from ALSA control applications * communicate with device to operate its functions such as volume control * dispatch any event from the device. The registered control element set can be handled transparently by ALSA control applications such as amixer. When the application operates the added control element, events are delivered to the server program. Then the server program communicates with the device for the operation. Now instead of Python 3, I select Rust language to write the server programs for audio and music units on IEEE 1394 bus. The hinawa-rs helps the third and fourth of the above tasks. For the first and second task, I wrote some libraries in alsa-gobject project[5]. The demonstration by Python 3 is public[6]. I already write alsa-gobject-rs which includes Rust bindings for the libraries. It's not public yet since I make no official releases of alsa-gobject itself. At the same time, I already write the prototype of server programs itself and it works well in my local. The code base already reaches 28,000 lines even if it supports the limited number of devices. I realized again that it was a better decision not to implement them in kernel land. As IEEE 1394 bus becomes legacy, the audio and music units is outdated. One of my motivation to continue the development is the idea of control service in use space itself since the idea is also available for USB Audio as well. When developers work for devices with vendor-dependent protocol, the idea helps the developer because user space applications can communicate with the device via USB character device. For example, I recently saw an attempt by Guy Sherman for US-4x4 Utils[7]. As a quick glance to his repository[8], vendor-dependent command is used to operate the device. For this kind of work, the idea is available as well to produce transparent control element set. Anyway I'm going to make official release of alsa-gobject as a next step toward the idea. [1] https://github.com/takaswie/hinawa-rs [2] https://github.com/takaswie/libhinawa [3] https://www.alsa-project.org/pipermail/alsa-devel/2018-August/139448.html [4] https://github.com/takaswie/presentations/blob/master/20161101/content.md [5] https://github.com/alsa-project/alsa-gobject [6] 'self.open(card_id)' should be 'self.open(card_id, 0)' now https://mailman.alsa-project.org/pipermail/alsa-devel/2019-December/159339.… [7] https://lists.linuxaudio.org/archives/linux-audio-dev/2020-May/037774.html [8] https://github.com/guysherman/tascam-util Regards Takashi Sakamoto

2 3

alsa-gobject: seq: fulfill documentation for ALSASeq
by GitHub pull_request - opened 06 Jun '20

06 Jun '20

alsa-project/alsa-gobject pull request #24 was opened from takaswie: This patch fulfills documentation for ALSASeq. Request URL : https://github.com/alsa-project/alsa-gobject/pull/24 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/24.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

alsa-gobject: hwdep/timer/rawmidi: fulfill documentation for ALSAHwdep/ALSATimer/ALSARawmidi
by GitHub pull_request - opened 06 Jun '20

06 Jun '20

alsa-project/alsa-gobject pull request #23 was opened from takaswie: This patchset fulfills documentation for ALSAHwdep/ALSATimer/ALSARawmidi, except for ALSASeq, including some documentation improvements for ALSACtl. Request URL : https://github.com/alsa-project/alsa-gobject/pull/23 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/23.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

detailed documentation for plug plugin?
by D. R. Evans 06 Jun '20

06 Jun '20

This is a follow-on to the topic started in e-mail <62e4a031-f175-70bc-099f-441fa0623a9f(a)gmail.com> on the alsa-users reflector; I also posted this e-mail on that reflector, but I suspect that there are more people here who would immediately understand the behaviour described below, and can point me to the right documentation. -------- I have a machine on which the following works for reading audio: device: default [which is actually hw:0,0,0] rate: 44100 [which is all that the raw device supports] And the following does not work: device: plug:default rate: 8000 Everything else is identical in the two scenarios. So I am trying to find detailed documentation about the "plug" plugin, to see why it doesn't seem to do what the minimal description I've been able to find suggests. That is, from what little I've been able to find, it seemed like the second scenario should work if the first one does: behind the scenes it would take the 44100 output from the default device and downsample to 8000, and make that available to the snd_pcm_readX() functions. But that is not what's happening, since the second scenario fails: snd_pcm_readX() blocks (even in non-blocking mode). Somewhere there has to be a detailed, technical description of precisely what the plug plugin does; can someone please provide a suggestion where to look? Doc -- Web: http://enginehousebooks.com/drevans

1 0

[RFC][PATCH] slimbus: core: Set fwnode for a device when setting of_node
by John Stultz 06 Jun '20

06 Jun '20

From: Saravana Kannan <saravanak(a)google.com> When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink to work for slimbus devices. Cc: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> Cc: alsa-devel(a)alsa-project.org Signed-off-by: Saravana Kannan <saravanak(a)google.com> Signed-off-by: John Stultz <john.stultz(a)linaro.org> --- drivers/slimbus/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 526e3215d8fe..44228a5b246d 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl, INIT_LIST_HEAD(&sbdev->stream_list); spin_lock_init(&sbdev->stream_list_lock); - if (node) + if (node) { sbdev->dev.of_node = of_node_get(node); + sbdev->dev.fwnode = of_fwnode_handle(node); + } dev_set_name(&sbdev->dev, "%x:%x:%x:%x", sbdev->e_addr.manf_id, -- 2.17.1

2 2