June 2020 - Alsa-devel - mailman.alsa-project.org

Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices
by Srinivas Kandagatla 09 Jun '20

09 Jun '20

On 08/06/2020 21:43, Jonathan Marek wrote: > Adds support for qcom soundwire devices with memory mapped IO registers. > > Signed-off-by: Jonathan Marek <jonathan(a)marek.ca> > --- In general patch itself looks pretty trivial, but I would like to see what 1.5.1 controller provides in terms of error reporting of SoundWire slave register reads/writes. On WCD based controller we did not have a mechanism to report things like if the read is ignored or not. I was hoping that this version of controller would be able to report that. I will be nice to those patches if that is something which is supported in this version. --srini > drivers/soundwire/qcom.c | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index f38d1fd3679f..628747df1c75 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -90,6 +90,7 @@ struct qcom_swrm_ctrl { > struct sdw_bus bus; > struct device *dev; > struct regmap *regmap; > + void __iomem *mmio; > struct completion *comp; > struct work_struct slave_work; > /* read/write lock */ > @@ -154,6 +155,20 @@ static int qcom_swrm_ahb_reg_write(struct qcom_swrm_ctrl *ctrl, > return SDW_CMD_OK; > } > > +static int qcom_swrm_cpu_reg_read(struct qcom_swrm_ctrl *ctrl, int reg, > + u32 *val) > +{ > + *val = readl(ctrl->mmio + reg); > + return SDW_CMD_OK; > +} > + > +static int qcom_swrm_cpu_reg_write(struct qcom_swrm_ctrl *ctrl, int reg, > + int val) > +{ > + writel(val, ctrl->mmio + reg); > + return SDW_CMD_OK; > +} > + > static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *ctrl, u8 cmd_data, > u8 dev_addr, u16 reg_addr) > { > @@ -746,6 +761,7 @@ static int qcom_swrm_probe(struct platform_device *pdev) > struct sdw_master_prop *prop; > struct sdw_bus_params *params; > struct qcom_swrm_ctrl *ctrl; > + struct resource *res; > int ret; > u32 val; > > @@ -760,8 +776,13 @@ static int qcom_swrm_probe(struct platform_device *pdev) > if (!ctrl->regmap) > return -EINVAL; > } else { > - /* Only WCD based SoundWire controller is supported */ > - return -ENOTSUPP; > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + > + ctrl->reg_read = qcom_swrm_cpu_reg_read; > + ctrl->reg_write = qcom_swrm_cpu_reg_write; > + ctrl->mmio = devm_ioremap_resource(dev, res); > + if (IS_ERR(ctrl->mmio)) > + return PTR_ERR(ctrl->mmio); > } > > ctrl->irq = of_irq_get(dev->of_node, 0); >

1 0

Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices
by Vinod Koul 09 Jun '20

09 Jun '20

Hi Jonathan, On 08-06-20, 16:43, Jonathan Marek wrote: > Adds support for qcom soundwire devices with memory mapped IO registers. Please use 'SoundWire Master devices' instead :) > > Signed-off-by: Jonathan Marek <jonathan(a)marek.ca> > --- > drivers/soundwire/qcom.c | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index f38d1fd3679f..628747df1c75 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -90,6 +90,7 @@ struct qcom_swrm_ctrl { > struct sdw_bus bus; > struct device *dev; > struct regmap *regmap; > + void __iomem *mmio; > struct completion *comp; > struct work_struct slave_work; > /* read/write lock */ > @@ -154,6 +155,20 @@ static int qcom_swrm_ahb_reg_write(struct qcom_swrm_ctrl *ctrl, > return SDW_CMD_OK; > } > > +static int qcom_swrm_cpu_reg_read(struct qcom_swrm_ctrl *ctrl, int reg, > + u32 *val) > +{ > + *val = readl(ctrl->mmio + reg); > + return SDW_CMD_OK; > +} > + > +static int qcom_swrm_cpu_reg_write(struct qcom_swrm_ctrl *ctrl, int reg, > + int val) > +{ > + writel(val, ctrl->mmio + reg); > + return SDW_CMD_OK; > +} this looks fine but regmap supports mmio also, so I am thinking we should remove these and set regmap (mmio/slim)... Srini..? -- ~Vinod

2 1

Re: [PATCH 1/5] soundwire: qcom: fix abh/ahb typo
by Srinivas Kandagatla 09 Jun '20

09 Jun '20

On 08/06/2020 21:43, Jonathan Marek wrote: > The function name qcom_swrm_abh_reg_read should say ahb, fix that. > > Signed-off-by: Jonathan Marek <jonathan(a)marek.ca> > --- Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> > drivers/soundwire/qcom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index a1c2a44a3b4d..f38d1fd3679f 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -114,7 +114,7 @@ struct qcom_swrm_ctrl { > > #define to_qcom_sdw(b) container_of(b, struct qcom_swrm_ctrl, bus) > > -static int qcom_swrm_abh_reg_read(struct qcom_swrm_ctrl *ctrl, int reg, > +static int qcom_swrm_ahb_reg_read(struct qcom_swrm_ctrl *ctrl, int reg, > u32 *val) > { > struct regmap *wcd_regmap = ctrl->regmap; > @@ -754,7 +754,7 @@ static int qcom_swrm_probe(struct platform_device *pdev) > return -ENOMEM; > > if (dev->parent->bus == &slimbus_bus) { > - ctrl->reg_read = qcom_swrm_abh_reg_read; > + ctrl->reg_read = qcom_swrm_ahb_reg_read; > ctrl->reg_write = qcom_swrm_ahb_reg_write; > ctrl->regmap = dev_get_regmap(dev->parent, NULL); > if (!ctrl->regmap) >

1 0

alsa-gobject: timer: add global method to retrieve current source of timestamp
by GitHub pull_request - opened 09 Jun '20

09 Jun '20

alsa-project/alsa-gobject pull request #27 was opened from takaswie: ALSA snd_timer kernel module has a parameter for source of timestamping. Applications cannot refer to the parameter via UAPI of Linux kernel, however it's possible via sysfs. This patch adds an API to refer to the parameter. Request URL : https://github.com/alsa-project/alsa-gobject/pull/27 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/27.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 1/3] bytcr-rt5640: Fix DMIC1 not working when connected over AIF2
by Hans de Goede 09 Jun '20

09 Jun '20

The RT5640 codec has 2 ADC-s which are caled the Stereo ADC and the Mono ADC (even though the mono ADC seems to be stereo too?). The Stereo ADC is connected to the AIF1 interface of the codec and the Mono ADC to the AIF2 interface. Almost all X86 BYT/CHT design use the AIF1 interface, but a few models use the AIF2 interface. For this reason the IN?-InternalMic.conf bits not only select/enable the microphone input on the Stereo ADC, but also on the Mono ADC, so that the analog mic. inputs also work in devices using the AIF2 interface. Before this commit DigitalMics.conf was only setting up the DMIC input on the Stereo ADC and not on the Mono ADC, causing DMIC1 to not work when connected over AIF2. This commit adds selecting / enabling DMIC1 on the Mono ADC. This fixes the internal microphone not working on the Toshiba Encore WT10A. Note that for devices which use the AIF1 interface this is a no-op since the AIF1 interface is not connected to anything, there is no complete chain so DAPM will not enable any of the elements in the chain. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- ucm2/codecs/rt5640/DigitalMics.conf | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ucm2/codecs/rt5640/DigitalMics.conf b/ucm2/codecs/rt5640/DigitalMics.conf index 503c4a9..fdd412f 100644 --- a/ucm2/codecs/rt5640/DigitalMics.conf +++ b/ucm2/codecs/rt5640/DigitalMics.conf @@ -6,6 +6,9 @@ SectionDevice."Mic" { ] EnableSequence [ + cset "name='Mono ADC MIXL ADC2 Switch' on" + cset "name='Mono ADC MIXR ADC2 Switch' on" + cset "name='Mono ADC Capture Switch' on" cset "name='Stereo ADC MIXL ADC2 Switch' on" cset "name='Stereo ADC MIXR ADC2 Switch' on" cset "name='Internal Mic Switch' on" @@ -13,6 +16,9 @@ SectionDevice."Mic" { ] DisableSequence [ + cset "name='Mono ADC MIXL ADC2 Switch' off" + cset "name='Mono ADC MIXR ADC2 Switch' off" + cset "name='Mono ADC Capture Switch' off" cset "name='Stereo ADC MIXL ADC2 Switch' off" cset "name='Stereo ADC MIXR ADC2 Switch' off" cset "name='Internal Mic Switch' off" -- 2.26.2

3 6

[PATCH alsa-lib] conf: USB-Audio: Add HP Thunderbolt Dock in the IEC958 blacklist
by Kai-Heng Feng 09 Jun '20

09 Jun '20

Both headset and speaker on HP Thunderbolt Dock don't support IEC958 interface. Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- src/conf/cards/USB-Audio.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/cards/USB-Audio.conf b/src/conf/cards/USB-Audio.conf index 735079e3..01664abf 100644 --- a/src/conf/cards/USB-Audio.conf +++ b/src/conf/cards/USB-Audio.conf @@ -62,6 +62,8 @@ USB-Audio.pcm.iec958_device { "Scarlett 2i4 USB" 999 "Sennheiser USB headset" 999 "SWTOR Gaming Headset by Razer" 999 + "Thunderbolt Dock Audio Headset" 999 + "Thunderbolt Dock Audio Module" 999 "USB Device 0x46d_0x821" 999 "USB Device 0x46d_0x992" 999 "WD15 Dock" 999 -- 2.17.1

2 1

Renoir APU - Mic-mute Led status not updated for onboard DMIC
by Mukunda, Vijendar 09 Jun '20

09 Jun '20

Renoir APU has on board DMIC and HD Audio Endpoint combination. Mic-mute LED status not updated for On board DMIC i.e internal Mic when Mute is applied from OS in Ubuntu. When External Mic is connected(HD Audio Endpoint) , ACPI event got updated based on Mic mute status , able to toggle the Mic Led status in Ubuntu. We have found a thread which explains toggling Mic Led status for Lenovo thinkpads. Below is the link. https://askubuntu.com/questions/125367/enabling-mic-mute-button-and-light-o… In case of Internal Mic(DMIC), Mic-mute Led status is not updated as onboard DMIC doesn't have any volume control. We are not really sure how to update Mic mute status in this case. Help us in resolving this issue. Alsa info link: https://pastebin.ubuntu.com/p/4kprhDZYbg/ Thanks, Vijendar

1 0

Re: [PATCH 3/5] soundwire: qcom: add v1.5.1 compatible
by Vinod Koul 09 Jun '20

09 Jun '20

On 08-06-20, 16:43, Jonathan Marek wrote: > Add a compatible string for HW version v1.5.1 on sm8250 SoCs. Please document this new compatible -- ~Vinod

1 0

Update configs for Broadwell devices
by GitHub pull_request - opened 09 Jun '20

09 Jun '20

alsa-project/alsa-ucm-conf pull request #32 was opened from plbossart: use the SOF card test to reuse legacy configs. tests require https://github.com/alsa-project/alsa-tests/pull/9 Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/32 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/32.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v4 0/3] ASoC: Intel: Add KeemBay ASoC platform driver
by Sia Jee Heng 09 Jun '20

09 Jun '20

The below series of patches support the KeemBay ASoC platform driver. The platform driver initialize the i2s to capture and playback the pcm data on the ARM. The i2s is running in polling mode. There is no DSP in the KeemBay SoC. Users are rely on the Gstreamer plugin to perform Audio preprocessing. Audio graph card is used to connect the platform driver with the tlv320aic3204 codec. Change History: v4: - Reduce if-otology at the tx/rx function. - Fix indentation. - specify .rate directly v3: - Adjusted header format. - Use Audio graph card instead of custom sound card. - Use if-else instead of conditional operator. - Enabled .set_fmt to configure master clock. v2: - Corrected I2S naming for DT binding. v1: - Initial version. Sia Jee Heng (3): ASoC: Intel: Add KeemBay platform driver ASoC: Intel: Add makefiles and kconfig changes for KeemBay dt-bindings: sound: Add documentation for KeemBay i2s .../bindings/sound/intel,keembay-i2s.yaml | 68 +++ sound/soc/intel/Kconfig | 7 + sound/soc/intel/Makefile | 1 + sound/soc/intel/keembay/Makefile | 4 + sound/soc/intel/keembay/kmb_platform.c | 654 +++++++++++++++++++++ sound/soc/intel/keembay/kmb_platform.h | 145 +++++ 6 files changed, 879 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml create mode 100644 sound/soc/intel/keembay/Makefile create mode 100644 sound/soc/intel/keembay/kmb_platform.c create mode 100644 sound/soc/intel/keembay/kmb_platform.h -- 1.9.1

3 5