May 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] Enable class-D silence and clock detections
by derek.fang＠realtek.com 29 May '20

29 May '20

From: "derek.fang" <derek.fang(a)realtek.com> Avoid noise under bypass boost mode. Signed-off-by: derek.fang <derek.fang(a)realtek.com> --- sound/soc/codecs/rt1015.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt1015.c b/sound/soc/codecs/rt1015.c index 5eb07a4..67e2e94 100644 --- a/sound/soc/codecs/rt1015.c +++ b/sound/soc/codecs/rt1015.c @@ -475,7 +475,7 @@ static int rt1015_bypass_boost_put(struct snd_kcontrol *kcontrol, snd_soc_component_write(component, RT1015_CLSD_INTERNAL9, 0x0140); snd_soc_component_write(component, - RT1015_GAT_BOOST, 0x00fe); + RT1015_GAT_BOOST, 0x0efe); snd_soc_component_write(component, RT1015_PWR_STATE_CTRL, 0x000d); msleep(500); -- 2.7.4

2 2

[PATCH v2] ASoC: reduce verbosity of error messages for sof-dai and sof-link
by Pierre-Louis Bossart 29 May '20

29 May '20

Recent changes result in multiple dmesg traces such as: [ 14.410435] Audio Port: ASoC: error at snd_soc_link_startup on Audio Port: 1 [ 14.410446] sst-mfld-platform sst-mfld-platform: ASoC: error at snd_soc_dai_startup on media-cpu-dai: 1 These messages are not really errors, when dai and dai-link callbacks return the value of e.g. snd_pcm_hw_constraint_single() the result is "Positive if the value is changed, zero if it's not changed, or a negative error code" Add a simple test to skip the checks for positive returned values Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/soc-dai.c | 6 +++++- sound/soc/soc-link.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-dai.c b/sound/soc/soc-dai.c index 2c6ac3b0afa5..b05e18b63a1c 100644 --- a/sound/soc/soc-dai.c +++ b/sound/soc/soc-dai.c @@ -14,10 +14,14 @@ static inline int _soc_dai_ret(struct snd_soc_dai *dai, const char *func, int ret) { + /* Positive, Zero values are not errors */ + if (ret >= 0) + return ret; + + /* Negative values might be errors */ switch (ret) { case -EPROBE_DEFER: case -ENOTSUPP: - case 0: break; default: dev_err(dai->dev, diff --git a/sound/soc/soc-link.c b/sound/soc/soc-link.c index 248e1be4e1eb..f849278beba0 100644 --- a/sound/soc/soc-link.c +++ b/sound/soc/soc-link.c @@ -12,10 +12,14 @@ static inline int _soc_link_ret(struct snd_soc_pcm_runtime *rtd, const char *func, int ret) { + /* Positive, Zero values are not errors */ + if (ret >= 0) + return ret; + + /* Negative values might be errors */ switch (ret) { case -EPROBE_DEFER: case -ENOTSUPP: - case 0: break; default: dev_err(rtd->dev, base-commit: 4a0434502191347ba8f99468f2fb2cdddc20d381 -- 2.20.1

2 1

[sound:for-next 67/134] sound/usb/mixer_quirks.c:2254:49: sparse: sparse: Using plain integer as NULL pointer
by kbuild test robot 29 May '20

29 May '20

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 8191743d5f9a34c0665046937eff262bffdad9a9 commit: 3e8f3bd047163d30fb1ad32ca7e4628921555c09 [67/134] ALSA: usb-audio: RME Babyface Pro mixer patch config: x86_64-randconfig-s022-20200529 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-243-gc100a7ab-dirty git checkout 3e8f3bd047163d30fb1ad32ca7e4628921555c09 # save the attached .config to linux build tree make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp(a)intel.com> sparse warnings: (new ones prefixed by >>) >> sound/usb/mixer_quirks.c:2254:49: sparse: sparse: Using plain integer as NULL pointer sound/usb/mixer_quirks.c:2393:49: sparse: sparse: Using plain integer as NULL pointer vim +2254 sound/usb/mixer_quirks.c 2224 2225 static int snd_bbfpro_ctl_update(struct usb_mixer_interface *mixer, u8 reg, 2226 u8 index, u8 value) 2227 { 2228 int err; 2229 u16 usb_req, usb_idx, usb_val; 2230 struct snd_usb_audio *chip = mixer->chip; 2231 2232 err = snd_usb_lock_shutdown(chip); 2233 if (err < 0) 2234 return err; 2235 2236 if (reg == SND_BBFPRO_CTL_REG1) { 2237 usb_req = SND_BBFPRO_USBREQ_CTL_REG1; 2238 if (index == SND_BBFPRO_CTL_REG1_CLK_OPTICAL) { 2239 usb_idx = 3; 2240 usb_val = value ? 3 : 0; 2241 } else { 2242 usb_idx = 1 << index; 2243 usb_val = value ? usb_idx : 0; 2244 } 2245 } else { 2246 usb_req = SND_BBFPRO_USBREQ_CTL_REG2; 2247 usb_idx = 1 << index; 2248 usb_val = value ? usb_idx : 0; 2249 } 2250 2251 err = snd_usb_ctl_msg(chip->dev, 2252 usb_sndctrlpipe(chip->dev, 0), usb_req, 2253 USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, > 2254 usb_val, usb_idx, 0, 0); 2255 2256 snd_usb_unlock_shutdown(chip); 2257 return err; 2258 } 2259 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH 0/3] ASoC: Intel: simplify driver/card names for SOF/UCM integration
by Pierre-Louis Bossart 29 May '20

29 May '20

As suggested by Jaroslav, this patchset simplifies legacy cards compiled with SOF: they now expose an 'SOF' driver name and an 'sof-bytcht <codec>' card name. UCM uses this driver name and additionally checks for the card name to load a configuration shared with the SST driver. This patchset is just a rename with no functionality change. There is no modification when SOF is not used, and Kconfig for SOF are disabled when SST is enabled so no risk of interference. I know this is cutting it very close to the merge window but hope that this helps make 5.8 the first kernel version where SOF 'just works'(tm) on legacy platforms with no additional configuration needed (as is already the case with more recent HDaudio+DMIC platforms). Thanks to Jaroslav for all the hard work on the alsa-lib/UCM side (the majority of the configs are already merged in alsa-ucm-conf, only minor updates are in-flight for max98090 and broadwell). Pierre-Louis Bossart (3): ASoC: Intel: byt*: simplify card names for SOF uses ASoC: Intel: cht*: simplify card names for SOF uses ASoC: Intel: broadwell: simplify card names for SOF uses sound/soc/intel/boards/bdw-rt5650.c | 12 +++++++++++- sound/soc/intel/boards/bdw-rt5677.c | 12 +++++++++++- sound/soc/intel/boards/broadwell.c | 12 +++++++++++- sound/soc/intel/boards/bytcht_cx2072x.c | 12 +++++++++++- sound/soc/intel/boards/bytcht_da7213.c | 12 +++++++++++- sound/soc/intel/boards/bytcht_es8316.c | 12 +++++++++++- sound/soc/intel/boards/bytcr_rt5640.c | 12 +++++++++++- sound/soc/intel/boards/bytcr_rt5651.c | 12 +++++++++++- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 12 +++++++++++- sound/soc/intel/boards/cht_bsw_nau8824.c | 12 +++++++++++- sound/soc/intel/boards/cht_bsw_rt5645.c | 17 +++++++++++++++-- sound/soc/intel/boards/cht_bsw_rt5672.c | 12 +++++++++++- 12 files changed, 136 insertions(+), 13 deletions(-) base-commit: 67866ff9b7a7d9d4a3030efaadb079290ebaf967 -- 2.20.1

2 4

Re: [PATCH] Enable class-D silence and clock detections
by Mark Brown 29 May '20

29 May '20

On Fri, May 29, 2020 at 11:22:25AM +0000, Derek [方德義] wrote: > > Please submit patches using subject lines reflecting the style for the > > subsystem, this makes it easier for people to identify relevant patches. > Sorry for the mistake. I will resend the patch. It's OK, no need for this one - just please bear this in mind in future.

1 0

[PATCH] ASoC: reduce verbosity of error messages for sof-dai and sof-link
by Pierre-Louis Bossart 29 May '20

29 May '20

Recent changes result in multiple dmesg traces such as: [ 14.410435] Audio Port: ASoC: error at snd_soc_link_startup on Audio Port: 1 [ 14.410446] sst-mfld-platform sst-mfld-platform: ASoC: error at snd_soc_dai_startup on media-cpu-dai: 1 These messages are not really errors, when dai and dai-link callbacks return the value of e.g. snd_pcm_hw_constraint_single() the result is "Positive if the value is changed, zero if it's not changed, or a negative error code" Add a simple test to only log errors when the result is negative. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/soc-dai.c | 7 ++++--- sound/soc/soc-link.c | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/soc/soc-dai.c b/sound/soc/soc-dai.c index 2c6ac3b0afa5..6a0e7560bacc 100644 --- a/sound/soc/soc-dai.c +++ b/sound/soc/soc-dai.c @@ -20,9 +20,10 @@ static inline int _soc_dai_ret(struct snd_soc_dai *dai, case 0: break; default: - dev_err(dai->dev, - "ASoC: error at %s on %s: %d\n", - func, dai->name, ret); + if (ret < 0) + dev_err(dai->dev, + "ASoC: error at %s on %s: %d\n", + func, dai->name, ret); } return ret; diff --git a/sound/soc/soc-link.c b/sound/soc/soc-link.c index 248e1be4e1eb..ff053d4c1a49 100644 --- a/sound/soc/soc-link.c +++ b/sound/soc/soc-link.c @@ -18,9 +18,10 @@ static inline int _soc_link_ret(struct snd_soc_pcm_runtime *rtd, case 0: break; default: - dev_err(rtd->dev, - "ASoC: error at %s on %s: %d\n", - func, rtd->dai_link->name, ret); + if (ret < 0) + dev_err(rtd->dev, + "ASoC: error at %s on %s: %d\n", + func, rtd->dai_link->name, ret); } return ret; base-commit: 4a0434502191347ba8f99468f2fb2cdddc20d381 -- 2.20.1

2 2

Re: Subject: [PATCH] ASoC: soc-pcm: fix BE dai not hw_free and shutdown during mixer update
by Mark Brown 29 May '20

29 May '20

On Fri, May 29, 2020 at 12:10:26PM +0800, zhucancan wrote: > +++ b/sound/soc/soc-pcm.c > @@ -2730,12 +2730,12 @@ static int dpcm_run_update_startup(struct snd_soc_pcm_runtime *fe, int stream) > close: > dpcm_be_dai_shutdown(fe, stream); > disconnect: > - /* disconnect any non started BEs */ > + /* disconnect any closed BEs */ Your mailer has corrupted the patch (it looks like it replaced tabs with spaces).

1 0

[V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390
by Steve Lee 29 May '20

29 May '20

Add DT binding of max98390 amplifier driver. Signed-off-by: Steve Lee <steves.lee(a)maximintegrated.com> --- Changed since V5: * Change txt to yaml and fix up the examples. Changed since V4: * No changes. Changed since V3: * No changes. Changed since V2: * No changes. Changed since V1: * Modified sample text in example .../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yaml diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file mode 100644 index 000000000000..1ed4ab9e1c37 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speaker Management + +maintainers: + - Steve Lee <steves.lee(a)maximintegrated.com> + +properties: + compatible: + const: maxim,max98390 + + reg: + maxItems: 1 + description: I2C address of the device. + + temperature_calib: + $ref: /schemas/types.yaml#/definitions/uint32 + description: The calculated temperature data was measured while doing the calibration. Data : Temp / 100 * 2^12 + + r0_calib: + $ref: /schemas/types.yaml#/definitions/uint32 + description: This is r0 calibration data which was measured in factory mode. + +required: + - compatible + - reg + +examples: + - | + max98390: amplifier@38 { + compatible = "maxim,max98390"; + reg = <0x38>; + maxim,temperature_calib = <1024>; + maxim,r0_calib = <100232>; + }; -- 2.17.1

3 4

alsa-ucm.c: UCM not available for card sof-bytcr-rt5640
by GitHub issues - opened 29 May '20

29 May '20

alsa-project/alsa-ucm-conf issue #28 was opened from youling257: ( 30.692| 0.006) I: [pulseaudio] (alsa-lib)main.c: error: failed to import hw:0 use case configuration -2 ( 30.693| 0.000) I: [pulseaudio] (alsa-lib)main.c: error: failed to import sof-bytcr-rt5640 use case configuration -2 ( 30.693| 0.000) I: [pulseaudio] alsa-ucm.c: UCM not available for card sof-bytcr-rt5640 Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/28 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v2 0/4] ASoC: Intel: Add KeemBay ASoC driver
by Sia Jee Heng 29 May '20

29 May '20

The below series of patches support the KeemBay ASoC driver. It enabled the tlv320aic3204 machine driver and the platform driver initialize the i2s to capture and playback the pcm data on the ARM. The i2s is running in polling mode. There is no DSP in the KeemBay SoC. Users are rely on the Gstreamer plugin to perform some Audio preprocessing. Change History: v2: - Corrected I2S naming for DT binding. v1: - Initial version. Sia Jee Heng (4): ASoC: Intel: Add KeemBay platform driver ASoC: Intel: Boards: Add KeemBay machine driver ASoC: Intel: Add makefiles and kconfig changes for KeemBay dt-bindings: sound: Add documentation for KeemBay sound card and i2s .../bindings/sound/intel,keembay-i2s.yaml | 57 ++ .../bindings/sound/intel,keembay-sound-card.yaml | 30 + sound/soc/intel/Kconfig | 7 + sound/soc/intel/Makefile | 1 + sound/soc/intel/boards/Kconfig | 15 + sound/soc/intel/boards/Makefile | 4 + sound/soc/intel/boards/kmb_tlv3204.c | 144 ++++ sound/soc/intel/keembay/Makefile | 4 + sound/soc/intel/keembay/kmb_platform.c | 746 +++++++++++++++++++++ sound/soc/intel/keembay/kmb_platform.h | 145 ++++ 10 files changed, 1153 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml create mode 100644 Documentation/devicetree/bindings/sound/intel,keembay-sound-card.yaml create mode 100644 sound/soc/intel/boards/kmb_tlv3204.c create mode 100644 sound/soc/intel/keembay/Makefile create mode 100644 sound/soc/intel/keembay/kmb_platform.c create mode 100644 sound/soc/intel/keembay/kmb_platform.h -- 1.9.1

4 11