August 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/6] ASoC: SOF: refactor duplicated code between Intel and i.MX8
by Pierre-Louis Bossart 09 Aug '19

09 Aug '19

During the initial i.MX patch reviews on GitHub, we realized a lot of the i.MX mailbox/window code was common with the Intel loader code except for a couple of offsets. Most of the credit goes to Daniel Baluta for working on this series which adds a better abstraction and reduces code duplication. Comments from Keyon and Ranjani helped remove unnecessary parts kept for historical reasons and improve the code overall. Daniel Baluta (6): ASoC: SOF: Remove call to snd_sof_dsp_mailbox_init ASoC: SOF: Introduce snd_sof_dsp_get_mailbox_offset ASoC: SOF: Introduce snd_sof_dsp_get_window_offset ASoC: SOF: Intel: byt: Refactor fw ready / mem windows creation ASoC: SOF: Intel: bdw: Use generic function for fw ready / mem windows creation ASoC: SOF: Intel: hda: Use generic function for fw ready / mem windows creation sound/soc/sof/intel/apl.c | 4 +- sound/soc/sof/intel/bdw.c | 161 +++----------------------------- sound/soc/sof/intel/byt.c | 169 ++++------------------------------ sound/soc/sof/intel/cnl.c | 4 +- sound/soc/sof/intel/hda-ipc.c | 150 +----------------------------- sound/soc/sof/intel/hda.h | 4 +- sound/soc/sof/loader.c | 168 +++++++++++++++++++++++++++++++++ sound/soc/sof/ops.h | 18 ++++ sound/soc/sof/sof-priv.h | 6 ++ 9 files changed, 237 insertions(+), 447 deletions(-) -- 2.20.1

3 14

[alsa-devel] [PATCH 0/3] ALSA: hda: bus cleanup
by Takashi Iwai 09 Aug '19

09 Aug '19

Hi, this is a few patches to simplify and cleanup the HD-audio bus ops. The first two patches translate the indirect calls of DMA page allocation and MMIO accesses with the direct ones, as well as eliminating the whole bus->io_ops. The last one is SOF-specific, and fixes/cleans up by calling the proper hdaudio bus init function, as formerly discussed. Takashi === Takashi Iwai (3): ALSA: hda: Remove page allocation redirection ALSA: hda: Direct MMIO accesses ASoC: SOF: Intel: Initialize hdaudio bus properly include/sound/hdaudio.h | 69 +++++++++++++-------------- include/sound/hdaudio_ext.h | 1 - sound/hda/Kconfig | 3 ++ sound/hda/ext/hdac_ext_bus.c | 60 +----------------------- sound/hda/hdac_bus.c | 36 ++++++++++++-- sound/hda/hdac_controller.c | 18 +++---- sound/hda/hdac_stream.c | 8 ++-- sound/pci/hda/Kconfig | 1 + sound/pci/hda/hda_controller.c | 6 +-- sound/pci/hda/hda_controller.h | 3 +- sound/pci/hda/hda_intel.c | 71 ++-------------------------- sound/pci/hda/hda_tegra.c | 84 +-------------------------------- sound/soc/intel/skylake/skl-messages.c | 15 +----- sound/soc/intel/skylake/skl.c | 7 ++- sound/soc/sof/intel/hda-bus.c | 85 ++++------------------------------ sound/soc/sof/intel/hda-dsp.c | 2 +- sound/soc/sof/intel/hda.c | 6 +-- sound/soc/sof/intel/hda.h | 3 +- 18 files changed, 107 insertions(+), 371 deletions(-) -- 2.16.4

3 12

[alsa-devel] [PATCH -next] ALSA: Au88x0 - remove some unused const variables
by YueHaibing 09 Aug '19

09 Aug '19

sound/pci/au88x0/au88x0_xtalk.c:121:28: warning: asXtalkWideCoefsRightXt defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:152:28: warning: asXtalkNarrowCoefsRightXt defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:175:28: warning: asXtalkCoefsNegPipe defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:183:28: warning: asXtalkCoefsNumTest defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:191:28: warning: asXtalkCoefsDenTest defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:199:28: warning: asXtalkOutStateTest defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:20:20: warning: sXtalkWideKRightXt defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:231:28: warning: asDiamondCoefsRightXt defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:24:20: warning: sXtalkWideShiftRightXt defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:30:20: warning: sXtalkNarrowKRightXt defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:34:20: warning: sXtalkNarrowShiftRightXt defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:38:28: warning: asXtalkGainsDefault defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:43:28: warning: asXtalkGainsTest defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:48:28: warning: asXtalkGains1Chan defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:67:28: warning: alXtalkDlineTest defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:77:30: warning: asXtalkInStateTest defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:92:20: warning: sDiamondKRightXt defined but not used [-Wunused-const-variable=] sound/pci/au88x0/au88x0_xtalk.c:96:20: warning: sDiamondShiftRightXt defined but not used [-Wunused-const-variable=] They are never used, so can be removed. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- sound/pci/au88x0/au88x0_xtalk.c | 85 ----------------------------------------- 1 file changed, 85 deletions(-) diff --git a/sound/pci/au88x0/au88x0_xtalk.c b/sound/pci/au88x0/au88x0_xtalk.c index 084fcbf..143646c 100644 --- a/sound/pci/au88x0/au88x0_xtalk.c +++ b/sound/pci/au88x0/au88x0_xtalk.c @@ -17,39 +17,20 @@ static short const sXtalkWideKLeftEq = 0x269C; static short const sXtalkWideKRightEq = 0x269C; static short const sXtalkWideKLeftXt = 0xF25E; -static short const sXtalkWideKRightXt = 0xF25E; static short const sXtalkWideShiftLeftEq = 1; static short const sXtalkWideShiftRightEq = 1; static short const sXtalkWideShiftLeftXt = 0; -static short const sXtalkWideShiftRightXt = 0; static unsigned short const wXtalkWideLeftDelay = 0xd; static unsigned short const wXtalkWideRightDelay = 0xd; static short const sXtalkNarrowKLeftEq = 0x468D; static short const sXtalkNarrowKRightEq = 0x468D; static short const sXtalkNarrowKLeftXt = 0xF82E; -static short const sXtalkNarrowKRightXt = 0xF82E; static short const sXtalkNarrowShiftLeftEq = 0x3; static short const sXtalkNarrowShiftRightEq = 0x3; static short const sXtalkNarrowShiftLeftXt = 0; -static short const sXtalkNarrowShiftRightXt = 0; static unsigned short const wXtalkNarrowLeftDelay = 0x7; static unsigned short const wXtalkNarrowRightDelay = 0x7; -static xtalk_gains_t const asXtalkGainsDefault = { - 0x4000, 0x4000, 0x4000, 0x4000, 0x4000, - 0x4000, 0x4000, 0x4000, 0x4000, 0x4000 -}; - -static xtalk_gains_t const asXtalkGainsTest = { - 0x7fff, 0x8000, 0x0000, 0x0000, 0x0001, - 0xffff, 0x4000, 0xc000, 0x0002, 0xfffe -}; - -static xtalk_gains_t const asXtalkGains1Chan = { - 0x7FFF, 0, 0, 0, 0, - 0x7FFF, 0, 0, 0, 0, -}; - // Input gain for 4 A3D slices. One possible input pair is left zero. static xtalk_gains_t const asXtalkGainsAllChan = { 0x7FFF, 0x7FFF, 0x7FFF, 0x7FFF, 0, @@ -64,20 +45,11 @@ static xtalk_dline_t const alXtalkDlineZeros = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; -static xtalk_dline_t const alXtalkDlineTest = { - 0x0000fc18, 0xfff03e8, 0x000186a0, 0xfffe7960, 1, 0xffffffff, 0, 0, - 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, - 0, 0, 0, 0, 0, 0, 0, 0 -}; static xtalk_instate_t const asXtalkInStateZeros = { 0, 0, 0, 0 }; -static xtalk_instate_t const asXtalkInStateTest = { - 0x0080, 0xff80, 0x0001, 0xffff -}; - static xtalk_state_t const asXtalkOutStateZeros = { {0, 0, 0, 0}, {0, 0, 0, 0}, @@ -89,11 +61,9 @@ static xtalk_state_t const asXtalkOutStateZeros = { static short const sDiamondKLeftEq = 0x401d; static short const sDiamondKRightEq = 0x401d; static short const sDiamondKLeftXt = 0xF90E; -static short const sDiamondKRightXt = 0xF90E; static short const sDiamondShiftLeftEq = 1; static short const sDiamondShiftRightEq = 1; static short const sDiamondShiftLeftXt = 0; -static short const sDiamondShiftRightXt = 0; static unsigned short const wDiamondLeftDelay = 0xb; static unsigned short const wDiamondRightDelay = 0xb; @@ -118,13 +88,6 @@ static xtalk_coefs_t const asXtalkWideCoefsLeftXt = { {0x77dc, 0xc79e, 0xffb8, 0x000a, 0}, {0, 0, 0, 0, 0} }; -static xtalk_coefs_t const asXtalkWideCoefsRightXt = { - {0x55c6, 0xc97b, 0x005b, 0x0047, 0}, - {0x6a60, 0xca20, 0xffc6, 0x0040, 0}, - {0x6411, 0xd711, 0xfca1, 0x0190, 0}, - {0x77dc, 0xc79e, 0xffb8, 0x000a, 0}, - {0, 0, 0, 0, 0} -}; static xtalk_coefs_t const asXtalkNarrowCoefsLeftEq = { {0x50B5, 0xD07C, 0x026D, 0xFD21, 0}, {0x460F, 0xE44F, 0xF75E, 0xEFA6, 0}, @@ -149,14 +112,6 @@ static xtalk_coefs_t const asXtalkNarrowCoefsLeftXt = { {0, 0, 0, 0, 0} }; -static xtalk_coefs_t const asXtalkNarrowCoefsRightXt = { - {0x3CB2, 0xDF49, 0xF6EA, 0x095B, 0}, - {0x6777, 0xC915, 0xFEAF, 0x00B1, 0}, - {0x7762, 0xC7D9, 0x025B, 0xFDA6, 0}, - {0x6B7A, 0xD2AA, 0xF2FB, 0x0B64, 0}, - {0, 0, 0, 0, 0} -}; - static xtalk_coefs_t const asXtalkCoefsZeros = { {0, 0, 0, 0, 0}, {0, 0, 0, 0, 0}, @@ -172,37 +127,6 @@ static xtalk_coefs_t const asXtalkCoefsPipe = { {0, 0, 0x0FA0, 0, 0}, {0, 0, 0x1180, 0, 0}, }; -static xtalk_coefs_t const asXtalkCoefsNegPipe = { - {0, 0, 0xF380, 0, 0}, - {0, 0, 0xF380, 0, 0}, - {0, 0, 0xF380, 0, 0}, - {0, 0, 0xF380, 0, 0}, - {0, 0, 0xF200, 0, 0} -}; - -static xtalk_coefs_t const asXtalkCoefsNumTest = { - {0, 0, 0xF380, 0x8000, 0x6D60}, - {0, 0, 0, 0, 0}, - {0, 0, 0, 0, 0}, - {0, 0, 0, 0, 0}, - {0, 0, 0, 0, 0} -}; - -static xtalk_coefs_t const asXtalkCoefsDenTest = { - {0xC000, 0x2000, 0x4000, 0, 0}, - {0, 0, 0, 0, 0}, - {0, 0, 0, 0, 0}, - {0, 0, 0, 0, 0}, - {0, 0, 0, 0, 0} -}; - -static xtalk_state_t const asXtalkOutStateTest = { - {0x7FFF, 0x0004, 0xFFFC, 0}, - {0xFE00, 0x0008, 0xFFF8, 0x4000}, - {0x0200, 0x0010, 0xFFF0, 0xC000}, - {0x8000, 0x0020, 0xFFE0, 0}, - {0, 0, 0, 0} -}; static xtalk_coefs_t const asDiamondCoefsLeftEq = { {0x0F1E, 0x2D05, 0xF8E3, 0x07C8, 0}, @@ -228,15 +152,6 @@ static xtalk_coefs_t const asDiamondCoefsLeftXt = { {0, 0, 0, 0, 0} }; -static xtalk_coefs_t const asDiamondCoefsRightXt = { - {0x3B50, 0xFE08, 0xF959, 0x0060, 0}, - {0x9FCB, 0xD8F1, 0x00A2, 0x003A, 0}, - {0, 0, 0, 0, 0}, - {0, 0, 0, 0, 0}, - {0, 0, 0, 0, 0} -}; - - /**/ /* XTalk EQ and XT */ static void vortex_XtalkHw_SetLeftEQ(vortex_t * vortex, short arg_0, short arg_4, -- 2.7.4

2 2

[alsa-devel] [PATCH -next] ALSA: ac97: remove unused variable 'snd_ac97_controls_master_mono'
by YueHaibing 09 Aug '19

09 Aug '19

sound/pci/ac97/ac97_codec.c:599:38: warning: snd_ac97_controls_master_mono defined but not used [-Wunused-const-variable=] It is never used, so can be removed. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- sound/pci/ac97/ac97_codec.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c index 96b4601..66f6c3b 100644 --- a/sound/pci/ac97/ac97_codec.c +++ b/sound/pci/ac97/ac97_codec.c @@ -596,11 +596,6 @@ static int snd_ac97_put_volsw(struct snd_kcontrol *kcontrol, return err; } -static const struct snd_kcontrol_new snd_ac97_controls_master_mono[2] = { -AC97_SINGLE("Master Mono Playback Switch", AC97_MASTER_MONO, 15, 1, 1), -AC97_SINGLE("Master Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 1) -}; - static const struct snd_kcontrol_new snd_ac97_controls_tone[2] = { AC97_SINGLE("Tone Control - Bass", AC97_MASTER_TONE, 8, 15, 1), AC97_SINGLE("Tone Control - Treble", AC97_MASTER_TONE, 0, 15, 1) -- 2.7.4

2 1

[alsa-devel] [PATCH] ALSA: hda - Apply workaround for another AMD chip 1022:1487
by Takashi Iwai 09 Aug '19

09 Aug '19

MSI MPG X570 board is with another AMD HD-audio controller (PCI ID 1022:1487) and it requires the same workaround applied for X370, etc (PCI ID 1022:1457). BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=195303 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_intel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index a6d8c0d77b84..99fc0917339b 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2508,6 +2508,9 @@ static const struct pci_device_id azx_ids[] = { /* AMD, X370 & co */ { PCI_DEVICE(0x1022, 0x1457), .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB }, + /* AMD, X570 & co */ + { PCI_DEVICE(0x1022, 0x1487), + .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB }, /* AMD Stoney */ { PCI_DEVICE(0x1022, 0x157a), .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_ATI_SB | -- 2.16.4

1 0

[alsa-devel] [PATCH v2 0/4] ASoC: codecs: Add WSA881x Smart Speaker amplifier support
by Srinivas Kandagatla 09 Aug '19

09 Aug '19

This patchset adds support to WSA8810/WSA8815 Class-D Smart Speaker Amplifier which is SoundWire interfaced. This also adds support to some missing bits in SoundWire bus layer like Device Tree support and module_sdw_driver macro. This patchset along with DB845c machine driver and WCD934x codec driver has been tested on SDM845 SoC based DragonBoard DB845c with two WSA8810 speakers. Most of the code in this driver is rework of Qualcomm downstream drivers used in Andriod. Credits to Banajit Goswami and Patrick Lai's Team. TODO: Add thermal sensor support in WSA881x. This patchset also depends on the soundwire Kconfig patch https://lkml.org/lkml/2019/7/18/834 from Pierre Thanks, srini Changes since v1 RFC: - bindings document renamed to slave.txt - fix error code from dt slave parsing Srinivas Kandagatla (4): dt-bindings: soundwire: add slave bindings soundwire: core: add device tree support for slave devices dt-bindings: ASoC: Add WSA881x bindings ASoC: codecs: add wsa881x amplifier support .../bindings/sound/qcom,wsa881x.txt | 27 + .../devicetree/bindings/soundwire/slave.txt | 46 + drivers/soundwire/bus.c | 2 + drivers/soundwire/bus.h | 1 + drivers/soundwire/slave.c | 47 + sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/wsa881x.c | 1160 +++++++++++++++++ 8 files changed, 1295 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa881x.txt create mode 100644 Documentation/devicetree/bindings/soundwire/slave.txt create mode 100644 sound/soc/codecs/wsa881x.c -- 2.21.0

4 20

[alsa-devel] jack plugin freezes mpv.
by GitHub issues - opened 09 Aug '19

09 Aug '19

alsa-project/alsa-plugins issue #1 was opened from crocket: I'm using alsa-plugin-1.1.8 `mpv --audio-device=alsa/plug:rawjack /path/to/musicfile` freezes mpv. mpv doesn't freeze only when it plays a wav file. I have to press Ctrl+C twice to kill mpv. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/1 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[alsa-devel] [PATCH] soundwire: fix regmap dependencies and align with other serial links
by Pierre-Louis Bossart 09 Aug '19

09 Aug '19

The existing code has a mixed select/depend usage which makes no sense. config SOUNDWIRE_BUS tristate select REGMAP_SOUNDWIRE config REGMAP_SOUNDWIRE tristate depends on SOUNDWIRE_BUS Let's remove one layer of Kconfig definitions and align with the solutions used by all other serial links. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- drivers/base/regmap/Kconfig | 2 +- drivers/soundwire/Kconfig | 7 +------ drivers/soundwire/Makefile | 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig index 6ad5ef48b61e..8cd2ac650b50 100644 --- a/drivers/base/regmap/Kconfig +++ b/drivers/base/regmap/Kconfig @@ -44,7 +44,7 @@ config REGMAP_IRQ config REGMAP_SOUNDWIRE tristate - depends on SOUNDWIRE_BUS + depends on SOUNDWIRE config REGMAP_SCCB tristate diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig index 3a01cfd70fdc..f518273cfbe3 100644 --- a/drivers/soundwire/Kconfig +++ b/drivers/soundwire/Kconfig @@ -4,7 +4,7 @@ # menuconfig SOUNDWIRE - bool "SoundWire support" + tristate "SoundWire support" help SoundWire is a 2-Pin interface with data and clock line ratified by the MIPI Alliance. SoundWire is used for transporting data @@ -17,17 +17,12 @@ if SOUNDWIRE comment "SoundWire Devices" -config SOUNDWIRE_BUS - tristate - select REGMAP_SOUNDWIRE - config SOUNDWIRE_CADENCE tristate config SOUNDWIRE_INTEL tristate "Intel SoundWire Master driver" select SOUNDWIRE_CADENCE - select SOUNDWIRE_BUS depends on X86 && ACPI && SND_SOC help SoundWire Intel Master driver. diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile index fd99a831b92a..45b7e5001653 100644 --- a/drivers/soundwire/Makefile +++ b/drivers/soundwire/Makefile @@ -5,7 +5,7 @@ #Bus Objs soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o -obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o +obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o #Cadence Objs soundwire-cadence-objs := cadence_master.o -- 2.20.1

5 7

[alsa-devel] [asoc:for-5.4 195/195] sound/soc/sof/intel/hda-ctrl.c:257:8: error: 'struct hdac_bus' has no member named 'io_ops'; did you mean 'ops'?
by kbuild test robot 09 Aug '19

09 Aug '19

tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 head: c2f16a94a80497e4b28c27f9ca2cd6cd60706fb6 commit: c2f16a94a80497e4b28c27f9ca2cd6cd60706fb6 [195/195] Merge branch 'topic/hda-bus-ops-cleanup' of https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into asoc-5.4 config: i386-randconfig-b003-201931 (attached as .config) compiler: gcc-7 (Debian 7.4.0-10) 7.4.0 reproduce: git checkout c2f16a94a80497e4b28c27f9ca2cd6cd60706fb6 # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): sound/soc/sof/intel/hda-ctrl.c: In function 'hda_dsp_ctrl_init_chip': >> sound/soc/sof/intel/hda-ctrl.c:257:8: error: 'struct hdac_bus' has no member named 'io_ops'; did you mean 'ops'? bus->io_ops->reg_writel(0, hlink->ml_addr + AZX_REG_ML_LOSIDV); ^~~~~~ ops vim +257 sound/soc/sof/intel/hda-ctrl.c be1b577d01787c Zhu Yingjiang 2019-05-24 240 be1b577d01787c Zhu Yingjiang 2019-05-24 241 /* enable CIE and GIE interrupts */ be1b577d01787c Zhu Yingjiang 2019-05-24 242 snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTCTL, be1b577d01787c Zhu Yingjiang 2019-05-24 243 SOF_HDA_INT_CTRL_EN | SOF_HDA_INT_GLOBAL_EN, be1b577d01787c Zhu Yingjiang 2019-05-24 244 SOF_HDA_INT_CTRL_EN | SOF_HDA_INT_GLOBAL_EN); be1b577d01787c Zhu Yingjiang 2019-05-24 245 be1b577d01787c Zhu Yingjiang 2019-05-24 246 /* program the position buffer */ be1b577d01787c Zhu Yingjiang 2019-05-24 247 if (bus->use_posbuf && bus->posbuf.addr) { 061edb23250579 Zhu Yingjiang 2019-07-22 248 snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR, SOF_HDA_ADSP_DPLBASE, 061edb23250579 Zhu Yingjiang 2019-07-22 249 (u32)bus->posbuf.addr); 061edb23250579 Zhu Yingjiang 2019-07-22 250 snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR, SOF_HDA_ADSP_DPUBASE, be1b577d01787c Zhu Yingjiang 2019-05-24 251 upper_32_bits(bus->posbuf.addr)); be1b577d01787c Zhu Yingjiang 2019-05-24 252 } be1b577d01787c Zhu Yingjiang 2019-05-24 253 d06973515f95ac Zhu Yingjiang 2019-07-22 254 #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA) d06973515f95ac Zhu Yingjiang 2019-07-22 255 /* Reset stream-to-link mapping */ d06973515f95ac Zhu Yingjiang 2019-07-22 256 list_for_each_entry(hlink, &bus->hlink_list, list) d06973515f95ac Zhu Yingjiang 2019-07-22 @257 bus->io_ops->reg_writel(0, hlink->ml_addr + AZX_REG_ML_LOSIDV); d06973515f95ac Zhu Yingjiang 2019-07-22 258 #endif d06973515f95ac Zhu Yingjiang 2019-07-22 259 be1b577d01787c Zhu Yingjiang 2019-05-24 260 bus->chip_init = true; be1b577d01787c Zhu Yingjiang 2019-05-24 261 be1b577d01787c Zhu Yingjiang 2019-05-24 262 hda_dsp_ctrl_misc_clock_gating(sdev, true); be1b577d01787c Zhu Yingjiang 2019-05-24 263 be1b577d01787c Zhu Yingjiang 2019-05-24 264 return ret; be1b577d01787c Zhu Yingjiang 2019-05-24 265 } 13063a2ccf79d2 Zhu Yingjiang 2019-06-12 266 :::::: The code at line 257 was first introduced by commit :::::: d06973515f95ac74d68fb3e1f1fb4b055531296c ASoC: SOF: Intel: hda: use SOF defined init chip in resume :::::: TO: Zhu Yingjiang <yingjiang.zhu(a)linux.intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [asoc:for-5.4 195/195] sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared
by kbuild test robot 09 Aug '19

09 Aug '19

tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 head: c2f16a94a80497e4b28c27f9ca2cd6cd60706fb6 commit: c2f16a94a80497e4b28c27f9ca2cd6cd60706fb6 [195/195] Merge branch 'topic/hda-bus-ops-cleanup' of https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into asoc-5.4 config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout c2f16a94a80497e4b28c27f9ca2cd6cd60706fb6 # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=sparc64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All error/warnings (new ones prefixed by >>): In file included from include/linux/kobject.h:19:0, from include/linux/device.h:16, from include/sound/hdaudio.h:9, from include/sound/hdaudio_ext.h:5, from sound/soc/sof/intel/hda-dsp.c:18: sound/soc/sof/intel/hda-dsp.c: In function 'hda_resume': >> sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared (first use in this function) list_for_each_entry(hlink, &bus->hlink_list, list) ^ include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry' for (pos = list_first_entry(head, typeof(*pos), member); \ ^~~ sound/soc/sof/intel/hda-dsp.c:360:22: note: each undeclared identifier is reported only once for each function it appears in list_for_each_entry(hlink, &bus->hlink_list, list) ^ include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry' for (pos = list_first_entry(head, typeof(*pos), member); \ ^~~ In file included from include/linux/list.h:9:0, from include/linux/kobject.h:19, from include/linux/device.h:16, from include/sound/hdaudio.h:9, from include/sound/hdaudio_ext.h:5, from sound/soc/sof/intel/hda-dsp.c:18: >> sound/soc/sof/intel/hda-dsp.c:360:30: error: 'bus' undeclared (first use in this function) list_for_each_entry(hlink, &bus->hlink_list, list) ^ include/linux/kernel.h:972:26: note: in definition of macro 'container_of' void *__mptr = (void *)(ptr); \ ^~~ include/linux/list.h:490:2: note: in expansion of macro 'list_entry' list_entry((ptr)->next, type, member) ^~~~~~~~~~ include/linux/list.h:577:13: note: in expansion of macro 'list_first_entry' for (pos = list_first_entry(head, typeof(*pos), member); \ ^~~~~~~~~~~~~~~~ >> sound/soc/sof/intel/hda-dsp.c:360:2: note: in expansion of macro 'list_for_each_entry' list_for_each_entry(hlink, &bus->hlink_list, list) ^~~~~~~~~~~~~~~~~~~ >> sound/soc/sof/intel/hda-dsp.c:364:2: error: #else without #if #else ^~~~ >> sound/soc/sof/intel/hda-dsp.c:390:2: error: #endif without #if #endif ^~~~~ vim +/hlink +360 sound/soc/sof/intel/hda-dsp.c 747503b1813a3e Liam Girdwood 2019-04-12 334 fd15f2f5e27214 Rander Wang 2019-07-22 335 static int hda_resume(struct snd_sof_dev *sdev, bool runtime_resume) 747503b1813a3e Liam Girdwood 2019-04-12 336 { 747503b1813a3e Liam Girdwood 2019-04-12 337 #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA) 747503b1813a3e Liam Girdwood 2019-04-12 338 struct hdac_bus *bus = sof_to_bus(sdev); 747503b1813a3e Liam Girdwood 2019-04-12 339 struct hdac_ext_link *hlink = NULL; 747503b1813a3e Liam Girdwood 2019-04-12 340 #endif 747503b1813a3e Liam Girdwood 2019-04-12 341 int ret; 747503b1813a3e Liam Girdwood 2019-04-12 342 747503b1813a3e Liam Girdwood 2019-04-12 343 /* 747503b1813a3e Liam Girdwood 2019-04-12 344 * clear TCSEL to clear playback on some HD Audio 747503b1813a3e Liam Girdwood 2019-04-12 345 * codecs. PCI TCSEL is defined in the Intel manuals. 747503b1813a3e Liam Girdwood 2019-04-12 346 */ 747503b1813a3e Liam Girdwood 2019-04-12 347 snd_sof_pci_update_bits(sdev, PCI_TCSEL, 0x07, 0); 747503b1813a3e Liam Girdwood 2019-04-12 348 747503b1813a3e Liam Girdwood 2019-04-12 349 /* reset and start hda controller */ 747503b1813a3e Liam Girdwood 2019-04-12 350 ret = hda_dsp_ctrl_init_chip(sdev, true); 747503b1813a3e Liam Girdwood 2019-04-12 351 if (ret < 0) { 747503b1813a3e Liam Girdwood 2019-04-12 352 dev_err(sdev->dev, 747503b1813a3e Liam Girdwood 2019-04-12 353 "error: failed to start controller after resume\n"); 747503b1813a3e Liam Girdwood 2019-04-12 354 return ret; 747503b1813a3e Liam Girdwood 2019-04-12 355 } 747503b1813a3e Liam Girdwood 2019-04-12 356 747503b1813a3e Liam Girdwood 2019-04-12 357 hda_dsp_ctrl_misc_clock_gating(sdev, false); 747503b1813a3e Liam Girdwood 2019-04-12 358 747503b1813a3e Liam Girdwood 2019-04-12 359 /* Reset stream-to-link mapping */ 747503b1813a3e Liam Girdwood 2019-04-12 @360 list_for_each_entry(hlink, &bus->hlink_list, list) 19abfefd4c7604 Takashi Iwai 2019-08-07 361 writel(0, hlink->ml_addr + AZX_REG_ML_LOSIDV); 747503b1813a3e Liam Girdwood 2019-04-12 362 747503b1813a3e Liam Girdwood 2019-04-12 363 hda_dsp_ctrl_misc_clock_gating(sdev, true); 747503b1813a3e Liam Girdwood 2019-04-12 @364 #else 747503b1813a3e Liam Girdwood 2019-04-12 365 747503b1813a3e Liam Girdwood 2019-04-12 366 hda_dsp_ctrl_misc_clock_gating(sdev, false); 747503b1813a3e Liam Girdwood 2019-04-12 367 747503b1813a3e Liam Girdwood 2019-04-12 368 /* reset controller */ 747503b1813a3e Liam Girdwood 2019-04-12 369 ret = hda_dsp_ctrl_link_reset(sdev, true); 747503b1813a3e Liam Girdwood 2019-04-12 370 if (ret < 0) { 747503b1813a3e Liam Girdwood 2019-04-12 371 dev_err(sdev->dev, 747503b1813a3e Liam Girdwood 2019-04-12 372 "error: failed to reset controller during resume\n"); 747503b1813a3e Liam Girdwood 2019-04-12 373 return ret; 747503b1813a3e Liam Girdwood 2019-04-12 374 } 747503b1813a3e Liam Girdwood 2019-04-12 375 747503b1813a3e Liam Girdwood 2019-04-12 376 /* take controller out of reset */ 747503b1813a3e Liam Girdwood 2019-04-12 377 ret = hda_dsp_ctrl_link_reset(sdev, false); 747503b1813a3e Liam Girdwood 2019-04-12 378 if (ret < 0) { 747503b1813a3e Liam Girdwood 2019-04-12 379 dev_err(sdev->dev, 747503b1813a3e Liam Girdwood 2019-04-12 380 "error: failed to ready controller during resume\n"); 747503b1813a3e Liam Girdwood 2019-04-12 381 return ret; 747503b1813a3e Liam Girdwood 2019-04-12 382 } 747503b1813a3e Liam Girdwood 2019-04-12 383 747503b1813a3e Liam Girdwood 2019-04-12 384 /* enable hda bus irq */ 747503b1813a3e Liam Girdwood 2019-04-12 385 snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTCTL, 747503b1813a3e Liam Girdwood 2019-04-12 386 SOF_HDA_INT_CTRL_EN | SOF_HDA_INT_GLOBAL_EN, 747503b1813a3e Liam Girdwood 2019-04-12 387 SOF_HDA_INT_CTRL_EN | SOF_HDA_INT_GLOBAL_EN); 747503b1813a3e Liam Girdwood 2019-04-12 388 747503b1813a3e Liam Girdwood 2019-04-12 389 hda_dsp_ctrl_misc_clock_gating(sdev, true); 24b6ff686fce80 Zhu Yingjiang 2019-06-12 @390 #endif 747503b1813a3e Liam Girdwood 2019-04-12 391 747503b1813a3e Liam Girdwood 2019-04-12 392 /* enable ppcap interrupt */ 747503b1813a3e Liam Girdwood 2019-04-12 393 hda_dsp_ctrl_ppcap_enable(sdev, true); 747503b1813a3e Liam Girdwood 2019-04-12 394 hda_dsp_ctrl_ppcap_int_enable(sdev, true); 747503b1813a3e Liam Girdwood 2019-04-12 395 :::::: The code at line 360 was first introduced by commit :::::: 747503b1813a3e6e4c52d9c0b4bd462b64940940 ASoC: SOF: Intel: Add Intel specific HDA DSP HW operations :::::: TO: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0