July 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 00/11] JZ4740 SoC cleanup
by Paul Cercueil 13 Aug '19

13 Aug '19

Hi, This patchset converts the Qi LB60 MIPS board to devicetree and makes it use all the shiny new drivers that have been developed or updated recently. All the crappy old drivers and custom code can be dropped since they have been replaced by better alternatives. Some of these alternatives are not yet in 5.3-rc1 but have already been accepted by their respective maintainer for inclusion in 5.4-rc1. To upstream this patchset, I think that as soon as MIPS maintainers agree to take patches 01-03/11 and 11/11, the other patches can go through their respective maintainer's tree. Note for MIPS maintainers: Patch 11/11 may conflict with the TCU patchset v15, should this one be accepted upstream, but the conflict is tiny and easy to fix. Should this case appear, don't hesitate to bother me about it. Thanks, -Paul

12 38

[alsa-devel] [PATCH v4 0/7] Allwinner H6 SPDIF support
by Clément Péron 12 Aug '19

12 Aug '19

*H6 DMA support IS REQUIRED* Allwinner H6 SoC has a SPDIF controller called One Wire Audio (OWA) which is different from the previous H3 generation and not compatible. Difference are an increase of fifo sizes, some memory mapping are different and there is now the possibility to output the master clock on a pin. Actually all these features are unused and only a bit for flushing the TX fifo is required. Also this series requires the DMA working on H6, a first version has been submitted by Jernej Škrabec[1] but has not been accepted yet. [1] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=89011 Changes since v3: - rename reg_fctl_ftx to val_fctl_ftx - rebase this series on sound-next - fix dt-bindings due to change in sound-next - change node name sound_spdif to sound-spdif Changes since v2: - Split quirks and H6 support patch - Add specific section for quirks comment Changes since v1: - Remove H3 compatible - Add TX fifo bit flush quirks - Add H6 bindings in SPDIF driver Clément Péron (7): dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible ASoC: sun4i-spdif: Move quirks to the top ASoC: sun4i-spdif: Add TX fifo bit flush quirks ASoC: sun4i-spdif: Add support for H6 SoC arm64: dts: allwinner: Add SPDIF node for Allwinner H6 arm64: dts: allwinner: h6: Enable SPDIF for Beelink GS1 arm64: defconfig: Enable Sun4i SPDIF module .../sound/allwinner,sun4i-a10-spdif.yaml | 1 + .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 4 ++ arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38 ++++++++++++++ arch/arm64/configs/defconfig | 1 + sound/soc/sunxi/sun4i-spdif.c | 49 ++++++++++++++++--- 5 files changed, 87 insertions(+), 6 deletions(-) -- 2.20.1

3 15

[alsa-devel] [PATCH v4 0/9]ASoC: sun4i-i2s: Updates to the driver
by codekipper＠gmail.com 12 Aug '19

12 Aug '19

From: Marcus Cooper <codekipper(a)gmail.com> Hi All, here is a patch series to add some improvements to the sun4i-i2s driver found whilst getting slave clocking and hdmi audio working on the newer SoCs. As the LibreELEC project is progressing extremely well then there has been some activity getting surround sound working and this is included. The functionality included with the new patch set has been extended to cover more sample resolutions, multi-lane data output for HDMI audio and some bug fixes that have been discovered along the way. I can see more usage of the tdm property since I last attempted to push these patches and the examples currently in mainline sort of the opposite to what I'm trying to achieve. When we first started looking at the i2s driver, the codecs that we were using allowed for the frame width to be determined based on the sampling resolution but in most use cases it seems that a fixed width is required(my highest priority should be to get HDMI audio support in). We're using the tdm property to override the old way to calculate the frame width. What I've seen in what has already been mainlined is that the i2s driver has a frame width that is fixed to 32 bits and this can be overridden using the tdm property. I still need to investigate the FIFO syncing issues which i've not had a chance to change or address the concerns that broonie and wens brought up. This change has been moved to the top of the patch stack. BR, CK --- v4 changes compared to v3 are: - Moved patches around so that the more controversial of patches are at the top of the stack. - Added more details to commit messages. - Fixed 20bit audio PCM format to use 4 bytes. - Reduced number of flags used to indicate a new SoC. v3 changes compared to v2 are: - added back slave mode changes - added back the use of tdm properties - changes to regmap and caching - removed loopback functionality - fixes to the channel offset mask v2 changes compared to v1 are: - removed slave mode changes which didn't set mclk and bclk div. - removed use of tdm and now use a dedicated property. - fix commit message to better explain reason for sign extending - add divider calculations for newer SoCs. - add support for multi-lane i2s data output. - add support for 20, 24 and 32 bit samples. - add loopback property so blocks can be tested without a codec. Marcus Cooper (9): ASoC: sun4i-i2s: Fix sun8i tx channel offset mask ASoC: sun4i-i2s: Add offset to RX channel select ASoC: sun4i-i2s: Add regmap field to sign extend sample ASoC: sun4i-i2s: Reduce quirks for sun8i-h3 ASoC: sun4i-i2s: Add set_tdm_slot functionality ASoC: sun4i-i2s: Add multi-lane functionality ASoC: sun4i-i2s: Add multichannel functionality ASoc: sun4i-i2s: Add 20, 24 and 32 bit support ASoC: sun4i-i2s: Adjust regmap settings sound/soc/sunxi/sun4i-i2s.c | 242 ++++++++++++++++++++++++------------ 1 file changed, 164 insertions(+), 78 deletions(-) -- 2.21.0

7 33

[alsa-devel] [PATCH] soundwire: fix regmap dependencies and align with other serial links
by Pierre-Louis Bossart 09 Aug '19

09 Aug '19

The existing code has a mixed select/depend usage which makes no sense. config SOUNDWIRE_BUS tristate select REGMAP_SOUNDWIRE config REGMAP_SOUNDWIRE tristate depends on SOUNDWIRE_BUS Let's remove one layer of Kconfig definitions and align with the solutions used by all other serial links. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- drivers/base/regmap/Kconfig | 2 +- drivers/soundwire/Kconfig | 7 +------ drivers/soundwire/Makefile | 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig index 6ad5ef48b61e..8cd2ac650b50 100644 --- a/drivers/base/regmap/Kconfig +++ b/drivers/base/regmap/Kconfig @@ -44,7 +44,7 @@ config REGMAP_IRQ config REGMAP_SOUNDWIRE tristate - depends on SOUNDWIRE_BUS + depends on SOUNDWIRE config REGMAP_SCCB tristate diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig index 3a01cfd70fdc..f518273cfbe3 100644 --- a/drivers/soundwire/Kconfig +++ b/drivers/soundwire/Kconfig @@ -4,7 +4,7 @@ # menuconfig SOUNDWIRE - bool "SoundWire support" + tristate "SoundWire support" help SoundWire is a 2-Pin interface with data and clock line ratified by the MIPI Alliance. SoundWire is used for transporting data @@ -17,17 +17,12 @@ if SOUNDWIRE comment "SoundWire Devices" -config SOUNDWIRE_BUS - tristate - select REGMAP_SOUNDWIRE - config SOUNDWIRE_CADENCE tristate config SOUNDWIRE_INTEL tristate "Intel SoundWire Master driver" select SOUNDWIRE_CADENCE - select SOUNDWIRE_BUS depends on X86 && ACPI && SND_SOC help SoundWire Intel Master driver. diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile index fd99a831b92a..45b7e5001653 100644 --- a/drivers/soundwire/Makefile +++ b/drivers/soundwire/Makefile @@ -5,7 +5,7 @@ #Bus Objs soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o -obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o +obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o #Cadence Objs soundwire-cadence-objs := cadence_master.o -- 2.20.1

5 7

[alsa-devel] [PATCH v2 0/2] ASoC: Intel: IPC framework updates
by Cezary Rojewski 07 Aug '19

07 Aug '19

Existing IPC framework omits crucial part of the entire communication: reply header. Some IPCs cannot function at all without the access to said header. Update the sst-ipc with new sst_ipc_message structure to represent both request and reply allowing reply-processing handlers to save received responses. Despite the range of changes required for model to be updated, no functional changes are made for core hanswell, baytrail and skylake message handlers. Reply-processing handlers now save received response header yet no usage is added by default. To allow for future changes, righful kings of IPC kingdom need to be put back on the throne. This update addresses one of them: LARGE_CONFIG_GET. Changes since v1: - Combined first four patches into single one - Rebased onto v5.4 Cezary Rojewski (2): ASoC: Intel: Update request-reply IPC model ASoC: Intel: Skylake: large_config_get overhaul sound/soc/intel/baytrail/sst-baytrail-ipc.c | 65 ++++---- sound/soc/intel/common/sst-ipc.c | 69 ++++---- sound/soc/intel/common/sst-ipc.h | 27 ++-- sound/soc/intel/haswell/sst-haswell-ipc.c | 164 +++++++++++--------- sound/soc/intel/skylake/cnl-sst.c | 6 +- sound/soc/intel/skylake/skl-messages.c | 3 +- sound/soc/intel/skylake/skl-sst-ipc.c | 152 ++++++++++-------- sound/soc/intel/skylake/skl-sst-ipc.h | 3 +- 8 files changed, 260 insertions(+), 229 deletions(-) -- 2.17.1

2 4

[alsa-devel] [PATCH v2 0/7] Add support for new SAI IP version
by Daniel Baluta 07 Aug '19

07 Aug '19

So far SAI IPs integrated with imx6 only supported one data line. Starting with imx7 and imx8 SAI integration support up to 8 data lines. New SAI IP version introduces two new registers (Version and Parmeter registers) which are placed at the beginning of register address space. For this reason we need to fix the register's address. Changes since v1: - removed patches from Lucas as they were already accepted - addressed comments from Lucas and Nicolin regarding device tree property naming - removed comment saying that "datalines" must be always consecutively enabled (this is not true, checked with IP owner) - added new patch to document newly introduced compatbile strings - removed patch introducing combined mode as I will still need some time to figure out how to properly allow users to set it. Nicolin, Unfortunately I couldn't find any clean solution on handling registers address shifts. As mentioned in patch 5/7 Tx/Rx data registers and Tx/Rx FIFO registers keep their addresses while others are shifted by 8 bytes. Even if I could create two regmaps as suggested I will still need to update each call of regmap_functions. Daniel Baluta (7): ASoC: fsl_sai: Add registers definition for multiple datalines ASoC: fsl_sai: Update Tx/Rx channel enable mask ASoC: fsl_sai: Add support to enable multiple data lines ASoC: dt-bindings: Document dl-mask property ASoC: fsl_sai: Add support for SAI new version ASoC: fsl_sai: Add support for imx7ulp/imx8mq ASoC: dt-bindings: Introduce compatible strings for 7ULP and 8MQ .../devicetree/bindings/sound/fsl-sai.txt | 10 +- sound/soc/fsl/fsl_sai.c | 331 ++++++++++++------ sound/soc/fsl/fsl_sai.h | 82 +++-- 3 files changed, 293 insertions(+), 130 deletions(-) -- 2.17.1

4 23

[alsa-devel] [PATCH v1 0/3] Allow reconfiguration of clock rate
by Jiada Wang 06 Aug '19

06 Aug '19

There is use case in Gstreamer ALSA sink, in case of changed caps Gsreatmer reconfigs and it calls snd_pcm_hw_free() before snd_pcm_prepre(). See gstreamer1.0-plugins-base/ gst-libs/gst/audio/gstaudiobasesink.c: gst_audio_base_sink_setcaps(): - gst_audio_ring_buffer_release() - gst_audio_sink_ring_buffer_release() - gst_alsasink_unprepare() - snd_pcm_hw_free() is called before - gst_audio_ring_buffer_acquire() - gst_audio_sink_ring_buffer_acquire() - gst_alsasink_prepare() - set_hwparams() - snd_pcm_hw_params() - snd_pcm_prepare() But with current implementation after clock rate is started in .prepare reconfiguration of clock rate is not allowed, unless the stream is stopped. This patch set by move stop of clock to .hw_free callback, to allow reconfiguration of clock rate. Jiada Wang (1): ASoC: rsnd: call .hw_{params,free} in pair for same stream Timo Wischer (2): ASoC: rsnd: Support hw_free() callback at DAI level ASoC: rsnd: Allow reconfiguration of clock rate sound/soc/sh/rcar/core.c | 22 +++++++++++++-- sound/soc/sh/rcar/rsnd.h | 36 ++++++++++++++++++++---- sound/soc/sh/rcar/ssi.c | 61 +++++++++++++++++++++++++++++----------- sound/soc/sh/rcar/ssiu.c | 3 +- 4 files changed, 96 insertions(+), 26 deletions(-) -- 2.19.2

3 8

[alsa-devel] [PATCH v2 00/29] ASoC: add soc-component.c
by Kuninori Morimoto 06 Aug '19

06 Aug '19

Hi Mark These are v2 of soc-component.c patch-set. I want to add multi CPU DAI support to ALSA SoC. But I noticed that we want to cleanup ALSA SoC before that. These patches will do nothing from "technical" point of view, but, will makes code readable. These are focusing to "component". Actually, soc-io.c is also for component. I'm thinking that we can merge soc-io.c into soc-component.c, but do nothing by these patch-set. 1) - 4) : new patch. it removes un-used component functions 5) - 19) : small bug fixed from v1 20) - 22) : more cleanuped 23) - 29) : cares for_each_rtdcom() loop Kuninori Morimoto (29): 1) ASoC: Intel: skl-pcm: disable skl_get_time_info 2) ASoC: soc-pcm: remove soc_rtdcom_ack() 3) ASoC: soc-pcm: remove soc_rtdcom_copy_kernel() 4) ASoC: soc-pcm: remove soc_fill_silence() 5) ASoC: add soc-component.c 6) ASoC: soc-component: add snd_soc_component_get/put() 7) ASoC: soc-component: add snd_soc_component_open() 8) ASoC: soc-component: add snd_soc_component_close() 9) ASoC: soc-component: add snd_soc_component_prepare() 10) ASoC: soc-component: add snd_soc_component_hw_params() 11) ASoC: soc-component: add snd_soc_component_hw_free() 12) ASoC: soc-component: add snd_soc_component_trigger() 13) ASoC: soc-component: add snd_soc_component_suspend() 14) ASoC: soc-component: add snd_soc_component_resume() 15) ASoC: soc-component: add snd_soc_component_is_suspended() 16) ASoC: soc-component: add snd_soc_component_probe() 17) ASoC: soc-component: add snd_soc_component_remove() 18) ASoC: soc-component: add snd_soc_component_of_xlate_dai_id() 19) ASoC: soc-component: add snd_soc_component_of_xlate_dai_name() 20) ASoC: soc-component: move snd_soc_component_seq_notifier() 21) ASoC: soc-component: move snd_soc_component_stream_event() 22) ASoC: soc-component: move snd_soc_component_set_bias_level() 23) ASoC: soc-component: add snd_soc_pcm_component_pointer() 24) ASoC: soc-component: add snd_soc_pcm_component_ioctrl() 25) ASoC: soc-component: add snd_soc_pcm_component_copy_user() 26) ASoC: soc-component: add snd_soc_pcm_component_page() 27) ASoC: soc-component: add snd_soc_pcm_component_mmap() 28) ASoC: soc-component: add snd_soc_pcm_component_pcm_new() 29) ASoC: soc-component: add snd_soc_pcm_component_pcm_free() include/sound/soc-component.h | 387 ++++++++++++++++++++++++++ include/sound/soc-dapm.h | 6 - include/sound/soc.h | 306 +-------------------- sound/soc/Makefile | 2 +- sound/soc/intel/skylake/skl-pcm.c | 3 +- sound/soc/soc-component.c | 561 ++++++++++++++++++++++++++++++++++++++ sound/soc/soc-core.c | 123 ++------- sound/soc/soc-dapm.c | 28 +- sound/soc/soc-jack.c | 18 -- sound/soc/soc-pcm.c | 260 ++---------------- sound/soc/soc-utils.c | 199 -------------- 11 files changed, 1012 insertions(+), 881 deletions(-) create mode 100644 include/sound/soc-component.h create mode 100644 sound/soc/soc-component.c -- 2.7.4

3 60

Re: [alsa-devel] [Sound-open-firmware] Signed firmware availability for kbl/cnl
by Jaroslav Kysela 05 Aug '19

05 Aug '19

Dne 24. 07. 19 v 18:09 Liam Girdwood napsal(a): > On Wed, 2019-07-24 at 18:00 +0200, Jaroslav Kysela wrote: >> Dne 24. 07. 19 v 16:41 Pierre-Louis Bossart napsal(a): >>> On 7/24/19 8:59 AM, Jaroslav Kysela wrote: >>>> Dne 23. 07. 19 v 16:22 Liam Girdwood napsal(a): >>>>> On Thu, 2019-07-18 at 16:43 +0800, Daniel Drake >>>>> wrote:_______________________________________________ >>>>>> Sound-open-firmware mailing list >>>>>> Sound-open-firmware(a)alsa-project.org >>>>>> >>>>> https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware >>>>> >>>>>> On Wed, Jul 17, 2019 at 8:09 AM Pierre-Louis Bossart >>>>>> <pierre-louis.bossart(a)linux.intel.com> >>>>>> wrote:_______________________________________________ >>>>>>> Sound-open-firmware mailing list >>>>>>> Sound-open-firmware(a)alsa-project.org >>>>>>> >>>>>> https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware >>>>>> >>>>>>> I was indeed told a while ago that there was a limited >>>>>>> number of >>>>>>> KBL-based devices with DMIC, but mistakenly assumed we >>>>>>> could avoid >>>>>>> dealing with this configuration and Murphy's Law applied of >>>>>>> course. >>>>>>> we'll have to huddle with our Intel colleagues to figure >>>>>>> this one >>>>>>> out. >>>>>> >>>>>> OK, thanks. >>>>>> >>>>>> Is there any update on the release of signed firmware files >>>>>> for the >>>>>> other platforms? We are under pressure to return the other >>>>>> unit we >>>>>> have to the vendor (which needs the cnl files), but we would >>>>>> like to >>>>>> try SOF first. >>>>>> >>>>> >>>>> Apologies for the delay, I hurt my back and was off work for a >>>>> few >>>>> weeks. Signed binaries now on v1.3 github release tag. Will now >>>>> be >>>>> upstreaming into Linux FW repo. >>>> >>>> Liam, the sizes of signed firmware binaries are a lot different >>>> than the >>>> unsigned ones (v1.3 tag) which I can build in docker: >>>> >>>> -rw-rw-r--. 1 perex perex 270336 Jul 24 15:44 sof-apl-signed- >>>> intel.ri >>>> -rw-r--r--. 1 perex perex 167936 Jul 24 15:44 sof-apl.ri >>>> -rw-rw-r--. 1 perex perex 278528 Jul 24 15:44 sof-cnl-signed- >>>> intel.ri >>>> -rw-r--r--. 1 perex perex 172032 Jul 24 15:44 sof-cnl.ri >>>> -rw-rw-r--. 1 perex perex 278528 Jul 24 15:44 sof-icl-signed- >>>> intel.ri >>>> -rw-r--r--. 1 perex perex 172032 Jul 24 15:44 sof-icl.ri >>>> >>>> Is that ok? >>> >>> The firmware used for production is typically built with the >>> Cadence >>> tools, which unfortunately are not available publicly (but can be >>> made >>> available to Intel partners). It wouldn't be surprising if the code >>> size >>> was different due to the use of intrinsics (though 100K seems like >>> a lot >>> indeed). >>> >>> Liam, I think we ought to release binaries with the community key >>> as >>> well so that people can use them as is, e.g. on the Up2 board which >>> does >>> not require the Intel production key. Same for GLK Chromebooks. >> >> It would be probably more nice to create a tar ball with all firmware >> and >> topology files bundled with the proper (usual) filesystem location >> (/lib/firmware/intel/sof/... and /lib/firmware/intel/sof-tplg/...). >> So we >> (users/distribution packagers) can just use it. > > Yeah, been thinking about this atm. It may be better to package the > binaries (firmware and topologies) as part of Linux firmware repo > (since the driver expects to load them all from lib/firmware) and > package the sources (firmware and topology) via sof tarball ? It looks good in my eyes, because topology files are another pieces of the driver from the user space perspective. The unanswered question is the UCM configuration which is linked to the topology configuration (if I understand this correctly). I proposed to place an unique identifier/version to the topology file and propagate this identifier to the user space, so the alsa-lib can pick the right UCM configuration when topology changes. The component string (snd_component_add function / struct snd_ctl_card_info -> components) can be used for this identification. Jaroslav > > Would this be OK for the distros ? > > Liam > >> >> BTW: Do we need UCM config files for SOF, too? >> >> Jaroslav >> > -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

3 12

[alsa-devel] [PATCH v2 0/3] ASoC: Codecs: Add TDA7802 codec
by Thomas Preston 02 Aug '19

02 Aug '19

Hi, This patch series adds a driver for the ST TDA7802 amplifier. Thank you Mark Brown, Charles Keepax, Cezary Rojewski and Kirill Marinushkin for your time and useful feedback (on IRC too). Sorry for taking so long in getting back to you, there were quite a lot of changes! Please let me know if there's anything else which needs changing. Many thanks, Thomas Thomas Preston (3): dt-bindings: ASoC: Add TDA7802 amplifier ASoC: Add codec driver for ST TDA7802 ASoC: TDA7802: Add turn-on diagnostic routine .../devicetree/bindings/sound/tda7802.txt | 26 + sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tda7802.c | 693 ++++++++++++++++++ 4 files changed, 727 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tda7802.txt create mode 100644 sound/soc/codecs/tda7802.c -- 2.21.0

4 29