April 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] soundwire: cdns: Fix compilation error on arm64
by Jan Kotas 27 May '19

27 May '19

On arm64 the cadence_master.c file doesn't compile. readl and writel are undefined. This patch fixes that by including io.h. Signed-off-by: Jan Kotas <jank(a)cadence.com> --- drivers/soundwire/cadence_master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index cb6a331f4..0b5bcc209 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -9,6 +9,7 @@ #include <linux/delay.h> #include <linux/device.h> #include <linux/interrupt.h> +#include <linux/io.h> #include <linux/module.h> #include <linux/mod_devicetable.h> #include <linux/soundwire/sdw_registers.h> -- 2.15.0

4 6

Re: [alsa-devel] [PATCH] ASoC: rt1308: Add RT1308 amplifier driver
by Mark Brown 16 May '19

16 May '19

On Wed, Apr 17, 2019 at 11:40:28AM +0000, Derek [方德義] wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > The ones here with comments look an awful lot like they're system specific config > > which should be left up to either platform data (or DT/ACPI configuration) or > > done at runtime (like gains). Some of the others like the pads configuration > > might also fit into that. > We don't open the DA gain setting for user at runtime, so have to set > a default level in the init list. That's not the way Linux drivers generally work... is there some technical reason for that or is it just some kind of policy decision? > > > +static void rt1308_reset(struct regmap *regmap) { > > > + regmap_write(regmap, RT1308_RESET, 0); } > > > > If we do need the init list shouldn't we also do a reninit every time we do a reset? > The init list is only set at driver probe, not every time after resetting. This is what I'm pointing out; if you don't restore these values then why set them at all?

2 10

[alsa-devel] [PATCH] ASoC: Intel: kbl: fix wrong number of channels
by Tzung-Bi Shih 13 May '19

13 May '19

Fix wrong setting on number of channels. The context wants to set constraint to 2 channels instead of 4. Signed-off-by: Tzung-Bi Shih <tzungbi(a)google.com> --- sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c index 7044d8c2b187..879f14257a3e 100644 --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c @@ -405,7 +405,7 @@ static const struct snd_pcm_hw_constraint_list constraints_dmic_channels = { }; static const unsigned int dmic_2ch[] = { - 4, + 2, }; static const struct snd_pcm_hw_constraint_list constraints_dmic_2ch = { -- 2.21.0.392.gf8f6787159e-goog

3 3

[alsa-devel] alsa-lib-1.1.6.tar.bz2: some files are missing in the tarball
by Lars Wendler 13 May '19

13 May '19

Hello list, please have a look at this Gentoo bug report [1] where a user reported that he cannot compile alsa-lib-1.1.6 with --enable-alisp configure option. The error message is: make[3]: *** No rule to make target 'SI7018/sndoc-mixer.alisp', needed by 'all-am'. Stop. This happens because the directory src/conf/cards/SI7018 is missing as well as the following files: src/conf/cards/aliases.alisp src/conf/smixer.conf src/conf/sndo-mixer.alisp First I thought those files were removed intentionally but checking the alsa-lib git tree I can see all files still being available. So at Gentoo we fixed this by re-adding the files through a patch [2]. Any chance this was an accidental oversight? Kind regards Lars [1] https://bugs.gentoo.org/652422 [2] https://gitweb.gentoo.org/repo/gentoo.git/tree/media-libs/alsa-lib/files/al… P.S.: Please CC me on replies as I am not subscribed to the list. -- Lars Wendler Gentoo package maintainer GPG: 21CC CF02 4586 0A07 ED93 9F68 498F E765 960E 9B39

2 3

[alsa-devel] [PATCH] ASoC: cs42xx8: Add reset gpio handling
by S.j. Wang 08 May '19

08 May '19

Handle the reset GPIO and reset the device in pm_runtime_resume Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/codecs/cs42xx8.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/sound/soc/codecs/cs42xx8.c b/sound/soc/codecs/cs42xx8.c index ebb9e0cf8364..fc28e6d26c6d 100644 --- a/sound/soc/codecs/cs42xx8.c +++ b/sound/soc/codecs/cs42xx8.c @@ -14,6 +14,7 @@ #include <linux/delay.h> #include <linux/module.h> #include <linux/of_device.h> +#include <linux/of_gpio.h> #include <linux/pm_runtime.h> #include <linux/regulator/consumer.h> #include <sound/pcm_params.h> @@ -45,6 +46,7 @@ struct cs42xx8_priv { bool slave_mode; unsigned long sysclk; u32 tx_channels; + int gpio_reset; }; /* -127.5dB to 0dB with step of 0.5dB */ @@ -467,6 +469,17 @@ int cs42xx8_probe(struct device *dev, struct regmap *regmap) return -EINVAL; } + cs42xx8->gpio_reset = of_get_named_gpio(dev->of_node, "gpio-reset", 0); + if (gpio_is_valid(cs42xx8->gpio_reset)) { + ret = devm_gpio_request_one(dev, cs42xx8->gpio_reset, + GPIOF_OUT_INIT_LOW, "cs42xx8 reset"); + if (ret) { + dev_err(dev, "unable to get reset gpio\n"); + return ret; + } + gpio_set_value_cansleep(cs42xx8->gpio_reset, 1); + } + cs42xx8->clk = devm_clk_get(dev, "mclk"); if (IS_ERR(cs42xx8->clk)) { dev_err(dev, "failed to get the clock: %ld\n", @@ -547,6 +560,11 @@ static int cs42xx8_runtime_resume(struct device *dev) return ret; } + if (gpio_is_valid(cs42xx8->gpio_reset)) { + gpio_set_value_cansleep(cs42xx8->gpio_reset, 0); + gpio_set_value_cansleep(cs42xx8->gpio_reset, 1); + } + ret = regulator_bulk_enable(ARRAY_SIZE(cs42xx8->supplies), cs42xx8->supplies); if (ret) { @@ -559,6 +577,7 @@ static int cs42xx8_runtime_resume(struct device *dev) regcache_cache_only(cs42xx8->regmap, false); + regcache_mark_dirty(cs42xx8->regmap); ret = regcache_sync(cs42xx8->regmap); if (ret) { dev_err(dev, "failed to sync regmap: %d\n", ret); -- 1.9.1

2 1

[alsa-devel] [PATCH V5] ASoC: fsl_esai: Fix missing break in switch statement
by S.j. Wang 08 May '19

08 May '19

case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of each other, so replace fall-through with break. Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> Acked-by: Nicolin Chen <nicoleotsuka(a)gmail.com> Cc: <stable(a)vger.kernel.org> --- Changes in v5 - remove new line after Fixes Changes in v4 - Add acked-by Changes in v3 - Update subject line and cc stable Changes in v2 - Fix "Fixes" tag sound/soc/fsl/fsl_esai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 3623aa9a6f2e..15202a637197 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, break; case ESAI_HCKT_EXTAL: ecr |= ESAI_ECR_ETI; - /* fall through */ + break; case ESAI_HCKR_EXTAL: ecr |= ESAI_ECR_ERI; break; -- 1.9.1

3 2

[alsa-devel] Right internal speaker and internal microphone doesn't seem to work
by Drago Praznik 07 May '19

07 May '19

My Mint 19 (kernel: 4.15.0-48-generic) on Lenovo V110 never succeeded to use an internal microphone and the right internal speaker also doesn't seem to work. Previously I tried to install Windows 10 and all the hardware works normally whilst using Win10. Here's some additional info of my setup: http://alsa-project.org/db/?f=9e9d2f773b9682f2dbd2a22cd1f4fd0613eb0a2d Originally I submitted a post on forum: https://forums.linuxmint.com/viewtopic.php?f=49&t=292732 ... since it didn't help, I ended up here. Cheers, Drago

3 4

[alsa-devel] [PATCH] ASoC: sprd: Add reserved DMA memory support
by Baolin Wang 07 May '19

07 May '19

For Spreadtrum audio platform driver, it need allocate a larger DMA buffer dynamically to copy audio data between userspace and kernel space, but that will increase the risk of memory allocation failure especially the system is under heavy load situation. To make sure the audio can work in this scenario, we usually reserve one region of memory to be used as a shared pool of DMA buffers for the platform component. So add of_reserved_mem_device_init_by_idx() function to initialize the shared pool of DMA buffers to be used by the platform component. Signed-off-by: Baolin Wang <baolin.wang(a)linaro.org> --- sound/soc/sprd/sprd-pcm-dma.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/sprd/sprd-pcm-dma.c b/sound/soc/sprd/sprd-pcm-dma.c index 9be6d4b..d38ebbb 100644 --- a/sound/soc/sprd/sprd-pcm-dma.c +++ b/sound/soc/sprd/sprd-pcm-dma.c @@ -6,6 +6,7 @@ #include <linux/dma/sprd-dma.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/of_reserved_mem.h> #include <linux/platform_device.h> #include <sound/pcm.h> #include <sound/pcm_params.h> @@ -530,8 +531,14 @@ static void sprd_pcm_free(struct snd_pcm *pcm) static int sprd_soc_platform_probe(struct platform_device *pdev) { + struct device_node *np = pdev->dev.of_node; int ret; + ret = of_reserved_mem_device_init_by_idx(&pdev->dev, np, 0); + if (ret) + dev_warn(&pdev->dev, + "no reserved DMA memory for audio platform device\n"); + ret = devm_snd_soc_register_component(&pdev->dev, &sprd_soc_component, NULL, 0); if (ret) -- 1.7.9.5

2 5

[alsa-devel] [PATCH v3 00/26] compat_ioctl: cleanups
by Arnd Bergmann 06 May '19

06 May '19

Hi Al, It took me way longer than I had hoped to revisit this series, see https://lore.kernel.org/lkml/20180912150142.157913-1-arnd@arndb.de/ for the previously posted version. I've come to the point where all conversion handlers and most COMPATIBLE_IOCTL() entries are gone from this file, but for now, this series only has the parts that have either been reviewed previously, or that are simple enough to include. The main missing piece is the SG_IO/SG_GET_REQUEST_TABLE conversion. I'll post the patches I made for that later, as they need more testing and review from the scsi maintainers. I hope you can still take these for the coming merge window, unless new problems come up. Arnd Arnd Bergmann (26): compat_ioctl: pppoe: fix PPPOEIOCSFWD handling compat_ioctl: move simple ppp command handling into driver compat_ioctl: avoid unused function warning for do_ioctl compat_ioctl: move PPPIOCSCOMPRESS32 to ppp-generic.c compat_ioctl: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c compat_ioctl: handle PPPIOCGIDLE for 64-bit time_t compat_ioctl: move rtc handling into rtc-dev.c compat_ioctl: add compat_ptr_ioctl() compat_ioctl: move drivers to compat_ptr_ioctl compat_ioctl: use correct compat_ptr() translation in drivers ceph: fix compat_ioctl for ceph_dir_operations compat_ioctl: move more drivers to compat_ptr_ioctl compat_ioctl: move tape handling into drivers compat_ioctl: move ATYFB_CLK handling to atyfb driver compat_ioctl: move isdn/capi ioctl translation into driver compat_ioctl: move rfcomm handlers into driver compat_ioctl: move hci_sock handlers into driver compat_ioctl: remove HCIUART handling compat_ioctl: remove HIDIO translation compat_ioctl: remove translation for sound ioctls compat_ioctl: remove IGNORE_IOCTL() compat_ioctl: remove /dev/random commands compat_ioctl: remove joystick ioctl translation compat_ioctl: remove PCI ioctl translation compat_ioctl: remove /dev/raw ioctl translation compat_ioctl: remove last RAID handling code Documentation/networking/ppp_generic.txt | 2 + arch/um/drivers/hostaudio_kern.c | 1 + drivers/android/binder.c | 2 +- drivers/char/ppdev.c | 12 +- drivers/char/random.c | 1 + drivers/char/tpm/tpm_vtpm_proxy.c | 12 +- drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 +- drivers/dma-buf/dma-buf.c | 4 +- drivers/dma-buf/sw_sync.c | 2 +- drivers/dma-buf/sync_file.c | 2 +- drivers/firewire/core-cdev.c | 12 +- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- drivers/hid/hidraw.c | 4 +- drivers/hid/usbhid/hiddev.c | 11 +- drivers/hwtracing/stm/core.c | 12 +- drivers/ide/ide-tape.c | 31 +- drivers/iio/industrialio-core.c | 2 +- drivers/infiniband/core/uverbs_main.c | 4 +- drivers/isdn/capi/capi.c | 31 + drivers/isdn/i4l/isdn_ppp.c | 14 +- drivers/media/rc/lirc_dev.c | 4 +- drivers/mfd/cros_ec_dev.c | 4 +- drivers/misc/cxl/flash.c | 8 +- drivers/misc/genwqe/card_dev.c | 23 +- drivers/misc/mei/main.c | 22 +- drivers/misc/vmw_vmci/vmci_host.c | 2 +- drivers/mtd/ubi/cdev.c | 36 +- drivers/net/ppp/ppp_generic.c | 99 +++- drivers/net/ppp/pppoe.c | 7 + drivers/net/ppp/pptp.c | 3 + drivers/net/tap.c | 12 +- drivers/nvdimm/bus.c | 4 +- drivers/nvme/host/core.c | 2 +- drivers/pci/switch/switchtec.c | 2 +- drivers/platform/x86/wmi.c | 2 +- drivers/rpmsg/rpmsg_char.c | 4 +- drivers/rtc/dev.c | 13 +- drivers/rtc/rtc-vr41xx.c | 10 + drivers/s390/char/tape_char.c | 41 +- drivers/sbus/char/display7seg.c | 2 +- drivers/sbus/char/envctrl.c | 4 +- drivers/scsi/3w-xxxx.c | 4 +- drivers/scsi/cxlflash/main.c | 2 +- drivers/scsi/esas2r/esas2r_main.c | 2 +- drivers/scsi/megaraid/megaraid_mm.c | 28 +- drivers/scsi/osst.c | 34 +- drivers/scsi/pmcraid.c | 4 +- drivers/scsi/st.c | 35 +- drivers/staging/android/ion/ion.c | 4 +- drivers/staging/pi433/pi433_if.c | 12 +- drivers/staging/vme/devices/vme_user.c | 2 +- drivers/tee/tee_core.c | 2 +- drivers/usb/class/cdc-wdm.c | 2 +- drivers/usb/class/usbtmc.c | 4 +- drivers/usb/core/devio.c | 16 +- drivers/usb/gadget/function/f_fs.c | 12 +- drivers/vfio/vfio.c | 39 +- drivers/vhost/net.c | 12 +- drivers/vhost/scsi.c | 12 +- drivers/vhost/test.c | 12 +- drivers/vhost/vsock.c | 12 +- drivers/video/fbdev/aty/atyfb_base.c | 12 +- drivers/virt/fsl_hypervisor.c | 2 +- fs/btrfs/super.c | 2 +- fs/ceph/dir.c | 1 + fs/ceph/file.c | 2 +- fs/compat_ioctl.c | 602 +------------------- fs/fat/file.c | 13 +- fs/fuse/dev.c | 2 +- fs/notify/fanotify/fanotify_user.c | 2 +- fs/userfaultfd.c | 2 +- include/linux/fs.h | 7 + include/linux/if_pppox.h | 2 + include/linux/mtio.h | 58 ++ include/uapi/linux/ppp-ioctl.h | 2 + include/uapi/linux/ppp_defs.h | 14 + net/bluetooth/hci_sock.c | 21 +- net/bluetooth/rfcomm/sock.c | 14 +- net/l2tp/l2tp_ppp.c | 3 + net/rfkill/core.c | 2 +- sound/core/oss/pcm_oss.c | 4 + sound/oss/dmasound/dmasound_core.c | 2 + 82 files changed, 452 insertions(+), 1034 deletions(-) create mode 100644 include/linux/mtio.h -- 2.20.0 Cc: "David S. Miller" <davem(a)davemloft.net> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Karsten Keil <isdn(a)linux-pingi.de> Cc: "James E.J. Bottomley" <jejb(a)linux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen(a)oracle.com> Cc: Marcel Holtmann <marcel(a)holtmann.org> Cc: netdev(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: devel(a)driverdev.osuosl.org Cc: linux-integrity(a)vger.kernel.org Cc: qat-linux(a)intel.com Cc: linux-crypto(a)vger.kernel.org Cc: linux-media(a)vger.kernel.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux1394-devel(a)lists.sourceforge.net Cc: amd-gfx(a)lists.freedesktop.org Cc: linux-input(a)vger.kernel.org Cc: linux-usb(a)vger.kernel.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-ide(a)vger.kernel.org Cc: linux-iio(a)vger.kernel.org Cc: linux-rdma(a)vger.kernel.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: linux-mtd(a)lists.infradead.org Cc: linux-ppp(a)vger.kernel.org Cc: linux-nvme(a)lists.infradead.org Cc: platform-driver-x86(a)vger.kernel.org Cc: linux-remoteproc(a)vger.kernel.org Cc: linux-rtc(a)vger.kernel.org Cc: linux-s390(a)vger.kernel.org Cc: sparclinux(a)vger.kernel.org Cc: linux-scsi(a)vger.kernel.org Cc: linux-fbdev(a)vger.kernel.org Cc: linux-btrfs(a)vger.kernel.org Cc: ceph-devel(a)vger.kernel.org Cc: linux-fsdevel(a)vger.kernel.org Cc: linux-bluetooth(a)vger.kernel.org Cc: linux-wireless(a)vger.kernel.org Cc: alsa-devel(a)alsa-project.org Cc: y2038(a)lists.linaro.org

4 7

[alsa-devel] [PATCH] Aseqnet, no nagle and dual stack
by Rob van der Putten 05 May '19

05 May '19

Hi there Not an ALSA source patch, but a patch for an ALSA related util. Aseqnet sends ALSA sound_seq MIDI over TCP/IP. The patch below disables nagle, enables quickack and makes aseqnet dual-stack. --- aseqnet.c.bak 2012-01-25 10:43:38.000000000 +0100 +++ aseqnet.c 2017-08-26 14:17:58.261868853 +0200 @@ -3,6 +3,8 @@ * ver.0.1 * * Copyright (C) 1999-2000 Takashi Iwai + * Modified by Rob van der Putten, Leiden, Holland, + * rob at sput dot nl. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -15,18 +17,21 @@ * */ +#include <alsa/asoundlib.h> +#include <arpa/inet.h> +#include <assert.h> +#include <ctype.h> +#include <getopt.h> +#include <locale.h> +#include <netdb.h> +#include <netinet/in.h> +#include <netinet/tcp.h> +#include <signal.h> #include <stdio.h> #include <stdlib.h> -#include <ctype.h> #include <string.h> -#include <netinet/in.h> #include <sys/socket.h> -#include <netdb.h> -#include <locale.h> -#include <alsa/asoundlib.h> -#include <getopt.h> -#include <signal.h> -#include <assert.h> +#include <sys/types.h> #include "aconfig.h" #include "gettext.h" @@ -327,17 +332,24 @@ */ static void init_server(int port) { + /* + * RvdP, changed to support IPv6 + * Dual stack only! + */ int i; int curstate = 1; - struct sockaddr_in addr; + int ipv6only = 0; + int nodelay = 1; + int quickack = 1; + struct sockaddr_in6 addr; memset(&addr, 0, sizeof(addr)); - addr.sin_family = AF_INET; - addr.sin_addr.s_addr = INADDR_ANY; - addr.sin_port = htons(port); + addr.sin6_family = AF_INET6; + inet_pton(AF_INET6, "::", &(addr.sin6_addr)); + addr.sin6_port = htons(port); - sockfd = socket(AF_INET, SOCK_STREAM, 0); + sockfd = socket(PF_INET6, SOCK_STREAM, 0); if (sockfd < 0) { perror("create socket"); exit(1); @@ -345,7 +357,19 @@ setsockopt(sockfd, SOL_SOCKET, SO_REUSEADDR, &curstate, sizeof(curstate)); /* the return value is ignored.. */ - if (bind(sockfd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { + /* Force dual stack */ + setsockopt(sockfd, IPPROTO_IPV6, IPV6_V6ONLY, &ipv6only, sizeof(ipv6only)); + /* the return value is ignored.. */ + + /* Nagle and quickack */ + if ((setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, &nodelay, sizeof(nodelay))) < 0) { + perror("Error setsockopt tcp_nodelay"); + } + if ((setsockopt(sockfd, IPPROTO_TCP, TCP_QUICKACK, &quickack, sizeof(quickack))) < 0) { + perror("Error setsockopt tcp_quickack"); + } + + if (bind(sockfd, (struct sockaddr *) &addr, sizeof(addr)) < 0) { perror("can't bind"); exit(1); } @@ -394,30 +418,58 @@ */ static void init_client(char *server, int port) { - struct sockaddr_in addr; - struct hostent *host; - int curstate = 1; - int fd; + /* + * RvdP, changed to support IPv6 + */ - if ((fd = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0){ - perror("create socket"); + struct addrinfo hints; + struct addrinfo *result, *rp; + int curstate = 1; + int nodelay = 1; + int quickack = 1; + int fd, s; + char portstr[8]; + + memset(&hints, 0, sizeof(struct addrinfo)); + hints.ai_family = AF_UNSPEC; + hints.ai_socktype = SOCK_STREAM; + /* hints.ai_protocol = IPPROTO_TCP; */ + hints.ai_flags = 0; + + memset(portstr, 0, 8); + snprintf(portstr, 6, "%d", port); + + s = getaddrinfo(server, portstr, &hints, &result); + if (s != 0) { + fprintf(stderr, "getaddrinfo: %s\n", gai_strerror(s)); + exit(1); + } + for (rp = result; rp != NULL; rp = rp->ai_next) { + fd = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol); + if (fd == -1) + continue; + if (connect(fd, rp->ai_addr, rp->ai_addrlen) != -1) + break; + close(fd); + } + if (rp == NULL) { + fprintf(stderr, "Could not connect\n"); exit(1); } + if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &curstate, sizeof(curstate)) < 0) { perror("setsockopt"); exit(1); } - if ((host = gethostbyname(server)) == NULL){ - fprintf(stderr, _("can't get address %s\n"), server); - exit(1); + + /* RvdP, nagle and quickack */ + if ((setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &nodelay, sizeof(nodelay))) < 0) { + perror("Error setsockopt tcp_nodelay"); } - addr.sin_port = htons(port); - addr.sin_family = AF_INET; - memcpy(&addr.sin_addr, host->h_addr, host->h_length); - if (connect(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { - perror("connect"); - exit(1); + if ((setsockopt(fd, IPPROTO_TCP, TCP_QUICKACK, &quickack, sizeof(quickack))) < 0) { + perror("Error setsockopt tcp_quickack"); } + if (verbose) fprintf(stderr, _("ok.. connected\n")); netfd[0] = fd; Regards, Rob

2 3