March 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH AUTOSEL 5.0 118/262] SoC: imx-sgtl5000: add missing put_device()
by Sasha Levin 27 Mar '19

27 Mar '19

From: Wen Yang <yellowriver2010(a)hotmail.com> [ Upstream commit 8fa857da9744f513036df1c43ab57f338941ae7d ] The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Detected by coccinelle with the following warnings: ./sound/soc/fsl/imx-sgtl5000.c:169:1-7: ERROR: missing put_device; call of_find_device_by_node on line 105, but without a corresponding object release within this function. ./sound/soc/fsl/imx-sgtl5000.c:177:1-7: ERROR: missing put_device; call of_find_device_by_node on line 105, but without a corresponding object release within this function. Signed-off-by: Wen Yang <yellowriver2010(a)hotmail.com> Cc: Timur Tabi <timur(a)kernel.org> Cc: Nicolin Chen <nicoleotsuka(a)gmail.com> Cc: Xiubo Li <Xiubo.Lee(a)gmail.com> Cc: Fabio Estevam <festevam(a)gmail.com> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: Shawn Guo <shawnguo(a)kernel.org> Cc: Sascha Hauer <s.hauer(a)pengutronix.de> Cc: Pengutronix Kernel Team <kernel(a)pengutronix.de> Cc: NXP Linux Team <linux-imx(a)nxp.com> Cc: alsa-devel(a)alsa-project.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/fsl/imx-sgtl5000.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index c29200cf755a..9b9a7ec52905 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -108,6 +108,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) ret = -EPROBE_DEFER; goto fail; } + put_device(&ssi_pdev->dev); codec_dev = of_find_i2c_device_by_node(codec_np); if (!codec_dev) { dev_err(&pdev->dev, "failed to find codec platform device\n"); -- 2.19.1

1 0

[alsa-devel] [PATCH -next] ASoC: fix SND_SOC_LOCHNAGAR_SC kconfig warning
by Randy Dunlap 27 Mar '19

27 Mar '19

From: Randy Dunlap <rdunlap(a)infradead.org> Fix kconfig warning for SND_SOC_LOCHNAGAR_SC: WARNING: unmet direct dependencies detected for SND_SOC_LOCHNAGAR_SC Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=m] && MFD_LOCHNAGAR [=n] Selected by [m]: - SND_SOC_ALL_CODECS [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=m] && COMPILE_TEST [=y] Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Piotr Stankiewicz <piotrs(a)opensource.cirrus.com> Cc: Charles Keepax <ckeepax(a)opensource.cirrus.com> Cc: Richard Fitzgerald <rf(a)opensource.cirrus.com> Cc: patches(a)opensource.cirrus.com Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: alsa-devel(a)alsa-project.org --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20190327.orig/sound/soc/codecs/Kconfig +++ linux-next-20190327/sound/soc/codecs/Kconfig @@ -94,7 +94,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_JZ4725B_CODEC select SND_SOC_LM4857 if I2C select SND_SOC_LM49453 if I2C - select SND_SOC_LOCHNAGAR_SC + select SND_SOC_LOCHNAGAR_SC if MFD_LOCHNAGAR select SND_SOC_MAX98088 if I2C select SND_SOC_MAX98090 if I2C select SND_SOC_MAX98095 if I2C

2 1

[alsa-devel] [PATCH 0/4] ALSA: yet more timer cleanup and fixes
by Takashi Iwai 27 Mar '19

27 Mar '19

Hi, while looking at the old syzkaller reports, I noticed that there are still some possible races around closing the timer object. Here is a patch set to cover it as well as some relevant cleanups / fixes. I haven't set stable to Cc in them since they are really corner cases, and they haven't been tested much. But they should be safe (and easy) to backport, too, if any. Takashi === Takashi Iwai (4): ALSA: timer: Unify timer callback process code ALSA: timer: Make sure to clear pending ack list ALSA: timer: Check ack_list emptiness instead of bit flag ALSA: timer: Make snd_timer_close() really kill pending actions include/sound/timer.h | 1 - sound/core/timer.c | 123 ++++++++++++++++++++++++++++++-------------------- 2 files changed, 74 insertions(+), 50 deletions(-) -- 2.16.4

1 4

[alsa-devel] [PATCH] amixer: define _GNU_SOURCE to get exp10
by Milton Vandersloot 27 Mar '19

27 Mar '19

Hi I get a warning about the implicit declaration of exp10 for amixer (not alsamixer). The same issue was reported at beginning of the year for alsamixer [0,1] and solved by adding -D_GNU_SOURCE to the CFLAGS. (In fact both alsamixer and amixer use the same file alsamixer/volume_mapping.c.) I suggest adding the same CFLAG also to the amixer Makefile.am. Cheers Milton [0] https://patchwork.kernel.org/patch/10765311/ [1] commit 116488e5f2f1b897084bd151381ee254e1cc177d Patch suggestion: >From d31f804d171e7548ecf6e96e96edc7a694a51612 Mon Sep 17 00:00:00 2001 From: Milton Vandersloot <miltonvandersloot(a)fake-box.com> Date: Wed, 27 Mar 2019 17:36:54 +0100 Subject: [PATCH] amixer: define _GNU_SOURCE to get exp10 Get rid of a warning about implicit declarition of exp10, which is behind _GNU_SOURCE as a non-standard feature. The same problem was fixed for alsamixer in commit 116488e5f2f1b897084bd151381ee254e1cc177d. --- amixer/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/amixer/Makefile.am b/amixer/Makefile.am index 0343c8e..b4526ca 100644 --- a/amixer/Makefile.am +++ b/amixer/Makefile.am @@ -1,3 +1,4 @@ +AM_CFLAGS = -D_GNU_SOURCE AM_CPPFLAGS = -I$(top_srcdir)/include LDADD = -lm # LDFLAGS = -static

1 0

[alsa-devel] [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''
by YueHaibing 27 Mar '19

27 Mar '19

Fixes gcc '-Wunused-but-set-variable' warning: sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk': sound/soc/generic/simple-card-utils.c:164:18: warning: parameter 'dai_name' set but not used [-Wunused-but-set-parameter] It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add asoc_simple_debug_info()"), so can be removed. Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- sound/soc/generic/simple-card-utils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c index 4ed68348f939..db1458a19985 100644 --- a/sound/soc/generic/simple-card-utils.c +++ b/sound/soc/generic/simple-card-utils.c @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev, * see * soc-core.c :: snd_soc_init_multicodec() */ - if (dlc) { + if (dlc) dai_of_node = dlc->of_node; - dai_name = dlc->dai_name; - } /* * Parse dai->sysclk come from "clocks = <&xxx>"

3 7

[alsa-devel] [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call
by Aditya Pakki 27 Mar '19

27 Mar '19

Unlike other drivers probe method, of_match_node return value is not used or checked. This patch removes the redundant code. Signed-off-by: Aditya Pakki <pakki001(a)umn.edu> --- v2: Move the signed by above the version change log v1: A check is unnecessary as match is never used. --- sound/soc/codecs/sirf-audio-codec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c index e424499a8450..e0af21050078 100644 --- a/sound/soc/codecs/sirf-audio-codec.c +++ b/sound/soc/codecs/sirf-audio-codec.c @@ -461,9 +461,6 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev) struct sirf_audio_codec *sirf_audio_codec; void __iomem *base; struct resource *mem_res; - const struct of_device_id *match; - - match = of_match_node(sirf_audio_codec_of_match, pdev->dev.of_node); sirf_audio_codec = devm_kzalloc(&pdev->dev, sizeof(struct sirf_audio_codec), GFP_KERNEL); -- 2.17.1

3 3

[alsa-devel] [PATCH 0/2] Replace with alloc_pages_exact(), take#2
by Takashi Iwai 27 Mar '19

27 Mar '19

Hi, this is a renewed attempt to replace __get_free_pages() usages with alloc_pages_exact() in sound tree. At this time, the incorrectly leftover of __GFP_COMP flag is removed altogether. thanks, Takashi === Takashi Iwai (2): ALSA: Replace snd_malloc_pages() and snd_free_pages() with standard helpers, take#2 ALSA: us122l: Use alloc_pages_exact() include/sound/memalloc.h | 4 ---- sound/core/memalloc.c | 53 +++-------------------------------------- sound/core/pcm.c | 14 +++++------ sound/usb/usx2y/usX2Yhwdep.c | 3 ++- sound/usb/usx2y/usb_stream.c | 20 +++++++--------- sound/usb/usx2y/usbusx2y.c | 3 ++- sound/usb/usx2y/usx2yhwdeppcm.c | 6 +++-- 7 files changed, 26 insertions(+), 77 deletions(-) -- 2.16.4

2 6

[alsa-devel] [PATCH v12 0/5] Media Device Allocator API
by Shuah Khan 27 Mar '19

27 Mar '19

Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Video class, two or more independent drivers will share a single physical USB bridge. In such cases, it is necessary to coordinate access to the shared resource. Using this API, drivers can allocate a media device with the shared struct device as the key. Once the media device is allocated by a driver, other drivers can get a reference to it. The media device is released when all the references are released. - This patch series in tested on 5.1-rc2 and addresses the compile errors, warns, and sparse errors reported by Hans Verkuil and Dan Carpenter. Changes since v11: - Patch 1: Add CONFIG_MODULES dependency in media_dev_allocator files. to fix compile errors when CONFIG_MODULES is disabled. - Patch 2, 3: No changes. - Patch 4: Fix sparse error reported by Dan Carpenter. - Patch 5: Fix warns found by Hans Verkuil. - v11 was tested on 5.0-rc7 and addresses comments on v10 series from Hans Verkuil. Fixed problems found in resource sharing logic in au0828 adding a patch 5 to this series. The test plan used for testing resource sharing could serve as a regression test plan and the test results can be found at: https://docs.google.com/document/d/1XMs3HYgLiHby6xVIvIxv75KSXAAN3F4uUpw2uLu… - v10 was tested on 5.0-rc3 and addresses comments on v9 series from Hans Verkuil. Changes since v10: - Patch 1: Fixed SPDX tag and removed redundant IS_ENABLED(CONFIG_USB) around media_device_usb_allocate() - Sakari Ailus's review comment. - Patch 2 and 3: No changes - Patch 4: Fixed SPDX tag - Sakari Ailus's review comment. - Carried Reviewed-by tag from Takashi Iwai for the sound from v9. - Patch 5: This is a new patch added to fix resource sharing inconsistencies and problem found during testing using Han's tests. Changes since v9: - Patch 1: Fix mutex assert warning from find_module() calls. This code was written before the change to find_module() that requires callers to hold module_mutex. I missed this during my testing on 4.20-rc6. Hans Verkuil reported the problem. - Patch 4: sound/usb: Initializes all the entities it can before registering the device based on comments from Hans Verkuil - Carried Reviewed-by tag from Takashi Iwai for the sound from v9. - No changes to Patches 2 and 3. - v9 was tested on 4.20-rc6. - Tested sharing resources with kaffeine, vlc, xawtv, tvtime, and arecord. When analog is streaming, digital and audio user-space applications detect that the tuner is busy and exit. When digital is streaming, analog and audio applications detect that the tuner is busy and exit. When arecord is owns the tuner, digital and analog detect that the tuner is busy and exit. - Tested media device allocator API with bind/unbind testing on snd-usb-audio and au0828 drivers to make sure /dev/mediaX is released only when the last driver is unbound. - Addressed review comments from Hans on the RFC v8 (rebased on 4.19) - Updated change log to describe the use-case more clearly. - No changes to 0001,0002 code since the v7 referenced below. - 0003 is a new patch to enable ALSA defines that have been disabled for kernel between 4.9 and 4.19. - Minor merge conflict resolution in 0004. - Added SPDX to new files. References: https://lkml.org/lkml/2018/11/2/169 https://www.mail-archive.com/linux-media@vger.kernel.org/msg105854.html Shuah Khan (5): media: Media Device Allocator API media: change au0828 to use Media Device Allocator API media: media.h: Enable ALSA MEDIA_INTF_T* interface types sound/usb: Use Media Controller API to share media resources au0828: fix enable and disable source audio and video inconsistencies Documentation/media/kapi/mc-core.rst | 41 ++++ drivers/media/Makefile | 6 + drivers/media/media-dev-allocator.c | 142 +++++++++++ drivers/media/usb/au0828/au0828-core.c | 194 +++++++++++---- drivers/media/usb/au0828/au0828.h | 6 +- include/media/media-dev-allocator.h | 54 ++++ include/uapi/linux/media.h | 25 +- sound/usb/Kconfig | 4 + sound/usb/Makefile | 2 + sound/usb/card.c | 14 ++ sound/usb/card.h | 3 + sound/usb/media.c | 327 +++++++++++++++++++++++++ sound/usb/media.h | 74 ++++++ sound/usb/mixer.h | 3 + sound/usb/pcm.c | 29 ++- sound/usb/quirks-table.h | 1 + sound/usb/stream.c | 2 + sound/usb/usbaudio.h | 6 + 18 files changed, 872 insertions(+), 61 deletions(-) create mode 100644 drivers/media/media-dev-allocator.c create mode 100644 include/media/media-dev-allocator.h create mode 100644 sound/usb/media.c create mode 100644 sound/usb/media.h -- 2.17.1

3 9

[alsa-devel] [RFC 0/2] Add MICFIL DAI support
by Cosmin Samoila 27 Mar '19

27 Mar '19

PDM is a popular way to deliver audio from microphones to the processor in several applications, such as mobile telephones. However, current digital-audio systems use multibit audio signal (also known as multibit PCM) to represent the signal. For this purpose a set of FIR, CIC or/and Half Band filters are usually implemented on DSPs or software. This block implements the required digital interface to provide a 16-bit audio signal from a PDM microphone bitstream in a configurable output sampling rate. The implementation of this digital interface is based on the application of digital signal processing techniques in hardware. The PDM Microphone Interface architecture was designed to gate saving and minimal power consumption. It implements a bunch of filters to transform a 1-bit PDM bitstream to a 16-bit PCM signal in the audio band. To avoid aliasing frequencies in passband, the overall filter has 80 dB stopband attenuation and passband ripple less than 0.2dB. The whole module is implemented to work in a multichannel mode. All channels have the same configuration but each input channel could be turned on/off independently. Cosmin-Gabriel Samoila (2): ASoC: micfil: Add bindings for MICFIL DAI ASoC: Add MICFIL SoC Digital Audio Interface driver. .../devicetree/bindings/sound/fsl,micfil.txt | 38 + sound/soc/fsl/Kconfig | 9 + sound/soc/fsl/Makefile | 2 + sound/soc/fsl/fsl_micfil.c | 2451 ++++++++++++++++++++ sound/soc/fsl/fsl_micfil.h | 317 +++ 5 files changed, 2817 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,micfil.txt create mode 100644 sound/soc/fsl/fsl_micfil.c create mode 100644 sound/soc/fsl/fsl_micfil.h -- 2.7.4

6 18

[alsa-devel] [PATCH alsa-plugins] configure: Fix unexpanded ALSA_DATA_DIR
by Takashi Iwai 27 Mar '19

27 Mar '19

When no --with-alsadatadir is given, configure scripts takes $datadir/alsa as the default location, while it's expanded to $prefix/data/alsa. Although ALSA_DATA_DIR is set via AC_DEFINE_UNQUOTED(), this expands only $alsadatadir itself and not about the $prefix in the content. For resolving this, we need to do eval twice. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 1be4a70c803c..5b131e704c2f 100644 --- a/configure.ac +++ b/configure.ac @@ -211,7 +211,7 @@ if test -z "$alsadatadir"; then eval dir="$datadir" case "$dir" in /*) ;; - *) dir="$dir" + *) eval dir="$dir" esac alsadatadir="$dir/alsa" fi -- 2.16.4

2 1