February 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v3 1/2] ASoC: ssm2602: switch to SPDX identifier
by Marco Felsch 06 Feb '19

06 Feb '19

Drop old license header and switch to SPDX-License-Identifier. Signed-off-by: Marco Felsch <m.felsch(a)pengutronix.de> --- Changelog: v3: - switch to C++ comment style v2: - new created sound/soc/codecs/ssm2602.c | 39 ++++++++++++-------------------------- 1 file changed, 12 insertions(+), 27 deletions(-) diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c index 501a4e73b185..30b6d30e8e7c 100644 --- a/sound/soc/codecs/ssm2602.c +++ b/sound/soc/codecs/ssm2602.c @@ -1,30 +1,15 @@ -/* - * File: sound/soc/codecs/ssm2602.c - * Author: Cliff Cai <Cliff.Cai(a)analog.com> - * - * Created: Tue June 06 2008 - * Description: Driver for ssm2602 sound chip - * - * Modified: - * Copyright 2008 Analog Devices Inc. - * - * Bugs: Enter bugs at http://blackfin.uclinux.org/ - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, see the file COPYING, or write - * to the Free Software Foundation, Inc., - * 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ +// SPDX-License-Identifier: GPL-2.0-or-later +// +// File: sound/soc/codecs/ssm2602.c +// Author: Cliff Cai <Cliff.Cai(a)analog.com> +// +// Created: Tue June 06 2008 +// Description: Driver for ssm2602 sound chip +// +// Modified: +// Copyright 2008 Analog Devices Inc. +// +// Bugs: Enter bugs at http://blackfin.uclinux.org/ #include <linux/module.h> #include <linux/regmap.h> -- 2.20.1

1 2

[alsa-devel] Applied "ASoC: dapm: Check for NULL widget in dapm_update_dai_unlocked" to the asoc tree
by Mark Brown 06 Feb '19

06 Feb '19

The patch ASoC: dapm: Check for NULL widget in dapm_update_dai_unlocked has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From cf17a5ffd27234371d10748bf1c716ef172877f3 Mon Sep 17 00:00:00 2001 From: Charles Keepax <ckeepax(a)opensource.cirrus.com> Date: Wed, 6 Feb 2019 11:13:59 +0000 Subject: [PATCH] ASoC: dapm: Check for NULL widget in dapm_update_dai_unlocked DAIs linked to the dummy will not have an associated playback/capture widget, so we need to skip the update in that case. Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI") Reported-by: Krzysztof Kozlowski <krzk(a)kernel.org> Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> Tested-by: Sylwester Nawrocki <s.nawrocki(a)samsung.com> Tested-by: Krzysztof Kozlowski <krzk(a)kernel.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/soc-dapm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 5b74dffc9c11..111a23a9708a 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -2580,6 +2580,9 @@ static int dapm_update_dai_unlocked(struct snd_pcm_substream *substream, else w = dai->capture_widget; + if (!w) + return 0; + dev_dbg(dai->dev, "Update DAI routes for %s %s\n", dai->name, dir == SNDRV_PCM_STREAM_PLAYBACK ? "playback" : "capture"); -- 2.20.1

1 0

[alsa-devel] Applied "ASoC: ssm2602: Fix ADC powerup sequencing" to the asoc tree
by Mark Brown 06 Feb '19

06 Feb '19

The patch ASoC: ssm2602: Fix ADC powerup sequencing has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 37768e3917405e82611af8e693ccac1a20df38b5 Mon Sep 17 00:00:00 2001 From: Philipp Zabel <p.zabel(a)pengutronix.de> Date: Wed, 6 Feb 2019 16:29:47 +0100 Subject: [PATCH] ASoC: ssm2602: Fix ADC powerup sequencing According to the ssm2603 data sheet (control register sequencing), the digital core should be activated only after all necessary bits in the power register are enabled, and a delay determined by the decoupling capacitor on the VMID pin has passed. If the digital core is activated too early, or even before the ADC is powered up, audible artifacts appear at the beginning of the recorded signal. The digital core is also needed for playback, so when recording starts it may already be enabled. This means we cannot get the power sequence correct when we want to be able to start recording after playback. As a workaround put the MIC mute switch into the DAPM routes. This way we can keep the recording disabled until the MIC Bias has settled and thus get rid of audible artifacts. Signed-off-by: Philipp Zabel <p.zabel(a)pengutronix.de> m.felsch(a)pengutronix.de: adapt commit message m.felsch(a)pengutronix.de: drop of configuration as mentioned by Mark: https://patchwork.kernel.org/patch/10407449/ Signed-off-by: Marco Felsch <m.felsch(a)pengutronix.de> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/ssm2602.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c index 501a4e73b185..6f79cb0fbc63 100644 --- a/sound/soc/codecs/ssm2602.c +++ b/sound/soc/codecs/ssm2602.c @@ -26,6 +26,7 @@ * 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <linux/delay.h> #include <linux/module.h> #include <linux/regmap.h> #include <linux/slab.h> @@ -111,7 +112,6 @@ SOC_SINGLE_TLV("Sidetone Playback Volume", SSM2602_APANA, 6, 3, 1, SOC_SINGLE("Mic Boost (+20dB)", SSM2602_APANA, 0, 1, 0), SOC_SINGLE("Mic Boost2 (+20dB)", SSM2602_APANA, 8, 1, 0), -SOC_SINGLE("Mic Switch", SSM2602_APANA, 1, 1, 1), }; /* Output Mixer */ @@ -121,10 +121,31 @@ SOC_DAPM_SINGLE("HiFi Playback Switch", SSM2602_APANA, 4, 1, 0), SOC_DAPM_SINGLE("Mic Sidetone Switch", SSM2602_APANA, 5, 1, 0), }; +static const struct snd_kcontrol_new mic_ctl = + SOC_DAPM_SINGLE("Switch", SSM2602_APANA, 1, 1, 1); + /* Input mux */ static const struct snd_kcontrol_new ssm2602_input_mux_controls = SOC_DAPM_ENUM("Input Select", ssm2602_enum[0]); +static int ssm2602_mic_switch_event(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *kcontrol, int event) +{ + /* + * According to the ssm2603 data sheet (control register sequencing), + * the digital core should be activated only after all necessary bits + * in the power register are enabled, and a delay determined by the + * decoupling capacitor on the VMID pin has passed. If the digital core + * is activated too early, or even before the ADC is powered up, audible + * artifacts appear at the beginning and end of the recorded signal. + * + * In practice, audible artifacts disappear well over 500 ms. + */ + msleep(500); + + return 0; +} + static const struct snd_soc_dapm_widget ssm260x_dapm_widgets[] = { SND_SOC_DAPM_DAC("DAC", "HiFi Playback", SSM2602_PWR, 3, 1), SND_SOC_DAPM_ADC("ADC", "HiFi Capture", SSM2602_PWR, 2, 1), @@ -146,6 +167,9 @@ SND_SOC_DAPM_MIXER("Output Mixer", SSM2602_PWR, 4, 1, SND_SOC_DAPM_MUX("Input Mux", SND_SOC_NOPM, 0, 0, &ssm2602_input_mux_controls), SND_SOC_DAPM_MICBIAS("Mic Bias", SSM2602_PWR, 1, 1), +SND_SOC_DAPM_SWITCH_E("Mic Switch", SSM2602_APANA, 1, 1, &mic_ctl, + ssm2602_mic_switch_event, SND_SOC_DAPM_PRE_PMU), + SND_SOC_DAPM_OUTPUT("LHPOUT"), SND_SOC_DAPM_OUTPUT("RHPOUT"), SND_SOC_DAPM_INPUT("MICIN"), @@ -178,9 +202,11 @@ static const struct snd_soc_dapm_route ssm2602_routes[] = { {"LHPOUT", NULL, "Output Mixer"}, {"Input Mux", "Line", "Line Input"}, - {"Input Mux", "Mic", "Mic Bias"}, + {"Input Mux", "Mic", "Mic Switch"}, {"ADC", NULL, "Input Mux"}, + {"Mic Switch", NULL, "Mic Bias"}, + {"Mic Bias", NULL, "MICIN"}, }; -- 2.20.1

1 0

[alsa-devel] Applied "ASoC: wcd9335: remove some unnecessary NULL checks" to the asoc tree
by Mark Brown 06 Feb '19

06 Feb '19

The patch ASoC: wcd9335: remove some unnecessary NULL checks has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From d22b4117538d42f3dcf7e28210f07f968e46222e Mon Sep 17 00:00:00 2001 From: Dan Carpenter <dan.carpenter(a)oracle.com> Date: Tue, 5 Feb 2019 12:09:27 +0300 Subject: [PATCH] ASoC: wcd9335: remove some unnecessary NULL checks These are arrays, not pointers, and they can't be NULL. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/wcd9335.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 3878187bb512..981f88a5f615 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -2001,20 +2001,16 @@ static int wcd9335_set_channel_map(struct snd_soc_dai *dai, return -EINVAL; } - if (wcd->rx_chs) { - wcd->num_rx_port = rx_num; - for (i = 0; i < rx_num; i++) { - wcd->rx_chs[i].ch_num = rx_slot[i]; - INIT_LIST_HEAD(&wcd->rx_chs[i].list); - } + wcd->num_rx_port = rx_num; + for (i = 0; i < rx_num; i++) { + wcd->rx_chs[i].ch_num = rx_slot[i]; + INIT_LIST_HEAD(&wcd->rx_chs[i].list); } - if (wcd->tx_chs) { - wcd->num_tx_port = tx_num; - for (i = 0; i < tx_num; i++) { - wcd->tx_chs[i].ch_num = tx_slot[i]; - INIT_LIST_HEAD(&wcd->tx_chs[i].list); - } + wcd->num_tx_port = tx_num; + for (i = 0; i < tx_num; i++) { + wcd->tx_chs[i].ch_num = tx_slot[i]; + INIT_LIST_HEAD(&wcd->tx_chs[i].list); } return 0; -- 2.20.1

1 0

[alsa-devel] [PATCH 1/2] ASoC: compress: Clarify the intent of current compressed ops handling
by Charles Keepax 06 Feb '19

06 Feb '19

For callbacks configuring the state of the components (trigger, set_params, ack and set_metadata) simplify the code a little and make intention clearer by aborting as soon as an error is encountered. The operation has already failed and there is nothing to be gained from processing the callbacks on additional components. The operations currently abort after the callbacks, so this simply shortens the error path. For callbacks returning information from the driver (copy, get_metadata, pointer, get_codec_caps, get_caps and get_params) only look for the first callback provided, currently the code will call every callback only returning the information provided by the last. Since we can only return one set of data, it makes no sense to request the data from every component. Again this just makes the currently supported feature set a little more clear. Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- sound/soc/soc-compress.c | 106 +++++++++++++++++++++-------------------------- 1 file changed, 48 insertions(+), 58 deletions(-) diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index 699397a091670..fc8742383b230 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -353,7 +353,7 @@ static int soc_compr_trigger(struct snd_compr_stream *cstream, int cmd) struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_dai *codec_dai = rtd->codec_dai; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; - int ret = 0, __ret; + int ret = 0; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); @@ -364,12 +364,10 @@ static int soc_compr_trigger(struct snd_compr_stream *cstream, int cmd) !component->driver->compr_ops->trigger) continue; - __ret = component->driver->compr_ops->trigger(cstream, cmd); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->trigger(cstream, cmd); + if (ret < 0) + goto out; } - if (ret < 0) - goto out; if (cpu_dai->driver->cops && cpu_dai->driver->cops->trigger) cpu_dai->driver->cops->trigger(cstream, cmd, cpu_dai); @@ -394,7 +392,7 @@ static int soc_compr_trigger_fe(struct snd_compr_stream *cstream, int cmd) struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_dai *cpu_dai = fe->cpu_dai; - int ret = 0, __ret, stream; + int ret, stream; if (cmd == SND_COMPR_TRIGGER_PARTIAL_DRAIN || cmd == SND_COMPR_TRIGGER_DRAIN) { @@ -406,9 +404,10 @@ static int soc_compr_trigger_fe(struct snd_compr_stream *cstream, int cmd) !component->driver->compr_ops->trigger) continue; - __ret = component->driver->compr_ops->trigger(cstream, cmd); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->trigger(cstream, + cmd); + if (ret < 0) + return ret; } return ret; } @@ -433,12 +432,10 @@ static int soc_compr_trigger_fe(struct snd_compr_stream *cstream, int cmd) !component->driver->compr_ops->trigger) continue; - __ret = component->driver->compr_ops->trigger(cstream, cmd); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->trigger(cstream, cmd); + if (ret < 0) + goto out; } - if (ret < 0) - goto out; fe->dpcm[stream].runtime_update = SND_SOC_DPCM_UPDATE_FE; @@ -472,7 +469,7 @@ static int soc_compr_set_params(struct snd_compr_stream *cstream, struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; - int ret = 0, __ret; + int ret; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); @@ -496,12 +493,10 @@ static int soc_compr_set_params(struct snd_compr_stream *cstream, !component->driver->compr_ops->set_params) continue; - __ret = component->driver->compr_ops->set_params(cstream, params); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->set_params(cstream, params); + if (ret < 0) + goto err; } - if (ret < 0) - goto err; if (rtd->dai_link->compr_ops && rtd->dai_link->compr_ops->set_params) { ret = rtd->dai_link->compr_ops->set_params(cstream); @@ -522,7 +517,7 @@ static int soc_compr_set_params(struct snd_compr_stream *cstream, cancel_delayed_work_sync(&rtd->delayed_work); - return ret; + return 0; err: mutex_unlock(&rtd->pcm_mutex); @@ -538,7 +533,7 @@ static int soc_compr_set_params_fe(struct snd_compr_stream *cstream, struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_dai *cpu_dai = fe->cpu_dai; - int ret = 0, __ret, stream; + int ret, stream; if (cstream->direction == SND_COMPRESS_PLAYBACK) stream = SNDRV_PCM_STREAM_PLAYBACK; @@ -578,12 +573,10 @@ static int soc_compr_set_params_fe(struct snd_compr_stream *cstream, !component->driver->compr_ops->set_params) continue; - __ret = component->driver->compr_ops->set_params(cstream, params); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->set_params(cstream, params); + if (ret < 0) + goto out; } - if (ret < 0) - goto out; if (fe->dai_link->compr_ops && fe->dai_link->compr_ops->set_params) { ret = fe->dai_link->compr_ops->set_params(cstream); @@ -607,7 +600,7 @@ static int soc_compr_get_params(struct snd_compr_stream *cstream, struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; - int ret = 0, __ret; + int ret = 0; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); @@ -624,9 +617,8 @@ static int soc_compr_get_params(struct snd_compr_stream *cstream, !component->driver->compr_ops->get_params) continue; - __ret = component->driver->compr_ops->get_params(cstream, params); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->get_params(cstream, params); + break; } err: @@ -640,7 +632,7 @@ static int soc_compr_get_caps(struct snd_compr_stream *cstream, struct snd_soc_pcm_runtime *rtd = cstream->private_data; struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; - int ret = 0, __ret; + int ret = 0; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); @@ -651,9 +643,8 @@ static int soc_compr_get_caps(struct snd_compr_stream *cstream, !component->driver->compr_ops->get_caps) continue; - __ret = component->driver->compr_ops->get_caps(cstream, caps); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->get_caps(cstream, caps); + break; } mutex_unlock(&rtd->pcm_mutex); @@ -666,7 +657,7 @@ static int soc_compr_get_codec_caps(struct snd_compr_stream *cstream, struct snd_soc_pcm_runtime *rtd = cstream->private_data; struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; - int ret = 0, __ret; + int ret = 0; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); @@ -677,9 +668,9 @@ static int soc_compr_get_codec_caps(struct snd_compr_stream *cstream, !component->driver->compr_ops->get_codec_caps) continue; - __ret = component->driver->compr_ops->get_codec_caps(cstream, codec); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->get_codec_caps(cstream, + codec); + break; } mutex_unlock(&rtd->pcm_mutex); @@ -692,7 +683,7 @@ static int soc_compr_ack(struct snd_compr_stream *cstream, size_t bytes) struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; - int ret = 0, __ret; + int ret = 0; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); @@ -709,9 +700,9 @@ static int soc_compr_ack(struct snd_compr_stream *cstream, size_t bytes) !component->driver->compr_ops->ack) continue; - __ret = component->driver->compr_ops->ack(cstream, bytes); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->ack(cstream, bytes); + if (ret < 0) + goto err; } err: @@ -725,7 +716,7 @@ static int soc_compr_pointer(struct snd_compr_stream *cstream, struct snd_soc_pcm_runtime *rtd = cstream->private_data; struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; - int ret = 0, __ret; + int ret = 0; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); @@ -740,9 +731,8 @@ static int soc_compr_pointer(struct snd_compr_stream *cstream, !component->driver->compr_ops->pointer) continue; - __ret = component->driver->compr_ops->pointer(cstream, tstamp); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->pointer(cstream, tstamp); + break; } mutex_unlock(&rtd->pcm_mutex); @@ -781,7 +771,7 @@ static int soc_compr_set_metadata(struct snd_compr_stream *cstream, struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; - int ret = 0, __ret; + int ret; if (cpu_dai->driver->cops && cpu_dai->driver->cops->set_metadata) { ret = cpu_dai->driver->cops->set_metadata(cstream, metadata, cpu_dai); @@ -796,12 +786,13 @@ static int soc_compr_set_metadata(struct snd_compr_stream *cstream, !component->driver->compr_ops->set_metadata) continue; - __ret = component->driver->compr_ops->set_metadata(cstream, metadata); - if (__ret < 0) - ret = __ret; + ret = component->driver->compr_ops->set_metadata(cstream, + metadata); + if (ret < 0) + return ret; } - return ret; + return 0; } static int soc_compr_get_metadata(struct snd_compr_stream *cstream, @@ -811,7 +802,7 @@ static int soc_compr_get_metadata(struct snd_compr_stream *cstream, struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; - int ret = 0, __ret; + int ret; if (cpu_dai->driver->cops && cpu_dai->driver->cops->get_metadata) { ret = cpu_dai->driver->cops->get_metadata(cstream, metadata, cpu_dai); @@ -826,12 +817,11 @@ static int soc_compr_get_metadata(struct snd_compr_stream *cstream, !component->driver->compr_ops->get_metadata) continue; - __ret = component->driver->compr_ops->get_metadata(cstream, metadata); - if (__ret < 0) - ret = __ret; + return component->driver->compr_ops->get_metadata(cstream, + metadata); } - return ret; + return 0; } /* ASoC Compress operations */ -- 2.11.0

2 3

[alsa-devel] [PATCH v2 1/2] ASoC: ssm2602: switch to SPDX identifier
by Marco Felsch 06 Feb '19

06 Feb '19

Drop old license header and switch to SPDX-License-Identifier. Signed-off-by: Marco Felsch <m.felsch(a)pengutronix.de> --- Changelog: v2: - new created sound/soc/codecs/ssm2602.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c index 501a4e73b185..580ab8916854 100644 --- a/sound/soc/codecs/ssm2602.c +++ b/sound/soc/codecs/ssm2602.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * File: sound/soc/codecs/ssm2602.c * Author: Cliff Cai <Cliff.Cai(a)analog.com> @@ -9,21 +10,6 @@ * Copyright 2008 Analog Devices Inc. * * Bugs: Enter bugs at http://blackfin.uclinux.org/ - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, see the file COPYING, or write - * to the Free Software Foundation, Inc., - * 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ #include <linux/module.h> -- 2.20.1

3 5

[alsa-devel] [BUG BISECT] NULL pointer after commit "ASoC: dapm: Only power up active channels from a DAI"
by Krzysztof Kozlowski 06 Feb '19

06 Feb '19

Hi, Bisect pointed to commit: commit 078a85f2806f0ffd11289009462a6a390f9adb5c Author: Charles Keepax <ckeepax(a)opensource.cirrus.com> Date: Thu Jan 31 13:30:18 2019 +0000 ASoC: dapm: Only power up active channels from a DAI as a bad commit for NULL pointer on my Odroid XU3 and Odroid U3 board when doing "aplay /usr/share/sounds/alsa/Front_Right.wav". 1. Arch ARM Linux 2. exynos_defconfig 3. Odroid U3, XU3, Exynos SoC, ARMv7 Last address is in calltrace: c079552c dapm_update_dai_unlocked sound/soc/soc-dapm.c:2586 Full log: Unable to handle kernel NULL pointer dereference at virtual address 0000007c pgd = d5b32ef7 [0000007c] *pgd=00000000 Internal error: Oops: 5 [#1] PREEMPT SMP ARM Modules linked in: s5p_mfc s5p_jpeg exynos_gsc v4l2_mem2mem v4l2_common videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common videodev media s5p_cec CPU: 7 PID: 359 Comm: aplay Not tainted 5.0.0-rc4-00177-g078a85f2806f #32 Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) PC is at dapm_update_dai_unlocked+0x38/0x138 LR is at snd_soc_dapm_update_dai+0x34/0x4c pc : [<c079552c>] lr : [<c0795660>] psr: 60010013 sp : eb9d9be8 ip : eabc8b64 fp : ecce0e10 r10: c100b448 r9 : ecce0e0c r8 : 00000000 r7 : 00000000 r6 : 00000000 r5 : 00000002 r4 : ecce0800 r3 : 00000000 r2 : eccaa080 r1 : ecdab000 r0 : 00000000 Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 10c5387d Table: 6c09806a DAC: 00000051 Process aplay (pid: 359, stack limit = 0x4ae0a814) Stack: (0xeb9d9be8 to 0xeb9da000) 9be0: ecce0e0c c100b448 ecce0e10 ecce0800 ecd64400 ecdab000 9c00: eccaa080 c0795660 ee3c480c ecd64400 ecce0800 ecdab000 00000000 c079d760 9c20: eccaa080 ecce080c 00000000 00000001 00000000 00000000 00000000 00000000 9c40: 00000000 00000000 00000000 00000004 00000000 00000000 00000000 00000000 9c60: 00000000 00000000 00000000 00000001 00000000 00000000 00000000 00000000 9c80: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9ca0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9cc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9ce0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9d00: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9d20: 00000000 00000000 00000000 00000010 00000010 00000004 00000020 00000020 9d40: 00000004 00000002 00000002 00000004 0000bb80 0000bb80 00000004 0001e848 9d60: 0001e848 00000004 00001770 00001770 00000004 00005dc0 00005dc0 00000004 9d80: 00000004 00000004 00000004 0007a120 0007a120 00000004 00005dc0 00005dc0 9da0: 00000004 00017700 00017700 00000004 00000000 00000000 00000004 00000000 9dc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9de0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9e00: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9e20: 00000000 00000000 00000000 000fff07 00200103 00000010 0000bb80 00000001 9e40: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9e60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9e80: 00000000 8c6972bb ecdab000 ecd64400 ecdab000 00000000 c0b97b1c ebfe8000 9ea0: 00000000 bea4eea0 b6effb88 c07825e4 c100b448 ecdab000 ecd64400 00000000 9ec0: ecfdd180 ec1bde40 bea4eea0 c07836e0 eb9d9f78 00000000 00000000 00000001 9ee0: 61746164 c0294d70 00000001 8c6972bb c100b448 bea4eea0 ecfdd180 c02a9bac 9f00: bea4eea0 eb9d8000 ed4aafa8 c02a9244 eb9cbb80 c100b448 00000000 00000000 9f20: 00000000 00000000 00000000 8c6972bb eb9d9fb0 ec6f11c0 eb9cbb80 00000002 9f40: eb9cbb88 00000001 b6e85b6f 00000001 61746164 c0295028 00000000 00000000 9f60: c100b448 8c6972bb 00000000 ecfdd180 ecfdd180 00000004 c25c4111 bea4eea0 9f80: eb9d8000 00000036 b6effb88 c02a9bac 004cf1b8 bea4eea0 004cf208 00000036 9fa0: c01011c4 c0101000 004cf1b8 bea4eea0 00000004 c25c4111 bea4eea0 00020001 9fc0: 004cf1b8 bea4eea0 004cf208 00000036 bea4ee10 00000000 b6fb5900 b6effb88 9fe0: b6f6c82c bea4edf4 b6efbfc4 b6e0bbdc 200d0010 00000004 00000000 00000000 [<c079552c>] (dapm_update_dai_unlocked) from [<c0795660>] (snd_soc_dapm_update_dai+0x34/0x4c) [<c0795660>] (snd_soc_dapm_update_dai) from [<c079d760>] (soc_pcm_hw_params+0x22c/0x624) [<c079d760>] (soc_pcm_hw_params) from [<c07825e4>] (snd_pcm_hw_params+0x128/0x378) [<c07825e4>] (snd_pcm_hw_params) from [<c07836e0>] (snd_pcm_ioctl+0x26c/0x1258) [<c07836e0>] (snd_pcm_ioctl) from [<c02a9244>] (do_vfs_ioctl+0xb0/0x9e4) [<c02a9244>] (do_vfs_ioctl) from [<c02a9bac>] (ksys_ioctl+0x34/0x58) [<c02a9bac>] (ksys_ioctl) from [<c0101000>] (ret_fast_syscall+0x0/0x28) Exception stack(0xeb9d9fa8 to 0xeb9d9ff0) 9fa0: 004cf1b8 bea4eea0 00000004 c25c4111 bea4eea0 00020001 9fc0: 004cf1b8 bea4eea0 004cf208 00000036 bea4ee10 00000000 b6fb5900 b6effb88 9fe0: b6f6c82c bea4edf4 b6efbfc4 b6e0bbdc Code: e3530000 e5926020 1a00003a e1a07006 (e5b7407c) ---[ end trace 8561600efcd2b2f1 ]--- Let me know if you need any other data. Best regards, Krzysztof

3 11

[alsa-devel] [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks
by Takashi Iwai 06 Feb '19

06 Feb '19

Hi, this is yet another patchset for trivial cleanups. At this time, it's about the superfluous error check from snd_pcm_lib_preallocate_pages() and co. They always succeed and never return a failure although many codes do the error check. The patches simply remove the error checks and finally change the function to be void function. The patches are applied on top of my previous NULL device fix patches, so not applicable to ASoC tree, I guess. As all these are trivial, applying through my tree altogether would be simpler. So, Mark, please give your ACK if the changes to ASoC drivers are OK. thanks, Takashi === Takashi Iwai (20): ALSA: atmel: Drop superfluous PCM preallocation error checks ALSA: parisc: Drop superfluous PCM preallocation error checks ALSA: pci: Drop superfluous PCM preallocation error checks ALSA: ppc: Drop superfluous PCM preallocation error checks ALSA: sh: Drop superfluous PCM preallocation error checks ALSA: sparc: Drop superfluous PCM preallocation error checks ALSA: spi: Drop superfluous PCM preallocation error checks ALSA: usb: Drop superfluous PCM preallocation error checks ASoC: amd: Drop superfluous PCM preallocation error checks ASoC: dwc: Drop superfluous PCM preallocation error checks ASoC: intel: Drop superfluous PCM preallocation error checks ASoC: mediatek: Drop superfluous PCM preallocation error checks ASoC: meson: Drop superfluous PCM preallocation error checks ASoC: sh: Drop superfluous PCM preallocation error checks ASoC: stm: Drop superfluous PCM preallocation error checks ASoC: txx9: Drop superfluous PCM preallocation error checks ASoC: uniphier: Drop superfluous PCM preallocation error checks ASoC: xtensa: Drop superfluous PCM preallocation error checks ASoC: dmaengine: Drop superfluous PCM preallocation error checks ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void include/sound/pcm.h | 8 ++--- sound/atmel/ac97c.c | 4 +-- sound/core/pcm_memory.c | 29 +++++----------- sound/parisc/harmony.c | 10 ++---- sound/pci/ad1889.c | 7 +--- sound/pci/aw2/aw2-alsa.c | 40 +++++++--------------- sound/pci/bt87x.c | 10 +++--- sound/pci/ca0106/ca0106_main.c | 16 ++++----- sound/pci/echoaudio/echoaudio.c | 16 ++++----- sound/pci/emu10k1/emupcm.c | 22 ++++++++---- sound/pci/emu10k1/p16v.c | 17 ++++----- sound/pci/lx6464es/lx6464es.c | 8 ++--- sound/pci/rme9652/hdspm.c | 20 +++-------- sound/pci/via82xx_modem.c | 8 ++--- sound/ppc/snd_ps3.c | 6 +--- sound/sh/aica.c | 14 ++++---- sound/soc/amd/acp-pcm-dma.c | 26 ++++++-------- sound/soc/amd/raven/acp3x-pcm-dma.c | 9 +++-- sound/soc/dwc/dwc-pcm.c | 3 +- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 9 ++--- sound/soc/intel/baytrail/sst-baytrail-pcm.c | 15 +++----- sound/soc/intel/haswell/sst-haswell-pcm.c | 10 ++---- sound/soc/intel/skylake/skl-pcm.c | 9 ++--- .../soc/mediatek/common/mtk-afe-platform-driver.c | 6 ++-- sound/soc/meson/axg-fifo.c | 7 ++-- sound/soc/sh/fsi.c | 3 +- sound/soc/sh/rcar/core.c | 5 +-- sound/soc/sh/siu_pcm.c | 13 +------ sound/soc/soc-generic-dmaengine-pcm.c | 5 +-- sound/soc/stm/stm32_adfsdm.c | 5 +-- sound/soc/txx9/txx9aclc.c | 4 ++- sound/soc/uniphier/aio-dma.c | 3 +- sound/soc/xtensa/xtfpga-i2s.c | 6 ++-- sound/sparc/dbri.c | 9 ++--- sound/spi/at73c213.c | 2 +- sound/usb/usx2y/usbusx2yaudio.c | 21 ++++++------ sound/usb/usx2y/usx2yhwdeppcm.c | 19 +++++----- 37 files changed, 157 insertions(+), 267 deletions(-) -- 2.16.4

4 25

[alsa-devel] [PATCH] ASoC: dapm: Check for NULL widget in dapm_update_dai_unlocked
by Charles Keepax 06 Feb '19

06 Feb '19

DAIs linked to the dummy will not have an associated playback/capture widget, so we need to skip the update in that case. Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI") Reported-by: Krzysztof Kozlowski <krzk(a)kernel.org> Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> Tested-by: Sylwester Nawrocki <s.nawrocki(a)samsung.com> Tested-by: Krzysztof Kozlowski <krzk(a)kernel.org> --- sound/soc/soc-dapm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 5b74dffc9c11d..111a23a9708a2 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -2580,6 +2580,9 @@ static int dapm_update_dai_unlocked(struct snd_pcm_substream *substream, else w = dai->capture_widget; + if (!w) + return 0; + dev_dbg(dai->dev, "Update DAI routes for %s %s\n", dai->name, dir == SNDRV_PCM_STREAM_PLAYBACK ? "playback" : "capture"); -- 2.11.0

1 0

[alsa-devel] [sound:topic/memory-device-fixes 83/83] drivers/media/pci/solo6x10/solo6x10-g723.c:363:6: error: void value not ignored as it ought to be
by kbuild test robot 06 Feb '19

06 Feb '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/memory-device-fixes head: c898c3496b8e5c583e874bbfbbcba3d185cac051 commit: c898c3496b8e5c583e874bbfbbcba3d185cac051 [83/83] ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void config: x86_64-allmodconfig (attached as .config) compiler: gcc-8 (Debian 8.2.0-14) 8.2.0 reproduce: git checkout c898c3496b8e5c583e874bbfbbcba3d185cac051 # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): >> drivers/media/pci/solo6x10/solo6x10-g723.c:363:13: sparse: warning: incorrect type in assignment (different base types) drivers/media/pci/solo6x10/solo6x10-g723.c:363:13: sparse: expected int [assigned] ret drivers/media/pci/solo6x10/solo6x10-g723.c:363:13: sparse: got void -- drivers/media/pci/solo6x10/solo6x10-g723.c: In function 'solo_snd_pcm_init': >> drivers/media/pci/solo6x10/solo6x10-g723.c:363:6: error: void value not ignored as it ought to be ret = snd_pcm_lib_preallocate_pages_for_all(pcm, ^ -- >> drivers/media/pci/tw686x/tw686x-audio.c:304:53: sparse: warning: incorrect type in return expression (different base types) drivers/media/pci/tw686x/tw686x-audio.c:304:53: sparse: expected int drivers/media/pci/tw686x/tw686x-audio.c:304:53: sparse: got void -- drivers/media/pci/tw686x/tw686x-audio.c: In function 'tw686x_snd_pcm_init': >> drivers/media/pci/tw686x/tw686x-audio.c:304:9: error: void value not ignored as it ought to be return snd_pcm_lib_preallocate_pages_for_all(pcm, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ SNDRV_DMA_TYPE_DEV, ~~~~~~~~~~~~~~~~~~~ snd_dma_pci_data(dev->pci_dev), ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TW686X_AUDIO_PAGE_MAX * AUDIO_DMA_SIZE_MAX, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TW686X_AUDIO_PAGE_MAX * AUDIO_DMA_SIZE_MAX); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/media/pci/tw686x/tw686x-audio.c:309:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ sparse warnings: (new ones prefixed by >>) drivers/media/pci/solo6x10/solo6x10-g723.c:363:13: sparse: warning: incorrect type in assignment (different base types) >> drivers/media/pci/solo6x10/solo6x10-g723.c:363:13: sparse: expected int [assigned] ret >> drivers/media/pci/solo6x10/solo6x10-g723.c:363:13: sparse: got void -- drivers/media/pci/tw686x/tw686x-audio.c:304:53: sparse: warning: incorrect type in return expression (different base types) >> drivers/media/pci/tw686x/tw686x-audio.c:304:53: sparse: expected int >> drivers/media/pci/tw686x/tw686x-audio.c:304:53: sparse: got void vim +363 drivers/media/pci/solo6x10/solo6x10-g723.c faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 338 decebabf drivers/staging/solo6x10/g723.c Krzysztof Hałasa 2011-02-11 339 static int solo_snd_pcm_init(struct solo_dev *solo_dev) faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 340 { faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 341 struct snd_card *card = solo_dev->snd_card; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 342 struct snd_pcm *pcm; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 343 struct snd_pcm_substream *ss; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 344 int ret; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 345 int i; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 346 faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 347 ret = snd_pcm_new(card, card->driver, 0, 0, solo_dev->nr_chans, faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 348 &pcm); faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 349 if (ret < 0) faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 350 return ret; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 351 faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 352 snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 353 &snd_solo_pcm_ops); faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 354 faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 355 snd_pcm_chip(pcm) = solo_dev; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 356 pcm->info_flags = 0; cc1e6315 drivers/media/pci/solo6x10/solo6x10-g723.c Mauro Carvalho Chehab 2018-09-10 357 strscpy(pcm->name, card->shortname, sizeof(pcm->name)); faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 358 faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 359 for (i = 0, ss = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 360 ss; ss = ss->next, i++) faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 361 sprintf(ss->name, "Camera #%d Audio", i); faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 362 faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 @363 ret = snd_pcm_lib_preallocate_pages_for_all(pcm, faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 364 SNDRV_DMA_TYPE_CONTINUOUS, faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 365 snd_dma_continuous_data(GFP_KERNEL), 9d1b1f61 drivers/media/pci/solo6x10/solo6x10-g723.c Krzysztof Hałasa 2015-06-08 366 G723_PERIOD_BYTES * PERIODS, 9d1b1f61 drivers/media/pci/solo6x10/solo6x10-g723.c Krzysztof Hałasa 2015-06-08 367 G723_PERIOD_BYTES * PERIODS); faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 368 if (ret < 0) faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 369 return ret; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 370 faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 371 solo_dev->snd_pcm = pcm; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 372 faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 373 return 0; faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 374 } faa4fd2a drivers/staging/solo6x10/solo6010-g723.c Ben Collins 2010-06-17 375 :::::: The code at line 363 was first introduced by commit :::::: faa4fd2a09517b39cc1f5d622453f97a59acfdac Staging: solo6x10: New driver (staging) for Softlogic 6x10 :::::: TO: Ben Collins <bcollins(a)bluecherry.net> :::::: CC: Greg Kroah-Hartman <gregkh(a)suse.de> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0