February 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/5] ASoC: codecs: ad193x: Several fixes and imprevements
by Codrin.Ciubotariu＠microchip.com 18 Feb '19

18 Feb '19

From: Codrin Ciubotariu <codrin.ciubotariu(a)microchip.com> This patch set contains some changes I needed to make I2S and TDM (DSP_A) formats work. I tested only with ad1936, but the patches should work fine for all the codecs that use this driver. Although I checked the DS for all of them (I hope) to assure that the patches apply, I would really appreciate if someone else can test them on another codec. Codrin Ciubotariu (5): ASoC: codecs: ad193x: Remove capture support for codecs without ADC ASoC: codecs: ad193x: Set constraint to always have 32 sample bits ASoC: codecs: ad193x: Fix frame polarity for DSP_A format ASoC: codecs: ad193x: Add runtime support for DSP_A and I2S modes ASoC: codecs: ad193x: Add support to disable on-chip PLL sound/soc/codecs/ad193x.c | 76 ++++++++++++++++++++++++++++++++++++--- sound/soc/codecs/ad193x.h | 8 +++++ 2 files changed, 80 insertions(+), 4 deletions(-) -- 2.17.1

2 11

[alsa-devel] snd_hda_codec_hdmi: `hdaudio hdaudioC0D2: Unable to bind the codec`
by Paul Menzel 18 Feb '19

18 Feb '19

Dear Linux folks, With drm-tip (v4.19-rc3-946-g09b295662edd) Linux prints `snd_hda_codec_hdmi hdaudioC0D2: No i915 binding for Intel HDMI/DP codec` to the log. ``` […] [ 12.481788] snd_hda_codec_realtek hdaudioC0D0: autoconfig for ALC671: line_outs=1 (0x21/0x0/0x0/0x0/0x0) type:line [ 12.482536] snd_hda_codec_realtek hdaudioC0D0: speaker_outs=1 (0x17/0x0/0x0/0x0/0x0) [ 12.483184] snd_hda_codec_realtek hdaudioC0D0: hp_outs=1 (0x14/0x0/0x0/0x0/0x0) [ 12.483737] snd_hda_codec_realtek hdaudioC0D0: mono: mono_out=0x0 [ 12.484198] snd_hda_codec_realtek hdaudioC0D0: inputs: [ 12.484582] snd_hda_codec_realtek hdaudioC0D0: Front Mic=0x19 [ 12.485100] snd_hda_codec_realtek hdaudioC0D0: Rear Mic=0x18 [ 12.485519] snd_hda_codec_realtek hdaudioC0D0: Line=0x1a [ 12.497685] snd_hda_codec_hdmi hdaudioC0D2: No i915 binding for Intel HDMI/DP codec [ 12.498311] hdaudio hdaudioC0D2: Unable to bind the codec [ 12.498789] input: HDA Intel PCH Front Mic as /devices/pci0000:00/0000:00:1f.3/sound/card0/input6 [ 12.499567] input: HDA Intel PCH Rear Mic as /devices/pci0000:00/0000:00:1f.3/sound/card0/input7 [ 12.500268] input: HDA Intel PCH Line as /devices/pci0000:00/0000:00:1f.3/sound/card0/input8 [ 12.501039] input: HDA Intel PCH Line Out as /devices/pci0000:00/0000:00:1f.3/sound/card0/input9 [ 12.501683] input: HDA Intel PCH Front Headphone as /devices/pci0000:00/0000:00:1f.3/sound/card0/input10 [ 17.743338] [drm:intel_pch_type [i915]] Found SunrisePoint PCH […] ``` Is that an error or just a notice? Kind regards, Paul

2 12

Re: [alsa-devel] [PATCH 1/2] ASoC: samsung: i2s: Fix the secondary platform device registration
by Krzysztof Kozlowski 18 Feb '19

18 Feb '19

On Fri, 15 Feb 2019 at 15:48, Sylwester Nawrocki <s.nawrocki(a)samsung.com> wrote: > > This fixes unregistration of the secondary platform device so all > resources are properly released. The test for NULL priv->pdev_sec > is not necessary and it is removed. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki(a)samsung.com> > --- > This patch is based off of ASoC for-next and patches: > ASoC: samsung: odroid: Ensure proper sample rate on pri/sec PCM > ASoC: samsung: i2s: Prevent potential NULL platform data dereference > ASoC: samsung: odroid: Add missing DAPM routes > > sound/soc/samsung/i2s.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c > index 6bf0f55d1e51..e36c44e2f1bb 100644 > --- a/sound/soc/samsung/i2s.c > +++ b/sound/soc/samsung/i2s.c > @@ -1359,11 +1359,10 @@ static int i2s_create_secondary_device(struct samsung_i2s_priv *priv) > > static void i2s_delete_secondary_device(struct samsung_i2s_priv *priv) > { > - if (priv->pdev_sec) { > - platform_device_del(priv->pdev_sec); > - priv->pdev_sec = NULL; > - } > + platform_device_unregister(priv->pdev_sec); > + priv->pdev_sec = NULL; Reviewed-by: Krzysztof Kozlowski <krzk(a)kernel.org> Although I think that you might need to re-order calls in samsung_i2s_remove(). In general they should be in exact reverse order of probe(). In this case, clk_disable_unprepare(priv->clk) should be after unregistering secondary device. If order has to be different because of some reasons - could you document them in comment? Best regards, Krzysztof

2 1

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization
by Krzysztof Kozlowski 18 Feb '19

18 Feb '19

On Fri, 15 Feb 2019 at 15:48, Sylwester Nawrocki <s.nawrocki(a)samsung.com> wrote: > > On some SoCs (e.g. Exynos5433) there are multiple "IIS multi audio > interfaces" and the driver will try to register there multiple times > same platform device for the secondary FIFO, which of course fails > miserably. To fix this we derive the secondary platform device name > from the primary device name. The secondary device name will now > be <primary_dev_name>-sec instead of fixed "samsung-i2s-sec". > > The fixed platform_device_id table entry is removed as the secondary > device name is now dynamic and device/driver matching is done through > driver_override. > > Reported-by: Marek Szyprowski <m.szyprowski(a)samsung.com> > Suggested-by: Marek Szyprowski <m.szyprowski(a)samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki(a)samsung.com> > --- > sound/soc/samsung/i2s.c | 49 +++++++++++++++++++++++++------------- > sound/soc/samsung/odroid.c | 2 +- > 2 files changed, 33 insertions(+), 18 deletions(-) > > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c > index e36c44e2f1bb..4a6dd86459bc 100644 > --- a/sound/soc/samsung/i2s.c > +++ b/sound/soc/samsung/i2s.c > @@ -1339,20 +1339,34 @@ static int i2s_register_clock_provider(struct samsung_i2s_priv *priv) > /* Create platform device for the secondary PCM */ > static int i2s_create_secondary_device(struct samsung_i2s_priv *priv) > { > - struct platform_device *pdev; > + struct platform_device *pdev_sec; > + const char *devname; > int ret; > > - pdev = platform_device_register_simple("samsung-i2s-sec", -1, NULL, 0); > - if (!pdev) > + devname = devm_kasprintf(&priv->pdev->dev, GFP_KERNEL, "%s-sec", > + dev_name(&priv->pdev->dev)); > + if (!devname) > return -ENOMEM; > > - ret = device_attach(&pdev->dev); > + pdev_sec = platform_device_alloc(devname, -1); > + if (!pdev_sec) > + return -ENOMEM; > + > + pdev_sec->driver_override = "samsung-i2s"; > + > + ret = platform_device_add(pdev_sec); > if (ret < 0) { > - dev_info(&pdev->dev, "device_attach() failed\n"); > + platform_device_put(pdev_sec); > return ret; > } > > - priv->pdev_sec = pdev; > + priv->pdev_sec = pdev_sec; > + > + ret = device_attach(&pdev_sec->dev); > + if (ret < 0) { > + dev_info(&pdev_sec->dev, "device_attach() failed\n"); Don't you need here platform_device_unregister()? Best regards, Krzysztof

2 1

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization
by Krzysztof Kozlowski 18 Feb '19

18 Feb '19

On Fri, 15 Feb 2019 at 15:48, Sylwester Nawrocki <s.nawrocki(a)samsung.com> wrote: > > On some SoCs (e.g. Exynos5433) there are multiple "IIS multi audio > interfaces" and the driver will try to register there multiple times > same platform device for the secondary FIFO, which of course fails > miserably. To fix this we derive the secondary platform device name > from the primary device name. The secondary device name will now > be <primary_dev_name>-sec instead of fixed "samsung-i2s-sec". > > The fixed platform_device_id table entry is removed as the secondary > device name is now dynamic and device/driver matching is done through > driver_override. > > Reported-by: Marek Szyprowski <m.szyprowski(a)samsung.com> > Suggested-by: Marek Szyprowski <m.szyprowski(a)samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki(a)samsung.com> > --- > sound/soc/samsung/i2s.c | 49 +++++++++++++++++++++++++------------- > sound/soc/samsung/odroid.c | 2 +- > 2 files changed, 33 insertions(+), 18 deletions(-) > > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c > index e36c44e2f1bb..4a6dd86459bc 100644 > --- a/sound/soc/samsung/i2s.c > +++ b/sound/soc/samsung/i2s.c > @@ -1339,20 +1339,34 @@ static int i2s_register_clock_provider(struct samsung_i2s_priv *priv) > /* Create platform device for the secondary PCM */ > static int i2s_create_secondary_device(struct samsung_i2s_priv *priv) > { > - struct platform_device *pdev; > + struct platform_device *pdev_sec; > + const char *devname; > int ret; > > - pdev = platform_device_register_simple("samsung-i2s-sec", -1, NULL, 0); > - if (!pdev) > + devname = devm_kasprintf(&priv->pdev->dev, GFP_KERNEL, "%s-sec", > + dev_name(&priv->pdev->dev)); > + if (!devname) > return -ENOMEM; > > - ret = device_attach(&pdev->dev); > + pdev_sec = platform_device_alloc(devname, -1); > + if (!pdev_sec) > + return -ENOMEM; > + > + pdev_sec->driver_override = "samsung-i2s"; This is wrong, see: https://patchwork.kernel.org/project/linux-samsung-soc/list/?series=81639&s… Although there is ongoing discussion whether the drivers should use driver_override at all: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1934411.html Best regards, Krzysztof

1 0

Re: [alsa-devel] [PATCH -next] ASoC: samsung: i2s: Fix return value check in i2s_create_secondary_device()
by Sylwester Nawrocki 18 Feb '19

18 Feb '19

On 2/16/19 02:20, Wei Yongjun wrote: > In case of error, the function platform_device_register_simple() returns > ERR_PTR() and never returns NULL. The NULL test in the return value > check should be replaced with IS_ERR(). Thanks for the patch, it looks good but I have already prepared other fix that removes the platform_device_register_simple() call entirely: "ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization" https://www.spinics.net/lists/kernel/msg3045092.html -- Thanks, Sylwester

1 0

Re: [alsa-devel] [PATCH -next] ASoC: wm8741: Make function 'wm8741_mute' static
by Charles Keepax 18 Feb '19

18 Feb '19

On Sat, Feb 16, 2019 at 01:35:56AM +0000, Wei Yongjun wrote: > Fixes the following sparse warning: > > sound/soc/codecs/wm8741.c:371:5: warning: > symbol 'wm8741_mute' was not declared. Should it be static? > > Fixes: 36b1599340b5 ("ASoC: wm8741: Add digital mute callback") > Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> > --- Acked-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> Thanks, Charles

1 0

[alsa-devel] [PATCH] ALSA: usb-audio: Expose sample resolution through proc interface
by Jussi Laako 18 Feb '19

18 Feb '19

At least some USB devices use (MSB-aligned) audio format larger than the actual resolution of the device. In order to expose the actual device resolution (bBitResolution), add extra field to the procfs stream info interface. Signed-off-by: Jussi Laako <jussi(a)sonarnerd.net> --- sound/usb/card.h | 1 + sound/usb/format.c | 2 ++ sound/usb/proc.c | 1 + 3 files changed, 4 insertions(+) diff --git a/sound/usb/card.h b/sound/usb/card.h index ac785d15ced4..d9bb2c4a3bd9 100644 --- a/sound/usb/card.h +++ b/sound/usb/card.h @@ -14,6 +14,7 @@ struct audioformat { u64 formats; /* ALSA format bits */ unsigned int channels; /* # channels */ unsigned int fmt_type; /* USB audio format type (1-3) */ + unsigned int fmt_bits; /* number of significant bits */ unsigned int frame_size; /* samples per frame for non-audio */ int iface; /* interface number */ unsigned char altsetting; /* corresponding alternate setting */ diff --git a/sound/usb/format.c b/sound/usb/format.c index fd13ac11b136..d5b7cbcc2956 100644 --- a/sound/usb/format.c +++ b/sound/usb/format.c @@ -87,6 +87,8 @@ static u64 parse_audio_format_i_type(struct snd_usb_audio *chip, } } + fp->fmt_bits = (unsigned int) sample_width; + if ((pcm_formats == 0) && (format == 0 || format == (1 << UAC_FORMAT_TYPE_I_UNDEFINED))) { /* some devices don't define this correctly... */ diff --git a/sound/usb/proc.c b/sound/usb/proc.c index e80c9d0749c9..ef9190530fd2 100644 --- a/sound/usb/proc.c +++ b/sound/usb/proc.c @@ -109,6 +109,7 @@ static void proc_dump_substream_formats(struct snd_usb_substream *subs, struct s if (subs->speed != USB_SPEED_FULL) snd_iprintf(buffer, " Data packet interval: %d us\n", 125 * (1 << fp->datainterval)); + snd_iprintf(buffer, " Bits: %d\n", fp->fmt_bits); // snd_iprintf(buffer, " Max Packet Size = %d\n", fp->maxpacksize); // snd_iprintf(buffer, " EP Attribute = %#x\n", fp->attributes); } -- 2.17.1

2 2

Re: [alsa-devel] Multiple codecs on one sound card for multi-channel sound card
by Yann CARDAILLAC 18 Feb '19

18 Feb '19

Hi guys, Where are we now with TDM on several codecs on the same TDM channel ? I'm sorry to dig out this old thread but I couldn't really find any proper information about that. I only plan to use 4 channel TDM with two codecs. I'm using IMX6's SSI as master for both codec. What I've got working today is 1 codec with ssi as I2S master. Do you have any pointer on what is achieved so far and how to implement it ? I'm using kernel *v4.14.78*. Any pointer to DTS achieving that or audio card doing that kind of thing would already be an amazing first hint.! Regards, Yann >Got it. Thanks Arnaud. >-Caleb > >On Thu, Sep 17, 2015 at 9:09 AM, arnaud.mouiche at invoxia.com <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel> ><arnaud.mouiche at invoxia.com <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>> wrote: >>>>>*> Le 17/09/2015 17:34, Caleb Crome a écrit : *>>>>>>* On Thu, Sep 17, 2015 at 7:33 AM, arnaud.mouiche at invoxia.com <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel> *>>>* <arnaud.mouiche at invoxia.com <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>> wrote: *>>>>>>>>* hello, *>>>>>>>*> Le 17/09/2015 15:38, Caleb Crome a écrit : *>>>>>>>>>>* On Thu, Sep 17, 2015 at 1:51 AM, arnaud.mouiche at invoxia.com <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel> *>>>>>* <arnaud.mouiche at invoxia.com <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>> wrote: *>>>>>>>>>>>>* Hello Caleb, *>>>>>>>>>>>>* freescale SSI is fine with more than 2 channels. *>>>>>>* I have planed to publish a set of patch in this direction but we still *>>>>>>* have *>>>>>>* some corner cases to fix first (rare issues with channels alignment) *>>>>>>>>>>* I'd love to see anything you're willing to show :-) *>>>>>>>>>>>* Yet, this following is far enough to have it working. *>>>>>>* And since the max/min rate is at the end the intersection of what the *>>>>>>* SSI, *>>>>>>* the codec and the card are declaring, it will not change anything until *>>>>>>* you *>>>>>>* connect the SSI to a codec with more than 2 channels, or a multi-codec *>>>>>>* solution. *>>>>*> *>>>>* What if I change channels_max to 16 for capture and playback? Last *>>>>>* time I tried, it would not keep the channels synchronized on the TDM *>>>>>* bus. I tried playing with the FIFO settings, which helped, but it *>>>>>* still would not start each channel in the right slot reliably. *>>>>>* Perhaps I was using an older kernel. *>>>>>>>>* you put the finger on what's hurting ! ;) *>>>>>>>>* In fact, we made 8 channels working in reliable way on imx50, with *>>>>* predictive latency ... with an old kernel (3.17) ... based on freescale *>>>>* BSP... on sound/soc/imx/imx-ssi.c (something that doesn't exist outside *>>>>* freescale BSP) *>>>>>>>>* Well, just to say it is doable on any recent imx since the hardware is *>>>>* not *>>>>* the issue. But the job was a set of awful hacks. *>>>>>>* Sorry, I don't quite understand. Are you saying that on a recent *>>>* kernel (say 4.1 or 4.2), you think it will just work. Or are yo *>>>* saying that even on a modern kernel it's a set of awful hacks? And *>>>* should I use fsl_ssi.c or imx-ssi.c (device tree/non device tree) *>>>* version? *>>>>* - I'm saying it is working on recent upstream kernel, using *>>* sound/soc/fsl/fsl_ssi.c, but with *>>* some channel sync issues in rare conditions (at least 4 channels case, *>>* opening multiple SSI at the same time). *>>* So, you should test on your side with you setup, and simply be prepared to *>>* not see it working as a charm. *>>>>* - we made it work perfectly, but on an old freescale BSP, where freescale *>>* rewrites a SSI driver different from the already 2 drivers (device tree/non *>>* device tree) available today in upstream + lot of awful hacks => so, this is *>>* not a hardware issue. *>>>>* - when I will have time, I will start from the upstream driver, and make it *>>* work correctly with 8 channels (or more) *>>>>* arnaud *>>>>>>>>* In short, what's your best current recommendation to get it working today? *>>>>>>>* My plan was to re-do all this job on an upstream kernel, in a way it can *>>>>* be *>>>>* accepted. *>>>>* Unfortunately you will have to wait, I'm under pressure for other stuff *>>>>* right now. *>>>>>>* Heh, understood. If there's anything I can do to help, let me know. *>>>>>>* Thanks, *>>>* -Caleb *>>>>>>>* Regards, *>>>>* arnaud *>>>>>>>>>>>>>* I'll give it a try again. Like I said, we'd love to get our *>>>>>* 16-channel board up and running on the MX6, so I'm definitely *>>>>>* motivated to put some work in to get it reliable. *>>>>>>>>>>* Thanks, *>>>>>* -Caleb *>>>>>>> -- [image: SMILE] <http://www.smile.eu/> 20 rue des Jardins 92600 Asnières-sur-Seine *Yann CARDAILLAC* Ingénieur Linux Embarqué [image: email] yann.cardaillac(a)smile.fr [image: url] http://www.smile.eu [image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook] <https://www.facebook.com/smileopensource> [image: LinkedIn] <https://www.linkedin.com/company/smile> [image: Github] <https://github.com/Smile-SA> [image: eco] Pour la planète, n'imprimez ce mail que si c'est nécessaire

2 1

[alsa-devel] [PATCH V3] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode
by S.j. Wang 18 Feb '19

18 Feb '19

The ESAI_xCR_xWA is xCR's bit, not the xCCR's bit, driver set it to wrong register, correct it. Fixes 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") Cc: <stable(a)vger.kernel.org> Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> Reviewed-by: Fabio Estevam <festevam(a)gmail.com> Ackedy-by: Nicolin Chen <nicoleotsuka(a)gmail.com> --- Changes in v3 - Add Cc: <stable(a)vger.kernel.org> sound/soc/fsl/fsl_esai.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 57b484768a58..afe67c865330 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -398,7 +398,8 @@ static int fsl_esai_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) break; case SND_SOC_DAIFMT_RIGHT_J: /* Data on rising edge of bclk, frame high, right aligned */ - xccr |= ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP | ESAI_xCR_xWA; + xccr |= ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP; + xcr |= ESAI_xCR_xWA; break; case SND_SOC_DAIFMT_DSP_A: /* Data on rising edge of bclk, frame high, 1clk before data */ @@ -455,12 +456,12 @@ static int fsl_esai_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } - mask = ESAI_xCR_xFSL | ESAI_xCR_xFSR; + mask = ESAI_xCR_xFSL | ESAI_xCR_xFSR | ESAI_xCR_xWA; regmap_update_bits(esai_priv->regmap, REG_ESAI_TCR, mask, xcr); regmap_update_bits(esai_priv->regmap, REG_ESAI_RCR, mask, xcr); mask = ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP | ESAI_xCCR_xFSP | - ESAI_xCCR_xFSD | ESAI_xCCR_xCKD | ESAI_xCR_xWA; + ESAI_xCCR_xFSD | ESAI_xCCR_xCKD; regmap_update_bits(esai_priv->regmap, REG_ESAI_TCCR, mask, xccr); regmap_update_bits(esai_priv->regmap, REG_ESAI_RCCR, mask, xccr); -- 1.9.1

1 0