January 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 2/2] ASoC: pcm512x: Fix clocking calculations when not using the PLL
by Dimitris Papavasiliou 28 Jan '19

28 Jan '19

The rationale behind the current calculation is somewhat obscure [1] and can yield slightly wrong dividers in certain cases, which the machine drivers for some boards (like the HiFiBerry DAC+ Pro) seemingly try to circumvent, by updating the rate fraction so as to suit this calculation. The updated calculation should correctly yield the smallest bit clock rate that would fit the frame. [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2019-January/144219.ht… Signed-off-by: Dimitris Papavasiliou <dpapavas(a)gmail.com> --- sound/soc/codecs/pcm512x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index b63d9392bae3..87a2bff366f3 100644 --- a/sound/soc/codecs/pcm512x.c +++ b/sound/soc/codecs/pcm512x.c @@ -929,8 +929,8 @@ static int pcm512x_set_dividers(struct snd_soc_dai *dai, if (!pcm512x->pll_out) { sck_rate = clk_get_rate(pcm512x->sclk); - bclk_div = params->rate_den * 64 / lrclk_div; - bclk_rate = DIV_ROUND_CLOSEST(sck_rate, bclk_div); + bclk_rate = params_rate(params) * lrclk_div; + bclk_div = DIV_ROUND_CLOSEST(sck_rate, bclk_rate); mck_rate = sck_rate; } else { -- 2.11.0

2 1

[alsa-devel] [PATCH] ASoC: soc-acpi: add static inline fallbacks when CONFIG_ACPI=n
by Pierre-Louis Bossart 28 Jan '19

28 Jan '19

Fix compilation issues reported by 0day-Kbuild with sparc64 w/ SOF. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- include/sound/soc-acpi.h | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/include/sound/soc-acpi.h b/include/sound/soc-acpi.h index 266e64e3c24c..6cbbeed9cdd0 100644 --- a/include/sound/soc-acpi.h +++ b/include/sound/soc-acpi.h @@ -22,20 +22,37 @@ struct snd_soc_acpi_package_context { #define SND_ACPI_I2C_ID_LEN (4 + ACPI_ID_LEN + 3 + 1) #if IS_ENABLED(CONFIG_ACPI) +/* acpi match */ +struct snd_soc_acpi_mach * +snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines); + bool snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN], struct snd_soc_acpi_package_context *ctx); + +/* check all codecs */ +struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg); + #else +/* acpi match */ +static inline struct snd_soc_acpi_mach * +snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines) +{ + return NULL; +} + static inline bool snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN], struct snd_soc_acpi_package_context *ctx) { return false; } -#endif -/* acpi match */ -struct snd_soc_acpi_mach * -snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines); +/* check all codecs */ +static inline struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg) +{ + return NULL; +} +#endif /** * snd_soc_acpi_mach_params: interface for machine driver configuration @@ -105,7 +122,4 @@ struct snd_soc_acpi_codecs { u8 codecs[SND_SOC_ACPI_MAX_CODECS][ACPI_ID_LEN]; }; -/* check all codecs */ -struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg); - #endif -- 2.17.1

2 1

[alsa-devel] Applied "ASoC: rt5651: Variable "ret" in function rt5651_i2c_probe() could be uninitialized" to the asoc tree
by Mark Brown 28 Jan '19

28 Jan '19

The patch ASoC: rt5651: Variable "ret" in function rt5651_i2c_probe() could be uninitialized has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From e20bfeb0b7d808bc05e7c4cb1f492cd31d837da0 Mon Sep 17 00:00:00 2001 From: Yizhuo <yzhai003(a)ucr.edu> Date: Fri, 25 Jan 2019 10:45:37 -0800 Subject: [PATCH] ASoC: rt5651: Variable "ret" in function rt5651_i2c_probe() could be uninitialized In function rt5651_i2c_probe(), local variable "ret" could be uninitialized if function regmap_read() returns -EINVAL. However, this value is used in if statement. This is potentially unsafe. Signed-off-by: Yizhuo <yzhai003(a)ucr.edu> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/rt5651.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index 75994297c896..29b2d60076b0 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -2181,6 +2181,7 @@ static int rt5651_i2c_probe(struct i2c_client *i2c, { struct rt5651_priv *rt5651; int ret; + int err; rt5651 = devm_kzalloc(&i2c->dev, sizeof(*rt5651), GFP_KERNEL); @@ -2197,7 +2198,10 @@ static int rt5651_i2c_probe(struct i2c_client *i2c, return ret; } - regmap_read(rt5651->regmap, RT5651_DEVICE_ID, &ret); + err = regmap_read(rt5651->regmap, RT5651_DEVICE_ID, &ret); + if (err) + return err; + if (ret != RT5651_DEVICE_ID_VALUE) { dev_err(&i2c->dev, "Device with ID register %#x is not rt5651\n", ret); -- 2.20.1

1 0

[alsa-devel] Record stereo from one input on the soundcard
by Tomas Nordin 28 Jan '19

28 Jan '19

Hello List I sent this question first to the alsa-user list but somebody recommended somebody to send to this list instead when the user-list don't get much attention. I have an external USB soundcard called Audiobox from Presonus, https://www.presonus.com/products/AudioBox-USB. Somewhere I read that this is a class compliant USB sound card. I use this card to record audio from a drum module (e-drums). I take the audio signal from the head phones out socket on the module, and plug it into input 1 on the card. The card has 2 inputs, for the moment I don't use the second input but I consider it busy. For a minimum of hassle I want to make my recording using arecord (want to use a command line program). So the card is a kind of bedroom musician type of card that might have 2 inputs, 4 inputs or 12 or whatever, to record a number of instruments at the same time. But as I said, this card has two inputs. The audio signal from the headphones out socket (on the drum module) is stereo. The card support routing that stereo sound from one input, in so far that it can be heard in stereo from the cards head phones out. The following command lets me record audio from the card, $ arecord -c 2 -d 60 -f S24_3LE -r 48000 -D hw:1,0 s3.wav The resulting wav file has all hearable audio in the left speaker when listening. Do you think it is possible to get that stereo signal from one input on the card into a stereo sound file. Or somehow else get left and right audio separately from that input 1 on the card. My guess on what's happening now is that the stereo signal gets merged as mono into one channel. Here are some listings: $ uname -a Linux raspberrypi 4.14.79+ #1159 Sun Nov 4 17:28:08 GMT 2018 armv6l GNU/Linux $ arecord -l **** List of CAPTURE Hardware Devices **** card 1: USB [AudioBox USB], device 0: USB Audio [USB Audio] Subdevices: 1/1 Subdevice #0: subdevice #0 $ arecord --dump-hw-params -D hw:1,0 Recording WAVE 'stdin' : Unsigned 8 bit, Rate 8000 Hz, Mono HW Params of device "hw:1,0": -------------------- ACCESS: MMAP_INTERLEAVED RW_INTERLEAVED FORMAT: S24_3LE SUBFORMAT: STD SAMPLE_BITS: 24 FRAME_BITS: 48 CHANNELS: 2 RATE: [44100 48000] PERIOD_TIME: [1000 1981429) PERIOD_SIZE: [45 87381] PERIOD_BYTES: [270 524286] PERIODS: [2 1024] BUFFER_TIME: [1875 3962858) BUFFER_SIZE: [90 174762] BUFFER_BYTES: [540 1048572] TICK_TIME: ALL -------------------- arecord: set_params:1299: Sample format non available Available formats: - S24_3LE Any ideas anyone? Best regards -- Tomas

3 5

[alsa-devel] [RFC PATCH 0/2] ASoC: mediatek: add btcvsd driver
by KaiChieh Chuang 28 Jan '19

28 Jan '19

The driver function for transferring/receiving BT encoded data to/from BT hardware. KaiChieh Chuang (2): ASoC: mediatek: add btcvsd driver ASoC: mediatek: add documents for btcvsd driver .../bindings/sound/mtk-btcvsd-snd.txt | 24 + sound/soc/mediatek/Kconfig | 9 + sound/soc/mediatek/common/Makefile | 2 + sound/soc/mediatek/common/mtk-btcvsd.c | 1376 +++++++++++++++++ 4 files changed, 1411 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mtk-btcvsd-snd.txt create mode 100644 sound/soc/mediatek/common/mtk-btcvsd.c -- 2.18.0

2 4

[alsa-devel] [PATCH 0/6] ASoC: soc-core: cleanup and platform
by Kuninori Morimoto 28 Jan '19

28 Jan '19

Hi Mark I merged my posted patches into 1 patch-set, and arranged patch order. 2) - 6) are not yet reviewed. Kuninori Morimoto (6): 1) ASoC: soc-core: add .num_platform for dai_link 2) ASoC: soc-core: add new snd_soc_flush_all_delayed_work() 3) ASoC: soc-core: merge card resources cleanup method 4) ASoC: soc-core: reduce if/else nest on soc_probe_link_dais 5) ASoC: soc-core: add soc_cleanup_component() 6) ASoC: soc-core: use for_each_link_codecs() for dai_link codecs include/sound/simple_card_utils.h | 2 +- include/sound/soc.h | 3 +- sound/soc/generic/audio-graph-card.c | 5 +- sound/soc/generic/simple-card-utils.c | 4 +- sound/soc/generic/simple-card.c | 7 +- sound/soc/soc-core.c | 211 ++++++++++++++++------------------ 6 files changed, 114 insertions(+), 118 deletions(-) -- 2.7.4

3 17

[alsa-devel] alsa-utils 1.1.8: axfer tests take ages tu run.
by Elimar Riesebieter 27 Jan '19

27 Jan '19

Hi, what are the tests in alsa-utils-1.1.8/axfer/test/ good for? mapper-test and container-test are running very long time. I Can't find any docu in the source? If the need as long as on my 8-core the source is not ready for distribution, though. Elimar -- You cannot propel yourself forward by patting yourself on the back.

2 6

[alsa-devel] [PATCH 0/7] alsa-utils: axfer: misc fixes for manual
by GitHub pull_request - opened 27 Jan '19

27 Jan '19

alsa-project/alsa-utils pull request #12 was opened from takaswie: Hi, This patchset includes fixes for the manual of axfer and add an entry to README in the end. ``` Takashi Sakamoto (7): axfer: add a section about unit test axfer: fulfill section for backward compatibitity for chmap option axfer: correct description about snoop mode of libffado axfer: correct message to notice that help text is implemented axfer: supplement value of options for the manual of transfer subcommand axfer: correct invalid usage of escape of itaric text axfer: add an entry of axfer to README README.md | 1 + axfer/axfer-transfer.1 | 74 ++++++++++++++++++++++++++++-------------- axfer/axfer.1 | 7 ++++ 3 files changed, 58 insertions(+), 24 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-utils/pull/12 Patch URL : https://github.com/alsa-project/alsa-utils/pull/12.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[alsa-devel] [PATCH] axfer: allow to be compiled with glibc-2.11 or former
by GitHub pull_request - opened 27 Jan '19

27 Jan '19

alsa-project/alsa-utils pull request #11 was opened from takaswie: The program, axfer, was developed in userspace with glibc-2.28. This userspace is mostly compliant to POSIX:2008 and some additional macros for poll event are officially available. The glibc supports them as a default since its v2.12 release. It will be failed to be compiled with old glibc or the other libraries for C standard APIs. One of the purpose of axfer is an better alternative of aplay. In a point of the purpose, it's preferable to be compiled with the old libraries. This commit adds conditional macros to be compiled with libraries for old compliance level of POSIX. This fixes #9 . Request URL : https://github.com/alsa-project/alsa-utils/pull/11 Patch URL : https://github.com/alsa-project/alsa-utils/pull/11.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[alsa-devel] alsa-utils source is missing axfer/test/generator.h
by Elimar Riesebieter 27 Jan '19

27 Jan '19

Hi, downloaded ftp://ftp.alsa-project.org/pub/utils/alsa-utils-1.1.8.tar.bz2. axfer/test/generator.h is missing in this tarball Elimar -- 355/113: Not the famous irrational number pi, but an incredible simulation! -unknown

2 1