January 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Applied "ASoC: Intel: atom: Make PCI dependency explicit" to the asoc tree
by Mark Brown 03 Jan '19

03 Jan '19

The patch ASoC: Intel: atom: Make PCI dependency explicit has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 6a444da7ddc6e478637a189a9c2898f2c3e0d399 Mon Sep 17 00:00:00 2001 From: Sinan Kaya <okaya(a)kernel.org> Date: Wed, 2 Jan 2019 18:10:35 +0000 Subject: [PATCH] ASoC: Intel: atom: Make PCI dependency explicit After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. This code relies on IOSF_MBI and IOSF_MBI depends on PCI. For this reason, add a direct dependency on CONFIG_PCI to the IOSF_MBI driver. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya(a)kernel.org> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index 99a62ba409df..bd9fd2035c55 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI config SND_SST_ATOM_HIFI2_PLATFORM_ACPI tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" default ACPI - depends on X86 && ACPI + depends on X86 && ACPI && PCI select SND_SST_IPC_ACPI select SND_SST_ATOM_HIFI2_PLATFORM select SND_SOC_ACPI_INTEL_MATCH -- 2.20.1

1 0

Re: [alsa-devel] [PATCH] In function rt274_i2c_probe(), if the regmap_read fails. The variable "val" could leave uninitialized but used in if statement.
by Mark Brown 03 Jan '19

03 Jan '19

On Wed, Jan 02, 2019 at 06:38:39PM -0800, Yizhuo wrote: > int ret; > - unsigned int val; > + unsigned int val = ~0; > This just shuts warnings up which may mask further problem, it is better to just leave it and fix the users. > - regmap_read(rt274->regmap, > + ret = regmap_read(rt274->regmap, > RT274_GET_PARAM(AC_NODE_ROOT, AC_PAR_VENDOR_ID), &val); > - if (val != RT274_VENDOR_ID) { > + if (ret || val != RT274_VENDOR_ID) { > dev_err(&i2c->dev, > "Device with ID register %#x is not rt274\n", val); > return -ENODEV; If the read returned an error we should pass back the error code we got from it, not mask it with another error code. This is especially true here where the error message would be very misleading if there's a problem with I/O.

1 0

Re: [alsa-devel] [PATCH] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode
by Mark Brown 03 Jan '19

03 Jan '19

On Wed, Jan 02, 2019 at 10:36:33PM +0530, b-ak wrote: > During the bootup of the kernel, as soon as the DAPM framework kicks in > it pushes the codec into standy mode. > > The existing TVL320AIC32x4 codec driver doesn't prepare the clock in > the probe function. > This leads to an OOPS when the DAPM tries to put it into standy by calling > clk_disable_unprepare() > > This patch fixes that problem. This isn't the best way of fixing this because it makes it look like there's a missing disable in the removal process. What would be better would be to do what other drivers do and check to see what state we're transitioning from before we disable the clock in set_bias_level(). See drivers like wm8903.c for examples.

1 0

[alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
by Sinan Kaya 03 Jan '19

03 Jan '19

After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. This code relies on IOSF_MBI and IOSF_MBI depends on PCI. For this reason, add a direct dependency on CONFIG_PCI to the IOSF_MBI driver. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya(a)kernel.org> --- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index 2fd1b61e8331..b0764b2fe001 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI config SND_SST_ATOM_HIFI2_PLATFORM_ACPI tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" default ACPI - depends on X86 && ACPI + depends on X86 && ACPI && PCI select SND_SST_IPC_ACPI select SND_SST_ATOM_HIFI2_PLATFORM select SND_SOC_ACPI_INTEL_MATCH -- 2.19.0

4 9

[alsa-devel] [PATCH 2/2] ALSA: oxygen: initialize spdif_playback_enable to 0
by tom.ty89＠gmail.com 03 Jan '19

03 Jan '19

From: Tom Yan <tom.ty89(a)gmail.com> oxygen_init() has been clearing the OXYGEN_SPDIF_OUT_ENABLE bit and initializing dac_mute to 1. Signed-off-by: Tom Yan <tom.ty89(a)gmail.com> diff --git a/sound/pci/oxygen/oxygen_lib.c b/sound/pci/oxygen/oxygen_lib.c index b4ef5804212d..6a743c878415 100644 --- a/sound/pci/oxygen/oxygen_lib.c +++ b/sound/pci/oxygen/oxygen_lib.c @@ -373,7 +373,7 @@ static void oxygen_init(struct oxygen *chip) for (i = 0; i < 8; ++i) chip->dac_volume[i] = chip->model.dac_volume_min; chip->dac_mute = 1; - chip->spdif_playback_enable = 1; + chip->spdif_playback_enable = 0; chip->spdif_bits = OXYGEN_SPDIF_C | OXYGEN_SPDIF_ORIGINAL | (IEC958_AES1_CON_PCM_CODER << OXYGEN_SPDIF_CATEGORY_SHIFT); chip->spdif_pcm_bits = chip->spdif_bits; -- 2.20.1

1 0

[alsa-devel] [Bug] [oxygen] Left/Right volumes de-sync when changed fast
by Tom Yan 03 Jan '19

03 Jan '19

Hi all, This is actually quite a long-time issue as far as I am aware of. My card is Xonar Essence STX. There is no problem when I change the volume in alsamixer. The problem occurs when I bind XF86Audio{Raise,Lower}Volume (a volume wheel on my keyboard) to amixer commands. Volumes of the two channel can easily de-sync from each other as long as I roll the wheel (up or down) fast. The problem doesn't occur if the commands target volume control of a onboard or USB sound card (even while their control allows different volumes for the two channels). Regards, Tom

1 0

[alsa-devel] [PATCH 1/2] ASoC: Intel: sst: Fallback to BYT-CR if IRQ 5 is missing
by Stephan Gerhold 02 Jan '19

02 Jan '19

Some devices detected as BYT-T by the PMIC-type based detection have only a single IRQ listed in the 80860F28 ACPI device. This causes -ENXIO later when attempting to get the IRQ at index 5. It turns out these devices behave more like BYT-CR devices, and using the IRQ at index 0 makes sound work correctly. This patch adds a fallback for these devices to is_byt_cr(): If there is no IRQ resource at index 5, treating the device as BYT-T is guaranteed to fail later, so we can safely treat these devices as BYT-CR without breaking any working device. Link: http://mailman.alsa-project.org/pipermail/alsa-devel/2018-December/143176.h… Signed-off-by: Stephan Gerhold <stephan(a)gerhold.net> --- Moved the "Detected Baytrail-CR platform" message to is_byt_cr() so we can log a different message if the fallback is used. Tested this on my device as-is, and simulated a "normal" BYT-T and BYT-CR device (copied their IRQs to a custom DSDT). sound/soc/intel/atom/sst/sst_acpi.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c index 3a95ebbfc45d..755a396121ff 100644 --- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -255,10 +255,22 @@ static int is_byt(void) return status; } -static int is_byt_cr(struct device *dev, bool *bytcr) +static int is_byt_cr(struct platform_device *pdev, bool *bytcr) { + struct device *dev = &pdev->dev; int status = 0; + if (platform_get_resource(pdev, IORESOURCE_IRQ, 5) == NULL) { + /* + * Some devices detected as BYT-T have only a single IRQ listed, + * causing platform_get_irq with index 5 to return -ENXIO. + * The correct IRQ in this case is at index 0, as used on BYT-CR. + */ + dev_info(dev, "Falling back to Baytrail-CR platform\n"); + *bytcr = true; + return status; + } + if (IS_ENABLED(CONFIG_IOSF_MBI)) { u32 bios_status; @@ -278,10 +290,12 @@ static int is_byt_cr(struct device *dev, bool *bytcr) /* bits 26:27 mirror PMIC options */ bios_status = (bios_status >> 26) & 3; - if ((bios_status == 1) || (bios_status == 3)) + if ((bios_status == 1) || (bios_status == 3)) { + dev_info(dev, "Detected Baytrail-CR platform\n"); *bytcr = true; - else + } else { dev_info(dev, "BYT-CR not detected\n"); + } } } else { dev_info(dev, "IOSF_MBI not enabled, no BYT-CR detection\n"); @@ -333,10 +347,8 @@ static int sst_acpi_probe(struct platform_device *pdev) if (ret < 0) return ret; - ret = is_byt_cr(dev, &bytcr); + ret = is_byt_cr(pdev, &bytcr); if (!(ret < 0 || !bytcr)) { - dev_info(dev, "Detected Baytrail-CR platform\n"); - /* override resource info */ byt_rvp_platform_data.res_info = &bytcr_res_info; } -- 2.20.1

3 10

[alsa-devel] [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
by Sinan Kaya 02 Jan '19

02 Jan '19

Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on CONFIG_PCI set but this is not specified anywhere. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya(a)kernel.org> --- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index 2fd1b61e8331..b0764b2fe001 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI config SND_SST_ATOM_HIFI2_PLATFORM_ACPI tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" default ACPI - depends on X86 && ACPI + depends on X86 && ACPI && PCI select SND_SST_IPC_ACPI select SND_SST_ATOM_HIFI2_PLATFORM select SND_SOC_ACPI_INTEL_MATCH -- 2.19.0

4 11

[alsa-devel] [PATCH 1/2] ALSA: usb-audio: Avoid access before bLength check in build_audio_procunit()
by Takashi Iwai 02 Jan '19

02 Jan '19

The parser for the processing unit reads bNrInPins field before the bLength sanity check, which may lead to an out-of-bound access when a malformed descriptor is given. Fix it by assignment after the bLength check. Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/mixer.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index c63c84b54969..0131de348cf6 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2314,7 +2314,7 @@ static int build_audio_procunit(struct mixer_build *state, int unitid, char *name) { struct uac_processing_unit_descriptor *desc = raw_desc; - int num_ins = desc->bNrInPins; + int num_ins; struct usb_mixer_elem_info *cval; struct snd_kcontrol *kctl; int i, err, nameid, type, len; @@ -2329,7 +2329,13 @@ static int build_audio_procunit(struct mixer_build *state, int unitid, 0, NULL, default_value_info }; - if (desc->bLength < 13 || desc->bLength < 13 + num_ins || + if (desc->bLength < 13) { + usb_audio_err(state->chip, "invalid %s descriptor (id %d)\n", name, unitid); + return -EINVAL; + } + + num_ins = desc->bNrInPins; + if (desc->bLength < 13 + num_ins || desc->bLength < num_ins + uac_processing_unit_bControlSize(desc, state->mixer->protocol)) { usb_audio_err(state->chip, "invalid %s descriptor (id %d)\n", name, unitid); return -EINVAL; -- 2.19.2

1 1

[alsa-devel] [PATCH 0/8] alsa-utils: axfer: fulfill help texts and manual sections for each of xfer backend
by GitHub pull_request - opened 02 Jan '19

02 Jan '19

alsa-project/alsa-utils pull request #8 was opened from takaswie: Hi, This patchset fulfills help texts and manual sections for each of xfer backend. All of options are described in this patchset, however I leave a placeholder for scheduling model of libasound. This section will be fulfilled later. (I note that this is a first attempt to explain about `slave` and `snoop` options of libffado.) ``` Takashi Sakamoto (8): axfer: fix no return statement in print_help() function axfer: fix typo in axfer(1) manual axfer: correct description about signal handling axfer: print help for libffado backend axfer: fulfill manual section for libffado backend axfer: print help for libasound backend axfer: fulfill manual section for libasound backend axfer: add text for compatibility loss of sw parameter in libasound backend axfer/axfer-transfer.1 | 383 ++++++++++++++++++++++++++++++++++++++++- axfer/axfer.1 | 2 +- axfer/xfer-libasound.c | 25 ++- axfer/xfer-libffado.c | 11 +- axfer/xfer-options.c | 2 +- 5 files changed, 414 insertions(+), 9 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-utils/pull/8 Patch URL : https://github.com/alsa-project/alsa-utils/pull/8.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0