August 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v1] ASoC: Intel: Skylake: Switch to modern UUID API
by Andy Shevchenko 21 Jan '19

21 Jan '19

Switch the driver to use modern UUID API, i.e. guid_t type and accompanying functions, such as guid_equal(). Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Vinod Koul <vkoul(a)kernel.org> Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- sound/soc/intel/skylake/skl-pcm.c | 12 ++++++------ sound/soc/intel/skylake/skl-sst-dsp.h | 6 +++--- sound/soc/intel/skylake/skl-sst-utils.c | 23 +++++++---------------- sound/soc/intel/skylake/skl-sst.c | 4 ++-- sound/soc/intel/skylake/skl-topology.c | 24 ++++++++++++------------ sound/soc/intel/skylake/skl-topology.h | 6 +++--- 6 files changed, 33 insertions(+), 42 deletions(-) diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c index 823e39103edd..86f8ebc77a32 100644 --- a/sound/soc/intel/skylake/skl-pcm.c +++ b/sound/soc/intel/skylake/skl-pcm.c @@ -1268,12 +1268,12 @@ static int skl_get_module_info(struct skl *skl, struct skl_module_cfg *mconfig) { struct skl_sst *ctx = skl->skl_sst; struct skl_module_inst_id *pin_id; - uuid_le *uuid_mod, *uuid_tplg; + guid_t *uuid_mod, *uuid_tplg; struct skl_module *skl_module; struct uuid_module *module; int i, ret = -EIO; - uuid_mod = (uuid_le *)mconfig->guid; + uuid_mod = (guid_t *)mconfig->guid; if (list_empty(&ctx->uuid_list)) { dev_err(ctx->dev, "Module list is empty\n"); @@ -1281,7 +1281,7 @@ static int skl_get_module_info(struct skl *skl, struct skl_module_cfg *mconfig) } list_for_each_entry(module, &ctx->uuid_list, list) { - if (uuid_le_cmp(*uuid_mod, module->uuid) == 0) { + if (guid_equal(uuid_mod, &module->uuid)) { mconfig->id.module_id = module->id; if (mconfig->module) mconfig->module->loadable = module->is_loadable; @@ -1298,7 +1298,7 @@ static int skl_get_module_info(struct skl *skl, struct skl_module_cfg *mconfig) for (i = 0; i < skl->nr_modules; i++) { skl_module = skl->modules[i]; uuid_tplg = &skl_module->uuid; - if (!uuid_le_cmp(*uuid_mod, *uuid_tplg)) { + if (guid_equal(uuid_mod, uuid_tplg)) { mconfig->module = skl_module; ret = 0; break; @@ -1310,13 +1310,13 @@ static int skl_get_module_info(struct skl *skl, struct skl_module_cfg *mconfig) list_for_each_entry(module, &ctx->uuid_list, list) { for (i = 0; i < MAX_IN_QUEUE; i++) { pin_id = &mconfig->m_in_pin[i].id; - if (!uuid_le_cmp(pin_id->mod_uuid, module->uuid)) + if (guid_equal(&pin_id->mod_uuid, &module->uuid)) pin_id->module_id = module->id; } for (i = 0; i < MAX_OUT_QUEUE; i++) { pin_id = &mconfig->m_out_pin[i].id; - if (!uuid_le_cmp(pin_id->mod_uuid, module->uuid)) + if (guid_equal(&pin_id->mod_uuid, &module->uuid)) pin_id->module_id = module->id; } } diff --git a/sound/soc/intel/skylake/skl-sst-dsp.h b/sound/soc/intel/skylake/skl-sst-dsp.h index e1d6f6719f7e..cbc7a93d56c2 100644 --- a/sound/soc/intel/skylake/skl-sst-dsp.h +++ b/sound/soc/intel/skylake/skl-sst-dsp.h @@ -177,7 +177,7 @@ struct skl_dsp_loader_ops { #define MAX_INSTANCE_BUFF 2 struct uuid_module { - uuid_le uuid; + guid_t uuid; int id; int is_loadable; int max_instance; @@ -241,8 +241,8 @@ void bxt_sst_dsp_cleanup(struct device *dev, struct skl_sst *ctx); int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, unsigned int offset, int index); -int skl_get_pvt_id(struct skl_sst *ctx, uuid_le *uuid_mod, int instance_id); -int skl_put_pvt_id(struct skl_sst *ctx, uuid_le *uuid_mod, int *pvt_id); +int skl_get_pvt_id(struct skl_sst *ctx, guid_t *uuid_mod, int instance_id); +int skl_put_pvt_id(struct skl_sst *ctx, guid_t *uuid_mod, int *pvt_id); int skl_get_pvt_instance_id_map(struct skl_sst *ctx, int module_id, int instance_id); void skl_freeup_uuid_list(struct skl_sst *ctx); diff --git a/sound/soc/intel/skylake/skl-sst-utils.c b/sound/soc/intel/skylake/skl-sst-utils.c index 2ae405617876..85551321c35b 100644 --- a/sound/soc/intel/skylake/skl-sst-utils.c +++ b/sound/soc/intel/skylake/skl-sst-utils.c @@ -21,17 +21,11 @@ #include "../common/sst-dsp-priv.h" #include "skl-sst-ipc.h" - -#define UUID_STR_SIZE 37 #define DEFAULT_HASH_SHA256_LEN 32 /* FW Extended Manifest Header id = $AE1 */ #define SKL_EXT_MANIFEST_HEADER_MAGIC 0x31454124 -struct UUID { - u8 id[16]; -}; - union seg_flags { u32 ul; struct { @@ -65,7 +59,7 @@ struct module_type { struct adsp_module_entry { u32 struct_id; u8 name[8]; - struct UUID uuid; + u8 uuid[16]; struct module_type type; u8 hash1[DEFAULT_HASH_SHA256_LEN]; u32 entry_point; @@ -184,13 +178,13 @@ static inline int skl_pvtid_128(struct uuid_module *module) * This generates a 128 bit private unique id for a module TYPE so that * module instance is unique */ -int skl_get_pvt_id(struct skl_sst *ctx, uuid_le *uuid_mod, int instance_id) +int skl_get_pvt_id(struct skl_sst *ctx, guid_t *uuid_mod, int instance_id) { struct uuid_module *module; int pvt_id; list_for_each_entry(module, &ctx->uuid_list, list) { - if (uuid_le_cmp(*uuid_mod, module->uuid) == 0) { + if (guid_equal(uuid_mod, &module->uuid)) { pvt_id = skl_pvtid_128(module); if (pvt_id >= 0) { @@ -214,13 +208,13 @@ EXPORT_SYMBOL_GPL(skl_get_pvt_id); * * This frees a 128 bit private unique id previously generated */ -int skl_put_pvt_id(struct skl_sst *ctx, uuid_le *uuid_mod, int *pvt_id) +int skl_put_pvt_id(struct skl_sst *ctx, guid_t *uuid_mod, int *pvt_id) { int i; struct uuid_module *module; list_for_each_entry(module, &ctx->uuid_list, list) { - if (uuid_le_cmp(*uuid_mod, module->uuid) == 0) { + if (guid_equal(uuid_mod, &module->uuid)) { if (*pvt_id != 0) i = (*pvt_id) / 64; @@ -247,7 +241,6 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, struct adsp_fw_hdr *adsp_hdr; struct adsp_module_entry *mod_entry; int i, num_entry, size; - uuid_le *uuid_bin; const char *buf; struct skl_sst *skl = ctx->thread_context; struct uuid_module *module; @@ -279,8 +272,7 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, return -EINVAL; } - mod_entry = (struct adsp_module_entry *) - (buf + offset + adsp_hdr->len); + mod_entry = (struct adsp_module_entry *)(buf + offset + adsp_hdr->len); num_entry = adsp_hdr->num_modules; @@ -307,8 +299,7 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, goto free_uuid_list; } - uuid_bin = (uuid_le *)mod_entry->uuid.id; - memcpy(&module->uuid, uuid_bin, sizeof(module->uuid)); + guid_copy(&module->uuid, (guid_t *)&mod_entry->uuid); module->id = (i | (index << 12)); module->is_loadable = mod_entry->type.load_type; diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c index 5951bbdf1f1a..92806119a755 100644 --- a/sound/soc/intel/skylake/skl-sst.c +++ b/sound/soc/intel/skylake/skl-sst.c @@ -420,9 +420,9 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, u8 *guid) struct skl_module_table *module_entry = NULL; int ret = 0; char mod_name[64]; /* guid str = 32 chars + 4 hyphens */ - uuid_le *uuid_mod; + guid_t *uuid_mod; - uuid_mod = (uuid_le *)guid; + uuid_mod = (guid_t *)guid; snprintf(mod_name, sizeof(mod_name), "%s%pUL%s", "intel/dsp_fw_", uuid_mod, ".bin"); diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 76dde12cc2bb..160a5c864b3f 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -577,7 +577,7 @@ skl_tplg_init_pipe_modules(struct skl *skl, struct skl_pipe *pipe) int ret = 0; list_for_each_entry(w_module, &pipe->w_list, node) { - uuid_le *uuid_mod; + guid_t *uuid_mod; w = w_module->w; mconfig = w->priv; @@ -585,7 +585,7 @@ skl_tplg_init_pipe_modules(struct skl *skl, struct skl_pipe *pipe) if (mconfig->id.module_id < 0) { dev_err(skl->skl_sst->dev, "module %pUL id not populated\n", - (uuid_le *)mconfig->guid); + (guid_t *)mconfig->guid); return -EIO; } @@ -619,7 +619,7 @@ skl_tplg_init_pipe_modules(struct skl *skl, struct skl_pipe *pipe) * FE/BE params */ skl_tplg_update_module_params(w, ctx); - uuid_mod = (uuid_le *)mconfig->guid; + uuid_mod = (guid_t *)mconfig->guid; mconfig->id.pvt_id = skl_get_pvt_id(ctx, uuid_mod, mconfig->id.instance_id); if (mconfig->id.pvt_id < 0) @@ -658,9 +658,9 @@ static int skl_tplg_unload_pipe_modules(struct skl_sst *ctx, struct skl_module_cfg *mconfig = NULL; list_for_each_entry(w_module, &pipe->w_list, node) { - uuid_le *uuid_mod; + guid_t *uuid_mod; mconfig = w_module->w->priv; - uuid_mod = (uuid_le *)mconfig->guid; + uuid_mod = (guid_t *)mconfig->guid; if (mconfig->module->loadable && ctx->dsp->fw_ops.unload_mod && mconfig->m_state > SKL_MODULE_UNINIT) { @@ -916,12 +916,12 @@ static int skl_tplg_set_module_bind_params(struct snd_soc_dapm_widget *w, return 0; } -static int skl_get_module_id(struct skl_sst *ctx, uuid_le *uuid) +static int skl_get_module_id(struct skl_sst *ctx, guid_t *uuid) { struct uuid_module *module; list_for_each_entry(module, &ctx->uuid_list, list) { - if (uuid_le_cmp(*uuid, module->uuid) == 0) + if (guid_equal(uuid, &module->uuid)) return module->id; } @@ -2121,11 +2121,11 @@ static int skl_tplg_add_pipe(struct device *dev, return 0; } -static int skl_tplg_get_uuid(struct device *dev, u8 *guid, +static int skl_tplg_get_uuid(struct device *dev, guid_t *guid, struct snd_soc_tplg_vendor_uuid_elem *uuid_tkn) { if (uuid_tkn->token == SKL_TKN_UUID) { - memcpy(guid, &uuid_tkn->uuid, 16); + guid_copy(guid, (guid_t *)&uuid_tkn->uuid); return 0; } @@ -2151,7 +2151,7 @@ static int skl_tplg_fill_pin(struct device *dev, break; case SKL_TKN_UUID: - ret = skl_tplg_get_uuid(dev, m_pin[pin_index].id.mod_uuid.b, + ret = skl_tplg_get_uuid(dev, &m_pin[pin_index].id.mod_uuid, (struct snd_soc_tplg_vendor_uuid_elem *)tkn_elem); if (ret < 0) return ret; @@ -2666,7 +2666,7 @@ static int skl_tplg_get_tokens(struct device *dev, case SND_SOC_TPLG_TUPLE_TYPE_UUID: if (is_module_guid) { - ret = skl_tplg_get_uuid(dev, mconfig->guid, + ret = skl_tplg_get_uuid(dev, (guid_t *)mconfig->guid, array->uuid); is_module_guid = false; } else { @@ -3484,7 +3484,7 @@ static int skl_tplg_get_manifest_uuid(struct device *dev, if (uuid_tkn->token == SKL_TKN_UUID) { mod = skl->modules[ref_count]; - memcpy(&mod->uuid, &uuid_tkn->uuid, sizeof(uuid_tkn->uuid)); + guid_copy(&mod->uuid, (guid_t *)&uuid_tkn->uuid); ref_count++; } else { dev_err(dev, "Not an UUID token tkn %d\n", uuid_tkn->token); diff --git a/sound/soc/intel/skylake/skl-topology.h b/sound/soc/intel/skylake/skl-topology.h index 82282cac9751..9311e248b6f9 100644 --- a/sound/soc/intel/skylake/skl-topology.h +++ b/sound/soc/intel/skylake/skl-topology.h @@ -224,7 +224,7 @@ struct skl_mod_inst_map { struct skl_uuid_inst_map { u16 inst_id; u16 reserved; - uuid_le mod_uuid; + guid_t mod_uuid; } __packed; struct skl_kpb_params { @@ -236,7 +236,7 @@ struct skl_kpb_params { }; struct skl_module_inst_id { - uuid_le mod_uuid; + guid_t mod_uuid; int module_id; u32 instance_id; int pvt_id; @@ -369,7 +369,7 @@ struct skl_module_res { }; struct skl_module { - uuid_le uuid; + guid_t uuid; u8 loadable; u8 input_pin_type; u8 output_pin_type; -- 2.18.0

3 4

[alsa-devel] [PATCH 0/6] ASoC: rt5651: Various fixes and quirks
by Hans de Goede 24 Dec '18

24 Dec '18

Hi All, Here is my last (big) round of (Intel) rt5651 support updates, with these patches combined with the updated, matching UCM profiles from here: https://github.com/jwrdegoede/alsa-lib/commits/master All 7 different devices I have work 100% OOTB, without requiring any manual config or mixer setup. After this there should be no more big changes. I will submit the matching alsa-lib UCM profile changes upstream once this set is in -next (and thus I can be sure the long-names will not change due to review). Note that unfortunately my previous round of cleanup patches removed 1 input mapping (of the 3 mappings in total it removed) which is actually necessary. So this series re-introduces that 1 mapping. I did not notice this before because UCM input profile switching does not work reliably for some reason, something which I still need to investigate. This time I manually veryfied that the correct / expected mixer settings where used while testing. Regards, Hans

4 23

[alsa-devel] [PATCH v2 01/13] conf/ucm: bytcr-rt5645: Use the generic bytcr/PlatformEnableSeq.conf
by Hans de Goede 28 Nov '18

28 Nov '18

Use the generic Intel SSP bytcr/PlatformEnableSeq.conf file, it is identical to all the cset statements this commit removes. Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- src/conf/ucm/chtrt5645/HiFi.conf | 116 +------------------------------ 1 file changed, 1 insertion(+), 115 deletions(-) diff --git a/src/conf/ucm/chtrt5645/HiFi.conf b/src/conf/ucm/chtrt5645/HiFi.conf index e81866cf..d993f6ae 100644 --- a/src/conf/ucm/chtrt5645/HiFi.conf +++ b/src/conf/ucm/chtrt5645/HiFi.conf @@ -11,121 +11,7 @@ SectionVerb { EnableSequence [ cdev "hw:chtrt5645" - # media mixer settings - # compress - cset "name='media0_in Gain 0 Switch' on" - cset "name='media0_in Gain 0 Volume' 0" - - # normal - cset "name='media1_in Gain 0 Switch' on" - cset "name='media1_in Gain 0 Volume' 0" - # swm loopback - cset "name='media2_in Gain 0 Switch' off" - cset "name='media2_in Gain 0 Volume' 0%" - # deep buffer - cset "name='media3_in Gain 0 Switch' on" - cset "name='media3_in Gain 0 Volume' 0" - - cset "name='media0_out mix 0 media0_in Switch' on" - cset "name='media0_out mix 0 media1_in Switch' on" - cset "name='media0_out mix 0 media2_in Switch' off" - cset "name='media0_out mix 0 media3_in Switch' on" - - cset "name='media1_out mix 0 media0_in Switch' off" - cset "name='media1_out mix 0 media1_in Switch' off" - cset "name='media1_out mix 0 media2_in Switch' off" - cset "name='media1_out mix 0 media3_in Switch' off" - - cset "name='pcm0_in Gain 0 Switch' on" - cset "name='pcm0_in Gain 0 Volume' 0" - - cset "name='pcm1_in Gain 0 Switch' off" - cset "name='pcm1_in Gain 0 Volume' 0%" - - # codec0_out settings (used if ssp2 is connected to aif1) - cset "name='codec_out0 mix 0 codec_in0 Switch' off" - cset "name='codec_out0 mix 0 codec_in1 Switch' off" - cset "name='codec_out0 mix 0 media_loop1_in Switch' off" - cset "name='codec_out0 mix 0 media_loop2_in Switch' off" - cset "name='codec_out0 mix 0 pcm0_in Switch' on" - cset "name='codec_out0 mix 0 pcm1_in Switch' off" - cset "name='codec_out0 mix 0 sprot_loop_in Switch' off" - cset "name='codec_out0 Gain 0 Switch' on" - cset "name='codec_out0 Gain 0 Volume' 0" - - # modem_out settings (used if ssp0 is connected to aif2) - cset "name='modem_out mix 0 codec_in0 Switch' off" - cset "name='modem_out mix 0 codec_in1 Switch' off" - cset "name='modem_out mix 0 media_loop1_in Switch' off" - cset "name='modem_out mix 0 media_loop2_in Switch' off" - cset "name='modem_out mix 0 pcm0_in Switch' on" - cset "name='modem_out mix 0 pcm1_in Switch' off" - cset "name='modem_out mix 0 sprot_loop_in Switch' off" - cset "name='modem_out Gain 0 Switch' on" - cset "name='modem_out Gain 0 Volume' 0" - - # input settings - # pcm1_out settings - - # input used when SSP2 is connected - cset "name='codec_in0 Gain 0 Switch' on" - cset "name='codec_in0 Gain 0 Volume' 0" - - # input used when SSP0 is connected - cset "name='modem_in Gain 0 Switch' on" - cset "name='modem_in Gain 0 Volume' 0" - - cset "name='pcm1_out mix 0 codec_in0 Switch' on" - cset "name='pcm1_out mix 0 modem_in Switch' on" - cset "name='pcm1_out mix 0 codec_in1 Switch' off" - cset "name='pcm1_out mix 0 media_loop1_in Switch' off" - cset "name='pcm1_out mix 0 media_loop2_in Switch' off" - cset "name='pcm1_out mix 0 pcm0_in Switch' off" - cset "name='pcm1_out mix 0 pcm1_in Switch' off" - cset "name='pcm1_out mix 0 sprot_loop_in Switch' off" - - cset "name='pcm1_out Gain 0 Switch' on" - cset "name='pcm1_out Gain 0 Volume' 0" - - # disable codec_out1 - cset "name='codec_out1 mix 0 codec_in0 Switch' off" - cset "name='codec_out1 mix 0 codec_in1 Switch' off" - cset "name='codec_out1 mix 0 media_loop1_in Switch' off" - cset "name='codec_out1 mix 0 media_loop2_in Switch' off" - cset "name='codec_out1 mix 0 pcm0_in Switch' off" - cset "name='codec_out1 mix 0 pcm1_in Switch' off" - cset "name='codec_out1 mix 0 sprot_loop_in Switch' off" - cset "name='codec_out1 Gain 0 Switch' off" - cset "name='codec_out1 Gain 0 Volume' 0%" - - # disable codec_in1 - cset "name='codec_in1 Gain 0 Switch' off" - cset "name='codec_in1 Gain 0 Volume' 0%" - - # disable all loops - cset "name='media_loop1_out mix 0 codec_in0 Switch' off" - cset "name='media_loop1_out mix 0 codec_in1 Switch' off" - cset "name='media_loop1_out mix 0 media_loop1_in Switch' off" - cset "name='media_loop1_out mix 0 media_loop2_in Switch' off" - cset "name='media_loop1_out mix 0 pcm0_in Switch' off" - cset "name='media_loop1_out mix 0 pcm1_in Switch' off" - cset "name='media_loop1_out mix 0 sprot_loop_in Switch' off" - - cset "name='media_loop2_out mix 0 codec_in0 Switch' off" - cset "name='media_loop2_out mix 0 codec_in1 Switch' off" - cset "name='media_loop2_out mix 0 media_loop1_in Switch' off" - cset "name='media_loop2_out mix 0 media_loop2_in Switch' off" - cset "name='media_loop2_out mix 0 pcm0_in Switch' off" - cset "name='media_loop2_out mix 0 pcm1_in Switch' off" - cset "name='media_loop2_out mix 0 sprot_loop_in Switch' off" - - cset "name='sprot_loop_out mix 0 codec_in0 Switch' off" - cset "name='sprot_loop_out mix 0 codec_in1 Switch' off" - cset "name='sprot_loop_out mix 0 media_loop1_in Switch' off" - cset "name='sprot_loop_out mix 0 media_loop2_in Switch' off" - cset "name='sprot_loop_out mix 0 pcm0_in Switch' off" - cset "name='sprot_loop_out mix 0 pcm1_in Switch' off" - cset "name='sprot_loop_out mix 0 sprot_loop_in Switch' off" + <bytcr/PlatformEnableSeq.conf> # Output Configuration cset "name='DAC1 L Mux' IF1 DAC" -- 2.18.0

6 30

Re: [alsa-devel] CS8409 Macbook Pro 2016 2017
by Takashi Iwai 26 Nov '18

26 Nov '18

Please don't drop Cc to ML. Also avoid top-posting. On Sat, 04 Aug 2018 19:02:53 +0200, David Ulricht wrote: > > How can I do that ? > I tried verifying if /proc/asound/card0/codec#0 changes when i put > handphone jack in and out with "diff ver1 ver2" and it is exactly the same. Just do for each bit as you tried for GPIO output. In this case, the direction bit should be different (set 0), and you need to read. > > One strange thing I note is hda-jack-retask.fw contains: > [pincfg] > 0x24 0x90100080 > 0x25 0x90100082 > I have 0x90100080 for 0x24 but in /proc/asound/card0/codec#0 : > Node 0x24 [Pin Complex] wcaps 0x400101: Stereo > Pincap 0x00000010: OUT > Pin Default 0x90100110: [Fixed] Speaker at Int N/A > Conn = Unknown, Color = Unknown > DefAssociation = 0x1, Sequence = 0x0 > Misc = NO_PRESENCE > Pin-ctls: 0x40: OUT > Connection: 1 > 0x02 > > Shouldn't "Pin Default 0x90100110" be 0x90100080 after applying the patch ? No, the codec config value itself won't change, the driver uses the given value only internally. Takashi > I can see that Applying patch firmware 'hda-jack-retask.fw' is before > hdaudioC0D0: autoconfig for Generic: line_outs=2 (0x24/0x25/0x0/0x0/0x0) > type:speaker > in dmesg and this worries me, maybe the pins are overriden by generic > cirrus logic ? > > > On Sat, Aug 4, 2018 at 7:26 PM, Takashi Iwai <tiwai(a)suse.de> wrote: > > > On Sat, 04 Aug 2018 17:44:59 +0200, > > David Ulricht wrote: > > > > > > I used the following script running as root to verify the 8 GPIOs while > > > playing long youtube video, > > > I have running pulseaudio meanwhile and not restarting it, i think its > > okay > > > like that people on the ubuntu forums say that after using > > > hda-verb and setting a gpio active immediately sound appears, so i guess > > > there is no need to restart pulseaudio. > > > I have done the same test with headphones in. > > > No sound in both scenarios, no input no output detected (i'm watching > > > pavucontrol for input detection). > > > > This codec is fairly unique and doesn't provide the standard jack > > detection on each pin. Maybe it's via either GPIO or any other > > method. You can try to read GPIO pins (set as input) to see whether > > any of them corresponds to the jack detection, for example. > > > > > > Takashi > > > > > > > > #!/usr/bin/env python3 > > > import os,time > > > for x in range(0,256): > > > mhex=("0x%0.2X" % x) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK "+mhex) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION "+mhex) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA "+mhex) > > > time.sleep(3) > > > > > > Meanwhile script is running I'm watching /proc/asound/card0/codec#0 and > > > IO[0-7] changes its configuration, > > > in comparison Joel Krahemann in his scripts is changing the hex right > > after > > > /dev/snd/hwC0D0 (0x01) e.g. i dont think he is modifiying the GPIOs > > > correctly. > > > > > > I found the following post: > > > https://forum.manjaro.org/t/sound-not-working-on-a-2017- > > imac-27-5k-retina/43638 > > > According to https://bugzilla.kernel.org/show_bug.cgi?id=195671 iMac27 > > has > > > a similar soundcard. > > > How can i setup with command line or any other utility: > > > """select “off” in the top menu that propose to setup the Digital > > > Surround""" > > > this is some setting in xfce4-mixer package which is not available for > > > ubuntu since 2 LTS versions behind. I tried current Manjaro and couldn't > > > find this setting in audio mixer of xfce4 either. > > > > > > On Sat, Aug 4, 2018 at 9:48 AM, Takashi Iwai <tiwai(a)suse.de> wrote: > > > > > > > On Sat, 04 Aug 2018 04:07:43 +0200, > > > > David Ulricht wrote: > > > > > > > > > > Hello, > > > > > > > > > > Macbook pro models containing CS8409 for sure are: > > > > > MBP131 MBP141.I own MBP 14,1 e.g. 2017 model. > > > > > > > > > > I'm attaching working sound configuration from Windows 10 registry > > (note > > > > > that the cs420x might need to be ignored or might be important i > > don't > > > > > really know). I believe what is really used is in the > > PinConfigOverride > > > > > section. > > > > > > > > Comparing between BIOS default (init_pin_cfg in alsa-info.sh output) > > > > and your override (user_pin_cfg), there aren't so many changes. > > > > All changes are pretty minor, and I guess it won't influence on the > > > > driver behavior. > > > > > > > > > Interesting thing to note is that sound in MacOS is much louder than > > > > > Bootcamp Windows, would be nice to hear how loud is on linux. > > > > > > > > This is possibly with some vendor-specific GPIO or COEF verbs. > > > > Or it's some direct I2C control. The INI file mentions it. > > > > And that's above HD-audio driver's responsibility. > > > > > > > > > I did convert PinConfigOverride HEX strings to [pincfg] format in the > > > > > attached hda-jack-retask.fw thanks to Takashi's guidance. > > > > > > > > > > I'm attaching also alsamixer ASCII. Only PCM, no Master ? > > > > > > > > It's because the codec chip has no output amplifier at all. > > > > So there can be neither output volume nor mute control on this chip. > > > > > > > > > What I have tried is execute: > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x@@ > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION 0x@@ > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x@@ > > > > > putting @@ from 0x00 to 0x50 > > > > > > > > There are eight GPIOs, so you'd need to test each bit, i.e. 0x01, > > > > 0x02, 0x04, 0x08, ... 0x80. > > > > > > > > And how is the current situation? You can't play *and* record > > > > anything from any inputs / outputs? > > > > > > > > > > > > Takashi > > > > > > > [2 <text/html; UTF-8 (quoted-printable)>] > > > > > > [2 <text/html; UTF-8 (quoted-printable)>] >

3 12

Re: [alsa-devel] [linux-sunxi] [BUG] On Allwinner A20 Board Cubietruck distorted SPDIF opical output
by Markus Mitsch 27 Oct '18

27 Oct '18

hi. i posted my answer wrong so here is my finding: i made the output work by disabling the sigma delta modulation. after compiling the kernel i can output through spdif with any rate. greetings markus 2018-05-26 18:38 GMT+02:00 Markus Mitsch <markusmitsch86(a)googlemail.com>: > 2018-05-26 16:57 GMT+02:00 Markus Mitsch <markusmitsch86(a)googlemail.com>: >> 2018-05-23 17:12 GMT+02:00 Code Kipper <codekipper(a)gmail.com>: >>> Hi All, >>> I can see that the problem was introduced somewhere here >>> >>> DOESN'T WORK >>> ffc3eb6f3a83 Merge tag 'sunxi-clk-for-4.15' of >>> https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux into >>> clk-next >>> ae74ac082886 Merge tag 'clk-v4.15-exynos-pm' of >>> git://git.kernel.org/pub/scm/linux/kernel/git/snawrocki/clk into >>> clk-next >>> faa865f18cb7 Merge tag 'clk-v4.15-samsung' of >>> git://git.kernel.org/pub/scm/linux/kernel/git/snawrocki/clk into >>> clk-next >>> f09a6b86fdae Merge tag 'clk-renesas-for-v4.15-tag1' of >>> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers >>> into clk-next >>> 4328a2186e51 clk: sunxi-ng: sun4i: Export video PLLs >>> 553c7d5ba2fe clk: sunxi-ng: Add A83T display clocks >>> 7679eb20353d clk: samsung: Add a separate driver for Exynos4412 ISP clocks >>> 8ca8ac102484 clk: samsung: Add dt bindings for Exynos4412 ISP clock controller >>> 75920aac275a clk: samsung: Instantiate Exynos4412 ISP clocks only when available >>> 24ea78a09f89 clk: sunxi-ng: sun8i: a23: Use sigma-delta modulation for audio PLL >>> ee6501d69217 clk: sunxi-ng: sun6i: Use sigma-delta modulation for audio PLL >>> 042f7f8f9715 clk: sunxi-ng: sun5i: Use sigma-delta modulation for audio PLL >>> de3448519194 clk: sunxi-ng: sun4i: Use sigma-delta modulation for audio PLL >>> a5e3e2b2ef85 clk: sunxi-ng: sun8i: h3: Use sigma-delta modulation for audio PLL >>> 392ba5fafcdf clk: sunxi-ng: nm: Add support for sigma-delta modulation >>> 05d2eaac96d4 clk: sunxi-ng: Add sigma-delta modulation support >>> 4cdbc40d64d4 clk: sunxi-ng: nm: Check if requested rate is supported >>> by fractional clock >>> d51fe3ba9773 clk: sunxi-ng: sun5i: Fix bit offset of audio PLL post-divider >>> 4e8975cbb516 clk: samsung: exynos5433: mark PM functions as __maybe_unused >>> a4f21e9ceb5c clk: samsung: Remove obsolete clkdev alias support >>> 45d882daf88a clk: samsung: Add explicit MPLL, EPLL clkdev aliases in >>> S3C2443 driver >>> cd05417f728b clk: samsung: Rework clkdev alias handling in S3C2443 driver >>> efea8d377184 clk: samsung: Rework clkdev alias handling in Exynos5440 driver >>> 36ba48240b19 clk: samsung: Drop useless alias in Exynos5420 clk driver >>> 29964890f31c clk: samsung: Remove clkdev alias support in Exynos5250 clk driver >>> 6de08891c896 clk: samsung: Remove double assignment of CLK_ARM_CLK in >>> Exynos4 driver >>> 58f4a5ff3a62 clk: samsung: Remove clkdev alias support in Exynos4 clk driver >>> c9194fb623b0 clk: samsung: Remove support for obsolete Exynos4212 CPU clock >>> d5cd103b06f9 clk: samsung: Remove support for Exynos4212 SoCs in >>> Exynos CLKOUT driver >>> 7c4f63ec94a1 clk: sunxi-ng: a83t: Fix invalid csi-mclk mux offset >>> WORKS >>> 0a4e632b6f9d Merge branch 'clk-fixes' into clk-next >>> >>> BR, >>> CK >>> >>> >>> On 22 May 2018 at 21:27, Code Kipper <codekipper(a)gmail.com> wrote: >>>> Hi Markus, >>>> I've been able to reproduce this on my A31 board with linux-next(plays >>>> at 44100 but not at 96K)so it is an issue. I also tested the same code >>>> on my A64 and it worked fine, The blocks are very similar so it maybe >>>> a clocking issue, I'll look into this. >>>> BR, >>>> CK >>>> >>>> On 21 May 2018 at 20:17, Markus Mitsch <markusmitsch86(a)googlemail.com> wrote: >>>>> 2018-05-21 15:17 GMT+02:00 Maxime Ripard <maxime.ripard(a)bootlin.com>: >>>>>> On Mon, May 21, 2018 at 02:43:55PM +0200, Markus Mitsch wrote: >>>>>>> 2018-05-21 11:43 GMT+02:00 Markus Mitsch <markusmitsch86(a)googlemail.com>: >>>>>>> >>> Hello, >>>>>>> >>> >>>>>>> >>> i have a new problem. if i want to output sound from optical i get >>>>>>> >>> distorted sound. At 44.1 khz its like an old vinly, but at 48 khz and >>>>>>> >>> higher it is very bad. thanks in advance for your time. >>>>>>> > >>>>>>> >> Hi Markus, >>>>>>> >> I haven't tested it for a while but when I did it worked as high as >>>>>>> >> 96K with no issues. Does it work ok with the original cubietruck >>>>>>> >> software?, >>>>>>> >> CK >>>>>>> > >>>>>>> > Hello, >>>>>>> > i am using arch linux with mainline kernel 4.16.8. parhaps i can try >>>>>>> > today with official image. >>>>>>> > mfg >>>>>>> >>>>>>> Hi. >>>>>>> So, with debian image from 2014 with 3.4.79 kernel the sound is clear >>>>>>> up to 96 khz. >>>>>> >>>>>> You said that it is a new problem, when was it introduced? Could you >>>>>> bisect the issue? >>>>>> >>>>>> Maxime >>>>> >>>>> Hello. >>>>> I dont know since when this problem appears. When saying "new" i >>>>> refered to my older post. I tried to look into the dts file and the >>>>> code >>>>> but i am afraid this is a bit too high for me. I can say that the >>>>> analog output works, even at high sampling rates. >>>>> And I have read something about a clock source could be the problem. >>>>> I'm sorry I can't tell you any more. >>>>> >>>>> mfg >>>>> Markus >> >> Hello, >> i tried undoing part of the commit >> de3448519194 clk: sunxi-ng: sun4i: Use sigma-delta modulation for audio PLL >> by setting the value for the divider from 1 to 4 again on both places. >> with no success. >> >> markus > > i now had a little success. the output works!! > i disabled the sigma-delta support by making > ccu_sdm_helper_enable in drivers/clk/sunxi-ng/ccu_sdm.c return imediately. > > markus

2 2

Re: [alsa-devel] [PATCH 1/3] MIPS: jz4780: Allow access to jz4740-i2s
by Paul Burton 17 Oct '18

17 Oct '18

Hi Matthieu, On Wed, Jun 06, 2018 at 09:38:08PM +0200, Mathieu Malaterre wrote: > diff --git a/sound/soc/jz4740/Kconfig b/sound/soc/jz4740/Kconfig > index 1a354a6b6e87..35d82d96e781 100644 > --- a/sound/soc/jz4740/Kconfig > +++ b/sound/soc/jz4740/Kconfig > @@ -1,20 +1,20 @@ > config SND_JZ4740_SOC > - tristate "SoC Audio for Ingenic JZ4740 SoC" > - depends on MACH_JZ4740 || COMPILE_TEST > + tristate "SoC Audio for Ingenic JZ4740/JZ4780 SoC" > + depends on MACH_JZ4740 || MACH_JZ4780 || COMPILE_TEST Perhaps this could be MACH_INGENIC, or even just MIPS? Thanks, Paul

2 4

[alsa-devel] [ANNOUNCE] 2018 Linux Audio miniconference
by Mark Brown 16 Oct '18

16 Oct '18

Hi, As in previous years we're trying to organize an audio miniconference so we can get together and talk through issues, especially design decisons, face to face. This year's event will be held on Sunday October 21st in Edinburgh, the day before ELC Europe starts there. We're still finalizing the venue (we expect to be able to confirm next week) but it'll be outside the ELC venue so there will be no need to purchase an ELC ticket to attend. As with previous years let's pull together an agenda through a mailing list discussion - if people could reply to this mail with any topics they'd like to discuss we can take it from there. Of course if we can sort things out more quickly via the mailing list that's even better! If you're planning to attend please fill out the form here: https://docs.google.com/spreadsheets/d/11p2pSNxS7sJysg1JwErWi0T2Dq7XKRtAGng… Thanks, Mark

6 10

[alsa-devel] [PATCH v2 00/12] Sound Open Firmware Core
by Liam Girdwood 20 Sep '18

20 Sep '18

Sound Open Firmware (SOF) is a host and DSP architecture agnostic audio DSP firmware. SOF is not tied to any specific host architecture or any specific physical IO communication type (it will work with on SoC DSPs, or DSP connected via SPI/I2C). SOF is also not coupled to any particular DSP architecture and has abstraction similar to Linux to allow porting to other DSP architectures. https://www.sofproject.org/ This patch series introduces the SOF core, later series will add host platform support for SOF. The SOF core manages all the core DSP services and ALSA/ASoC IO. The core is responsible for loading firmware, parsing topology, exposing PCMs and kcontrols, providing debug and trace mechanisms and performing IPC between host and DSP. The SOF core also has logic to allow reuse of existing machine drivers for other platforms/machines without any code modification. i.e. DAI links can be modified at runtime to bind with SOF and SOF topologies instead of existing hard coded DAI links and topology. Changes since V1 :- o Added PM source. o Updated header comments to C++ style o Used generic private data in snd_soc_pcm_runtime o remove sof_get_pages() o Added comments for compressed SG pages. o Check return values for runtime_pm calls. Liam Girdwood (12): ASoC: SOF: Add Sound Open Firmware driver core ASoC: SOF: Add Sound Open Firmware KControl support ASoC: SOF: Add driver debug support. ASoC: SOF: Add support for IPC IO between DSP and Host ASoC: SOF: Add PCM operations support ASoC: SOF: Add support for loading topologies ASoC: SOF: Add DSP firmware trace event support ASoC: SOF: Add DSP HW abstraction operations ASoC: SOF: Add firmware loader support ASoC: SOF: Add PM support ASoC: SOF: Add userspace ABI support ASoC: SOF: Add Build support for SOF core include/sound/soc.h | 3 + include/sound/sof.h | 82 ++ include/uapi/sound/sof-abi.h | 29 + include/uapi/sound/sof-eq.h | 102 ++ include/uapi/sound/sof-fw.h | 67 + include/uapi/sound/sof-ipc.h | 938 ++++++++++++ include/uapi/sound/sof-tone.h | 27 + include/uapi/sound/sof-topology.h | 94 ++ sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/sof/Kconfig | 36 + sound/soc/sof/Makefile | 6 + sound/soc/sof/control.c | 270 ++++ sound/soc/sof/core.c | 381 +++++ sound/soc/sof/debug.c | 157 ++ sound/soc/sof/ipc.c | 788 ++++++++++ sound/soc/sof/loader.c | 287 ++++ sound/soc/sof/ops.c | 210 +++ sound/soc/sof/ops.h | 298 ++++ sound/soc/sof/pcm.c | 733 ++++++++++ sound/soc/sof/pm.c | 345 +++++ sound/soc/sof/sof-priv.h | 519 +++++++ sound/soc/sof/topology.c | 2222 +++++++++++++++++++++++++++++ sound/soc/sof/trace.c | 293 ++++ 24 files changed, 7889 insertions(+) create mode 100644 include/sound/sof.h create mode 100644 include/uapi/sound/sof-abi.h create mode 100644 include/uapi/sound/sof-eq.h create mode 100644 include/uapi/sound/sof-fw.h create mode 100644 include/uapi/sound/sof-ipc.h create mode 100644 include/uapi/sound/sof-tone.h create mode 100644 include/uapi/sound/sof-topology.h create mode 100644 sound/soc/sof/Kconfig create mode 100644 sound/soc/sof/Makefile create mode 100644 sound/soc/sof/control.c create mode 100644 sound/soc/sof/core.c create mode 100644 sound/soc/sof/debug.c create mode 100644 sound/soc/sof/ipc.c create mode 100644 sound/soc/sof/loader.c create mode 100644 sound/soc/sof/ops.c create mode 100644 sound/soc/sof/ops.h create mode 100644 sound/soc/sof/pcm.c create mode 100644 sound/soc/sof/pm.c create mode 100644 sound/soc/sof/sof-priv.h create mode 100644 sound/soc/sof/topology.c create mode 100644 sound/soc/sof/trace.c -- 2.17.1

2 22

[alsa-devel] [RFC - AAF PCM plugin 0/5] Introduce AVTP Audio Format (AAF) plugin
by Andre Guedes 12 Sep '18

12 Sep '18

Hi all, This patchset introduces the AAF plugin to the alsa-plugins project which enables TSN audio applications on Linux. For those not familiarized with TSN, it stands for Time-Sensitive Networking, and it's a set of IEEE technologies (enhancements to IEEE 802.1Q and Ethernet protocols) that provide precise time synchronization, bounded latency and application interoperability to bridged networks. Those technologies enable time-sensitive applications such as audio, video and control loops to run on top of bridged networks, co-existing with regular applications. TSN technologies are a super set of Audio Video Bridging (AVB) technologies also developed by IEEE. AVTP is the protocol defined to transport data in a TSN system, and AAF is one of the formats defined by AVTP to encapsulate audio data. AAF is specified in Chapter 7 from the AVTP spec [1]. This work is part of the effort to enable TSN technologies on upstream Linux ecosystem. All building-blocks required to enable TSN audio applications have been already developed and pushed to upstream projects. Time synchronization features are provided by linuxptp project [2], bounded latency features are provided by Linux Traffic Control subsystem since kernel version 4.15 [3], and AVTP packetization is provided by libavtp [4]. What is currently missing in the ecosystem to enable TSN audio applications is a piece of software that plumbs it all together and interfaces with Linux Audio system properly. That's the point of the AAF plugin introduced here. The AAF plugin is a PCM plugin that uses AVTP protocol to transmit/receive audio data through a TSN capable network. When operating in playback mode, the plugin reads PCM samples from the audio buffer, encapsulates into AVTP packets and transmits to the network, mimicking a typical AVTP Talker. When operating in capture mode, the plugin receives AVTP packets from the network, retrieves the PCM samples, and present them to alsa-lib layer at the presentation time, mimicking a typical AVTP Listener. Details about the plugin implementation are provided in the patches description, and information on how to configure and run the AAF plugin is provided in doc/aaf.txt file. Best regards, Andre [1] 1722-2016 - IEEE Standard for a Transport Protocol for Time-Sensitive Applications in Bridged Local Area Networks [2] http://linuxptp.sourceforge.net [3] https://patchwork.ozlabs.org/cover/826678/ [4] https://github.com/AVnu/libavtp Andre Guedes (5): aaf: Introduce plugin skeleton aaf: Load configuration parameters aaf: Implement Playback mode support aaf: Prepare for Capture mode support aaf: Implement Capture mode support Makefile.am | 3 + aaf/Makefile.am | 9 + aaf/pcm_aaf.c | 1172 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 9 + doc/aaf.txt | 110 ++++++ 5 files changed, 1303 insertions(+) create mode 100644 aaf/Makefile.am create mode 100644 aaf/pcm_aaf.c create mode 100644 doc/aaf.txt -- 2.14.4

4 26

[alsa-devel] [PATCH - DMA engine v2 1/1] ALSA: SOC: DMA: increment buffer pointer atomically
by twischer＠de.adit-jv.com 11 Sep '18

11 Sep '18

From: Andreas Pape <apape(a)de.adit-jv.com> Setting pointer and afterwards check for wrap around leads to the possibility of returning the inconsistent pointer position. This patch increments buffer pointer atomically to avoid this issue. Signed-off-by: Andreas Pape <apape(a)de.adit-jv.com> Since commit: b7ae6f3 dmaengine implementation has been moved from ASoC to ALSA core. So change goes to sound/soc/soc-dmaengine-pcm.c, apply to sound/core/pcm_dmaengine.c now cherry picked from ADIT v3.14 e2f803f("ALSA: SOC: DMA: increment buffer pointer atomically") Signed-off-by: Veeraiyan Chidambaram <veeraiyan.chidambaram(a)in.bosch.com> (cherry picked from ADIT v4.1 commit 9e7eff10a38157db75f12e032fc378d3104a2812) Signed-off-by: Takashi Sakamoto <takashi.sakamoto(a)miraclelinux.com> (cherry picked from ADIT v4.9 commit 66c00aa1e7cd3b077fc2e5a45a4594b86246cf78) Signed-off-by: Jiada Wang <jiada_wang(a)mentor.com> Signed-off-by: Timo Wischer <twischer(a)de.adit-jv.com> --- v1 can be found in http://mailman.alsa-project.org/pipermail/alsa-devel/2016-November/115277.h… diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c index 8eb58c7..0a7ed85 100644 --- a/sound/core/pcm_dmaengine.c +++ b/sound/core/pcm_dmaengine.c @@ -139,12 +139,14 @@ EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_set_config_from_dai_data); static void dmaengine_pcm_dma_complete(void *arg) { + unsigned int new_pos; struct snd_pcm_substream *substream = arg; struct dmaengine_pcm_runtime_data *prtd = substream_to_prtd(substream); - prtd->pos += snd_pcm_lib_period_bytes(substream); - if (prtd->pos >= snd_pcm_lib_buffer_bytes(substream)) - prtd->pos = 0; + new_pos = READ_ONCE(prtd->pos) + snd_pcm_lib_period_bytes(substream); + if (new_pos >= snd_pcm_lib_buffer_bytes(substream)) + new_pos = 0; + WRITE_ONCE(prtd->pos, new_pos); snd_pcm_period_elapsed(substream); } @@ -235,7 +237,7 @@ EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_trigger); snd_pcm_uframes_t snd_dmaengine_pcm_pointer_no_residue(struct snd_pcm_substream *substream) { struct dmaengine_pcm_runtime_data *prtd = substream_to_prtd(substream); - return bytes_to_frames(substream->runtime, prtd->pos); + return bytes_to_frames(substream->runtime, READ_ONCE(prtd->pos)); } EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_pointer_no_residue); -- 2.7.4

2 1