April 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/1] Handling of serializers
by Vishal Thanki 17 May '18

17 May '18

On a custom AM33xx based platform, we use 4 channels for audio output (2 * Left/Right) by making use of two TX serializers. The audio input path only uses 2 channels, hence one RX serializer. If the recording is started before the playback, the playback cannot make use of all 4 channels because of the imposed max number of channels by recording. And if playback is started before recording, the hw_params set during recording stream would disable an active TX serializer which causes audio distortion. I have tried to fix this unwanted behavior in following patch. Please comment if this should be done differently. Vishal Thanki (1): ASoC: davinci-mcasp: Only disable inactive serializer sound/soc/davinci/davinci-mcasp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.3

3 6

[alsa-devel] [PATCH 43/45] sound/soc/zte: remove duplicate includes
by Pravin Shedge 17 May '18

17 May '18

These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge <pravin.shedge4linux(a)gmail.com> --- sound/soc/zte/zx-i2s.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/zte/zx-i2s.c b/sound/soc/zte/zx-i2s.c index 9a05659..93428e1 100644 --- a/sound/soc/zte/zx-i2s.c +++ b/sound/soc/zte/zx-i2s.c @@ -20,9 +20,6 @@ #include <sound/core.h> #include <sound/dmaengine_pcm.h> #include <sound/initval.h> -#include <sound/pcm.h> -#include <sound/pcm_params.h> -#include <sound/soc.h> #define ZX_I2S_PROCESS_CTRL 0x04 #define ZX_I2S_TIMING_CTRL 0x08 -- 2.7.4

2 2

[alsa-devel] [PATCH 0/4] ALSA: usb: UAC3 new features.
by Jorge Sanjuan 15 May '18

15 May '18

Now that the UAC3 patch [1] has made it to linux-next I have some extra features to make a UAC3 device fully work in Linux. Including Jack insertion control that I have put on top of this other patch [2] for UAC2. Also adding support for the UAC3 Mixer Unit which is most likely to appear in most headset type devices. UAC3 devices also require to have a Basic Audio Device (BADD) in a separate config for which both Ruslan Bilovol and myself have submited different approaches[3][4] but I don't know what the final merge will be. Once there is official support for BADD, we'll need to test it with an actual UAC3 device to confirm it all wokrs. All this features are tested with an actual UAC3 device that is still in development. For this patch series, only the legacy config (#1. UAC1/UAC2) and the UAC3 config have been tested. The BADD config is only tested using and updated verison of [4]. [1]: https://patchwork.kernel.org/patch/10298179/ [2]: https://patchwork.kernel.org/patch/10305847/ [3]: https://patchwork.kernel.org/patch/10340851/ [4]: https://www.spinics.net/lists/alsa-devel/msg71617.html Based on linux-next tag: next-20180420 Jorge Sanjuan (3): ALSA: usb-audio: UAC3. Add support for mixer unit. ALSA: usb-audio: Use Class Specific EP for UAC3 devices. ALSA: usb-audio: UAC3 Add support for connector insertion. Michael Drake (1): ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3. include/linux/usb/audio-v2.h | 7 ++ include/linux/usb/audio-v3.h | 14 ++++ include/uapi/linux/usb/audio.h | 13 ++- sound/usb/mixer.c | 175 ++++++++++++++++++++++++++++++++++++----- sound/usb/stream.c | 19 ++++- 5 files changed, 204 insertions(+), 24 deletions(-) -- 2.11.0

5 39

[alsa-devel] KASAN: null-ptr-deref Write in linear_transfer
by syzbot 13 May '18

13 May '18

Hello, syzkaller hit the following crash on 30a7acd573899fd8b8ac39236eff6468b195ac7d git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. C reproducer is attached syzkaller reproducer is attached. See https://goo.gl/kgGztJ for information about syzkaller reproducers IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+a8f5641f452c7e6abf03(a)syzkaller.appspotmail.com It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. ================================================================== BUG: KASAN: null-ptr-deref in memcpy include/linux/string.h:344 [inline] BUG: KASAN: null-ptr-deref in do_convert sound/core/oss/linear.c:52 [inline] BUG: KASAN: null-ptr-deref in convert sound/core/oss/linear.c:81 [inline] BUG: KASAN: null-ptr-deref in linear_transfer+0x634/0x900 sound/core/oss/linear.c:110 Write of size 2 at addr (null) by task syzkaller360172/7860 CPU: 0 PID: 7860 Comm: syzkaller360172 Not tainted 4.15.0-rc6+ #155 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x194/0x257 lib/dump_stack.c:53 kasan_report_error mm/kasan/report.c:349 [inline] kasan_report+0x13b/0x340 mm/kasan/report.c:409 check_memory_region_inline mm/kasan/kasan.c:260 [inline] check_memory_region+0x137/0x190 mm/kasan/kasan.c:267 memcpy+0x37/0x50 mm/kasan/kasan.c:303 memcpy include/linux/string.h:344 [inline] do_convert sound/core/oss/linear.c:52 [inline] convert sound/core/oss/linear.c:81 [inline] linear_transfer+0x634/0x900 sound/core/oss/linear.c:110 snd_pcm_plug_write_transfer+0x22d/0x420 sound/core/oss/pcm_plugin.c:611 snd_pcm_oss_write2+0x260/0x420 sound/core/oss/pcm_oss.c:1311 snd_pcm_oss_sync1+0x1cc/0x550 sound/core/oss/pcm_oss.c:1530 snd_pcm_oss_sync+0x5b6/0x830 sound/core/oss/pcm_oss.c:1604 snd_pcm_oss_release+0x20b/0x280 sound/core/oss/pcm_oss.c:2431 __fput+0x327/0x7e0 fs/file_table.c:210 ____fput+0x15/0x20 fs/file_table.c:244 task_work_run+0x199/0x270 kernel/task_work.c:113 exit_task_work include/linux/task_work.h:22 [inline] do_exit+0x9bb/0x1ad0 kernel/exit.c:865 do_group_exit+0x149/0x400 kernel/exit.c:968 get_signal+0x73f/0x16c0 kernel/signal.c:2335 do_signal+0x90/0x1eb0 arch/x86/kernel/signal.c:809 exit_to_usermode_loop+0x214/0x310 arch/x86/entry/common.c:158 prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline] syscall_return_slowpath arch/x86/entry/common.c:264 [inline] do_syscall_32_irqs_on arch/x86/entry/common.c:333 [inline] do_fast_syscall_32+0xbfd/0xf9d arch/x86/entry/common.c:389 entry_SYSENTER_compat+0x54/0x63 arch/x86/entry/entry_64_compat.S:129 RIP: 0023:0xf7fcac79 RSP: 002b:00000000f7f8412c EFLAGS: 00000292 ORIG_RAX: 00000000000000f0 RAX: fffffffffffffe00 RBX: 00000000080fd024 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00000000080fd024 RBP: 0000000000000001 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 ================================================================== Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 7860 Comm: syzkaller360172 Tainted: G B 4.15.0-rc6+ #155 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x194/0x257 lib/dump_stack.c:53 panic+0x1e4/0x41c kernel/panic.c:183 kasan_end_report+0x50/0x50 mm/kasan/report.c:176 kasan_report_error mm/kasan/report.c:356 [inline] kasan_report+0x144/0x340 mm/kasan/report.c:409 check_memory_region_inline mm/kasan/kasan.c:260 [inline] check_memory_region+0x137/0x190 mm/kasan/kasan.c:267 memcpy+0x37/0x50 mm/kasan/kasan.c:303 memcpy include/linux/string.h:344 [inline] do_convert sound/core/oss/linear.c:52 [inline] convert sound/core/oss/linear.c:81 [inline] linear_transfer+0x634/0x900 sound/core/oss/linear.c:110 snd_pcm_plug_write_transfer+0x22d/0x420 sound/core/oss/pcm_plugin.c:611 snd_pcm_oss_write2+0x260/0x420 sound/core/oss/pcm_oss.c:1311 snd_pcm_oss_sync1+0x1cc/0x550 sound/core/oss/pcm_oss.c:1530 snd_pcm_oss_sync+0x5b6/0x830 sound/core/oss/pcm_oss.c:1604 snd_pcm_oss_release+0x20b/0x280 sound/core/oss/pcm_oss.c:2431 __fput+0x327/0x7e0 fs/file_table.c:210 ____fput+0x15/0x20 fs/file_table.c:244 task_work_run+0x199/0x270 kernel/task_work.c:113 exit_task_work include/linux/task_work.h:22 [inline] do_exit+0x9bb/0x1ad0 kernel/exit.c:865 do_group_exit+0x149/0x400 kernel/exit.c:968 get_signal+0x73f/0x16c0 kernel/signal.c:2335 do_signal+0x90/0x1eb0 arch/x86/kernel/signal.c:809 exit_to_usermode_loop+0x214/0x310 arch/x86/entry/common.c:158 prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline] syscall_return_slowpath arch/x86/entry/common.c:264 [inline] do_syscall_32_irqs_on arch/x86/entry/common.c:333 [inline] do_fast_syscall_32+0xbfd/0xf9d arch/x86/entry/common.c:389 entry_SYSENTER_compat+0x54/0x63 arch/x86/entry/entry_64_compat.S:129 RIP: 0023:0xf7fcac79 RSP: 002b:00000000f7f8412c EFLAGS: 00000292 ORIG_RAX: 00000000000000f0 RAX: fffffffffffffe00 RBX: 00000000080fd024 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00000000080fd024 RBP: 0000000000000001 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 Dumping ftrace buffer: (ftrace buffer empty) Kernel Offset: disabled Rebooting in 86400 seconds.. --- This bug is generated by a dumb bot. It may contain errors. See https://goo.gl/tpsmEJ for details. Direct all questions to syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. If you forgot to add the Reported-by tag, once the fix for this bug is merged into any tree, please reply to this email with: #syz fix: exact-commit-title If you want to test a patch for this bug, please reply with: #syz test: git://repo/address.git branch and provide the patch inline or as an attachment. To mark this as a duplicate of another syzbot report, please reply with: #syz dup: exact-subject-of-another-report If it's a one-off invalid bug report, please reply with: #syz invalid Note: if the crash happens again, it will cause creation of a new bug report. Note: all commands must start from beginning of the line in the email body.

3 4

[alsa-devel] [PATCH v6 00/13] soundwire: Add stream support
by Vinod Koul 11 May '18

11 May '18

This series adds support in SoundWire subsystem for: - Documentation for stream support - stream management - data port management - DAI ops in cadence and Intel drivers - ASoC API to propagate SDW stream Updates in v6: - Fix return error as pointed by Sanyog - Update stream state enum documentation as pointed by Pierre and few other nits Updated in v5: - Add todo for device-device changes in future and some comment updates based on feedback from Pierre Updates in v4: - Add more comments for sdw_release_master_stream() - Make sure ports are freed upon sdw_stream_remove_slave() - Clarify snd_soc_dai_set_sdw_stream() and setting of NULL upon release. Updates in v3: - Remove stream state transition checks and redefine stream states - Update bansk switch routines - Other nitpicks pointed out by Pierre. Updates in v2: - Make ASoC API inlined - Make stream states as states and not action - Update the direction enum - Fix some typos and comment updates *** SUBJECT HERE *** *** BLURB HERE *** Sanyog Kale (7): Documentation: soundwire: Add more documentation soundwire: Add support for SoundWire stream management soundwire: Add support for port management soundwire: Add Master and Slave port programming soundwire: Add helpers for ports operations soundwire: Add bank switch routine soundwire: Add stream configuration APIs Shreyas NC (2): ASoC: Add SoundWire stream programming interface soundwire: Remove cdns_master_ops Vinod Koul (4): soundwire: cdns: Add port routines soundwire: cdns: Add stream routines soundwire: intel: Add stream initialization soundwire: intel: Add audio DAI ops .../driver-api/soundwire/error_handling.rst | 65 + Documentation/driver-api/soundwire/index.rst | 3 + Documentation/driver-api/soundwire/locking.rst | 106 ++ Documentation/driver-api/soundwire/stream.rst | 372 +++++ drivers/soundwire/Kconfig | 2 +- drivers/soundwire/Makefile | 2 +- drivers/soundwire/bus.c | 43 + drivers/soundwire/bus.h | 72 + drivers/soundwire/cadence_master.c | 451 +++++- drivers/soundwire/cadence_master.h | 151 ++ drivers/soundwire/intel.c | 525 ++++++- drivers/soundwire/intel.h | 4 + drivers/soundwire/intel_init.c | 3 + drivers/soundwire/stream.c | 1479 ++++++++++++++++++++ include/linux/soundwire/sdw.h | 332 ++++- include/linux/soundwire/sdw_intel.h | 14 + include/sound/soc-dai.h | 23 + 17 files changed, 3633 insertions(+), 14 deletions(-) create mode 100644 Documentation/driver-api/soundwire/error_handling.rst create mode 100644 Documentation/driver-api/soundwire/locking.rst create mode 100644 Documentation/driver-api/soundwire/stream.rst create mode 100644 drivers/soundwire/stream.c -- 2.7.4

6 19

[alsa-devel] [PATCH 1/4] ASoC: compress: Only assign compr->ops->copy once
by Charles Keepax 11 May '18

11 May '18

There are only one set of ops on the compressed stream so no need to reassign the copy callback repeatedly, stop after copy is seen to be necessary. Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- sound/soc/soc-compress.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index ba56f87f96d4c..62875c6a93a14 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -973,6 +973,7 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num) continue; compr->ops->copy = soc_compr_copy; + break; } -- 2.11.0

4 13

[alsa-devel] [PATCH 1/2] ASoC: rt5645: Add platform-data for Lenovo Ideapad Mixx 310
by Hans de Goede 11 May '18

11 May '18

The Lenovo Ideapad Mixx 310 has a differential internal analog mic, add platform-data for this. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/soc/codecs/rt5645.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index bc8d829ce45b..70f351c61d41 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3652,6 +3652,11 @@ static const struct rt5645_platform_data asus_t100ha_platform_data = { .inv_jd1_1 = true, }; +static const struct rt5645_platform_data lenovo_ideapad_miix_310_pdata = { + .jd_mode = 3, + .in2_diff = true, +}; + static const struct rt5645_platform_data jd_mode3_platform_data = { .jd_mode = 3, }; @@ -3735,6 +3740,15 @@ static const struct dmi_system_id dmi_platform_data[] = { }, .driver_data = (void *)&jd_mode3_platform_data, }, + { + .ident = "Lenovo Ideapad Miix 310", + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), + }, + .driver_data = (void *)&lenovo_ideapad_miix_310_pdata, + }, { } }; -- 2.17.0

2 3

[alsa-devel] [PATCH 0/5] ASoC: cirrus: Series of fixes for ep93xx-i2s
by Alexander Sverdlin 11 May '18

11 May '18

This series is a result of long-running debugging of rarely screwed I2S stream out of EP9302 chip. Logic analyser shows that the stream is shifted by one byte (out of 32 bits per sample) which leads to noise intead of original stream. DMA is verified to work fine (no underrun). The issue is only reproducible under high load (CPU or AMBA bus -- not yet clear). This stream corruption happens at the same time I2S controller reports internal FIFO underrun (even though according to documentation, it should handle an underrun gracefully). First two patches are fixing unrelated issues in I2S driver found during debugging of the stream shift. Third one is simplification of the driver to prepare for workaround. Both controller configuration options for TX FIFO underrun handling were tested, both do not work reliable. Hence, this ugly watchdog in the last patch. The whole series is tested on a board similar to EDB9302 (identical in sound part). Alexander Sverdlin (5): ASoC: cirrus: i2s: Fix LRCLK configuration ASoC: cirrus: i2s: Fix {TX|RX}LinCtrlData setup ASoC: cirrus: i2s: Stop enabling I2S2 and I2S3 FIFOs ARM: ep93xx: i2s: Add IRQ to platform device resources ASoC: cirrus: i2s: IRQ-based stream watchdog arch/arm/mach-ep93xx/core.c | 1 + sound/soc/cirrus/Kconfig | 17 +++++++ sound/soc/cirrus/edb93xx.c | 2 +- sound/soc/cirrus/ep93xx-i2s.c | 106 +++++++++++++++++++++++++++++++++-------- sound/soc/cirrus/snappercl15.c | 2 +- 5 files changed, 106 insertions(+), 22 deletions(-) -- 2.16.2

2 10

[alsa-devel] [PATCH 0/7] ASoC: omap: Deprecate omap-pcm for sdma-pcm
by Peter Ujfalusi 09 May '18

09 May '18

Hi, omap-pcm served us well over the years, but there is no reason to keep it around as we can rely on generic dmaengine_pcm code without the need to maintain custom code. The series has been tested on: omap3 beagle-xm, omap4 PandaES, omap4 Blaze (SDP), am57xx beagle-x15, dra7 evm. McBSP, McASP, McPDM, DMIC and HDMI audio was tested and I have found no issue with them. I was not able to test on OMAP1 or OMAP2 for various reasons, but mainly because neither Nokia 770 or Nokia n810 audio probes with linux-next. It does not matter if I have omap-pcm or sdma-pcm... I would be grateful if someone can give tested-by or pointers on how to get 770/n810 audio working. Regards, Peter --- Peter Ujfalusi (7): ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm ASoC: davinci-mcasp: Convert to use the sdma-pcm instead of omap-pcm ASoC: omap-hdmi-audio: Convert to use the sdma-pcm instead of omap-pcm ASoC: omap-dmic: Convert to use the sdma-pcm instead of omap-pcm ASoC: omap-mcpdm: Convert to use the sdma-pcm instead of omap-pcm ASoC: omap-mcbsp: Convert to use the sdma-pcm instead of omap-pcm ASoC: omap: Mark the omap-pcm as deprecated, but keep it in the tree sound/soc/davinci/Kconfig | 2 +- sound/soc/davinci/davinci-mcasp.c | 8 ++-- sound/soc/omap/Kconfig | 33 ++++++++------- sound/soc/omap/Makefile | 4 +- sound/soc/omap/omap-dmic.c | 4 +- sound/soc/omap/omap-hdmi-audio.c | 5 ++- sound/soc/omap/omap-mcbsp.c | 4 +- sound/soc/omap/omap-mcpdm.c | 4 +- sound/soc/omap/sdma-pcm.c | 68 +++++++++++++++++++++++++++++++ sound/soc/omap/sdma-pcm.h | 21 ++++++++++ 10 files changed, 124 insertions(+), 29 deletions(-) create mode 100644 sound/soc/omap/sdma-pcm.c create mode 100644 sound/soc/omap/sdma-pcm.h -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

4 17

[alsa-devel] Prepare to covert Codec/Platform into Component
by Kuninori Morimoto 09 May '18

09 May '18

Hi Mark, Lars-Peter I will post all prepare patches to convert Codec/Platform into Component. It has 3 steps. 1) add new necessary functions 2) remove/don't use codec hw_write/read 3) remove/don't use codec reg_cache If these are accepted, all prepares were completed. Next, I can post "convert Codec/Platform into Component" patch bomb. These are too many convert patches, to avoid review issue, I will post few of them as sample. 4) sample of don't use rtd->codec 5) sample of convert Platform into Component 6) sample of convert Codec into Component I will post some of "remove" patches too for each steps. I will re-post all "remove" patches if all are accepted. For your review, please consider below. If these are not good, all covert patch doesn't work. 1. use devm_snd_soc_register_component() and remove snd_soc_unregister_component() My patches is using devm_ version function, and removed unregister function. This is not a big deal 2. New flags. Because "Codec" and "CPU/Platform" are using different features, we need to use some new flags. .idle_bias_off/on .ignore_pmdown_time/pmdown_time These are because "CPU/Platform" and "Codec" are using different default value. "Codec" side convert patches are using these. .endianness .non_legacy_dai_naming These are because "Codec" only needs fixup format, and not use "legacy" DAI name. "Codec" side convert patches are using these I added its flags info on each patch. 3. rtd->platform rtd->platform will be removed. Now we can find all rtd connected component by using rtdcom_lookup. rtd->platform will be replaced to snd_soc_rtdcom_lookup(rtd, DRV_NAME); Here, DRV_NAME is platform's component driver name. 4. rtd->codec rtd->codec will be removed. In soc_bind_dai_link(), It is rtd->codec = rtd->codec_dai->codec; And now, DAI has codec and component pointer. So, rtd->codec will be replaced into rtd->codec_dai->component. Best regards --- Kuninori Morimoto

2 104