April 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: dmic: Fix clock parenting
by Peter Ujfalusi 12 Apr '18

12 Apr '18

From: Tero Kristo <t-kristo(a)ti.com> In 4.16 the clock hierarchy got changed by a5c82a09d876 ARM: dts: omap4: add clkctrl nodes The fck of dmic is no longer a mux clock, it's parent is. Signed-off-by: Tero Kristo <t-kristo(a)ti.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)ti.com> Cc: stable(a)vger.kernel.org # 4.16+ --- Mark, can you apply this for 4.17 as DMIC got broken already in 4.16. Regards, Peter sound/soc/omap/omap-dmic.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c index c7101d851213..51dd7c65096b 100644 --- a/sound/soc/omap/omap-dmic.c +++ b/sound/soc/omap/omap-dmic.c @@ -281,7 +281,7 @@ static int omap_dmic_dai_trigger(struct snd_pcm_substream *substream, static int omap_dmic_select_fclk(struct omap_dmic *dmic, int clk_id, unsigned int freq) { - struct clk *parent_clk; + struct clk *parent_clk, *mux; char *parent_clk_name; int ret = 0; @@ -329,14 +329,21 @@ static int omap_dmic_select_fclk(struct omap_dmic *dmic, int clk_id, return -ENODEV; } + mux = clk_get_parent(dmic->fclk); + if (IS_ERR(mux)) { + dev_err(dmic->dev, "can't get fck mux parent\n"); + clk_put(parent_clk); + return -ENODEV; + } + mutex_lock(&dmic->mutex); if (dmic->active) { /* disable clock while reparenting */ pm_runtime_put_sync(dmic->dev); - ret = clk_set_parent(dmic->fclk, parent_clk); + ret = clk_set_parent(mux, parent_clk); pm_runtime_get_sync(dmic->dev); } else { - ret = clk_set_parent(dmic->fclk, parent_clk); + ret = clk_set_parent(mux, parent_clk); } mutex_unlock(&dmic->mutex); @@ -349,6 +356,7 @@ static int omap_dmic_select_fclk(struct omap_dmic *dmic, int clk_id, dmic->fclk_freq = freq; err_busy: + clk_put(mux); clk_put(parent_clk); return ret; -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2 1

[alsa-devel] [PATCH] ALSA: line6: Use correct endpoint type for midi output
by Fabián Inostroza 12 Apr '18

12 Apr '18

Hi, Sending MIDI messages to a PODxt through the USB connection shows "usb_submit_urb failed" in dmesg and the message is not received by the POD. The error is caused because in the funcion send_midi_async() in midi.c there is a call to usb_sndbulkpipe() for endpoint 3 OUT, but the PODxt USB descriptor shows that this endpoint it's an interrupt endpoint. Patch tested with PODxt only. Signed-off-by: Fabián Inostroza <fabianinostroza(a)udec.cl> --- sound/usb/line6/midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/line6/midi.c b/sound/usb/line6/midi.c index 6d7cde56..e2cf55c5 100644 --- a/sound/usb/line6/midi.c +++ b/sound/usb/line6/midi.c @@ -125,7 +125,7 @@ static int send_midi_async(struct usb_line6 *line6, unsigned char *data, } usb_fill_int_urb(urb, line6->usbdev, - usb_sndbulkpipe(line6->usbdev, + usb_sndintpipe(line6->usbdev, line6->properties->ep_ctrl_w), transfer_buffer, length, midi_sent, line6, line6->interval); -- 2.16.3

2 1

[alsa-devel] [PATCH 1/2] ASoC: AMD: Support headset button on Stoney DA7219
by Akshu Agrawal 12 Apr '18

12 Apr '18

Adds headset button support. TEST=Tested Volume UP/Down functionality Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- sound/soc/amd/acp-da7219-max98357a.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index b205c78..d9491e1 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -33,6 +33,7 @@ #include <linux/gpio.h> #include <linux/module.h> #include <linux/i2c.h> +#include <linux/input.h> #include <linux/acpi.h> #include "../codecs/da7219.h" @@ -51,6 +52,7 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd) struct snd_soc_card *card = rtd->card; struct snd_soc_dai *codec_dai = rtd->codec_dai; struct snd_soc_component *component = codec_dai->component; + struct snd_soc_jack *jack; dev_info(rtd->dev, "codec dai name = %s\n", codec_dai->name); @@ -80,6 +82,12 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd) return ret; } + jack = &cz_jack; + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA); + snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); + snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); + snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); + da7219_aad_jack_det(component, &cz_jack); return 0; -- 1.9.1

4 10

[alsa-devel] BUG: unable to handle kernel paging request in snd_pcm_format_set_silence
by syzbot 11 Apr '18

11 Apr '18

Hello, syzbot hit the following crash on upstream commit f2d285669aae656dfeafa0bf25e86bbbc5d22329 (Tue Apr 3 17:45:39 2018 +0000) Merge tag 'pm-4.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=f973e52978d95f818f69 So far this crash happened 2 times on upstream. syzkaller reproducer: https://syzkaller.appspot.com/x/repro.syz?id=5368241429938176 Raw console output: https://syzkaller.appspot.com/x/log.txt?id=6066534392791040 Kernel config: https://syzkaller.appspot.com/x/.config?id=686016073509112605 compiler: gcc (GCC) 7.1.1 20170620 user-space arch: i386 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+f973e52978d95f818f69(a)syzkaller.appspotmail.com It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 BUG: unable to handle kernel paging request at ffffc90004cc7000 PGD 1dad42067 P4D 1dad42067 PUD 1dad43067 PMD 1c5cb3067 PTE 0 Oops: 0002 [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 0 PID: 5516 Comm: syz-executor3 Not tainted 4.16.0+ #288 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:memset_erms+0x9/0x10 arch/x86/lib/memset_64.S:65 RSP: 0018:ffff8801d7fc7368 EFLAGS: 00010246 RAX: fffff520009b9600 RBX: ffffc90004cc7000 RCX: 0000000000104500 RDX: 0000000000104500 RSI: 0000000000000000 RDI: ffffc90004cc7000 RBP: ffff8801d7fc7388 R08: 0000000000000000 R09: ffffc90004cc7000 R10: 00000000000208a0 R11: fffff520009b969f R12: 0000000000104500 R13: 0000000000000000 R14: ffffffff88c9185c R15: 0000000000000010 FS: 0000000000000000(0000) GS:ffff8801db000000(0063) knlGS:00000000f7f5fb40 CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033 CR2: ffffc90004cc7000 CR3: 00000001d765c000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: memset include/linux/string.h:330 [inline] snd_pcm_format_set_silence+0x13f/0x4b0 sound/core/pcm_misc.c:431 loopback_prepare+0x92b/0xbf0 sound/drivers/aloop.c:347 snd_pcm_do_prepare+0x58/0x90 sound/core/pcm_native.c:1640 snd_pcm_action_single+0x70/0x110 sound/core/pcm_native.c:1084 snd_pcm_action_nonatomic+0x95/0xa0 sound/core/pcm_native.c:1151 snd_pcm_prepare+0x115/0x1a0 sound/core/pcm_native.c:1687 snd_pcm_kernel_ioctl+0x97/0x240 sound/core/pcm_native.c:2998 snd_pcm_oss_prepare+0x49/0x150 sound/core/oss/pcm_oss.c:1104 snd_pcm_oss_make_ready+0xf9/0x130 sound/core/oss/pcm_oss.c:1132 snd_pcm_oss_set_trigger+0x384/0x930 sound/core/oss/pcm_oss.c:1959 snd_pcm_oss_poll+0x7aa/0xd60 sound/core/oss/pcm_oss.c:2727 do_pollfd fs/select.c:832 [inline] do_poll fs/select.c:883 [inline] do_sys_poll+0x719/0x1050 fs/select.c:977 SYSC_poll fs/select.c:1035 [inline] SyS_poll+0x10d/0x450 fs/select.c:1023 do_syscall_32_irqs_on arch/x86/entry/common.c:330 [inline] do_fast_syscall_32+0x3ec/0xf9f arch/x86/entry/common.c:392 entry_SYSENTER_compat+0x70/0x7f arch/x86/entry/entry_64_compat.S:139 RIP: 0023:0xf7f63c99 RSP: 002b:00000000f7f5f0ac EFLAGS: 00000282 ORIG_RAX: 00000000000000a8 RAX: ffffffffffffffda RBX: 0000000020000100 RCX: 0000000000000001 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 Code: 48 c1 e9 03 40 0f b6 f6 48 b8 01 01 01 01 01 01 01 01 48 0f af c6 f3 48 ab 89 d1 f3 aa 4c 89 c8 c3 90 49 89 f9 40 88 f0 48 89 d1 <f3> aa 4c 89 c8 c3 90 49 89 fa 40 0f b6 ce 48 b8 01 01 01 01 01 RIP: memset_erms+0x9/0x10 arch/x86/lib/memset_64.S:65 RSP: ffff8801d7fc7368 CR2: ffffc90004cc7000 ---[ end trace 95a476f9da224f32 ]--- --- This bug is generated by a dumb bot. It may contain errors. See https://goo.gl/tpsmEJ for details. Direct all questions to syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. If you forgot to add the Reported-by tag, once the fix for this bug is merged into any tree, please reply to this email with: #syz fix: exact-commit-title If you want to test a patch for this bug, please reply with: #syz test: git://repo/address.git branch and provide the patch inline or as an attachment. To mark this as a duplicate of another syzbot report, please reply with: #syz dup: exact-subject-of-another-report If it's a one-off invalid bug report, please reply with: #syz invalid Note: if the crash happens again, it will cause creation of a new bug report. Note: all commands must start from beginning of the line in the email body.

1 0

[alsa-devel] [PATCH v2 0/5] ASoC: Intel: geminilake: Adds da7219+max98537 machine driver support
by Naveen Manohar 11 Apr '18

11 Apr '18

Patch adds required changes in bxt machine & corresponding driver entry in machine to use MAX98357A codec as speaker on SSP1 and DA7219 codec as headset on SSP2 for GLK board. Naveen Manohar (5): ASoC: Intel: broxton: reduce machine name for bxt_da7219_max98357a ASoC: Intel: Headset button support in broxton machine driver ASoC: Intel: Add Geminilake Dialog Maxim machine driver support ASoC: Intel: glk: Add DAI links for Multi-Playback ASoC: Intel: Add Geminilake Dialog+Maxim machine driver entry sound/soc/intel/boards/bxt_da7219_max98357a.c | 152 ++++++++++++++++++++++---- sound/soc/intel/skylake/skl.c | 9 +- 2 files changed, 141 insertions(+), 20 deletions(-) -- v1->v2: Unified dai-link usage between bxt & glk mach, corrected jack CTRL 2.7.4

4 9

Re: [alsa-devel] call/normal switch was Re: omap4-droid4: voice call support was
by Tony Lindgren 11 Apr '18

11 Apr '18

* Dan Williams <dcbw(a)redhat.com> [180402 15:51]: > On Sun, 2018-04-01 at 10:30 -0700, Tony Lindgren wrote: > > * Tony Lindgren <tony(a)atomide.com> [180401 15:38]: > > Found it! Here's what I need to do over n_gsm: > > > > ngsm 1 "AT+CFUN=1" > > ngsm 1 "AT+CFUN?" > > ngsm 2 "AT+EACC=3,0" # enable mic > > ngsm 2 "AT+CLVL=4" # set speaker volume > > ngsm 2 "AT+CMUT=0" # unmute mic > > I tried to look through the QMI dumps we have in libqmi from 2013 > (latest Qualcomm posted) and couldn't find anything to do with mic > control, speaker volume, or anything like that. > > If the modem supports the AT service (which I think it does? Not > looking at the libqmi dumps right now) then it could potentially tunnel > these AT commands through QMI too. > > Perhaps Qualcomm added something to the Voice service after 2013, or > perhaps there are other services that might control speaker/mic that we > don't have public dumps for yet though. OK thanks for checking. So probably only n_gsm channel 1 is for normal Qualcomm at commands, and then channel 2 and others are commands implemented by Motorola on the mdm6600. I guess we'd have to add support for reading and writing to /dev/gsmtty2 at least as it looks like these cannot be accessed via /dev/ttyUSB4. Or at least I have not figured out any other way to access them. Regards, Tony

4 18

[alsa-devel] [PATCH v2, 1/2] ASoC: AMD: Support headset button on Stoney DA7219
by Akshu Agrawal 11 Apr '18

11 Apr '18

Adds headset button support. TEST=Tested Volume UP/Down, Play/Pause functionality Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- v2: Changed KEY_MEDIA to KEY_PLAYPAUSE sound/soc/amd/acp-da7219-max98357a.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index b205c78..1012a80 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -33,6 +33,7 @@ #include <linux/gpio.h> #include <linux/module.h> #include <linux/i2c.h> +#include <linux/input.h> #include <linux/acpi.h> #include "../codecs/da7219.h" @@ -51,6 +52,7 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd) struct snd_soc_card *card = rtd->card; struct snd_soc_dai *codec_dai = rtd->codec_dai; struct snd_soc_component *component = codec_dai->component; + struct snd_soc_jack *jack; dev_info(rtd->dev, "codec dai name = %s\n", codec_dai->name); @@ -80,6 +82,12 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd) return ret; } + jack = &cz_jack; + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); + snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); + snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); + snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); + da7219_aad_jack_det(component, &cz_jack); return 0; -- 1.9.1

4 5

[alsa-devel] [PATCH 1/2] ASoC: adau17x1: Handling of DSP_RUN register during fw setup
by Robert Rosengren 11 Apr '18

11 Apr '18

From: Danny Smith <dannys(a)axis.com> DSP_RUN needs to be disabled during firmware write otherwise we can end up with undefined behavior if writing to a dsp which is already running firmware. Signed-off-by: Danny Smith <dannys(a)axis.com> --- sound/soc/codecs/adau17x1.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/adau17x1.c b/sound/soc/codecs/adau17x1.c index 80c2a06285bb..5636b9522462 100644 --- a/sound/soc/codecs/adau17x1.c +++ b/sound/soc/codecs/adau17x1.c @@ -838,14 +838,19 @@ EXPORT_SYMBOL_GPL(adau17x1_volatile_register); int adau17x1_setup_firmware(struct adau *adau, unsigned int rate) { int ret; - int dspsr; + int dspsr, dsp_run; ret = regmap_read(adau->regmap, ADAU17X1_DSP_SAMPLING_RATE, &dspsr); if (ret) return ret; + ret = regmap_read(adau->regmap, ADAU17X1_DSP_RUN, &dsp_run); + if (ret) + return ret; + regmap_write(adau->regmap, ADAU17X1_DSP_ENABLE, 1); regmap_write(adau->regmap, ADAU17X1_DSP_SAMPLING_RATE, 0xf); + regmap_write(adau->regmap, ADAU17X1_DSP_RUN, 0); ret = sigmadsp_setup(adau->sigmadsp, rate); if (ret) { @@ -853,6 +858,7 @@ int adau17x1_setup_firmware(struct adau *adau, unsigned int rate) return ret; } regmap_write(adau->regmap, ADAU17X1_DSP_SAMPLING_RATE, dspsr); + regmap_write(adau->regmap, ADAU17X1_DSP_RUN, dsp_run); return 0; } -- 2.11.0

2 4

[alsa-devel] [PATCH v2 00/13] soundwire: Add stream support
by Vinod Koul 10 Apr '18

10 Apr '18

This series adds support in SoundWire subsystem for: - Documentation for stream support - stream management - data port management - DAI ops in cadence and Intel drivers - ASoC API to propagate SDW stream Updates in v2: - Make ASoC API inlined - Make stream states as states and not action - Update the direction enum - Fix some typos and comment updates Sanyog Kale (7): soundwire: Add more documentation soundwire: Add support for SoundWire stream management soundwire: Add support for port management soundwire: Add Master and Slave port programming soundwire: Add helpers for ports operations soundwire: Add bank switch routine soundwire: Add stream configuration APIs Shreyas NC (2): ASoC: Add SoundWire stream programming interface soundwire: Remove cdns_master_ops Vinod Koul (4): soundwire: cdns: Add port routines soundwire: cdns: Add stream routines soundwire: intel: Add stream initialization soundwire: intel: Add audio DAI ops .../driver-api/soundwire/error_handling.rst | 65 + Documentation/driver-api/soundwire/index.rst | 3 + Documentation/driver-api/soundwire/locking.rst | 106 ++ Documentation/driver-api/soundwire/stream.rst | 368 +++++ drivers/soundwire/Kconfig | 2 +- drivers/soundwire/Makefile | 2 +- drivers/soundwire/bus.c | 43 + drivers/soundwire/bus.h | 72 + drivers/soundwire/cadence_master.c | 449 +++++- drivers/soundwire/cadence_master.h | 151 ++ drivers/soundwire/intel.c | 528 ++++++- drivers/soundwire/intel.h | 4 + drivers/soundwire/intel_init.c | 3 + drivers/soundwire/stream.c | 1549 ++++++++++++++++++++ include/linux/soundwire/sdw.h | 332 ++++- include/linux/soundwire/sdw_intel.h | 14 + include/sound/soc-dai.h | 21 + 17 files changed, 3698 insertions(+), 14 deletions(-) create mode 100644 Documentation/driver-api/soundwire/error_handling.rst create mode 100644 Documentation/driver-api/soundwire/locking.rst create mode 100644 Documentation/driver-api/soundwire/stream.rst create mode 100644 drivers/soundwire/stream.c -- 2.7.4

2 43

Re: [alsa-devel] No audio on iMac18,1 (A1418) with kernel 4.15.14
by Freaky 10 Apr '18

10 Apr '18

FYI: Tested all the pin outs with hda-analyzer, didn't get sound on the speakers with any of them. On Tue, Apr 10, 2018 at 3:57 PM, Freaky <freaky2000(a)gmail.com> wrote: > Hi there, > > we got an iMac18,1 here on which we have no audio. > > Maybe the codec is just too new, although I see people using it on > non-Apple hardware. Using model parameters imac27 or imac27_122 doesn't > help. > > Have alsa-info attached. lspci (on this distro (but it's dated although it > has a recent kernel)) doesn't recognize it yet, the online PCI-IDs says: > > Sunrise Point-LP HD Audio > > Found some other people mentioning this issue at Arch, thread is here: > https://bbs.archlinux.org/viewtopic.php?id=233449&p=2 - no solution so > far. > > Will see if flipping bits with hda-analyzer will make it go. > > If there's a solution for this already we'd be much obliged if someone can > point us to it. Otherwise very willing to help, but can't code drivers > unfortunately. Can apply patches and build kernels however :). We'll have > to return the machine in about a week, so if anyone desires > output/testing/etc. please let us know asap as we only have it available > for a short while. > > Will post the solution, if we can find one, to the Arch thread as well. > > Thanks in advance. > > Kind regards >

1 0