April 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: hda - Skip jack and others for non-existing PCM streams
by Takashi Iwai 25 Apr '18

25 Apr '18

When CONFIG_SND_DYNAMIC_MINORS isn't set, there are only limited number of devices available, and HD-audio, especially with HDMI/DP codec, will fail to create more than two devices. The driver warns about the lack of such devices and skips the PCM device creations, but the HDMI driver still tries to create the corresponding JACK, SPDIF and ELD controls even for the non-existing PCM substreams. This results in confusion on user-space, and even may break the operation. Similarly, Intel HDMI/DP codec builds the ELD notification from i915 graphics driver, and this may be broken if a notification is sent for the non-existing PCM stream. This patch adds the check of the existence of the assigned PCM substream in the both scenarios above, and skips the further operation if the PCM substream is not assigned. Fixes: 9152085defb6 ("ALSA: hda - add DP MST audio support") Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_hdmi.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index b4f1b6e88305..7d7eb1354eee 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1383,6 +1383,8 @@ static void hdmi_pcm_setup_pin(struct hdmi_spec *spec, pcm = get_pcm_rec(spec, per_pin->pcm_idx); else return; + if (!pcm->pcm) + return; if (!test_bit(per_pin->pcm_idx, &spec->pcm_in_use)) return; @@ -2151,8 +2153,13 @@ static int generic_hdmi_build_controls(struct hda_codec *codec) int dev, err; int pin_idx, pcm_idx; - for (pcm_idx = 0; pcm_idx < spec->pcm_used; pcm_idx++) { + if (!get_pcm_rec(spec, pcm_idx)->pcm) { + /* no PCM: mark this for skipping permanently */ + set_bit(pcm_idx, &spec->pcm_bitmap); + continue; + } + err = generic_hdmi_build_jack(codec, pcm_idx); if (err < 0) return err; -- 2.16.3

1 0

[alsa-devel] ASoC: BCM2835-I2S: TDM slots / slot mask ignored
by Steven Eckhoff 25 Apr '18

25 Apr '18

Hi, I am testing a codec driver interfaced to the Raspberry Pi in TDM mode and on the logic analyzer I see that the I2S controller is shifting out data in slots 2 - 7 when playing 2 channel audio. The codec is master and only works at 256 x fs, so after the frame sync slots 0 and 1 transfer as they should but after that data continues to be shifted out. It is my understanding that the remaining bits should be zero padded. On a similar note I see that the I2S bcm2835-i2s driver only supports 2 slots, but it seems it can also do 8. For example if I take an 8 channel audio source file(NOTE: I had to hack the file to look like 2 channels so hw_params didn't return an error) and play it I hear the first two channels fine and in the part that I am writing the dirver for I can easily route the other slots to additional DACs and get those to play as well. So I guess I am wondering about two things: 1. In the first case why does my 2 channel audio get shifted out on all 8 slots? It seems if configured for 2 it should only shift data in the first two and wait for the next fsync before starting to shift again. 2. Why does the driver obly support 2 channels when it seems the hardware is capable of more? I figure there is something about this controller that made this tricky or impossible, but I am still curious about it. Regards, Steven

1 0

[alsa-devel] azx_probe() called twice
by Paul Menzel 25 Apr '18

25 Apr '18

Dear Linux folks, With the attached debug patch, `azx_probe()` seems to have been called twice on the ASRock E350M1. Is that expected? It also differs, that it’s only called once during some boots, and twice during others. [ 0.000000] Linux version 4.17.0-rc2+ (root@35489178f57d) (gcc version 7.3.0 (Debian 7.3.0-15)) #12 SMP Mon Apr 23 06:57:55 UTC 2018 […] [ 2.746962] calling azx_driver_init+0x0/0xfe4 [snd_hda_intel] @ 214 [ 2.777881] random: get_random_u32 called from arch_rnd.part.2+0x18/0x40 with crng_init=1 [ 2.777900] random: get_random_u32 called from load_elf_binary+0x76a/0x1d20 with crng_init=1 [ 2.777907] random: get_random_u32 called from arch_align_stack+0x45/0x70 with crng_init=1 [ 2.777938] random: get_random_u32 called from arch_rnd.part.2+0x18/0x40 with crng_init=1 [ 2.778822] random: get_random_u32 called from arch_align_stack+0x45/0x70 with crng_init=1 [ 2.778846] random: get_random_u32 called from randomize_page+0x42/0x57 with crng_init=1 [ 2.781026] calling shpcd_init+0x0/0x1000 [shpchp] @ 219 [ 2.781154] random: get_random_u32 called from cache_alloc_refill+0x5bb/0x13d0 with crng_init=1 [ 2.781477] calling k10temp_driver_init+0x0/0x1000 [k10temp] @ 215 [ 2.796426] usb usb3: New USB device found, idVendor=1d6b, idProduct=0001, bcdDevice= 4.17 [ 2.796434] usb usb3: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 2.796438] usb usb3: Product: OHCI PCI host controller [ 2.796441] usb usb3: Manufacturer: Linux 4.17.0-rc2+ ohci_hcd [ 2.796445] usb usb3: SerialNumber: 0000:00:12.0 [ 2.796922] hub 3-0:1.0: USB hub found [ 2.796968] hub 3-0:1.0: 5 ports detected [ 2.798039] ohci-pci 0000:00:13.0: OHCI PCI host controller [ 2.798056] ohci-pci 0000:00:13.0: new USB bus registered, assigned bus number 4 [ 2.798123] ohci-pci 0000:00:13.0: irq 18, io mem 0xf0149000 [ 2.804555] random: get_random_u32 called from cache_random_seq_create+0xa3/0x1f0 with crng_init=1 [ 2.804604] random: get_random_u32 called from copy_process.part.33+0x186/0x2100 with crng_init=1 [ 2.804625] random: get_random_u32 called from cache_random_seq_create+0xa3/0x1f0 with crng_init=1 [ 2.804669] random: get_random_u32 called from cache_alloc_refill+0x5bb/0x13d0 with crng_init=1 [ 2.860446] usb usb4: New USB device found, idVendor=1d6b, idProduct=0001, bcdDevice= 4.17 [ 2.860455] usb usb4: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 2.860459] usb usb4: Product: OHCI PCI host controller [ 2.860463] usb usb4: Manufacturer: Linux 4.17.0-rc2+ ohci_hcd [ 2.860466] usb usb4: SerialNumber: 0000:00:13.0 [ 2.860899] hub 4-0:1.0: USB hub found [ 2.860941] hub 4-0:1.0: 5 ports detected [ 2.861606] 1 [ 2.861632] 2 [ 2.861991] 3 [ 2.861992] 4 [ 2.861993] 5 [ 2.861995] 6 [ 2.861996] 7 [ 2.862004] 8 [ 2.862005] 9 [ 2.862290] 1 [ 2.862307] 2 [ 2.862642] 3 [ 2.862643] 4 [ 2.862645] 5 [ 2.862646] 6 [ 2.862647] 7 [ 2.862654] 8 [ 2.862655] 9 [ 2.862934] initcall azx_driver_init+0x0/0xfe4 [snd_hda_intel] returned 0 after 79525 usecs Please find the full log attached. Kind regards, Paul

2 5

[alsa-devel] [GIT PULL] ASoC fixes for v4.17
by Mark Brown 25 Apr '18

25 Apr '18

The following changes since commit 445bb423f6a3c50788529a33b82e45148001e855: Merge remote-tracking branch 'asoc/topic/zx_aud96p22' into asoc-next (2018-03-28 10:32:03 +0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-4.17-rc2 for you to fetch changes up to a8419a0cd98ddf628a9e38a92110af7cc650dde7: ASoC: msm8916-wcd-analog: use threaded context for mbhc events (2018-04-19 12:30:42 +0100) ---------------------------------------------------------------- ASoC: Fixes for v4.17 A small batch of fixes collected since the merge window, none of which are particularly large or remarkable. They've all been cooking in -next for a while. ---------------------------------------------------------------- Arnd Bergmann (1): ASoC: rsnd: mark PM functions __maybe_unused Dan Carpenter (1): ASoC: topology: fix some tiny memory leaks Danny Smith (1): ASoC: adau17x1: Handling of DSP_RUN register during fw setup Liam Girdwood (1): ASoC: topology: Check widget kcontrols before deref Nicolin Chen (2): ASoC: fsl_esai: Fix divisor calculation failure at lower ratio ASoC: fsl_ssi: Fix mode setting when changing channel number Pierre-Louis Bossart (1): ASoC: Intel: atom: fix ACPI/PCI Kconfig Srinivas Kandagatla (1): ASoC: msm8916-wcd-analog: use threaded context for mbhc events Tero Kristo (1): ASoC: dmic: Fix clock parenting Wei Yongjun (1): ASoC: amd: acp-da7219-max98357: Make symbol da7219_dai_clk static Yan Wang (1): ASoC: topology: Fix bugs of freeing soc topology oder_chiou(a)realtek.com (1): ASoC: rt5514: Add the missing register in the readable table sound/soc/amd/acp-da7219-max98357a.c | 2 +- sound/soc/codecs/adau17x1.c | 26 ++++++++++++++++++++------ sound/soc/codecs/adau17x1.h | 3 ++- sound/soc/codecs/msm8916-wcd-analog.c | 9 ++++++--- sound/soc/codecs/rt5514.c | 3 +++ sound/soc/fsl/fsl_esai.c | 7 +++++++ sound/soc/fsl/fsl_ssi.c | 14 +++++++++++--- sound/soc/intel/Kconfig | 22 +++++++++++++--------- sound/soc/omap/omap-dmic.c | 14 +++++++++++--- sound/soc/sh/rcar/core.c | 4 ++-- sound/soc/soc-topology.c | 14 +++++++++----- 11 files changed, 85 insertions(+), 33 deletions(-)

2 1

[alsa-devel] change the location for one of two front mics for Lenovo ThinkCentre
by Kailang 25 Apr '18

25 Apr '18

Hi Takashi, Lenovo ThinkCentre machine had two front mics. we change the location for one of them. Relation commit: f33f79f3d0e5caf04dd889cd7cf636261970f009 BR, Kailang

2 1

[alsa-devel] [PATCH 0/8] arm: renesas: Change platform dependency to ARCH_RENESAS
by Geert Uytterhoeven 25 Apr '18

25 Apr '18

Hi all, Commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") started the conversion from ARCH_SHMOBILE to ARCH_RENESAS for Renesas ARM SoCs. This patch series completes the conversion, by: 1. Updating dependencies for drivers that weren't converted yet, 2. Removing the ARCH_SHMOBILE Kconfig symbols on ARM and ARM64. The first 6 patches can be applied independently by subsystem maintainers. The last two patches depend on the first 6 patches, and are thus marked RFC. Thanks for your comments! Geert Uytterhoeven (8): arm: shmobile: Change platform dependency to ARCH_RENESAS dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS sh_eth: Change platform check to CONFIG_ARCH_RENESAS staging: emxx_udc: Change platform dependency to ARCH_RENESAS ASoC: sh: Update menu title and platform dependency [RFC] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol [RFC] arm64: renesas: Remove the ARCH_SHMOBILE Kconfig symbol arch/arm/Kconfig | 2 +- arch/arm/Makefile | 2 +- arch/arm/mach-shmobile/Kconfig | 4 --- arch/arm64/Kconfig.platforms | 42 +++++++++++++---------------- drivers/dma/sh/shdmac.c | 50 +++++++++++++++-------------------- drivers/media/platform/Kconfig | 2 +- drivers/net/ethernet/renesas/sh_eth.h | 2 +- drivers/staging/emxx_udc/Kconfig | 2 +- sound/soc/sh/Kconfig | 4 +-- 9 files changed, 47 insertions(+), 63 deletions(-) -- 2.7.4 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

7 22

[alsa-devel] Fix ALC233 default init
by Kailang 25 Apr '18

25 Apr '18

Hi Takashi, Attach patch was for fix ALC233 for default initial. BR, Kailang

2 3

[alsa-devel] Update ALC255 depop optimize
by Kailang 25 Apr '18

25 Apr '18

Hi Takashi, Attach patch was update ALC255 depop optimize. BR, Kailang

2 1

[alsa-devel] [PATCH] sound: core: Change return type to vm_fault_t
by Souptick Joarder 25 Apr '18

25 Apr '18

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Commit 1c8f422059ae ("mm: change return type to vm_fault_t") Signed-off-by: Souptick Joarder <jrdr.linux(a)gmail.com> Reviewed-by: Matthew Wilcox <mawilcox(a)microsoft.com> --- sound/core/pcm_native.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 77ba50d..2d331f4 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -3229,7 +3229,7 @@ static __poll_t snd_pcm_capture_poll(struct file *file, poll_table * wait) /* * mmap status record */ -static int snd_pcm_mmap_status_fault(struct vm_fault *vmf) +static vm_fault_t snd_pcm_mmap_status_fault(struct vm_fault *vmf) { struct snd_pcm_substream *substream = vmf->vma->vm_private_data; struct snd_pcm_runtime *runtime; @@ -3265,7 +3265,7 @@ static int snd_pcm_mmap_status(struct snd_pcm_substream *substream, struct file /* * mmap control record */ -static int snd_pcm_mmap_control_fault(struct vm_fault *vmf) +static vm_fault_t snd_pcm_mmap_control_fault(struct vm_fault *vmf) { struct snd_pcm_substream *substream = vmf->vma->vm_private_data; struct snd_pcm_runtime *runtime; @@ -3354,7 +3354,7 @@ static int snd_pcm_mmap_control(struct snd_pcm_substream *substream, struct file /* * fault callback for mmapping a RAM page */ -static int snd_pcm_mmap_data_fault(struct vm_fault *vmf) +static vm_fault_t snd_pcm_mmap_data_fault(struct vm_fault *vmf) { struct snd_pcm_substream *substream = vmf->vma->vm_private_data; struct snd_pcm_runtime *runtime; -- 1.9.1

2 1

[alsa-devel] [PATCH] sound: usb: usx2y: Change return type to vm_fault_t
by Souptick Joarder 25 Apr '18

25 Apr '18

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Commit 1c8f422059ae ("mm: change return type to vm_fault_t") Signed-off-by: Souptick Joarder <jrdr.linux(a)gmail.com> Reviewed-by: Matthew Wilcox <mawilcox(a)microsoft.com> --- sound/usb/usx2y/us122l.c | 2 +- sound/usb/usx2y/usX2Yhwdep.c | 2 +- sound/usb/usx2y/usx2yhwdeppcm.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/usb/usx2y/us122l.c b/sound/usb/usx2y/us122l.c index ebcab5c..8082f7b 100644 --- a/sound/usb/usx2y/us122l.c +++ b/sound/usb/usx2y/us122l.c @@ -139,7 +139,7 @@ static void usb_stream_hwdep_vm_open(struct vm_area_struct *area) snd_printdd(KERN_DEBUG "%i\n", atomic_read(&us122l->mmap_count)); } -static int usb_stream_hwdep_vm_fault(struct vm_fault *vmf) +static vm_fault_t usb_stream_hwdep_vm_fault(struct vm_fault *vmf) { unsigned long offset; struct page *page; diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c index d8bd7c9..c1dd9a7 100644 --- a/sound/usb/usx2y/usX2Yhwdep.c +++ b/sound/usb/usx2y/usX2Yhwdep.c @@ -31,7 +31,7 @@ #include "usbusx2y.h" #include "usX2Yhwdep.h" -static int snd_us428ctls_vm_fault(struct vm_fault *vmf) +static vm_fault_t snd_us428ctls_vm_fault(struct vm_fault *vmf) { unsigned long offset; struct page * page; diff --git a/sound/usb/usx2y/usx2yhwdeppcm.c b/sound/usb/usx2y/usx2yhwdeppcm.c index 0d05052..4fd9276 100644 --- a/sound/usb/usx2y/usx2yhwdeppcm.c +++ b/sound/usb/usx2y/usx2yhwdeppcm.c @@ -652,7 +652,7 @@ static void snd_usX2Y_hwdep_pcm_vm_close(struct vm_area_struct *area) } -static int snd_usX2Y_hwdep_pcm_vm_fault(struct vm_fault *vmf) +static vm_fault_t snd_usX2Y_hwdep_pcm_vm_fault(struct vm_fault *vmf) { unsigned long offset; void *vaddr; -- 1.9.1

2 1