March 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1/2] ASoC: AMD: Support headset button on Stoney DA7219
by Akshu Agrawal 12 Apr '18

12 Apr '18

Adds headset button support. TEST=Tested Volume UP/Down functionality Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- sound/soc/amd/acp-da7219-max98357a.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index b205c78..d9491e1 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -33,6 +33,7 @@ #include <linux/gpio.h> #include <linux/module.h> #include <linux/i2c.h> +#include <linux/input.h> #include <linux/acpi.h> #include "../codecs/da7219.h" @@ -51,6 +52,7 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd) struct snd_soc_card *card = rtd->card; struct snd_soc_dai *codec_dai = rtd->codec_dai; struct snd_soc_component *component = codec_dai->component; + struct snd_soc_jack *jack; dev_info(rtd->dev, "codec dai name = %s\n", codec_dai->name); @@ -80,6 +82,12 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd) return ret; } + jack = &cz_jack; + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA); + snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); + snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); + snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); + da7219_aad_jack_det(component, &cz_jack); return 0; -- 1.9.1

4 10

[alsa-devel] [PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h
by Kai-Heng Feng 07 Apr '18

07 Apr '18

This header will be used for more than just led. Change it to a more generic name. Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- v2: Mario suggested to squash the HDA part into the same series. drivers/platform/x86/dell-laptop.c | 2 +- include/linux/{dell-led.h => dell-common.h} | 4 ++-- sound/pci/hda/dell_wmi_helper.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) rename include/linux/{dell-led.h => dell-common.h} (61%) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index c52c6723374b..8ba820e6c3d0 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -29,7 +29,7 @@ #include <linux/mm.h> #include <linux/i8042.h> #include <linux/debugfs.h> -#include <linux/dell-led.h> +#include <linux/dell-common.h> #include <linux/seq_file.h> #include <acpi/video.h> #include "dell-rbtn.h" diff --git a/include/linux/dell-led.h b/include/linux/dell-common.h similarity index 61% rename from include/linux/dell-led.h rename to include/linux/dell-common.h index 92521471517f..37e4b614dd74 100644 --- a/include/linux/dell-led.h +++ b/include/linux/dell-common.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ -#ifndef __DELL_LED_H__ -#define __DELL_LED_H__ +#ifndef __DELL_COMMON_H__ +#define __DELL_COMMON_H__ int dell_micmute_led_set(int on); diff --git a/sound/pci/hda/dell_wmi_helper.c b/sound/pci/hda/dell_wmi_helper.c index 1b48a8c19d28..56050cc3c0ee 100644 --- a/sound/pci/hda/dell_wmi_helper.c +++ b/sound/pci/hda/dell_wmi_helper.c @@ -4,7 +4,7 @@ */ #if IS_ENABLED(CONFIG_DELL_LAPTOP) -#include <linux/dell-led.h> +#include <linux/dell-common.h> enum { MICMUTE_LED_ON, -- 2.15.1

6 24

[alsa-devel] KASAN: use-after-free Read in snd_pcm_timer_resolution
by syzbot 05 Apr '18

05 Apr '18

Hello, syzbot hit the following crash on upstream commit 0b412605ef5f5c64b31f19e2910b1d5eba9929c3 (Thu Mar 29 01:07:23 2018 +0000) Merge tag 'drm-fixes-for-v4.16-rc8' of git://people.freedesktop.org/~airlied/linux syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=8e62ff4e07aa2ce87826 So far this crash happened 3 times on upstream. C reproducer: https://syzkaller.appspot.com/x/repro.c?id=6219387178582016 syzkaller reproducer: https://syzkaller.appspot.com/x/repro.syz?id=5176598244360192 Raw console output: https://syzkaller.appspot.com/x/log.txt?id=5815694612496384 Kernel config: https://syzkaller.appspot.com/x/.config?id=-8440362230543204781 compiler: gcc (GCC) 7.1.1 20170620 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+8e62ff4e07aa2ce87826(a)syzkaller.appspotmail.com It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. ================================================================== BUG: KASAN: use-after-free in snd_pcm_timer_resolution+0xa3/0xc0 sound/core/pcm_timer.c:72 Read of size 4 at addr ffff8801bdd58490 by task syzkaller702213/13238 CPU: 0 PID: 13238 Comm: syzkaller702213 Not tainted 4.16.0-rc7+ #370 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x194/0x24d lib/dump_stack.c:53 print_address_description+0x73/0x250 mm/kasan/report.c:256 kasan_report_error mm/kasan/report.c:354 [inline] kasan_report+0x23c/0x360 mm/kasan/report.c:412 __asan_report_load4_noabort+0x14/0x20 mm/kasan/report.c:432 snd_pcm_timer_resolution+0xa3/0xc0 sound/core/pcm_timer.c:72 snd_timer_resolution sound/core/timer.c:439 [inline] snd_timer_notify1+0x10f/0x400 sound/core/timer.c:462 snd_timer_start1+0x586/0x8f0 sound/core/timer.c:522 snd_timer_start+0x5d/0xa0 sound/core/timer.c:634 snd_timer_user_start.isra.12+0xde/0x130 sound/core/timer.c:1878 snd_timer_user_continue sound/core/timer.c:1902 [inline] __snd_timer_user_ioctl+0x1771/0x2c10 sound/core/timer.c:1977 snd_timer_user_ioctl+0x5f/0x7d sound/core/timer.c:1992 vfs_ioctl fs/ioctl.c:46 [inline] do_vfs_ioctl+0x1b1/0x1520 fs/ioctl.c:686 SYSC_ioctl fs/ioctl.c:701 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692 do_syscall_64+0x281/0x940 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x42/0xb7 RIP: 0033:0x4453c9 RSP: 002b:00007ffd46abffe8 EFLAGS: 00000217 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00000000004453c9 RDX: 00000000004453c9 RSI: 00000000000054a2 RDI: 0000000000000003 RBP: 0000000000000000 R08: 0000000046ac0168 R09: 0000000046ac0168 R10: 0000000046ac0168 R11: 0000000000000217 R12: 00000000000142ea R13: 0000000000402c90 R14: 00000000006d1440 R15: 0000000000000000 Allocated by task 13234: save_stack+0x43/0xd0 mm/kasan/kasan.c:447 set_track mm/kasan/kasan.c:459 [inline] kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:552 kmem_cache_alloc_trace+0x136/0x740 mm/slab.c:3608 kmalloc include/linux/slab.h:512 [inline] kzalloc include/linux/slab.h:701 [inline] snd_pcm_attach_substream+0x3c5/0xb60 sound/core/pcm.c:1006 snd_pcm_open_substream+0x95/0x3b0 sound/core/pcm_native.c:2372 snd_pcm_oss_open_file sound/core/oss/pcm_oss.c:2309 [inline] snd_pcm_oss_open+0x7cf/0x1540 sound/core/oss/pcm_oss.c:2391 soundcore_open+0x321/0x630 sound/sound_core.c:597 chrdev_open+0x257/0x730 fs/char_dev.c:417 do_dentry_open+0x667/0xd40 fs/open.c:752 vfs_open+0x107/0x220 fs/open.c:866 do_last fs/namei.c:3379 [inline] path_openat+0x1151/0x3530 fs/namei.c:3519 do_filp_open+0x25b/0x3b0 fs/namei.c:3554 do_sys_open+0x502/0x6d0 fs/open.c:1059 SYSC_openat fs/open.c:1086 [inline] SyS_openat+0x30/0x40 fs/open.c:1080 do_syscall_64+0x281/0x940 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x42/0xb7 Freed by task 13234: save_stack+0x43/0xd0 mm/kasan/kasan.c:447 set_track mm/kasan/kasan.c:459 [inline] __kasan_slab_free+0x11a/0x170 mm/kasan/kasan.c:520 kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:527 __cache_free mm/slab.c:3486 [inline] kfree+0xd9/0x260 mm/slab.c:3801 snd_pcm_detach_substream+0x134/0x290 sound/core/pcm.c:1057 snd_pcm_release_substream.part.44+0x23d/0x300 sound/core/pcm_native.c:2361 snd_pcm_release_substream+0x59/0x70 sound/core/pcm_native.c:2362 snd_pcm_oss_release_file.part.18+0x71/0xa0 sound/core/oss/pcm_oss.c:2268 snd_pcm_oss_release_file sound/core/oss/pcm_oss.c:2263 [inline] snd_pcm_oss_release+0x104/0x280 sound/core/oss/pcm_oss.c:2448 __fput+0x327/0x7e0 fs/file_table.c:209 ____fput+0x15/0x20 fs/file_table.c:243 task_work_run+0x199/0x270 kernel/task_work.c:113 exit_task_work include/linux/task_work.h:22 [inline] do_exit+0x9bb/0x1ad0 kernel/exit.c:865 do_group_exit+0x149/0x400 kernel/exit.c:968 SYSC_exit_group kernel/exit.c:979 [inline] SyS_exit_group+0x1d/0x20 kernel/exit.c:977 do_syscall_64+0x281/0x940 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x42/0xb7 The buggy address belongs to the object at ffff8801bdd58180 which belongs to the cache kmalloc-2048 of size 2048 The buggy address is located 784 bytes inside of 2048-byte region [ffff8801bdd58180, ffff8801bdd58980) The buggy address belongs to the page: page:ffffea0006f75600 count:1 mapcount:0 mapping:ffff8801bdd58180 index:0x0 compound_mapcount: 0 flags: 0x2fffc0000008100(slab|head) raw: 02fffc0000008100 ffff8801bdd58180 0000000000000000 0000000100000003 raw: ffffea0007330d20 ffffea0007268aa0 ffff8801dac00c40 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff8801bdd58380: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff8801bdd58400: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > ffff8801bdd58480: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff8801bdd58500: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff8801bdd58580: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== --- This bug is generated by a dumb bot. It may contain errors. See https://goo.gl/tpsmEJ for details. Direct all questions to syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. If you forgot to add the Reported-by tag, once the fix for this bug is merged into any tree, please reply to this email with: #syz fix: exact-commit-title If you want to test a patch for this bug, please reply with: #syz test: git://repo/address.git branch and provide the patch inline or as an attachment. To mark this as a duplicate of another syzbot report, please reply with: #syz dup: exact-subject-of-another-report If it's a one-off invalid bug report, please reply with: #syz invalid Note: if the crash happens again, it will cause creation of a new bug report. Note: all commands must start from beginning of the line in the email body.

3 2

[alsa-devel] [PATCH 00/13] soundwire: Add stream support
by Vinod Koul 05 Apr '18

05 Apr '18

This series adds support in SoundWire subsystem for: - Documentation for stream support - stream management - data port management - DAI ops in cadence and Intel drivers - ASoC API to propagate SDW stream Sanyog Kale (5): soundwire: Add more documentation soundwire: Add support for SoundWire stream management soundwire: Add Master and Slave port programming soundwire: Add helpers for ports operations soundwire: Add bank switch routine Shreyas NC (2): ASoC: Add SoundWire stream programming interface soundwire: Remove cdns_master_ops Vinod Koul (6): soundwire: Add support for port management soundwire: Add stream configuration APIs soundwire: cdns: Add port routines soundwire: cdns: Add stream routines soundwire: intel: Add stream initialization soundwire: intel: Add audio DAI ops .../driver-api/soundwire/error_handling.rst | 65 ++ Documentation/driver-api/soundwire/index.rst | 3 + Documentation/driver-api/soundwire/locking.rst | 106 +++ Documentation/driver-api/soundwire/stream.rst | 369 +++++++++ drivers/soundwire/Kconfig | 2 +- drivers/soundwire/Makefile | 3 +- drivers/soundwire/bus.c | 44 + drivers/soundwire/bus.h | 81 ++ drivers/soundwire/cadence_master.c | 449 +++++++++- drivers/soundwire/cadence_master.h | 151 ++++ drivers/soundwire/intel.c | 589 ++++++++++++- drivers/soundwire/intel.h | 4 + drivers/soundwire/intel_init.c | 3 + drivers/soundwire/runtime.c | 907 +++++++++++++++++++++ drivers/soundwire/stream.c | 678 +++++++++++++++ include/linux/soundwire/sdw.h | 337 +++++++- include/linux/soundwire/sdw_intel.h | 14 + include/sound/soc-dai.h | 5 + sound/soc/soc-core.c | 20 + 19 files changed, 3816 insertions(+), 14 deletions(-) create mode 100644 Documentation/driver-api/soundwire/error_handling.rst create mode 100644 Documentation/driver-api/soundwire/locking.rst create mode 100644 Documentation/driver-api/soundwire/stream.rst create mode 100644 drivers/soundwire/runtime.c create mode 100644 drivers/soundwire/stream.c -- 2.7.4

5 24

[alsa-devel] [PATCHv5 0/5] Motorola Droid 4 Audio Support
by Sebastian Reichel 04 Apr '18

04 Apr '18

Hi, This adds audio support to Motorola Droid 4. I dropped the regulator from the DT binding as requested by Mark. Tested: - Playing via both DACs using Speaker, Earpiece, Headphone - Recording using internal Mic - Volume Controls Known not to work: - 3.5mm detection support (requires closed source firmware, needs further investigation) - Modem / Bluetooth Audio (this needs something more sophisticated than the audio-graph-card driver. I will have a look once the basic support has been merged) Changes since PATCHv4: * Replace verbose GPL text with SPDX header * Use "GPL v2" as MODULE_LICENSE * Drop "default MFD_CPCAP" for the codec driver * Use SOC_SINGLE instead of SOC_ENUM for Phase invert switches * Find DT node by node name instead of by compatible property - Drop Acked-by from Rob Herring * Add new patch for MFD driver to implement the mentioned DT change Changes since PATCHv3: * Drop regulator from DT binding, request VAUDIO from global regulator namespace instead Changes since PATCHv2: * Fix a whitespace issue * Fix const notes Takashi provided * Fix a DAPM route issue I accidently introduced in v2 Changes since PATCHv1: * Add patch from Tony exporting soc_dpcm_runtime_update * Integrate DT patch for vaudio initial mode * Split dt-binding from codec patch and add Ack from Rob * Fix CPCAP position in Kconfig/Makefile * Avoid "err +=" constructs * Simplify reset function * Drop cpcap_audio_read/write helpers * Do not use tertiary operator for mute register value * Update Input Mux logic * Switch from simple-audio-card to audio-graph-card -- Sebastian Sebastian Reichel (5): dt-bindings: mfd: motorola-cpcap: document audio-codec ASoC: codec: cpcap: new codec mfd: motorola-cpcap: Add audio-codec support ARM: dts: motorola-cpcap-mapphone: add audio-codec ARM: dts: omap4-droid4: add soundcard .../devicetree/bindings/mfd/motorola-cpcap.txt | 42 + arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 13 + arch/arm/boot/dts/omap4-droid4-xt894.dts | 78 + drivers/mfd/motorola-cpcap.c | 51 +- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/cpcap.c | 1568 ++++++++++++++++++++ 7 files changed, 1757 insertions(+), 1 deletion(-) create mode 100644 sound/soc/codecs/cpcap.c -- 2.16.1

9 90

[alsa-devel] [PATCH 1/3 v3] ASoC: TSCS42xx: Shorten lines and other cleanup
by Steven Eckhoff 03 Apr '18

03 Apr '18

Shorten lines greater than 80 chars Add const to struct snd_soc_component_driver Signed-off-by: Steven Eckhoff <steven.eckhoff.opensource(a)gmail.com> --- sound/soc/codecs/tscs42xx.c | 87 ++++++++++++++++++++++++++++----------------- 1 file changed, 55 insertions(+), 32 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index cfc71b5411ee..37636d6efe60 100644 --- a/sound/soc/codecs/tscs42xx.c +++ b/sound/soc/codecs/tscs42xx.c @@ -204,7 +204,8 @@ static int power_up_audio_plls(struct snd_soc_component *component) break; default: ret = -EINVAL; - dev_err(component->dev, "Unrecognized PLL output freq (%d)\n", ret); + dev_err(component->dev, + "Unrecognized PLL output freq (%d)\n", ret); return ret; } @@ -261,7 +262,8 @@ static int power_down_audio_plls(struct snd_soc_component *component) static int coeff_ram_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); + struct snd_soc_component *component = + snd_soc_kcontrol_component(kcontrol); struct tscs42xx *tscs42xx = snd_soc_component_get_drvdata(component); struct coeff_ram_ctl *ctl = (struct coeff_ram_ctl *)kcontrol->private_value; @@ -280,7 +282,8 @@ static int coeff_ram_get(struct snd_kcontrol *kcontrol, static int coeff_ram_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); + struct snd_soc_component *component = + snd_soc_kcontrol_component(kcontrol); struct tscs42xx *tscs42xx = snd_soc_component_get_drvdata(component); struct coeff_ram_ctl *ctl = (struct coeff_ram_ctl *)kcontrol->private_value; @@ -363,7 +366,8 @@ static int dapm_micb_event(struct snd_soc_dapm_widget *w, static int pll_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol, int event) { - struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); + struct snd_soc_component *component = + snd_soc_dapm_to_component(w->dapm); int ret; if (SND_SOC_DAPM_EVENT_ON(event)) @@ -377,7 +381,8 @@ static int pll_event(struct snd_soc_dapm_widget *w, static int dac_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol, int event) { - struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); + struct snd_soc_component *component = + snd_soc_dapm_to_component(w->dapm); struct tscs42xx *tscs42xx = snd_soc_component_get_drvdata(component); int ret; @@ -819,16 +824,19 @@ static int setup_sample_format(struct snd_soc_component *component, dev_err(component->dev, "Unsupported format width (%d)\n", ret); return ret; } - ret = snd_soc_component_update_bits(component, R_AIC1, RM_AIC1_WL, width); + ret = snd_soc_component_update_bits(component, + R_AIC1, RM_AIC1_WL, width); if (ret < 0) { - dev_err(component->dev, "Failed to set sample width (%d)\n", ret); + dev_err(component->dev, + "Failed to set sample width (%d)\n", ret); return ret; } return 0; } -static int setup_sample_rate(struct snd_soc_component *component, unsigned int rate) +static int setup_sample_rate(struct snd_soc_component *component, + unsigned int rate) { struct tscs42xx *tscs42xx = snd_soc_component_get_drvdata(component); unsigned int br, bm; @@ -881,24 +889,32 @@ static int setup_sample_rate(struct snd_soc_component *component, unsigned int r } /* DAC and ADC share bit and frame clock */ - ret = snd_soc_component_update_bits(component, R_DACSR, RM_DACSR_DBR, br); + ret = snd_soc_component_update_bits(component, + R_DACSR, RM_DACSR_DBR, br); if (ret < 0) { - dev_err(component->dev, "Failed to update register (%d)\n", ret); + dev_err(component->dev, + "Failed to update register (%d)\n", ret); return ret; } - ret = snd_soc_component_update_bits(component, R_DACSR, RM_DACSR_DBM, bm); + ret = snd_soc_component_update_bits(component, + R_DACSR, RM_DACSR_DBM, bm); if (ret < 0) { - dev_err(component->dev, "Failed to update register (%d)\n", ret); + dev_err(component->dev, + "Failed to update register (%d)\n", ret); return ret; } - ret = snd_soc_component_update_bits(component, R_ADCSR, RM_DACSR_DBR, br); + ret = snd_soc_component_update_bits(component, + R_ADCSR, RM_DACSR_DBR, br); if (ret < 0) { - dev_err(component->dev, "Failed to update register (%d)\n", ret); + dev_err(component->dev, + "Failed to update register (%d)\n", ret); return ret; } - ret = snd_soc_component_update_bits(component, R_ADCSR, RM_DACSR_DBM, bm); + ret = snd_soc_component_update_bits(component, + R_ADCSR, RM_DACSR_DBM, bm); if (ret < 0) { - dev_err(component->dev, "Failed to update register (%d)\n", ret); + dev_err(component->dev, + "Failed to update register (%d)\n", ret); return ret; } @@ -1076,7 +1092,8 @@ static int tscs42xx_hw_params(struct snd_pcm_substream *substream, ret = setup_sample_rate(component, params_rate(params)); if (ret < 0) { - dev_err(component->dev, "Failed to setup sample rate (%d)\n", ret); + dev_err(component->dev, + "Failed to setup sample rate (%d)\n", ret); return ret; } @@ -1087,7 +1104,8 @@ static inline int dac_mute(struct snd_soc_component *component) { int ret; - ret = snd_soc_component_update_bits(component, R_CNVRTR1, RM_CNVRTR1_DACMU, + ret = snd_soc_component_update_bits(component, + R_CNVRTR1, RM_CNVRTR1_DACMU, RV_CNVRTR1_DACMU_ENABLE); if (ret < 0) { dev_err(component->dev, "Failed to mute DAC (%d)\n", @@ -1102,7 +1120,8 @@ static inline int dac_unmute(struct snd_soc_component *component) { int ret; - ret = snd_soc_component_update_bits(component, R_CNVRTR1, RM_CNVRTR1_DACMU, + ret = snd_soc_component_update_bits(component, + R_CNVRTR1, RM_CNVRTR1_DACMU, RV_CNVRTR1_DACMU_DISABLE); if (ret < 0) { dev_err(component->dev, "Failed to unmute DAC (%d)\n", @@ -1117,8 +1136,8 @@ static inline int adc_mute(struct snd_soc_component *component) { int ret; - ret = snd_soc_component_update_bits(component, R_CNVRTR0, RM_CNVRTR0_ADCMU, - RV_CNVRTR0_ADCMU_ENABLE); + ret = snd_soc_component_update_bits(component, + R_CNVRTR0, RM_CNVRTR0_ADCMU, RV_CNVRTR0_ADCMU_ENABLE); if (ret < 0) { dev_err(component->dev, "Failed to mute ADC (%d)\n", ret); @@ -1132,8 +1151,8 @@ static inline int adc_unmute(struct snd_soc_component *component) { int ret; - ret = snd_soc_component_update_bits(component, R_CNVRTR0, RM_CNVRTR0_ADCMU, - RV_CNVRTR0_ADCMU_DISABLE); + ret = snd_soc_component_update_bits(component, + R_CNVRTR0, RM_CNVRTR0_ADCMU, RV_CNVRTR0_ADCMU_DISABLE); if (ret < 0) { dev_err(component->dev, "Failed to unmute ADC (%d)\n", ret); @@ -1171,8 +1190,8 @@ static int tscs42xx_set_dai_fmt(struct snd_soc_dai *codec_dai, /* Slave mode not supported since it needs always-on frame clock */ switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFM: - ret = snd_soc_component_update_bits(component, R_AIC1, RM_AIC1_MS, - RV_AIC1_MS_MASTER); + ret = snd_soc_component_update_bits(component, + R_AIC1, RM_AIC1_MS, RV_AIC1_MS_MASTER); if (ret < 0) { dev_err(component->dev, "Failed to set codec DAI master (%d)\n", ret); @@ -1211,14 +1230,18 @@ static int tscs42xx_set_dai_bclk_ratio(struct snd_soc_dai *codec_dai, return -EINVAL; } - ret = snd_soc_component_update_bits(component, R_DACSR, RM_DACSR_DBCM, value); + ret = snd_soc_component_update_bits(component, + R_DACSR, RM_DACSR_DBCM, value); if (ret < 0) { - dev_err(component->dev, "Failed to set DAC BCLK ratio (%d)\n", ret); + dev_err(component->dev, + "Failed to set DAC BCLK ratio (%d)\n", ret); return ret; } - ret = snd_soc_component_update_bits(component, R_ADCSR, RM_ADCSR_ABCM, value); + ret = snd_soc_component_update_bits(component, + R_ADCSR, RM_ADCSR_ABCM, value); if (ret < 0) { - dev_err(component->dev, "Failed to set ADC BCLK ratio (%d)\n", ret); + dev_err(component->dev, + "Failed to set ADC BCLK ratio (%d)\n", ret); return ret; } @@ -1309,7 +1332,7 @@ static int part_is_valid(struct tscs42xx *tscs42xx) }; } -static struct snd_soc_component_driver soc_codec_dev_tscs42xx = { +static const struct snd_soc_component_driver soc_codec_dev_tscs42xx = { .dapm_widgets = tscs42xx_dapm_widgets, .num_dapm_widgets = ARRAY_SIZE(tscs42xx_dapm_widgets), .dapm_routes = tscs42xx_intercon, @@ -1416,8 +1439,8 @@ static int tscs42xx_i2c_probe(struct i2c_client *i2c, mutex_init(&tscs42xx->coeff_ram_lock); mutex_init(&tscs42xx->pll_lock); - ret = devm_snd_soc_register_component(tscs42xx->dev, &soc_codec_dev_tscs42xx, - &tscs42xx_dai, 1); + ret = devm_snd_soc_register_component(tscs42xx->dev, + &soc_codec_dev_tscs42xx, &tscs42xx_dai, 1); if (ret) { dev_err(tscs42xx->dev, "Failed to register codec (%d)\n", ret); return ret; -- 2.15.1

2 2

[alsa-devel] [PATCH 0/8] Enablement of BT I2S controller instance for AMD APUs
by Vijendar Mukunda 02 Apr '18

02 Apr '18

This patch set updates Audio CoProcessor (ACP) audio drivers to enable BT I2S controller instance. In Audio Coprocessor, There are three I2S controllers can be configured/enabled.(I2S SP, I2S MICSP, BT I2S) Default enabled I2S controller instance is I2S SP instance. There is a requirement to enable BT I2S controller Instance along with I2S SP controller instance. This patch set bring up functionality to render & capture on BT I2S controller instance. The current patch set also includes a new dependent patch. The current code is based on asoc-next, but I'm happy to rebase on whatever tree this ends up going through if there are any problems applying. Vijendar Mukunda (8): ASoC: dwc: I2S Controller instance param added ASoC: amd: dma driver changes for BT I2S controller instance ASoC: amd: dma descriptor changes for BT I2S Instance ASoC: amd: Interrupt handler changes for BT I2S instance ASoC: amd: prepare callback modifications for bt i2s instance ASoC: amd: pointer and trigger callback modifications for bt i2s ASoC: amd: 16bit resolution support for bt i2s instance ASoC: amd: enabling bt i2s config after acp reset include/sound/designware_i2s.h | 6 + sound/soc/amd/acp-pcm-dma.c | 531 +++++++++++++++++++++++++++++++++-------- sound/soc/amd/acp.h | 50 +++- sound/soc/dwc/dwc-i2s.c | 1 + sound/soc/dwc/local.h | 1 + 5 files changed, 481 insertions(+), 108 deletions(-) -- 2.7.4

3 11

[alsa-devel] [PATCH v4] ASoC: AMD: Enable/Disable auxiliary clock via common clock framework
by Akshu Agrawal 30 Mar '18

30 Mar '18

This enables/disables and sets auxiliary clock at 25Mhz. It uses common clock framework for proper ref counting. This approach will save power in comparison to keeping it always On in firmware. V2: Correcting the pin to OSCOUT1 from OSCOUT2 V3: Fix error/warnings from kbuild test V4: Fix build errors for platform which do not support CONFIG_COMMON_CLK TEST= aplay -vv <file> check register to see clock enabled kill aplay check register to see clock disabled Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> Acked-by: Alex Deucher <alexander.deucher(a)amd.com> --- sound/soc/amd/acp-da7219-max98357a.c | 144 ++++++++++++++++++++++++++++++++++- 1 file changed, 142 insertions(+), 2 deletions(-) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index 99c6b5c..3c77803 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -30,10 +30,13 @@ #include <sound/soc-dapm.h> #include <sound/jack.h> #include <linux/clk.h> +#include <linux/clkdev.h> +#include <linux/clk-provider.h> #include <linux/gpio.h> #include <linux/module.h> #include <linux/i2c.h> #include <linux/acpi.h> +#include <linux/types.h> #include "../codecs/da7219.h" #include "../codecs/da7219-aad.h" @@ -41,6 +44,20 @@ #define CZ_PLAT_CLK 24000000 #define MCLK_RATE 24576000 #define DUAL_CHANNEL 2 +#define CLKDRVSTR2 0x28 +#define MISCCLKCNTL1 0x40 +#define OSCCLKENB 2 +#define OSCOUT1CLK25MHZ 16 + +struct cz_clock { + const char* acp_clks_name; +#ifdef CONFIG_COMMON_CLK + struct clk_hw acp_clks_hw; +#endif + struct clk_lookup *acp_clks_lookup; + struct clk *acp_clks; + void __iomem *res_base; +}; static struct snd_soc_jack cz_jack; struct clk *da7219_dai_clk; @@ -91,6 +108,8 @@ static int cz_da7219_hw_params(struct snd_pcm_substream *substream, { int ret = 0; struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_card *card = rtd->card; + struct clk *acpd7219_clk; ret = clk_prepare_enable(da7219_dai_clk); if (ret < 0) { @@ -98,13 +117,27 @@ static int cz_da7219_hw_params(struct snd_pcm_substream *substream, return ret; } + acpd7219_clk = clk_get(card->dev, "acpd7219-clks"); + ret = clk_prepare_enable(acpd7219_clk); + if (ret < 0) { + dev_err(rtd->dev, "can't enable oscillator clock %d\n", ret); + return ret; + } + return ret; } static int cz_da7219_hw_free(struct snd_pcm_substream *substream) { + struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_card *card = rtd->card; + struct clk *acpd7219_clk; + clk_disable_unprepare(da7219_dai_clk); + acpd7219_clk = clk_get(card->dev, "acpd7219-clks"); + clk_disable_unprepare(acpd7219_clk); + return 0; } @@ -237,9 +270,113 @@ static int cz_fe_startup(struct snd_pcm_substream *substream) .num_controls = ARRAY_SIZE(cz_mc_controls), }; +#ifdef CONFIG_COMMON_CLK +static int acpd7219_clks_prepare(struct clk_hw *hw) +{ + u32 reg_val; + struct cz_clock *cz_clock_obj = + container_of(hw, struct cz_clock, acp_clks_hw); + void __iomem *base = cz_clock_obj->res_base; + + reg_val = readl(base + MISCCLKCNTL1); + reg_val &= ~(0x1 << OSCCLKENB); + writel(reg_val, base + MISCCLKCNTL1); + reg_val = readl(base + CLKDRVSTR2); + reg_val |= (0x1 << OSCOUT1CLK25MHZ); + writel(reg_val, base + CLKDRVSTR2); + + return 0; +} + +static void acpd7219_clks_unprepare(struct clk_hw *hw) +{ + u32 reg_val; + struct cz_clock *cz_clock_obj = + container_of(hw, struct cz_clock, acp_clks_hw); + void __iomem *base = cz_clock_obj->res_base; + + reg_val = readl(base + MISCCLKCNTL1); + reg_val |= (0x1 << OSCCLKENB); + writel(reg_val, base + MISCCLKCNTL1); +} + +static int acpd7219_clks_is_enabled(struct clk_hw *hw) +{ + u32 reg_val; + struct cz_clock *cz_clock_obj = + container_of(hw, struct cz_clock, acp_clks_hw); + void __iomem *base = cz_clock_obj->res_base; + + reg_val = readl(base + MISCCLKCNTL1); + + return !(reg_val & OSCCLKENB); +} + +const struct clk_ops acpd7219_clks_ops = { + .prepare = acpd7219_clks_prepare, + .unprepare = acpd7219_clks_unprepare, + .is_enabled = acpd7219_clks_is_enabled, +}; + +static int register_acpd7219_clocks(struct platform_device *pdev) +{ + struct clk_init_data init = {}; + struct clk *acp_clks; + struct clk_lookup *acp_clks_lookup; + struct cz_clock *cz_clock_obj; + struct resource *res; + struct device dev = pdev->dev; + + cz_clock_obj = kzalloc(sizeof(struct cz_clock), GFP_KERNEL); + if (!cz_clock_obj) + return -ENOMEM; + + cz_clock_obj->acp_clks_name = "acpd7219-clks"; + + init.parent_names = NULL; + init.num_parents = 0; + init.name = cz_clock_obj->acp_clks_name; + init.ops = &acpd7219_clks_ops; + cz_clock_obj->acp_clks_hw.init = &init; + + acp_clks = devm_clk_register(&dev, &cz_clock_obj->acp_clks_hw); + if (IS_ERR(acp_clks)) + { + dev_err(&dev, "Failed to register DAI clocks: %ld\n", + PTR_ERR(acp_clks)); + return -EINVAL; + } + cz_clock_obj->acp_clks = acp_clks; + + acp_clks_lookup = clkdev_create(acp_clks, cz_clock_obj->acp_clks_name, + "%s", dev_name(&dev)); + if (!acp_clks_lookup) + dev_warn(&dev, "Failed to create DAI clkdev"); + else + cz_clock_obj->acp_clks_lookup = acp_clks_lookup; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(&pdev->dev, "Failed to get misc io resource.\n"); + return -EINVAL; + } + cz_clock_obj->res_base = devm_ioremap_nocache(&pdev->dev, res->start, + resource_size(res)); + if (!cz_clock_obj->res_base) + return -ENOMEM; + + return 0; +} +#else +static int register_acpd7219_clocks(struct platform_device *pdev) +{ + return 0; +} +#endif /* CONFIG_COMMON_CLK */ + static int cz_probe(struct platform_device *pdev) { - int ret; + int ret = 0; struct snd_soc_card *card; card = &cz_card; @@ -252,7 +389,10 @@ static int cz_probe(struct platform_device *pdev) cz_card.name, ret); return ret; } - return 0; + + ret = register_acpd7219_clocks(pdev); + + return ret; } static const struct acpi_device_id cz_audio_acpi_match[] = { -- 1.9.1

4 4

[alsa-devel] Regression? No sound with HDMI audio (snd-hda-intel) with kernel 4.15(.*)
by VDR User 30 Mar '18

30 Mar '18

Hi, I upgraded my Debian Sid box from kernel 4.14.31 to 4.15.14 and I no longer get sound over HDMI with my Nividia GT430. Nvidia driver version is 390.48. Neither the Nvidia installer nor dkms makes any difference. My alsa-utils is 1.1.3-1 and my ~/.asoundrc is: ~$ cat .asoundrc pcm.!default "hdmi:NVidia,1" ~$ aplay -l **** List of PLAYBACK Hardware Devices **** card 1: NVidia [HDA NVidia], device 3: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 1: NVidia [HDA NVidia], device 7: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 1: NVidia [HDA NVidia], device 8: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 1: NVidia [HDA NVidia], device 9: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 I'm using 'speaker-test -c 2 -t wav -Dhw:CARD=1,7' for testing. After kernel 4.15.14 didn't work, I compiled kernel 4.15 and still got no audio. I then compiled kernel 4.15-rc9 and audio worked. From there I tried to bisect the exact patch that broke the audio but got the following: ~$ cd /usr/src /usr/src$ git clone https://github.com/torvalds/linux.git /usr/src$ cd linux /usr/src/linux$ git bisect start -- sound/hda sound/pci/hda /usr/src/linux$ git bisect good v4.15-rc9 /usr/src/linux$ git bisect bad v4.15 No testable commit found. Maybe you started with bad path parameters? /usr/src/linux$ I'm not sure what went wrong there, hopefully one of you reading this may have an idea. It's worth noting I upgraded another near-identical system and HDMI audio is working fine with 4.15.* on that box. That box has an Nvidia GT520 but other than that the package versions, driver version, etc. are all the same. Also, it's connected to a surround receiver whereas the non-working box is connected directly to a tv. Please let me know if any other info is needed or what I can do/try to debug this further. Any help is greatly appreciated! -Derek

1 0

Re: [alsa-devel] [PATCH] pcm_native: Remove VLA usage
by kbuild test robot 30 Mar '18

30 Mar '18

Hi Kyle, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc7] [cannot apply to sound/for-next next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kyle-Spiers/pcm_native-Remove-VLA-… config: x86_64-randconfig-x019-201812 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): In file included from include/asm-generic/bug.h:5:0, from arch/x86/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:9, from sound/core/pcm_native.c:22: sound/core/pcm_native.c: In function 'constrain_params_by_rules': include/linux/compiler.h:58:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) ) ^~~~~~~~~~ >> sound/core/pcm_native.c:401:3: note: in expansion of macro 'if' if (changed < 0) ^~ sound/core/pcm_native.c:403:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' return changed; ^~~~~~ vim +/if +401 sound/core/pcm_native.c ^1da177e4 Linus Torvalds 2005-04-16 319 9cc07f55d Takashi Sakamoto 2017-06-09 320 static int constrain_params_by_rules(struct snd_pcm_substream *substream, 877211f5e Takashi Iwai 2005-11-17 321 struct snd_pcm_hw_params *params) ^1da177e4 Linus Torvalds 2005-04-16 322 { 9cc07f55d Takashi Sakamoto 2017-06-09 323 struct snd_pcm_hw_constraints *constrs = 9cc07f55d Takashi Sakamoto 2017-06-09 324 &substream->runtime->hw_constraints; ^1da177e4 Linus Torvalds 2005-04-16 325 unsigned int k; 16c438ade Kyle Spiers 2018-03-28 326 unsigned int *rstamps; ^1da177e4 Linus Torvalds 2005-04-16 327 unsigned int vstamps[SNDRV_PCM_HW_PARAM_LAST_INTERVAL + 1]; d81052f92 Takashi Sakamoto 2017-06-09 328 unsigned int stamp; a1c06e39a Takashi Sakamoto 2017-06-09 329 struct snd_pcm_hw_rule *r; a1c06e39a Takashi Sakamoto 2017-06-09 330 unsigned int d; 9cc07f55d Takashi Sakamoto 2017-06-09 331 struct snd_mask old_mask; 9cc07f55d Takashi Sakamoto 2017-06-09 332 struct snd_interval old_interval; a1c06e39a Takashi Sakamoto 2017-06-09 333 bool again; 9cc07f55d Takashi Sakamoto 2017-06-09 334 int changed; ^1da177e4 Linus Torvalds 2005-04-16 335 d81052f92 Takashi Sakamoto 2017-06-09 336 /* d81052f92 Takashi Sakamoto 2017-06-09 337 * Each application of rule has own sequence number. d81052f92 Takashi Sakamoto 2017-06-09 338 * d81052f92 Takashi Sakamoto 2017-06-09 339 * Each member of 'rstamps' array represents the sequence number of d81052f92 Takashi Sakamoto 2017-06-09 340 * recent application of corresponding rule. d81052f92 Takashi Sakamoto 2017-06-09 341 */ 16c438ade Kyle Spiers 2018-03-28 342 16c438ade Kyle Spiers 2018-03-28 343 rstamps = kcalloc(constrs->rules_num, sizeof(*rstamps), GFP_KERNEL); d81052f92 Takashi Sakamoto 2017-06-09 344 d81052f92 Takashi Sakamoto 2017-06-09 345 /* d81052f92 Takashi Sakamoto 2017-06-09 346 * Each member of 'vstamps' array represents the sequence number of d81052f92 Takashi Sakamoto 2017-06-09 347 * recent application of rule in which corresponding parameters were d81052f92 Takashi Sakamoto 2017-06-09 348 * changed. d81052f92 Takashi Sakamoto 2017-06-09 349 * d81052f92 Takashi Sakamoto 2017-06-09 350 * In initial state, elements corresponding to parameters requested by d81052f92 Takashi Sakamoto 2017-06-09 351 * a caller is 1. For unrequested parameters, corresponding members d81052f92 Takashi Sakamoto 2017-06-09 352 * have 0 so that the parameters are never changed anymore. d81052f92 Takashi Sakamoto 2017-06-09 353 */ ^1da177e4 Linus Torvalds 2005-04-16 354 for (k = 0; k <= SNDRV_PCM_HW_PARAM_LAST_INTERVAL; k++) ^1da177e4 Linus Torvalds 2005-04-16 355 vstamps[k] = (params->rmask & (1 << k)) ? 1 : 0; d81052f92 Takashi Sakamoto 2017-06-09 356 d81052f92 Takashi Sakamoto 2017-06-09 357 /* Due to the above design, actual sequence number starts at 2. */ d81052f92 Takashi Sakamoto 2017-06-09 358 stamp = 2; 0d4e39996 Takashi Sakamoto 2017-06-09 359 retry: d81052f92 Takashi Sakamoto 2017-06-09 360 /* Apply all rules in order. */ a1c06e39a Takashi Sakamoto 2017-06-09 361 again = false; ^1da177e4 Linus Torvalds 2005-04-16 362 for (k = 0; k < constrs->rules_num; k++) { a1c06e39a Takashi Sakamoto 2017-06-09 363 r = &constrs->rules[k]; d81052f92 Takashi Sakamoto 2017-06-09 364 d81052f92 Takashi Sakamoto 2017-06-09 365 /* d81052f92 Takashi Sakamoto 2017-06-09 366 * Check condition bits of this rule. When the rule has d81052f92 Takashi Sakamoto 2017-06-09 367 * some condition bits, parameter without the bits is d81052f92 Takashi Sakamoto 2017-06-09 368 * never processed. SNDRV_PCM_HW_PARAMS_NO_PERIOD_WAKEUP d81052f92 Takashi Sakamoto 2017-06-09 369 * is an example of the condition bits. d81052f92 Takashi Sakamoto 2017-06-09 370 */ ^1da177e4 Linus Torvalds 2005-04-16 371 if (r->cond && !(r->cond & params->flags)) ^1da177e4 Linus Torvalds 2005-04-16 372 continue; d81052f92 Takashi Sakamoto 2017-06-09 373 d81052f92 Takashi Sakamoto 2017-06-09 374 /* d81052f92 Takashi Sakamoto 2017-06-09 375 * The 'deps' array includes maximum three dependencies d81052f92 Takashi Sakamoto 2017-06-09 376 * to SNDRV_PCM_HW_PARAM_XXXs for this rule. The fourth d81052f92 Takashi Sakamoto 2017-06-09 377 * member of this array is a sentinel and should be d81052f92 Takashi Sakamoto 2017-06-09 378 * negative value. d81052f92 Takashi Sakamoto 2017-06-09 379 * d81052f92 Takashi Sakamoto 2017-06-09 380 * This rule should be processed in this time when dependent d81052f92 Takashi Sakamoto 2017-06-09 381 * parameters were changed at former applications of the other d81052f92 Takashi Sakamoto 2017-06-09 382 * rules. d81052f92 Takashi Sakamoto 2017-06-09 383 */ ^1da177e4 Linus Torvalds 2005-04-16 384 for (d = 0; r->deps[d] >= 0; d++) { d656b4a65 Takashi Sakamoto 2017-06-09 385 if (vstamps[r->deps[d]] > rstamps[k]) ^1da177e4 Linus Torvalds 2005-04-16 386 break; ^1da177e4 Linus Torvalds 2005-04-16 387 } d656b4a65 Takashi Sakamoto 2017-06-09 388 if (r->deps[d] < 0) ^1da177e4 Linus Torvalds 2005-04-16 389 continue; be4e31dab Takashi Sakamoto 2017-06-07 390 be4e31dab Takashi Sakamoto 2017-06-07 391 if (trace_hw_mask_param_enabled()) { be4e31dab Takashi Sakamoto 2017-06-07 392 if (hw_is_mask(r->var)) be4e31dab Takashi Sakamoto 2017-06-07 393 old_mask = *hw_param_mask(params, r->var); ^1da177e4 Linus Torvalds 2005-04-16 394 } be4e31dab Takashi Sakamoto 2017-06-07 395 if (trace_hw_interval_param_enabled()) { be4e31dab Takashi Sakamoto 2017-06-07 396 if (hw_is_interval(r->var)) be4e31dab Takashi Sakamoto 2017-06-07 397 old_interval = *hw_param_interval(params, r->var); ^1da177e4 Linus Torvalds 2005-04-16 398 } c6706de0c Takashi Sakamoto 2017-06-07 399 ^1da177e4 Linus Torvalds 2005-04-16 400 changed = r->func(params, r); f74ae15fe Takashi Sakamoto 2017-06-11 @401 if (changed < 0) 16c438ade Kyle Spiers 2018-03-28 402 kfree(rstamps); f74ae15fe Takashi Sakamoto 2017-06-11 403 return changed; c6706de0c Takashi Sakamoto 2017-06-07 404 d81052f92 Takashi Sakamoto 2017-06-09 405 /* 82e7d5012 Takashi Sakamoto 2017-06-11 406 * When the parameter is changed, notify it to the caller d81052f92 Takashi Sakamoto 2017-06-09 407 * by corresponding returned bit, then preparing for next d81052f92 Takashi Sakamoto 2017-06-09 408 * iteration. d81052f92 Takashi Sakamoto 2017-06-09 409 */ ^1da177e4 Linus Torvalds 2005-04-16 410 if (changed && r->var >= 0) { 82e7d5012 Takashi Sakamoto 2017-06-11 411 if (hw_is_mask(r->var)) { 82e7d5012 Takashi Sakamoto 2017-06-11 412 trace_hw_mask_param(substream, r->var, 82e7d5012 Takashi Sakamoto 2017-06-11 413 k + 1, &old_mask, 82e7d5012 Takashi Sakamoto 2017-06-11 414 hw_param_mask(params, r->var)); ^1da177e4 Linus Torvalds 2005-04-16 415 } 82e7d5012 Takashi Sakamoto 2017-06-11 416 if (hw_is_interval(r->var)) { 82e7d5012 Takashi Sakamoto 2017-06-11 417 trace_hw_interval_param(substream, r->var, 82e7d5012 Takashi Sakamoto 2017-06-11 418 k + 1, &old_interval, 82e7d5012 Takashi Sakamoto 2017-06-11 419 hw_param_interval(params, r->var)); ^1da177e4 Linus Torvalds 2005-04-16 420 } 82e7d5012 Takashi Sakamoto 2017-06-11 421 ^1da177e4 Linus Torvalds 2005-04-16 422 params->cmask |= (1 << r->var); ^1da177e4 Linus Torvalds 2005-04-16 423 vstamps[r->var] = stamp; a1c06e39a Takashi Sakamoto 2017-06-09 424 again = true; ^1da177e4 Linus Torvalds 2005-04-16 425 } f74ae15fe Takashi Sakamoto 2017-06-11 426 82e7d5012 Takashi Sakamoto 2017-06-11 427 rstamps[k] = stamp++; ^1da177e4 Linus Torvalds 2005-04-16 428 } 0d4e39996 Takashi Sakamoto 2017-06-09 429 d81052f92 Takashi Sakamoto 2017-06-09 430 /* Iterate to evaluate all rules till no parameters are changed. */ 0d4e39996 Takashi Sakamoto 2017-06-09 431 if (again) 0d4e39996 Takashi Sakamoto 2017-06-09 432 goto retry; 9cc07f55d Takashi Sakamoto 2017-06-09 433 16c438ade Kyle Spiers 2018-03-28 434 kfree(rstamps); 9cc07f55d Takashi Sakamoto 2017-06-09 435 return 0; ^1da177e4 Linus Torvalds 2005-04-16 436 } 9cc07f55d Takashi Sakamoto 2017-06-09 437 :::::: The code at line 401 was first introduced by commit :::::: f74ae15fe3da7905b78e986ad906a333587cf160 ALSA: pcm: return error immediately for parameters handling :::::: TO: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> :::::: CC: Takashi Iwai <tiwai(a)suse.de> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0