March 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] slimbus: core: use put_device() instead of kfree()
by Arvind Yadav 07 Mar '18

07 Mar '18

Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav <arvind.yadav.cs(a)gmail.com> --- drivers/slimbus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 4988a8f..7ddfc67 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -141,7 +141,7 @@ static struct slim_device *slim_alloc_device(struct slim_controller *ctrl, sbdev->e_addr = *eaddr; ret = slim_add_device(ctrl, sbdev, node); if (ret) { - kfree(sbdev); + put_device(&sbdev->dev); return NULL; } -- 1.9.1

2 1

Re: [alsa-devel] Dell new AIO platform
by Hui Wang 07 Mar '18

07 Mar '18

This is the alsa-info.txt for the machine of zuma-p (the machine kailang sent the patch for): https://pastebin.ubuntu.com/p/V4QgWWY5Nj/ And we have a similar bug with this one, but it is not for output, it is for input. On one of Dell desktops, there is no internal microphone, the only input devices are "Headphone Mic=0x1a" and "Headset Mic=0x19", so the imux_pins[spec->gen.cur_mux[0]] is headphone mic or headset mic, let us suppose it is headset mic, and we are unlucky that the auto-mute is disabled, and then unplug a headset from the jack, the audio is now in unplugged mode (alc_headset_mode_unplugged(codec);), then next time we plug the headset into the jack, the "what-did-you-plug" dialogue will pop up, we select headset-mic, since the imux_pins[spec->gen.cur_mux[0]] is already the headset mic (not internal microphone since there is no internal microphone on this machine), the alc_update_headset_mode() will not be called and then alc_determine_headset_type(), alc_headset_mode_ctia() and alc_headset_mode_omtp() will not be called, as a result the headset mic can't record sound. So far, I have no idea how to fix this problem. And the alsa-info.txt for my machine is as below shown: https://pastebin.ubuntu.com/p/SNMNjbRgnT/ Regards, Hui. On 2018年03月06日 17:13, Kailang wrote: > > >> -----Original Message----- >> From: Takashi Iwai [mailto:tiwai@suse.de] >> Sent: Tuesday, March 06, 2018 5:10 PM >> To: Kailang >> Cc: Hui Wang; (alsa-devel(a)alsa-project.org)" >> Subject: Re: Dell new AIO platform >> >> On Tue, 06 Mar 2018 10:03:38 +0100, >> Kailang wrote: >>> >>> >>>> -----Original Message----- >>>> From: Takashi Iwai [mailto:tiwai@suse.de] >>>> Sent: Tuesday, March 06, 2018 4:49 PM >>>> To: Kailang >>>> Cc: (alsa-devel(a)alsa-project.org) >>>> Subject: Re: Dell new AIO platform >>>> >>>> On Tue, 06 Mar 2018 08:54:39 +0100, >>>> Kailang wrote: >>>>> Hi Takashi, >>>>> >>>>> This platform was only one phone Jack. >>>>> Add dummy lineout verb to fix automute mode disable. >>>>> This just the workarround. >>>> I'm not sure why this phantom line pin is needed. >>>> What happens without that? >>> Looks like I find the root cause for this issue, since >> there is only one output device (headphone）， so the Auto-mute >> is not supported on this machine, as a result, when users >> plug headphone to the jack, audomute_hook or hp_automute_hook >> will not be called, then the alc_update_headset_mode() will >> not be called, and alc_headset_mode_default() will not be >> called. the headset jack is always in the >> alc_headset_mode_unplugged() state. >> >> OK, now understood. >> >> I can take the patch as a tentative workaround. >> But for the proper fix, could you give alsa-info.sh output? > I had no machine in my site. > > Hi Hui Wang, > > Could you help to send alsa-info.sh output to Takashi? > >> >> thanks, >> >> Takashi >> >> ------Please consider the environment before printing this e-mail.

1 1

[alsa-devel] [PATCH] ALSA: hda/realtek - Fix dock line-out volume on Dell Precision 7520
by Takashi Iwai 06 Mar '18

06 Mar '18

The dock line-out pin (NID 0x17 of ALC3254 codec) on Dell Precision 7520 may route to three different DACs, 0x02, 0x03 and 0x06. The first two DACS have the volume amp controls while the last one doesn't. And unfortunately, the auto-parser assigns this pin to DAC3, resulting in the non-working volume control for the line out. Fix it by disabling the routing to DAC3 on the corresponding pin. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199029 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 85d9efe343d2..60f1b9524957 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5274,6 +5274,16 @@ static void alc298_fixup_speaker_volume(struct hda_codec *codec, } } +/* disable DAC3 (0x06) selection on NID 0x17 as it has no volume amp control */ +static void alc295_fixup_disable_dac3(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + if (action == HDA_FIXUP_ACT_PRE_PROBE) { + hda_nid_t conn[2] = { 0x02, 0x03 }; + snd_hda_override_conn_list(codec, 0x17, 2, conn); + } +} + /* Hook to update amp GPIO4 for automute */ static void alc280_hp_gpio4_automute_hook(struct hda_codec *codec, struct hda_jack_callback *jack) @@ -5466,6 +5476,7 @@ enum { ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY, ALC255_FIXUP_DELL_SPK_NOISE, ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, + ALC295_FIXUP_DISABLE_DAC3, ALC280_FIXUP_HP_HEADSET_MIC, ALC221_FIXUP_HP_FRONT_MIC, ALC292_FIXUP_TPT460, @@ -6200,6 +6211,10 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC298_FIXUP_DELL_AIO_MIC_NO_PRESENCE, }, + [ALC295_FIXUP_DISABLE_DAC3] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc295_fixup_disable_dac3, + }, [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -6390,6 +6405,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE), SND_PCI_QUIRK(0x1028, 0x075b, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE), SND_PCI_QUIRK(0x1028, 0x075d, "Dell AIO", ALC298_FIXUP_SPK_VOLUME), + SND_PCI_QUIRK(0x1028, 0x07b0, "Dell Precision 7520", ALC295_FIXUP_DISABLE_DAC3), SND_PCI_QUIRK(0x1028, 0x0798, "Dell Inspiron 17 7000 Gaming", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER), SND_PCI_QUIRK(0x1028, 0x080c, "Dell WYSE", ALC225_FIXUP_DELL_WYSE_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x082a, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE), -- 2.16.2

1 0

[alsa-devel] [PATCH] ALSA: hda/realtek: Limit mic boost on T480
by Benjamin Berg 06 Mar '18

06 Mar '18

The internal mic boost on the T480 is too high. Fix this by applying the ALC269_FIXUP_LIMIT_INT_MIC_BOOST fixup to the machine to limit the gain. Signed-off-by: Benjamin Berg <bberg(a)redhat.com> Tested-by: Benjamin Berg <bberg(a)redhat.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index ce28f7ce64e6..8467ce3db767 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6510,6 +6510,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), + SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), -- 2.14.3

3 8

Re: [alsa-devel] Dell new AIO platform
by Hui Wang 06 Mar '18

06 Mar '18

On 2018年03月06日 17:13, Kailang wrote: > > >> -----Original Message----- >> From: Takashi Iwai [mailto:tiwai@suse.de] >> Sent: Tuesday, March 06, 2018 5:10 PM >> To: Kailang >> Cc: Hui Wang; (alsa-devel(a)alsa-project.org) >> Subject: Re: Dell new AIO platform >> >> On Tue, 06 Mar 2018 10:03:38 +0100, >> Kailang wrote: >>> >>> >>>> -----Original Message----- >>>> From: Takashi Iwai [mailto:tiwai@suse.de] >>>> Sent: Tuesday, March 06, 2018 4:49 PM >>>> To: Kailang >>>> Cc: (alsa-devel(a)alsa-project.org) >>>> Subject: Re: Dell new AIO platform >>>> >>>> On Tue, 06 Mar 2018 08:54:39 +0100, >>>> Kailang wrote: >>>>> Hi Takashi, >>>>> >>>>> This platform was only one phone Jack. >>>>> Add dummy lineout verb to fix automute mode disable. >>>>> This just the workarround. >>>> I'm not sure why this phantom line pin is needed. >>>> What happens without that? >>> Looks like I find the root cause for this issue, since >> there is only one output device (headphone）， so the Auto-mute >> is not supported on this machine, as a result, when users >> plug headphone to the jack, audomute_hook or hp_automute_hook >> will not be called, then the alc_update_headset_mode() will >> not be called, and alc_headset_mode_default() will not be >> called. the headset jack is always in the >> alc_headset_mode_unplugged() state. >> >> OK, now understood. >> >> I can take the patch as a tentative workaround. >> But for the proper fix, could you give alsa-info.sh output? > I had no machine in my site. > > Hi Hui Wang, > > Could you help to send alsa-info.sh output to Takashi? OK, I will collect the alsa-info.txt tomorrow. Regards, Hui. >> >> thanks, >> >> Takashi >> >> ------Please consider the environment before printing this e-mail.

1 0

Re: [alsa-devel] Dell new AIO platform
by Takashi Iwai 06 Mar '18

06 Mar '18

On Tue, 06 Mar 2018 10:24:55 +0100, Kailang wrote: > > > > > -----Original Message----- > > From: Takashi Iwai [mailto:tiwai@suse.de] > > Sent: Tuesday, March 06, 2018 5:16 PM > > To: Kailang > > Cc: Hui Wang; (alsa-devel(a)alsa-project.org) > > Subject: Re: Dell new AIO platform > > > > On Tue, 06 Mar 2018 10:13:16 +0100, > > Kailang wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Takashi Iwai [mailto:tiwai@suse.de] > > > > Sent: Tuesday, March 06, 2018 5:10 PM > > > > To: Kailang > > > > Cc: Hui Wang; (alsa-devel(a)alsa-project.org) > > > > Subject: Re: Dell new AIO platform > > > > > > > > On Tue, 06 Mar 2018 10:03:38 +0100, > > > > Kailang wrote: > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Takashi Iwai [mailto:tiwai@suse.de] > > > > > > Sent: Tuesday, March 06, 2018 4:49 PM > > > > > > To: Kailang > > > > > > Cc: (alsa-devel(a)alsa-project.org) > > > > > > Subject: Re: Dell new AIO platform > > > > > > > > > > > > On Tue, 06 Mar 2018 08:54:39 +0100, Kailang wrote: > > > > > > > > > > > > > > Hi Takashi, > > > > > > > > > > > > > > This platform was only one phone Jack. > > > > > > > Add dummy lineout verb to fix automute mode disable. > > > > > > > This just the workarround. > > > > > > > > > > > > I'm not sure why this phantom line pin is needed. > > > > > > What happens without that? > > > > > > > > > > Looks like I find the root cause for this issue, since > > > > there is only one output device (headphone）， so the > > Auto-mute is not > > > > supported on this machine, as a result, when users plug > > headphone to > > > > the jack, audomute_hook or hp_automute_hook will not be > > called, then > > > > the alc_update_headset_mode() will not be called, and > > > > alc_headset_mode_default() will not be called. the > > headset jack is > > > > always in the > > > > alc_headset_mode_unplugged() state. > > > > > > > > OK, now understood. > > > > > > > > I can take the patch as a tentative workaround. > > > > But for the proper fix, could you give alsa-info.sh output? > > > > > > I had no machine in my site. > > > > > > Hi Hui Wang, > > > > > > Could you help to send alsa-info.sh output to Takashi? > > > > Meanwhile, I found there is another quirk > > ALC274_FIXUP_DELL_AIO_LINEOUT_VERB, which looks like serving > > for a similar purpose, but with more stuff (e.g. bind-dac). > > > No, this issue was not the same. > ALC274_FIXUP_DELL_AIO_LINEOUT_VERB ==> this lineout was true pin. > Bios verb table can't fill this verb. So, it need driver to fill it. OK, I'll add more information about that in the changelog. thanks, Takashi

1 0

Re: [alsa-devel] Dell new AIO platform
by Takashi Iwai 06 Mar '18

06 Mar '18

On Tue, 06 Mar 2018 10:13:16 +0100, Kailang wrote: > > > > > -----Original Message----- > > From: Takashi Iwai [mailto:tiwai@suse.de] > > Sent: Tuesday, March 06, 2018 5:10 PM > > To: Kailang > > Cc: Hui Wang; (alsa-devel(a)alsa-project.org) > > Subject: Re: Dell new AIO platform > > > > On Tue, 06 Mar 2018 10:03:38 +0100, > > Kailang wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Takashi Iwai [mailto:tiwai@suse.de] > > > > Sent: Tuesday, March 06, 2018 4:49 PM > > > > To: Kailang > > > > Cc: (alsa-devel(a)alsa-project.org) > > > > Subject: Re: Dell new AIO platform > > > > > > > > On Tue, 06 Mar 2018 08:54:39 +0100, > > > > Kailang wrote: > > > > > > > > > > Hi Takashi, > > > > > > > > > > This platform was only one phone Jack. > > > > > Add dummy lineout verb to fix automute mode disable. > > > > > This just the workarround. > > > > > > > > I'm not sure why this phantom line pin is needed. > > > > What happens without that? > > > > > > Looks like I find the root cause for this issue, since > > there is only one output device (headphone）， so the Auto-mute > > is not supported on this machine, as a result, when users > > plug headphone to the jack, audomute_hook or hp_automute_hook > > will not be called, then the alc_update_headset_mode() will > > not be called, and alc_headset_mode_default() will not be > > called. the headset jack is always in the > > alc_headset_mode_unplugged() state. > > > > OK, now understood. > > > > I can take the patch as a tentative workaround. > > But for the proper fix, could you give alsa-info.sh output? > > I had no machine in my site. > > Hi Hui Wang, > > Could you help to send alsa-info.sh output to Takashi? Meanwhile, I found there is another quirk ALC274_FIXUP_DELL_AIO_LINEOUT_VERB, which looks like serving for a similar purpose, but with more stuff (e.g. bind-dac). thanks, Takashi

1 0

Re: [alsa-devel] Dell new AIO platform
by Takashi Iwai 06 Mar '18

06 Mar '18

On Tue, 06 Mar 2018 10:03:38 +0100, Kailang wrote: > > > > > -----Original Message----- > > From: Takashi Iwai [mailto:tiwai@suse.de] > > Sent: Tuesday, March 06, 2018 4:49 PM > > To: Kailang > > Cc: (alsa-devel(a)alsa-project.org) > > Subject: Re: Dell new AIO platform > > > > On Tue, 06 Mar 2018 08:54:39 +0100, > > Kailang wrote: > > > > > > Hi Takashi, > > > > > > This platform was only one phone Jack. > > > Add dummy lineout verb to fix automute mode disable. > > > This just the workarround. > > > > I'm not sure why this phantom line pin is needed. > > What happens without that? > > Looks like I find the root cause for this issue, since there is only one output device (headphone）， so the Auto-mute is not supported on this machine, as a result, when users plug headphone to the jack, audomute_hook or hp_automute_hook will not be called, then the alc_update_headset_mode() will not be called, and alc_headset_mode_default() will not be called. the headset jack is always in the alc_headset_mode_unplugged() state. OK, now understood. I can take the patch as a tentative workaround. But for the proper fix, could you give alsa-info.sh output? thanks, Takashi

1 0

[alsa-devel] Dell New WYSE enable headset mode
by Kailang 06 Mar '18

06 Mar '18

Hi Takashi, Attach was new Dell WYSE platform. This patch will enable headset mode for it. BR, Kailang

2 1

Re: [alsa-devel] Dell new AIO platform
by Takashi Iwai 06 Mar '18

06 Mar '18

On Tue, 06 Mar 2018 08:54:39 +0100, Kailang wrote: > > Hi Takashi, > > This platform was only one phone Jack. > Add dummy lineout verb to fix automute mode disable. > This just the workarround. I'm not sure why this phantom line pin is needed. What happens without that? thanks, Takashi > > This patch was test by Hui Wang@canonical > > Many Thanks. > > BR, > Kailang > [1.2 <text/html; us-ascii (quoted-printable)>] > > [2 0000-dell-0x0873-headset-mode-support.patch <application/octet-stream (base64)>] >

1 0