December 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] KASAN: use-after-free Read in delete_and_unsubscribe_port
by syzbot 29 Dec '18

29 Dec '18

Hello, syzbot found the following crash on: HEAD commit: 8fe28cb58bcb Linux 4.20 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=166859b3400000 kernel config: https://syzkaller.appspot.com/x/.config?x=7d581260bae0899a dashboard link: https://syzkaller.appspot.com/bug?extid=9917f000776fb73fa40f compiler: gcc (GCC) 8.0.1 20180413 (experimental) Unfortunately, I don't have any reproducer for this crash yet. IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+9917f000776fb73fa40f(a)syzkaller.appspotmail.com ================================================================== BUG: KASAN: use-after-free in __read_once_size include/linux/compiler.h:191 [inline] BUG: KASAN: use-after-free in list_empty include/linux/list.h:226 [inline] BUG: KASAN: use-after-free in delete_and_unsubscribe_port+0x5d7/0x6d0 sound/core/seq/seq_ports.c:548 Read of size 8 at addr ffff8881d1c05590 by task syz-executor1/6930 CPU: 0 PID: 6930 Comm: syz-executor1 Not tainted 4.20.0 #167 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1d3/0x2c6 lib/dump_stack.c:113 print_address_description.cold.8+0x9/0x1ff mm/kasan/report.c:256 kasan_report_error mm/kasan/report.c:354 [inline] kasan_report.cold.9+0x242/0x309 mm/kasan/report.c:412 __asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:433 __read_once_size include/linux/compiler.h:191 [inline] list_empty include/linux/list.h:226 [inline] delete_and_unsubscribe_port+0x5d7/0x6d0 sound/core/seq/seq_ports.c:548 snd_seq_port_disconnect+0x17b/0x280 sound/core/seq/seq_ports.c:628 snd_seq_ioctl_unsubscribe_port+0x1d8/0x310 sound/core/seq/seq_clientmgr.c:1499 snd_seq_ioctl+0x253/0x440 sound/core/seq/seq_clientmgr.c:2138 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0x1de/0x1790 fs/ioctl.c:696 ksys_ioctl+0xa9/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x457759 Code: fd b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007f36626cac78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000457759 RDX: 00000000200001c0 RSI: 0000000040505331 RDI: 0000000000000003 RBP: 000000000073bf00 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f36626cb6d4 R13: 00000000004ca358 R14: 00000000004d35d0 R15: 00000000ffffffff Allocated by task 6924: save_stack+0x43/0xd0 mm/kasan/kasan.c:448 set_track mm/kasan/kasan.c:460 [inline] kasan_kmalloc+0xc7/0xe0 mm/kasan/kasan.c:553 kmem_cache_alloc_trace+0x152/0x750 mm/slab.c:3620 kmalloc include/linux/slab.h:546 [inline] kzalloc include/linux/slab.h:741 [inline] snd_seq_port_connect+0xe0/0x760 sound/core/seq/seq_ports.c:571 snd_seq_ioctl_subscribe_port+0x1d8/0x310 sound/core/seq/seq_clientmgr.c:1458 snd_seq_ioctl+0x253/0x440 sound/core/seq/seq_clientmgr.c:2138 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0x1de/0x1790 fs/ioctl.c:696 ksys_ioctl+0xa9/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe Freed by task 6931: save_stack+0x43/0xd0 mm/kasan/kasan.c:448 set_track mm/kasan/kasan.c:460 [inline] __kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521 kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528 __cache_free mm/slab.c:3498 [inline] kfree+0xcf/0x230 mm/slab.c:3817 snd_seq_port_disconnect+0x205/0x280 sound/core/seq/seq_ports.c:632 snd_seq_ioctl_unsubscribe_port+0x1d8/0x310 sound/core/seq/seq_clientmgr.c:1499 snd_seq_ioctl+0x253/0x440 sound/core/seq/seq_clientmgr.c:2138 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0x1de/0x1790 fs/ioctl.c:696 ksys_ioctl+0xa9/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe The buggy address belongs to the object at ffff8881d1c05540 which belongs to the cache kmalloc-128 of size 128 The buggy address is located 80 bytes inside of 128-byte region [ffff8881d1c05540, ffff8881d1c055c0) The buggy address belongs to the page: page:ffffea0007470140 count:1 mapcount:0 mapping:ffff8881da800640 index:0xffff8881d1c05b40 flags: 0x2fffc0000000200(slab) raw: 02fffc0000000200 ffffea0006fb09c8 ffffea0006f38908 ffff8881da800640 raw: ffff8881d1c05b40 ffff8881d1c05000 000000010000000e 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff8881d1c05480: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff8881d1c05500: fc fc fc fc fc fc fc fc fb fb fb fb fb fb fb fb > ffff8881d1c05580: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc ^ ffff8881d1c05600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff8881d1c05680: fc fc fc fc fc fc fc fc fb fb fb fb fb fb fb fb ================================================================== --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot.

1 0

[alsa-devel] Coherence of status structure after SYNC_PTR
by Ricardo Biehl Pasquali 28 Dec '18

28 Dec '18

In alsa-lib, pcm_hw, htimestamp(), avail is rechecked to ensure a valid timestamp. I guess this is for the case when status is mmaped, when hardware pointer is read, an interrupt occur, and timestamp is read. Does SYNC_PTR ioctl always fill a coherent status? Cheers! pasquali

2 3

[alsa-devel] Codec tlv320aic3401 and SoC im6ul (no i2c input/output, aplay hang up)
by tmptmp15 27 Dec '18

27 Dec '18

Hello ! I try make kernel with ALSA drivers for tlv320aic3401. Platform arm / imx6ul. CPU: Freescale i.MX6UL rev1.2 528 MHz (running at 396 MHz) Kernel config: $grep SND_ .config |grep -v ^# CONFIG_SND_TIMER=y CONFIG_SND_PCM=y CONFIG_SND_DMAENGINE_PCM=y CONFIG_SND_HWDEP=y CONFIG_SND_RAWMIDI=y CONFIG_SND_COMPRESS_OFFLOAD=y CONFIG_SND_JACK=y CONFIG_SND_SUPPORT_OLD_API=y CONFIG_SND_VERBOSE_PROCFS=y CONFIG_SND_VERBOSE_PRINTK=y CONFIG_SND_DEBUG=y CONFIG_SND_DEBUG_VERBOSE=y CONFIG_SND_ARM=y CONFIG_SND_SPI=y CONFIG_SND_USB=y CONFIG_SND_USB_AUDIO=y CONFIG_SND_SOC=y CONFIG_SND_SOC_GENERIC_DMAENGINE_PCM=y CONFIG_SND_SOC_FSL_ASRC=y CONFIG_SND_SOC_FSL_SAI=y CONFIG_SND_SOC_FSL_SSI=y CONFIG_SND_SOC_FSL_ESAI=y CONFIG_SND_SOC_IMX_PCM_DMA=y CONFIG_SND_SOC_IMX_AUDMUX=y CONFIG_SND_IMX_SOC=y CONFIG_SND_SOC_IMX_PCM_FIQ=y CONFIG_SND_SOC_FSL_ASOC_CARD=y CONFIG_SND_SOC_IMX_TLV320AIC3X=y CONFIG_SND_SOC_I2C_AND_SPI=y CONFIG_SND_SOC_TLV320AIC3X=y $uname -a Linux myd-y6ul14x14 4.1.15+ #20 SMP PREEMPT Thu Dec 27 16:00:37 +07 2018 armv7l GNU/Linux dmesg / i2c: imx-i2c 21a4000.i2c: <i2c_imx_probe> i2c i2c-1: adapter [21a4000.i2c] registered i2c i2c-1: of_i2c: walking child nodes i2c i2c-1: of_i2c: register /soc/aips-bus@02100000/i2c@021a4000/tlv320aic3104@18 i2c 1-0018: uevent i2c i2c-1: client [tlv320aic3104] registered with bus id 1-0018 i2c i2c-1: of_i2c: register /soc/aips-bus@02100000/i2c@021a4000/rtc@68 i2c 1-0068: uevent i2c i2c-1: client [ds1307] registered with bus id 1-0068 i2c i2c-1: claimed irq 228 i2c i2c-1: device resources: [mem 0x021a4000-0x021a7fff] i2c i2c-1: adapter name: "21a4000.i2c" i2c i2c-1: IMX I2C adapter registered i2c i2c-1: can't request DMA tx channel i2c i2c-1: can't use DMA I2C physic work fine: i can access to ds1307, and tlv320 may detect with i2cdetect (if disable tlv320 in DTS). On console, dmesg / tlv320: .... of_get_named_gpiod_flags: parsed 'gpio-reset' property of node '/soc/aips-bus@02100000/i2c@021a4000/tlv320aic3104@18[0]' - status (0) aic3x_i2c_probe: model=3 1-0018 supply IOVDD not found, using dummy regulator 1-0018 supply DVDD not found, using dummy regulator 1-0018 supply AVDD not found, using dummy regulator 1-0018 supply DRVDD not found, using dummy regulator i2c-core: driver [tlv320aic3x-codec] registered fsl-asrc 2034000.asrc: driver registered ... tlv320aic3x sound: tlv320aic3x-hifi <-> 202c000.sai mapping ok ... ALSA device list: #0: tlv320-audio-U .... Device Tree Source: &i2c2 { clock_frequency = <100000>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c2>; status = "okay"; codec: tlv320aic3104@18 { /* ai3x-micbias-vg = <2>; */ compatible = "ti,tlv320aic3104"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_gpio_key>; reg = <0x18>; gpio-reset = <&gpio5 0 GPIO_ACTIVE_LOW>; clocks = <&clks IMX6UL_CLK_SAI2>; clock-names = "mclk"; /* clock-frequency = <19200000>; */ status = "okay"; }; ..... }; / { ..... sound { compatible = "fsl,imx-audio-tlv320aic3x"; model = "tlv320-audio-U"; cpu-dai = <&sai2>; audio-codec = <&codec>; ssi-controller = <&sai2>; mux-int-port = <2>; /* 1, 2, 7 - SSI */ mux-ext-port = <5>; /* 3-6, IOMUX */ audio-routing = "LINE1L", "Mic Jack", "Headphone Jack", "HPLOUT", "Headphone Jack", "HPROUT", "Mic Jack", "Mic Bias"; }; ..... } Machine driver imx-audio-tlv320aic3x.c not present in kernel sources, I try some version from Inet. At any case codec driver sound/soc/codec/tlv320aic3x.c call procedure snd_soc_write() for init codec registers, but no any messages from i2c for address 0x18 in dmesg or /var/log/messages. In kernel config i2c debug messages enable: CONFIG_I2C_DEBUG_CORE=y CONFIG_I2C_DEBUG_ALGO=y CONFIG_I2C_DEBUG_BUS=y But if I run aplay: #aplay -vvv x.wav Playing WAVE 'x.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo Plug PCM: Direct Stream Mixing PCM Its setup is: stream : PLAYBACK access : RW_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 44100 exact rate : 44100 (44100/1) msbits : 16 buffer_size : 15876 period_size : 1764 period_time : 40000 tstamp_mode : NONE tstamp_type : MONOTONIC period_step : 1 avail_min : 1764 period_event : 0 start_threshold : 15876 stop_threshold : 15876 silence_threshold: 0 silence_size : 0 boundary : 2080899072 Hardware PCM card 0 'tlv320-audio-U' device 0 subdevice 0 Its setup is: stream : PLAYBACK access : MMAP_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 44100 exact rate : 44100 (44100/1) msbits : 16 buffer_size : 15876 period_size : 1764 period_time : 40000 tstamp_mode : ENABLE tstamp_type : MONOTONIC period_step : 1 avail_min : 1764 period_event : 0 start_threshold : 1 stop_threshold : 2080899072 silence_threshold: 0 silence_size : 2080899072 boundary : 2080899072 appl_ptr : 0 hw_ptr : 0 Max peak (3528 samples): 0x00000000 # 0% Max peak (3528 samples): 0x00000285 # 1% Max peak (3528 samples): 0x000003dd # 3% Max peak (3528 samples): 0x000004b8 # 3% Max peak (3528 samples): 0x00001739 #### 18% Max peak (3528 samples): 0x0000068d ## 5% Max peak (3528 samples): 0x0000058f # 4% Max peak (3528 samples): 0x00000534 # 4% Max peak (3528 samples): 0x000004a3 # 3% Then in /var/log/messages append some messages, like this: Dec 27 09:29:39 myd-y6ul14x14 user.debug kernel: i2c i2c-1: master_xfer[0] W, addr=0x18, len=2 and in I2C wire I see some pulses. And then aplay is locked. :( No pulses at SAI. Questions: 1) It problem may occur due to my error in DTS ? 2) snd_soc_write() / snd_soc_read() do call direct to i2c or more complex way ? For what reason can request not always reach i2c? 3) Any advice ? Thank you!

1 0

[alsa-devel] [PATCH 1/7] ASoC: Intel: common: Add quirk for PoV P1006W tablet
by Hans de Goede 26 Dec '18

26 Dec '18

The Point of View TAB-P1006W-232 (v1.0) tablet uses 10EC5640 as ACPI HID, but it has a rt5651 codec add a quirk for this. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- .../intel/common/soc-acpi-intel-byt-match.c | 35 +++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/common/soc-acpi-intel-byt-match.c b/sound/soc/intel/common/soc-acpi-intel-byt-match.c index 097dc06377ba..027dc27262b7 100644 --- a/sound/soc/intel/common/soc-acpi-intel-byt-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-byt-match.c @@ -21,6 +21,7 @@ static unsigned long byt_machine_id; #define BYT_THINKPAD_10 1 +#define BYT_POV_P1006W 2 static int byt_thinkpad10_quirk_cb(const struct dmi_system_id *id) { @@ -28,6 +29,11 @@ static int byt_thinkpad10_quirk_cb(const struct dmi_system_id *id) return 1; } +static int byt_pov_p1006w_quirk_cb(const struct dmi_system_id *id) +{ + byt_machine_id = BYT_POV_P1006W; + return 1; +} static const struct dmi_system_id byt_table[] = { { @@ -58,6 +64,17 @@ static const struct dmi_system_id byt_table[] = { DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), }, }, + { + /* Point of View mobii wintab p1006w (v1.0) */ + .callback = byt_pov_p1006w_quirk_cb, + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "BayTrail"), + /* Note 105b is Foxcon's USB/PCI vendor id */ + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "105B"), + DMI_EXACT_MATCH(DMI_BOARD_NAME, "0E57"), + }, + }, { } }; @@ -71,16 +88,30 @@ static struct snd_soc_acpi_mach byt_thinkpad_10 = { .asoc_plat_name = "sst-mfld-platform", }; +static struct snd_soc_acpi_mach byt_pov_p1006w = { + .id = "10EC5640", + .drv_name = "bytcr_rt5651", + .fw_filename = "intel/fw_sst_0f28.bin", + .board = "bytcr_rt5651", + .sof_fw_filename = "intel/sof-byt.ri", + .sof_tplg_filename = "intel/sof-byt-rt5651.tplg", + .asoc_plat_name = "sst-mfld-platform", +}; + static struct snd_soc_acpi_mach *byt_quirk(void *arg) { struct snd_soc_acpi_mach *mach = arg; dmi_check_system(byt_table); - if (byt_machine_id == BYT_THINKPAD_10) + switch (byt_machine_id) { + case BYT_THINKPAD_10: return &byt_thinkpad_10; - else + case BYT_POV_P1006W: + return &byt_pov_p1006w; + default: return mach; + } } struct snd_soc_acpi_mach snd_soc_acpi_intel_baytrail_legacy_machines[] = { -- 2.20.1

2 7

Re: [alsa-devel] [PATCH v3 08/11] ASoC: Intel: atom: Make PCI dependency explicit
by Pierre-Louis Bossart 26 Dec '18

26 Dec '18

On 12/23/18 5:25 PM, Sinan Kaya wrote: > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on > CONFIG_PCI set but this is not specified anywhere. Can you please share the .config that exposes this problem? This hasn't changed in a long time and I wonder why this pops up now. You have similar cases elsewhere, e.g. arch/x86/Kconfig config X86_INTEL_LPSS bool "Intel Low Power Subsystem Support" depends on X86 && ACPI select COMMON_CLK select PINCTRL select IOSF_MBI or for the MMC. config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" depends on MMC_SDHCI && ACPI select IOSF_MBI if X86 The use of IOSF_MBI is only for the Baytrail-CR detection and there are already in-flight patches to change the code and move it to a helper. My understanding is that for compilation you only need CONFIG_x86 since there are fall-back routines available in iosf_mbi.h Thanks! > > Signed-off-by: Sinan Kaya <okaya(a)kernel.org> > --- > sound/soc/intel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index 2fd1b61e8331..b0764b2fe001 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI > config SND_SST_ATOM_HIFI2_PLATFORM_ACPI > tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" > default ACPI > - depends on X86 && ACPI > + depends on X86 && ACPI && PCI > select SND_SST_IPC_ACPI > select SND_SST_ATOM_HIFI2_PLATFORM > select SND_SOC_ACPI_INTEL_MATCH

1 0

[alsa-devel] [PATCH v2 1/3] mfd: cros_ec: Add commands to control codec
by Cheng-Yi Chiang 26 Dec '18

26 Dec '18

Add EC host commands to control codec on EC. Signed-off-by: Cheng-Yi Chiang <cychiang(a)chromium.org> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> --- Note: This patch is merged to mfd tree for-mfd-next branch already. But this is still needed on sound tree for-next branch in order to compile codec driver. include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+) diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h index 9a9631f0559e2..fc91082d4c357 100644 --- a/include/linux/mfd/cros_ec_commands.h +++ b/include/linux/mfd/cros_ec_commands.h @@ -2790,6 +2790,100 @@ struct ec_response_battery_vendor_param { uint32_t value; } __packed; +/*****************************************************************************/ +/* Commands for I2S recording on audio codec. */ + +#define EC_CMD_CODEC_I2S 0x00BC + +enum ec_codec_i2s_subcmd { + EC_CODEC_SET_SAMPLE_DEPTH = 0x0, + EC_CODEC_SET_GAIN = 0x1, + EC_CODEC_GET_GAIN = 0x2, + EC_CODEC_I2S_ENABLE = 0x3, + EC_CODEC_I2S_SET_CONFIG = 0x4, + EC_CODEC_I2S_SET_TDM_CONFIG = 0x5, + EC_CODEC_I2S_SET_BCLK = 0x6, +}; + +enum ec_sample_depth_value { + EC_CODEC_SAMPLE_DEPTH_16 = 0, + EC_CODEC_SAMPLE_DEPTH_24 = 1, +}; + +enum ec_i2s_config { + EC_DAI_FMT_I2S = 0, + EC_DAI_FMT_RIGHT_J = 1, + EC_DAI_FMT_LEFT_J = 2, + EC_DAI_FMT_PCM_A = 3, + EC_DAI_FMT_PCM_B = 4, + EC_DAI_FMT_PCM_TDM = 5, +}; + +struct ec_param_codec_i2s { + /* + * enum ec_codec_i2s_subcmd + */ + uint8_t cmd; + union { + /* + * EC_CODEC_SET_SAMPLE_DEPTH + * Value should be one of ec_sample_depth_value. + */ + uint8_t depth; + + /* + * EC_CODEC_SET_GAIN + * Value should be 0~43 for both channels. + */ + struct ec_param_codec_i2s_set_gain { + uint8_t left; + uint8_t right; + } __packed gain; + + /* + * EC_CODEC_I2S_ENABLE + * 1 to enable, 0 to disable. + */ + uint8_t i2s_enable; + + /* + * EC_CODEC_I2S_SET_COFNIG + * Value should be one of ec_i2s_config. + */ + uint8_t i2s_config; + + /* + * EC_CODEC_I2S_SET_TDM_CONFIG + * Value should be one of ec_i2s_config. + */ + struct ec_param_codec_i2s_tdm { + /* + * 0 to 496 + */ + int16_t ch0_delay; + /* + * -1 to 496 + */ + int16_t ch1_delay; + uint8_t adjacent_to_ch0; + uint8_t adjacent_to_ch1; + } __packed tdm_param; + + /* + * EC_CODEC_I2S_SET_BCLK + */ + uint32_t bclk; + }; +} __packed; + +/* + * For subcommand EC_CODEC_GET_GAIN. + */ +struct ec_response_codec_gain { + uint8_t left; + uint8_t right; +} __packed; + /*****************************************************************************/ /* System commands */ -- 2.20.1.415.g653613c723-goog

2 6

[alsa-devel] fixing seq_midi: MIDI output buffer overrun
by Adam Goode 26 Dec '18

26 Dec '18

Hi, I am investigating why Chromium can't reliably send sysex messages on Linux. (See https://bugs.chromium.org/p/chromium/issues/detail?id=917708.) I've seen the message at https://alsa-devel.alsa-project.narkive.com/6w35hffF/sysex-overflow-when-us… Chromium does use seq and we do need sysex to be reliable since vendors such as Novation and Yamaha use Web MIDI to interface with hardware. The code in question predates git history (2005). It's event_process_midi() and dump_midi() in seq_midi.c. I see that dump_midi() returns either ENOMEM or EINVAL under certain conditions, but the only caller (event_process_midi()) throws these errors away and always returns 0 if everything but dump_midi() succeeds. A few questions: 1. Can I change dump_midi to block instead of return ENOMEM if I don't use SND_SEQ_NONBLOCK in snd_seq_open? 2. What should be returned in NONBLOCK mode? Probably EAGAIN? 3. The general blocking behavior of seq seems inconsistent. If I am using snd_seq_ev_set_direct, then I get EAGAIN even with a blocking open. Should I expect blocking from the pool, or only if using a queue? 4. Is there any obvious fix I am overlooking? Thanks, Adam

2 3

Re: [alsa-devel] [PATCH -next] ASoC: Intel: remove set but not used variable 'stage_type'
by kbuild test robot 25 Dec '18

25 Dec '18

Hi YueHaibing, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20181224] url: https://github.com/0day-ci/linux/commits/YueHaibing/ASoC-Intel-remove-set-b… config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): arch/x86/kvm/vmx/nested.c:58:6: warning: symbol 'init_vmcs_shadow_fields' was not declared. Should it be static? arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (110011 becomes 11) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100790 becomes 790) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100790 becomes 790) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a000a becomes a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100490 becomes 490) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100310 becomes 310) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80a08 becomes a08) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80688 becomes 688) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80608 becomes 608) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80108 becomes 108) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80388 becomes 388) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100390 becomes 390) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80208 becomes 208) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80288 becomes 288) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a000a becomes a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100010 becomes 10) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80488 becomes 488) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100710 becomes 710) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100090 becomes 90) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20402 becomes 402) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80508 becomes 508) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80b88 becomes b88) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100790 becomes 790) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100490 becomes 490) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100310 becomes 310) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20482 becomes 482) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100590 becomes 590) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100610 becomes 610) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100690 becomes 690) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120912 becomes 912) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100590 becomes 590) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20002 becomes 2) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20082 becomes 82) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20102 becomes 102) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20182 becomes 182) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20202 becomes 202) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20282 becomes 282) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20302 becomes 302) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (20382 becomes 382) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120012 becomes 12) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120092 becomes 92) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120112 becomes 112) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120192 becomes 192) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120212 becomes 212) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120292 becomes 292) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120312 becomes 312) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120392 becomes 392) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120412 becomes 412) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120492 becomes 492) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120512 becomes 512) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120692 becomes 692) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120712 becomes 712) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120792 becomes 792) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120812 becomes 812) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120892 becomes 892) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a019a becomes 19a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a021a becomes 21a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a029a becomes 29a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a031a becomes 31a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a039a becomes 39a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a041a becomes 41a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a049a becomes 49a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a051a becomes 51a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a059a becomes 59a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a061a becomes 61a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120a92 becomes a92) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a089a becomes 89a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a091a becomes 91a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a099a becomes 99a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a028a becomes 28a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a030a becomes 30a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a038a becomes 38a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a040a becomes 40a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80b08 becomes b08) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100190 becomes 190) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100210 becomes 210) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80708 becomes 708) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80788 becomes 788) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80808 becomes 808) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80888 becomes 888) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100410 becomes 410) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100510 becomes 510) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120592 becomes 592) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (120612 becomes 612) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a008a becomes 8a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a008a becomes 8a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (180018 becomes 18) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a010a becomes 10a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (a010a becomes 10a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80408 becomes 408) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (80c88 becomes c88) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (180118 becomes 118) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (180198 becomes 198) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100410 becomes 410) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (100510 becomes 510) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1a081a becomes 81a) arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1b009b becomes 9b) >> arch/x86/kvm/vmx/evmcs.h:80:30: warning: cast truncates bits from constant value (1b011b becomes 11b) arch/x86/kvm/vmx/evmcs.h:80:30: warning: too many warnings vim +80 arch/x86/kvm/vmx/evmcs.h 75edce8a arch/x86/kvm/vmx/evmcs.h Sean Christopherson 2018-12-03 76 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 77 static __always_inline int get_evmcs_offset(unsigned long field, 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 78 u16 *clean_field) 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 79 { 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 @80 unsigned int index = ROL16(field, 6); 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 81 const struct evmcs_field *evmcs_field; 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 82 75edce8a arch/x86/kvm/vmx/evmcs.h Sean Christopherson 2018-12-03 83 if (unlikely(index >= nr_evmcs_1_fields)) { 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 84 WARN_ONCE(1, "KVM: accessing unsupported EVMCS field %lx\n", 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 85 field); 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 86 return -ENOENT; 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 87 } 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 88 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 89 evmcs_field = &vmcs_field_to_evmcs_1[index]; 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 90 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 91 if (clean_field) 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 92 *clean_field = evmcs_field->clean_field; 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 93 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 94 return evmcs_field->offset; 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 95 } 773e8a04 arch/x86/kvm/vmx_evmcs.h Vitaly Kuznetsov 2018-03-20 96 :::::: The code at line 80 was first introduced by commit :::::: 773e8a0425c923bc02668a2d6534a5ef5a43cc69 x86/kvm: use Enlightened VMCS when running on Hyper-V :::::: TO: Vitaly Kuznetsov <vkuznets(a)redhat.com> :::::: CC: Radim Krčmář <rkrcmar(a)redhat.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] Message from ALSA found in my kernel logs
by Philippe Lefèvre 24 Dec '18

24 Dec '18

Sorry, I forgot to join my file. Philippe

1 0

[alsa-devel] Message from ALSA found in my kernel logs
by Philippe Lefèvre 24 Dec '18

24 Dec '18

Hi, I found this message into my kernel logs this morning and it is said that I shoud report it to ALSA developers. Sorry, it is French. I'm going to try to translate it : 1800 Dec 24 08:22:20 phlsys pulseaudio[2291]: ALSA nous a réveillé pour écrire de nouvelles données à partir du périphérique, mais il n'y avait en fait rien à écrire ! 1801 Dec 24 08:22:20 phlsys pulseaudio[2291]: Il s'agit très probablement d'un bogue dans le pilote ALSA « snd_usb_audio ». Veuillez rapporter ce problème aux développeurs d'ALSA. 1802 Dec 24 08:22:20 phlsys pulseaudio[2291]: Nous avons été réveillés avec POLLOUT actif, cependant un snd_pcm_avail() ultérieur a retourné 0 ou une autre valeur < min_avail. 1800 ... ALSA wake us up to write datas from the dev but there was nothing to write ! 1801 ... This is probably a bug within the ALSA driver "snb_usb_audio". Please report this issue to the ALSA developers. 1802 ... We were waked up with an active POLLOUT however a previous snd_pcm_avail() returned 0 or an other value < min_avail. I'm running 3.16.0-7-amd64 #1 SMP Debian 3.16.59-1 (2018-10-03) x86_64 GNU/Linux Please find attached my hardawre list. While I'm at it, I also tried to register to www.*alsa*-project.org without success because I might be able to bring my computer skills to that project even if my skills regarding any sound server are very low. The box #wpCaptchaWord (@ http://www.alsa-project.org/main/index.php?title=Special:UserLogin&type=sig…) remains empty. (My browser (Firefox Dev) do not block any cookie neither from www.*alsa*-project.org nor accounts.google.com) Best regards ... and happy Christmas ;-) Philippe

1 0