November 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: wm8996: fix small typo
by lshua312 02 Nov '18

02 Nov '18

From e9b923690675ca8fa883fd25dcead5b457856735 Mon Sep 17 00:00:00 2001 From: liush <liush(a)allwinnertech.com> Date: Fri, 2 Nov 2018 08:57:00 +0800 Subject: [PATCH] ASoC: wm8996: fix small typo atleast -> at least Change-Id: Icc970b438166daef13518b7d1a62b13eb8752f5f Signed-off-by: liush <liush(a)allwinnertech.com> --- sound/soc/codecs/wm8996.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c index 8affa49..d039835 100644 --- a/sound/soc/codecs/wm8996.c +++ b/sound/soc/codecs/wm8996.c @@ -2109,7 +2109,7 @@ static int wm8996_set_fll(struct snd_soc_codec *codec, int fll_id, int source, if (i2c->irq) timeout *= 10; else - /* ensure timeout of atleast 1 jiffies */ + /* ensure timeout of at least 1 jiffies */ timeout = timeout/2 ? : 1; for (retry = 0; retry < 10; retry++) { -- 1.9.1

1 0

[alsa-devel] [PATCH 0/7] ASoC: Intel: cleanups
by Pierre-Louis Bossart 01 Nov '18

01 Nov '18

This patchset contain 4 different cleanups: a) change of pdata definition to avoid using SST-specific structures and allow for machine driver reuse w/ SOF. No new features, just different data structures. b) removal of remaining GFP_ATOMIC usages c) Cleanup of machine driver tables for APL (missing SOF information and quirk for APL RVP/LeafHill CRB boards). These boards are used outside of Intel so it's worth sharing the fixes for the general public. d) typo Bard liao (1): ASoC: Intel: common: add SOF information for APL RVP Pierre-Louis Bossart (6): ASoC: acpi: define common interface for machine driver configuration ASoC: Intel: use standard interface for Hdaudio machine driver ASoC: Intel: use standard interface for Atom machine drivers ASoC: Intel: boards: fix Skylake typo ASoC: Intel: remove GFP_ATOMIC, use GFP_KERNEL ASoC: Intel: common: add quirk for APL RVP boards include/sound/soc-acpi.h | 14 +++++++ sound/soc/intel/atom/sst/sst_acpi.c | 4 ++ sound/soc/intel/atom/sst/sst_pvt.c | 4 +- sound/soc/intel/boards/bytcr_rt5640.c | 6 +-- sound/soc/intel/boards/bytcr_rt5651.c | 6 +-- sound/soc/intel/boards/cht_bsw_rt5645.c | 6 +-- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 +- sound/soc/intel/boards/glk_rt5682_max98357a.c | 2 +- sound/soc/intel/boards/kbl_da7219_max98927.c | 8 ++-- sound/soc/intel/boards/kbl_rt5663_max98927.c | 4 +- sound/soc/intel/boards/skl_hda_dsp_generic.c | 22 +++++------ .../soc/intel/boards/skl_nau88l25_max98357a.c | 4 +- sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 4 +- .../intel/common/soc-acpi-intel-bxt-match.c | 38 +++++++++++++++++++ sound/soc/intel/skylake/skl.c | 10 ++--- 15 files changed, 87 insertions(+), 47 deletions(-) -- 2.17.1

3 11

[alsa-devel] [USB-Audio - PX USB, playback] snd-usb-audio: probe of 2-3:1.0 failed with error -22 after kernel upgrade
by Mutz Heuer 01 Nov '18

01 Nov '18

USB-Audio Connection on Bowers & Wilkens PX Bluetooth Headphones started working when upgrading kernel from 4.13 to 4.15 series. Then it suddenly stopped working again on newer kernels. The bug report has been generated on the latest working mainline kernel 4.15.7. All newer kernels have some usb quirks in place, which should fix the playback sample rates to 48 kHz. The quirk seems not to be working correctly - it seems to hinder the audio system to recognize the USB-device as a sound device. The Headphones work on kernels before 4,15.7 when manually configuring pulseaudio to a default samplerate of 48 kHz. PX Headphones are on the newest firmware level. See https://patchwork.kernel.org/patch/10265345/. Dropping that patch and recompiling the kernel leads to a situation where alsa and pulseaudio seem to to be working again. Adding default-sample-rate = 48000 to /etc/pulse/daemon.conf leads to working headphones. Maybe the patch has to be adjusted to newer firmware? A quirk seems to be really necessary to avoid the specific patch to daemon.conf. More details can be found in https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773697 What would be the best way to proceed?

2 4

[alsa-devel] [PATCH 3/3] ALSA:hda: add support for Huawei WMI MicMute LED
by Ayman Bagabas 01 Nov '18

01 Nov '18

Some of Huawei laptops come with a LED in the mic mute key. This patch enables and disable this LED when the internal microphone status is changed. Signed-off-by: Ayman Bagabas <ayman.bagabas(a)gmail.com> --- include/linux/huawei_wmi.h | 7 ++++ sound/pci/hda/huawei_wmi_helper.c | 66 +++++++++++++++++++++++++++++++ sound/pci/hda/patch_realtek.c | 12 ++++++ 3 files changed, 85 insertions(+) create mode 100644 include/linux/huawei_wmi.h create mode 100644 sound/pci/hda/huawei_wmi_helper.c diff --git a/include/linux/huawei_wmi.h b/include/linux/huawei_wmi.h new file mode 100644 index 000000000000..69b656c5029b --- /dev/null +++ b/include/linux/huawei_wmi.h @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __HUAWEI_WMI_H__ +#define __HUAWEI_WMI_H__ + +int huawei_wmi_micmute_led_set(bool on); + +#endif diff --git a/sound/pci/hda/huawei_wmi_helper.c b/sound/pci/hda/huawei_wmi_helper.c new file mode 100644 index 000000000000..57256f51fd88 --- /dev/null +++ b/sound/pci/hda/huawei_wmi_helper.c @@ -0,0 +1,66 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Helper functions for Huawei WMI Mic Mute LED; + * to be included from codec driver + */ + +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) +#include <linux/huawei_wmi.h> + +static int (*huawei_wmi_micmute_led_set_func)(bool); + +static void update_huawei_wmi_micmute_led(struct hda_codec *codec, + struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + if (!ucontrol || !huawei_wmi_micmute_led_set_func) + return; + if (strcmp("Capture Switch", ucontrol->id.name) == 0 && ucontrol->id.index == 0) { + /* TODO: How do I verify if it's a mono or stereo here? */ + bool val = ucontrol->value.integer.value[0] || ucontrol->value.integer.value[1]; + huawei_wmi_micmute_led_set_func(!val); + } +} + +static void alc_fixup_huawei_wmi(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct hda_gen_spec *spec = codec->spec; + bool removefunc = false; + + codec_info(codec, "In alc_fixup_huawei_wmi\n"); + + if (action == HDA_FIXUP_ACT_PROBE) { + if (!huawei_wmi_micmute_led_set_func) + huawei_wmi_micmute_led_set_func = symbol_request(huawei_wmi_micmute_led_set); + if (!huawei_wmi_micmute_led_set_func) { + codec_warn(codec, "Failed to find huawei_wmi symbol huawei_wmi_micmute_led_set\n"); + return; + } + + removefunc = true; + if (huawei_wmi_micmute_led_set_func(false) >= 0) { + if (spec->num_adc_nids > 1 && !spec->dyn_adc_switch) + codec_dbg(codec, "Skipping micmute LED control due to several ADCs"); + else { + spec->cap_sync_hook = update_huawei_wmi_micmute_led; + removefunc = false; + } + } + codec_info(codec, "In alc_fixup_huawei_wmi IF\n"); + + } + + if (huawei_wmi_micmute_led_set_func && (action == HDA_FIXUP_ACT_FREE || removefunc)) { + symbol_put(huawei_wmi_micmute_led_set); + huawei_wmi_micmute_led_set_func = NULL; + } +} + +#else + +static void hda_fixup_huawei_wmi(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ +} + +#endif diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4f7a39c7883c..0dab00c0df50 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5371,6 +5371,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec, /* for dell wmi mic mute led */ #include "dell_wmi_helper.c" +/* for huawei wmi mic mute led */ +#include "huawei_wmi_helper.c" + /* for alc295_fixup_hp_top_speakers */ #include "hp_x360_helper.c" @@ -5494,6 +5497,7 @@ enum { ALC255_FIXUP_DUMMY_LINEOUT_VERB, ALC255_FIXUP_DELL_HEADSET_MIC, ALC256_FIXUP_HUAWEI_MBXP_PINS, + ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED, ALC295_FIXUP_HP_X360, ALC221_FIXUP_HP_HEADSET_MIC, }; @@ -6348,6 +6352,10 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_huawei_wmi, + }, [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -6363,6 +6371,8 @@ static const struct hda_fixup alc269_fixups[] = { {0x21, 0x04211020}, { }, }, + .chained = true, + .chain_id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED }, [ALC295_FIXUP_HP_X360] = { .type = HDA_FIXUP_FUNC, @@ -6610,6 +6620,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS), + SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED), SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD), SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */ @@ -6775,6 +6786,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {.id = ALC274_FIXUP_DELL_AIO_LINEOUT_VERB, .name = "alc274-dell-aio"}, {.id = ALC255_FIXUP_DUMMY_LINEOUT_VERB, .name = "alc255-dummy-lineout"}, {.id = ALC255_FIXUP_DELL_HEADSET_MIC, .name = "alc255-dell-headset"}, + {.id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED, .name = "alc256-huawei-micmute"}, {.id = ALC295_FIXUP_HP_X360, .name = "alc295-hp-x360"}, {} }; -- 2.17.2

2 2

[alsa-devel] [PATCH 2/3] ALSA:hda: fix front speakers on Huawei MBXP.
by Ayman Bagabas 01 Nov '18

01 Nov '18

This patch enables the front speakers on Huawei Matebook X Pro laptops. These laptops come with Dolby Atmos sound system and these pins configuration enables the front speakers. Signed-off-by: Ayman Bagabas <ayman.bagabas(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3ac7ba9b342d..4f7a39c7883c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5493,6 +5493,7 @@ enum { ALC298_FIXUP_TPT470_DOCK, ALC255_FIXUP_DUMMY_LINEOUT_VERB, ALC255_FIXUP_DELL_HEADSET_MIC, + ALC256_FIXUP_HUAWEI_MBXP_PINS, ALC295_FIXUP_HP_X360, ALC221_FIXUP_HP_HEADSET_MIC, }; @@ -6347,6 +6348,22 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + {0x12, 0x90a60130}, + {0x13, 0x40000000}, + {0x14, 0x90170110}, + {0x18, 0x411111f0}, + {0x19, 0x04a11040}, + {0x1a, 0x411111f0}, + {0x1b, 0x90170112}, + {0x1d, 0x40759a05}, + {0x1e, 0x411111f0}, + {0x21, 0x04211020}, + { }, + }, + }, [ALC295_FIXUP_HP_X360] = { .type = HDA_FIXUP_FUNC, .v.func = alc295_fixup_hp_top_speakers, @@ -6592,6 +6609,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), + SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS), SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD), SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */ -- 2.17.2

3 2