January 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] WARNING in snd_pcm_hw_param_last
by syzbot 02 Jan '18

02 Jan '18

Hello, syzkaller hit the following crash on 30a7acd573899fd8b8ac39236eff6468b195ac7d git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. syzkaller reproducer is attached. See https://goo.gl/kgGztJ for information about syzkaller reproducers IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+a8d726b19492f85fdb50(a)syzkaller.appspotmail.com It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. WARNING: CPU: 1 PID: 4856 at sound/core/pcm_lib.c:1681 snd_pcm_hw_param_last+0x28b/0x670 sound/core/pcm_lib.c:1681 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 4856 Comm: syz-executor7 Not tainted 4.15.0-rc6+ #245 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x194/0x257 lib/dump_stack.c:53 panic+0x1e4/0x41c kernel/panic.c:183 __warn+0x1dc/0x200 kernel/panic.c:547 report_bug+0x211/0x2d0 lib/bug.c:184 fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178 fixup_bug arch/x86/kernel/traps.c:247 [inline] do_error_trap+0x2d7/0x3e0 arch/x86/kernel/traps.c:296 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315 invalid_op+0x22/0x40 arch/x86/entry/entry_64.S:1079 RIP: 0010:snd_pcm_hw_param_last+0x28b/0x670 sound/core/pcm_lib.c:1681 RSP: 0018:ffff8801d5e07498 EFLAGS: 00010293 RAX: ffff8801d5fe2080 RBX: ffff8801d5587200 RCX: ffffffff841bb75b RDX: 0000000000000000 RSI: 00000000ffffffea RDI: ffffed003abc0e88 RBP: ffff8801d5e074e0 R08: 0000000000000001 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 000000000000000a R13: 00000000ffffffea R14: 0000000000000002 R15: 0000000000000400 snd_pcm_hw_param_near.constprop.27+0x6f5/0x9a0 sound/core/oss/pcm_oss.c:455 snd_pcm_oss_change_params+0xb3d/0x3720 sound/core/oss/pcm_oss.c:878 snd_pcm_oss_get_active_substream+0x10c/0x150 sound/core/oss/pcm_oss.c:1088 snd_pcm_oss_get_channels sound/core/oss/pcm_oss.c:1708 [inline] snd_pcm_oss_set_channels+0x23e/0x3a0 sound/core/oss/pcm_oss.c:1700 snd_pcm_oss_ioctl+0x1dcc/0x39f0 sound/core/oss/pcm_oss.c:2514 vfs_ioctl fs/ioctl.c:46 [inline] do_vfs_ioctl+0x1b1/0x1520 fs/ioctl.c:686 SYSC_ioctl fs/ioctl.c:701 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692 entry_SYSCALL_64_fastpath+0x23/0x9a RIP: 0033:0x452ac9 RSP: 002b:00007fa5a61bec58 EFLAGS: 00000212 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 000000000071bf58 RCX: 0000000000452ac9 RDX: 0000000020004ff8 RSI: 00800000c0045006 RDI: 0000000000000003 RBP: 00000000000000ef R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000212 R12: 00000000006ef708 R13: 00000000ffffffff R14: 00007fa5a61bf6d4 R15: 0000000000000002 Dumping ftrace buffer: (ftrace buffer empty) Kernel Offset: disabled Rebooting in 86400 seconds.. --- This bug is generated by a dumb bot. It may contain errors. See https://goo.gl/tpsmEJ for details. Direct all questions to syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. If you forgot to add the Reported-by tag, once the fix for this bug is merged into any tree, please reply to this email with: #syz fix: exact-commit-title If you want to test a patch for this bug, please reply with: #syz test: git://repo/address.git branch and provide the patch inline or as an attachment. To mark this as a duplicate of another syzbot report, please reply with: #syz dup: exact-subject-of-another-report If it's a one-off invalid bug report, please reply with: #syz invalid Note: if the crash happens again, it will cause creation of a new bug report. Note: all commands must start from beginning of the line in the email body.

1 1

[alsa-devel] [RFC v4 0/3] Enable HDA Codec support on Intel Platforms (Series1)
by Rakesh Ughreja 02 Jan '18

02 Jan '18

Enhanced HD Audio capabilities introduced in HD Audio controllers are added in backward compatible way i.e. it does not change the behavior of the controller with respect to HDA Bus and HDA devices. Since there is no change in the hardware with respect to the HDA bus and HDA device it is more appropriate to represent the same in software as well. In order to align software representation with hardware it makes more sense to have common data structures across device, bus and driver for both enhanced HDA controllers and legacy HDA controllers. This patch series removes the hdac_ext_device structure, hdac_ext_bus and hdac_ext_driver data structures so that legacy and enhanced HDaudio capabilities can be handled in a backwards-compatible way without separate definitions. Once this clean-up is complete, additional patches will allow for HDaudio codec support in an ASoC framework without the need to develop new codec drivers, thereby enabling the use of the Intel DSP on more platforms (currently limited to hdmi). Changes in v4: - No changes in this series except rebase as there were no comments. Changes in v3: - No changes in this series except rebase as there were no comments. Changes in v2: - First three patches from v1 are merged so not included in this series. - No changes in this series except rebase as there were no comments. Rakesh Ughreja (3): ALSA: hdac: Remove usage of struct hdac_ext_device and use hdac_device instead ALSA: hdac: Remove usage of struct hdac_ext_bus and use hdac_bus instead ALSA: hdac: Remove usage of struct hdac_ext_driver, use hdac_driver instead include/sound/hdaudio.h | 21 ++ include/sound/hdaudio_ext.h | 119 +++------- sound/hda/ext/hdac_ext_bus.c | 76 +++--- sound/hda/ext/hdac_ext_controller.c | 55 +++-- sound/hda/ext/hdac_ext_stream.c | 104 ++++----- sound/soc/codecs/hdac_hdmi.c | 415 ++++++++++++++++----------------- sound/soc/intel/skylake/skl-messages.c | 50 ++-- sound/soc/intel/skylake/skl-nhlt.c | 8 +- sound/soc/intel/skylake/skl-pcm.c | 112 +++++---- sound/soc/intel/skylake/skl-topology.c | 18 +- sound/soc/intel/skylake/skl-topology.h | 6 +- sound/soc/intel/skylake/skl.c | 176 +++++++------- sound/soc/intel/skylake/skl.h | 7 +- 13 files changed, 521 insertions(+), 646 deletions(-) -- 2.7.4

3 5

[alsa-devel] [PATCH -next] slimbus: qcom: Make some local functions static
by Wei Yongjun 02 Jan '18

02 Jan '18

Fixes the following sparse warnings: drivers/slimbus/qcom-ctrl.c:151:6: warning: symbol 'slim_ack_txn' was not declared. Should it be static? drivers/slimbus/qcom-ctrl.c:304:6: warning: symbol 'slim_alloc_txbuf' was not declared. Should it be static? Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- drivers/slimbus/qcom-ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index 35ad70d..600f62d 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -148,7 +148,7 @@ static void *slim_alloc_rxbuf(struct qcom_slim_ctrl *ctrl) return ctrl->rx.base + (idx * ctrl->rx.sl_sz); } -void slim_ack_txn(struct qcom_slim_ctrl *ctrl, int err) +static void slim_ack_txn(struct qcom_slim_ctrl *ctrl, int err) { struct completion *comp; unsigned long flags; @@ -301,8 +301,8 @@ static int qcom_clk_pause_wakeup(struct slim_controller *sctrl) return 0; } -void *slim_alloc_txbuf(struct qcom_slim_ctrl *ctrl, struct slim_msg_txn *txn, - struct completion *done) +static void *slim_alloc_txbuf(struct qcom_slim_ctrl *ctrl, + struct slim_msg_txn *txn, struct completion *done) { unsigned long flags; int idx;

1 0

[alsa-devel] [PATCH -next] slimbus: qcom: Fix return value check in qcom_slim_probe()
by Wei Yongjun 02 Jan '18

02 Jan '18

In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver") Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- drivers/slimbus/qcom-ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index 35ad70d..96fefd6 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -530,9 +530,9 @@ static int qcom_slim_probe(struct platform_device *pdev) slim_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl"); ctrl->base = devm_ioremap_resource(ctrl->dev, slim_mem); - if (!ctrl->base) { + if (IS_ERR(ctrl->base)) { dev_err(&pdev->dev, "IOremap failed\n"); - return -ENOMEM; + return PTR_ERR(ctrl->base); } sctrl->set_laddr = qcom_set_laddr;

1 0

[alsa-devel] [PATCH -next] slimbus: Fix missing unlock on error in slim_msg_response()
by Wei Yongjun 02 Jan '18

02 Jan '18

Add the missing unlock before return from function slim_msg_response() in the error handling case. Fixes: afbdcc7c384b ("slimbus: Add messaging APIs to slimbus framework") Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 755462a..a1328ac 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -38,6 +38,7 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len) if (msg == NULL || msg->rbuf == NULL) { dev_err(ctrl->dev, "Got response to invalid TID:%d, len:%d\n", tid, len); + spin_unlock_irqrestore(&ctrl->txn_lock, flags); return; }

1 0

[alsa-devel] [PATCH -next] slimbus: Use GFP_ATOMIC under spin lock
by Wei Yongjun 02 Jan '18

02 Jan '18

A spin lock is taken here so we should use GFP_ATOMIC. Fixes: afbdcc7c384b ("slimbus: Add messaging APIs to slimbus framework") Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 755462a..ef54ea1 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -98,7 +98,7 @@ int slim_do_transfer(struct slim_controller *ctrl, struct slim_msg_txn *txn) if (need_tid) { spin_lock_irqsave(&ctrl->txn_lock, flags); tid = idr_alloc(&ctrl->tid_idr, txn, 0, - SLIM_MAX_TIDS, GFP_KERNEL); + SLIM_MAX_TIDS, GFP_ATOMIC); txn->tid = tid; if (!txn->msg->comp)

1 0